Geronimo :: Deploy :: Hot Deployer

Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
4	0	0	244

Rules

Rules	Violations	Severity
PackageHtml	1	Error
NewlineAtEndOfFile	0	Error
Translation	0	Error
JavadocMethod	75	Error
JavadocType	3	Error
JavadocVariable	34	Error
JavadocStyle	2	Error
ConstantName	2	Error
LocalFinalVariableName	0	Error
LocalVariableName	0	Error
MemberName	0	Error
MethodName	0	Error
PackageName	0	Error
ParameterName	0	Error
StaticVariableName	3	Error
TypeName	0	Error
Header headerFile: `"/home/anthill/anthill3/agent/var/jobs/projects/Geronimo_Server/modules/geronimo-hot-deploy/target/checkstyle-header.txt"`	3	Error
AvoidStarImport	0	Error
IllegalImport	0	Error
RedundantImport	0	Error
UnusedImports	0	Error
FileLength	0	Error
LineLength max: `"120"`	17	Error
MethodLength	0	Error
ParameterNumber	0	Error
EmptyForIteratorPad	0	Error
NoWhitespaceAfter	0	Error
NoWhitespaceBefore	0	Error
OperatorWrap	3	Error
ParenPad	0	Error
TypecastParenPad	0	Error
TabCharacter	0	Error
WhitespaceAfter	0	Error
WhitespaceAround	24	Error
ModifierOrder	0	Error
RedundantModifier	2	Error
AvoidNestedBlocks	0	Error
EmptyBlock	0	Error
LeftCurly	0	Error
NeedBraces	4	Error
RightCurly	0	Error
AvoidInlineConditionals	12	Error
DoubleCheckedLocking	0	Error
EmptyStatement	0	Error
EqualsHashCode	0	Error
HiddenField ignoreConstructorParameter: `"true"` ignoreSetter: `"true"`	0	Error
IllegalInstantiation	0	Error
InnerAssignment	0	Error
MagicNumber	12	Error
MissingSwitchDefault	0	Error
RedundantThrows	0	Error
SimplifyBooleanExpression	0	Error
SimplifyBooleanReturn	0	Error
FinalClass	0	Error
HideUtilityClassConstructor	0	Error
InterfaceIsType	0	Error
VisibilityModifier	0	Error
ArrayTypeStyle	0	Error
FinalParameters	47	Error
GenericIllegalRegexp message: `"Line has trailing spaces."` format: `"\s+$"`	0	Error
TodoComment	0	Error
UpperEll	0	Error

Files

Files	I	W	E
org/apache/geronimo/deployment/hot/DirectoryMonitor.java	0	0	124
org/apache/geronimo/deployment/hot/package.html	0	0	1
org/apache/geronimo/deployment/hot/HotDeployer.java	0	0	6
org/apache/geronimo/deployment/hot/DirectoryHotDeployer.java	0	0	113

Details

org/apache/geronimo/deployment/hot/DirectoryMonitor.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	47
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	47
	Missing a Javadoc comment.	49
	Expected an @return tag.	55
	Expected @param tag for 'file'.	64
	Expected @param tag for 'configId'.	64
	Expected @param tag for 'file'.	73
	Expected @param tag for 'configId'.	73
	Expected @param tag for 'file'.	89
	Expected @param tag for 'configId'.	89
	Expected @param tag for 'file'.	98
	Expected @param tag for 'file'.	104
	Expected @param tag for 'configId'.	104
	Missing a Javadoc comment.	106
	Missing a Javadoc comment.	109
	Missing a Javadoc comment.	110
	Missing a Javadoc comment.	111
	Missing a Javadoc comment.	112
	Missing a Javadoc comment.	113
	Missing a Javadoc comment.	114
	Missing a Javadoc comment.	116
	Parameter directory should be final.	116
	Parameter listener should be final.	116
	Parameter pollIntervalMillis should be final.	116
	Missing a Javadoc comment.	122
	Missing a Javadoc comment.	126
	Parameter pollIntervalMillis should be final.	126
	Missing a Javadoc comment.	130
	Missing a Javadoc comment.	134
	Parameter listener should be final.	134
	Missing a Javadoc comment.	138
	Parameter directory should be final.	147
	Expected @param tag for 'directory'.	147
	Missing a Javadoc comment.	154
	Missing a Javadoc comment.	158
	Missing a Javadoc comment.	162
	Parameter id should be final.	162
	'+' is not preceded with whitespace.	163
	'+' is not followed by whitespace.	163
	'if' is not followed by whitespace.	164
	'synchronized' is not followed by whitespace.	171
	'if' is not followed by whitespace.	176
	'if' is not followed by whitespace.	178
	'+' is not preceded with whitespace.	179
	'+' is not followed by whitespace.	179
	'if' is not followed by whitespace.	180
	'+' is not preceded with whitespace.	181
	'+' is not followed by whitespace.	181
	Missing a Javadoc comment.	190
	Missing a Javadoc comment.	219
	Avoid inline conditionals.	227
	Line is longer than 120 characters.	235
	'+' is not preceded with whitespace.	235
	'+' is not followed by whitespace.	235
	'+' is not preceded with whitespace.	235
	'+' is not followed by whitespace.	235
	'+' is not preceded with whitespace.	235
	'+' is not followed by whitespace.	235
	'+' is not preceded with whitespace.	235
	'+' is not followed by whitespace.	235
	'+' is not preceded with whitespace.	235
	'+' is not followed by whitespace.	235
	Avoid inline conditionals.	263
	'if' is not followed by whitespace.	282
	Missing a Javadoc comment.	347
	Parameter action should be final.	347
	Missing a Javadoc comment.	355
	Parameter module should be final.	355
	Line is longer than 120 characters.	363
	Avoid inline conditionals.	368
	Expected an @return tag.	378
	Parameter dir should be final.	378
	Expected @param tag for 'dir'.	378
	Missing a Javadoc comment.	385
	Parameter dir should be final.	385
	Missing a Javadoc comment.	406
	Parameter child should be final.	406
	Missing a Javadoc comment.	413
	Missing a Javadoc comment.	414
	Name 'NEW_FILE' must match pattern '^[a-z][a-zA-Z0-9]*$'.	414
	Missing a Javadoc comment.	415
	Name 'UPDATED_FILE' must match pattern '^[a-z][a-zA-Z0-9]*$'.	415
	Missing a Javadoc comment.	416
	Name 'REMOVED_FILE' must match pattern '^[a-z][a-zA-Z0-9]*$'.	416
	'3' is a magic number.	416
	Missing a Javadoc comment.	417
	Missing a Javadoc comment.	418
	Missing a Javadoc comment.	419
	Missing a Javadoc comment.	421
	Parameter action should be final.	421
	Parameter child should be final.	421
	Parameter info should be final.	421
	Missing a Javadoc comment.	427
	Avoid inline conditionals.	428
	Avoid inline conditionals.	428
	Missing a Javadoc comment.	432
	Missing a Javadoc comment.	433
	Missing a Javadoc comment.	434
	Missing a Javadoc comment.	435
	Missing a Javadoc comment.	436
	Missing a Javadoc comment.	437
	Missing a Javadoc comment.	438
	Missing a Javadoc comment.	440
	Parameter path should be final.	440
	Missing a Javadoc comment.	446
	Missing a Javadoc comment.	450
	Missing a Javadoc comment.	454
	Parameter size should be final.	454
	Missing a Javadoc comment.	458
	Missing a Javadoc comment.	462
	Parameter modified should be final.	462
	Missing a Javadoc comment.	466
	Missing a Javadoc comment.	470
	Parameter newFile should be final.	470
	Missing a Javadoc comment.	474
	Missing a Javadoc comment.	478
	Parameter changing should be final.	478
	Missing a Javadoc comment.	482
	Missing a Javadoc comment.	486
	Parameter configId should be final.	486
	Missing a Javadoc comment.	490
	Parameter info should be final.	490
	Line is longer than 120 characters.	492

org/apache/geronimo/deployment/hot/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/deployment/hot/HotDeployer.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	19
	Missing a Javadoc comment.	25
	Redundant 'public' modifier.	25
	Missing a Javadoc comment.	26
	Redundant 'public' modifier.	26

org/apache/geronimo/deployment/hot/DirectoryHotDeployer.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	First sentence should end with a period.	50
	Missing a Javadoc comment.	56
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	56
	Line is longer than 120 characters.	59
	Missing a Javadoc comment.	59
	'+' should be on a new line.	59
	'+' should be on a new line.	60
	'+' should be on a new line.	61
	Missing a Javadoc comment.	63
	Missing a Javadoc comment.	64
	Missing a Javadoc comment.	65
	Missing a Javadoc comment.	66
	Missing a Javadoc comment.	67
	Missing a Javadoc comment.	68
	Missing a Javadoc comment.	69
	Missing a Javadoc comment.	70
	Missing a Javadoc comment.	71
	Missing a Javadoc comment.	72
	Missing a Javadoc comment.	73
	Missing a Javadoc comment.	74
	Line is longer than 120 characters.	76
	Missing a Javadoc comment.	76
	Parameter path should be final.	76
	Parameter pollIntervalMillis should be final.	76
	Parameter serverInfo should be final.	76
	Parameter configManager should be final.	76
	Parameter kernel should be final.	76
	Missing a Javadoc comment.	84
	Parameter id should be final.	84
	Missing a Javadoc comment.	88
	Parameter id should be final.	88
	Missing a Javadoc comment.	93
	Missing a Javadoc comment.	97
	Parameter path should be final.	97
	Missing a Javadoc comment.	101
	Missing a Javadoc comment.	105
	Parameter serverInfo should be final.	105
	Missing a Javadoc comment.	109
	Missing a Javadoc comment.	113
	Parameter pollIntervalMillis should be final.	113
	Missing a Javadoc comment.	117
	Missing a Javadoc comment.	121
	Parameter deploymentURI should be final.	121
	Missing a Javadoc comment.	127
	Missing a Javadoc comment.	131
	Parameter deploymentUser should be final.	131
	Missing a Javadoc comment.	135
	Missing a Javadoc comment.	139
	Parameter deploymentPassword should be final.	139
	Missing a Javadoc comment.	143
	Line is longer than 120 characters.	150
	Line is longer than 120 characters.	153
	'if' construct must use '{}'s.	168
	Missing a Javadoc comment.	172
	Missing a Javadoc comment.	176
	Missing a Javadoc comment.	182
	Parameter file should be final.	182
	Parameter configId should be final.	182
	Missing a Javadoc comment.	192
	Line is longer than 120 characters.	197
	Missing a Javadoc comment.	214
	Parameter file should be final.	214
	Parameter configId should be final.	214
	'+' is not preceded with whitespace.	220
	'+' is not followed by whitespace.	220
	Missing a Javadoc comment.	225
	Missing a Javadoc comment.	230
	Parameter file should be final.	230
	Parameter configId should be final.	230
	Missing a Javadoc comment.	239
	Parameter file should be final.	239
	Line is longer than 120 characters.	266
	Avoid inline conditionals.	266
	Avoid inline conditionals.	266
	'4' is a magic number.	266
	'72' is a magic number.	266
	Line is longer than 120 characters.	270
	Avoid inline conditionals.	270
	'4' is a magic number.	270
	'72' is a magic number.	270
	'if' construct must use '{}'s.	284
	Missing a Javadoc comment.	299
	Missing a Javadoc comment.	307
	Parameter file should be final.	307
	Parameter configId should be final.	307
	Line is longer than 120 characters.	314
	Line is longer than 120 characters.	321
	Avoid inline conditionals.	321
	'4' is a magic number.	321
	'72' is a magic number.	321
	Line is longer than 120 characters.	324
	'if' construct must use '{}'s.	334
	Missing a Javadoc comment.	339
	Parameter file should be final.	339
	Parameter configId should be final.	339
	Line is longer than 120 characters.	346
	Line is longer than 120 characters.	358
	Avoid inline conditionals.	358
	Avoid inline conditionals.	358
	'4' is a magic number.	358
	'72' is a magic number.	358
	Line is longer than 120 characters.	362
	Avoid inline conditionals.	362
	'4' is a magic number.	362
	'72' is a magic number.	362
	Line is longer than 120 characters.	367
	'if' construct must use '{}'s.	374
	Missing a Javadoc comment.	378
	Parameter po should be final.	378
	'100' is a magic number.	381
	Missing a Javadoc comment.	388
	Missing a Javadoc comment.	411

Parent Project

Project Documentation

Checkstyle Results

Summary

Rules

Files

Details

org/apache/geronimo/deployment/hot/DirectoryMonitor.java

org/apache/geronimo/deployment/hot/package.html

org/apache/geronimo/deployment/hot/HotDeployer.java

org/apache/geronimo/deployment/hot/DirectoryHotDeployer.java