Checkstyle Results

The following document contains the results of Checkstyle. rss feed

Summary

FilesInfos infoWarnings warningErrors error
1100516

Rules

RulesViolationsSeverity
PackageHtml3error Error
NewlineAtEndOfFile0error Error
Translation0error Error
JavadocMethod109error Error
JavadocType2error Error
JavadocVariable49error Error
JavadocStyle4error Error
ConstantName0error Error
LocalFinalVariableName0error Error
LocalVariableName0error Error
MemberName0error Error
MethodName0error Error
PackageName0error Error
ParameterName0error Error
StaticVariableName0error Error
TypeName0error Error
Header
  • headerFile: "/home/anthill/anthill3/agent/var/jobs/projects/Geronimo_Server/modules/geronimo-converter/target/checkstyle-header.txt"
8error Error
AvoidStarImport0error Error
IllegalImport0error Error
RedundantImport0error Error
UnusedImports0error Error
FileLength0error Error
LineLength
  • max: "120"
15error Error
MethodLength0error Error
ParameterNumber0error Error
EmptyForIteratorPad0error Error
NoWhitespaceAfter0error Error
NoWhitespaceBefore0error Error
OperatorWrap0error Error
ParenPad0error Error
TypecastParenPad0error Error
TabCharacter0error Error
WhitespaceAfter11error Error
WhitespaceAround182error Error
ModifierOrder5error Error
RedundantModifier0error Error
AvoidNestedBlocks0error Error
EmptyBlock0error Error
LeftCurly0error Error
NeedBraces21error Error
RightCurly0error Error
AvoidInlineConditionals3error Error
DoubleCheckedLocking0error Error
EmptyStatement0error Error
EqualsHashCode0error Error
HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
0error Error
IllegalInstantiation0error Error
InnerAssignment0error Error
MagicNumber4error Error
MissingSwitchDefault0error Error
RedundantThrows0error Error
SimplifyBooleanExpression0error Error
SimplifyBooleanReturn0error Error
FinalClass0error Error
HideUtilityClassConstructor1error Error
InterfaceIsType0error Error
VisibilityModifier0error Error
ArrayTypeStyle3error Error
FinalParameters96error Error
GenericIllegalRegexp
  • message: "Line has trailing spaces."
  • format: "\s+$"
0error Error
TodoComment0error Error
UpperEll0error Error

Files

FilesI infoW warningE error
org/apache/geronimo/converter/AbstractDatabasePool.java0050
org/apache/geronimo/converter/DatabaseConversionStatus.java0017
org/apache/geronimo/converter/package.html001
org/apache/geronimo/converter/JDBCPool.java0022
org/apache/geronimo/converter/XADatabasePool.java009
org/apache/geronimo/converter/jboss/package.html001
org/apache/geronimo/converter/jboss/JBoss4DatabaseConverter.java0089
org/apache/geronimo/converter/DOMUtils.java0016
org/apache/geronimo/converter/bea/package.html001
org/apache/geronimo/converter/bea/Weblogic81Utils.java0073
org/apache/geronimo/converter/bea/WebLogic81DatabaseConverter.java00237

Details

org/apache/geronimo/converter/AbstractDatabasePool.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorFirst sentence should end with a period.21
errorMissing a Javadoc comment.27
error'static' modifier out of order with the JLS suggestions.27
errorMissing a Javadoc comment.28
error'static' modifier out of order with the JLS suggestions.28
errorMissing a Javadoc comment.29
error'static' modifier out of order with the JLS suggestions.29
errorMissing a Javadoc comment.30
error'static' modifier out of order with the JLS suggestions.30
errorMissing a Javadoc comment.31
errorMissing a Javadoc comment.32
errorMissing a Javadoc comment.33
errorMissing a Javadoc comment.34
errorMissing a Javadoc comment.35
errorMissing a Javadoc comment.36
errorMissing a Javadoc comment.37
errorMissing a Javadoc comment.38
errorMissing a Javadoc comment.39
errorMissing a Javadoc comment.40
errorMissing a Javadoc comment.42
errorMissing a Javadoc comment.46
errorParameter name should be final.46
errorMissing a Javadoc comment.50
errorMissing a Javadoc comment.54
errorParameter jndiName should be final.54
errorMissing a Javadoc comment.58
errorMissing a Javadoc comment.62
errorParameter newConnectionSQL should be final.62
errorMissing a Javadoc comment.66
errorMissing a Javadoc comment.70
errorParameter testConnectionSQL should be final.70
errorMissing a Javadoc comment.74
errorMissing a Javadoc comment.78
errorParameter vendor should be final.78
errorMissing a Javadoc comment.82
errorMissing a Javadoc comment.86
errorParameter minSize should be final.86
errorMissing a Javadoc comment.90
errorMissing a Javadoc comment.94
errorParameter maxSize should be final.94
errorMissing a Javadoc comment.98
errorMissing a Javadoc comment.102
errorParameter blockingTimeoutMillis should be final.102
errorMissing a Javadoc comment.106
errorMissing a Javadoc comment.110
errorParameter idleTimeoutMillis should be final.110
errorMissing a Javadoc comment.114
errorMissing a Javadoc comment.118
errorParameter statementCacheSize should be final.118

org/apache/geronimo/converter/DatabaseConversionStatus.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.25
errorMissing a Javadoc comment.26
errorMissing a Javadoc comment.27
errorMissing a Javadoc comment.28
errorMissing a Javadoc comment.30
errorMissing a Javadoc comment.34
errorParameter messages should be final.34
errorMissing a Javadoc comment.38
errorMissing a Javadoc comment.42
errorParameter noTXPools should be final.42
errorMissing a Javadoc comment.46
errorMissing a Javadoc comment.50
errorParameter jdbcPools should be final.50
errorMissing a Javadoc comment.54
errorMissing a Javadoc comment.58
errorParameter xaPools should be final.58

org/apache/geronimo/converter/package.html

ViolationMessageLine
errorMissing package documentation file.0

org/apache/geronimo/converter/JDBCPool.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorFirst sentence should end with a period.21
errorMissing a Javadoc comment.27
errorMissing a Javadoc comment.28
errorMissing a Javadoc comment.29
errorMissing a Javadoc comment.30
errorMissing a Javadoc comment.31
errorMissing a Javadoc comment.33
errorMissing a Javadoc comment.37
errorParameter driverClass should be final.37
errorMissing a Javadoc comment.41
errorMissing a Javadoc comment.45
errorParameter jdbcURL should be final.45
errorMissing a Javadoc comment.49
errorMissing a Javadoc comment.53
errorParameter username should be final.53
errorMissing a Javadoc comment.57
errorMissing a Javadoc comment.61
errorParameter password should be final.61
errorMissing a Javadoc comment.65
errorMissing a Javadoc comment.69
errorParameter connectionProperties should be final.69

org/apache/geronimo/converter/XADatabasePool.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.25
errorMissing a Javadoc comment.26
errorMissing a Javadoc comment.28
errorMissing a Javadoc comment.32
errorParameter xaDataSourceClass should be final.32
errorMissing a Javadoc comment.36
errorMissing a Javadoc comment.40
errorParameter properties should be final.40

org/apache/geronimo/converter/jboss/package.html

ViolationMessageLine
errorMissing package documentation file.0

org/apache/geronimo/converter/jboss/JBoss4DatabaseConverter.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorFirst sentence should end with a period.39
errorMissing a Javadoc comment.45
errorParameter dsXml should be final.45
error'cast' is not followed by whitespace.59
error'cast' is not followed by whitespace.61
errorMissing a Javadoc comment.72
errorParameter doc should be final.72
errorParameter status should be final.72
errorParameter noTx should be final.72
errorParameter local should be final.72
errorParameter xa should be final.72
error'if' is not followed by whitespace.74
error'if' is not followed by whitespace.75
errorLine is longer than 120 characters.76
errorLine is longer than 120 characters.79
error'+' is not preceded with whitespace.79
error'+' is not followed by whitespace.79
error'+' is not preceded with whitespace.79
error'+' is not followed by whitespace.79
error'for' is not followed by whitespace.84
error'=' is not preceded with whitespace.84
error'=' is not followed by whitespace.84
error'<' is not preceded with whitespace.84
error'<' is not followed by whitespace.84
error'if' is not followed by whitespace.86
error'if' is not followed by whitespace.88
error'cast' is not followed by whitespace.89
error'if' is not followed by whitespace.90
error'cast' is not followed by whitespace.91
error'if' is not followed by whitespace.92
error'cast' is not followed by whitespace.93
error'if' is not followed by whitespace.94
error'+' is not preceded with whitespace.97
error'+' is not followed by whitespace.97
errorMissing a Javadoc comment.103
errorParameter root should be final.103
errorParameter pool should be final.103
errorParameter status should be final.103
error'if' is not followed by whitespace.106
error'+' is not preceded with whitespace.107
error'+' is not followed by whitespace.107
error'+' is not preceded with whitespace.107
error'+' is not followed by whitespace.107
error'if' construct must use '{}'s.110
error'if' is not followed by whitespace.110
error'if' construct must use '{}'s.112
error'if' is not followed by whitespace.112
error'if' construct must use '{}'s.114
error'if' is not followed by whitespace.114
error'if' construct must use '{}'s.116
error'if' is not followed by whitespace.116
error'*' is not preceded with whitespace.116
error'*' is not followed by whitespace.116
error'60' is a magic number.116
error'*' is not preceded with whitespace.116
error'*' is not followed by whitespace.116
error'1000' is a magic number.116
error'if' is not followed by whitespace.120
error'if' construct must use '{}'s.121
error'if' is not followed by whitespace.121
error'if' construct must use '{}'s.122
error'if' is not followed by whitespace.122
error'if' construct must use '{}'s.123
error'if' is not followed by whitespace.123
error'if' construct must use '{}'s.124
error'if' is not followed by whitespace.124
error'if' construct must use '{}'s.127
error'if' is not followed by whitespace.127
errorMissing a Javadoc comment.130
errorParameter root should be final.130
errorParameter status should be final.130
errorParameter results should be final.130
error'for' is not followed by whitespace.136
error'=' is not preceded with whitespace.136
error'=' is not followed by whitespace.136
error'<' is not preceded with whitespace.136
error'<' is not followed by whitespace.136
error'if' is not followed by whitespace.144
errorMissing a Javadoc comment.151
errorParameter root should be final.151
errorParameter status should be final.151
errorParameter results should be final.151
error'for' is not followed by whitespace.156
error'=' is not preceded with whitespace.156
error'=' is not followed by whitespace.156
error'<' is not preceded with whitespace.156
error'<' is not followed by whitespace.156
error'if' is not followed by whitespace.161

org/apache/geronimo/converter/DOMUtils.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorUtility classes should not have a public or default constructor.28
errorMissing a Javadoc comment.29
errorParameter parent should be final.29
errorParameter childName should be final.29
error'if' is not followed by whitespace.31
error'if' is not followed by whitespace.33
errorMissing a Javadoc comment.40
errorParameter element should be final.40
error'for' is not followed by whitespace.44
error'=' is not preceded with whitespace.44
error'=' is not followed by whitespace.44
error'<' is not preceded with whitespace.44
error'<' is not followed by whitespace.44
error'if' is not followed by whitespace.46
errorAvoid inline conditionals.51

org/apache/geronimo/converter/bea/package.html

ViolationMessageLine
errorMissing package documentation file.0

org/apache/geronimo/converter/bea/Weblogic81Utils.java

ViolationMessageLine
errorMissing a header - not enough lines in file.1
errorMissing a Javadoc comment.44
error'static' modifier out of order with the JLS suggestions.44
errorMissing a Javadoc comment.45
errorMissing a Javadoc comment.46
errorMissing a Javadoc comment.47
errorMissing a Javadoc comment.48
errorMissing a Javadoc comment.49
errorMissing a Javadoc comment.51
errorParameter libDirPath should be final.51
errorParameter domainDirPath should be final.51
error'if' construct must use '{}'s.53
errorLine is longer than 120 characters.53
error'if' is not followed by whitespace.53
error'if' construct must use '{}'s.56
error'if' is not followed by whitespace.56
error'if' construct must use '{}'s.58
errorLine is longer than 120 characters.58
error'if' is not followed by whitespace.58
error'if' construct must use '{}'s.60
error'if' is not followed by whitespace.60
errorLine is longer than 120 characters.62
errorAvoid inline conditionals.62
errorLine is longer than 120 characters.65
error'cast' is not followed by whitespace.65
errorMissing a Javadoc comment.69
error'if' construct must use '{}'s.84
error'if' is not followed by whitespace.84
errorMissing a Javadoc comment.92
error'while' is not followed by whitespace.100
error'while' is not followed by whitespace.103
error'+' is not preceded with whitespace.104
error'+' is not followed by whitespace.104
error'-' is not preceded with whitespace.107
error'-' is not followed by whitespace.107
error'-' is not preceded with whitespace.109
error'-' is not followed by whitespace.109
error'if' is not followed by whitespace.111
error'if' is not followed by whitespace.114
error'+' is not preceded with whitespace.114
error'+' is not followed by whitespace.114
error'+' is not preceded with whitespace.115
error'+' is not followed by whitespace.115
errorLine is longer than 120 characters.129
errorMissing a Javadoc comment.129
errorParameter loader should be final.129
errorParameter state should be final.129
error'if' is not followed by whitespace.134
error'if' construct must use '{}'s.135
error'if' is not followed by whitespace.135
errorMissing a Javadoc comment.145
errorParameter in should be final.145
error'if' construct must use '{}'s.147
error'if' is not followed by whitespace.147
errorArray brackets at illegal position.149
error'while' is not followed by whitespace.151
error'if' is not followed by whitespace.152
error'if' construct must use '{}'s.156
error'if' is not followed by whitespace.156
errorMissing a Javadoc comment.163
errorParameter string should be final.163
error'if' is not followed by whitespace.164
error'+' is not preceded with whitespace.165
error'+' is not followed by whitespace.165
errorLine is longer than 120 characters.170
errorMissing a Javadoc comment.170
errorParameter loader should be final.170
errorParameter salt should be final.170
errorArray brackets at illegal position.170
errorParameter key should be final.170
errorArray brackets at illegal position.170
errorLine is longer than 120 characters.172
errorLine is longer than 120 characters.173

org/apache/geronimo/converter/bea/WebLogic81DatabaseConverter.java

ViolationMessageLine
errorLine does not match expected header line of ''.1
errorFirst sentence should end with a period.44
errorMissing a Javadoc comment.50
errorParameter libDir should be final.50
errorParameter domainDir should be final.50
errorMissing a Javadoc comment.56
errorParameter configXml should be final.56
error'cast' is not followed by whitespace.70
error'cast' is not followed by whitespace.72
errorMissing a Javadoc comment.83
errorParameter doc should be final.83
errorParameter status should be final.83
errorParameter local should be final.83
errorParameter xa should be final.83
error'if' is not followed by whitespace.85
errorLine is longer than 120 characters.86
error'+' is not preceded with whitespace.86
error'+' is not followed by whitespace.86
error'+' is not preceded with whitespace.86
error'+' is not followed by whitespace.86
error'for' is not followed by whitespace.91
error'=' is not preceded with whitespace.91
error'=' is not followed by whitespace.91
error'<' is not preceded with whitespace.91
error'<' is not followed by whitespace.91
error'if' is not followed by whitespace.93
error'if' is not followed by whitespace.95
error'cast' is not followed by whitespace.96
error'if' is not followed by whitespace.98
error'cast' is not followed by whitespace.99
error'if' is not followed by whitespace.101
error'+' is not preceded with whitespace.104
error'+' is not followed by whitespace.104
error'+' is not preceded with whitespace.104
error'+' is not followed by whitespace.104
error'+' is not preceded with whitespace.104
error'+' is not followed by whitespace.104
error'+' is not preceded with whitespace.104
error'+' is not followed by whitespace.104
error'if' is not followed by whitespace.106
error'cast' is not followed by whitespace.107
error'if' is not followed by whitespace.109
error'+' is not preceded with whitespace.112
error'+' is not followed by whitespace.112
error'+' is not preceded with whitespace.112
error'+' is not followed by whitespace.112
error'+' is not preceded with whitespace.112
error'+' is not followed by whitespace.112
error'+' is not preceded with whitespace.112
error'+' is not followed by whitespace.112
error'+' is not preceded with whitespace.115
error'+' is not followed by whitespace.115
error'+' is not preceded with whitespace.115
error'+' is not followed by whitespace.115
error'if' is not followed by whitespace.119
error'if' is not followed by whitespace.122
errorLine is longer than 120 characters.123
errorMissing a Javadoc comment.132
errorParameter pools should be final.132
errorParameter status should be final.132
errorParameter local should be final.132
errorParameter xa should be final.132
error'if' is not followed by whitespace.136
error'if' is not followed by whitespace.138
error'if' is not followed by whitespace.140
errorLine is longer than 120 characters.144
error'+' is not preceded with whitespace.144
error'+' is not followed by whitespace.144
error'+' is not preceded with whitespace.144
error'+' is not followed by whitespace.144
error'if' is not followed by whitespace.146
errorLine is longer than 120 characters.147
error'+' is not preceded with whitespace.147
error'+' is not followed by whitespace.147
error'+' is not preceded with whitespace.147
error'+' is not followed by whitespace.147
error'if' is not followed by whitespace.148
error'if' is not followed by whitespace.156
errorMissing a Javadoc comment.166
errorParameter pool should be final.166
errorParameter target should be final.166
error'if' is not followed by whitespace.167
error'*' is not preceded with whitespace.168
error'*' is not followed by whitespace.168
error'1000' is a magic number.168
error'if' is not followed by whitespace.170
error'*' is not preceded with whitespace.171
error'*' is not followed by whitespace.171
error'1000' is a magic number.171
errorLine is longer than 120 characters.177
errorAvoid inline conditionals.177
error'+' is not preceded with whitespace.177
error'+' is not followed by whitespace.177
error'+' is not preceded with whitespace.177
error'+' is not followed by whitespace.177
error'if' construct must use '{}'s.178
error'if' is not followed by whitespace.178
error'if' construct must use '{}'s.179
error'if' is not followed by whitespace.179
error'if' construct must use '{}'s.180
error'if' is not followed by whitespace.180
error'if' construct must use '{}'s.181
error'if' is not followed by whitespace.181
errorMissing a Javadoc comment.184
errorParameter pool should be final.184
errorParameter name should be final.184
errorParameter jndiName should be final.184
error'if' is not followed by whitespace.193
errorMissing a Javadoc comment.200
errorParameter pool should be final.200
errorParameter name should be final.200
errorParameter jndiName should be final.200
errorMissing a Javadoc comment.210
errorParameter root should be final.210
errorParameter tx should be final.210
errorMissing a Javadoc comment.220
errorParameter value should be final.220
errorParameter defaultResult should be final.220
error'if' is not followed by whitespace.221
errorMissing a Javadoc comment.227
errorParameter root should be final.227
errorParameter status should be final.227
error'if' is not followed by whitespace.237
error'if' is not followed by whitespace.239
errorMissing a Javadoc comment.250
errorParameter props should be final.250
errorParameter value should be final.250
errorParameter status should be final.250
error'if' is not followed by whitespace.251
error'if' is not followed by whitespace.255
error'while' is not followed by whitespace.260
error'+' is not preceded with whitespace.261
error'+' is not followed by whitespace.261
error'if' is not followed by whitespace.263
error'+' is not preceded with whitespace.264
error'+' is not followed by whitespace.264
error'+' is not preceded with whitespace.266
error'+' is not followed by whitespace.266
error'+' is not preceded with whitespace.266
error'+' is not followed by whitespace.266
error'+' is not preceded with whitespace.269
error'+' is not followed by whitespace.269
error'+' is not preceded with whitespace.271
error'+' is not followed by whitespace.271
error'if' is not followed by whitespace.273
error'+' is not preceded with whitespace.274
error'+' is not followed by whitespace.274
error'+' is not preceded with whitespace.276
error'+' is not followed by whitespace.276
error'+' is not preceded with whitespace.276
error'+' is not followed by whitespace.276
errorMissing a Javadoc comment.280
errorParameter value should be final.280
error'if' is not followed by whitespace.281
error'if' is not followed by whitespace.285
errorMissing a Javadoc comment.291
errorMissing a Javadoc comment.292
errorMissing a Javadoc comment.293
errorMissing a Javadoc comment.294
errorMissing a Javadoc comment.295
errorMissing a Javadoc comment.296
errorMissing a Javadoc comment.298
errorMissing a Javadoc comment.302
errorParameter name should be final.302
errorMissing a Javadoc comment.306
errorMissing a Javadoc comment.310
errorParameter poolName should be final.310
errorMissing a Javadoc comment.314
errorMissing a Javadoc comment.318
errorParameter jndiName should be final.318
errorMissing a Javadoc comment.322
errorMissing a Javadoc comment.326
errorParameter emulate should be final.326
errorMissing a Javadoc comment.330
errorMissing a Javadoc comment.334
errorParameter declaredAsTX should be final.334
errorMissing a Javadoc comment.339
errorMissing a Javadoc comment.340
errorMissing a Javadoc comment.341
errorMissing a Javadoc comment.342
errorMissing a Javadoc comment.343
errorMissing a Javadoc comment.344
errorMissing a Javadoc comment.345
errorMissing a Javadoc comment.346
errorMissing a Javadoc comment.347
errorMissing a Javadoc comment.348
errorMissing a Javadoc comment.349
errorMissing a Javadoc comment.350
errorMissing a Javadoc comment.351
errorMissing a Javadoc comment.352
errorMissing a Javadoc comment.354
error'if' is not followed by whitespace.357
errorMissing a Javadoc comment.364
error'if' is not followed by whitespace.367
errorMissing a Javadoc comment.374
errorMissing a Javadoc comment.378
errorMissing a Javadoc comment.382
errorParameter name should be final.382
errorMissing a Javadoc comment.386
errorMissing a Javadoc comment.390
errorParameter driverName should be final.390
errorMissing a Javadoc comment.394
errorMissing a Javadoc comment.398
errorParameter username should be final.398
errorMissing a Javadoc comment.402
errorMissing a Javadoc comment.406
errorParameter password should be final.406
errorMissing a Javadoc comment.410
errorMissing a Javadoc comment.414
errorParameter initSQL should be final.414
errorMissing a Javadoc comment.418
errorMissing a Javadoc comment.422
errorParameter testTable should be final.422
errorMissing a Javadoc comment.426
errorMissing a Javadoc comment.430
errorParameter properties should be final.430
errorMissing a Javadoc comment.434
errorMissing a Javadoc comment.438
errorParameter dataSources should be final.438
errorMissing a Javadoc comment.442
errorMissing a Javadoc comment.446
errorParameter min should be final.446
errorMissing a Javadoc comment.450
errorMissing a Javadoc comment.454
errorParameter max should be final.454
errorMissing a Javadoc comment.458
errorMissing a Javadoc comment.462
errorParameter reserveTimeoutSecs should be final.462
errorMissing a Javadoc comment.466
errorMissing a Javadoc comment.470
errorParameter idleTimeoutSecs should be final.470
errorMissing a Javadoc comment.474
errorMissing a Javadoc comment.478
errorParameter cacheSize should be final.478
errorMissing a Javadoc comment.482
errorMissing a Javadoc comment.486
errorParameter url should be final.486