Geronimo :: Connector - Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
96	0	0	1772

Rules

Rules	Violations	Severity
PackageHtml	8	Error
NewlineAtEndOfFile	0	Error
Translation	0	Error
JavadocMethod	639	Error
JavadocType	12	Error
JavadocVariable	228	Error
JavadocStyle	20	Error
ConstantName	4	Error
LocalFinalVariableName	0	Error
LocalVariableName	0	Error
MemberName	0	Error
MethodName	6	Error
PackageName	0	Error
ParameterName	0	Error
StaticVariableName	0	Error
TypeName	0	Error
Header headerFile: `"/home/anthill/anthill3/agent/var/jobs/projects/Geronimo_Server/modules/geronimo-connector/target/checkstyle-header.txt"`	88	Error
AvoidStarImport	0	Error
IllegalImport	0	Error
RedundantImport	0	Error
UnusedImports	1	Error
FileLength	0	Error
LineLength max: `"120"`	106	Error
MethodLength	0	Error
ParameterNumber	4	Error
EmptyForIteratorPad	3	Error
NoWhitespaceAfter	0	Error
NoWhitespaceBefore	0	Error
OperatorWrap	2	Error
ParenPad	0	Error
TypecastParenPad	0	Error
TabCharacter	0	Error
WhitespaceAfter	13	Error
WhitespaceAround	28	Error
ModifierOrder	6	Error
RedundantModifier	5	Error
AvoidNestedBlocks	0	Error
EmptyBlock	11	Error
LeftCurly	1	Error
NeedBraces	3	Error
RightCurly	4	Error
AvoidInlineConditionals	16	Error
DoubleCheckedLocking	0	Error
EmptyStatement	0	Error
EqualsHashCode	0	Error
HiddenField ignoreConstructorParameter: `"true"` ignoreSetter: `"true"`	32	Error
IllegalInstantiation	0	Error
InnerAssignment	0	Error
MagicNumber	18	Error
MissingSwitchDefault	0	Error
RedundantThrows	0	Error
SimplifyBooleanExpression	0	Error
SimplifyBooleanReturn	0	Error
FinalClass	5	Error
HideUtilityClassConstructor	11	Error
InterfaceIsType	0	Error
VisibilityModifier	16	Error
ArrayTypeStyle	0	Error
FinalParameters	456	Error
GenericIllegalRegexp message: `"Line has trailing spaces."` format: `"\s+$"`	23	Error
TodoComment	3	Error
UpperEll	0	Error

Files

Files	I	W	E
org/apache/geronimo/connector/outbound/ConnectionHandleInterceptor.java	0	0	16
org/apache/geronimo/connector/outbound/SinglePoolConnectionInterceptor.java	0	0	51
org/apache/geronimo/connector/outbound/XAResourceInsertionInterceptor.java	0	0	12
org/apache/geronimo/connector/outbound/SinglePoolMatchAllConnectionInterceptor.java	0	0	35
org/apache/geronimo/connector/ResourceAdapterModuleImpl.java	0	0	60
org/apache/geronimo/connector/outbound/LocalXAResourceInsertionInterceptor.java	0	0	12
org/apache/geronimo/connector/outbound/SubjectInterceptor.java	0	0	12
org/apache/geronimo/connector/outbound/connectionmanagerconfig/XATransactions.java	0	0	19
org/apache/geronimo/connector/work/GeronimoWorkManagerGBean.java	0	0	11
org/apache/geronimo/connector/outbound/GenericConnectionManager.java	0	0	36
org/apache/geronimo/connector/outbound/LocalXAResource.java	0	0	40
org/apache/geronimo/connector/DatabaseInitializationGBean.java	0	0	12
org/apache/geronimo/connector/outbound/security/package.html	0	0	1
org/apache/geronimo/connector/outbound/AbstractConnectionManagerGBean.java	0	0	3
org/apache/geronimo/connector/outbound/transactionlog/package.html	0	0	1
org/apache/geronimo/connector/work/pool/WorkExecutorPoolImpl.java	0	0	9
org/apache/geronimo/connector/outbound/JCAConnectionFactoryImpl.java	0	0	21
org/apache/geronimo/connector/outbound/PoolIdleReleaserTimer.java	0	0	5
org/apache/geronimo/connector/JCAResourceImpl.java	0	0	34
org/apache/geronimo/connector/ConnectionReleaser.java	0	0	2
org/apache/geronimo/connector/outbound/connectiontracking/ConnectionTrackingCoordinatorGBean.java	0	0	14
org/apache/geronimo/connector/ResourceAdapterModuleImplGBean.java	0	0	5
org/apache/geronimo/connector/outbound/GeronimoConnectionEventListener.java	0	0	29
org/apache/geronimo/connector/ConnectorTransactionContext.java	0	0	28
org/apache/geronimo/connector/outbound/ConnectionFactorySource.java	0	0	3
org/apache/geronimo/connector/outbound/connectionmanagerconfig/SinglePool.java	0	0	56
org/apache/geronimo/connector/outbound/security/PasswordCredentialLoginModuleWrapperGBean.java	0	0	6
org/apache/geronimo/connector/ResourceAdapterWrapper.java	0	0	29
org/apache/geronimo/connector/work/pool/NamedRunnable.java	0	0	8
org/apache/geronimo/connector/work/GeronimoWorkManager.java	0	0	47
org/apache/geronimo/connector/AdminObjectWrapper.java	0	0	46
org/apache/geronimo/connector/outbound/connectionmanagerconfig/TransactionSupport.java	0	0	4
org/apache/geronimo/connector/outbound/connectionmanagerconfig/PartitionedPool.java	0	0	53
org/apache/geronimo/connector/outbound/TransactionEnlistingInterceptor.java	0	0	13
org/apache/geronimo/connector/work/pool/WorkExecutor.java	0	0	2
org/apache/geronimo/connector/outbound/connectiontracking/ConnectionTrackingCoordinator.java	0	0	20
org/apache/geronimo/connector/ResourceAdapterWrapperGBean.java	0	0	32
org/apache/geronimo/connector/outbound/connectionmanagerconfig/LocalTransactions.java	0	0	11
org/apache/geronimo/connector/ConnectorMethodInterceptor.java	0	0	13
org/apache/geronimo/connector/outbound/ManagedConnectionFactoryWrapper.java	0	0	99
org/apache/geronimo/connector/outbound/PoolingAttributes.java	0	0	12
org/apache/geronimo/connector/outbound/security/ResourcePrincipal.java	0	0	5
org/apache/geronimo/connector/outbound/TxUtil.java	0	0	10
org/apache/geronimo/connector/outbound/connectiontracking/ConnectionTracker.java	0	0	4
org/apache/geronimo/connector/outbound/connectionmanagerconfig/NoPool.java	0	0	18
org/apache/geronimo/connector/outbound/ConnectionInterceptorSource.java	0	0	2
org/apache/geronimo/connector/outbound/transactionlog/JDBCLog.java	0	0	45
org/apache/geronimo/connector/outbound/MCFConnectionInterceptor.java	0	0	15
org/apache/geronimo/connector/work/package.html	0	0	1
org/apache/geronimo/connector/outbound/connectiontracking/ConnectorInstanceContextImpl.java	0	0	10
org/apache/geronimo/connector/ActivationSpecWrapperGBean.java	0	0	16
org/apache/geronimo/connector/ResourceAdapterImpl.java	0	0	12
org/apache/geronimo/connector/outbound/transactionlog/LogXAResource.java	0	0	39
org/apache/geronimo/connector/outbound/TCCLInterceptor.java	0	0	14
org/apache/geronimo/connector/work/pool/NullWorkExecutorPool.java	0	0	13
org/apache/geronimo/connector/work/pool/package.html	0	0	1
org/apache/geronimo/connector/work/pool/SyncWorkExecutor.java	0	0	4
org/apache/geronimo/connector/outbound/connectiontracking/ConnectorInstanceContext.java	0	0	3
org/apache/geronimo/connector/JCAResourceImplGBean.java	0	0	6
org/apache/geronimo/connector/outbound/ConnectionTrackingInterceptor.java	0	0	21
org/apache/geronimo/connector/outbound/security/PasswordCredentialLoginModuleWrapper.java	0	0	11
org/apache/geronimo/connector/outbound/ConnectionInterceptor.java	0	0	4
org/apache/geronimo/connector/outbound/AbstractSinglePoolConnectionInterceptor.java	0	0	96
org/apache/geronimo/connector/outbound/connectiontracking/GeronimoTransactionListener.java	0	0	10
org/apache/geronimo/connector/ActivationSpecWrapper.java	0	0	23
org/apache/geronimo/connector/outbound/JCAConnectionFactoryImplGBean.java	0	0	7
org/apache/geronimo/connector/work/pool/ScheduleWorkExecutor.java	0	0	4
org/apache/geronimo/connector/outbound/TransactionCachingInterceptor.java	0	0	36
org/apache/geronimo/connector/outbound/security/CallerIdentityPasswordCredentialLoginModule.java	0	0	19
org/apache/geronimo/connector/AdminObjectWrapperGBean.java	0	0	6
org/apache/geronimo/connector/outbound/AbstractConnectionManager.java	0	0	54
org/apache/geronimo/connector/outbound/connectionmanagerconfig/PoolingSupport.java	0	0	2
org/apache/geronimo/connector/outbound/ConnectionManagerContainer.java	0	0	40
org/apache/geronimo/connector/outbound/package.html	0	0	1
org/apache/geronimo/connector/package.html	0	0	1
org/apache/geronimo/connector/ResourceAdapterImplGBean.java	0	0	6
org/apache/geronimo/connector/work/pool/WorkExecutorPool.java	0	0	8
org/apache/geronimo/connector/work/pool/StartWorkExecutor.java	0	0	4
org/apache/geronimo/connector/outbound/transactionlog/LogXAResourceInsertionInterceptor.java	0	0	12
org/apache/geronimo/connector/outbound/connectionmanagerconfig/package.html	0	0	1
org/apache/geronimo/connector/AdminObjectSource.java	0	0	3
org/apache/geronimo/connector/outbound/ThreadLocalCachingConnectionInterceptor.java	0	0	12
org/apache/geronimo/connector/outbound/MultiPoolConnectionInterceptor.java	0	0	52
org/apache/geronimo/connector/outbound/ConnectionInfo.java	0	0	30
org/apache/geronimo/connector/work/WorkerContext.java	0	0	29
org/apache/geronimo/connector/GeronimoBootstrapContextGBean.java	0	0	6
org/apache/geronimo/connector/outbound/ManagedConnectionInfo.java	0	0	53
org/apache/geronimo/connector/outbound/ManagedConnectionFactoryWrapperGBean.java	0	0	6
org/apache/geronimo/connector/GeronimoBootstrapContext.java	0	0	11
org/apache/geronimo/connector/outbound/transactionlog/JDBCLogGBean.java	0	0	8
org/apache/geronimo/connector/outbound/connectionmanagerconfig/NoTransactions.java	0	0	11
org/apache/geronimo/connector/outbound/connectionmanagerconfig/TransactionLog.java	0	0	12
org/apache/geronimo/connector/outbound/ConnectionReturnAction.java	0	0	8
org/apache/geronimo/connector/outbound/connectiontracking/TrackedConnectionAssociator.java	0	0	4
org/apache/geronimo/connector/outbound/connectiontracking/package.html	0	0	1
org/apache/geronimo/connector/outbound/GenericConnectionManagerGBean.java	0	0	20

Details

org/apache/geronimo/connector/outbound/ConnectionHandleInterceptor.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	22
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	32
	Parameter next should be final.	32
	Line is longer than 120 characters.	37
	Line is longer than 120 characters.	38
	Parameter connectionInfo should be final.	42
	Expected @param tag for 'connectionInfo'.	42
	Expected @throws tag for 'ResourceException'.	42
	Line is longer than 120 characters.	61
	Parameter connectionInfo should be final.	66
	Expected @param tag for 'connectionInfo'.	66
	Parameter connectionReturnAction should be final.	66
	Expected @param tag for 'connectionReturnAction'.	66
	Missing a Javadoc comment.	74

org/apache/geronimo/connector/outbound/SinglePoolConnectionInterceptor.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	44
	Parameter maxSize should be final.	45
	Parameter minSize should be final.	46
	Parameter blockingTimeoutMilliseconds should be final.	47
	Parameter idleTimeoutMinutes should be final.	48
	Parameter selectOneAssumeMatch should be final.	49
	Missing a Javadoc comment.	55
	Parameter connectionInfo should be final.	55
	Line has trailing spaces.	60
	'10' is a magic number.	73
	Line is longer than 120 characters.	78
	Line is longer than 120 characters.	102
	Missing a Javadoc comment.	115
	'}' should be on the same line.	122
	Must have at least one statement.	123
	Missing a Javadoc comment.	129
	Parameter connectionInfo should be final.	129
	Parameter connectionReturnAction should be final.	129
	Line has trailing spaces.	139
	'}' should be on the same line.	144
	Must have at least one statement.	145
	Line has trailing spaces.	148
	Missing a Javadoc comment.	167
	Missing a Javadoc comment.	171
	Parameter maxSize should be final.	171
	Parameter shrinkNow should be final.	171
	Missing a Javadoc comment.	186
	Missing a Javadoc comment.	191
	Parameter threshold should be final.	191
	Parameter killList should be final.	191
	Missing a Javadoc comment.	202
	Parameter mci should be final.	202
	Missing a Javadoc comment.	214
	Missing a Javadoc comment.	216
	Missing a Javadoc comment.	217
	Missing a Javadoc comment.	218
	Missing a Javadoc comment.	220
	Parameter size should be final.	220
	Missing a Javadoc comment.	225
	Missing a Javadoc comment.	230
	Parameter mci should be final.	230
	Missing a Javadoc comment.	238
	Parameter i should be final.	238
	Missing a Javadoc comment.	246
	Missing a Javadoc comment.	255
	Parameter mci should be final.	255
	Missing a Javadoc comment.	270
	Missing a Javadoc comment.	275

org/apache/geronimo/connector/outbound/XAResourceInsertionInterceptor.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	24
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	40
	Parameter connectionInfo should be final.	40
	Missing a Javadoc comment.	46
	Parameter connectionInfo should be final.	46
	Parameter connectionReturnAction should be final.	46
	Line has trailing spaces.	49
	Missing a Javadoc comment.	50

org/apache/geronimo/connector/outbound/SinglePoolMatchAllConnectionInterceptor.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	43
	Parameter maxSize should be final.	44
	Parameter minSize should be final.	45
	Parameter blockingTimeoutMilliseconds should be final.	46
	Parameter idleTimeoutMinutes should be final.	47
	Missing a Javadoc comment.	54
	Parameter connectionInfo should be final.	54
	'10' is a magic number.	75
	'10' is a magic number.	95
	Missing a Javadoc comment.	106
	Parameter connectionInfo should be final.	106
	Parameter connectionReturnAction should be final.	106
	'}' should be on the same line.	121
	Must have at least one statement.	122
	Missing a Javadoc comment.	143
	';' is followed by whitespace.	146
	'cast' is not followed by whitespace.	148
	'}' should be on the same line.	149
	Must have at least one statement.	150
	Missing a Javadoc comment.	156
	Missing a Javadoc comment.	160
	Missing a Javadoc comment.	164
	Parameter maxSize should be final.	164
	'maxSize' hides a field.	164
	Parameter shrinkNow should be final.	164
	'cast' is not followed by whitespace.	173
	';' is followed by whitespace.	176
	Missing a Javadoc comment.	183
	Parameter threshold should be final.	183
	Parameter killList should be final.	183
	Missing a Javadoc comment.	196
	Parameter mci should be final.	196

org/apache/geronimo/connector/ResourceAdapterModuleImpl.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	46
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	48
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	51
	More than 7 parameters.	51
	Parameter objectName should be final.	51
	Parameter resourceAdapter should be final.	52
	Parameter server should be final.	53
	Parameter application should be final.	54
	Parameter deploymentDescriptor should be final.	55
	Parameter resourceAdapterGBeanData should be final.	56
	Parameter activationSpecInfoMap should be final.	57
	Parameter adminObjectInfoMap should be final.	58
	Parameter managedConnectionFactoryInfoMap should be final.	59
	Parameter displayName should be final.	60
	Parameter description should be final.	61
	Parameter vendorName should be final.	62
	Parameter resourceAdapterVersion should be final.	63
	Parameter eisType should be final.	64
	Missing a Javadoc comment.	86
	Missing a Javadoc comment.	90
	Missing a Javadoc comment.	94
	Missing a Javadoc comment.	98
	Missing a Javadoc comment.	102
	Missing a Javadoc comment.	106
	Missing a Javadoc comment.	110
	Missing a Javadoc comment.	117
	Missing a Javadoc comment.	121
	Missing a Javadoc comment.	125
	Missing a Javadoc comment.	129
	Missing a Javadoc comment.	133
	Missing a Javadoc comment.	137
	Missing a Javadoc comment.	141
	Missing a Javadoc comment.	145
	Missing a Javadoc comment.	149
	Missing a Javadoc comment.	153
	Missing a Javadoc comment.	157
	Missing a Javadoc comment.	161
	First sentence should end with a period.	165
	Parameter objectName should be final.	170
	'objectName' hides a field.	170
	Expected @param tag for 'objectName'.	170
	Line is longer than 120 characters.	176
	Line is longer than 120 characters.	179
	Line is longer than 120 characters.	182
	Line is longer than 120 characters.	185
	'4' is a magic number.	187
	Line is longer than 120 characters.	188

org/apache/geronimo/connector/outbound/LocalXAResourceInsertionInterceptor.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	22
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	40
	Parameter connectionInfo should be final.	40
	Missing a Javadoc comment.	47
	Parameter connectionInfo should be final.	48
	Parameter connectionReturnAction should be final.	49
	Missing a Javadoc comment.	53
	Line has trailing spaces.	54

org/apache/geronimo/connector/outbound/SubjectInterceptor.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	27
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	43
	Parameter connectionInfo should be final.	43
	Avoid inline conditionals.	60
	Line is longer than 120 characters.	62
	Missing a Javadoc comment.	90
	Parameter connectionInfo should be final.	91
	Parameter connectionReturnAction should be final.	92
	Missing a Javadoc comment.	96

org/apache/geronimo/connector/outbound/connectionmanagerconfig/XATransactions.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	38
	Parameter useTransactionCaching should be final.	38
	Parameter useThreadCaching should be final.	38
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	47
	Parameter useTransactionCaching should be final.	47
	Missing a Javadoc comment.	51
	Missing a Javadoc comment.	55
	Parameter useThreadCaching should be final.	55
	Missing a Javadoc comment.	59
	Parameter stack should be final.	59
	Parameter name should be final.	59
	Line is longer than 120 characters.	63
	Missing a Javadoc comment.	63
	Parameter stack should be final.	63
	Parameter transactionManager should be final.	63

org/apache/geronimo/connector/work/GeronimoWorkManagerGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	30
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	38
	Parameter sync should be final.	38
	Parameter start should be final.	38
	Parameter sched should be final.	38
	Parameter xaWork should be final.	38
	Missing a Javadoc comment.	42
	Line is longer than 120 characters.	45
	Missing a Javadoc comment.	63

org/apache/geronimo/connector/outbound/GenericConnectionManager.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	40
	Parameter transactionSupport should be final.	40
	Parameter pooling should be final.	41
	Parameter containerManagedSecurity should be final.	42
	Parameter connectionTracker should be final.	43
	Parameter transactionManager should be final.	44
	Parameter objectName should be final.	45
	Parameter classLoader should be final.	46
	Line is longer than 120 characters.	47
	Missing a Javadoc comment.	50
	Missing a Javadoc comment.	52
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	54
	First sentence should end with a period.	56
	Parameter transactionSupport should be final.	69
	Expected @param tag for 'transactionSupport'.	69
	Parameter pooling should be final.	70
	Expected @param tag for 'pooling'.	70
	Parameter containerManagedSecurity should be final.	71
	Expected @param tag for 'containerManagedSecurity'.	71
	Parameter objectName should be final.	72
	Expected @param tag for 'objectName'.	72
	Parameter connectionTracker should be final.	73
	Expected @param tag for 'connectionTracker'.	73
	Parameter transactionManager should be final.	74
	Expected @param tag for 'transactionManager'.	74
	Parameter classLoader should be final.	75
	Expected @param tag for 'classLoader'.	75
	Line is longer than 120 characters.	77
	'stack' hides a field.	83
	'recoveryStack' hides a field.	94
	Missing a Javadoc comment.	109
	Missing a Javadoc comment.	113
	Missing a Javadoc comment.	117

org/apache/geronimo/connector/outbound/LocalXAResource.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	39
	Variable 'localTransaction' must be private and have accessor methods.	39
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	44
	Parameter localTransaction should be final.	44
	Parameter name should be final.	44
	Missing a Javadoc comment.	51
	Parameter xid should be final.	51
	'xid' hides a field.	51
	Parameter flag should be final.	51
	'cast' is not followed by whitespace.	58
	Missing a Javadoc comment.	65
	Parameter xid should be final.	65
	'xid' hides a field.	65
	Missing a Javadoc comment.	69
	Missing a Javadoc comment.	73
	Parameter xares should be final.	73
	Missing a Javadoc comment.	77
	Parameter n should be final.	77
	Missing a Javadoc comment.	81
	Parameter xid should be final.	81
	'xid' hides a field.	81
	'cast' is not followed by whitespace.	88
	Missing a Javadoc comment.	94
	Parameter txTimeout should be final.	94
	Missing a Javadoc comment.	99
	Parameter xid should be final.	99
	'xid' hides a field.	99
	Parameter flag should be final.	99
	Missing a Javadoc comment.	120
	Parameter xid should be final.	120
	'xid' hides a field.	120
	Parameter flag should be final.	120
	Missing a Javadoc comment.	127
	Parameter xid should be final.	127
	'xid' hides a field.	127
	Missing a Javadoc comment.	132

org/apache/geronimo/connector/DatabaseInitializationGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Utility classes should not have a public or default constructor.	39
	Line is longer than 120 characters.	42
	Missing a Javadoc comment.	42
	Parameter testSQL should be final.	42
	Parameter path should be final.	42
	Parameter cfSource should be final.	42
	Parameter classLoader should be final.	42
	Must have at least one statement.	53
	Missing a Javadoc comment.	87
	Line is longer than 120 characters.	93
	Missing a Javadoc comment.	101

org/apache/geronimo/connector/outbound/security/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/connector/outbound/AbstractConnectionManagerGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	29
	Line is longer than 120 characters.	32

org/apache/geronimo/connector/outbound/transactionlog/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/connector/work/pool/WorkExecutorPoolImpl.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Parameter maxSize should be final.	46
	Line has trailing spaces.	54
	Parameter work should be final.	60
	Expected an @return tag.	67
	Expected an @return tag.	74
	Parameter maxSize should be final.	82
	Missing a Javadoc comment.	86
	Expected an @return tag.	94

org/apache/geronimo/connector/outbound/JCAConnectionFactoryImpl.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	34
	Parameter objectName should be final.	34
	Parameter managedConnectionFactory should be final.	34
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	51
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	59
	Missing a Javadoc comment.	63
	First sentence should end with a period.	67
	Parameter objectName should be final.	72
	'objectName' hides a field.	72
	Expected @param tag for 'objectName'.	72
	Line is longer than 120 characters.	78
	Line is longer than 120 characters.	81
	Line is longer than 120 characters.	84
	Line is longer than 120 characters.	87
	Line is longer than 120 characters.	90

org/apache/geronimo/connector/outbound/PoolIdleReleaserTimer.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Utility classes should not have a public or default constructor.	24
	Missing a Javadoc comment.	26
	Name 'timer' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	26
	Missing a Javadoc comment.	28

org/apache/geronimo/connector/JCAResourceImpl.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	43
	Line is longer than 120 characters.	45
	Missing a Javadoc comment.	45
	Parameter objectName should be final.	45
	Parameter connectionFactories should be final.	45
	Parameter resourceAdapters should be final.	45
	Parameter adminObjects should be final.	45
	Missing a Javadoc comment.	52
	Missing a Javadoc comment.	56
	'cast' is not followed by whitespace.	62
	Missing a Javadoc comment.	65
	'cast' is not followed by whitespace.	66
	Missing a Javadoc comment.	69
	Line is longer than 120 characters.	70
	'cast' is not followed by whitespace.	70
	Missing a Javadoc comment.	73
	Missing a Javadoc comment.	77
	Parameter connectionFactoryInterface should be final.	77
	Missing a Javadoc comment.	81
	Parameter connectionFactoryInterfaces should be final.	81
	Missing a Javadoc comment.	106
	Missing a Javadoc comment.	110
	Missing a Javadoc comment.	114
	Parameter adminObjectInterface should be final.	114
	Missing a Javadoc comment.	118
	Parameter adminObjectInterfaces should be final.	118
	Missing a Javadoc comment.	137
	Missing a Javadoc comment.	141
	Missing a Javadoc comment.	145
	Missing a Javadoc comment.	149

org/apache/geronimo/connector/ConnectionReleaser.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	26

org/apache/geronimo/connector/outbound/connectiontracking/ConnectionTrackingCoordinatorGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	27
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	34
	Parameter monitorableTm should be final.	34
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	51
	'static' modifier out of order with the JLS suggestions.	51
	Line is longer than 120 characters.	54
	Line is longer than 120 characters.	56
	Missing a Javadoc comment.	65

org/apache/geronimo/connector/ResourceAdapterModuleImplGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Utility classes should not have a public or default constructor.	34
	Missing a Javadoc comment.	36
	Line is longer than 120 characters.	39
	Missing a Javadoc comment.	86

org/apache/geronimo/connector/outbound/GeronimoConnectionEventListener.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	31
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	54
	Parameter connectionEvent should be final.	54
	Missing a Javadoc comment.	70
	Parameter connectionEvent should be final.	70
	Line is longer than 120 characters.	78
	Missing a Javadoc comment.	84
	Parameter event should be final.	84
	First sentence should end with a period.	88
	Parameter event should be final.	94
	First sentence should end with a period.	97
	Parameter event should be final.	103
	Missing a Javadoc comment.	106
	Parameter connectionInfo should be final.	106
	Missing a Javadoc comment.	111
	Parameter connectionInfo should be final.	111
	Missing a Javadoc comment.	116
	Missing a Javadoc comment.	120
	Missing a Javadoc comment.	124
	Parameter connectionInfo should be final.	124
	Missing a Javadoc comment.	128
	Parameter connectionInfo should be final.	128
	Missing a Javadoc comment.	132

org/apache/geronimo/connector/ConnectorTransactionContext.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	38
	Parameter transaction should be final.	38
	Line is longer than 120 characters.	50
	Line is longer than 120 characters.	64
	Missing a Javadoc comment.	64
	Parameter transaction should be final.	64
	Parameter key should be final.	64
	Missing a Javadoc comment.	74
	Parameter transaction should be final.	74
	Missing a Javadoc comment.	78
	Line is longer than 120 characters.	80
	Missing a Javadoc comment.	80
	Parameter key should be final.	80
	Line is longer than 120 characters.	87
	Missing a Javadoc comment.	87
	Parameter key should be final.	87
	Parameter info should be final.	87
	Missing a Javadoc comment.	94
	Missing a Javadoc comment.	95
	Missing a Javadoc comment.	96
	Missing a Javadoc comment.	98
	Parameter ctx should be final.	98
	Parameter transaction should be final.	98
	Missing a Javadoc comment.	103
	Missing a Javadoc comment.	106
	Parameter status should be final.	106

org/apache/geronimo/connector/outbound/ConnectionFactorySource.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	33
	Name '$getResource' must match pattern '^[a-z][a-zA-Z0-9]*$'.	33

org/apache/geronimo/connector/outbound/connectionmanagerconfig/SinglePool.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	29
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	37
	Line is longer than 120 characters.	39
	Missing a Javadoc comment.	39
	Parameter maxSize should be final.	39
	Parameter minSize should be final.	39
	Parameter blockingTimeoutMilliseconds should be final.	39
	Parameter idleTimeoutMinutes should be final.	39
	Parameter matchOne should be final.	39
	Parameter matchAll should be final.	39
	Parameter selectOneAssumeMatch should be final.	39
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	53
	Parameter maxSize should be final.	53
	Missing a Javadoc comment.	57
	Missing a Javadoc comment.	61
	Parameter minSize should be final.	61
	Missing a Javadoc comment.	65
	Missing a Javadoc comment.	69
	Parameter blockingTimeoutMilliseconds should be final.	69
	Missing a Javadoc comment.	76
	Missing a Javadoc comment.	80
	Parameter idleTimeoutMinutes should be final.	80
	Missing a Javadoc comment.	87
	Missing a Javadoc comment.	91
	Parameter matchOne should be final.	91
	Missing a Javadoc comment.	95
	Missing a Javadoc comment.	99
	Parameter matchAll should be final.	99
	Missing a Javadoc comment.	103
	Missing a Javadoc comment.	107
	Parameter selectOneAssumeMatch should be final.	107
	Missing a Javadoc comment.	111
	Parameter tail should be final.	111
	'pool' hides a field.	113
	'pool' hides a field.	122
	Missing a Javadoc comment.	133
	Missing a Javadoc comment.	137
	Missing a Javadoc comment.	141
	Parameter maxSize should be final.	141
	'maxSize' hides a field.	141
	Missing a Javadoc comment.	148
	Missing a Javadoc comment.	152
	Parameter minSize should be final.	152
	'minSize' hides a field.	152
	Missing a Javadoc comment.	159
	Avoid inline conditionals.	160
	Missing a Javadoc comment.	163
	Avoid inline conditionals.	164

org/apache/geronimo/connector/outbound/security/PasswordCredentialLoginModuleWrapperGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Utility classes should not have a public or default constructor.	28
	Missing a Javadoc comment.	30
	Line is longer than 120 characters.	33
	Line is longer than 120 characters.	35
	Missing a Javadoc comment.	40

org/apache/geronimo/connector/ResourceAdapterWrapper.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	41
	Variable 'resourceAdapter' must be private and have accessor methods.	41
	First sentence should end with a period.	44
	Missing a Javadoc comment.	53
	Parameter resourceAdapterClass should be final.	53
	Parameter bootstrapContext should be final.	54
	Parameter cl should be final.	55
	Line has trailing spaces.	61
	Missing a Javadoc comment.	62
	Parameter resourceAdapter should be final.	62
	Parameter bootstrapContext should be final.	62
	Missing a Javadoc comment.	68
	Line is longer than 120 characters.	72
	Missing a Javadoc comment.	72
	Missing a Javadoc comment.	76
	Parameter ctx should be final.	76
	Missing a Javadoc comment.	80
	Line is longer than 120 characters.	85
	Missing a Javadoc comment.	85
	Line is longer than 120 characters.	89
	Missing a Javadoc comment.	89
	Missing a Javadoc comment.	93
	Parameter specs should be final.	93
	Missing a Javadoc comment.	97
	Missing a Javadoc comment.	101
	Missing a Javadoc comment.	105

org/apache/geronimo/connector/work/pool/NamedRunnable.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	23
	Missing a Javadoc comment.	24
	Missing a Javadoc comment.	26
	Parameter name should be final.	26
	Parameter runnable should be final.	26
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	35

org/apache/geronimo/connector/work/GeronimoWorkManager.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	68
	Missing a Javadoc comment.	70
	Missing a Javadoc comment.	71
	Missing a Javadoc comment.	72
	Missing a Javadoc comment.	81
	Parameter sync should be final.	81
	Parameter start should be final.	81
	Parameter sched should be final.	81
	Parameter xaWork should be final.	81
	Missing a Javadoc comment.	88
	Missing a Javadoc comment.	91
	Missing a Javadoc comment.	94
	Must have at least one statement.	97
	Missing a Javadoc comment.	102
	Missing a Javadoc comment.	106
	Missing a Javadoc comment.	110
	Missing a Javadoc comment.	117
	Parameter work should be final.	117
	Line is longer than 120 characters.	122
	Missing a Javadoc comment.	124
	Parameter work should be final.	125
	Parameter startTimeout should be final.	126
	Parameter execContext should be final.	127
	Parameter workListener should be final.	128
	Missing a Javadoc comment.	139
	Parameter work should be final.	139
	Line is longer than 120 characters.	147
	Missing a Javadoc comment.	149
	Parameter work should be final.	150
	Parameter startTimeout should be final.	151
	Parameter execContext should be final.	152
	Parameter workListener should be final.	153
	Missing a Javadoc comment.	165
	Parameter work should be final.	165
	Line is longer than 120 characters.	172
	Missing a Javadoc comment.	174
	Parameter work should be final.	175
	Parameter startTimeout should be final.	176
	Parameter execContext should be final.	177
	Parameter workListener should be final.	178
	Line is longer than 120 characters.	194
	Parameter work should be final.	194
	Parameter workExecutor should be final.	194
	Expected @param tag for 'workExecutor'.	194
	Parameter pooledExecutor should be final.	194
	Expected @param tag for 'pooledExecutor'.	194

org/apache/geronimo/connector/AdminObjectWrapper.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	46
	Missing a Javadoc comment.	47
	Expected @param tag for 'kernel'.	72
	Expected @param tag for 'abstractName'.	73
	Expected @param tag for 'objectName'.	74
	Line is longer than 120 characters.	75
	Expected @param tag for 'cl'.	75
	Expected @throws tag for 'IllegalAccessException'.	75
	Expected @throws tag for 'InstantiationException'.	75
	Expected @throws tag for 'ClassNotFoundException'.	75
	Missing a Javadoc comment.	87
	Name '$getResource' must match pattern '^[a-z][a-zA-Z0-9]*$'.	103
	Expected @throws tag for 'Exception'.	116
	Expected @throws tag for 'Exception'.	126
	First sentence should end with a period.	130
	Expected @param tag for 'name'.	138
	Expected @param tag for 'arguments'.	138
	Expected @param tag for 'types'.	138
	Expected @throws tag for 'Exception'.	138
	Expected an @return tag.	147
	'if' is not followed by whitespace.	152
	Missing a Javadoc comment.	160
	Parameter property should be final.	160
	Parameter value should be final.	160
	'if' is not followed by whitespace.	162
	'if' is not followed by whitespace.	163
	'if' is not followed by whitespace.	164
	'if' is not followed by whitespace.	166
	'if' is not followed by whitespace.	168
	'if' is not followed by whitespace.	170
	'if' is not followed by whitespace.	172
	'if' is not followed by whitespace.	174
	'if' is not followed by whitespace.	176
	'if' is not followed by whitespace.	178
	Missing a Javadoc comment.	188
	Parameter property should be final.	188
	Missing a Javadoc comment.	192
	Missing a Javadoc comment.	196
	Missing a Javadoc comment.	200
	Missing a Javadoc comment.	204

org/apache/geronimo/connector/outbound/connectionmanagerconfig/TransactionSupport.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	33
	Line is longer than 120 characters.	34
	Missing a Javadoc comment.	34

org/apache/geronimo/connector/outbound/connectionmanagerconfig/PartitionedPool.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	29
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	34
	Line is longer than 120 characters.	36
	Missing a Javadoc comment.	36
	More than 7 parameters.	36
	Parameter maxSize should be final.	36
	Parameter minSize should be final.	36
	Parameter blockingTimeoutMilliseconds should be final.	36
	Parameter idleTimeoutMinutes should be final.	36
	Parameter matchOne should be final.	36
	Parameter matchAll should be final.	36
	Parameter selectOneAssumeMatch should be final.	36
	Parameter partitionByConnectionRequestInfo should be final.	36
	Parameter partitionBySubject should be final.	36
	Line is longer than 120 characters.	37
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	46
	Parameter partitionByConnectionRequestInfo should be final.	46
	Missing a Javadoc comment.	50
	Missing a Javadoc comment.	54
	Parameter partitionBySubject should be final.	54
	Missing a Javadoc comment.	58
	Missing a Javadoc comment.	62
	Parameter maxSize should be final.	62
	Missing a Javadoc comment.	66
	Missing a Javadoc comment.	70
	Parameter blockingTimeoutMilliseconds should be final.	70
	Missing a Javadoc comment.	74
	Missing a Javadoc comment.	78
	Parameter idleTimeoutMinutes should be final.	78
	Missing a Javadoc comment.	82
	Missing a Javadoc comment.	86
	Parameter matchOne should be final.	86
	Missing a Javadoc comment.	90
	Missing a Javadoc comment.	94
	Parameter matchAll should be final.	94
	Missing a Javadoc comment.	98
	Missing a Javadoc comment.	102
	Parameter selectOneAssumeMatch should be final.	102
	Missing a Javadoc comment.	106
	Parameter tail should be final.	106
	Missing a Javadoc comment.	115
	Missing a Javadoc comment.	119
	Missing a Javadoc comment.	123
	Parameter maxSize should be final.	123
	Missing a Javadoc comment.	127
	Missing a Javadoc comment.	131
	Parameter minSize should be final.	131
	Missing a Javadoc comment.	135
	Missing a Javadoc comment.	139

org/apache/geronimo/connector/outbound/TransactionEnlistingInterceptor.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	27
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40
	Parameter next should be final.	40
	Parameter transactionManager should be final.	40
	Missing a Javadoc comment.	45
	Parameter connectionInfo should be final.	45
	Line is longer than 120 characters.	50
	Parameter connectionInfo should be final.	78
	Parameter connectionReturnAction should be final.	79
	Missing a Javadoc comment.	98

org/apache/geronimo/connector/work/pool/WorkExecutor.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Expected @param tag for 'executor'.	28

org/apache/geronimo/connector/outbound/connectiontracking/ConnectionTrackingCoordinator.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	51
	Parameter newConnectorInstanceContext should be final.	51
	Missing a Javadoc comment.	59
	Parameter oldConnectorInstanceContext should be final.	59
	Missing a Javadoc comment.	70
	Missing a Javadoc comment.	78
	Parameter reenteringConnectorInstanceContext should be final.	78
	Missing a Javadoc comment.	96
	Parameter connectionTrackingInterceptor should be final.	97
	Parameter connectionInfo should be final.	98
	Missing a Javadoc comment.	112
	Parameter connectionTrackingInterceptor should be final.	113
	Parameter connectionInfo should be final.	114
	Missing a Javadoc comment.	131
	Parameter connectionInfo should be final.	131
	Parameter key should be final.	131
	Line is longer than 120 characters.	132
	Line is longer than 120 characters.	137

org/apache/geronimo/connector/ResourceAdapterWrapperGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	34
	Line is longer than 120 characters.	37
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	42
	'=' is not preceded with whitespace.	43
	'=' is not followed by whitespace.	43
	Line is longer than 120 characters.	47
	Missing a Javadoc comment.	47
	Parameter resourceAdapterClass should be final.	47
	Parameter workManager should be final.	47
	Parameter xaTerminator should be final.	47
	Parameter cl should be final.	47
	Parameter objectName should be final.	47
	Missing a Javadoc comment.	54
	Parameter name should be final.	54
	Missing a Javadoc comment.	58
	Parameter name should be final.	58
	Parameter value should be final.	58
	Missing a Javadoc comment.	62
	Parameter name should be final.	62
	Parameter arguments should be final.	62
	Parameter types should be final.	62
	Missing a Javadoc comment.	67
	Missing a Javadoc comment.	71
	Missing a Javadoc comment.	75
	Missing a Javadoc comment.	79
	Missing a Javadoc comment.	83
	Line is longer than 120 characters.	86
	Line is longer than 120 characters.	99
	Missing a Javadoc comment.	104

org/apache/geronimo/connector/outbound/connectionmanagerconfig/LocalTransactions.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Class LocalTransactions should be declared as final.	33
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	39
	Parameter stack should be final.	39
	Parameter name should be final.	39
	Line is longer than 120 characters.	43
	Missing a Javadoc comment.	43
	Parameter stack should be final.	43
	Parameter transactionManager should be final.	43

org/apache/geronimo/connector/ConnectorMethodInterceptor.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	44
	Parameter kernelName should be final.	44
	Parameter targetName should be final.	44
	Line is longer than 120 characters.	49
	Missing a Javadoc comment.	49
	Parameter objects should be final.	49
	Missing a Javadoc comment.	61
	Missing a Javadoc comment.	65

org/apache/geronimo/connector/outbound/ManagedConnectionFactoryWrapper.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Unused import - javax.management.ObjectName.	25
	Line is longer than 120 characters.	49
	Missing a Javadoc comment.	51
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	51
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	54
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	56
	Missing a Javadoc comment.	57
	Missing a Javadoc comment.	58
	Missing a Javadoc comment.	60
	Missing a Javadoc comment.	62
	Missing a Javadoc comment.	63
	Missing a Javadoc comment.	65
	Missing a Javadoc comment.	67
	Missing a Javadoc comment.	69
	Missing a Javadoc comment.	72
	Missing a Javadoc comment.	73
	Missing a Javadoc comment.	74
	Missing a Javadoc comment.	75
	Missing a Javadoc comment.	76
	Missing a Javadoc comment.	77
	Missing a Javadoc comment.	78
	Missing a Javadoc comment.	79
	Missing a Javadoc comment.	82
	Missing a Javadoc comment.	99
	More than 7 parameters.	99
	Parameter managedConnectionFactoryClass should be final.	99
	Parameter connectionFactoryInterface should be final.	100
	Parameter implementedInterfaces should be final.	101
	Parameter connectionFactoryImplClass should be final.	102
	Parameter connectionInterface should be final.	103
	Parameter connectionImplClass should be final.	104
	Parameter resourceAdapterWrapper should be final.	105
	Parameter connectionManagerContainer should be final.	106
	Parameter kernel should be final.	107
	Parameter abstractName should be final.	108
	Parameter objectName should be final.	109
	Line is longer than 120 characters.	110
	Parameter cl should be final.	110
	'cast' is not followed by whitespace.	123
	Line has trailing spaces.	124
	Missing a Javadoc comment.	149
	Missing a Javadoc comment.	153
	Missing a Javadoc comment.	157
	Missing a Javadoc comment.	161
	Missing a Javadoc comment.	165
	Missing a Javadoc comment.	169
	Missing a Javadoc comment.	173
	Missing a Javadoc comment.	177
	Missing a Javadoc comment.	181
	Missing a Javadoc comment.	185
	Line is longer than 120 characters.	189
	Line is longer than 120 characters.	191
	';' is not followed by whitespace.	204
	Missing a Javadoc comment.	218
	Missing a Javadoc comment.	225
	Missing a Javadoc comment.	230
	Parameter name should be final.	230
	Missing a Javadoc comment.	241
	Parameter name should be final.	241
	Parameter value should be final.	241
	Missing a Javadoc comment.	252
	Parameter name should be final.	252
	Parameter arguments should be final.	252
	Parameter types should be final.	252
	Missing a Javadoc comment.	257
	Missing a Javadoc comment.	261
	Name '$getResource' must match pattern '^[a-z][a-zA-Z0-9]*$'.	261
	Missing a Javadoc comment.	265
	Name '$getConnectionFactory' must match pattern '^[a-z][a-zA-Z0-9]*$'.	265
	Missing a Javadoc comment.	269
	Name '$getManagedConnectionFactory' must match pattern '^[a-z][a-zA-Z0-9]*$'.	269
	Expected an @return tag.	277
	'if' is not followed by whitespace.	282
	Missing a Javadoc comment.	290
	Parameter property should be final.	290
	Parameter value should be final.	290
	'if' is not followed by whitespace.	292
	'if' is not followed by whitespace.	293
	'if' is not followed by whitespace.	294
	'if' is not followed by whitespace.	296
	'if' is not followed by whitespace.	298
	'if' is not followed by whitespace.	300
	'if' is not followed by whitespace.	302
	'if' is not followed by whitespace.	304
	'if' is not followed by whitespace.	306
	'if' is not followed by whitespace.	308
	Missing a Javadoc comment.	318
	Parameter property should be final.	318
	Missing a Javadoc comment.	323
	Line is longer than 120 characters.	327
	Missing a Javadoc comment.	331
	Parameter xaResource should be final.	331
	Missing a Javadoc comment.	335
	Missing a Javadoc comment.	339
	Missing a Javadoc comment.	343
	Missing a Javadoc comment.	347

org/apache/geronimo/connector/outbound/PoolingAttributes.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	24
	Missing a Javadoc comment.	26
	Missing a Javadoc comment.	28
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	44

org/apache/geronimo/connector/outbound/security/ResourcePrincipal.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	32
	Parameter resourcePrincipal should be final.	32
	Missing a Javadoc comment.	36

org/apache/geronimo/connector/outbound/TxUtil.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	28
	Missing a Javadoc comment.	31
	Parameter transactionManager should be final.	31
	'if' construct must use '{}'s.	36
	Must have at least one statement.	37
	Missing a Javadoc comment.	46
	Parameter transactionManager should be final.	46
	Missing a Javadoc comment.	55
	Parameter transaction should be final.	55

org/apache/geronimo/connector/outbound/connectiontracking/ConnectionTracker.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	38

org/apache/geronimo/connector/outbound/connectionmanagerconfig/NoPool.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	29
	Parameter tail should be final.	29
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	49
	Parameter maxSize should be final.	49
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	57
	Parameter minSize should be final.	57
	Missing a Javadoc comment.	61
	Missing a Javadoc comment.	65
	Parameter timeoutMilliseconds should be final.	65
	Missing a Javadoc comment.	69
	Missing a Javadoc comment.	73
	Parameter idleTimeoutMinutes should be final.	73

org/apache/geronimo/connector/outbound/ConnectionInterceptorSource.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	10

org/apache/geronimo/connector/outbound/transactionlog/JDBCLog.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line is longer than 120 characters.	49
	Missing a Javadoc comment.	49
	'static' modifier out of order with the JLS suggestions.	49
	Line is longer than 120 characters.	50
	Missing a Javadoc comment.	50
	'static' modifier out of order with the JLS suggestions.	50
	Line is longer than 120 characters.	51
	Missing a Javadoc comment.	51
	'static' modifier out of order with the JLS suggestions.	51
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	54
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	57
	Parameter systemId should be final.	57
	Parameter managedConnectionFactoryWrapper should be final.	57
	Missing a Javadoc comment.	62
	Parameter systemId should be final.	62
	Parameter dataSource should be final.	62
	Missing a Javadoc comment.	68
	Missing a Javadoc comment.	72
	Missing a Javadoc comment.	76
	Missing a Javadoc comment.	79
	Parameter xid should be final.	79
	Missing a Javadoc comment.	82
	Parameter xid should be final.	82
	Parameter branches should be final.	82
	'3' is a magic number.	96
	'4' is a magic number.	97
	'5' is a magic number.	98
	Missing a Javadoc comment.	116
	Parameter xid should be final.	116
	Parameter logMark should be final.	116
	'3' is a magic number.	125
	Missing a Javadoc comment.	141
	Parameter xid should be final.	141
	Parameter logMark should be final.	141
	Line is longer than 120 characters.	142
	Missing a Javadoc comment.	145
	Parameter xidFactory should be final.	145
	'3' is a magic number.	162
	'4' is a magic number.	163
	Missing a Javadoc comment.	189
	Missing a Javadoc comment.	193
	Missing a Javadoc comment.	197

org/apache/geronimo/connector/outbound/MCFConnectionInterceptor.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	23
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	36
	Parameter connectionInfo should be final.	36
	Missing a Javadoc comment.	51
	Parameter connectionInfo should be final.	52
	Parameter connectionReturnAction should be final.	53
	Must have at least one statement.	58
	Must have at least one statement.	62
	Missing a Javadoc comment.	67
	Line has trailing spaces.	70
	Missing a Javadoc comment.	71
	Parameter stack should be final.	71

org/apache/geronimo/connector/work/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/connector/outbound/connectiontracking/ConnectorInstanceContextImpl.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	36
	Parameter unshareableResources should be final.	36
	Parameter applicationManagedSecurityResources should be final.	36
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	49

org/apache/geronimo/connector/ActivationSpecWrapperGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	30
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	37
	Line is longer than 120 characters.	41
	Missing a Javadoc comment.	41
	Expected @throws tag for 'Exception'.	56
	Expected @throws tag for 'Exception'.	67
	First sentence should end with a period.	71
	Expected @param tag for 'name'.	80
	Expected @param tag for 'arguments'.	80
	Expected @param tag for 'types'.	80
	Expected @throws tag for 'Exception'.	80
	Missing a Javadoc comment.	85
	Line is longer than 120 characters.	88
	Missing a Javadoc comment.	109

org/apache/geronimo/connector/ResourceAdapterImpl.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	26
	Missing a Javadoc comment.	27
	Missing a Javadoc comment.	29
	Parameter objectName should be final.	29
	Parameter jcaResource should be final.	29
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	46
	Missing a Javadoc comment.	50
	Missing a Javadoc comment.	54

org/apache/geronimo/connector/outbound/transactionlog/LogXAResource.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	37
	Variable 'name' must be private and have accessor methods.	37
	Missing a Javadoc comment.	38
	Variable 'localTransaction' must be private and have accessor methods.	38
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	41
	Parameter localTransaction should be final.	41
	Parameter name should be final.	41
	Missing a Javadoc comment.	45
	Parameter xid should be final.	45
	'xid' hides a field.	45
	Parameter onePhase should be final.	45
	Missing a Javadoc comment.	48
	Parameter xid should be final.	48
	'xid' hides a field.	48
	Parameter flags should be final.	48
	Missing a Javadoc comment.	51
	Parameter xid should be final.	51
	'xid' hides a field.	51
	Missing a Javadoc comment.	54
	Missing a Javadoc comment.	58
	Parameter xaResource should be final.	58
	Missing a Javadoc comment.	62
	Parameter xid should be final.	62
	'xid' hides a field.	62
	Missing a Javadoc comment.	66
	Parameter flag should be final.	66
	Missing a Javadoc comment.	70
	Parameter xid should be final.	70
	'xid' hides a field.	70
	'cast' is not followed by whitespace.	77
	Missing a Javadoc comment.	83
	Parameter seconds should be final.	83
	Missing a Javadoc comment.	87
	Parameter xid should be final.	87
	'xid' hides a field.	87
	Parameter flag should be final.	87
	Missing a Javadoc comment.	108

org/apache/geronimo/connector/outbound/TCCLInterceptor.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	'{' is not preceded with whitespace.	24
	Missing a Javadoc comment.	25
	Missing a Javadoc comment.	26
	Missing a Javadoc comment.	28
	Parameter next should be final.	28
	Parameter classLoader should be final.	28
	Missing a Javadoc comment.	34
	Parameter connectionInfo should be final.	34
	Missing a Javadoc comment.	45
	Parameter connectionInfo should be final.	45
	Parameter connectionReturnAction should be final.	45
	Line has trailing spaces.	55
	Missing a Javadoc comment.	56

org/apache/geronimo/connector/work/pool/NullWorkExecutorPool.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	29
	Missing a Javadoc comment.	31
	Parameter maxSize should be final.	31
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	43
	Parameter maxSize should be final.	43
	'maxSize' hides a field.	43
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	51
	Missing a Javadoc comment.	55
	Parameter command should be final.	55

org/apache/geronimo/connector/work/pool/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/connector/work/pool/SyncWorkExecutor.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	36
	Parameter work should be final.	36
	Parameter executor should be final.	36

org/apache/geronimo/connector/outbound/connectiontracking/ConnectorInstanceContext.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	35

org/apache/geronimo/connector/JCAResourceImplGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	28
	Utility classes should not have a public or default constructor.	28
	Missing a Javadoc comment.	30
	Line is longer than 120 characters.	33
	Missing a Javadoc comment.	50

org/apache/geronimo/connector/outbound/ConnectionTrackingInterceptor.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	45
	Line is longer than 120 characters.	59
	Parameter connectionInfo should be final.	64
	Expected @param tag for 'connectionInfo'.	64
	Expected @throws tag for 'ResourceException'.	64
	Line is longer than 120 characters.	71
	Line is longer than 120 characters.	72
	Parameter connectionInfo should be final.	79
	Expected @param tag for 'connectionInfo'.	79
	Parameter connectionReturnAction should be final.	80
	Expected @param tag for 'connectionReturnAction'.	80
	Missing a Javadoc comment.	85
	Line has trailing spaces.	88
	Missing a Javadoc comment.	89
	Parameter connectionInfos should be final.	89
	Missing a Javadoc comment.	98
	Parameter connectionInfos should be final.	98

org/apache/geronimo/connector/outbound/security/PasswordCredentialLoginModuleWrapper.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	29
	Line is longer than 120 characters.	31
	Missing a Javadoc comment.	31
	Parameter loginModuleClass should be final.	31
	Parameter objectName should be final.	31
	Parameter serverSide should be final.	31
	Parameter wrapPrincipals should be final.	31
	Parameter managedConnectionFactoryWrapper should be final.	31
	Parameter classLoader should be final.	31
	Line is longer than 120 characters.	33

org/apache/geronimo/connector/outbound/ConnectionInterceptor.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	37

org/apache/geronimo/connector/outbound/AbstractSinglePoolConnectionInterceptor.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	41
	Variable 'log' must be private and have accessor methods.	41
	Missing a Javadoc comment.	42
	Variable 'next' must be private and have accessor methods.	42
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	44
	Variable 'permits' must be private and have accessor methods.	44
	Missing a Javadoc comment.	45
	Variable 'blockingTimeoutMilliseconds' must be private and have accessor methods.	45
	Missing a Javadoc comment.	46
	Variable 'connectionCount' must be private and have accessor methods.	46
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	48
	Missing a Javadoc comment.	49
	Variable 'timer' must be private and have accessor methods.	49
	Missing a Javadoc comment.	50
	Variable 'maxSize' must be private and have accessor methods.	50
	Missing a Javadoc comment.	51
	Variable 'minSize' must be private and have accessor methods.	51
	Missing a Javadoc comment.	52
	Variable 'shrinkLater' must be private and have accessor methods.	52
	Missing a Javadoc comment.	53
	Variable 'destroyed' must be private and have accessor methods.	53
	Missing a Javadoc comment.	55
	Parameter maxSize should be final.	56
	Parameter minSize should be final.	57
	Parameter blockingTimeoutMilliseconds should be final.	58
	Parameter idleTimeoutMinutes should be final.	59
	Missing a Javadoc comment.	68
	Parameter connectionInfo should be final.	68
	Missing a Javadoc comment.	93
	Missing a Javadoc comment.	95
	Parameter connectionInfo should be final.	95
	Parameter connectionReturnAction should be final.	96
	Must have at least one statement.	105
	Line is longer than 120 characters.	128
	Missing a Javadoc comment.	128
	Missing a Javadoc comment.	130
	Missing a Javadoc comment.	133
	'if' construct must use '{}'s.	135
	Missing a Javadoc comment.	141
	Missing a Javadoc comment.	145
	Missing a Javadoc comment.	147
	Parameter newMaxSize should be final.	147
	Line is longer than 120 characters.	154
	Line is longer than 120 characters.	158
	Missing a Javadoc comment.	172
	Missing a Javadoc comment.	174
	Missing a Javadoc comment.	175
	Missing a Javadoc comment.	176
	Missing a Javadoc comment.	177
	Line is longer than 120 characters.	179
	Missing a Javadoc comment.	179
	'shrinkLater' hides a field.	181
	'shrinkNow' hides a field.	186
	Missing a Javadoc comment.	199
	Missing a Javadoc comment.	203
	Missing a Javadoc comment.	207
	Missing a Javadoc comment.	211
	Missing a Javadoc comment.	218
	'maxSize' hides a field.	218
	Missing a Javadoc comment.	220
	Missing a Javadoc comment.	222
	Missing a Javadoc comment.	226
	Missing a Javadoc comment.	230
	Parameter minSize should be final.	230
	'minSize' hides a field.	230
	Missing a Javadoc comment.	234
	Missing a Javadoc comment.	238
	Parameter blockingTimeoutMilliseconds should be final.	238
	Line is longer than 120 characters.	240
	Missing a Javadoc comment.	249
	'1000' is a magic number.	250
	'60' is a magic number.	250
	Missing a Javadoc comment.	253
	Parameter idleTimeoutMinutes should be final.	253
	'60' is a magic number.	261
	'1000' is a magic number.	261
	Missing a Javadoc comment.	267
	Missing a Javadoc comment.	269
	Class IdleReleaser should be declared as final.	273
	Missing a Javadoc comment.	273
	Missing a Javadoc comment.	274
	Missing a Javadoc comment.	276
	Parameter parent should be final.	276
	Missing a Javadoc comment.	280
	Missing a Javadoc comment.	285
	'if' construct must use '{}'s.	288
	Missing a Javadoc comment.	311
	Missing a Javadoc comment.	312
	Missing a Javadoc comment.	313
	Missing a Javadoc comment.	314
	Missing a Javadoc comment.	316
	Parameter connectionInfo should be final.	316
	Missing a Javadoc comment.	322

org/apache/geronimo/connector/outbound/connectiontracking/GeronimoTransactionListener.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	31
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	31
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	34
	Parameter trackedConnectionAssociator should be final.	34
	Missing a Javadoc comment.	38
	Parameter transaction should be final.	38
	Missing a Javadoc comment.	46
	Parameter transaction should be final.	46

org/apache/geronimo/connector/ActivationSpecWrapper.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	40
	Variable 'activationSpec' must be private and have accessor methods.	40
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	43
	Expected @param tag for 'containerId'.	62
	Expected @param tag for 'resourceAdapterWrapper'.	63
	Line is longer than 120 characters.	64
	Expected @param tag for 'cl'.	64
	Expected @throws tag for 'IllegalAccessException'.	64
	Expected @throws tag for 'InstantiationException'.	64
	Expected @throws tag for 'ClassNotFoundException'.	64
	Parameter activationSpec should be final.	73
	Expected @param tag for 'activationSpec'.	73
	Parameter resourceAdapterWrapper should be final.	73
	Expected @param tag for 'resourceAdapterWrapper'.	73
	Missing a Javadoc comment.	92
	Missing a Javadoc comment.	98
	Missing a Javadoc comment.	106
	Missing a Javadoc comment.	117
	Line is longer than 120 characters.	128
	Missing a Javadoc comment.	132
	Parameter xaResource should be final.	132

org/apache/geronimo/connector/outbound/JCAConnectionFactoryImplGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	26
	Utility classes should not have a public or default constructor.	29
	Missing a Javadoc comment.	31
	Line is longer than 120 characters.	34
	Line is longer than 120 characters.	37
	Missing a Javadoc comment.	45

org/apache/geronimo/connector/work/pool/ScheduleWorkExecutor.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	35
	Parameter work should be final.	35
	Parameter executor should be final.	35

org/apache/geronimo/connector/outbound/TransactionCachingInterceptor.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Comment matches to-do format 'TODO:'.	35
	Comment matches to-do format 'TODO:'.	36
	Comment matches to-do format 'TODO:'.	38
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	56
	Missing a Javadoc comment.	58
	Parameter next should be final.	58
	Parameter transactionManager should be final.	58
	Missing a Javadoc comment.	63
	Parameter connectionInfo should be final.	63
	Missing a Javadoc comment.	91
	Parameter connectionInfo should be final.	91
	Parameter connectionReturnAction should be final.	91
	Must have at least one statement.	109
	Missing a Javadoc comment.	115
	Parameter connectionInfo should be final.	115
	Parameter connectionReturnAction should be final.	115
	Missing a Javadoc comment.	123
	Missing a Javadoc comment.	127
	Parameter stuff should be final.	127
	Missing a Javadoc comment.	139
	Parameter managedConnectionInfo should be final.	139
	Missing a Javadoc comment.	145
	Missing a Javadoc comment.	146
	Missing a Javadoc comment.	147
	Missing a Javadoc comment.	149
	Missing a Javadoc comment.	153
	Parameter shared should be final.	153
	Missing a Javadoc comment.	157
	Missing a Javadoc comment.	161
	Parameter unsharedMCI should be final.	161
	Missing a Javadoc comment.	168
	Parameter unsharedMCI should be final.	168
	Missing a Javadoc comment.	172
	Parameter managedConnectionInfo should be final.	172

org/apache/geronimo/connector/outbound/security/CallerIdentityPasswordCredentialLoginModule.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	48
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	51
	Parameter subject should be final.	51
	'subject' hides a field.	51
	Parameter callbackHandler should be final.	51
	'callbackHandler' hides a field.	51
	Parameter sharedState should be final.	52
	Parameter options should be final.	52
	Line is longer than 120 characters.	55
	Missing a Javadoc comment.	61
	Missing a Javadoc comment.	82
	Missing a Javadoc comment.	90
	Missing a Javadoc comment.	97

org/apache/geronimo/connector/AdminObjectWrapperGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	28
	Utility classes should not have a public or default constructor.	31
	Missing a Javadoc comment.	33
	Line is longer than 120 characters.	36
	Missing a Javadoc comment.	59

org/apache/geronimo/connector/outbound/AbstractConnectionManager.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line is longer than 120 characters.	32
	Missing a Javadoc comment.	33
	Variable 'interceptors' must be private and have accessor methods.	33
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	40
	Parameter interceptors should be final.	40
	Missing a Javadoc comment.	44
	Parameter mcf should be final.	44
	Missing a Javadoc comment.	48
	Line has trailing spaces.	51
	Expected an @return tag.	56
	Parameter managedConnectionFactory should be final.	56
	Expected @param tag for 'managedConnectionFactory'.	56
	Parameter connectionRequestInfo should be final.	57
	Expected @param tag for 'connectionRequestInfo'.	57
	Expected @throws tag for 'ResourceException'.	58
	Parameter connection should be final.	70
	Expected @param tag for 'connection'.	70
	Parameter managedConnectionFactory should be final.	71
	Expected @param tag for 'managedConnectionFactory'.	71
	Parameter connectionRequestInfo should be final.	72
	Expected @param tag for 'connectionRequestInfo'.	72
	Expected @throws tag for 'ResourceException'.	73
	Missing a Javadoc comment.	80
	Line is longer than 120 characters.	85
	Missing a Javadoc comment.	85
	Parameter managedConnectionFactory should be final.	85
	Line is longer than 120 characters.	94
	Missing a Javadoc comment.	99
	Missing a Javadoc comment.	103
	Missing a Javadoc comment.	107
	Parameter maxSize should be final.	107
	Missing a Javadoc comment.	111
	Missing a Javadoc comment.	115
	Parameter minSize should be final.	115
	Missing a Javadoc comment.	119
	Missing a Javadoc comment.	123
	Missing a Javadoc comment.	127
	Missing a Javadoc comment.	131
	Parameter timeoutMilliseconds should be final.	131
	Missing a Javadoc comment.	135
	Missing a Javadoc comment.	139
	Parameter idleTimeoutMinutes should be final.	139
	Missing a Javadoc comment.	143
	Missing a Javadoc comment.	147
	Missing a Javadoc comment.	152
	Missing a Javadoc comment.	156
	Missing a Javadoc comment.	157
	Missing a Javadoc comment.	159
	Missing a Javadoc comment.	161
	Missing a Javadoc comment.	164
	Missing a Javadoc comment.	168
	Missing a Javadoc comment.	172

org/apache/geronimo/connector/outbound/connectionmanagerconfig/PoolingSupport.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	30

org/apache/geronimo/connector/outbound/ConnectionManagerContainer.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	29
	Missing a Javadoc comment.	36
	Line is longer than 120 characters.	38
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	45
	Line is longer than 120 characters.	47
	Missing a Javadoc comment.	47
	Parameter delegate should be final.	47
	Parameter stack should be final.	47
	Parameter connectionInfo should be final.	47
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	57
	Missing a Javadoc comment.	61
	Parameter xid should be final.	61
	Parameter onePhase should be final.	61
	Missing a Javadoc comment.	65
	Parameter xid should be final.	65
	Parameter flags should be final.	65
	Missing a Javadoc comment.	69
	Parameter xid should be final.	69
	Missing a Javadoc comment.	73
	Missing a Javadoc comment.	77
	Parameter other should be final.	77
	'cast' is not followed by whitespace.	79
	Missing a Javadoc comment.	84
	Parameter xid should be final.	84
	Missing a Javadoc comment.	88
	Parameter flag should be final.	88
	Missing a Javadoc comment.	92
	Parameter xid should be final.	92
	Missing a Javadoc comment.	96
	Parameter seconds should be final.	96
	Missing a Javadoc comment.	100
	Parameter xid should be final.	100
	Parameter flags should be final.	100

org/apache/geronimo/connector/outbound/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/connector/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/connector/ResourceAdapterImplGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	26
	Utility classes should not have a public or default constructor.	26
	Missing a Javadoc comment.	28
	Line is longer than 120 characters.	31
	Missing a Javadoc comment.	45

org/apache/geronimo/connector/work/pool/WorkExecutorPool.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Redundant 'public' modifier.	36
	Redundant 'public' modifier.	43
	Redundant 'public' modifier.	50
	Missing a Javadoc comment.	52
	Redundant 'public' modifier.	52
	Missing a Javadoc comment.	54
	Redundant 'public' modifier.	54

org/apache/geronimo/connector/work/pool/StartWorkExecutor.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	36
	Parameter work should be final.	36
	Parameter executor should be final.	36

org/apache/geronimo/connector/outbound/transactionlog/LogXAResourceInsertionInterceptor.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	27
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40
	Parameter name should be final.	40
	Missing a Javadoc comment.	45
	Parameter connectionInfo should be final.	45
	Missing a Javadoc comment.	53
	Parameter connectionInfo should be final.	54
	Parameter connectionReturnAction should be final.	55
	Missing a Javadoc comment.	59

org/apache/geronimo/connector/outbound/connectionmanagerconfig/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/connector/AdminObjectSource.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	33
	Name '$getResource' must match pattern '^[a-z][a-zA-Z0-9]*$'.	33

org/apache/geronimo/connector/outbound/ThreadLocalCachingConnectionInterceptor.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	43
	Parameter connectionInfo should be final.	43
	Missing a Javadoc comment.	74
	Parameter connectionInfo should be final.	74
	Parameter connectionReturnAction should be final.	74
	Line has trailing spaces.	79
	Missing a Javadoc comment.	80

org/apache/geronimo/connector/outbound/MultiPoolConnectionInterceptor.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	'{' is not preceded with whitespace.	40
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	49
	Line is longer than 120 characters.	51
	Missing a Javadoc comment.	52
	Missing a Javadoc comment.	54
	Parameter singlePoolFactory should be final.	56
	Missing a Javadoc comment.	65
	Parameter connectionInfo should be final.	65
	Avoid inline conditionals.	69
	Avoid inline conditionals.	70
	Missing a Javadoc comment.	87
	Parameter connectionInfo should be final.	88
	Parameter connectionReturnAction should be final.	89
	Missing a Javadoc comment.	95
	';' is followed by whitespace.	98
	'cast' is not followed by whitespace.	99
	'cast' is not followed by whitespace.	99
	Line has trailing spaces.	105
	Missing a Javadoc comment.	106
	Missing a Javadoc comment.	110
	Missing a Javadoc comment.	114
	Parameter maxSize should be final.	114
	Missing a Javadoc comment.	122
	Missing a Javadoc comment.	126
	Parameter minSize should be final.	126
	Missing a Javadoc comment.	134
	Missing a Javadoc comment.	143
	Missing a Javadoc comment.	152
	Missing a Javadoc comment.	156
	Parameter timeoutMilliseconds should be final.	156
	Missing a Javadoc comment.	164
	Missing a Javadoc comment.	168
	Parameter idleTimeoutMinutes should be final.	168
	Missing a Javadoc comment.	176
	Missing a Javadoc comment.	177
	Missing a Javadoc comment.	178
	Missing a Javadoc comment.	179
	Missing a Javadoc comment.	181
	Avoid inline conditionals.	187
	'17' is a magic number.	187
	'17' is a magic number.	187
	Avoid inline conditionals.	188
	Missing a Javadoc comment.	191
	Missing a Javadoc comment.	195
	Parameter other should be final.	195
	Avoid inline conditionals.	204
	Avoid inline conditionals.	206

org/apache/geronimo/connector/outbound/ConnectionInfo.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	20
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	39
	Parameter mci should be final.	39
	Parameter mci should be final.	55
	'mci' hides a field.	55
	Parameter connection should be final.	71
	'connection' hides a field.	71
	Missing a Javadoc comment.	76
	Missing a Javadoc comment.	80
	Parameter unshareable should be final.	80
	Missing a Javadoc comment.	84
	Missing a Javadoc comment.	88
	Parameter applicationManagedSecurity should be final.	88
	Missing a Javadoc comment.	92
	Parameter obj should be final.	92
	Missing a Javadoc comment.	104
	Avoid inline conditionals.	105
	'7' is a magic number.	105
	'^' should be on a new line.	105
	Avoid inline conditionals.	106
	'7' is a magic number.	106
	Missing a Javadoc comment.	109
	Missing a Javadoc comment.	113

org/apache/geronimo/connector/work/WorkerContext.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	48
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	48
	Parameter event should be final.	54
	Missing a Javadoc comment.	101
	Parameter work should be final.	129
	Parameter xaWork should be final.	129
	Expected @param tag for 'xaWork'.	129
	Parameter aWork should be final.	146
	Parameter aStartTimeout should be final.	147
	Parameter execContext should be final.	148
	Parameter xaWork should be final.	149
	Expected @param tag for 'xaWork'.	149
	Parameter workListener should be final.	150
	Missing a Javadoc comment.	163
	Parameter aPriority should be final.	175
	Parameter anObject should be final.	198
	':' is not preceded with whitespace.	233
	'&&' should be on a new line.	239
	Avoid inline conditionals.	245
	Missing a Javadoc comment.	274
	Avoid inline conditionals.	296
	Line is longer than 120 characters.	298
	Line is longer than 120 characters.	300
	Line is longer than 120 characters.	302
	Line is longer than 120 characters.	304
	Line is longer than 120 characters.	315
	Avoid inline conditionals.	315
	Missing a Javadoc comment.	345

org/apache/geronimo/connector/GeronimoBootstrapContextGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	28
	Utility classes should not have a public or default constructor.	31
	Missing a Javadoc comment.	33
	Line is longer than 120 characters.	36
	Missing a Javadoc comment.	46

org/apache/geronimo/connector/outbound/ManagedConnectionInfo.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	28
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	46
	Missing a Javadoc comment.	48
	Parameter managedConnectionFactory should be final.	49
	Parameter connectionRequestInfo should be final.	50
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	59
	Parameter managedConnectionFactory should be final.	59
	Missing a Javadoc comment.	63
	Missing a Javadoc comment.	67
	Parameter cri should be final.	67
	Missing a Javadoc comment.	71
	Missing a Javadoc comment.	75
	Parameter subject should be final.	75
	Missing a Javadoc comment.	79
	Missing a Javadoc comment.	83
	Parameter managedConnection should be final.	83
	Missing a Javadoc comment.	88
	Missing a Javadoc comment.	92
	Parameter xares should be final.	92
	'xares' hides a field.	92
	Missing a Javadoc comment.	96
	Missing a Javadoc comment.	100
	Parameter lastUsed should be final.	100
	Missing a Javadoc comment.	104
	Parameter poolInterceptor should be final.	104
	Missing a Javadoc comment.	108
	Missing a Javadoc comment.	112
	Parameter listener should be final.	112
	'listener' hides a field.	112
	Missing a Javadoc comment.	116
	Parameter connectionInfo should be final.	116
	Missing a Javadoc comment.	120
	Parameter connectionInfo should be final.	120
	Missing a Javadoc comment.	124
	Missing a Javadoc comment.	128
	Missing a Javadoc comment.	132
	Missing a Javadoc comment.	136
	Parameter other should be final.	136
	Avoid inline conditionals.	139
	Avoid inline conditionals.	142
	Missing a Javadoc comment.	146
	Parameter connectionInfo should be final.	146
	Missing a Javadoc comment.	150
	Parameter connectionInfo should be final.	150

org/apache/geronimo/connector/outbound/ManagedConnectionFactoryWrapperGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Utility classes should not have a public or default constructor.	32
	Missing a Javadoc comment.	34
	Line is longer than 120 characters.	37
	Line is longer than 120 characters.	58
	Missing a Javadoc comment.	77

org/apache/geronimo/connector/GeronimoBootstrapContext.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	32
	Parameter workManager should be final.	47
	Expected @param tag for 'workManager'.	47
	Parameter xaTerminator should be final.	47
	Expected @param tag for 'xaTerminator'.	47
	Expected an @return tag.	56
	Expected an @return tag.	63
	Expected an @return tag.	70
	Expected @throws tag for 'UnavailableException'.	70

org/apache/geronimo/connector/outbound/transactionlog/JDBCLogGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	27
	Utility classes should not have a public or default constructor.	30
	Line has trailing spaces.	31
	Missing a Javadoc comment.	32
	Line is longer than 120 characters.	35
	Line is longer than 120 characters.	41
	Missing a Javadoc comment.	48

org/apache/geronimo/connector/outbound/connectionmanagerconfig/NoTransactions.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Class NoTransactions should be declared as final.	30
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	36
	Parameter stack should be final.	36
	Parameter name should be final.	36
	Line is longer than 120 characters.	40
	Missing a Javadoc comment.	40
	Parameter stack should be final.	40
	Parameter transactionManager should be final.	40

org/apache/geronimo/connector/outbound/connectionmanagerconfig/TransactionLog.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Class TransactionLog should be declared as final.	33
	'{' should be on the previous line.	34
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	40
	Parameter stack should be final.	40
	Parameter name should be final.	40
	Line is longer than 120 characters.	44
	Missing a Javadoc comment.	44
	Parameter stack should be final.	44
	Parameter transactionManager should be final.	44

org/apache/geronimo/connector/outbound/ConnectionReturnAction.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	20
	Class ConnectionReturnAction should be declared as final.	29
	Missing a Javadoc comment.	31
	'static' modifier out of order with the JLS suggestions.	31
	Missing a Javadoc comment.	33
	'static' modifier out of order with the JLS suggestions.	33
	Missing a Javadoc comment.	36

org/apache/geronimo/connector/outbound/connectiontracking/TrackedConnectionAssociator.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	35

org/apache/geronimo/connector/outbound/connectiontracking/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/connector/outbound/GenericConnectionManagerGBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	43
	More than 7 parameters.	43
	Parameter transactionSupport should be final.	43
	Parameter pooling should be final.	44
	Parameter containerManagedSecurity should be final.	45
	Parameter connectionTracker should be final.	46
	Parameter transactionManager should be final.	47
	Parameter objectName should be final.	48
	Parameter classLoader should be final.	49
	Parameter kernel should be final.	50
	Line is longer than 120 characters.	51
	Missing a Javadoc comment.	55
	'if' is not followed by whitespace.	58
	Line is longer than 120 characters.	61
	Missing a Javadoc comment.	65
	Line is longer than 120 characters.	68
	Missing a Javadoc comment.	96

Parent Project

Project Documentation

Checkstyle Results

Summary

Rules

Files

Details

org/apache/geronimo/connector/outbound/ConnectionHandleInterceptor.java

org/apache/geronimo/connector/outbound/SinglePoolConnectionInterceptor.java

org/apache/geronimo/connector/outbound/XAResourceInsertionInterceptor.java

org/apache/geronimo/connector/outbound/SinglePoolMatchAllConnectionInterceptor.java

org/apache/geronimo/connector/ResourceAdapterModuleImpl.java

org/apache/geronimo/connector/outbound/LocalXAResourceInsertionInterceptor.java

org/apache/geronimo/connector/outbound/SubjectInterceptor.java

org/apache/geronimo/connector/outbound/connectionmanagerconfig/XATransactions.java

org/apache/geronimo/connector/work/GeronimoWorkManagerGBean.java

org/apache/geronimo/connector/outbound/GenericConnectionManager.java

org/apache/geronimo/connector/outbound/LocalXAResource.java

org/apache/geronimo/connector/DatabaseInitializationGBean.java

org/apache/geronimo/connector/outbound/security/package.html

org/apache/geronimo/connector/outbound/AbstractConnectionManagerGBean.java

org/apache/geronimo/connector/outbound/transactionlog/package.html

org/apache/geronimo/connector/work/pool/WorkExecutorPoolImpl.java

org/apache/geronimo/connector/outbound/JCAConnectionFactoryImpl.java

org/apache/geronimo/connector/outbound/PoolIdleReleaserTimer.java

org/apache/geronimo/connector/JCAResourceImpl.java

org/apache/geronimo/connector/ConnectionReleaser.java

org/apache/geronimo/connector/outbound/connectiontracking/ConnectionTrackingCoordinatorGBean.java

org/apache/geronimo/connector/ResourceAdapterModuleImplGBean.java

org/apache/geronimo/connector/outbound/GeronimoConnectionEventListener.java

org/apache/geronimo/connector/ConnectorTransactionContext.java

org/apache/geronimo/connector/outbound/ConnectionFactorySource.java

org/apache/geronimo/connector/outbound/connectionmanagerconfig/SinglePool.java

org/apache/geronimo/connector/outbound/security/PasswordCredentialLoginModuleWrapperGBean.java

org/apache/geronimo/connector/ResourceAdapterWrapper.java

org/apache/geronimo/connector/work/pool/NamedRunnable.java

org/apache/geronimo/connector/work/GeronimoWorkManager.java

org/apache/geronimo/connector/AdminObjectWrapper.java

org/apache/geronimo/connector/outbound/connectionmanagerconfig/TransactionSupport.java

org/apache/geronimo/connector/outbound/connectionmanagerconfig/PartitionedPool.java

org/apache/geronimo/connector/outbound/TransactionEnlistingInterceptor.java

org/apache/geronimo/connector/work/pool/WorkExecutor.java

org/apache/geronimo/connector/outbound/connectiontracking/ConnectionTrackingCoordinator.java

org/apache/geronimo/connector/ResourceAdapterWrapperGBean.java

org/apache/geronimo/connector/outbound/connectionmanagerconfig/LocalTransactions.java

org/apache/geronimo/connector/ConnectorMethodInterceptor.java

org/apache/geronimo/connector/outbound/ManagedConnectionFactoryWrapper.java

org/apache/geronimo/connector/outbound/PoolingAttributes.java

org/apache/geronimo/connector/outbound/security/ResourcePrincipal.java

org/apache/geronimo/connector/outbound/TxUtil.java

org/apache/geronimo/connector/outbound/connectiontracking/ConnectionTracker.java

org/apache/geronimo/connector/outbound/connectionmanagerconfig/NoPool.java

org/apache/geronimo/connector/outbound/ConnectionInterceptorSource.java

org/apache/geronimo/connector/outbound/transactionlog/JDBCLog.java

org/apache/geronimo/connector/outbound/MCFConnectionInterceptor.java

org/apache/geronimo/connector/work/package.html

org/apache/geronimo/connector/outbound/connectiontracking/ConnectorInstanceContextImpl.java

org/apache/geronimo/connector/ActivationSpecWrapperGBean.java

org/apache/geronimo/connector/ResourceAdapterImpl.java

org/apache/geronimo/connector/outbound/transactionlog/LogXAResource.java

org/apache/geronimo/connector/outbound/TCCLInterceptor.java

org/apache/geronimo/connector/work/pool/NullWorkExecutorPool.java

org/apache/geronimo/connector/work/pool/package.html

org/apache/geronimo/connector/work/pool/SyncWorkExecutor.java

org/apache/geronimo/connector/outbound/connectiontracking/ConnectorInstanceContext.java

org/apache/geronimo/connector/JCAResourceImplGBean.java

org/apache/geronimo/connector/outbound/ConnectionTrackingInterceptor.java

org/apache/geronimo/connector/outbound/security/PasswordCredentialLoginModuleWrapper.java

org/apache/geronimo/connector/outbound/ConnectionInterceptor.java

org/apache/geronimo/connector/outbound/AbstractSinglePoolConnectionInterceptor.java

org/apache/geronimo/connector/outbound/connectiontracking/GeronimoTransactionListener.java

org/apache/geronimo/connector/ActivationSpecWrapper.java

org/apache/geronimo/connector/outbound/JCAConnectionFactoryImplGBean.java

org/apache/geronimo/connector/work/pool/ScheduleWorkExecutor.java

org/apache/geronimo/connector/outbound/TransactionCachingInterceptor.java

org/apache/geronimo/connector/outbound/security/CallerIdentityPasswordCredentialLoginModule.java

org/apache/geronimo/connector/AdminObjectWrapperGBean.java

org/apache/geronimo/connector/outbound/AbstractConnectionManager.java

org/apache/geronimo/connector/outbound/connectionmanagerconfig/PoolingSupport.java

org/apache/geronimo/connector/outbound/ConnectionManagerContainer.java