Geronimo :: Connector :: Builder

Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
34	0	0	1291

Rules

Rules	Violations	Severity
PackageHtml	3	Error
NewlineAtEndOfFile	0	Error
Translation	0	Error
JavadocMethod	305	Error
JavadocType	2	Error
JavadocVariable	83	Error
JavadocStyle	5	Error
ConstantName	2	Error
LocalFinalVariableName	0	Error
LocalVariableName	0	Error
MemberName	0	Error
MethodName	0	Error
PackageName	0	Error
ParameterName	0	Error
StaticVariableName	3	Error
TypeName	1	Error
Header headerFile: `"/home/anthill/anthill3/agent/var/jobs/projects/Geronimo_Server/modules/geronimo-connector-builder/target/checkstyle-header.txt"`	31	Error
AvoidStarImport	4	Error
IllegalImport	0	Error
RedundantImport	0	Error
UnusedImports	13	Error
FileLength	0	Error
LineLength max: `"120"`	200	Error
MethodLength	0	Error
ParameterNumber	3	Error
EmptyForIteratorPad	0	Error
NoWhitespaceAfter	0	Error
NoWhitespaceBefore	0	Error
OperatorWrap	5	Error
ParenPad	0	Error
TypecastParenPad	0	Error
TabCharacter	4	Error
WhitespaceAfter	7	Error
WhitespaceAround	233	Error
ModifierOrder	6	Error
RedundantModifier	0	Error
AvoidNestedBlocks	0	Error
EmptyBlock	4	Error
LeftCurly	0	Error
NeedBraces	25	Error
RightCurly	0	Error
AvoidInlineConditionals	24	Error
DoubleCheckedLocking	0	Error
EmptyStatement	0	Error
EqualsHashCode	0	Error
HiddenField ignoreConstructorParameter: `"true"` ignoreSetter: `"true"`	19	Error
IllegalInstantiation	0	Error
InnerAssignment	2	Error
MagicNumber	2	Error
MissingSwitchDefault	0	Error
RedundantThrows	0	Error
SimplifyBooleanExpression	0	Error
SimplifyBooleanReturn	0	Error
FinalClass	0	Error
HideUtilityClassConstructor	2	Error
InterfaceIsType	0	Error
VisibilityModifier	1	Error
ArrayTypeStyle	6	Error
FinalParameters	296	Error
GenericIllegalRegexp message: `"Line has trailing spaces."` format: `"\s+$"`	0	Error
TodoComment	0	Error
UpperEll	0	Error

Files

Files	I	W	E
org/apache/geronimo/connector/deployment/jsr88/ConfigHolder.java	0	0	43
org/apache/geronimo/connector/deployment/jsr88/ConnectionDefinitionInstance.java	0	0	36
org/apache/geronimo/connector/deployment/jsr88/ResourceAdapter.java	0	0	45
org/apache/geronimo/connector/deployment/ResourceRefBuilder.java	0	0	50
org/apache/geronimo/connector/deployment/jsr88/package.html	0	0	1
org/apache/geronimo/connector/deployment/dconfigbean/ConnectionDefinitionDConfigBean.java	0	0	14
org/apache/geronimo/connector/deployment/jsr88/AdminObjectDCB.java	0	0	26
org/apache/geronimo/connector/deployment/jsr88/ConnectionDefinition.java	0	0	35
org/apache/geronimo/connector/deployment/package.html	0	0	1
org/apache/geronimo/connector/deployment/jsr88/Connector15DCBRoot.java	0	0	44
org/apache/geronimo/connector/deployment/dconfigbean/package.html	0	0	1
org/apache/geronimo/connector/deployment/dconfigbean/ConnectionDefinitionInstanceBeanInfo.java	0	0	11
org/apache/geronimo/connector/deployment/dconfigbean/ConfigPropertySettingDConfigBean.java	0	0	11
org/apache/geronimo/connector/deployment/dconfigbean/ConnectionDefinitionInstance.java	0	0	32
org/apache/geronimo/connector/deployment/dconfigbean/AdminObjectInstance.java	0	0	25
org/apache/geronimo/connector/deployment/dconfigbean/ConnectionDefinitionDConfigBeanBeanInfo.java	0	0	8
org/apache/geronimo/connector/deployment/jsr88/ConnectorDCB.java	0	0	94
org/apache/geronimo/connector/deployment/dconfigbean/ResourceAdapter_1_0DConfigRoot.java	0	0	18
org/apache/geronimo/connector/deployment/dconfigbean/ConfigPropertySettings.java	0	0	36
org/apache/geronimo/connector/deployment/dconfigbean/AdminObjectDConfigBean.java	0	0	11
org/apache/geronimo/connector/deployment/ConnectorPlanRectifier.java	0	0	15
org/apache/geronimo/connector/deployment/ConnectorModuleBuilder.java	0	0	269
org/apache/geronimo/connector/deployment/jsr88/ResourceAdapterInstance.java	0	0	26
org/apache/geronimo/connector/deployment/dconfigbean/ResourceAdapterDConfigRoot.java	0	0	25
org/apache/geronimo/connector/deployment/RARConfiguration.java	0	0	4
org/apache/geronimo/connector/deployment/RARConfigurer.java	0	0	8
org/apache/geronimo/connector/deployment/dconfigbean/ResourceAdapterDConfigBean.java	0	0	44
org/apache/geronimo/connector/deployment/jsr88/ConnectionManager.java	0	0	122
org/apache/geronimo/connector/deployment/AdminObjectRefBuilder.java	0	0	74
org/apache/geronimo/connector/deployment/dconfigbean/ConfigPropertiesHelper.java	0	0	28
org/apache/geronimo/connector/deployment/jsr88/PartitionedPool.java	0	0	21
org/apache/geronimo/connector/deployment/jsr88/SinglePool.java	0	0	65
org/apache/geronimo/connector/deployment/jsr88/AdminObjectInstance.java	0	0	20
org/apache/geronimo/connector/deployment/jsr88/ConfigPropertySetting.java	0	0	28

Details

org/apache/geronimo/connector/deployment/jsr88/ConfigHolder.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	41
	Variable 'xpathListener' must be private and have accessor methods.	41
	Parameter event should be final.	42
	'if' is not followed by whitespace.	43
	Must have at least one statement.	43
	'if' is not followed by whitespace.	45
	Must have at least one statement.	45
	'if' is not followed by whitespace.	47
	'if' is not followed by whitespace.	48
	'if' is not followed by whitespace.	52
	Missing a Javadoc comment.	61
	Missing a Javadoc comment.	62
	Missing a Javadoc comment.	64
	Missing a Javadoc comment.	68
	'if' is not followed by whitespace.	73
	'-' is not preceded with whitespace.	80
	'-' is not followed by whitespace.	80
	'>=' is not preceded with whitespace.	80
	'>=' is not followed by whitespace.	80
	'if' is not followed by whitespace.	82
	Missing a Javadoc comment.	88
	Parameter ddBean should be final.	88
	'ddBean' hides a field.	88
	Parameter xml should be final.	88
	'if' is not followed by whitespace.	90
	Avoid inline conditionals.	99
	'if' is not followed by whitespace.	100
	'if' is not followed by whitespace.	112
	Line is longer than 120 characters.	115
	'+' is not preceded with whitespace.	115
	'+' is not followed by whitespace.	115
	'+' is not preceded with whitespace.	115
	'+' is not followed by whitespace.	115
	'if' is not followed by whitespace.	125
	'if' is not followed by whitespace.	128
	Missing a Javadoc comment.	133
	Missing a Javadoc comment.	137
	Parameter index should be final.	137
	Missing a Javadoc comment.	141
	Missing a Javadoc comment.	142
	Missing a Javadoc comment.	143
	Missing a Javadoc comment.	144

org/apache/geronimo/connector/deployment/jsr88/ConnectionDefinitionInstance.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Unused import - org.apache.geronimo.naming.deployment.jsr88.GBeanLocator.	23
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	39
	Parameter connectionDefinition should be final.	39
	Parameter instance should be final.	39
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	51
	Parameter connectionDefinition should be final.	51
	'connectionDefinition' hides a field.	51
	Parameter definition should be final.	51
	'if' is not followed by whitespace.	54
	'if' is not followed by whitespace.	57
	'if' is not followed by whitespace.	58
	'if' is not followed by whitespace.	64
	Missing a Javadoc comment.	74
	Missing a Javadoc comment.	78
	Missing a Javadoc comment.	82
	Missing a Javadoc comment.	86
	Parameter index should be final.	86
	Missing a Javadoc comment.	92
	Missing a Javadoc comment.	96
	Parameter name should be final.	96
	Missing a Javadoc comment.	102
	Missing a Javadoc comment.	106
	Parameter index should be final.	106
	Missing a Javadoc comment.	110
	Parameter list should be final.	110
	Missing a Javadoc comment.	116
	Parameter index should be final.	116
	Parameter iface should be final.	116
	Missing a Javadoc comment.	122
	Missing a Javadoc comment.	128

org/apache/geronimo/connector/deployment/jsr88/ResourceAdapter.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	46
	Parameter resourceAdapter should be final.	46
	Parameter ra should be final.	46
	Missing a Javadoc comment.	51
	'cast' is not followed by whitespace.	52
	Missing a Javadoc comment.	55
	Parameter resourceAdapter should be final.	55
	'resourceAdapter' hides a field.	55
	Parameter ra should be final.	55
	'if' is not followed by whitespace.	58
	'if' is not followed by whitespace.	63
	'if' is not followed by whitespace.	65
	'if' is not followed by whitespace.	68
	Must have at least one statement.	75
	Missing a Javadoc comment.	83
	Missing a Javadoc comment.	87
	Parameter index should be final.	87
	Missing a Javadoc comment.	91
	Parameter definitions should be final.	91
	'if' is not followed by whitespace.	94
	'if' is not followed by whitespace.	95
	'if' is not followed by whitespace.	99
	'if' is not followed by whitespace.	111
	Line is longer than 120 characters.	112
	Line is longer than 120 characters.	120
	Array brackets at illegal position.	120
	Avoid inline conditionals.	120
	'if' is not followed by whitespace.	122
	Missing a Javadoc comment.	131
	Parameter index should be final.	131
	Parameter definition should be final.	131
	'if' is not followed by whitespace.	134
	Line is longer than 120 characters.	135
	Missing a Javadoc comment.	140
	Missing a Javadoc comment.	144
	Parameter resourceAdapterInstance should be final.	144
	'if' is not followed by whitespace.	147
	'if' is not followed by whitespace.	148
	Line is longer than 120 characters.	151
	Missing a Javadoc comment.	159

org/apache/geronimo/connector/deployment/ResourceRefBuilder.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	57
	Missing a Javadoc comment.	58
	Missing a Javadoc comment.	60
	Missing a Javadoc comment.	62
	Missing a Javadoc comment.	63
	Missing a Javadoc comment.	65
	Parameter defaultEnvironment should be final.	65
	Parameter eeNamespaces should be final.	65
	Missing a Javadoc comment.	71
	Parameter specDD should be final.	71
	Parameter plan should be final.	71
	Line is longer than 120 characters.	75
	Missing a Javadoc comment.	75
	Parameter specDD should be final.	75
	Parameter plan should be final.	75
	Parameter localConfiguration should be final.	75
	Parameter remoteConfiguration should be final.	75
	Parameter module should be final.	75
	Parameter componentContext should be final.	75
	Line is longer than 120 characters.	76
	'?' is not preceded with whitespace.	77
	Avoid inline conditionals.	77
	':' is not preceded with whitespace.	77
	Line is longer than 120 characters.	120
	Line is longer than 120 characters.	131
	Line is longer than 120 characters.	133
	Line is longer than 120 characters.	137
	Line is longer than 120 characters.	151
	Missing a Javadoc comment.	151
	Parameter builder should be final.	151
	Parameter resourceRefs should be final.	151
	Parameter gerResourceRefs should be final.	151
	Line is longer than 120 characters.	165
	Line is longer than 120 characters.	166
	Missing a Javadoc comment.	180
	Parameter refs should be final.	180
	Line is longer than 120 characters.	191
	Missing a Javadoc comment.	191
	Parameter name should be final.	191
	Parameter type should be final.	191
	Parameter moduleURI should be final.	191
	Parameter gerResourceRef should be final.	191
	Avoid inline conditionals.	193
	Line is longer than 120 characters.	197
	Missing a Javadoc comment.	206
	Missing a Javadoc comment.	210
	Missing a Javadoc comment.	214
	Line is longer than 120 characters.	217
	Missing a Javadoc comment.	226

org/apache/geronimo/connector/deployment/jsr88/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/connector/deployment/dconfigbean/ConnectionDefinitionDConfigBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	39
	Parameter ddBean should be final.	39
	Parameter connectionDefinition should be final.	39
	Line is longer than 120 characters.	48
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	59
	Missing a Javadoc comment.	63
	Parameter instances should be final.	63
	'instances' hides a field.	63
	Line is longer than 120 characters.	69
	Line is longer than 120 characters.	86
	Missing a Javadoc comment.	99

org/apache/geronimo/connector/deployment/jsr88/AdminObjectDCB.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	42
	Parameter adminobjectDDBean should be final.	42
	Missing a Javadoc comment.	48
	Parameter adminDDBean should be final.	48
	Parameter adminXml should be final.	48
	Missing a Javadoc comment.	58
	Missing a Javadoc comment.	62
	Parameter xml should be final.	62
	'+' is not preceded with whitespace.	64
	'+' is not followed by whitespace.	64
	Missing a Javadoc comment.	72
	Missing a Javadoc comment.	76
	Missing a Javadoc comment.	80
	Missing a Javadoc comment.	84
	Parameter adminObjectInstance should be final.	84
	'if' is not followed by whitespace.	89
	Missing a Javadoc comment.	97
	Parameter index should be final.	97
	Missing a Javadoc comment.	101
	Parameter index should be final.	101
	Parameter adminObjectInstance should be final.	101
	'adminObjectInstance' hides a field.	101
	'if' is not followed by whitespace.	104
	Missing a Javadoc comment.	114

org/apache/geronimo/connector/deployment/jsr88/ConnectionDefinition.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Unused import - java.util.Map.	23
	Unused import - java.util.HashMap.	24
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	49
	Parameter resourceAdapter should be final.	49
	Parameter definition should be final.	49
	Missing a Javadoc comment.	54
	Missing a Javadoc comment.	58
	Parameter resourceAdapter should be final.	58
	'resourceAdapter' hides a field.	58
	Parameter definition should be final.	58
	'if' is not followed by whitespace.	67
	Missing a Javadoc comment.	81
	Missing a Javadoc comment.	85
	Parameter iface should be final.	85
	'if' is not followed by whitespace.	91
	Missing a Javadoc comment.	98
	Missing a Javadoc comment.	102
	Parameter instances should be final.	102
	'instances' hides a field.	102
	'if' is not followed by whitespace.	112
	Line is longer than 120 characters.	113
	Line is longer than 120 characters.	121
	Array brackets at illegal position.	121
	'if' is not followed by whitespace.	123
	First sentence should end with a period.	136
	Expected an @return tag.	139
	'if' is not followed by whitespace.	141
	Array brackets at illegal position.	144
	'if' is not followed by whitespace.	148
	'if' is not followed by whitespace.	150
	Missing a Javadoc comment.	158

org/apache/geronimo/connector/deployment/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/connector/deployment/jsr88/Connector15DCBRoot.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Unused import - java.util.Map.	23
	Unused import - java.util.HashMap.	24
	Unused import - java.util.Iterator.	27
	Unused import - java.util.Arrays.	28
	Unused import - org.apache.geronimo.xbeans.geronimo.GerAdminobjectInstanceType.	35
	Unused import - org.apache.geronimo.xbeans.geronimo.GerConnectiondefinitionInstanceType.	36
	Unused import - org.apache.geronimo.xbeans.geronimo.GerResourceadapterInstanceType.	37
	Unused import - org.apache.geronimo.xbeans.geronimo.GerConfigPropertySettingType.	38
	Unused import - org.apache.xmlbeans.XmlCursor.	43
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	60
	Missing a Javadoc comment.	62
	Parameter ddBean should be final.	62
	Missing a Javadoc comment.	67
	Parameter root should be final.	67
	'if' is not followed by whitespace.	69
	'if' is not followed by whitespace.	72
	'if' is not followed by whitespace.	81
	Missing a Javadoc comment.	93
	Missing a Javadoc comment.	97
	',' is not followed by whitespace.	98
	',' is not followed by whitespace.	98
	Missing a Javadoc comment.	101
	Parameter bean should be final.	101
	'+' is not preceded with whitespace.	105
	'+' is not followed by whitespace.	105
	Missing a Javadoc comment.	109
	First sentence should end with a period.	113
	Parameter inputStream should be final.	116
	Expected @param tag for 'inputStream'.	116
	Expected @throws tag for 'XmlException'.	116
	Expected @throws tag for 'IOException'.	116
	'if' is not followed by whitespace.	119
	Parameter outputStream should be final.	133
	Expected @param tag for 'outputStream'.	133
	Expected @throws tag for 'IOException'.	133
	Missing a Javadoc comment.	147
	Parameter parents should be final.	147
	'if' is not followed by whitespace.	151
	Array brackets at illegal position.	155
	Array brackets at illegal position.	158
	'if' construct must use '{}'s.	168
	'if' is not followed by whitespace.	168

org/apache/geronimo/connector/deployment/dconfigbean/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/connector/deployment/dconfigbean/ConnectionDefinitionInstanceBeanInfo.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Using the '.' form of import should be avoided - java.beans..	3
	Using the '.' form of import should be avoided - java.awt..	4
	Line contains a tab character.	16
	Line contains a tab character.	29
	Parameter iconKind should be final.	56
	Line is longer than 120 characters.	71
	Line is longer than 120 characters.	129
	Line is longer than 120 characters.	132
	Line is longer than 120 characters.	133
	Line is longer than 120 characters.	135

org/apache/geronimo/connector/deployment/dconfigbean/ConfigPropertySettingDConfigBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	35
	Parameter ddBean should be final.	35
	Parameter configPropertySetting should be final.	35
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	58
	Missing a Javadoc comment.	62
	Missing a Javadoc comment.	66
	Parameter configPropertyValue should be final.	66
	Missing a Javadoc comment.	70

org/apache/geronimo/connector/deployment/dconfigbean/ConnectionDefinitionInstance.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	35
	'static' modifier out of order with the JLS suggestions.	35
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	44
	Parameter xmlObject should be final.	44
	Parameter parent should be final.	44
	'parent' hides a field.	44
	Line is longer than 120 characters.	48
	Parameter j should be final.	57
	Parameter configs should be final.	65
	'configs' hides a field.	65
	Missing a Javadoc comment.	73
	Missing a Javadoc comment.	77
	Missing a Javadoc comment.	93
	Missing a Javadoc comment.	97
	Missing a Javadoc comment.	101
	Missing a Javadoc comment.	105
	Parameter configs should be final.	105
	'configs' hides a field.	105
	Missing a Javadoc comment.	111
	Missing a Javadoc comment.	115
	Parameter name should be final.	115
	Missing a Javadoc comment.	203
	Missing a Javadoc comment.	207
	Parameter containerManagedSecurity should be final.	207
	Missing a Javadoc comment.	217
	'+' is not preceded with whitespace.	218
	'+' is not followed by whitespace.	218

org/apache/geronimo/connector/deployment/dconfigbean/AdminObjectInstance.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	37
	'static' modifier out of order with the JLS suggestions.	37
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	46
	Parameter xmlObject should be final.	46
	Parameter parent should be final.	46
	'parent' hides a field.	46
	Line is longer than 120 characters.	50
	Parameter j should be final.	59
	Parameter configs should be final.	67
	'configs' hides a field.	67
	Missing a Javadoc comment.	74
	Missing a Javadoc comment.	78
	Missing a Javadoc comment.	93
	Missing a Javadoc comment.	97
	Missing a Javadoc comment.	101
	Parameter configs should be final.	101
	'configs' hides a field.	101
	Missing a Javadoc comment.	107
	Missing a Javadoc comment.	111
	Parameter messageDestinationName should be final.	111

org/apache/geronimo/connector/deployment/dconfigbean/ConnectionDefinitionDConfigBeanBeanInfo.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Using the '.' form of import should be avoided - java.beans..	3
	Using the '.' form of import should be avoided - java.awt..	4
	Line contains a tab character.	16
	Line contains a tab character.	29
	Parameter iconKind should be final.	56
	Line is longer than 120 characters.	127
	Line is longer than 120 characters.	129

org/apache/geronimo/connector/deployment/jsr88/ConnectorDCB.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	50
	Missing a Javadoc comment.	51
	Missing a Javadoc comment.	52
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	55
	Parameter connectorDDBean should be final.	55
	'if' is not followed by whitespace.	58
	Parameter event should be final.	66
	'if' is not followed by whitespace.	67
	'if' is not followed by whitespace.	69
	Line is longer than 120 characters.	72
	'+' is not preceded with whitespace.	72
	'+' is not followed by whitespace.	72
	Missing a Javadoc comment.	78
	',' is not followed by whitespace.	79
	',' is not followed by whitespace.	79
	',' is not followed by whitespace.	79
	Missing a Javadoc comment.	82
	Parameter bean should be final.	82
	'for' is not followed by whitespace.	87
	'=' is not preceded with whitespace.	87
	'=' is not followed by whitespace.	87
	'<' is not preceded with whitespace.	87
	'<' is not followed by whitespace.	87
	'if' is not followed by whitespace.	88
	'&&' should be on a new line.	88
	'+' is not preceded with whitespace.	96
	'+' is not followed by whitespace.	96
	'+' is not preceded with whitespace.	101
	'+' is not followed by whitespace.	101
	Missing a Javadoc comment.	105
	Parameter connector should be final.	105
	'if' is not followed by whitespace.	119
	'if' is not followed by whitespace.	121
	Line is longer than 120 characters.	135
	Avoid inline conditionals.	135
	'if' is not followed by whitespace.	138
	'+' is not preceded with whitespace.	146
	'+' is not followed by whitespace.	146
	'+' is not preceded with whitespace.	146
	'+' is not followed by whitespace.	146
	'+' is not preceded with whitespace.	146
	'+' is not followed by whitespace.	146
	'if' is not followed by whitespace.	147
	Line is longer than 120 characters.	148
	'if' is not followed by whitespace.	150
	'if' is not followed by whitespace.	159
	'+' is not preceded with whitespace.	164
	'+' is not followed by whitespace.	164
	'if' is not followed by whitespace.	174
	'if' is not followed by whitespace.	180
	Line is longer than 120 characters.	181
	'+' is not preceded with whitespace.	181
	'+' is not followed by whitespace.	181
	'+' is not preceded with whitespace.	181
	'+' is not followed by whitespace.	181
	'+' is not preceded with whitespace.	181
	'+' is not followed by whitespace.	181
	'+' is not preceded with whitespace.	181
	'+' is not followed by whitespace.	181
	'+' is not preceded with whitespace.	185
	'+' is not followed by whitespace.	185
	'+' is not preceded with whitespace.	185
	'+' is not followed by whitespace.	185
	'+' is not preceded with whitespace.	185
	'+' is not followed by whitespace.	185
	'+' is not preceded with whitespace.	194
	'+' is not followed by whitespace.	194
	'+' is not preceded with whitespace.	194
	'+' is not followed by whitespace.	194
	'+' is not preceded with whitespace.	194
	'+' is not followed by whitespace.	194
	Missing a Javadoc comment.	207
	Missing a Javadoc comment.	217
	Missing a Javadoc comment.	221
	Parameter environment should be final.	221
	'if' is not followed by whitespace.	224
	'&&' is not preceded with whitespace.	224
	'if' is not followed by whitespace.	227
	'if' is not followed by whitespace.	230
	Missing a Javadoc comment.	236
	Missing a Javadoc comment.	240
	Parameter resourceAdapter should be final.	240
	'if' is not followed by whitespace.	250
	Array brackets at illegal position.	259
	'if' is not followed by whitespace.	261
	Missing a Javadoc comment.	270
	Parameter index should be final.	270
	Missing a Javadoc comment.	274
	Parameter index should be final.	274
	Parameter ra should be final.	274
	'if' is not followed by whitespace.	277
	Missing a Javadoc comment.	288

org/apache/geronimo/connector/deployment/dconfigbean/ResourceAdapter_1_0DConfigRoot.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Name 'ResourceAdapter_1_0DConfigRoot' must match pattern '^[A-Z][a-zA-Z0-9]*$'.	40
	Missing a Javadoc comment.	42
	Name 'XPATHS' must match pattern '^[a-z][a-zA-Z0-9]*$'.	42
	Missing a Javadoc comment.	46
	Missing a Javadoc comment.	48
	Parameter ddBean should be final.	48
	Line is longer than 120 characters.	50
	Missing a Javadoc comment.	54
	Parameter connectionDefinition should be final.	54
	Missing a Javadoc comment.	60
	Missing a Javadoc comment.	64
	Missing a Javadoc comment.	68
	Parameter bean should be final.	68
	Missing a Javadoc comment.	75
	Parameter inputStream should be final.	75
	Line is longer than 120 characters.	78
	Missing a Javadoc comment.	81

org/apache/geronimo/connector/deployment/dconfigbean/ConfigPropertySettings.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	34
	'static' modifier out of order with the JLS suggestions.	34
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	44
	Parameter xmlObject should be final.	44
	Parameter configPropertyBean should be final.	44
	Inner assignments should be avoided.	55
	Parameter xpe should be final.	56
	Inner assignments should be avoided.	64
	Parameter xpe should be final.	65
	Missing a Javadoc comment.	75
	Parameter target should be final.	75
	Missing a Javadoc comment.	79
	Missing a Javadoc comment.	89
	Missing a Javadoc comment.	93
	Missing a Javadoc comment.	97
	Parameter configPropertyBean should be final.	97
	Missing a Javadoc comment.	105
	Parameter name should be final.	105
	Missing a Javadoc comment.	111
	Missing a Javadoc comment.	115
	Parameter configPropertyBean should be final.	115
	Missing a Javadoc comment.	123
	Parameter type should be final.	123
	'type' hides a field.	123
	Missing a Javadoc comment.	129
	Missing a Javadoc comment.	133
	Parameter configPropertyValue should be final.	133
	Missing a Javadoc comment.	139
	'+' is not preceded with whitespace.	140
	'+' is not followed by whitespace.	140

org/apache/geronimo/connector/deployment/dconfigbean/AdminObjectDConfigBean.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	37
	Parameter ddBean should be final.	37
	Parameter adminObject should be final.	37
	Missing a Javadoc comment.	60
	Missing a Javadoc comment.	64
	Missing a Javadoc comment.	68
	Parameter instances should be final.	68
	'instances' hides a field.	68
	Missing a Javadoc comment.	103

org/apache/geronimo/connector/deployment/ConnectorPlanRectifier.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Utility classes should not have a public or default constructor.	33
	Missing a Javadoc comment.	35
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	35
	Missing a Javadoc comment.	37
	Line is longer than 120 characters.	38
	Missing a Javadoc comment.	38
	Line is longer than 120 characters.	39
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	42
	Parameter gerConnector should be final.	42
	Line is longer than 120 characters.	54
	Line is longer than 120 characters.	57
	Line is longer than 120 characters.	59
	Line is longer than 120 characters.	80

org/apache/geronimo/connector/deployment/ConnectorModuleBuilder.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	129
	'static' modifier out of order with the JLS suggestions.	129
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	129
	Missing a Javadoc comment.	131
	Name 'CONNECTOR_QNAME' must match pattern '^[a-z][a-zA-Z0-9]*$'.	131
	Missing a Javadoc comment.	132
	Missing a Javadoc comment.	134
	Missing a Javadoc comment.	135
	Missing a Javadoc comment.	136
	Missing a Javadoc comment.	137
	Missing a Javadoc comment.	138
	Missing a Javadoc comment.	139
	Missing a Javadoc comment.	140
	Missing a Javadoc comment.	141
	Line is longer than 120 characters.	142
	Missing a Javadoc comment.	142
	Missing a Javadoc comment.	144
	More than 7 parameters.	144
	Parameter defaultEnvironment should be final.	144
	Parameter defaultMaxSize should be final.	145
	Parameter defaultMinSize should be final.	146
	Parameter defaultBlockingTimeoutMilliseconds should be final.	147
	Parameter defaultIdleTimeoutMinutes should be final.	148
	Parameter defaultXATransactionCaching should be final.	149
	Parameter defaultXAThreadCaching should be final.	150
	Parameter serviceBuilders should be final.	151
	Line is longer than 120 characters.	163
	Missing a Javadoc comment.	163
	Parameter plan should be final.	163
	Parameter moduleFile should be final.	163
	Parameter naming should be final.	163
	Parameter idBuilder should be final.	163
	Line is longer than 120 characters.	167
	Missing a Javadoc comment.	167
	More than 7 parameters.	167
	Parameter plan should be final.	167
	Parameter moduleFile should be final.	167
	Parameter targetPath should be final.	167
	Parameter specDDUrl should be final.	167
	Parameter environment should be final.	167
	Parameter moduleContextInfo should be final.	167
	Parameter earName should be final.	167
	Parameter naming should be final.	167
	Parameter idBuilder should be final.	167
	Line is longer than 120 characters.	171
	Missing a Javadoc comment.	171
	More than 7 parameters.	171
	Parameter plan should be final.	171
	Parameter moduleFile should be final.	171
	Parameter targetPath should be final.	171
	Parameter specDDUrl should be final.	171
	Parameter earEnvironment should be final.	171
	Parameter earName should be final.	171
	Parameter naming should be final.	171
	Parameter idBuilder should be final.	171
	':' is not preceded with whitespace.	172
	':' is not preceded with whitespace.	173
	':' is not preceded with whitespace.	174
	Line is longer than 120 characters.	211
	Line is longer than 120 characters.	214
	Must have at least one statement.	223
	'+' should be on a new line.	229
	Line is longer than 120 characters.	230
	Line is longer than 120 characters.	251
	Line is longer than 120 characters.	260
	Line is longer than 120 characters.	266
	Missing a Javadoc comment.	269
	Parameter xmlObject should be final.	269
	Line is longer than 120 characters.	283
	Line is longer than 120 characters.	287
	Line is longer than 120 characters.	340
	Missing a Javadoc comment.	340
	Parameter earFile should be final.	340
	Parameter earContext should be final.	340
	Parameter module should be final.	340
	Parameter configurationStores should be final.	340
	Parameter targetConfigurationStore should be final.	340
	Parameter repository should be final.	340
	Missing a Javadoc comment.	369
	Parameter earContext should be final.	369
	Parameter module should be final.	369
	Parameter cl should be final.	369
	Line is longer than 120 characters.	387
	Line is longer than 120 characters.	388
	Line is longer than 120 characters.	391
	Line is longer than 120 characters.	404
	Avoid inline conditionals.	404
	Line is longer than 120 characters.	405
	Avoid inline conditionals.	405
	Line is longer than 120 characters.	408
	Line is longer than 120 characters.	413
	Line is longer than 120 characters.	414
	Line is longer than 120 characters.	416
	Line is longer than 120 characters.	420
	Line is longer than 120 characters.	422
	Line is longer than 120 characters.	428
	Line is longer than 120 characters.	449
	Line is longer than 120 characters.	450
	Line is longer than 120 characters.	451
	Line is longer than 120 characters.	452
	Line is longer than 120 characters.	453
	Line is longer than 120 characters.	465
	Line is longer than 120 characters.	469
	Missing a Javadoc comment.	469
	Parameter earContext should be final.	469
	Parameter module should be final.	469
	Parameter cl should be final.	469
	Parameter repository should be final.	469
	Missing a Javadoc comment.	473
	Line is longer than 120 characters.	477
	Missing a Javadoc comment.	477
	Parameter earContext should be final.	477
	Parameter jcaResourceName should be final.	477
	Parameter resourceAdapterModuleData should be final.	477
	Parameter connector should be final.	477
	Parameter geronimoConnector should be final.	477
	Parameter cl should be final.	477
	Line is longer than 120 characters.	490
	Line is longer than 120 characters.	493
	Line is longer than 120 characters.	497
	Line is longer than 120 characters.	499
	Line is longer than 120 characters.	500
	Line is longer than 120 characters.	514
	Line is longer than 120 characters.	516
	Line is longer than 120 characters.	517
	Line is longer than 120 characters.	519
	':' is not preceded with whitespace.	520
	Line is longer than 120 characters.	522
	Line is longer than 120 characters.	523
	Line is longer than 120 characters.	526
	Line is longer than 120 characters.	531
	Line is longer than 120 characters.	533
	Line is longer than 120 characters.	554
	Line is longer than 120 characters.	556
	Line is longer than 120 characters.	567
	Missing a Javadoc comment.	567
	Parameter messagelistenerArray should be final.	567
	Parameter cl should be final.	567
	Line is longer than 120 characters.	574
	Line is longer than 120 characters.	589
	Line is longer than 120 characters.	591
	Avoid inline conditionals.	591
	'3' is a magic number.	591
	'3' is a magic number.	594
	Line is longer than 120 characters.	602
	Line is longer than 120 characters.	619
	Missing a Javadoc comment.	619
	Parameter connectionDefinitionArray should be final.	619
	Parameter cl should be final.	619
	Line is longer than 120 characters.	624
	Line is longer than 120 characters.	625
	Line is longer than 120 characters.	628
	Line is longer than 120 characters.	629
	Line is longer than 120 characters.	631
	Line is longer than 120 characters.	632
	Line is longer than 120 characters.	633
	Missing a Javadoc comment.	639
	Parameter adminobjectArray should be final.	639
	Parameter cl should be final.	639
	Line is longer than 120 characters.	644
	Line is longer than 120 characters.	645
	Line is longer than 120 characters.	650
	Line is longer than 120 characters.	657
	Missing a Javadoc comment.	657
	Parameter infoBuilder should be final.	657
	Parameter configProperties should be final.	657
	Parameter cl should be final.	657
	Line is longer than 120 characters.	659
	Line is longer than 120 characters.	675
	Missing a Javadoc comment.	675
	Parameter gbeanData should be final.	675
	Parameter configProperties should be final.	675
	Parameter cl should be final.	675
	Line is longer than 120 characters.	682
	Missing a Javadoc comment.	695
	Parameter type should be final.	695
	Parameter value should be final.	695
	Parameter cl should be final.	695
	Line is longer than 120 characters.	719
	Missing a Javadoc comment.	719
	Parameter earContext should be final.	719
	Parameter jcaResourceName should be final.	719
	Parameter ddTransactionSupport should be final.	719
	Parameter connectionfactoryInstance should be final.	719
	Parameter cl should be final.	719
	Line is longer than 120 characters.	725
	Line is longer than 120 characters.	730
	Line is longer than 120 characters.	735
	Line is longer than 120 characters.	748
	Line is longer than 120 characters.	753
	Line is longer than 120 characters.	758
	Line is longer than 120 characters.	761
	Line is longer than 120 characters.	773
	Avoid inline conditionals.	779
	Avoid inline conditionals.	780
	Line is longer than 120 characters.	781
	Avoid inline conditionals.	781
	Avoid inline conditionals.	782
	Avoid inline conditionals.	788
	Avoid inline conditionals.	789
	Line is longer than 120 characters.	790
	Avoid inline conditionals.	790
	Avoid inline conditionals.	791
	Line is longer than 120 characters.	800
	Line is longer than 120 characters.	806
	Line is longer than 120 characters.	809
	Line is longer than 120 characters.	815
	Line is longer than 120 characters.	820
	Missing a Javadoc comment.	820
	Parameter earContext should be final.	820
	Parameter jcaResourceName should be final.	820
	Parameter resourceAdapterAbstractName should be final.	820
	Parameter managedConnectionFactoryPrototypeGBeanData should be final.	820
	Parameter connectiondefinitionInstance should be final.	820
	Parameter transactionSupport should be final.	820
	Parameter cl should be final.	820
	Line is longer than 120 characters.	822
	Line is longer than 120 characters.	823
	Line is longer than 120 characters.	825
	Line is longer than 120 characters.	828
	'cast' is not followed by whitespace.	836
	Line is longer than 120 characters.	838
	'+' is not preceded with whitespace.	838
	'+' is not followed by whitespace.	838
	'+' is not preceded with whitespace.	838
	'+' is not followed by whitespace.	838
	Line is longer than 120 characters.	844
	Line is longer than 120 characters.	846
	Line is longer than 120 characters.	870
	Line is longer than 120 characters.	871
	Line is longer than 120 characters.	881
	Missing a Javadoc comment.	881
	Parameter containerId should be final.	881
	Parameter iface should be final.	881
	Parameter configuration should be final.	881
	Line is longer than 120 characters.	885
	Line is longer than 120 characters.	890
	Missing a Javadoc comment.	890
	Parameter containerId should be final.	890
	Parameter iface should be final.	890
	Parameter configuration should be final.	890
	Line is longer than 120 characters.	894
	Line is longer than 120 characters.	899
	Missing a Javadoc comment.	899
	Parameter resourceAdapterInstanceQuery should be final.	899
	Parameter messageListenerInterface should be final.	899
	Parameter configuration should be final.	899
	Line is longer than 120 characters.	905
	Line is longer than 120 characters.	914
	Line is longer than 120 characters.	920
	Line is longer than 120 characters.	924
	Missing a Javadoc comment.	929
	Parameter resourceAdapterModuleData should be final.	929
	Line is longer than 120 characters.	932
	Line is longer than 120 characters.	937
	Missing a Javadoc comment.	937
	Parameter resourceAdapterModuleData should be final.	937
	Parameter adminObjectInterfaceName should be final.	937
	Line is longer than 120 characters.	940
	Line is longer than 120 characters.	945
	Missing a Javadoc comment.	945
	Parameter resourceAdapterModuleData should be final.	945
	Parameter connectionFactoryInterfaceName should be final.	945
	Line is longer than 120 characters.	946
	Line is longer than 120 characters.	948
	Missing a Javadoc comment.	953
	Line is longer than 120 characters.	956
	Missing a Javadoc comment.	982

org/apache/geronimo/connector/deployment/jsr88/ResourceAdapterInstance.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	37
	First sentence should end with a period.	39
	Missing a Javadoc comment.	45
	Parameter resourceAdapter should be final.	45
	Parameter instance should be final.	45
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	57
	Parameter resourceAdapter should be final.	57
	'resourceAdapter' hides a field.	57
	Parameter xml should be final.	57
	Missing a Javadoc comment.	62
	Missing a Javadoc comment.	66
	Missing a Javadoc comment.	70
	Parameter index should be final.	70
	Missing a Javadoc comment.	76
	Missing a Javadoc comment.	80
	Parameter name should be final.	80
	Missing a Javadoc comment.	86
	Missing a Javadoc comment.	90
	Parameter locator should be final.	90
	'if' is not followed by whitespace.	92
	'if' is not followed by whitespace.	93
	Missing a Javadoc comment.	105

org/apache/geronimo/connector/deployment/dconfigbean/ResourceAdapterDConfigRoot.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	49
	Name 'XPATHS' must match pattern '^[a-z][a-zA-Z0-9]*$'.	49
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	55
	Parameter ddBean should be final.	55
	Missing a Javadoc comment.	60
	Parameter root should be final.	60
	'if' is not followed by whitespace.	62
	Missing a Javadoc comment.	79
	Parameter resourceAdapter should be final.	79
	'+' is not preceded with whitespace.	82
	'+' is not followed by whitespace.	82
	'+' is not preceded with whitespace.	82
	'+' is not followed by whitespace.	82
	'+' is not preceded with whitespace.	82
	'+' is not followed by whitespace.	82
	Missing a Javadoc comment.	87
	Missing a Javadoc comment.	91
	Missing a Javadoc comment.	95
	Parameter bean should be final.	95
	Missing a Javadoc comment.	102
	Parameter inputStream should be final.	102
	Missing a Javadoc comment.	108

org/apache/geronimo/connector/deployment/RARConfiguration.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	34
	Parameter deployable should be final.	34
	Parameter dconfigRoot should be final.	34

org/apache/geronimo/connector/deployment/RARConfigurer.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Unused import - org.apache.geronimo.connector.deployment.dconfigbean.ResourceAdapterDConfigRoot.	25
	Missing a Javadoc comment.	40
	Parameter deployable should be final.	40
	Line is longer than 120 characters.	50
	Missing a Javadoc comment.	56
	Line is longer than 120 characters.	59
	Missing a Javadoc comment.	64

org/apache/geronimo/connector/deployment/dconfigbean/ResourceAdapterDConfigBean.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	43
	'static' modifier out of order with the JLS suggestions.	43
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	48
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	51
	Parameter ddBean should be final.	51
	Parameter j should be final.	65
	Parameter configs should be final.	72
	Line is longer than 120 characters.	89
	Line is longer than 120 characters.	90
	Line is longer than 120 characters.	99
	Line is longer than 120 characters.	101
	Line is longer than 120 characters.	117
	Line is longer than 120 characters.	130
	Missing a Javadoc comment.	138
	Missing a Javadoc comment.	142
	Missing a Javadoc comment.	146
	Missing a Javadoc comment.	150
	Parameter resourceAdapterName should be final.	150
	Missing a Javadoc comment.	154
	'if' is not followed by whitespace.	155
	Missing a Javadoc comment.	161
	Parameter workManager should be final.	161
	'if' is not followed by whitespace.	162
	'if' is not followed by whitespace.	165
	Missing a Javadoc comment.	171
	Parameter bean should be final.	171
	Line is longer than 120 characters.	177
	Line is longer than 120 characters.	184
	Line is longer than 120 characters.	192
	Missing a Javadoc comment.	200
	Missing a Javadoc comment.	204
	Missing a Javadoc comment.	210
	'static' modifier out of order with the JLS suggestions.	210
	Missing a Javadoc comment.	211
	Missing a Javadoc comment.	212
	Missing a Javadoc comment.	214
	Parameter part1 should be final.	214
	Parameter part2 should be final.	214
	Missing a Javadoc comment.	219
	Missing a Javadoc comment.	223
	Parameter obj should be final.	223

org/apache/geronimo/connector/deployment/jsr88/ConnectionManager.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	40
	Parameter outboundRA should be final.	40
	Parameter manager should be final.	40
	Missing a Javadoc comment.	45
	Parameter outboundRA should be final.	45
	'outboundRA' hides a field.	45
	Parameter manager should be final.	45
	'if' is not followed by whitespace.	48
	'&&' should be on a new line.	48
	'if' is not followed by whitespace.	51
	'if' is not followed by whitespace.	53
	'if' is not followed by whitespace.	55
	'if' is not followed by whitespace.	57
	'if' is not followed by whitespace.	63
	'if' is not followed by whitespace.	65
	'if' is not followed by whitespace.	67
	Missing a Javadoc comment.	72
	Missing a Javadoc comment.	78
	Missing a Javadoc comment.	82
	Parameter set should be final.	82
	'if' is not followed by whitespace.	83
	'if' is not followed by whitespace.	84
	'if' is not followed by whitespace.	89
	Missing a Javadoc comment.	96
	Missing a Javadoc comment.	100
	Parameter set should be final.	100
	'if' is not followed by whitespace.	101
	'if' is not followed by whitespace.	102
	'if' construct must use '{}'s.	106
	'if' is not followed by whitespace.	106
	'if' construct must use '{}'s.	107
	'if' is not followed by whitespace.	107
	'if' construct must use '{}'s.	108
	'if' is not followed by whitespace.	108
	'if' is not followed by whitespace.	110
	Missing a Javadoc comment.	117
	Missing a Javadoc comment.	121
	Parameter set should be final.	121
	'if' is not followed by whitespace.	122
	'if' is not followed by whitespace.	123
	'if' construct must use '{}'s.	127
	'if' is not followed by whitespace.	127
	'if' construct must use '{}'s.	128
	'if' is not followed by whitespace.	128
	'if' construct must use '{}'s.	129
	'if' is not followed by whitespace.	129
	'if' is not followed by whitespace.	131
	Missing a Javadoc comment.	138
	Missing a Javadoc comment.	142
	Parameter set should be final.	142
	'if' is not followed by whitespace.	143
	'if' is not followed by whitespace.	144
	'if' construct must use '{}'s.	148
	'if' is not followed by whitespace.	148
	'if' construct must use '{}'s.	149
	'if' is not followed by whitespace.	149
	'if' construct must use '{}'s.	150
	'if' is not followed by whitespace.	150
	'if' is not followed by whitespace.	152
	Missing a Javadoc comment.	159
	Missing a Javadoc comment.	163
	Parameter set should be final.	163
	'if' is not followed by whitespace.	164
	'if' is not followed by whitespace.	165
	'if' construct must use '{}'s.	169
	'if' is not followed by whitespace.	169
	'if' construct must use '{}'s.	170
	'if' is not followed by whitespace.	170
	'if' construct must use '{}'s.	171
	'if' is not followed by whitespace.	171
	'if' is not followed by whitespace.	173
	'if' is not followed by whitespace.	178
	'if' is not followed by whitespace.	181
	Missing a Javadoc comment.	188
	Missing a Javadoc comment.	192
	Parameter set should be final.	192
	'if' is not followed by whitespace.	193
	'if' is not followed by whitespace.	195
	'if' is not followed by whitespace.	200
	Missing a Javadoc comment.	207
	Missing a Javadoc comment.	211
	Parameter set should be final.	211
	'if' is not followed by whitespace.	212
	'if' is not followed by whitespace.	214
	'if' is not followed by whitespace.	219
	Missing a Javadoc comment.	226
	Missing a Javadoc comment.	230
	Parameter set should be final.	230
	'if' is not followed by whitespace.	231
	'if' is not followed by whitespace.	232
	'if' construct must use '{}'s.	236
	'if' is not followed by whitespace.	236
	'if' construct must use '{}'s.	237
	'if' is not followed by whitespace.	237
	'if' is not followed by whitespace.	239
	'if' is not followed by whitespace.	243
	Missing a Javadoc comment.	249
	Missing a Javadoc comment.	253
	Parameter pool should be final.	253
	'if' is not followed by whitespace.	255
	'if' is not followed by whitespace.	257
	'if' construct must use '{}'s.	262
	'if' is not followed by whitespace.	262
	'if' construct must use '{}'s.	263
	'if' is not followed by whitespace.	263
	'if' is not followed by whitespace.	265
	Missing a Javadoc comment.	272
	Missing a Javadoc comment.	276
	Parameter pool should be final.	276
	'if' is not followed by whitespace.	278
	'if' is not followed by whitespace.	280
	'if' construct must use '{}'s.	285
	'if' is not followed by whitespace.	285
	'if' construct must use '{}'s.	286
	'if' is not followed by whitespace.	286
	'if' is not followed by whitespace.	288
	Missing a Javadoc comment.	297

org/apache/geronimo/connector/deployment/AdminObjectRefBuilder.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	56
	Missing a Javadoc comment.	57
	Missing a Javadoc comment.	59
	Missing a Javadoc comment.	60
	Line is longer than 120 characters.	61
	Missing a Javadoc comment.	61
	Missing a Javadoc comment.	62
	Missing a Javadoc comment.	64
	Parameter defaultEnvironment should be final.	64
	Parameter eeNamespaces should be final.	64
	Missing a Javadoc comment.	71
	Parameter specDD should be final.	71
	Parameter plan should be final.	71
	Line is longer than 120 characters.	72
	Line is longer than 120 characters.	75
	Missing a Javadoc comment.	75
	Parameter specDD should be final.	75
	Parameter plan should be final.	75
	Parameter localConfiguration should be final.	75
	Parameter remoteConfiguration should be final.	75
	Parameter module should be final.	75
	Line is longer than 120 characters.	76
	Line is longer than 120 characters.	80
	Line is longer than 120 characters.	99
	Missing a Javadoc comment.	99
	Parameter specDD should be final.	99
	Parameter plan should be final.	99
	Parameter localConfiguration should be final.	99
	Parameter remoteConfiguration should be final.	99
	Parameter module should be final.	99
	Parameter componentContext should be final.	99
	Line is longer than 120 characters.	100
	Line is longer than 120 characters.	102
	'?' is not preceded with whitespace.	102
	Avoid inline conditionals.	102
	':' is not preceded with whitespace.	102
	Line is longer than 120 characters.	120
	Avoid inline conditionals.	120
	Line is longer than 120 characters.	125
	Line is longer than 120 characters.	128
	Line is longer than 120 characters.	149
	Line is longer than 120 characters.	152
	Line is longer than 120 characters.	160
	Line is longer than 120 characters.	168
	Missing a Javadoc comment.	168
	Parameter messageDestinationLink should be final.	168
	Parameter messageDestinations should be final.	168
	Line is longer than 120 characters.	180
	'+' should be on a new line.	180
	Line is longer than 120 characters.	188
	Line is longer than 120 characters.	191
	Line is longer than 120 characters.	201
	Missing a Javadoc comment.	201
	Parameter localConfiguration should be final.	201
	Parameter containerId should be final.	201
	Parameter iface should be final.	201
	Line is longer than 120 characters.	205
	Missing a Javadoc comment.	210
	Parameter name should be final.	210
	Parameter gerResourceEnvRef should be final.	210
	Line is longer than 120 characters.	213
	Line is longer than 120 characters.	215
	Line is longer than 120 characters.	221
	Line is longer than 120 characters.	225
	Missing a Javadoc comment.	230
	Parameter refs should be final.	230
	Line is longer than 120 characters.	234
	Missing a Javadoc comment.	241
	Missing a Javadoc comment.	245
	Missing a Javadoc comment.	249
	Line is longer than 120 characters.	252
	Missing a Javadoc comment.	261

org/apache/geronimo/connector/deployment/dconfigbean/ConfigPropertiesHelper.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Utility classes should not have a public or default constructor.	39
	Line is longer than 120 characters.	41
	Missing a Javadoc comment.	41
	Parameter ddBean should be final.	41
	Parameter configPropertiesSource should be final.	41
	Parameter configPropertiesMap should be final.	41
	Parameter configPropertyXPath should be final.	41
	Parameter configPropertyNameXPath should be final.	41
	Line is longer than 120 characters.	49
	Line is longer than 120 characters.	51
	Line is longer than 120 characters.	62
	Line is longer than 120 characters.	68
	Missing a Javadoc comment.	68
	Parameter parentDDBean should be final.	68
	Parameter configPropertyXPath should be final.	68
	Parameter configPropertyNameXPath should be final.	68
	Avoid inline conditionals.	75
	Line is longer than 120 characters.	91
	Parameter xpe should be final.	103
	Line is longer than 120 characters.	109
	Line is longer than 120 characters.	116
	Missing a Javadoc comment.	145
	Missing a Javadoc comment.	146
	Missing a Javadoc comment.	148
	Missing a Javadoc comment.	150
	Missing a Javadoc comment.	152
	Missing a Javadoc comment.	154

org/apache/geronimo/connector/deployment/jsr88/PartitionedPool.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	23
	Missing a Javadoc comment.	29
	Missing a Javadoc comment.	32
	Parameter pool should be final.	32
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	40
	Parameter pool should be final.	40
	'if' is not followed by whitespace.	42
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	51
	Parameter set should be final.	51
	'if' is not followed by whitespace.	52
	'if' is not followed by whitespace.	53
	'if' is not followed by whitespace.	58
	Missing a Javadoc comment.	65
	Missing a Javadoc comment.	69
	Parameter set should be final.	69
	'if' is not followed by whitespace.	70
	'if' is not followed by whitespace.	71
	'if' is not followed by whitespace.	76

org/apache/geronimo/connector/deployment/jsr88/SinglePool.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	24
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	33
	Parameter pool should be final.	33
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	42
	Parameter pool should be final.	42
	'if' is not followed by whitespace.	44
	Missing a Javadoc comment.	51
	Avoid inline conditionals.	52
	Missing a Javadoc comment.	55
	Parameter value should be final.	55
	'if' is not followed by whitespace.	57
	'if' is not followed by whitespace.	58
	Missing a Javadoc comment.	67
	Avoid inline conditionals.	68
	Missing a Javadoc comment.	71
	Parameter value should be final.	71
	'if' is not followed by whitespace.	73
	'if' is not followed by whitespace.	74
	Missing a Javadoc comment.	83
	Line is longer than 120 characters.	84
	Avoid inline conditionals.	84
	Missing a Javadoc comment.	87
	Parameter value should be final.	87
	'if' is not followed by whitespace.	89
	'if' is not followed by whitespace.	90
	Missing a Javadoc comment.	99
	Avoid inline conditionals.	100
	Missing a Javadoc comment.	103
	Parameter value should be final.	103
	'if' is not followed by whitespace.	105
	'if' is not followed by whitespace.	106
	Missing a Javadoc comment.	115
	Missing a Javadoc comment.	119
	Parameter set should be final.	119
	'if' is not followed by whitespace.	120
	'if' is not followed by whitespace.	121
	'if' construct must use '{}'s.	125
	'if' is not followed by whitespace.	125
	'if' construct must use '{}'s.	126
	'if' is not followed by whitespace.	126
	'if' is not followed by whitespace.	128
	Missing a Javadoc comment.	135
	Missing a Javadoc comment.	139
	Parameter set should be final.	139
	'if' is not followed by whitespace.	140
	'if' is not followed by whitespace.	141
	'if' construct must use '{}'s.	145
	'if' is not followed by whitespace.	145
	'if' construct must use '{}'s.	146
	'if' is not followed by whitespace.	146
	'if' is not followed by whitespace.	148
	Missing a Javadoc comment.	155
	Missing a Javadoc comment.	159
	Parameter set should be final.	159
	'if' is not followed by whitespace.	160
	'if' is not followed by whitespace.	161
	'if' construct must use '{}'s.	165
	'if' is not followed by whitespace.	165
	'if' construct must use '{}'s.	166
	'if' is not followed by whitespace.	166
	'if' is not followed by whitespace.	168
	Missing a Javadoc comment.	177

org/apache/geronimo/connector/deployment/jsr88/AdminObjectInstance.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	37
	Parameter adminObject should be final.	37
	Parameter instance should be final.	37
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	49
	Parameter adminObject should be final.	49
	'adminObject' hides a field.	49
	Parameter definition should be final.	49
	Missing a Javadoc comment.	54
	Missing a Javadoc comment.	58
	Missing a Javadoc comment.	62
	Parameter index should be final.	62
	Missing a Javadoc comment.	68
	Missing a Javadoc comment.	72
	Parameter name should be final.	72
	Missing a Javadoc comment.	80

org/apache/geronimo/connector/deployment/jsr88/ConfigPropertySetting.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line is longer than 120 characters.	27
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	41
	Parameter configProperty should be final.	41
	Parameter property should be final.	41
	Parameter setDefault should be final.	41
	Missing a Javadoc comment.	46
	Missing a Javadoc comment.	50
	Missing a Javadoc comment.	54
	Parameter configProperty should be final.	54
	'configProperty' hides a field.	54
	Parameter property should be final.	54
	Parameter setDefault should be final.	54
	'if' is not followed by whitespace.	60
	'if' is not followed by whitespace.	65
	Missing a Javadoc comment.	70
	'\|\|' should be on a new line.	72
	Missing a Javadoc comment.	78
	Missing a Javadoc comment.	83
	Parameter name should be final.	83
	Missing a Javadoc comment.	89
	Avoid inline conditionals.	90
	Missing a Javadoc comment.	93
	Parameter value should be final.	93
	Missing a Javadoc comment.	101

Parent Project

Project Documentation

Checkstyle Results

Summary

Rules

Files

Details

org/apache/geronimo/connector/deployment/jsr88/ConfigHolder.java

org/apache/geronimo/connector/deployment/jsr88/ConnectionDefinitionInstance.java

org/apache/geronimo/connector/deployment/jsr88/ResourceAdapter.java

org/apache/geronimo/connector/deployment/ResourceRefBuilder.java

org/apache/geronimo/connector/deployment/jsr88/package.html

org/apache/geronimo/connector/deployment/dconfigbean/ConnectionDefinitionDConfigBean.java

org/apache/geronimo/connector/deployment/jsr88/AdminObjectDCB.java

org/apache/geronimo/connector/deployment/jsr88/ConnectionDefinition.java

org/apache/geronimo/connector/deployment/package.html

org/apache/geronimo/connector/deployment/jsr88/Connector15DCBRoot.java

org/apache/geronimo/connector/deployment/dconfigbean/package.html

org/apache/geronimo/connector/deployment/dconfigbean/ConnectionDefinitionInstanceBeanInfo.java

org/apache/geronimo/connector/deployment/dconfigbean/ConfigPropertySettingDConfigBean.java

org/apache/geronimo/connector/deployment/dconfigbean/ConnectionDefinitionInstance.java

org/apache/geronimo/connector/deployment/dconfigbean/AdminObjectInstance.java

org/apache/geronimo/connector/deployment/dconfigbean/ConnectionDefinitionDConfigBeanBeanInfo.java

org/apache/geronimo/connector/deployment/jsr88/ConnectorDCB.java

org/apache/geronimo/connector/deployment/dconfigbean/ResourceAdapter_1_0DConfigRoot.java

org/apache/geronimo/connector/deployment/dconfigbean/ConfigPropertySettings.java

org/apache/geronimo/connector/deployment/dconfigbean/AdminObjectDConfigBean.java

org/apache/geronimo/connector/deployment/ConnectorPlanRectifier.java

org/apache/geronimo/connector/deployment/ConnectorModuleBuilder.java

org/apache/geronimo/connector/deployment/jsr88/ResourceAdapterInstance.java

org/apache/geronimo/connector/deployment/dconfigbean/ResourceAdapterDConfigRoot.java

org/apache/geronimo/connector/deployment/RARConfiguration.java

org/apache/geronimo/connector/deployment/RARConfigurer.java

org/apache/geronimo/connector/deployment/dconfigbean/ResourceAdapterDConfigBean.java

org/apache/geronimo/connector/deployment/jsr88/ConnectionManager.java

org/apache/geronimo/connector/deployment/AdminObjectRefBuilder.java

org/apache/geronimo/connector/deployment/dconfigbean/ConfigPropertiesHelper.java

org/apache/geronimo/connector/deployment/jsr88/PartitionedPool.java

org/apache/geronimo/connector/deployment/jsr88/SinglePool.java

org/apache/geronimo/connector/deployment/jsr88/AdminObjectInstance.java

org/apache/geronimo/connector/deployment/jsr88/ConfigPropertySetting.java