GShell Support :: Common - Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
20	0	0	886

Rules

Rules	Violations	Severity
PackageHtml	3	Error
NewlineAtEndOfFile	9	Error
Translation	0	Error
JavadocMethod	107	Error
JavadocType	0	Error
JavadocVariable	47	Error
JavadocStyle	15	Error
ConstantName	8	Error
LocalFinalVariableName	0	Error
LocalVariableName	0	Error
MemberName	0	Error
MethodName	3	Error
PackageName	0	Error
ParameterName	0	Error
StaticVariableName	0	Error
TypeName	0	Error
Header headerFile: `"/Users/jason/ws/geronimo/gshell-tmp/gshell-support/gshell-common/target/checkstyle-header.txt"`	17	Error
AvoidStarImport	0	Error
IllegalImport	0	Error
RedundantImport	0	Error
UnusedImports	0	Error
FileLength	1	Error
LineLength max: `"120"`	1	Error
MethodLength	0	Error
ParameterNumber	1	Error
EmptyForIteratorPad	0	Error
NoWhitespaceAfter	0	Error
NoWhitespaceBefore	0	Error
OperatorWrap	10	Error
ParenPad	18	Error
TypecastParenPad	0	Error
TabCharacter	0	Error
WhitespaceAfter	0	Error
WhitespaceAround	47	Error
ModifierOrder	7	Error
RedundantModifier	0	Error
AvoidNestedBlocks	0	Error
EmptyBlock	4	Error
LeftCurly	11	Error
NeedBraces	2	Error
RightCurly	8	Error
AvoidInlineConditionals	10	Error
DoubleCheckedLocking	0	Error
EmptyStatement	0	Error
EqualsHashCode	0	Error
HiddenField ignoreConstructorParameter: `"true"` ignoreSetter: `"true"`	14	Error
IllegalInstantiation	0	Error
InnerAssignment	1	Error
MagicNumber	36	Error
MissingSwitchDefault	2	Error
RedundantThrows	1	Error
SimplifyBooleanExpression	1	Error
SimplifyBooleanReturn	0	Error
FinalClass	0	Error
HideUtilityClassConstructor	3	Error
InterfaceIsType	0	Error
VisibilityModifier	2	Error
ArrayTypeStyle	0	Error
FinalParameters	488	Error
GenericIllegalRegexp message: `"Line has trailing spaces."` format: `"\s+$"`	6	Error
TodoComment	3	Error
UpperEll	0	Error

Files

Files	I	W	E
org/apache/geronimo/gshell/common/StopWatch.java	0	0	29
org/apache/geronimo/gshell/common/tostring/StandardToStringStyle.java	0	0	24
org/apache/geronimo/gshell/common/tostring/ReflectionToStringBuilder.java	0	0	67
org/apache/geronimo/gshell/common/DurationFormatUtils.java	0	0	117
org/apache/geronimo/gshell/common/tostring/ToStringBuilder.java	0	0	120
org/apache/geronimo/gshell/common/io/package-info.java	0	0	1
org/apache/geronimo/gshell/common/tostring/ToStringStyle.java	0	0	240
org/apache/geronimo/gshell/common/package.html	0	0	1
org/apache/geronimo/gshell/common/tostring/package-info.java	0	0	1
org/apache/geronimo/gshell/common/Duration.java	0	0	22
org/apache/geronimo/gshell/common/NestedIOException.java	0	0	8
org/apache/geronimo/gshell/common/package-info.java	0	0	1
org/apache/geronimo/gshell/common/Arguments.java	0	0	25
org/apache/geronimo/gshell/common/NamedThreadFactory.java	0	0	17
org/apache/geronimo/gshell/common/io/PumpStreamHandler.java	0	0	49
org/apache/geronimo/gshell/common/io/package.html	0	0	1
org/apache/geronimo/gshell/common/io/StreamPumper.java	0	0	19
org/apache/geronimo/gshell/common/tostring/package.html	0	0	1
org/apache/geronimo/gshell/common/Notification.java	0	0	6
org/apache/geronimo/gshell/common/DateUtils.java	0	0	137

Details

org/apache/geronimo/gshell/common/StopWatch.java

Violation	Message	Line
	File does not end with a newline.	0
	Line does not match expected header line of ''.	1
	'{' should be on the previous line.	58
	Missing a Javadoc comment.	60
	Missing a Javadoc comment.	61
	Missing a Javadoc comment.	62
	Missing a Javadoc comment.	63
	Missing a Javadoc comment.	66
	Missing a Javadoc comment.	67
	Missing a Javadoc comment.	95
	Unused @throws tag for 'IllegalStateException'.	106
	'if' is not followed by whitespace.	109
	'if' is not followed by whitespace.	112
	Unused @throws tag for 'IllegalStateException'.	125
	'if' is not followed by whitespace.	128
	'if' is not followed by whitespace.	131
	Unused @throws tag for 'IllegalStateException'.	156
	'if' is not followed by whitespace.	159
	Unused @throws tag for 'IllegalStateException'.	172
	'if' is not followed by whitespace.	175
	Unused @throws tag for 'IllegalStateException'.	188
	'if' is not followed by whitespace.	191
	Unused @throws tag for 'IllegalStateException'.	204
	'if' is not followed by whitespace.	207
	'if' is not followed by whitespace.	224
	'if' is not followed by whitespace.	227
	'if' is not followed by whitespace.	230
	Unused @throws tag for 'IllegalStateException'.	243
	'if' is not followed by whitespace.	247

org/apache/geronimo/gshell/common/tostring/StandardToStringStyle.java

Violation	Message	Line
	File does not end with a newline.	0
	Line does not match expected header line of ''.	1
	Parameter useClassName should be final.	73
	Parameter useShortClassName should be final.	106
	Parameter shortClassName should be final.	117
	Parameter useIdentityHashCode should be final.	136
	Parameter useFieldNames should be final.	156
	Parameter defaultFullDetail should be final.	178
	Parameter arrayContentDetail should be final.	198
	Parameter arrayStart should be final.	221
	Parameter arrayEnd should be final.	244
	Parameter arraySeparator should be final.	267
	Parameter contentStart should be final.	290
	Parameter contentEnd should be final.	313
	Parameter fieldNameValueSeparator should be final.	336
	Parameter fieldSeparator should be final.	359
	Parameter fieldSeparatorAtStart should be final.	383
	Parameter fieldSeparatorAtEnd should be final.	407
	Parameter nullText should be final.	430
	Parameter sizeStartText should be final.	459
	Extra HTML tag found: </p>	467
	Parameter sizeEndText should be final.	488
	Parameter summaryObjectStartText should be final.	517
	Parameter summaryObjectEndText should be final.	546

org/apache/geronimo/gshell/common/tostring/ReflectionToStringBuilder.java

Violation	Message	Line
	File does not end with a newline.	0
	Line does not match expected header line of ''.	1
	Unused @throws tag for 'IllegalArgumentException'.	120
	Parameter object should be final.	123
	Unused @throws tag for 'IllegalArgumentException'.	152
	Parameter object should be final.	155
	Parameter style should be final.	155
	Unused @throws tag for 'IllegalArgumentException'.	190
	Parameter object should be final.	193
	Parameter style should be final.	193
	Parameter outputTransients should be final.	193
	Unused @throws tag for 'IllegalArgumentException'.	235
	Parameter object should be final.	239
	Parameter style should be final.	239
	Parameter outputTransients should be final.	239
	Parameter outputStatics should be final.	239
	Unused @throws tag for 'IllegalArgumentException'.	284
	Parameter object should be final.	288
	Parameter style should be final.	288
	Parameter outputTransients should be final.	288
	Parameter outputStatics should be final.	288
	Parameter reflectUpToClass should be final.	289
	Unused @throws tag for 'IllegalArgumentException'.	330
	Parameter object should be final.	334
	Parameter style should be final.	334
	Parameter outputTransients should be final.	335
	Parameter reflectUpToClass should be final.	335
	Parameter object should be final.	349
	Parameter object should be final.	362
	Parameter excludeFieldNames should be final.	362
	Parameter collection should be final.	375
	Parameter array should be final.	391
	Parameter object should be final.	412
	Parameter excludeFieldNames should be final.	412
	Unused @throws tag for 'IllegalArgumentException'.	447
	Parameter object should be final.	450
	Unused @throws tag for 'IllegalArgumentException'.	467
	Parameter object should be final.	470
	Parameter style should be final.	470
	Unused @throws tag for 'IllegalArgumentException'.	493
	Parameter object should be final.	496
	Parameter style should be final.	496
	Parameter buffer should be final.	496
	Parameter object should be final.	516
	Parameter style should be final.	516
	Parameter buffer should be final.	516
	Parameter reflectUpToClass should be final.	516
	Parameter outputTransients should be final.	517
	Parameter object should be final.	540
	Parameter style should be final.	540
	Parameter buffer should be final.	540
	Parameter reflectUpToClass should be final.	540
	Parameter outputTransients should be final.	541
	Parameter outputStatics should be final.	541
	Parameter field should be final.	560
	Parameter clazz should be final.	594
	Parameter field should be final.	655
	Redundant throws: 'IllegalArgumentException' is unchecked exception.	655
	Parameter array should be final.	691
	Parameter appendStatics should be final.	705
	Parameter appendTransients should be final.	717
	Parameter excludeFieldNamesParam should be final.	728
	Parameter clazz should be final.	746
	Missing a Javadoc comment.	774
	Name 'ArrayUtils_EMPTY_STRING_ARRAY' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	774
	Missing a Javadoc comment.	776
	Name 'ClassUtils_INNER_CLASS_SEPARATOR_CHAR' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	776

org/apache/geronimo/gshell/common/DurationFormatUtils.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Utility classes should not have a public or default constructor.	56
	'{' should be on the previous line.	57
	Parameter durationMillis should be final.	86
	Parameter durationMillis should be final.	101
	Parameter durationMillis should be final.	116
	Parameter format should be final.	116
	Parameter durationMillis should be final.	133
	Parameter format should be final.	133
	Parameter padWithZeros should be final.	133
	')' is preceded with whitespace.	143
	')' is preceded with whitespace.	147
	')' is preceded with whitespace.	151
	')' is preceded with whitespace.	155
	')' is preceded with whitespace.	159
	Parameter durationMillis should be final.	178
	Parameter suppressLeadingZeroElements should be final.	179
	Parameter suppressTrailingZeroElements should be final.	180
	Parameter startMillis should be final.	240
	Parameter endMillis should be final.	240
	Parameter startMillis should be final.	253
	Parameter endMillis should be final.	253
	Parameter format should be final.	253
	Parameter startMillis should be final.	280
	Parameter endMillis should be final.	280
	Parameter format should be final.	280
	Parameter padWithZeros should be final.	280
	Parameter timezone should be final.	281
	Comment matches to-do format 'TODO:'.	286
	'1000' is a magic number.	309
	'60' is a magic number.	313
	'60' is a magic number.	317
	'24' is a magic number.	321
	'12' is a magic number.	333
	'12' is a magic number.	339
	'if' is not followed by whitespace.	346
	'(' is followed by whitespace.	346
	')' is preceded with whitespace.	346
	'(' is followed by whitespace.	353
	'if' is not followed by whitespace.	357
	'if' is not followed by whitespace.	358
	'(' is followed by whitespace.	358
	'&&' should be on a new line.	358
	'29' is a magic number.	359
	')' is preceded with whitespace.	359
	')' is preceded with whitespace.	359
	'{' should be on the previous line.	360
	'while' is not followed by whitespace.	373
	'(' is followed by whitespace.	373
	')' is preceded with whitespace.	373
	'24' is a magic number.	393
	'60' is a magic number.	397
	'60' is a magic number.	401
	'1000' is a magic number.	405
	More than 7 parameters.	427
	Parameter tokens should be final.	427
	Parameter years should be final.	427
	Parameter months should be final.	427
	Parameter days should be final.	427
	Parameter hours should be final.	427
	Parameter minutes should be final.	427
	Parameter seconds should be final.	427
	Parameter milliseconds should be final.	428
	Parameter padWithZeros should be final.	428
	Avoid inline conditionals.	440
	Avoid inline conditionals.	444
	Avoid inline conditionals.	448
	Avoid inline conditionals.	452
	Avoid inline conditionals.	456
	Avoid inline conditionals.	460
	'1000' is a magic number.	465
	Avoid inline conditionals.	467
	Avoid inline conditionals.	472
	Missing a Javadoc comment.	482
	Name 'y' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	482
	Missing a Javadoc comment.	483
	Missing a Javadoc comment.	484
	Name 'd' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	484
	Missing a Javadoc comment.	485
	Missing a Javadoc comment.	486
	Name 'm' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	486
	Missing a Javadoc comment.	487
	Name 's' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	487
	Missing a Javadoc comment.	488
	First sentence should end with a period.	490
	Parameter format should be final.	496
	'<' is not preceded with whitespace.	498
	'<' is not followed by whitespace.	498
	'>' is not preceded with whitespace.	498
	'<' is not preceded with whitespace.	498
	'<' is not followed by whitespace.	498
	'>' is not preceded with whitespace.	498
	'>' is not followed by whitespace.	498
	'for' is not followed by whitespace.	504
	'=' is not preceded with whitespace.	504
	'=' is not followed by whitespace.	504
	'<' is not preceded with whitespace.	504
	'<' is not followed by whitespace.	504
	'if' is not followed by whitespace.	506
	Comment matches to-do format 'TODO:'.	512
	'if' is not followed by whitespace.	514
	'if' is not followed by whitespace.	531
	'if' is not followed by whitespace.	538
	'if' is not followed by whitespace.	539
	'(' is followed by whitespace.	549
	')' is preceded with whitespace.	549
	First sentence should end with a period.	557
	Parameter tokens should be final.	564
	Parameter value should be final.	564
	Missing a Javadoc comment.	574
	Missing a Javadoc comment.	575
	Parameter value should be final.	582
	Parameter value should be final.	594
	Parameter count should be final.	594
	First sentence should end with a period.	599
	First sentence should end with a period.	606
	Parameter obj2 should be final.	630

org/apache/geronimo/gshell/common/tostring/ToStringBuilder.java

Violation	Message	Line
	File does not end with a newline.	0
	Line does not match expected header line of ''.	1
	Parameter object should be final.	129
	Parameter object should be final.	141
	Parameter style should be final.	141
	Parameter object should be final.	154
	Parameter style should be final.	154
	Parameter outputTransients should be final.	154
	Parameter object should be final.	170
	Parameter style should be final.	171
	Parameter outputTransients should be final.	172
	Parameter reflectUpToClass should be final.	173
	Unused @throws tag for 'IllegalArgumentException'.	181
	Parameter style should be final.	183
	Unused @throws tag for 'IllegalArgumentException'.	212
	Parameter object should be final.	215
	Unused @throws tag for 'IllegalArgumentException'.	228
	Parameter object should be final.	231
	Parameter style should be final.	231
	Parameter object should be final.	248
	Parameter style should be final.	248
	Parameter buffer should be final.	248
	'512' is a magic number.	253
	Parameter value should be final.	271
	Parameter array should be final.	285
	Parameter value should be final.	299
	Parameter array should be final.	313
	Parameter value should be final.	327
	Parameter array should be final.	341
	Parameter value should be final.	355
	Parameter array should be final.	369
	Parameter value should be final.	383
	Parameter array should be final.	397
	Parameter value should be final.	411
	Parameter array should be final.	425
	Parameter value should be final.	439
	Parameter array should be final.	453
	Parameter obj should be final.	467
	Parameter array should be final.	481
	Parameter value should be final.	495
	Parameter array should be final.	509
	Parameter fieldName should be final.	522
	Parameter value should be final.	522
	Parameter fieldName should be final.	535
	Parameter array should be final.	535
	Parameter fieldName should be final.	555
	Parameter array should be final.	555
	Parameter fullDetail should be final.	555
	Parameter fieldName should be final.	568
	Parameter value should be final.	568
	Parameter fieldName should be final.	580
	Parameter array should be final.	580
	Parameter fieldName should be final.	600
	Parameter array should be final.	600
	Parameter fullDetail should be final.	600
	Parameter fieldName should be final.	613
	Parameter value should be final.	613
	Parameter fieldName should be final.	626
	Parameter array should be final.	626
	Parameter fieldName should be final.	646
	Parameter array should be final.	646
	Parameter fullDetail should be final.	646
	Parameter fieldName should be final.	659
	Parameter value should be final.	659
	Parameter fieldName should be final.	672
	Parameter array should be final.	672
	Parameter fieldName should be final.	692
	Parameter array should be final.	692
	Parameter fullDetail should be final.	692
	Parameter fieldName should be final.	705
	Parameter value should be final.	705
	Parameter fieldName should be final.	718
	Parameter array should be final.	718
	Parameter fieldName should be final.	738
	Parameter array should be final.	738
	Parameter fullDetail should be final.	738
	Parameter fieldName should be final.	751
	Parameter value should be final.	751
	Parameter fieldName should be final.	764
	Parameter array should be final.	764
	Parameter fieldName should be final.	784
	Parameter array should be final.	784
	Parameter fullDetail should be final.	784
	Parameter fieldName should be final.	797
	Parameter value should be final.	797
	Parameter fieldName should be final.	810
	Parameter array should be final.	810
	Parameter fieldName should be final.	830
	Parameter array should be final.	830
	Parameter fullDetail should be final.	830
	Parameter fieldName should be final.	843
	Parameter obj should be final.	843
	Parameter fieldName should be final.	858
	Parameter obj should be final.	858
	Parameter fullDetail should be final.	858
	Parameter fieldName should be final.	871
	Parameter array should be final.	871
	Parameter fieldName should be final.	891
	Parameter array should be final.	891
	Parameter fullDetail should be final.	891
	Parameter fieldName should be final.	904
	Parameter value should be final.	904
	Parameter fieldName should be final.	917
	Parameter array should be final.	917
	Parameter fieldName should be final.	937
	Parameter array should be final.	937
	Parameter fullDetail should be final.	937
	Parameter object should be final.	951
	'object' hides a field.	951
	Parameter superToString should be final.	970
	Parameter toString should be final.	1004
	Missing a Javadoc comment.	1065
	Name 'BooleanUtils_toBooleanObject' must match pattern '^[a-z][a-zA-Z0-9]*$'.	1065
	Parameter bool should be final.	1065
	Avoid inline conditionals.	1066
	Line has trailing spaces.	1068
	Missing a Javadoc comment.	1069
	Name 'ObjectUtils_appendIdentityToString' must match pattern '^[a-z][a-zA-Z0-9]*$'.	1069
	Parameter buffer should be final.	1069
	Parameter object should be final.	1069

org/apache/geronimo/gshell/common/io/package-info.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1

org/apache/geronimo/gshell/common/tostring/ToStringStyle.java

Violation	Message	Line
	File does not end with a newline.	0
	File length is 2,292 lines (max allowed is 2,000).	1
	Line does not match expected header line of ''.	1
	Parameter value should be final.	139
	Parameter value should be final.	152
	Parameter value should be final.	170
	Unclosed HTML tag found: <code>'<size'</code>.	256
	Unclosed HTML tag found: <size'</code>.	256
	Parameter buffer should be final.	295
	Parameter superToString should be final.	295
	Parameter buffer should be final.	308
	Parameter toString should be final.	308
	Parameter buffer should be final.	329
	Parameter object should be final.	329
	Parameter buffer should be final.	347
	Parameter object should be final.	347
	Expression can be simplified.	348
	Parameter buffer should be final.	361
	Parameter buffer should be final.	391
	Parameter fieldName should be final.	391
	Parameter value should be final.	391
	Parameter fullDetail should be final.	391
	Parameter buffer should be final.	423
	Parameter fieldName should be final.	423
	Parameter value should be final.	423
	Parameter detail should be final.	423
	Parameter buffer should be final.	534
	Parameter fieldName should be final.	534
	Parameter value should be final.	534
	Parameter buffer should be final.	547
	Parameter fieldName should be final.	547
	Parameter value should be final.	547
	Parameter buffer should be final.	559
	Parameter fieldName should be final.	559
	Parameter coll should be final.	559
	Unclosed HTML tag found: <code>.</p>	564
	Parameter buffer should be final.	571
	Parameter fieldName should be final.	571
	Parameter map should be final.	571
	Parameter buffer should be final.	584
	Parameter fieldName should be final.	584
	Parameter value should be final.	584
	Parameter buffer should be final.	600
	Parameter fieldName should be final.	600
	Parameter value should be final.	600
	Parameter buffer should be final.	614
	Parameter fieldName should be final.	614
	Parameter value should be final.	614
	Parameter buffer should be final.	628
	Parameter fieldName should be final.	628
	Parameter value should be final.	628
	Parameter buffer should be final.	642
	Parameter fieldName should be final.	642
	Parameter value should be final.	642
	Parameter buffer should be final.	656
	Parameter fieldName should be final.	656
	Parameter value should be final.	656
	Parameter buffer should be final.	670
	Parameter fieldName should be final.	670
	Parameter value should be final.	670
	Parameter buffer should be final.	684
	Parameter fieldName should be final.	684
	Parameter value should be final.	684
	Parameter buffer should be final.	698
	Parameter fieldName should be final.	698
	Parameter value should be final.	698
	Parameter buffer should be final.	712
	Parameter fieldName should be final.	712
	Parameter value should be final.	712
	Parameter buffer should be final.	726
	Parameter fieldName should be final.	726
	Parameter value should be final.	726
	Parameter buffer should be final.	740
	Parameter fieldName should be final.	740
	Parameter value should be final.	740
	Parameter buffer should be final.	754
	Parameter fieldName should be final.	754
	Parameter value should be final.	754
	Parameter buffer should be final.	768
	Parameter fieldName should be final.	768
	Parameter value should be final.	768
	Parameter buffer should be final.	782
	Parameter fieldName should be final.	782
	Parameter value should be final.	782
	Parameter buffer should be final.	796
	Parameter fieldName should be final.	796
	Parameter value should be final.	796
	Parameter buffer should be final.	810
	Parameter fieldName should be final.	810
	Parameter value should be final.	810
	Parameter buffer should be final.	824
	Parameter fieldName should be final.	824
	Parameter array should be final.	824
	Parameter fullDetail should be final.	824
	Parameter buffer should be final.	851
	Parameter fieldName should be final.	851
	Parameter array should be final.	851
	Parameter buffer should be final.	877
	Parameter fieldName should be final.	877
	Parameter array should be final.	877
	Parameter buffer should be final.	904
	Parameter fieldName should be final.	904
	Parameter array should be final.	904
	Parameter buffer should be final.	920
	Parameter fieldName should be final.	920
	Parameter array should be final.	920
	Parameter fullDetail should be final.	920
	Parameter buffer should be final.	945
	Parameter fieldName should be final.	945
	Parameter array should be final.	945
	Parameter buffer should be final.	965
	Parameter fieldName should be final.	965
	Parameter array should be final.	965
	Parameter buffer should be final.	981
	Parameter fieldName should be final.	981
	Parameter array should be final.	981
	Parameter fullDetail should be final.	981
	Parameter buffer should be final.	1006
	Parameter fieldName should be final.	1006
	Parameter array should be final.	1006
	Parameter buffer should be final.	1026
	Parameter fieldName should be final.	1026
	Parameter array should be final.	1026
	Parameter buffer should be final.	1042
	Parameter fieldName should be final.	1042
	Parameter array should be final.	1042
	Parameter fullDetail should be final.	1042
	Parameter buffer should be final.	1067
	Parameter fieldName should be final.	1067
	Parameter array should be final.	1067
	Parameter buffer should be final.	1087
	Parameter fieldName should be final.	1087
	Parameter array should be final.	1087
	Parameter buffer should be final.	1103
	Parameter fieldName should be final.	1103
	Parameter array should be final.	1103
	Parameter fullDetail should be final.	1103
	Parameter buffer should be final.	1128
	Parameter fieldName should be final.	1128
	Parameter array should be final.	1128
	Parameter buffer should be final.	1148
	Parameter fieldName should be final.	1148
	Parameter array should be final.	1148
	Parameter buffer should be final.	1164
	Parameter fieldName should be final.	1164
	Parameter array should be final.	1164
	Parameter fullDetail should be final.	1164
	Parameter buffer should be final.	1189
	Parameter fieldName should be final.	1189
	Parameter array should be final.	1189
	Parameter buffer should be final.	1209
	Parameter fieldName should be final.	1209
	Parameter array should be final.	1209
	Parameter buffer should be final.	1225
	Parameter fieldName should be final.	1225
	Parameter array should be final.	1225
	Parameter fullDetail should be final.	1225
	Parameter buffer should be final.	1250
	Parameter fieldName should be final.	1250
	Parameter array should be final.	1250
	Parameter buffer should be final.	1270
	Parameter fieldName should be final.	1270
	Parameter array should be final.	1270
	Parameter buffer should be final.	1286
	Parameter fieldName should be final.	1286
	Parameter array should be final.	1286
	Parameter fullDetail should be final.	1286
	Parameter buffer should be final.	1311
	Parameter fieldName should be final.	1311
	Parameter array should be final.	1311
	Parameter buffer should be final.	1331
	Parameter fieldName should be final.	1331
	Parameter array should be final.	1331
	Parameter buffer should be final.	1347
	Parameter fieldName should be final.	1347
	Parameter array should be final.	1347
	Parameter fullDetail should be final.	1347
	Parameter buffer should be final.	1372
	Parameter fieldName should be final.	1372
	Parameter array should be final.	1372
	Parameter buffer should be final.	1392
	Parameter fieldName should be final.	1392
	Parameter array should be final.	1392
	Parameter buffer should be final.	1404
	Parameter object should be final.	1404
	Parameter buffer should be final.	1421
	Parameter object should be final.	1421
	'!=' is not preceded with whitespace.	1422
	'!=' is not followed by whitespace.	1422
	Parameter buffer should be final.	1434
	Parameter buffer should be final.	1443
	Parameter buffer should be final.	1455
	Parameter fieldName should be final.	1455
	Parameter buffer should be final.	1464
	Parameter buffer should be final.	1474
	Parameter fieldName should be final.	1474
	Unclosed HTML tag found: <code> the field end.</p>	1482
	Parameter buffer should be final.	1487
	Parameter fieldName should be final.	1487
	Unclosed HTML tag found: <code>.</p>	1500
	Parameter buffer should be final.	1506
	Parameter fieldName should be final.	1506
	Parameter size should be final.	1506
	Parameter fullDetailRequest should be final.	1526
	Parameter cls should be final.	1542
	Line has trailing spaces.	1545
	Parameter useClassName should be final.	1565
	Parameter useShortClassName should be final.	1598
	Parameter shortClassName should be final.	1609
	Parameter useIdentityHashCode should be final.	1629
	Parameter useFieldNames should be final.	1649
	Parameter defaultFullDetail should be final.	1671
	Parameter arrayContentDetail should be final.	1691
	Parameter arrayStart should be final.	1714
	Parameter arrayEnd should be final.	1740
	Parameter arraySeparator should be final.	1766
	Parameter contentStart should be final.	1792
	Parameter contentEnd should be final.	1818
	Parameter fieldNameValueSeparator should be final.	1844
	Parameter fieldSeparator should be final.	1870
	Parameter fieldSeparatorAtStart should be final.	1897
	Parameter fieldSeparatorAtEnd should be final.	1921
	Parameter nullText should be final.	1944
	Parameter sizeStartText should be final.	1976
	Parameter sizeEndText should be final.	2008
	Parameter summaryObjectStartText should be final.	2040
	Parameter summaryObjectEndText should be final.	2072
	Missing a Javadoc comment.	2127
	Missing a Javadoc comment.	2161
	Unclosed HTML tag found: <code>Singleton</ode> after serialization.</p>	2175
	Extra HTML tag found: </ode> after serialization.</p>	2175
	Missing a Javadoc comment.	2193
	Unclosed HTML tag found: <code>Singleton</ode> after serialization.</p>	2210
	Extra HTML tag found: </ode> after serialization.</p>	2210
	Missing a Javadoc comment.	2229
	Missing a Javadoc comment.	2259
	Name 'SystemUtils_LINE_SEPARATOR' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	2259
	Name 'ObjectUtils_appendIdentityToString' must match pattern '^[a-z][a-zA-Z0-9]*$'.	2279
	Parameter buffer should be final.	2279
	Parameter object should be final.	2279

org/apache/geronimo/gshell/common/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/gshell/common/tostring/package-info.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1

org/apache/geronimo/gshell/common/Duration.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	30
	'{' should be on the previous line.	35
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	38
	Variable 'value' must be private and have accessor methods.	38
	Missing a Javadoc comment.	40
	Variable 'unit' must be private and have accessor methods.	40
	Missing a Javadoc comment.	42
	'}' should be on the same line.	47
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	57
	Missing a Javadoc comment.	61
	Line has trailing spaces.	64
	Missing a Javadoc comment.	65
	Missing a Javadoc comment.	72
	'if' construct must use '{}'s.	73
	'if' construct must use '{}'s.	74
	Missing a Javadoc comment.	81
	'32' is a magic number.	84
	'31' is a magic number.	85
	Avoid inline conditionals.	85

org/apache/geronimo/gshell/common/NestedIOException.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	31
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	48

org/apache/geronimo/gshell/common/package-info.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1

org/apache/geronimo/gshell/common/Arguments.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	Utility classes should not have a public or default constructor.	30
	'{' should be on the previous line.	31
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	36
	Parameter pos should be final.	36
	Line has trailing spaces.	42
	Missing a Javadoc comment.	48
	'=' is not preceded with whitespace.	53
	'=' is not followed by whitespace.	53
	'<' is not preceded with whitespace.	53
	'<' is not followed by whitespace.	53
	')' is preceded with whitespace.	53
	Missing a Javadoc comment.	63
	'=' is not preceded with whitespace.	68
	'=' is not followed by whitespace.	68
	'<' is not preceded with whitespace.	68
	'<' is not followed by whitespace.	68
	')' is preceded with whitespace.	68
	Missing a Javadoc comment.	78
	'=' is not preceded with whitespace.	83
	'=' is not followed by whitespace.	83
	'<' is not preceded with whitespace.	83
	'<' is not followed by whitespace.	83
	')' is preceded with whitespace.	83

org/apache/geronimo/gshell/common/NamedThreadFactory.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	33
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	48
	Missing a Javadoc comment.	52
	Missing a Javadoc comment.	56
	Missing a Javadoc comment.	60
	Missing a Javadoc comment.	64
	Missing a Javadoc comment.	68
	Missing a Javadoc comment.	76
	Line has trailing spaces.	80
	Missing a Javadoc comment.	86
	Missing a Javadoc comment.	90

org/apache/geronimo/gshell/common/io/PumpStreamHandler.java

Violation	Message	Line
	File does not end with a newline.	0
	Line does not match expected header line of ''.	1
	'{' should be on the previous line.	38
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	65
	Missing a Javadoc comment.	69
	'in' hides a field.	76
	Expected @param tag for 'in'.	76
	'in' hides a field.	85
	Expected @param tag for 'in'.	85
	'out' hides a field.	96
	Expected @param tag for 'out'.	96
	'}' should be on the same line.	101
	'}' should be on the same line.	145
	Must have at least one statement.	146
	'}' should be on the same line.	154
	Must have at least one statement.	155
	'}' should be on the same line.	166
	Must have at least one statement.	167
	'}' should be on the same line.	173
	Must have at least one statement.	174
	'in' hides a field.	182
	Expected @param tag for 'in'.	182
	'out' hides a field.	182
	Expected @param tag for 'out'.	182
	'in' hides a field.	192
	Expected @param tag for 'in'.	192
	'out' hides a field.	192
	Expected @param tag for 'out'.	192
	Expected an @return tag.	202
	'in' hides a field.	202
	Expected @param tag for 'in'.	202
	'out' hides a field.	202
	Expected @param tag for 'out'.	202
	'in' hides a field.	218
	'out' hides a field.	218
	Expected an @return tag.	231
	Line is longer than 120 characters.	231
	'in' hides a field.	231
	Expected @param tag for 'in'.	231
	'out' hides a field.	231
	Expected @param tag for 'out'.	231
	Expected @param tag for 'closeWhenExhausted'.	231

org/apache/geronimo/gshell/common/io/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/gshell/common/io/StreamPumper.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	38
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	51
	Missing a Javadoc comment.	53
	'128' is a magic number.	53
	Missing a Javadoc comment.	55
	Parameter autoflush should be final.	89
	Inner assignments should be avoided.	109
	'}' should be on the same line.	116
	'}' should be on the same line.	121
	Expected @throws tag for 'InterruptedException'.	148
	Unused @throws tag for 'IllegalStateException'.	158

org/apache/geronimo/gshell/common/tostring/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/gshell/common/Notification.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	29
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	44

org/apache/geronimo/gshell/common/DateUtils.java

Violation	Message	Line
	Line does not match expected header line of ''.	1
	Utility classes should not have a public or default constructor.	47
	'{' should be on the previous line.	48
	'static' modifier out of order with the JLS suggestions.	78
	Missing a Javadoc comment.	80
	Name 'fields' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	80
	'static' modifier out of order with the JLS suggestions.	95
	'static' modifier out of order with the JLS suggestions.	100
	'static' modifier out of order with the JLS suggestions.	105
	'static' modifier out of order with the JLS suggestions.	110
	'static' modifier out of order with the JLS suggestions.	115
	'static' modifier out of order with the JLS suggestions.	120
	Unused @throws tag for 'IllegalArgumentException'.	145
	Parameter date1 should be final.	148
	Parameter date2 should be final.	148
	Unused @throws tag for 'IllegalArgumentException'.	169
	Parameter cal1 should be final.	172
	Parameter cal2 should be final.	172
	'&&' should be on a new line.	176
	'&&' should be on a new line.	177
	Unused @throws tag for 'IllegalArgumentException'.	190
	Parameter date1 should be final.	193
	Parameter date2 should be final.	193
	Unused @throws tag for 'IllegalArgumentException'.	208
	Parameter cal1 should be final.	211
	Parameter cal2 should be final.	211
	Unused @throws tag for 'IllegalArgumentException'.	228
	Parameter cal1 should be final.	231
	Parameter cal2 should be final.	231
	'&&' should be on a new line.	235
	'&&' should be on a new line.	236
	'&&' should be on a new line.	237
	'&&' should be on a new line.	238
	'&&' should be on a new line.	239
	'&&' should be on a new line.	240
	'&&' should be on a new line.	241
	Unused @throws tag for 'IllegalArgumentException'.	256
	Parameter str should be final.	259
	Parameter parsePatterns should be final.	259
	Unused @throws tag for 'IllegalArgumentException'.	289
	Parameter date should be final.	291
	Parameter amount should be final.	291
	Unused @throws tag for 'IllegalArgumentException'.	303
	Parameter date should be final.	305
	Parameter amount should be final.	305
	Unused @throws tag for 'IllegalArgumentException'.	317
	Parameter date should be final.	319
	Parameter amount should be final.	319
	Unused @throws tag for 'IllegalArgumentException'.	331
	Parameter date should be final.	333
	Parameter amount should be final.	333
	Unused @throws tag for 'IllegalArgumentException'.	345
	Parameter date should be final.	347
	Parameter amount should be final.	347
	Unused @throws tag for 'IllegalArgumentException'.	359
	Parameter date should be final.	361
	Parameter amount should be final.	361
	Unused @throws tag for 'IllegalArgumentException'.	373
	Parameter date should be final.	375
	Parameter amount should be final.	375
	Unused @throws tag for 'IllegalArgumentException'.	387
	Parameter date should be final.	389
	Parameter amount should be final.	389
	Unused @throws tag for 'IllegalArgumentException'.	402
	Parameter date should be final.	404
	Parameter calendarField should be final.	404
	Parameter amount should be final.	404
	Unused @throws tag for 'IllegalArgumentException'.	440
	Unused @throws tag for 'ArithmeticException'.	441
	Parameter date should be final.	443
	Parameter field should be final.	443
	Unused @throws tag for 'IllegalArgumentException'.	478
	Unused @throws tag for 'ArithmeticException'.	479
	Parameter date should be final.	481
	Parameter field should be final.	481
	Unused @throws tag for 'IllegalArgumentException'.	515
	Unused @throws tag for 'ClassCastException'.	516
	Unused @throws tag for 'ArithmeticException'.	518
	Parameter date should be final.	520
	Parameter field should be final.	520
	Unused @throws tag for 'IllegalArgumentException'.	547
	Unused @throws tag for 'ArithmeticException'.	548
	Parameter date should be final.	550
	Parameter field should be final.	550
	Unused @throws tag for 'IllegalArgumentException'.	573
	Unused @throws tag for 'ArithmeticException'.	574
	Parameter date should be final.	576
	Parameter field should be final.	576
	Unused @throws tag for 'IllegalArgumentException'.	599
	Unused @throws tag for 'ClassCastException'.	601
	Unused @throws tag for 'ArithmeticException'.	603
	Parameter date should be final.	605
	Parameter field should be final.	605
	Unused @throws tag for 'ArithmeticException'.	625
	Parameter val should be final.	627
	Parameter field should be final.	627
	Parameter round should be final.	627
	'280000000' is a magic number.	628
	'500' is a magic number.	648
	'30' is a magic number.	657
	'1000L' is a magic number.	658
	'30' is a magic number.	666
	'60000L' is a magic number.	667
	'15' is a magic number.	688
	'-15' is a magic number.	690
	switch without "default" clause.	706
	'15' is a magic number.	715
	'15' is a magic number.	716
	'7' is a magic number.	719
	'12' is a magic number.	728
	'12' is a magic number.	729
	'6' is a magic number.	731
	Unused @throws tag for 'IllegalArgumentException'.	775
	Unused @throws tag for 'IllegalArgumentException'.	776
	Parameter focus should be final.	778
	Parameter rangeStyle should be final.	778
	Unused @throws tag for 'IllegalArgumentException'.	808
	Unused @throws tag for 'IllegalArgumentException'.	809
	Parameter focus should be final.	811
	Parameter rangeStyle should be final.	811
	switch without "default" clause.	841
	'3' is a magic number.	854
	'3' is a magic number.	855
	'7' is a magic number.	863
	'7' is a magic number.	866
	'7' is a magic number.	869
	'7' is a magic number.	872
	Unused @throws tag for 'IllegalArgumentException'.	897
	Unused @throws tag for 'ClassCastException'.	899
	Parameter focus should be final.	902
	Parameter rangeStyle should be final.	902
	Missing a Javadoc comment.	919
	Missing a Javadoc comment.	920
	Parameter startFinal should be final.	928
	Parameter endFinal should be final.	928
	First sentence should end with a period.	944
	Comment matches to-do format 'TODO:'.	970

Parent Project

Project Documentation

Checkstyle Results

Summary

Rules

Files

Details

org/apache/geronimo/gshell/common/StopWatch.java

org/apache/geronimo/gshell/common/tostring/StandardToStringStyle.java

org/apache/geronimo/gshell/common/tostring/ReflectionToStringBuilder.java

org/apache/geronimo/gshell/common/DurationFormatUtils.java

org/apache/geronimo/gshell/common/tostring/ToStringBuilder.java

org/apache/geronimo/gshell/common/io/package-info.java

org/apache/geronimo/gshell/common/tostring/ToStringStyle.java

org/apache/geronimo/gshell/common/package.html

org/apache/geronimo/gshell/common/tostring/package-info.java

org/apache/geronimo/gshell/common/Duration.java

org/apache/geronimo/gshell/common/NestedIOException.java

org/apache/geronimo/gshell/common/package-info.java

org/apache/geronimo/gshell/common/Arguments.java

org/apache/geronimo/gshell/common/NamedThreadFactory.java

org/apache/geronimo/gshell/common/io/PumpStreamHandler.java

org/apache/geronimo/gshell/common/io/package.html

org/apache/geronimo/gshell/common/io/StreamPumper.java

org/apache/geronimo/gshell/common/tostring/package.html

org/apache/geronimo/gshell/common/Notification.java

org/apache/geronimo/gshell/common/DateUtils.java