GShell - Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
22	0	0	205

Rules

Rules	Violations	Severity
PackageHtml	4	Error
NewlineAtEndOfFile	17	Error
Translation	0	Error
JavadocMethod	65	Error
JavadocType	7	Error
JavadocVariable	27	Error
JavadocStyle	0	Error
ConstantName	0	Error
LocalFinalVariableName	0	Error
LocalVariableName	0	Error
MemberName	0	Error
MethodName	0	Error
PackageName	0	Error
ParameterName	0	Error
StaticVariableName	0	Error
TypeName	0	Error
Header headerFile: `"/Users/jason/ws/geronimo/gshell-tmp/gshell-remote/gshell-remote-common/target/checkstyle-header.txt"`	18	Error
AvoidStarImport	0	Error
IllegalImport	0	Error
RedundantImport	0	Error
UnusedImports	0	Error
FileLength	0	Error
LineLength max: `"120"`	0	Error
MethodLength	0	Error
ParameterNumber	0	Error
EmptyForIteratorPad	0	Error
NoWhitespaceAfter	2	Error
NoWhitespaceBefore	1	Error
OperatorWrap	0	Error
ParenPad	0	Error
TypecastParenPad	0	Error
TabCharacter	0	Error
WhitespaceAfter	3	Error
WhitespaceAround	11	Error
ModifierOrder	0	Error
RedundantModifier	0	Error
AvoidNestedBlocks	0	Error
EmptyBlock	0	Error
LeftCurly	22	Error
NeedBraces	4	Error
RightCurly	7	Error
AvoidInlineConditionals	0	Error
DoubleCheckedLocking	0	Error
EmptyStatement	0	Error
EqualsHashCode	0	Error
HiddenField ignoreConstructorParameter: `"true"` ignoreSetter: `"true"`	0	Error
IllegalInstantiation	0	Error
InnerAssignment	0	Error
MagicNumber	1	Error
MissingSwitchDefault	1	Error
RedundantThrows	0	Error
SimplifyBooleanExpression	0	Error
SimplifyBooleanReturn	0	Error
FinalClass	0	Error
HideUtilityClassConstructor	0	Error
InterfaceIsType	0	Error
VisibilityModifier	0	Error
ArrayTypeStyle	0	Error
FinalParameters	1	Error
GenericIllegalRegexp message: `"Line has trailing spaces."` format: `"\s+$"`	13	Error
TodoComment	1	Error
UpperEll	0	Error

Files

Files	I	W	E
org/apache/geronimo/gshell/remote/jaas/UsernamePasswordCallbackHandler.java	0	0	13
org/apache/geronimo/gshell/remote/message/OpenShellMessage.java	0	0	6
org/apache/geronimo/gshell/remote/message/ConnectMessage.java	0	0	9
org/apache/geronimo/gshell/remote/package.html	0	0	1
org/apache/geronimo/gshell/remote/crypto/package.html	0	0	1
org/apache/geronimo/gshell/remote/message/RshMessage.java	0	0	6
org/apache/geronimo/gshell/remote/message/EchoMessage.java	0	0	7
org/apache/geronimo/gshell/remote/jaas/Identity.java	0	0	9
org/apache/geronimo/gshell/remote/crypto/package-info.java	0	0	2
org/apache/geronimo/gshell/remote/crypto/CryptoContext.java	0	0	28
org/apache/geronimo/gshell/remote/jaas/JaasConfigurationHelper.java	0	0	14
org/apache/geronimo/gshell/remote/message/LoginMessage.java	0	0	27
org/apache/geronimo/gshell/remote/jaas/package.html	0	0	1
org/apache/geronimo/gshell/remote/message/package-info.java	0	0	2
org/apache/geronimo/gshell/remote/package-info.java	0	0	3
org/apache/geronimo/gshell/remote/message/package.html	0	0	1
org/apache/geronimo/gshell/remote/jaas/GroupPrincipal.java	0	0	11
org/apache/geronimo/gshell/remote/message/CloseShellMessage.java	0	0	6
org/apache/geronimo/gshell/remote/crypto/CryptoContextAware.java	0	0	4
org/apache/geronimo/gshell/remote/jaas/UserPrincipal.java	0	0	11
org/apache/geronimo/gshell/remote/RemoteShell.java	0	0	5
org/apache/geronimo/gshell/remote/message/ExecuteMessage.java	0	0	38

Details

org/apache/geronimo/gshell/remote/jaas/UsernamePasswordCallbackHandler.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	37
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	47
	'}' should be on the same line.	52
	Missing a Javadoc comment.	58
	'cast' is not followed by whitespace.	61
	'}' should be on the same line.	64
	'cast' is not followed by whitespace.	66
	'}' should be on the same line.	70
	'}' should be on the same line.	74

org/apache/geronimo/gshell/remote/message/OpenShellMessage.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	29
	Missing a Javadoc comment.	30
	'{' is not followed by whitespace.	30
	'}' is not preceded with whitespace.	30

org/apache/geronimo/gshell/remote/message/ConnectMessage.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	31
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	42
	'{' should be on the previous line.	44
	Missing a Javadoc comment.	45

org/apache/geronimo/gshell/remote/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/gshell/remote/crypto/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/gshell/remote/message/RshMessage.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	31
	Missing a Javadoc comment.	32
	'{' is not followed by whitespace.	32
	'}' is not preceded with whitespace.	32

org/apache/geronimo/gshell/remote/message/EchoMessage.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	29
	Missing a Javadoc comment.	30
	Line has trailing spaces.	31
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	36

org/apache/geronimo/gshell/remote/jaas/Identity.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	35
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	51
	Missing a Javadoc comment.	55

org/apache/geronimo/gshell/remote/crypto/package-info.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1

org/apache/geronimo/gshell/remote/crypto/CryptoContext.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'=' is not preceded with whitespace.	40
	'{' should be on the previous line.	42
	Missing a Javadoc comment.	43
	Line has trailing spaces.	44
	Comment matches to-do format 'TODO:'.	46
	Line has trailing spaces.	48
	Missing a Javadoc comment.	50
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	57
	'1024' is a magic number.	59
	Line has trailing spaces.	60
	Missing a Javadoc comment.	64
	Missing a Javadoc comment.	68
	Missing a Javadoc comment.	78
	Missing a Javadoc comment.	82
	Missing a Javadoc comment.	86
	Missing a Javadoc comment.	90
	Missing a Javadoc comment.	94
	Line has trailing spaces.	103
	Missing a Javadoc comment.	108
	'}' should be on the same line.	111
	Missing a Javadoc comment.	117
	'}' should be on the same line.	120
	Missing a Javadoc comment.	126
	'}' should be on the same line.	129

org/apache/geronimo/gshell/remote/jaas/JaasConfigurationHelper.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'=' is not preceded with whitespace.	35
	'=' is not followed by whitespace.	35
	'{' should be on the previous line.	38
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	46
	Missing a Javadoc comment.	50
	'{' is not followed by whitespace.	50
	'}' is not preceded with whitespace.	50
	Line has trailing spaces.	51
	Missing a Javadoc comment.	52

org/apache/geronimo/gshell/remote/message/LoginMessage.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	35
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40
	Line has trailing spaces.	41
	Missing a Javadoc comment.	42
	Line has trailing spaces.	44
	Missing a Javadoc comment.	50
	Missing a Javadoc comment.	54
	'{' is followed by whitespace.	56
	Line has trailing spaces.	58
	Missing a Javadoc comment.	59
	Missing a Javadoc comment.	63
	Missing a Javadoc comment.	67
	Missing a Javadoc comment.	71
	'{' should be on the previous line.	73
	Missing a Javadoc comment.	74
	Missing a Javadoc comment.	76
	Parameter token should be final.	76
	Missing a Javadoc comment.	80
	Missing a Javadoc comment.	85
	'{' should be on the previous line.	87
	Missing a Javadoc comment.	88
	Missing a Javadoc comment.	90
	Missing a Javadoc comment.	94

org/apache/geronimo/gshell/remote/jaas/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/gshell/remote/message/package-info.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1

org/apache/geronimo/gshell/remote/package-info.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	22

org/apache/geronimo/gshell/remote/message/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/gshell/remote/jaas/GroupPrincipal.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	34
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	47
	'if' construct must use '{}'s.	48
	'if' construct must use '{}'s.	49
	Missing a Javadoc comment.	56
	Missing a Javadoc comment.	60

org/apache/geronimo/gshell/remote/message/CloseShellMessage.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	29
	Missing a Javadoc comment.	30
	'{' is not followed by whitespace.	30
	'}' is not preceded with whitespace.	30

org/apache/geronimo/gshell/remote/crypto/CryptoContextAware.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	28
	Missing a Javadoc comment.	29

org/apache/geronimo/gshell/remote/jaas/UserPrincipal.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	34
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	47
	'if' construct must use '{}'s.	48
	'if' construct must use '{}'s.	49
	Missing a Javadoc comment.	56
	Missing a Javadoc comment.	60

org/apache/geronimo/gshell/remote/RemoteShell.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	31
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	34

org/apache/geronimo/gshell/remote/message/ExecuteMessage.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	31
	Missing a Javadoc comment.	32
	Line has trailing spaces.	33
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	44
	'{' is followed by whitespace.	45
	Missing a Javadoc comment.	48
	Missing a Javadoc comment.	52
	Missing a Javadoc comment.	56
	Missing a Javadoc comment.	60
	Line has trailing spaces.	69
	Missing a Javadoc comment.	70
	'{' should be on the previous line.	71
	Missing a Javadoc comment.	72
	Missing a Javadoc comment.	73
	Missing a Javadoc comment.	74
	';' is preceded with whitespace.	75
	Missing a Javadoc comment.	77
	switch without "default" clause.	81
	'cast' is not followed by whitespace.	83
	Line has trailing spaces.	84
	Missing a Javadoc comment.	97
	'{' should be on the previous line.	99
	Missing a Javadoc comment.	100
	Missing a Javadoc comment.	102
	Missing a Javadoc comment.	106
	Missing a Javadoc comment.	111
	'{' should be on the previous line.	113
	Missing a Javadoc comment.	114
	Missing a Javadoc comment.	118
	Missing a Javadoc comment.	123
	'{' should be on the previous line.	125
	Missing a Javadoc comment.	126
	Missing a Javadoc comment.	130

Project Documentation

Checkstyle Results

Summary

Rules

Files

Details

org/apache/geronimo/gshell/remote/jaas/UsernamePasswordCallbackHandler.java

org/apache/geronimo/gshell/remote/message/OpenShellMessage.java

org/apache/geronimo/gshell/remote/message/ConnectMessage.java

org/apache/geronimo/gshell/remote/package.html

org/apache/geronimo/gshell/remote/crypto/package.html

org/apache/geronimo/gshell/remote/message/RshMessage.java

org/apache/geronimo/gshell/remote/message/EchoMessage.java

org/apache/geronimo/gshell/remote/jaas/Identity.java

org/apache/geronimo/gshell/remote/crypto/package-info.java

org/apache/geronimo/gshell/remote/crypto/CryptoContext.java

org/apache/geronimo/gshell/remote/jaas/JaasConfigurationHelper.java

org/apache/geronimo/gshell/remote/message/LoginMessage.java

org/apache/geronimo/gshell/remote/jaas/package.html

org/apache/geronimo/gshell/remote/message/package-info.java

org/apache/geronimo/gshell/remote/package-info.java

org/apache/geronimo/gshell/remote/message/package.html

org/apache/geronimo/gshell/remote/jaas/GroupPrincipal.java

org/apache/geronimo/gshell/remote/message/CloseShellMessage.java

org/apache/geronimo/gshell/remote/crypto/CryptoContextAware.java

org/apache/geronimo/gshell/remote/jaas/UserPrincipal.java

org/apache/geronimo/gshell/remote/RemoteShell.java

org/apache/geronimo/gshell/remote/message/ExecuteMessage.java