GShell - Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
19	0	0	347

Rules

Rules	Violations	Severity
PackageHtml	4	Error
NewlineAtEndOfFile	12	Error
Translation	0	Error
JavadocMethod	79	Error
JavadocType	3	Error
JavadocVariable	38	Error
JavadocStyle	0	Error
ConstantName	1	Error
LocalFinalVariableName	0	Error
LocalVariableName	0	Error
MemberName	0	Error
MethodName	0	Error
PackageName	0	Error
ParameterName	0	Error
StaticVariableName	0	Error
TypeName	0	Error
Header headerFile: `"/Users/jason/ws/geronimo/gshell-tmp/gshell-remote/gshell-remote-client/target/checkstyle-header.txt"`	15	Error
AvoidStarImport	0	Error
IllegalImport	0	Error
RedundantImport	0	Error
UnusedImports	0	Error
FileLength	0	Error
LineLength max: `"120"`	7	Error
MethodLength	0	Error
ParameterNumber	0	Error
EmptyForIteratorPad	0	Error
NoWhitespaceAfter	0	Error
NoWhitespaceBefore	0	Error
OperatorWrap	0	Error
ParenPad	0	Error
TypecastParenPad	0	Error
TabCharacter	0	Error
WhitespaceAfter	7	Error
WhitespaceAround	121	Error
ModifierOrder	0	Error
RedundantModifier	0	Error
AvoidNestedBlocks	0	Error
EmptyBlock	2	Error
LeftCurly	15	Error
NeedBraces	0	Error
RightCurly	10	Error
AvoidInlineConditionals	0	Error
DoubleCheckedLocking	0	Error
EmptyStatement	0	Error
EqualsHashCode	0	Error
HiddenField ignoreConstructorParameter: `"true"` ignoreSetter: `"true"`	2	Error
IllegalInstantiation	0	Error
InnerAssignment	0	Error
MagicNumber	0	Error
MissingSwitchDefault	0	Error
RedundantThrows	0	Error
SimplifyBooleanExpression	0	Error
SimplifyBooleanReturn	0	Error
FinalClass	0	Error
HideUtilityClassConstructor	0	Error
InterfaceIsType	0	Error
VisibilityModifier	3	Error
ArrayTypeStyle	0	Error
FinalParameters	4	Error
GenericIllegalRegexp message: `"Line has trailing spaces."` format: `"\s+$"`	15	Error
TodoComment	9	Error
UpperEll	0	Error

Files

Files	I	W	E
org/apache/geronimo/gshell/remote/client/proxy/RemoteShellProxy.java	0	0	59
org/apache/geronimo/gshell/remote/client/proxy/RemoteHistoryProxy.java	0	0	4
org/apache/geronimo/gshell/remote/client/proxy/package.html	0	0	1
org/apache/geronimo/gshell/remote/client/RshCommand.java	0	0	59
org/apache/geronimo/gshell/remote/client/proxy/RemoteShellInfoProxy.java	0	0	8
org/apache/geronimo/gshell/remote/client/handler/ClientSessionContext.java	0	0	17
org/apache/geronimo/gshell/remote/client/proxy/RemoteBrandingProxy.java	0	0	23
org/apache/geronimo/gshell/remote/client/proxy/RemoteEnvironmentProxy.java	0	0	7
org/apache/geronimo/gshell/remote/client/handler/ClientMessageHandlerSupport.java	0	0	18
org/apache/geronimo/gshell/remote/client/package.html	0	0	1
org/apache/geronimo/gshell/remote/client/auth/package.html	0	0	1
org/apache/geronimo/gshell/remote/client/handler/ClientMessageHandler.java	0	0	11
org/apache/geronimo/gshell/remote/client/RshClient.java	0	0	55
org/apache/geronimo/gshell/remote/client/handler/package.html	0	0	1
org/apache/geronimo/gshell/remote/client/auth/ClientPrincipal.java	0	0	11
org/apache/geronimo/gshell/remote/client/handler/EchoHandler.java	0	0	13
org/apache/geronimo/gshell/remote/client/package-info.java	0	0	3
org/apache/geronimo/gshell/remote/client/RemoteExecuteException.java	0	0	8
org/apache/geronimo/gshell/remote/client/auth/RemoteLoginModule.java	0	0	47

Details

org/apache/geronimo/gshell/remote/client/proxy/RemoteShellProxy.java

Violation	Message	Line
	File does not end with a newline.	0
	Line does not match expected header line of ''.	1
	'{' should be on the previous line.	46
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	51
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	57
	Missing a Javadoc comment.	59
	Missing a Javadoc comment.	61
	Missing a Javadoc comment.	63
	Missing a Javadoc comment.	65
	Missing a Javadoc comment.	67
	Comment matches to-do format 'TODO:'.	77
	Line has trailing spaces.	80
	Missing a Javadoc comment.	96
	Missing a Javadoc comment.	102
	Missing a Javadoc comment.	108
	Missing a Javadoc comment.	114
	Missing a Javadoc comment.	118
	'}' should be on the same line.	121
	Must have at least one statement.	122
	'{' is not followed by whitespace.	122
	'}' is not preceded with whitespace.	122
	'}' should be on the same line.	126
	Must have at least one statement.	127
	'{' is not followed by whitespace.	127
	'}' is not preceded with whitespace.	127
	Line has trailing spaces.	128
	Missing a Javadoc comment.	136
	Missing a Javadoc comment.	142
	'cast' is not followed by whitespace.	145
	Missing a Javadoc comment.	148
	Missing a Javadoc comment.	158
	Comment matches to-do format 'TODO:'.	166
	Line is longer than 120 characters.	166
	Line has trailing spaces.	168
	Comment matches to-do format 'TODO:'.	170
	'<' is not preceded with whitespace.	174
	'<' is not followed by whitespace.	174
	'>' is not preceded with whitespace.	174
	'<' is not preceded with whitespace.	174
	'<' is not followed by whitespace.	174
	'>' is not preceded with whitespace.	174
	'>' is not followed by whitespace.	174
	'<' is not preceded with whitespace.	175
	'<' is not followed by whitespace.	175
	'>' is not preceded with whitespace.	175
	'<' is not preceded with whitespace.	175
	'<' is not followed by whitespace.	175
	'>' is not preceded with whitespace.	175
	'>' is not followed by whitespace.	175
	'}' should be on the same line.	185
	Variable 'renderer' must be private and have accessor methods.	199
	Comment matches to-do format 'TODO:'.	203
	Comment matches to-do format 'TODO:'.	219
	Comment matches to-do format 'TODO:'.	227
	Line is longer than 120 characters.	231

org/apache/geronimo/gshell/remote/client/proxy/RemoteHistoryProxy.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	32
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	35

org/apache/geronimo/gshell/remote/client/proxy/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/gshell/remote/client/RshCommand.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'=' is not preceded with whitespace.	42
	'=' is not followed by whitespace.	42
	'{' should be on the previous line.	45
	Missing a Javadoc comment.	46
	'=' is not preceded with whitespace.	46
	'=' is not followed by whitespace.	46
	'=' is not preceded with whitespace.	46
	'=' is not followed by whitespace.	46
	'}' is not preceded with whitespace.	46
	'=' is not preceded with whitespace.	46
	'=' is not followed by whitespace.	46
	Missing a Javadoc comment.	49
	'=' is not preceded with whitespace.	49
	'=' is not followed by whitespace.	49
	'=' is not preceded with whitespace.	49
	'=' is not followed by whitespace.	49
	'}' is not preceded with whitespace.	49
	'=' is not preceded with whitespace.	49
	'=' is not followed by whitespace.	49
	Missing a Javadoc comment.	52
	'=' is not preceded with whitespace.	52
	'=' is not followed by whitespace.	52
	'=' is not preceded with whitespace.	52
	'=' is not followed by whitespace.	52
	'}' is not preceded with whitespace.	52
	'=' is not preceded with whitespace.	52
	'=' is not followed by whitespace.	52
	Line has trailing spaces.	54
	Missing a Javadoc comment.	55
	'=' is not preceded with whitespace.	55
	'=' is not followed by whitespace.	55
	'=' is not preceded with whitespace.	55
	'=' is not followed by whitespace.	55
	'=' is not preceded with whitespace.	55
	'=' is not followed by whitespace.	55
	Missing a Javadoc comment.	58
	'=' is not preceded with whitespace.	58
	'=' is not followed by whitespace.	58
	'=' is not preceded with whitespace.	58
	'=' is not followed by whitespace.	58
	'=' is not preceded with whitespace.	58
	'=' is not followed by whitespace.	58
	'<' is not preceded with whitespace.	59
	'<' is not followed by whitespace.	59
	'>' is not preceded with whitespace.	59
	'<' is not preceded with whitespace.	59
	'<' is not followed by whitespace.	59
	'>' is not preceded with whitespace.	59
	'>' is not followed by whitespace.	59
	Missing a Javadoc comment.	61
	Missing a Javadoc comment.	64
	Missing a Javadoc comment.	67
	Line is longer than 120 characters.	76
	Comment matches to-do format 'TODO:'.	87
	'}' should be on the same line.	102
	Line is longer than 120 characters.	104
	Line has trailing spaces.	109

org/apache/geronimo/gshell/remote/client/proxy/RemoteShellInfoProxy.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	35
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	48
	Missing a Javadoc comment.	52

org/apache/geronimo/gshell/remote/client/handler/ClientSessionContext.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	35
	Line is longer than 120 characters.	36
	Missing a Javadoc comment.	36
	'<' is not preceded with whitespace.	36
	'<' is not followed by whitespace.	36
	'>' is not preceded with whitespace.	36
	'<' is not preceded with whitespace.	36
	'<' is not followed by whitespace.	36
	'>' is not preceded with whitespace.	36
	'>' is not followed by whitespace.	36
	Variable 'pk' must be private and have accessor methods.	39
	Variable 'subject' must be private and have accessor methods.	42
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	48
	Missing a Javadoc comment.	52

org/apache/geronimo/gshell/remote/client/proxy/RemoteBrandingProxy.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	34
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	51
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	59
	Missing a Javadoc comment.	63
	Missing a Javadoc comment.	67
	Missing a Javadoc comment.	71
	Missing a Javadoc comment.	75
	Missing a Javadoc comment.	79
	Missing a Javadoc comment.	83
	Missing a Javadoc comment.	87
	Parameter name should be final.	87
	Missing a Javadoc comment.	91
	Parameter name should be final.	91
	Missing a Javadoc comment.	95
	Parameter name should be final.	95
	Parameter defaultValue should be final.	95

org/apache/geronimo/gshell/remote/client/proxy/RemoteEnvironmentProxy.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	34
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	47

org/apache/geronimo/gshell/remote/client/handler/ClientMessageHandlerSupport.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Type Javadoc comment is missing an @param <T> tag.	31
	'<' is not preceded with whitespace.	31
	'<' is not followed by whitespace.	31
	'>' is not preceded with whitespace.	31
	'<' is not preceded with whitespace.	32
	'<' is not followed by whitespace.	32
	'>' is not preceded with whitespace.	32
	'<' is not preceded with whitespace.	33
	'<' is not followed by whitespace.	33
	'>' is not preceded with whitespace.	33
	'{' should be on the previous line.	34
	Missing a Javadoc comment.	35
	'<' is not preceded with whitespace.	35
	'<' is not followed by whitespace.	35
	'>' is not preceded with whitespace.	35
	Missing a Javadoc comment.	39

org/apache/geronimo/gshell/remote/client/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/gshell/remote/client/auth/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/gshell/remote/client/handler/ClientMessageHandler.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Type Javadoc comment is missing an @param <T> tag.	31
	'<' is not preceded with whitespace.	31
	'<' is not followed by whitespace.	31
	'>' is not preceded with whitespace.	31
	'<' is not preceded with whitespace.	32
	'<' is not followed by whitespace.	32
	'>' is not preceded with whitespace.	32
	'{' should be on the previous line.	33
	Missing a Javadoc comment.	34

org/apache/geronimo/gshell/remote/client/RshClient.java

Violation	Message	Line
	File does not end with a newline.	0
	Line does not match expected header line of ''.	1
	'=' is not preceded with whitespace.	60
	'=' is not followed by whitespace.	60
	'=' is not preceded with whitespace.	60
	'=' is not followed by whitespace.	60
	'{' should be on the previous line.	63
	Missing a Javadoc comment.	64
	Missing a Javadoc comment.	66
	Line has trailing spaces.	68
	Missing a Javadoc comment.	69
	Missing a Javadoc comment.	72
	Missing a Javadoc comment.	74
	'=' is not preceded with whitespace.	74
	'=' is not followed by whitespace.	74
	'<' is not preceded with whitespace.	75
	'<' is not followed by whitespace.	75
	'>' is not preceded with whitespace.	75
	Missing a Javadoc comment.	77
	Missing a Javadoc comment.	81
	Missing a Javadoc comment.	89
	Missing a Javadoc comment.	93
	Missing a Javadoc comment.	97
	Missing a Javadoc comment.	101
	Missing a Javadoc comment.	105
	Missing a Javadoc comment.	110
	'cast' is not followed by whitespace.	118
	'}' should be on the same line.	120
	Missing a Javadoc comment.	126
	'}' should be on the same line.	137
	Line has trailing spaces.	145
	Missing a Javadoc comment.	146
	Line has trailing spaces.	148
	Missing a Javadoc comment.	154
	Comment matches to-do format 'TODO:'.	160
	Missing a Javadoc comment.	166
	Comment matches to-do format 'TODO:'.	172
	Line has trailing spaces.	174
	Missing a Javadoc comment.	178
	'cast' is not followed by whitespace.	185
	'cast' is not followed by whitespace.	192
	Missing a Javadoc comment.	204
	Missing a Javadoc comment.	210
	Missing a Javadoc comment.	216
	Missing a Javadoc comment.	227
	'{' should be on the previous line.	229
	Missing a Javadoc comment.	230
	Missing a Javadoc comment.	241
	'<' is not preceded with whitespace.	244
	'<' is not followed by whitespace.	244
	'?' is not preceded with whitespace.	244
	'>' is not preceded with whitespace.	244
	'?' is not followed by whitespace.	244
	Missing a Javadoc comment.	252
	Missing a Javadoc comment.	261

org/apache/geronimo/gshell/remote/client/handler/package.html

Violation	Message	Line
	Missing package documentation file.	0

org/apache/geronimo/gshell/remote/client/auth/ClientPrincipal.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	16
	Missing a Javadoc comment.	17
	Missing a Javadoc comment.	19
	Line has trailing spaces.	20
	Missing a Javadoc comment.	21
	Missing a Javadoc comment.	23
	Line has trailing spaces.	26
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	39

org/apache/geronimo/gshell/remote/client/handler/EchoHandler.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'=' is not preceded with whitespace.	31
	'=' is not followed by whitespace.	31
	'=' is not preceded with whitespace.	31
	'=' is not followed by whitespace.	31
	'<' is not preceded with whitespace.	33
	'<' is not followed by whitespace.	33
	'>' is not preceded with whitespace.	33
	'{' should be on the previous line.	34
	Missing a Javadoc comment.	35
	Line is longer than 120 characters.	39
	Missing a Javadoc comment.	39

org/apache/geronimo/gshell/remote/client/package-info.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	22

org/apache/geronimo/gshell/remote/client/RemoteExecuteException.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	29
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	44

org/apache/geronimo/gshell/remote/client/auth/RemoteLoginModule.java

Violation	Message	Line
	Missing a header - not enough lines in file.	1
	'{' should be on the previous line.	48
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	51
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	57
	Missing a Javadoc comment.	59
	Line is longer than 120 characters.	61
	Missing a Javadoc comment.	61
	'subject' hides a field.	61
	'callbackHandler' hides a field.	61
	'<' is not preceded with whitespace.	61
	'<' is not followed by whitespace.	61
	'>' is not preceded with whitespace.	61
	'?' is not followed by whitespace.	61
	'<' is not preceded with whitespace.	61
	'<' is not followed by whitespace.	61
	'>' is not preceded with whitespace.	61
	'?' is not followed by whitespace.	61
	Missing a Javadoc comment.	66
	Missing a Javadoc comment.	72
	'}' should be on the same line.	84
	'}' should be on the same line.	87
	'cast' is not followed by whitespace.	92
	'}' should be on the same line.	99
	'cast' is not followed by whitespace.	105
	'}' should be on the same line.	108
	'cast' is not followed by whitespace.	110
	Line has trailing spaces.	114
	Missing a Javadoc comment.	118
	Missing a Javadoc comment.	128
	Missing a Javadoc comment.	134
	Line has trailing spaces.	143
	Missing a Javadoc comment.	144
	'<' is not preceded with whitespace.	144
	'<' is not followed by whitespace.	144
	'>' is not preceded with whitespace.	144
	Name 'transportHolder' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	144
	'<' is not preceded with whitespace.	144
	'<' is not followed by whitespace.	144
	'>' is not preceded with whitespace.	144
	'>' is not followed by whitespace.	144
	Missing a Javadoc comment.	146
	Missing a Javadoc comment.	152
	Missing a Javadoc comment.	156
	Line has trailing spaces.	160

Project Documentation

Checkstyle Results

Summary

Rules

Files

Details

org/apache/geronimo/gshell/remote/client/proxy/RemoteShellProxy.java

org/apache/geronimo/gshell/remote/client/proxy/RemoteHistoryProxy.java

org/apache/geronimo/gshell/remote/client/proxy/package.html

org/apache/geronimo/gshell/remote/client/RshCommand.java

org/apache/geronimo/gshell/remote/client/proxy/RemoteShellInfoProxy.java

org/apache/geronimo/gshell/remote/client/handler/ClientSessionContext.java

org/apache/geronimo/gshell/remote/client/proxy/RemoteBrandingProxy.java

org/apache/geronimo/gshell/remote/client/proxy/RemoteEnvironmentProxy.java

org/apache/geronimo/gshell/remote/client/handler/ClientMessageHandlerSupport.java

org/apache/geronimo/gshell/remote/client/package.html

org/apache/geronimo/gshell/remote/client/auth/package.html

org/apache/geronimo/gshell/remote/client/handler/ClientMessageHandler.java

org/apache/geronimo/gshell/remote/client/RshClient.java

org/apache/geronimo/gshell/remote/client/handler/package.html

org/apache/geronimo/gshell/remote/client/auth/ClientPrincipal.java

org/apache/geronimo/gshell/remote/client/handler/EchoHandler.java

org/apache/geronimo/gshell/remote/client/package-info.java

org/apache/geronimo/gshell/remote/client/RemoteExecuteException.java

org/apache/geronimo/gshell/remote/client/auth/RemoteLoginModule.java