/[Apache-SVN]
ViewVC logotype

Revision 790142


Jump to revision: Previous Next
Author: adelmelle
Date: Wed Jul 1 12:36:17 2009 UTC (14 years, 11 months ago)
Changed paths: 4
Log Message:
Some cleanups and attempts at improving code-readability and -extensibility:
* added inner holder class to BreakingAlgorithm to contain everything related to the fitness classes. Improves readability of both the code and the trace messages.
* extracted blocks of code in BreakingAlgorithm.findBreakingPoints() into protected methods. Following the already existing handleBox(), added handleGlueAt() and handlePenaltyAt() to provide extension points to subclasses. Extraction of the code-blocks related to the node-recovery mechanism.
* extracted blocks of code in BreakingAlgorithm.considerLegalBreak() into protected methods: deactivateNode(), activateNode() and forceNode()
* factored the functionality to obtain the index of the first box into KnuthSequence... just seemed to make sense; may be useful elsewhere.
* some (but not all :() javadoc fixups
* minor changes to LineLayoutManager and PageBreakingAlgorithm to take into account above changes

Changed paths

Path Details
Directoryxmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/BreakingAlgorithm.java modified , text changed
Directoryxmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/KnuthSequence.java modified , text changed
Directoryxmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/PageBreakingAlgorithm.java modified , text changed
Directoryxmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/LineLayoutManager.java modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26