/[Apache-SVN]
ViewVC logotype

Revision 1908545


Jump to revision: Previous Next
Author: philip
Date: Mon Mar 20 01:20:29 2023 UTC (15 months, 1 week ago)
Changed paths: 1
Log Message:
Fix a one definition rule (ODR) violation: explicitly linking
to both the libsvn_subr amalgation wrapper and the libsvn_subr
library is wrong. It's typically not a bug in a static build
because the linker will usually not pull the unneeded file from
the static library, but in a shared build the whole library is
used at runtime. It was harmless in practice because the symbols
were the same, so it didn't matter which ones were used, but an
ODR violation is strictly undefined behaviour, even in
non-amalgamtion builds when only a dummy symbol gets redefined.
GCC's santizer detects ODR violations.

* build.conf (wc-queries-test): Don't link SQLite wrapper.

** reverted in r1910481 since it broke tests on Windows **

Changed paths

Path Details
Directorysubversion/trunk/build.conf modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26