This page last changed on May 16, 2008 by aidan.

Agenda

Check on progress of last weeks review points
Commit review
JIRA Review
Landing Java Broker Refactoring

Attendees

Aidan, Arnaud, Rafi, Carl, Martin, Rob, Marnie

Outstanding actions

Almost all prior actions need to be taken, please seem last weeks minutes for details

Comitters need to get better at reviewing submitted patches 

Review of Code Commits

revision committer date comment review points
r654799 aidan 2008-05-09 allow merging from M2.x  
r654803 aidan 2008-05-09 allow merging from M2.x  
r654818 aidan 2008-05-09 Merged revisions 652388-653415,653417-654109 via svnmerge from https://svn.apache.org/repos/asf/incubator/qpid/branches/M2.x ........ r652388 - ritchiem - 2008-04-30 15:40:18 +0100 (Wed, 30 Apr 20 ...  
r654866 astitcher 2008-05-09 Fix to managementgen so that VPATH builds work  
r654902 gsim 2008-05-09 QPID-648 : Patch from Matt Farrellee - support for realms - updates to packaging to create a default db and the necessary conf files for plain and anon  
r654907 rhs 2008-05-09 QPID-1045 : always notify incoming message queues of session closure and provide API for notifying listeners of closure; also preserve connection close code and report in errors  
r654913 aconway 2008-05-09 Support for 0-10 sessions, not yet integrated. Misc minor fixes.  
r654918 rhs 2008-05-09 QPID-1045 and QPID-1041 : added a destination attribute to incoming queues, and added a start() method to incoming queues as syntactic sugar for the verbose message flow idiom  
r654927 nsantos 2008-05-09 QPID-1047 : Qpidc.spec.in is missing dependencies and has misplaced files - applied patch from Matt Farrellee  
r654947 rhs 2008-05-09 QPID-947 : made python client use execution.sync instead of session.flush when not in auto_sync mode  
r655323 rgodfrey 2008-05-11 Updates on the refactoring work  
r655326 rgodfrey 2008-05-11 Copy over QPID-925  
r655330 rgodfrey 2008-05-11 Copy over QPID-926  
r655353 gsim 2008-05-11 QPID-1048 : Only wait for enqueue completion for persistent queues.  
r655455 gsim 2008-05-12 Script to test federated setup using the topic test.  
r655470 aidan 2008-05-12 QPID-839 fix test to avoid potential race condition and general incorrectness AS: merge to trunk
r655494 gsim 2008-05-12 Couple of extra simple tests for publishing and consuming in generic fashion.  
r655495 gsim 2008-05-12 Extra ignores  
r655533 rhs 2008-05-12 QPID-947 : added handler for known_completed and generate known_completed when timely-reply is set  
r655534 rhs 2008-05-12 QPID-947 : fixed typo in prior commit  
r655536 rhs 2008-05-12 QPID-1037 : removed manual setting of the module.name property as it is set automatically by the build scripts  
r655563 gsim 2008-05-12 QPID-1050 : Patch from Ted Ross: 1) Durability for federation links (broker-to-broker connections) 2) Improved handling of federation links: a) Links can be created even if the remote broker is no ...  
r655568 gsim 2008-05-12 QPID-1044 : Part of patch from Jonathan Robie + changes to verify scripts to keep automated testing working.  
r655585 rhs 2008-05-12 QPID-1025 : updated fix for empty payload issue, this change removes state transitions that don't consume input bytes  
r655596 astitcher 2008-05-12 QPID-1039 : Patch from Mick Goulish: Fix program options behavior for Boost 103200  
r655597 astitcher 2008-05-12 Fix to allow VPATH builds to work after checkin for QPID-648  
r655619 gsim 2008-05-12 QPID-1052 : Patch from Ted Ross This patch contains the following: 1) The session-id reported by the management API now matches the session.name in the session table 2) management.py API has a new ca ...  
r655630 rgodfrey 2008-05-12 More fixing up of refactoring stuff; getting all maven tests passing and implementing management methods  
r655781 rgodfrey 2008-05-13 Fixed broken exception overriding  
r655790 gsim 2008-05-13 Fix macro used in test for backwards compatability.  
r655798 rgodfrey 2008-05-13 Changes to MessageStore interface  
r655915 nsantos 2008-05-13 QPID-1052 : Management: session.name matches session id provided by API, handling of lost connections - applied patch supplied by Ted Ross  
r655923 arnaudsimon 2008-05-13 QPID-1006 : Don't use tcp-nodelay as default and set socket buffer size only when the corresponding property is set. Discuss on list, config item, more investigation required
r655927 rhs 2008-05-13 QPID-1053 : updated QpidTestCase to check against broker output to ensure the broker is actually listening before the test attempts to connect; the text checked for is controlled by the broker.ready sy ...  
r655935 aconway 2008-05-13 Added enum CreditUnit MESSAGE=0, BYTE=1 ;  
r655944 gsim 2008-05-13 QPID-1054 : Fixed reporting of startup failures in daemon mode.  
r655951 rhs 2008-05-13 QPID-1055 : use int64 for encoding python both python int and longs; this ensures consistent behavior on both 64 bit and non 64 bit systems  
r655956 aconway 2008-05-13 Removed confusing broker::Message typedef intrusive_ptr<Message> shared_ptr  
r655957 gsim 2008-05-13 Fail with exception if queue is not durable and configured policy is exceeded.  
r655964 rhs 2008-05-13 QPID-1053 : add a timeout in case the broker is never ready  
r655965 aconway 2008-05-13 Fix typo in examples.  
r655966 aconway 2008-05-13 Ignore sasldb  
r655968 gsim 2008-05-13 Minor change to tests to use correlation id rather than body for identifying messages.  
r655976 rhs 2008-05-13 QPID-954 : added fallbacks and fixes for running the python client on python 2.3  
r655983 aconway 2008-05-13 Added sync() to ensure all acks are receivd before exiting the Dispatcher loop.  
r656004 nsantos 2008-05-13 continuation of QPID-1052  
r656005 aconway 2008-05-13 From Jonathan Robie: QPID-1056 :" title="Visit page outside Confluence" rel="nofollow"linktype="raw" linktext="https://issues.apache.org/jira/browse/QPID-1056 :">QPID-1056 :" title="Visit page outside Confluence" rel="nofollow"linktype="raw" linktext="https://issues.apache.org/jira/browse/QPID-1056 :"> QPID-1056 :">https://issues.apache.org/jira/browse/QPID-1056 :

Python examples for the xml exchange. QPID-1057 " title="Visit page outside Confluence" rel="nofollow"linktype="raw" linktext="https://issues.apache.org/jira/browse/QPID-1057 ">QPID-1057 " title="Visit page outside Confluence" rel="nofollow"linktype="raw" linktext="https://issues.apache.org/jira/browse/QPID-1057 ">

QPID-1057 ">https://issues.apache.org/jira/browse/QPID-1057

Fixes to the XmlExchange.cpp that preve ...

 
r656023 gsim 2008-05-13 QPID-990 : Patch from Ted Ross to enable persisting of inter-broker routing entities  
r656071 rajith 2008-05-14 Modified the verify_java_python.in file to reflect the changes made to the python code in rev 655965. The change was to correct a few typos.  
r656255 aconway 2008-05-14 Fixed python/examples/xml-exchange verify script.  
r656299 aidan 2008-05-14 add ignore file  
r656301 aidan 2008-05-14 Merge branch 'python-mllib' Should have had Jira
r656320 aconway 2008-05-14 Fix valgrind problems in VPATH builds.  
r656326 aconway 2008-05-14 Exclude XML example checks if XML support is not available.  
r656328 aconway 2008-05-14 svn:ignore properties.  
r656331 gsim 2008-05-14 Fix for large messages.  
r656335 gsim 2008-05-14 Don't fail if python tests aren't found.  
r656357 rhs 2008-05-14 QPID-965 : made the ant build report the cummulative success/failure of the test suite  
r656369 aconway 2008-05-14 Undo revision 656320, causing build problems.  
r656373 aconway 2008-05-14 Exclude XML example if XML not enabled.  
r656376 cctrieloff 2008-05-14 Added requires for XML exchange  
r656427 aconway 2008-05-14 Fix example check in rpmbuild.  
r656443 aconway 2008-05-14 Python tests running in rpmbuild.  
r656689 rhs 2008-05-15 added .class files to svn:ignore for common  
r656690 rhs 2008-05-15 fixed a typo in 010ExcludeList  
r656760 rhs 2008-05-15 QPID-1062 : phase 1 of improvements to 0-10 encode/decode; this inlines the read/write method of structs into generated code resulting in roughly a 2x improvement  
r656766 nsantos 2008-05-15 change ordering of config records in management updates; patch supplied by Ted Ross  
r656849 rgodfrey 2008-05-15 Fixed credit restoration, turned off biased write pool by default, removed unused lock from queue  
r656853 aconway 2008-05-15
  • Enable python tets and examples in make rpmbuild. - Remove hard-coded amqp.xml paths from python examples.
 
r656855 kpvdr 2008-05-15 Patch from michael goulish: QPID-1063 : "under Boost 103200, command line args with = didn't work"  
r656859 aconway 2008-05-15
  • Remove redundant comments about AMQP_SPEC
 
r656871 rhs 2008-05-15 QPID-1064 : made qpid-config close the session/connection; added incoming.stop() to cancel incoming messages and join on the listener thread; made managementBroker.removeChannel use incoming.stop(); mo ...  
r656918 nsantos 2008-05-16 QPID-1061 : Management heartbeat message from broker - applied patch supplied by Ted Ross  
r656920 nsantos 2008-05-16 QPID-1065 : Management messages may lost if client attach hits a small time window - patch supplied by Ted Ross  
r656924 cctrieloff 2008-05-16 QPID-1034 by Senaka Fernando  
r656926 cctrieloff 2008-05-16 QPID-1017 by Senaka Fernando - with a few small edits  

Recently Raised JIRAs

Key Component(s) Affects Version/s Summary Status Assignee Reporter Review Comments
QPID-1038 Dot Net Client M2.1, M3 (QPID-1038) Blocking I/O in transport layer leads to poor performance for mixed sender/producer Open Aidan Skinner Aidan Skinner  
QPID-1039 C++ Broker   (QPID-1039) fix program options behavior for Boost 103200 Closed Unassigned michael goulish  
QPID-1040 C++ Broker M3 (QPID-1040) Asynchronous Protocol Connector for C++ broker Closed Andrew Stitcher Ted Ross  
QPID-1041 Python Client M3 (QPID-1041) Sources and sinks should all have names ( a problem in at least the Python client ) Open Rafael H. Schloming Jonathan Robie  
QPID-1042 C++ Broker M3 (QPID-1042) Record of deliveries not kept for non-acquired, non-accepted subscriptions in credit flow mode Closed Gordon Sim Gordon Sim  
QPID-1043 website M3 (QPID-1043) Add page with a clear grid of protocol support for each qpid component Open Gordon Sim Gordon Sim  
QPID-1044     (QPID-1044) Python examples need updating for tutorial Open Unassigned Jonathan Robie  
QPID-1045 Python Client M3 (QPID-1045) incoming message queues are not always notified of session closure Resolved Rafael H. Schloming Rafael H. Schloming  
QPID-1046 Python Client M3 (QPID-1046) Provide easy way to start incoming message flow Resolved Rafael H. Schloming Justin Ross  
QPID-1047     (QPID-1047) Qpidc.spec.in is missing dependencies and has misplaced files Open Unassigned Matthew Farrellee  
QPID-1048 C++ Broker M3 (QPID-1048) Dispatch of durable message from non-durable queue held up if message is also enqueued asynchronously on durable queue Resolved Gordon Sim Gordon Sim  
QPID-1049 Java Broker M2, M2.1 (QPID-1049) Unnecessary WARN level logging in DestWildExchange Open Unassigned Martin Ritchie  
QPID-1050 C++ Broker M3 (QPID-1050) Durablilty of federation config, other miscellaneous fixes Closed Unassigned Ted Ross  
QPID-1051 C++ Client   (QPID-1051) The C++ examples contain some typos and other mistakes that will confuse users. These are usability errors Open Alan Conway William Henry  
QPID-1052 C++ Broker, Python Client M3 (QPID-1052) Management: session.name matches session id provided by API, handling of lost connections Closed Unassigned Ted Ross  
QPID-1053 Java Client M3 (QPID-1053) QpidTestCase should use something smarter than Thread.sleep(1000) to ensure that an external broker is listening on the port Resolved Rafael H. Schloming Rafael H. Schloming  
QPID-1054 C++ Broker M3 (QPID-1054) Startup failures not reported when in daemon mode Resolved Gordon Sim Gordon Sim  
QPID-1055 Python Client M3 (QPID-1055) map codec failures on 64 bit systems Resolved Rafael H. Schloming Rafael H. Schloming  
QPID-1056 Python Client   (QPID-1056) XML Exchange - Python example Resolved Unassigned Jonathan Robie  
QPID-1057 C++ Broker   (QPID-1057) Fix XML Exchange for Python client (which does not supply an empty FieldTable if there are no application message headers) Resolved Unassigned Jonathan Robie  
QPID-1058 Dot Net Client M2, M2.1 (QPID-1058) Add support for CRAM-MD5-HASHED as used by Java Broker Open Unassigned Martin Ritchie  
QPID-1059 Code Generator M3 (QPID-1059) mllib passes absoloute windows path as URL Open Aidan Skinner Aidan Skinner  
QPID-1060 Java Broker M2.1 (QPID-1060) (Java Broker) OutOfMemory due to continued reference to ContentHeaderBody on Persistent Messages Open Rob Godfrey Rob Godfrey  
QPID-1061 C++ Broker, Python Client M3 (QPID-1061) Management heartbeat message from broker Closed Unassigned Ted Ross  
QPID-1062 Java Client M3 (QPID-1062) improve performance of 0-10 encode/decode Open Rafael H. Schloming Rafael H. Schloming  
QPID-1063 C++ Broker   (QPID-1063) under Boost 103200, command line args with "=" didn't work Open Unassigned michael goulish  
QPID-1064 python tools M3 (QPID-1064) intermittent background thread stack trace when using qpid-config Open Rafael H. Schloming Rafael H. Schloming  
QPID-1065 C++ Broker M3 (QPID-1065) Management messages may lost if client attach hits a small time window Closed Unassigned Ted Ross  
QPID-1066 Java Broker M2, M2.1 (QPID-1066) cleanMainQueue call mistakenly wrapped in isInfoEnabled() Open Martin Ritchie Martin Ritchie  
Document generated by Confluence on May 26, 2010 10:32