ID |
Raised By |
Description |
Status |
Outcome |
1 |
RG |
Requirements 5,6,8,9 are design choices |
Done |
Moved to new section |
2 |
RG |
Requirement 10 is observation / scope limit |
Done |
Moved to new section |
3 |
RG |
Requirement 7 should be removed |
Done |
Removed |
4 |
RG |
Requirement 9 expand buffering of bytes before wire, writers are not synch it's about the contract. Similar to requirement 5 |
Done |
Folded into 5 |
5 |
MM |
Requirement 3 should be reworded since it's not exposing methods |
Done |
Reworded |
6 |
RG |
Explain configuration interface better later in documentation |
Done |
added text |
7 |
MM |
Document needs better flow requirements, current implemenation, new implemntation, dont' see how it all hangs together |
Done |
Current implementation removed, replaced with reference to current architecture page |
8 |
MM |
Doesn't highlight current problems |
Done |
Current architecture page talks about this in detail |
9 |
LB |
Link to reason why we're doing this work |
Done |
see point 7, 8 |
10 |
RG |
Previous / current design - move out and list w/explanation of what is wrong, link here and can then provide what is being done to address this. |
Done |
Added link to current design page |
11 |
RG |
Add link to old design parts |
Done |
added linke |
12 |
MM |
Not clear how docs link together. Hard to review, tick boxes w/out expected content defined |
Comment |
|
13 |
RG |
new implemntation needs to specify that protocol engine turns frames into bytes |
Done |
added text |
14 |
RG |
Move diagram / overview of approach top top before detailed discussion |
Done |
Moved |
15 |
RG |
Highlight that phase 1 is removing MINA leakage behind new interfaces and that's all |
Done |
Clarified in Port server to new interface |
16 |
MM |
Highlight now and phase 1, show MINA leakage |
Done |
see 15 |
17 |
RG |
Phaseing - interfaces, new decoders. Smaller parts better |
Done |
see Network IO page |
18 |
ALL |
new diagram - future state, phase 1 |
Done |
see Port server to new interface page |
19 |
MM |
Description does not tie with interfaces |
Done |
Amended |
20 |
RG |
Interfaces could do with class level doc, how it's used, what it does. Network driver extends sender, explain how it uses sender. ProtocolEngine is a reciever. ND is a sender |
Done |
added doc |
21 |
MM |
Hard to see links between sender/reciever and class |
Done |
made explicit that ND is a Sender, PE a Receiver |
22 |
RG |
Put more details about the abstract interfaces and the concrete classes later when we talk about this and refer back to interfaces |
Done |
see 21 |
23 |
MM |
ND clearer seperation between what is Sender and what is ND and that ND extends Sender |
Done |
see 21 |
24 |
MM |
Need state transition diagram to show data transfer |
Done |
see 25 |
25 |
RG |
Sequence diagram showing flow of control |
Done |
added diagram |
26 |
RG |
Detail to do with Job should move to impl doc |
Done |
removed Job info |
27 |
MM |
Exception handling on interfaces, open, bind, configuration |
Done |
added throws clauses |
28 |
RG |
Mention exception needs handled, throws OpenExcep/BindExcept. NOT AMQE. AMQE delenda est |
Done |
see 27 |
29 |
RG |
"New design" not new implementation |
Done |
changed title |
30 |
RG |
ProtocolEngine desc should mention that it also converts frames to bytes |
Done |
added to description |
31 |
RG |
NetworkDriverConfiguration needs to text to explain what is going with these details |
Done |
added text |
32 |
RG |
Reduce interface diagram to just who network driver / protocol engine |
Done |
added diagram |
33 |
MM |
Highlight difference with old |
Done |
added section detailing this |
34 |
RG/MR |
map ND -> MINA, Rest -> Decoder |
Done |
see 33 |
35 |
RG |
Highlight lack of MINA leakage |
Done |
see Port server to new interface |
36 |
RG |
Implementation details (AMQProtocolEngine_0_N) should be removed |
Done |
removed |