/[Apache-SVN]
ViewVC logotype

Revision 1817252

Jump to revision: Previous Next
Author: gwoolsey
Date: Wed Dec 6 00:15:51 2017 UTC (6 years, 4 months ago)
Changed paths: 11
Log Message: 
Bug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference

Found some optimizations in the general evaluation framework related to blank cells in rows beyond the last defined row of a sheet.

I don't see any issue with passing a bit of context down deeper into this framework, as it's all POI-internal and only had one calling path.

See the above bug for the performance analysis.  Not specifically related to VLOOKUP, but improves that case by more than 2/3 as well.

Changed paths

Path Details
Directorypoi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFEvaluationSheet.java modified , text changed
Directorypoi/trunk/src/java/org/apache/poi/ss/formula/CellEvaluationFrame.java modified , text changed
Directorypoi/trunk/src/java/org/apache/poi/ss/formula/EvaluationSheet.java modified , text changed
Directorypoi/trunk/src/java/org/apache/poi/ss/formula/EvaluationTracker.java modified , text changed
Directorypoi/trunk/src/java/org/apache/poi/ss/formula/FormulaUsedBlankCellSet.java modified , text changed
Directorypoi/trunk/src/java/org/apache/poi/ss/formula/WorkbookEvaluator.java modified , text changed
Directorypoi/trunk/src/java/org/apache/poi/ss/formula/eval/forked/ForkedEvaluationSheet.java modified , text changed
Directorypoi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFEvaluationSheet.java modified , text changed
Directorypoi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFEvaluationSheet.java modified , text changed
Directorypoi/trunk/src/ooxml/testcases/org/apache/poi/ss/formula/functions/TestVlookup.java added
Directorypoi/trunk/test-data/spreadsheet/VLookupFullColumn.xlsx added
infrastructure at apache.org
 ViewVC Help
Powered by ViewVC 1.1.26