/[Apache-SVN]
ViewVC logotype

Revision 1799643


Jump to revision: Previous Next
Author: gwoolsey
Date: Fri Jun 23 05:16:38 2017 UTC (7 years, 4 months ago)
Changed paths: 5
Log Message:
Bug 61203 - XSSFDrawing.getAnchorFromParent handles CTOneCellAnchor incorrectly, ignores CTAbsoluteAnchor

This is likely incomplete, but closer to where things should be.  It is backward compatible with previous uses of XSSFClientAnchor.

This fixes a bug in XSSFGraphicFrame that was hiding the parent class anchor property (which is a protected field set directly from XSSFDrawing).  This is a peril of using direct property access - the hiding wasn't obvious because there was no setter being overridden.

XSSFGraphicFrame now notices when it relates to a chart, and setts the frame property of the XSSFChart.  That was not being set on parse previously, only when creating charts from scratch.  That didn't seem right.

XSSFClientAnchor now calculates size and position correctly based on initial inputs from the different types of anchors.  It DOES NOT update those initial inputs, however.  It does properly adjust if the size or initial position are absolute and the corresponding row/column values are requested.

Added new class EMUUtils to centralize the measurement constants and conversions since there are so many units in play in the OOXML spec and POI APIs:

* EMUs (English Metric Units)
* Inches
* Centimeters
* Points
* Pixels
* Twips (1/20th of a point)

I'm sure there are more conversions that could be done there, I just started with what I needed.

Changed paths

Path Details
Directorypoi/trunk/src/java/org/apache/poi/ss/usermodel/ClientAnchor.java modified , text changed
Directorypoi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFClientAnchor.java modified , text changed
Directorypoi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDrawing.java modified , text changed
Directorypoi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFGraphicFrame.java modified , text changed
Directorypoi/trunk/src/ooxml/java/org/apache/poi/xssf/util/EMUUtils.java added

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26