/[Apache-SVN]
ViewVC logotype

Revision 1752779


Jump to revision: Previous Next
Author: centic
Date: Fri Jul 15 06:32:45 2016 UTC (7 years, 10 months ago)
Changed paths: 2
Log Message:
Function PROPER: Don't use a regular expression syntax that is not available on Android. Actually the use of regular expression in this case was overkill, slow and even incorrect in corner cases, the function can be done without regex easily and runs a bit faster anyway (microBench is down from 4sec to 2s)
Also added a unit-test to ensure the behavior stays the same (except in cases where it needed fixing, e.g. some toUppercase() leads to more than one character which was handled incorrectly)

Changed paths

Path Details
Directorypoi/trunk/src/java/org/apache/poi/ss/formula/functions/TextFunction.java modified , text changed
Directorypoi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestProper.java added

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26