/[Apache-SVN]
ViewVC logotype

Revision 1915593


Jump to revision: Previous Next
Author: jorton
Date: Tue Feb 6 08:33:52 2024 UTC (2 months, 3 weeks ago)
Changed paths: 1
Log Message:
* src/modules/perl/modperl_common_util.c (modperl_table_magic_copy):
  Use I32 rather than int for 'namelen' argument, fixing an
  incompatible function pointer error/warning in a 32-bit build:

modperl_common_util.c:57:53: error: initialization of ‘int (*)(PerlInterpreter *, SV *, MAGIC *, SV *, const char *, I32)’ {aka ‘int (*)(struct interpreter *, struct sv *, struct magic *, struct sv *, const char *, long int)’} from incompatible pointer type ‘int (*)(PerlInterpreter *, SV *, MAGIC *, SV *, const char *, int)’ {aka ‘int (*)(struct interpreter *, struct sv *, struct magic *, struct sv *, const char *, int)’} [-Wincompatible-pointer-types]
   57 |                                                     modperl_table_magic_copy};
      |                                                     ^~~~~~~~~~~~~~~~~~~~~~~~

Checked back to Perl 5.14.x which has I32 (a typedef of long int on
i686) rather than int in the prototype for the svt_copy function
pointer in MGVTBL, so I32 appears to have been always correct here:

int  (*svt_copy)(SV *sv, MAGIC* mg, SV *nsv, const char *name, I32 namlen);

per https://perldoc.perl.org/5.14.0/perlguts


Changed paths

Path Details
Directoryperl/modperl/trunk/src/modules/perl/modperl_common_util.c modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26