/[Apache-SVN]
ViewVC logotype

Revision 1865449


Jump to revision: Previous Next
Author: stevehay
Date: Mon Aug 19 12:29:37 2019 UTC (4 years, 8 months ago)
Changed paths: 6
Log Message:
Avoid use of FINFO_NORM where possible; if not possible then switch off the FINFO_PROT bits on Windows

Some Windows set-ups have problems using apr_stat()'s FINFO_NORM mode: see https://bz.apache.org/bugzilla/show_bug.cgi?id=51560 and the dev@apr.apache.org thread cited in Comment 4 on that bug.

The problem revolves around the information requested by the APR_FINFO_GPROT and APR_FINFO_WPROT bits. We don't appear to need that information in what we're doing, so the simplest workaround is to turn off those bits (and the APR_FINFO_UPROT bit) in what we're requesting -- but only on WIN32, to minimize regression risk.

In some places we clearly only need a tiny subset of what FINFO_NORM gives us anyway, and switching to FINFO_MIN etc instead is even easier (and hopefully risk-free).

Changed paths

Path Details
Directoryperl/modperl/trunk/ModPerl-Registry/lib/ModPerl/RegistryLoader.pm modified , text changed
Directoryperl/modperl/trunk/lib/Apache2/compat.pm modified , text changed
Directoryperl/modperl/trunk/t/lib/TestAPRlib/finfo.pm modified , text changed
Directoryperl/modperl/trunk/t/response/TestAPI/request_rec.pm modified , text changed
Directoryperl/modperl/trunk/t/response/TestAPR/finfo.pm modified , text changed
Directoryperl/modperl/trunk/xs/Apache2/RequestIO/Apache2__RequestIO.h modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26