The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is
Effort is min
Files
org.apache.oodt.cas.curation.policymgr.CurationPolicyManager
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.oodt.cas.curation.policymgr.CurationPolicyManager.typesToList(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 91 | Medium |
org.apache.oodt.cas.curation.service.CurationService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.curation.service.CurationService.config should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 70 | Medium |
| Class org.apache.oodt.cas.curation.service.CurationService defines non-transient non-serializable instance field sso | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Write to static field org.apache.oodt.cas.curation.service.CurationService.config from instance method org.apache.oodt.cas.curation.service.CurationService.init(ServletConfig) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 89 | Medium |
org.apache.oodt.cas.curation.service.IngestionResource
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.oodt.cas.curation.service.IngestionResource defines non-transient non-serializable instance field taskList | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class org.apache.oodt.cas.curation.service.IngestionResource defines non-transient non-serializable instance field uriInfo | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
org.apache.oodt.cas.curation.service.IngestionResource$IngestionTaskList
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.oodt.cas.curation.service.IngestionResource$IngestionTaskList be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 310-348 | Medium |
org.apache.oodt.cas.curation.service.MetadataResource
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to metadata in org.apache.oodt.cas.curation.service.MetadataResource.updateMetadata(MultivaluedMap, String, String, boolean, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 517 | Medium |
| org.apache.oodt.cas.curation.service.MetadataResource.updateCatalogMetadata(Product, Metadata) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 589 | Medium |
| org.apache.oodt.cas.curation.service.MetadataResource.getStagingMetadata(String, String, Boolean) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 213 | Medium |
| Class org.apache.oodt.cas.curation.service.MetadataResource defines non-transient non-serializable instance field catalog | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Method org.apache.oodt.cas.curation.service.MetadataResource.getMetadataFromMap(MultivaluedMap) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 383 | Medium |
org.apache.oodt.cas.curation.servlet.DirectoryListingServlet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.oodt.cas.curation.servlet.DirectoryListingServlet.basePath | CORRECTNESS | UWF_UNWRITTEN_FIELD | 81 | Medium |
org.apache.oodt.cas.curation.servlet.MetViewerServlet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.oodt.cas.curation.servlet.MetViewerServlet.basePath | CORRECTNESS | UWF_UNWRITTEN_FIELD | 79 | Medium |
org.apache.oodt.cas.curation.servlet.SSOConfiguredCuratorWebService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.oodt.cas.curation.servlet.SSOConfiguredCuratorWebService defines non-transient non-serializable instance field sso | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
org.apache.oodt.cas.curation.servlet.UpdateDatasetMetaDataServlet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to action in org.apache.oodt.cas.curation.servlet.UpdateDatasetMetaDataServlet.doPost(HttpServletRequest, HttpServletResponse) | STYLE | DLS_DEAD_LOCAL_STORE | 95 | Medium |
| Dead store to session in org.apache.oodt.cas.curation.servlet.UpdateDatasetMetaDataServlet.doPost(HttpServletRequest, HttpServletResponse) | STYLE | DLS_DEAD_LOCAL_STORE | 92 | Medium |
| HTTP parameter directly written to HTTP header output in org.apache.oodt.cas.curation.servlet.UpdateDatasetMetaDataServlet.doPost(HttpServletRequest, HttpServletResponse) | SECURITY | HRS_REQUEST_PARAMETER_TO_HTTP_HEADER | 96 | Medium |
| Class org.apache.oodt.cas.curation.servlet.UpdateDatasetMetaDataServlet defines non-transient non-serializable instance field fm | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
org.apache.oodt.cas.curation.servlet.UploadDatasetDefinitionServlet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.oodt.cas.curation.servlet.UploadDatasetDefinitionServlet defines non-transient non-serializable instance field fm | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
org.apache.oodt.cas.curation.structs.IngestionTask
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.curation.structs.IngestionTask.getCreateDate() may expose internal representation by returning IngestionTask.createDate | MALICIOUS_CODE | EI_EXPOSE_REP | 82 | Medium |
| org.apache.oodt.cas.curation.structs.IngestionTask.setCreateDate(Date) may expose internal representation by storing an externally mutable object into IngestionTask.createDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 90 | Medium |
org.apache.oodt.cas.curation.util.CurationXmlStructFactory
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.apache.oodt.cas.curation.util.CurationXmlStructFactory.augmentElement(List, Element, Document) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 88 | Medium |
org.apache.oodt.cas.curation.util.DateUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.curation.util.DateUtils.ISO8601FORMAT isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 40 | High |
| org.apache.oodt.cas.curation.util.DateUtils.RFC822DATEFORMAT isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 43 | High |
org.apache.oodt.cas.curation.util.ExtractorConfigReader
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.curation.util.ExtractorConfigReader.readFromDirectory(File, String) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 37 | Medium |
org.apache.oodt.cas.curation.util.ExtractorConfigWriter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.curation.util.ExtractorConfigWriter.saveToDirectory(ExtractorConfig, File) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 46 | Medium |
| org.apache.oodt.cas.curation.util.ExtractorConfigWriter.saveToDirectory(ExtractorConfig, File) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 37 | Medium |