/[Apache-SVN]
ViewVC logotype

Revision 1564111


Jump to revision: Previous Next
Author: jleroux
Date: Mon Feb 3 22:29:40 2014 UTC (10 years, 3 months ago)
Changed paths: 1
Log Message:
A (slightly modified) patch from  Ritu Raj Lakhera for "Order return is not refunding the money" https://issues.apache.org/jira/browse/OFBIZ-5528

When we placed an order with two items and generate a return towards one item then code is refunding the money correctly.
But if we again do return for second item then code is not refunding the money because first return-refund process has changed the status of OrderPaymentPreference from 'PAYMENT_SETTLED' to ‘PAYMENT_REFUNDED’.
I think We should create the new OrderPaymentPreference with PAYMENT_REFUNDED status against old OrderPaymentPreference of 'PAYMENT_SETTLED' status at the time of return-refund process. So second return can also refund the money.

In other words we should create the new OrderPaymentPreference for each refund amount as we are doing with Payment entity(processRefundResult PaymentGatewayServices.java).

jleroux: I 
* replaced the deprecated findByPrimaryKey by a finByOne
* replaced Exception GenericServiceException in catch (as it was before)
* reformatted some parts 

Changed paths

Path Details
Directoryofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReturnServices.java modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26