/[Apache-SVN]
ViewVC logotype

Revision 1536324


Jump to revision: Previous Next
Author: jleroux
Date: Mon Oct 28 12:12:43 2013 UTC (10 years, 5 months ago)
Changed paths: 18
Log Message:
Fixes <<Services allow arbitrary HTML for parameters with allow-html set to "safe">> https://issues.apache.org/jira/browse/OFBIZ-5254

After r751990, <<allow-html="any">> and <<allow-html="safe">> are the same: they do nothing! The only difference is the warning message from the OWASP Antisamy IntrusionDetector, which is both, as Christoph noted "giving you a false sense of security" or as I wrote "disturbing, wrong and useless". So there are no longer any reasons for differencing "safe" and "any".

This
* Deprecates "safe" (making it clear in the XSD documentation), keeping only "none" and "any". This is for backward compatibility, else we could completely remove the misleading "safe". Note that "none" is the default.
* Replaces in services definition all allow-html="safe" by allow-html="any"
* Remove from ModelService.java (near line 587) the code which throws the OWASP Antisamy IntrusionDetector message in log

Changed paths

Path Details
Directoryofbiz/trunk/applications/accounting/servicedef/services_agreement.xml modified , text changed
Directoryofbiz/trunk/applications/accounting/servicedef/services_invoice.xml modified , text changed
Directoryofbiz/trunk/applications/content/servicedef/services.xml modified , text changed
Directoryofbiz/trunk/applications/content/servicedef/services_content.xml modified , text changed
Directoryofbiz/trunk/applications/content/servicedef/services_data.xml modified , text changed
Directoryofbiz/trunk/applications/marketing/servicedef/services_opportunity.xml modified , text changed
Directoryofbiz/trunk/applications/order/servicedef/services.xml modified , text changed
Directoryofbiz/trunk/applications/order/servicedef/services_quote.xml modified , text changed
Directoryofbiz/trunk/applications/order/servicedef/services_request.xml modified , text changed
Directoryofbiz/trunk/applications/party/servicedef/services.xml modified , text changed
Directoryofbiz/trunk/applications/product/servicedef/services.xml modified , text changed
Directoryofbiz/trunk/applications/product/servicedef/services_pricepromo.xml modified , text changed
Directoryofbiz/trunk/applications/workeffort/servicedef/services.xml modified , text changed
Directoryofbiz/trunk/framework/common/servicedef/services.xml modified , text changed
Directoryofbiz/trunk/framework/common/servicedef/services_email.xml modified , text changed
Directoryofbiz/trunk/framework/service/dtd/services.xsd modified , text changed
Directoryofbiz/trunk/framework/service/src/org/ofbiz/service/ModelService.java modified , text changed
Directoryofbiz/trunk/specialpurpose/ebaystore/servicedef/services.xml modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26