/[Apache-SVN]
ViewVC logotype

Revision 1042348


Jump to revision: Previous Next
Author: jleroux
Date: Sun Dec 5 13:37:07 2010 UTC (13 years, 4 months ago)
Changed paths: 1
Log Message:
A patch from Anne Jessel "Collapse all broken if hyperlink in pane" (https://issues.apache.org/jira/browse/OFBIZ-4022) - OFBIZ-4022

To reproduce the bug:
    * edit the EditProduct form in applications/product/widget/catalog/ProductForms.xml
    * add a new field with a hyperlink sub-element.
    * refer to this new field in the first, non-collapsible field-group in the sort-order
    * go to this page in the UI (edit a product in the catalog)
    * the Expand All and Collapse All buttons do not work properly

The problem is caused by the javascript finding the added hyperlink field in the first field-group, and incorrectly assuming it is
the expand/collapse link for the field-group. This causes the javascript to crash when it gets a null reference to an enclosing li element.

It is not specific to the EditProduct form, but applies to any group of collapsible panes where one contains a hyperlink.

The attached patch simply checks that the li element actually exists.

Changed paths

Path Details
Directoryofbiz/trunk/framework/images/webapp/images/selectall.js modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26