/[Apache-SVN]
ViewVC logotype

Revision 741374


Jump to revision: Previous Next
Author: jonesde
Date: Fri Feb 6 02:14:19 2009 UTC (15 years, 2 months ago)
Changed paths: 23
Log Message:
A few related changes: 

Big refactor of ControlServlet, RequestManager, RequestHandler, and ConfigXMLReader so that simple objects are used instead of Maps within Maps within Maps for the data from the controller.xml file, which results in eliminating hundreds of lines of code including the entire RequestHandler class. I have tested this a lot with different apps that use the ControlServlet differently, but this is a very big change so there could still be issues. Based on this cleanup future issues and new features should be easier and less error prone, and that is why doing it now in order to help with a number of other improvements and bug fixes that are part of this commit.

Also added redirect-parameter element to go under the request-map -> response element which allows you to specify which parameters will be passed on in a redirect instead of using all of them. Also improved default there and in various places to only include parameters from the URL to avoid issues with form data, but if the ID to display (like following a crAlso added redirect-parameter element to go under the request-map -> response element which allows you to specify which parameters will be passed on in a redirect instead of using all of them. Also improved default there and in various places to only include parameters from the URL to avoid issues with form data, but if the ID to display (like following a crAlso added redirect-parameter element to go under the request-map -> response element which allows you to specify which parameters will be passed on in a redirect instead of using all of them. Also improved default there and in various places to only include parameters from the URL to avoid issues wd in and also going to the same page after login from auth=true or from clicking on the login link.

Related to cleaning up login URLs also changed how the request and parameters passed to a request before a login are saved and used after a login is successful so that it URL parameters go on the URL in a redirect to the original request to make it more transparent, and non-URL parameters just stay in the session and are used when the original request is run again to avoid putting sensitive information like passwords and big information like textarea data in the URL, which has been a problem before.

To see what some of these things combined can do try going to the example app, login, click on the New Example link, then logout in another tab or window, then go back to the New Example page and enter a name and a whole bunch of text in the long description then click Create, the system will show you the login page so enter username/password, and then after login you'll see a nice URL to EditExample with the correct exampleId parameter and all of the data entered before login successfully saved and never appearing in a URL.


Changed paths

Path Details
Directoryofbiz/trunk/applications/ecommerce/webapp/ecommerce/login.ftl modified , text changed
Directoryofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java modified , text changed
Directoryofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java modified , text changed
Directoryofbiz/trunk/framework/common/webcommon/WEB-INF/common-controller.xml modified , text changed
Directoryofbiz/trunk/framework/common/webcommon/includes/header.ftl modified , text changed
Directoryofbiz/trunk/framework/common/webcommon/login.ftl modified , text changed
Directoryofbiz/trunk/framework/example/webapp/example/WEB-INF/controller.xml modified , text changed
Directoryofbiz/trunk/framework/webapp/dtd/site-conf.xsd modified , text changed
Directoryofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java modified , text changed
Directoryofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java modified , text changed
Directoryofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modified , text changed
Directoryofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/RequestManager.java deleted
Directoryofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/CoreEvents.java modified , text changed
Directoryofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/EventFactory.java modified , text changed
Directoryofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/SOAPEventHandler.java modified , text changed
Directoryofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/ServiceMultiEventHandler.java modified , text changed
Directoryofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/view/ViewFactory.java modified , text changed
Directoryofbiz/trunk/framework/webtools/src/org/ofbiz/webtools/artifactinfo/ArtifactInfoFactory.java modified , text changed
Directoryofbiz/trunk/framework/webtools/src/org/ofbiz/webtools/artifactinfo/ControllerRequestArtifactInfo.java modified , text changed
Directoryofbiz/trunk/framework/webtools/src/org/ofbiz/webtools/artifactinfo/ControllerViewArtifactInfo.java modified , text changed
Directoryofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ScreenRenderer.java modified , text changed
Directoryofbiz/trunk/specialpurpose/hhfacility/webapp/hhfacility/login.ftl modified , text changed
Directoryofbiz/trunk/specialpurpose/myportal/widget/login.ftl modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26