/[Apache-SVN]
ViewVC logotype

Revision 1655803


Jump to revision: Previous Next
Author: jleroux
Date: Thu Jan 29 19:06:49 2015 UTC (9 years, 2 months ago)
Changed paths: 30
Log Message:
This implements OFBIZ-5312 "Proposal: URL-Generation Changes (mostly for SEO reasons but not only)" by merging the "SEO branch" in trunk

After some efforts to take into consideration Anil's justified concerns (simply put: keep the current behaviour), the modifications are finally light, which is greater for reviews. Most important are:
* Product component
  ** I have moved the OfbizCatalogAltUrlTransform and OfbizCatalogUrlTransform classes to a ftl subdirectory with the new FTL macros implementation: CatalogAltUrlSeoTransform, CatalogUrlSeoFilter, CatalogAltUrlSeoTransform, CatalogUrlSeoTransform, SeoTransform, UrlRegexpTransform
  ** A bunch of new filters have been added CatalogUrlSeoFilter, controlServlet, SeoCatalogUrlServlet, SeoContentUrlFilter, SeoContextFilter, SeoControlServlet, UrlRegexpContextFilter
  ** 2 util classes: SeoConfigUtil, SeoUrlUtil
  ** By default ofbizCatalogAltUrl and ofbizCatalogUrl macros now use the new implementations by CatalogAltUrlSeoTransform and CatalogUrlSeoTransform. This can be changed back in freemarkerTransforms.properties
  ** A SeoConfig.xml file define some SEO parameters, the SeoConfig.xsd can be sued as documentation, globally please refer to OFBIZ-5312.
* Framework webapp component
  ** By default ofbizUrl macro now uses the new implementations by UrlRegexpTransform. This can be changed back in freemarkerTransforms.properties
* Ecommerce component
  ** A new ecomseo webapp clones the ecommerce webapp on the model of ecomclone. There is not much there: mostly a controller with a new JspViewHandler class (in ecommerce) and a web.xml file

With these changes we can have both worlds running side by side. So you can use eitherb http://localhost:8080/ecommerce/control/main as root or http://localhost:8080/ecomseo, but also if you want http://localhost:8080/ecommerce/. Then everything follows.

From my reviews and tests all is working as expected. I only found a trivial bug that I can also reproduce in current trunk see OFBIZ-5305 (sometimes not locally, weird).

Of course, all the tests passes. 


Changed paths

Path Details
Directoryofbiz/trunk/ modified , props changed
Directoryofbiz/trunk/applications/product/build.xml modified , text changed
Directoryofbiz/trunk/applications/product/config/SeoConfig.xml
(Copied from ofbiz/branches/OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23/applications/product/config/SeoConfig.xml, r1654698)
added , text changed
Directoryofbiz/trunk/applications/product/config/freemarkerTransforms.properties modified , text changed
Directoryofbiz/trunk/applications/product/dtd/
(Copied from ofbiz/branches/OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23/applications/product/dtd, r1654698)
added
Directoryofbiz/trunk/applications/product/src/org/ofbiz/product/category/CatalogUrlSeoFilter.java
(Copied from ofbiz/branches/OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23/applications/product/src/org/ofbiz/product/category/CatalogUrlSeoFilter.java, r1654698)
added
Directoryofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryServices.java modified , text changed
Directoryofbiz/trunk/applications/product/src/org/ofbiz/product/category/ControlServlet.java
(Copied from ofbiz/branches/OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23/applications/product/src/org/ofbiz/product/category/ControlServlet.java, r1654698)
added
Directoryofbiz/trunk/applications/product/src/org/ofbiz/product/category/OfbizCatalogAltUrlTransform.java deleted
Directoryofbiz/trunk/applications/product/src/org/ofbiz/product/category/OfbizCatalogUrlTransform.java deleted
Directoryofbiz/trunk/applications/product/src/org/ofbiz/product/category/SeoCatalogUrlServlet.java
(Copied from ofbiz/branches/OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23/applications/product/src/org/ofbiz/product/category/SeoCatalogUrlServlet.java, r1654698)
added
Directoryofbiz/trunk/applications/product/src/org/ofbiz/product/category/SeoConfigUtil.java
(Copied from ofbiz/branches/OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23/applications/product/src/org/ofbiz/product/category/SeoConfigUtil.java, r1654698)
added
Directoryofbiz/trunk/applications/product/src/org/ofbiz/product/category/SeoContentUrlFilter.java
(Copied from ofbiz/branches/OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23/applications/product/src/org/ofbiz/product/category/SeoContentUrlFilter.java, r1654698)
added , text changed
Directoryofbiz/trunk/applications/product/src/org/ofbiz/product/category/SeoContextFilter.java
(Copied from ofbiz/branches/OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23/applications/product/src/org/ofbiz/product/category/SeoContextFilter.java, r1654698)
added
Directoryofbiz/trunk/applications/product/src/org/ofbiz/product/category/SeoControlServlet.java
(Copied from ofbiz/branches/OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23/applications/product/src/org/ofbiz/product/category/SeoControlServlet.java, r1654698)
added
Directoryofbiz/trunk/applications/product/src/org/ofbiz/product/category/SeoUrlUtil.java
(Copied from ofbiz/branches/OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23/applications/product/src/org/ofbiz/product/category/SeoUrlUtil.java, r1654698)
added
Directoryofbiz/trunk/applications/product/src/org/ofbiz/product/category/UrlRegexpContextFilter.java
(Copied from ofbiz/branches/OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23/applications/product/src/org/ofbiz/product/category/UrlRegexpContextFilter.java, r1654698)
added
Directoryofbiz/trunk/applications/product/src/org/ofbiz/product/category/ftl/
(Copied from ofbiz/branches/OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23/applications/product/src/org/ofbiz/product/category/ftl, r1654698)
added
Directoryofbiz/trunk/applications/product/src/org/ofbiz/product/category/ftl/OfbizCatalogAltUrlTransform.java modified , text changed
Directoryofbiz/trunk/framework/webapp/config/freemarkerTransforms.properties modified , text changed
Directoryofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/WebAppUtil.java modified , text changed
Directoryofbiz/trunk/specialpurpose/ecommerce/ofbiz-component.xml modified , text changed
Directoryofbiz/trunk/specialpurpose/ecommerce/src/org/ofbiz/ecommerce/webapp/
(Copied from ofbiz/branches/OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23/specialpurpose/ecommerce/src/org/ofbiz/ecommerce/webapp, r1654698)
added
Directoryofbiz/trunk/specialpurpose/ecommerce/webapp/ecomseo/ added
Directoryofbiz/trunk/specialpurpose/ecommerce/webapp/ecomseo/WEB-INF/ added
Directoryofbiz/trunk/specialpurpose/ecommerce/webapp/ecomseo/WEB-INF/controller.xml added
Directoryofbiz/trunk/specialpurpose/ecommerce/webapp/ecomseo/WEB-INF/web.xml added
Directoryofbiz/trunk/specialpurpose/ecommerce/webapp/ecomseo/error/ added
Directoryofbiz/trunk/specialpurpose/ecommerce/webapp/ecomseo/error/error.jsp added
Directoryofbiz/trunk/specialpurpose/ecommerce/webapp/ecomseo/index.jsp added

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26