Log Message: |
Improved: Avoid confusing indirections in ‘StartupControlPanel#start’
(OFBIZ-11137)
The ‘StartupControlPanel#start’ method is delegating its job to
smaller private methods to improve readability. However the
conditionnals were previously hidden inside those methods with the
unfortunate consequence of making case analysis hard.
To avoid this undesirable effect, the conditionals has been moved
inside the ‘StartupControlPanel#start’ method and some delegate
methods has been inlined when their implementation was trivial. The
parameters of the remaining delegate methods has be refined to avoid
passing around unneeded things.
|