/[Apache-SVN]
ViewVC logotype

Revision 1860051


Jump to revision: Previous Next
Author: jleroux
Date: Sun May 26 10:36:16 2019 UTC (4 years, 10 months ago)
Changed paths: 39
Log Message:
Improved: Use Groovy Truth instead of UtilValidate Class in Groovy
(OFBIZ-11064)

As we all know, Groovy is a powerful language with great built-in functions. 
Groovy Truth[1] is one of them, which is not used properly in our code base. 
We have used UtilValidate Class to validate arguments for Empty or NotEmpty, 
which can easily be done in groovy with built-in functionality[1].
 
Current Code: if (UtilValidate.isNotEmpty(locations)) { ... }
Groovy Built-in Code: if (locations) { ... }
 
[1] - http://groovy-lang.org/semantics.html#Groovy-Truth
 
We need to careful for some points while we change this:
Like:
maxRetry = 0
if (!maxRetry)
{  // Not set, use a default  maxRetry = -1 }

Because groovy evaluates zero to be false, it wouldn't be possible to set
maxRetry to zero.  So it's best not to use groovy truth for null-checks on
numbers in some cases. 
 
Thanks: Pawan Verma

Changed paths

Path Details
Directoryofbiz/ofbiz-framework/trunk/applications/accounting/groovyScripts/ar/BatchPayments.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/accounting/groovyScripts/payment/DepositWithdrawPayments.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/accounting/groovyScripts/reports/GlAccountTrialBalance.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/commonext/groovyScripts/ofbizsetup/GetProdCatalog.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/manufacturing/groovyScripts/jobshopmgt/ShowProductionRun.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/order/groovyScripts/entry/AddGiftCertificates.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/order/groovyScripts/entry/ShipSettings.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/order/groovyScripts/entry/catalog/CategoryDetail.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/order/groovyScripts/entry/catalog/ProductDetail.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/order/groovyScripts/lookup/LookupAssociatedProducts.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/order/groovyScripts/order/OrderView.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/party/groovyScripts/party/PartyGeoLocation.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/product/groovyScripts/catalog/PrepareCreateShipMeth.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/product/groovyScripts/catalog/category/EditCategoryContentContent.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/product/groovyScripts/catalog/imagemanagement/ImageFrame.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/product/groovyScripts/catalog/product/EditProductAssoc.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/product/groovyScripts/facility/facility/FacilityLocationGeoLocation.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/product/groovyScripts/facility/inventory/InventoryAverageCosts.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/workeffort/groovyScripts/workeffort/calendar/Days.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/workeffort/groovyScripts/workeffort/calendar/Month.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/applications/workeffort/groovyScripts/workeffort/calendar/Week.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/artifactinfo/ComponentList.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/entity/FindGeneric.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/entity/ProgramExport.groovy modified , text changed
Directoryofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/entity/ViewGeneric.groovy modified , text changed
Directoryofbiz/ofbiz-plugins/trunk/birt/groovyScripts/order/CheckReportBy.groovy modified , text changed
Directoryofbiz/ofbiz-plugins/trunk/ecommerce/groovyScripts/catalog/AjaxBreadcrumbs.groovy modified , text changed
Directoryofbiz/ofbiz-plugins/trunk/ecommerce/groovyScripts/catalog/BestSellingCategory.groovy modified , text changed
Directoryofbiz/ofbiz-plugins/trunk/ecommerce/groovyScripts/catalog/PopularTags.groovy modified , text changed
Directoryofbiz/ofbiz-plugins/trunk/ecommerce/groovyScripts/order/OrderStatus.groovy modified , text changed
Directoryofbiz/ofbiz-plugins/trunk/ecommerce/webapp/ecommerce/images/ecommain.css modified , text changed
Directoryofbiz/ofbiz-plugins/trunk/multiflex/webapp/multiflex/style.css modified , text changed
Directoryofbiz/ofbiz-plugins/trunk/projectmgr/groovyScripts/GanttChart.groovy modified , text changed
Directoryofbiz/ofbiz-plugins/trunk/projectmgr/groovyScripts/GetProjectId.groovy modified , text changed
Directoryofbiz/ofbiz-plugins/trunk/scrum/groovyScripts/FindProductBacklogItem.groovy modified , text changed
Directoryofbiz/ofbiz-plugins/trunk/scrum/groovyScripts/ListCurrentProducts.groovy modified , text changed
Directoryofbiz/ofbiz-plugins/trunk/scrum/groovyScripts/ProductEmail.groovy modified , text changed
Directoryofbiz/ofbiz-plugins/trunk/webpos/groovyScripts/cart/ShowCart.groovy modified , text changed
Directoryofbiz/ofbiz-plugins/trunk/webpos/groovyScripts/search/CustomerAddress.groovy modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26