/[Apache-SVN]
ViewVC logotype

Revision 1814292


Jump to revision: Previous Next
Author: jleroux
Date: Sat Nov 4 14:06:56 2017 UTC (6 years, 6 months ago)
Changed paths: 4
Log Message:
Improved: Replace Inline Javascript with External Javascript 
(OFBIZ-9465)

As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m 
inline javascript for various macros like renderLookupField, makeHyperlinkString,
shortDateInput etc in HtmlFormMacroLibrary.ftl should be replaced with a generic 
code written as external javascript. Generic Javascript code should be written 
in OfbizUtil.js and appropriate classes or identifiers should be used for 
applying that. Any additional data can be passed with HTML 5 custom data attribute 
(https://www.w3.org/TR/2011/WD-html5-20110525/elements.html
#embedding-custom-non-visible-data-with-the-data-attributes).


Deepak: I think we can use data-mask attribute to recognize the element instead 
of adding class. 

jeloux: I noticed a MaskFieldExampleForm was introduced with r1804027 but
not used in FormWidgetExampleScreens.xml so was not visible


Thanks: Aditya and Deepak


Changed paths

Path Details
Directoryofbiz/ofbiz-framework/trunk/framework/security/config/security.properties modified , text changed
Directoryofbiz/ofbiz-framework/trunk/themes/common/template/macro/HtmlFormMacroLibrary.ftl modified , text changed
Directoryofbiz/ofbiz-framework/trunk/themes/common/webapp/common/js/util/OfbizUtil.js modified , text changed
Directoryofbiz/ofbiz-framework/trunk/themes/common/widget/Theme.xml modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26