Revision 1187935

"Applied fix from trunk for revision: 1187933" 
------------------------------------------------------------------------
r1187933 | jleroux | 2011-10-23 19:05:59 +0200 (dim., 23 oct. 2011) | 10 lines

A patch from Kiran Gawde "Warnings while approving the purchase order" https://issues.apache.org/jira/browse/OFBIZ-4495

Following warnings were noticed in the log while approving the purchase order that was created automatically for drop ship product.

[ OrderServices.java:2389:WARN ] Tried to setOrderStatus with the same statusId [ ORDER_APPROVED ] for order with ID
[ServiceEcaCondition.java:156:WARN ] From Field (orderTypeId) is not found in context for changeOrderStatus, defaulting to null.

The first warning suggest that there is order status is changed again. Shouldn't have happened. The order header should be updated before updating the order items.
The second warning happens because some time, changeOrderStatus returns without adding orderTypeId to success result. Since there are secas rules based upon this field, the field should be mandatory and not optional.

------------------------------------------------------------------------