The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is low
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.custom.dynaForm.component.dynaForm.DynaConfig.getDisabled() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 114 | Medium |
| org.apache.myfaces.custom.dynaForm.component.dynaForm.DynaConfig.getDisplayOnly() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 76 | Medium |
| org.apache.myfaces.custom.dynaForm.component.dynaForm.DynaConfig.getReadOnly() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 95 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.custom.dynaForm.component.dynaForm.DynaForm in org.apache.myfaces.custom.dynaForm.component.dynaForm.DynaFormRenderer.encodeBegin(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 125 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.custom.dynaForm.component.dynaForm.DynaFormRenderer$AddComponentToTable be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 51-86 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Slipstream.guiBuilder not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
| Slipstream.modelMetaData not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.apache.myfaces.custom.dynaForm.guiBuilder.impl.jsf.JsfGuiBuilder.createNative(FieldInterface), since all javax.faces.component.UIComponent are instances of javax.faces.component.UIComponent | STYLE | BC_VACUOUS_INSTANCEOF | 264 | Medium |
| Redundant nullcheck of vld which is known to be null in org.apache.myfaces.custom.dynaForm.guiBuilder.impl.jsf.JsfGuiBuilder.attachLengthValidator(HtmlInputText, int, int) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 1000 | Low |
| Redundant nullcheck of vld which is known to be null in org.apache.myfaces.custom.dynaForm.guiBuilder.impl.jsf.JsfGuiBuilder.attachRangeValidator(HtmlInputText, Double, Double) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 974 | Low |
| Switch statement found in org.apache.myfaces.custom.dynaForm.guiBuilder.impl.jsf.JsfGuiBuilder.doCreateDateConverter(FieldInterface) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 437-438 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.custom.dynaForm.lib.DefaultValueMap defines non-transient non-serializable instance field original | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.custom.dynaForm.lib.NullObject defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 34 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Call to equals() comparing different types in org.apache.myfaces.custom.dynaForm.lib.ObjectSerializationConverter.getAsObject(FacesContext, UIComponent, String) | CORRECTNESS | EC_UNRELATED_TYPES | 48 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.custom.dynaForm.metadata.MetaData$FieldImpl.getAllowedSelections() may expose internal representation by returning MetaData$FieldImpl.allowedSelection | MALICIOUS_CODE | EI_EXPOSE_REP | 200 | Medium |
| org.apache.myfaces.custom.dynaForm.metadata.MetaData$FieldImpl.setAllowedSelections(Selection[]) may expose internal representation by storing an externally mutable object into MetaData$FieldImpl.allowedSelection | MALICIOUS_CODE | EI_EXPOSE_REP2 | 205 | Medium |
| Class org.apache.myfaces.custom.dynaForm.metadata.MetaData$FieldImpl defines non-transient non-serializable instance field wantedComponent | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| org.apache.myfaces.custom.dynaForm.metadata.MetaData$FieldImpl is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 61-376 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.custom.dynaForm.metadata.Selection is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36-55 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.custom.dynaForm.metadata.impl.ejb.EjbExtractor.determineAccessByField(Class) has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 269 | Medium |
