The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is low
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.custom.accordion.AbstractHtmlAccordionPanel.getChildExpanded() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 166 | Medium |
| org.apache.myfaces.custom.accordion.AbstractHtmlAccordionPanel.ACCORDION_LAYOUT isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 46 | High |
| org.apache.myfaces.custom.accordion.AbstractHtmlAccordionPanel.BORDER_COLOR isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 57 | High |
| org.apache.myfaces.custom.accordion.AbstractHtmlAccordionPanel.COLLAPSED_BACK_COLOR isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 52 | High |
| org.apache.myfaces.custom.accordion.AbstractHtmlAccordionPanel.COLLAPSED_FONT_WEIGHT isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 54 | High |
| org.apache.myfaces.custom.accordion.AbstractHtmlAccordionPanel.COLLAPSED_TEXT_COLOR isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 53 | High |
| org.apache.myfaces.custom.accordion.AbstractHtmlAccordionPanel.EXPANDED_BACK_COLOR isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 49 | High |
| org.apache.myfaces.custom.accordion.AbstractHtmlAccordionPanel.EXPANDED_FONT_WEIGHT isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 51 | High |
| org.apache.myfaces.custom.accordion.AbstractHtmlAccordionPanel.EXPANDED_TEXT_COLOR isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 50 | High |
| org.apache.myfaces.custom.accordion.AbstractHtmlAccordionPanel.EXPAND_STATEHOLDER_ID isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 59 | High |
| org.apache.myfaces.custom.accordion.AbstractHtmlAccordionPanel.HOVER_BACK_COLOR isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 55 | High |
| org.apache.myfaces.custom.accordion.AbstractHtmlAccordionPanel.HOVER_TEXT_COLOR isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 56 | High |
| org.apache.myfaces.custom.accordion.AbstractHtmlAccordionPanel.TOGGLING_LAYOUT isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 47 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.custom.accordion.HtmlAccordionPanel in org.apache.myfaces.custom.accordion.HtmlAccordionPanelRenderer.decode(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 202 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.custom.accordion.HtmlAccordionPanel in org.apache.myfaces.custom.accordion.HtmlAccordionPanelRenderer.encodeEnd(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 67 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.accordion.HtmlAccordionPanelTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 118 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.apache.myfaces.custom.ajax.api.AjaxDecodePhaseListener.encodeAjax(UIComponent, FacesContext), since all org.apache.myfaces.custom.ajax.api.DeprecatedAjaxComponent are instances of org.apache.myfaces.custom.ajax.api.AjaxComponent | STYLE | BC_VACUOUS_INSTANCEOF | 240 | Medium |
| Dead store to ajaxComponent in org.apache.myfaces.custom.ajax.api.AjaxDecodePhaseListener.beforePhase(PhaseEvent) | STYLE | DLS_DEAD_LOCAL_STORE | 88 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.custom.ajax.util.AjaxRendererUtils.encodeAjax(FacesContext, UIComponent, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 255 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.custom.autoupdatedatatable.AutoUpdateDataTable in org.apache.myfaces.custom.autoupdatedatatable.AutoUpdateDataTableRenderer.encodeEnd(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 101 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.autoupdatedatatable.AutoUpdateDataTableTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 76 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.custom.clientvalidation.common.CVCall.getValidatorScriptFunctions() may expose internal representation by returning CVCall._validatorScriptFunctions | MALICIOUS_CODE | EI_EXPOSE_REP | 84 | Medium |
| org.apache.myfaces.custom.clientvalidation.common.CVCall.getValidatorScriptResources() may expose internal representation by returning CVCall._validatorScriptResources | MALICIOUS_CODE | EI_EXPOSE_REP | 91 | Medium |
| org.apache.myfaces.custom.clientvalidation.common.CVCall.setValidatorScriptFunctions(String[]) may expose internal representation by storing an externally mutable object into CVCall._validatorScriptFunctions | MALICIOUS_CODE | EI_EXPOSE_REP2 | 87 | Medium |
| org.apache.myfaces.custom.clientvalidation.common.CVCall.setValidatorScriptResources(String[]) may expose internal representation by storing an externally mutable object into CVCall._validatorScriptResources | MALICIOUS_CODE | EI_EXPOSE_REP2 | 94 | Medium |
| org.apache.myfaces.custom.clientvalidation.common.CVCall is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 40-95 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.custom.clientvalidation.common.CVCallsHolder defines non-transient non-serializable instance field _cvCalls | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.custom.clientvalidation.common.CVCallsHolder is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 35-49 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to comp in org.apache.myfaces.custom.clientvalidation.validationscript.ValidationScriptTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 60 | Medium |
| Dead store to context in org.apache.myfaces.custom.clientvalidation.validationscript.ValidationScriptTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 64 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Comparison of String parameter using == or != in org.apache.myfaces.custom.comparetovalidator.AbstractCompareToValidator.nameForOperator(String) | BAD_PRACTICE | ES_COMPARING_PARAMETER_STRING_WITH_EQ | 183 | High |
| Comparison of String parameter using == or != in org.apache.myfaces.custom.comparetovalidator.AbstractCompareToValidator.validateOperatorOnComparisonResult(String, int) | BAD_PRACTICE | ES_COMPARING_PARAMETER_STRING_WITH_EQ | 201 | High |
| Redundant nullcheck of foreignValue, which is known to be non-null in org.apache.myfaces.custom.comparetovalidator.AbstractCompareToValidator.validate(FacesContext, UIComponent, Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 280 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.conversation.AbstractConversationTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 97 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.custom.conversation.ConversationManager.getConversationContextId() invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 208 | Medium |
| new org.apache.myfaces.custom.conversation.ConversationManager() invokes org.apache.myfaces.custom.conversation.ConversationManager$ContextWiperThread.start() | MT_CORRECTNESS | SC_START_IN_CTOR | 96 | Medium |
| org.apache.myfaces.custom.conversation.ConversationManager is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 43-590 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.custom.conversation.ConversationRequestParameterProvider.getFields() may expose internal representation by returning ConversationRequestParameterProvider.REQUEST_PARAMETERS | MALICIOUS_CODE | EI_EXPOSE_REP | 72 | Medium |
| Should org.apache.myfaces.custom.conversation.ConversationRequestParameterProvider.getFields() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 59 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.custom.conversation.UIEndConversation.getRestart() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 193 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.custom.conversation.UIEnsureConversation.getPreCheck() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 185 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.custom.conversation.UIStartConversation.getPersistence() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 199 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.custom.conversation.ValueBindingKey implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 30-37 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.custom.convertDateTime.ConvertDateTimeTag is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 44-198 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.custom.convertNumber.TypedNumberConverter._saveState(FacesContext) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 326 | Medium |
| Switch statement found in org.apache.myfaces.custom.convertNumber.TypedNumberConverter.checkJavaVersion14() where one case falls through to the next case | STYLE | SF_SWITCH_FALLTHROUGH | 563-566 | Medium |
| Switch statement found in org.apache.myfaces.custom.convertNumber.TypedNumberConverter.checkJavaVersion14() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 568-572 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.custom.convertNumber.TypedNumberConverterTag is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 42-331 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.custom.convertStringUtils.StringUtilsConverter.getAsObject(FacesContext, UIComponent, String) invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 64 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.custom.csvvalidator.AbstractCSVValidator.addMessage(FacesMessage, FacesMessage, int, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 93 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.apache.myfaces.custom.exporter.ExporterActionListener.processAction(ActionEvent), since all org.apache.myfaces.component.html.ext.HtmlDataTable are instances of org.apache.myfaces.component.html.ext.HtmlDataTable | STYLE | BC_VACUOUS_INSTANCEOF | 72 | Medium |
| Method org.apache.myfaces.custom.exporter.ExporterActionListener.processAction(ActionEvent) does an unnecessary type check using instanceof operator when it can be determined statically | CORRECTNESS | SIO_SUPERFLUOUS_INSTANCEOF | 72 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.custom.focus2.HtmlFocus in org.apache.myfaces.custom.focus2.HtmlFocusRenderer.decode(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 54 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.custom.focus2.HtmlFocus in org.apache.myfaces.custom.focus2.HtmlFocusRenderer.encodeEnd(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 68 | Low |
| Dead store to it in org.apache.myfaces.custom.focus2.HtmlFocusRenderer.getFocusForId(FacesContext, HtmlFocus) | STYLE | DLS_DEAD_LOCAL_STORE | 295 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.custom.focus2.HtmlFocusRenderer$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 314-323 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Private method org.apache.myfaces.custom.focus2.HtmlFocusRenderer$2.isVisible(UIComponent) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 387 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.focus2.HtmlFocusTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 146 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.form.HtmlFormTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 106 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to comp in org.apache.myfaces.custom.globalId.GlobalIdTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 60 | Medium |
| Dead store to context in org.apache.myfaces.custom.globalId.GlobalIdTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 64 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.custom.graphicimagedynamic.GraphicImageDynamic in org.apache.myfaces.custom.graphicimagedynamic.GraphicImageDynamicRenderer.encodeEnd(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 75 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.graphicimagedynamic.GraphicImageDynamicTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 70 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.ifmessage.IfMessageTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 70 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.apache.myfaces.custom.inputAjax.AbstractHtmlSelectBooleanCheckboxAjax.decodeUISelectBoolean(FacesContext, AbstractHtmlSelectBooleanCheckboxAjax), since all org.apache.myfaces.custom.inputAjax.AbstractHtmlSelectBooleanCheckboxAjax are instances of javax.faces.component.EditableValueHolder | STYLE | BC_VACUOUS_INSTANCEOF | 103 | Medium |
| Method org.apache.myfaces.custom.inputAjax.AbstractHtmlSelectBooleanCheckboxAjax.decodeUISelectBoolean(FacesContext, AbstractHtmlSelectBooleanCheckboxAjax) does an unnecessary type check using instanceof operator when it can be determined statically | CORRECTNESS | SIO_SUPERFLUOUS_INSTANCEOF | 103 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.inputAjax.HtmlCommandButtonAjaxTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 85 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.custom.inputAjax.HtmlInputTextAjax in org.apache.myfaces.custom.inputAjax.HtmlInputTextAjaxRenderer.encodeEnd(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 94 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.inputAjax.HtmlInputTextAjaxTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 122 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.custom.inputAjax.HtmlSelectBooleanCheckboxAjax in org.apache.myfaces.custom.inputAjax.HtmlSelectBooleanCheckboxAjaxRenderer.encodeEnd(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 122 | Low |
| Load of known null value in org.apache.myfaces.custom.inputAjax.HtmlSelectBooleanCheckboxAjaxRenderer.encodeJavascript(FacesContext, UIComponent) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 79 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.inputAjax.HtmlSelectBooleanCheckboxAjaxTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 98 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.custom.inputAjax.HtmlSelectManyCheckboxAjax in org.apache.myfaces.custom.inputAjax.HtmlSelectManyCheckboxAjaxRenderer.encodeEnd(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 98 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.inputAjax.HtmlSelectManyCheckboxAjaxTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 86 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.custom.inputAjax.HtmlSelectOneRadioAjax in org.apache.myfaces.custom.inputAjax.HtmlSelectOneRadioAjaxRenderer.encodeEnd(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 96 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.inputAjax.HtmlSelectOneRadioAjaxTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 86 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.inputAjax.ListenerTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 82 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to facesContext in org.apache.myfaces.custom.isbnvalidator.ValidateISBNTag._setProperties(Validator) | STYLE | DLS_DEAD_LOCAL_STORE | 53 | Medium |
| Dead store to validator in org.apache.myfaces.custom.isbnvalidator.ValidateISBNTag._setProperties(Validator) | STYLE | DLS_DEAD_LOCAL_STORE | 55 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of java.util.ResourceBundle.getObject(String), which is known to be non-null in org.apache.myfaces.custom.loadbundle.AbstractLoadBundle$BundleMap.containsKey(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 236 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.loadbundle.LoadBundleTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 76 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.custom.media.AbstractMediaComponent.COMPONENT_FAMILY isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 34 | Low |
| org.apache.myfaces.custom.media.AbstractMediaComponent.COMPONENT_TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 32 | Low |
| org.apache.myfaces.custom.media.AbstractMediaComponent.DEFAULT_RENDERER_TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 33 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.custom.media.MediaComponent in org.apache.myfaces.custom.media.MediaRenderer.encodeBegin(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 49 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.media.MediaTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 88 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.custom.outputlinkdynamic.OutputLinkDynamic in org.apache.myfaces.custom.outputlinkdynamic.OutputLinkDynamicRenderer.encodeBegin(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 113 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.outputlinkdynamic.OutputLinkDynamicTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 95 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.custom.passwordStrength.AbstractPasswordStrengthComponent.COMPONENT_FAMILY isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 56 | Low |
| org.apache.myfaces.custom.passwordStrength.AbstractPasswordStrengthComponent.COMPONENT_TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 52 | Low |
| org.apache.myfaces.custom.passwordStrength.AbstractPasswordStrengthComponent.DEFAULT_RENDERER_TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 54 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIInput in org.apache.myfaces.custom.passwordStrength.PasswordStrengthRenderer.decode(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 365 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 193 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.passwordStrength.PasswordStrengthTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 122 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.custom.redirectTracker.RedirectTrackerManager defines non-transient non-serializable instance field redirectEntryList | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.custom.redirectTracker.RedirectTrackerManager defines non-transient non-serializable instance field redirectEntryMap | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.custom.redirectTracker.RedirectTrackerManager is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 49-453 | Medium |
| The field org.apache.myfaces.custom.redirectTracker.RedirectTrackerManager.requestBeanMap is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.custom.redirectTracker.RedirectTrackerManager$Entry defines non-transient non-serializable instance field beanMap | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.custom.redirectTracker.RedirectTrackerManager$Entry defines non-transient non-serializable instance field messages | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.custom.redirectTracker.RedirectTrackerManager$Entry is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 62-95 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.custom.redirectTracker.RedirectTrackerManager$MessageEntry is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 101-110 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.custom.redirectTracker.RedirectTrackerNavigationHandler$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 41-44 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.renderOne.UIRenderOneTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 76 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.custom.requestParameterProvider.RequestParameterProviderManager is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 40-172 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.custom.roundeddiv.HtmlRoundedDiv in org.apache.myfaces.custom.roundeddiv.HtmlRoundedDivRenderer.encodeBegin(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 224 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.custom.roundeddiv.HtmlRoundedDiv in org.apache.myfaces.custom.roundeddiv.HtmlRoundedDivRenderer.encodeChildren(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 329 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.custom.roundeddiv.HtmlRoundedDiv in org.apache.myfaces.custom.roundeddiv.HtmlRoundedDivRenderer.encodeEnd(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 347 | Low |
| Possible doublecheck on org.apache.myfaces.custom.roundeddiv.HtmlRoundedDivRenderer.cacheSize in org.apache.myfaces.custom.roundeddiv.HtmlRoundedDivRenderer.initCache(ServletContext) | MT_CORRECTNESS | DC_DOUBLECHECK | 986-992 | Medium |
| Dead store of null to baos in org.apache.myfaces.custom.roundeddiv.HtmlRoundedDivRenderer.serveResource(ServletContext, HttpServletRequest, HttpServletResponse, String) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 136 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 975 | Low |
| Method org.apache.myfaces.custom.roundeddiv.HtmlRoundedDivRenderer.initCache(ServletContext) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 1000 | Medium |
| Method org.apache.myfaces.custom.roundeddiv.HtmlRoundedDivRenderer.isIE(FacesContext) invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 972 | Low |
| Redundant nullcheck of org.apache.myfaces.custom.roundeddiv.HtmlRoundedDivRenderer.cacheSize which is known to be null in org.apache.myfaces.custom.roundeddiv.HtmlRoundedDivRenderer.initCache(ServletContext) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 998 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.roundeddiv.HtmlRoundedDivTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 131 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to width in org.apache.myfaces.custom.roundeddiv.RoundedBorderGenerator.paint3DBorderTransition(Graphics2D, Color, Color, int, int, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 367 | Medium |
| org.apache.myfaces.custom.roundeddiv.RoundedBorderGenerator.main(String[]) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 474 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.custom.roundeddiv.RoundedBorderGenerator.main(String[]) | STYLE | REC_CATCH_EXCEPTION | 480 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.custom.scope.ScopeHolder defines non-transient non-serializable instance field oldScopes | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.custom.scope.ScopeHolder defines non-transient non-serializable instance field scopeMap | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to comp in org.apache.myfaces.custom.scope.ScopeTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 60 | Medium |
| Dead store to context in org.apache.myfaces.custom.scope.ScopeTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 64 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.custom.scope.ScopeUtils.getManagedBean(String) | STYLE | REC_CATCH_EXCEPTION | 85 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.myfaces.custom.script.Script in org.apache.myfaces.custom.script.ScriptRenderer.encodeBegin(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 46 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.script.ScriptTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 83 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.EditableValueHolder in org.apache.myfaces.custom.suggest.InputSuggestRenderer.decode(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 77 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.EditableValueHolder in org.apache.myfaces.custom.suggest.InputSuggestRenderer.encodeBegin(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 97 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.ValueHolder in org.apache.myfaces.custom.suggest.InputSuggestRenderer.encodeBegin(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 101 | Low |
| Method call in org.apache.myfaces.custom.suggest.InputSuggestRenderer.encodeBegin(FacesContext, UIComponent) passes null for nonnull parameter of encodeSuggestions(FacesContext, ResponseWriter, Map, String, UIComponent) | CORRECTNESS | NP_NULL_PARAM_DEREF | 123 | Medium |
| Method org.apache.myfaces.custom.suggest.InputSuggestRenderer.encodeSuggestions(FacesContext, ResponseWriter, Map, String, UIComponent) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 175 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to context in org.apache.myfaces.custom.suggest.InputSuggestTag.setProperties(UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 98 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.custom.urlvalidator.AbstractUrlValidator.getSchemesList() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 117 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.custom.valueChangeNotifier.ValueChangeCollector$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 84-100 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.custom.valueChangeNotifier.ValueChangeManager.SIGNATURE should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 41 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.custom.valueChangeNotifier.ValueChangeNotifierTag is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 53-122 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.html.HtmlCommandButton in org.apache.myfaces.renderkit.html.ext.HtmlButtonExRenderer.encodeBegin(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 44 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of templateEncoder in org.apache.myfaces.renderkit.template.TemplateRenderer.encodeTemplate(FacesContext, UIComponent, String) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 91 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.apache.myfaces.tomahawk.util.ErrorPageWriter.DEBUG_PARTS in org.apache.myfaces.tomahawk.util.ErrorPageWriter.init(FacesContext) | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 96-97 | Low |
| Incorrect lazy initialization of static field org.apache.myfaces.tomahawk.util.ErrorPageWriter.ERROR_PARTS in org.apache.myfaces.tomahawk.util.ErrorPageWriter.init(FacesContext) | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 92-93 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.tomahawk.util.ErrorPageWriter.initCauseIfAvailable(Throwable, Throwable) | STYLE | REC_CATCH_EXCEPTION | 573 | Medium |
| Exception is caught when Exception is not thrown in org.apache.myfaces.tomahawk.util.ErrorPageWriter.initCausePerReflection(Throwable, String) | STYLE | REC_CATCH_EXCEPTION | 529 | Medium |
| Exception is caught when Exception is not thrown in org.apache.myfaces.tomahawk.util.ErrorPageWriter.writeAttributes(Writer, UIComponent) | STYLE | REC_CATCH_EXCEPTION | 404 | Medium |
| Exception is caught when Exception is not thrown in org.apache.myfaces.tomahawk.util.ErrorPageWriter.writeAttributes(Writer, UIComponent) | STYLE | REC_CATCH_EXCEPTION | 404 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.apache.myfaces.tomahawk.util.ErrorRedirectJSFPageHandler.handleException(FacesContext, Exception) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 132 | Medium |
| Load of known null value in org.apache.myfaces.tomahawk.util.ErrorRedirectJSFPageHandler.handleThrowable(FacesContext, Throwable) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 198 | Medium |
