The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is low
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 43 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.examples.calendarexample.CalendarBean.getFirstDate() may expose internal representation by returning CalendarBean._firstDate | MALICIOUS_CODE | EI_EXPOSE_REP | 81 | Medium |
| org.apache.myfaces.examples.calendarexample.CalendarBean.getSecondDate() may expose internal representation by returning CalendarBean._secondDate | MALICIOUS_CODE | EI_EXPOSE_REP | 91 | Medium |
| org.apache.myfaces.examples.calendarexample.CalendarBean.getThirdDate() may expose internal representation by returning CalendarBean._thirdDate | MALICIOUS_CODE | EI_EXPOSE_REP | 101 | Medium |
| org.apache.myfaces.examples.calendarexample.CalendarBean.setFirstDate(Date) may expose internal representation by storing an externally mutable object into CalendarBean._firstDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 86 | Medium |
| org.apache.myfaces.examples.calendarexample.CalendarBean.setSecondDate(Date) may expose internal representation by storing an externally mutable object into CalendarBean._secondDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 96 | Medium |
| org.apache.myfaces.examples.calendarexample.CalendarBean.setThirdDate(Date) may expose internal representation by storing an externally mutable object into CalendarBean._thirdDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 106 | Medium |
| Class org.apache.myfaces.examples.calendarexample.CalendarBean defines non-transient non-serializable instance field _dates | BAD_PRACTICE | SE_BAD_FIELD | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.examples.calendarexample.DateHolder.getDate() may expose internal representation by returning DateHolder._date | MALICIOUS_CODE | EI_EXPOSE_REP | 40 | Medium |
| org.apache.myfaces.examples.calendarexample.DateHolder.setDate(Date) may expose internal representation by storing an externally mutable object into DateHolder._date | MALICIOUS_CODE | EI_EXPOSE_REP2 | 45 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.examples.collapsiblepanel.CollapsiblePanelBean.getBirthDate() may expose internal representation by returning CollapsiblePanelBean._birthDate | MALICIOUS_CODE | EI_EXPOSE_REP | 79 | Medium |
| org.apache.myfaces.examples.collapsiblepanel.CollapsiblePanelBean.setBirthDate(Date) may expose internal representation by storing an externally mutable object into CollapsiblePanelBean._birthDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 84 | Medium |
| Class org.apache.myfaces.examples.collapsiblepanel.CollapsiblePanelBean defines non-transient non-serializable instance field _persons | BAD_PRACTICE | SE_BAD_FIELD | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.examples.common.CarConfigurator.getExtras() may expose internal representation by returning CarConfigurator._extras | MALICIOUS_CODE | EI_EXPOSE_REP | 183 | Medium |
| org.apache.myfaces.examples.common.CarConfigurator.setExtras(String[]) may expose internal representation by storing an externally mutable object into CarConfigurator._extras | MALICIOUS_CODE | EI_EXPOSE_REP2 | 188 | Medium |
| Class org.apache.myfaces.examples.common.CarConfigurator defines non-transient non-serializable instance field _interiorColors | BAD_PRACTICE | SE_BAD_FIELD | Low | |
| Switch statement found in org.apache.myfaces.examples.common.CarConfigurator.calcPrice() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 271 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.examples.common.CarConfigurator$Color defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 361 | High |
| Possible null pointer dereference of CarConfigurator$Color.color in org.apache.myfaces.examples.common.CarConfigurator$Color.equals(Object) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 369 | Medium |
| org.apache.myfaces.examples.common.CarConfigurator$Color is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 345 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.examples.crosstable.DataBean.getColumnValue() uses the nextDouble method of Random to generate a random integer; using nextInt is more efficient | PERFORMANCE | DM_NEXTINT_VIA_NEXTDOUBLE | 134 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.examples.crosstable.DataBean$RowColumnKey be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 169 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.examples.displayValueOnly.DVOFace defines non-transient non-serializable instance field map | BAD_PRACTICE | SE_BAD_FIELD | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 51 | Low |
| org.apache.myfaces.examples.displayValueOnly.DVOFace$1.get(Object) checks to see if result of String.indexOf is positive | STYLE | RV_CHECK_FOR_POSITIVE_INDEXOF | 51 | Low |
| org.apache.myfaces.examples.displayValueOnly.DVOFace$1 is serializable and an inner class | BAD_PRACTICE | SE_INNER_CLASS | 40 | Low |
| The class org.apache.myfaces.examples.displayValueOnly.DVOFace$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 40 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 43 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 38 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.examples.example2.QuotationForm.getSelectManyValues() may expose internal representation by returning QuotationForm._selectManyValues | MALICIOUS_CODE | EI_EXPOSE_REP | 81 | Medium |
| org.apache.myfaces.examples.example2.QuotationForm.getSelectOneItems() may expose internal representation by returning QuotationForm._selectItems | MALICIOUS_CODE | EI_EXPOSE_REP | 73 | Medium |
| org.apache.myfaces.examples.example2.QuotationForm.setSelectManyValues(String[]) may expose internal representation by storing an externally mutable object into QuotationForm._selectManyValues | MALICIOUS_CODE | EI_EXPOSE_REP2 | 86 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.examples.forceid.ForceIdBean.getUsers() may expose internal representation by returning ForceIdBean.users | MALICIOUS_CODE | EI_EXPOSE_REP | 57 | Medium |
| org.apache.myfaces.examples.forceid.ForceIdBean.setUsers(User[]) may expose internal representation by storing an externally mutable object into ForceIdBean.users | MALICIOUS_CODE | EI_EXPOSE_REP2 | 60 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.event.ActionEvent to org.apache.myfaces.custom.datascroller.ScrollerActionEvent in org.apache.myfaces.examples.listexample.DataScrollerList.scrollerAction(ActionEvent) | STYLE | BC_UNCONFIRMED_CAST | 63 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of column1 on path that might be infeasible in org.apache.myfaces.examples.listexample.OpenDataList$1.compare(Object, Object) | STYLE | NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE | 161 | Medium |
| The class org.apache.myfaces.examples.listexample.OpenDataList$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 148 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.examples.listexample.PagedSortableCarList$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 73 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.examples.listexample.SimpleCountry defines non-transient non-serializable instance field _cities | BAD_PRACTICE | SE_BAD_FIELD | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.examples.listexample.SimpleSortableCarList$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 61 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.examples.misc.OptionsForm$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 69 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.examples.misc.TestCheckBox is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 27 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.examples.schedule.AddEntryHandler.getFrom() may expose internal representation by returning AddEntryHandler.from | MALICIOUS_CODE | EI_EXPOSE_REP | 65 | Medium |
| org.apache.myfaces.examples.schedule.AddEntryHandler.getUntil() may expose internal representation by returning AddEntryHandler.until | MALICIOUS_CODE | EI_EXPOSE_REP | 105 | Medium |
| org.apache.myfaces.examples.schedule.AddEntryHandler.setFrom(Date) may expose internal representation by storing an externally mutable object into AddEntryHandler.from | MALICIOUS_CODE | EI_EXPOSE_REP2 | 70 | Medium |
| org.apache.myfaces.examples.schedule.AddEntryHandler.setUntil(Date) may expose internal representation by storing an externally mutable object into AddEntryHandler.until | MALICIOUS_CODE | EI_EXPOSE_REP2 | 110 | Medium |
| AddEntryHandler.from not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Low | |
| AddEntryHandler.model not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| BindingScheduleExampleHandler.schedule not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| ScheduleExampleHandler.model not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| ScheduleSettings.model not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.event.ActionEvent to org.apache.myfaces.custom.datascroller.ScrollerActionEvent in org.apache.myfaces.examples.selectOneRow.SelectOneRowList.scrollerAction(ActionEvent) | STYLE | BC_UNCONFIRMED_CAST | 82 | Medium |
| Dead store to newVal in org.apache.myfaces.examples.selectOneRow.SelectOneRowList.processRowSelection(ValueChangeEvent) | STYLE | DLS_DEAD_LOCAL_STORE | 92 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.examples.testexception.TestException is not derived from an Exception, even though it is named as such | BAD_PRACTICE | NM_CLASS_NOT_EXCEPTION | 21 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.examples.toggle.ToggleBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 24 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.apache.myfaces.examples.tree.TreeBacker.checkPath(FacesContext, UIComponent, Object) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 172 | Low |
| Class org.apache.myfaces.examples.tree.TreeBacker defines non-transient non-serializable instance field _tree | BAD_PRACTICE | SE_BAD_FIELD | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.examples.webapp.SourceCodeServlet is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 28 | Low |
