PMD Results
The following document contains the results of PMD 4.2.5.
Files
org/apache/myfaces/tobago/ant/sniplet/CodeSniplet.java
Violation | Line |
---|---|
The class 'CodeSniplet' has a Cyclomatic Complexity of 2 (Highest = 11). | 25 - 109 |
The class 'CodeSniplet' has a Cyclomatic Complexity of 2 (Highest = 11). | 25 - 109 |
Private field 'code' could be made final; it is only initialized in the declaration or constructor. | 28 |
Parameter 'id' is not assigned and could be declared final | 33 |
Parameter 'lineStart' is not assigned and could be declared final | 33 |
Parameter 'fileName' is not assigned and could be declared final | 33 |
Parameter 'line' is not assigned and could be declared final | 40 |
Parameter 'id' is not assigned and could be declared final | 48 |
Parameter 'stripLeadingSpaces' is not assigned and could be declared final | 52 |
The method 'getCode' has a Cyclomatic Complexity of 11. | 52 - 79 |
The method 'getCode' has a Cyclomatic Complexity of 11. | 52 - 79 |
Local variable 's' could be declared final | 55 |
Local variable 'c' could be declared final | 57 |
Local variable 'sb' could be declared final | 66 |
Local variable 's' could be declared final | 68 |
Avoid appending characters as strings in StringBuffer.append. | 75 |
Parameter 'fileName' is not assigned and could be declared final | 85 |
Parameter 'lineStart' is not assigned and could be declared final | 93 |
Parameter 'lineEnd' is not assigned and could be declared final | 101 |
org/apache/myfaces/tobago/ant/sniplet/CodeSnipletExtractTask.java
Violation | Line |
---|---|
The class 'CodeSnipletExtractTask' has a Cyclomatic Complexity of 2 (Highest = 11). | 66 - 211 |
The class 'CodeSnipletExtractTask' has a Cyclomatic Complexity of 2 (Highest = 11). | 66 - 211 |
Parameter 'outputFileNamePattern' is not assigned and could be declared final | 87 |
Parameter 'outputDir' is not assigned and could be declared final | 95 |
Parameter 'fileSet' is not assigned and could be declared final | 99 |
Parameter 'stripLeadingSpaces' is not assigned and could be declared final | 107 |
The method 'execute' has a Cyclomatic Complexity of 11. | 111 - 161 |
The method 'execute' has a Cyclomatic Complexity of 11. | 111 - 161 |
Local variable 'fileSet' could be declared final | 113 |
Local variable 'dirScanner' could be declared final | 114 |
Local variable 'includedFiles' could be declared final | 116 |
Local variable 'fileS' could be declared final | 118 |
Avoid instantiating new objects inside loops | 121 - 122 |
Local variable 'startMatcher' could be declared final | 125 |
Local variable 'endMatcher' could be declared final | 129 |
Local variable 'codeSniplet' could be declared final | 139 |
The String literal "' at line '" appears 4 times in this file; the first occurrence is on line 142 | 142 |
Avoid instantiating new objects inside loops | 147 |
Local variable 'codeSniplet' could be declared final | 165 |
Local variable 'fileName' could be declared final | 166 |
Local variable 'file' could be declared final | 167 |
Avoid instantiating new objects inside loops | 167 |
Local variable 'out' could be declared final | 168 |
Avoid instantiating new objects inside loops | 168 |
Local variable 'code' could be declared final | 169 |
Parameter 'id' is not assigned and could be declared final | 176 |
Parameter 'fileName' is not assigned and could be declared final | 176 |
Parameter 'lineNumber' is not assigned and could be declared final | 176 |
Local variable 'codeSniplet' could be declared final | 178 |
Local variable 'codeSniplet' could be declared final | 185 |
Parameter 'id' is not assigned and could be declared final | 189 |
Parameter 'fileName' is not assigned and could be declared final | 189 |
Parameter 'lineNumber' is not assigned and could be declared final | 189 |
Local variable 'codeSniplet' could be declared final | 191 |
Parameter 'line' is not assigned and could be declared final | 201 |
Local variable 'codeSniplet' could be declared final | 203 |
org/apache/myfaces/tobago/apt/AnnotationUtils.java
Violation | Line |
---|---|
Parameter 'componentTag' is not assigned and could be declared final | 31 |
Parameter 'typeElement' is not assigned and could be declared final | 40 |
org/apache/myfaces/tobago/apt/generate/ClassInfo.java
Violation | Line |
---|---|
Private field 'className' could be made final; it is only initialized in the declaration or constructor. | 27 |
Private field 'packageName' could be made final; it is only initialized in the declaration or constructor. | 28 |
Private field 'imports' could be made final; it is only initialized in the declaration or constructor. | 29 |
Private field 'interfaces' could be made final; it is only initialized in the declaration or constructor. | 31 |
Private field 'sourceClass' could be made final; it is only initialized in the declaration or constructor. | 32 |
Parameter 'sourceClass' is not assigned and could be declared final | 34 |
Parameter 'qualifiedName' is not assigned and could be declared final | 34 |
Parameter 'qualifiedName' is not assigned and could be declared final | 49 |
Local variable 'name' could be declared final | 50 |
Avoid if (x != y) ..; else ..; | 51 - 56 |
Parameter 'qualifiedName' is not assigned and could be declared final | 67 |
Parameter 'qualifiedName' is not assigned and could be declared final | 75 |
Local variable 'name' could be declared final | 76 |
Avoid if (x != y) ..; else ..; | 77 - 82 |
org/apache/myfaces/tobago/apt/generate/ClassUtils.java
Violation | Line |
---|---|
A class which only has private constructors should be final | 25 - 71 |
Parameter 'qualifiedName' is not assigned and could be declared final | 44 |
Local variable 'pos' could be declared final | 45 |
Parameter 'qualifiedName' is not assigned and could be declared final | 52 |
Local variable 'pos' could be declared final | 53 |
Parameter 'qualifiedClassName' is not assigned and could be declared final | 60 |
Parameter 'name' is not assigned and could be declared final | 64 |
Parameter 'primitive' is not assigned and could be declared final | 68 |
org/apache/myfaces/tobago/apt/generate/ComponentInfo.java
Violation | Line |
---|---|
Private field 'nonTransientProperties' could be made final; it is only initialized in the declaration or constructor. | 30 |
Private field 'transientProperties' could be made final; it is only initialized in the declaration or constructor. | 31 |
Parameter 'declaration' is not assigned and could be declared final | 39 |
Parameter 'componentTag' is not assigned and could be declared final | 39 |
Parameter 'sourceClass' is not assigned and could be declared final | 48 |
Parameter 'rendererType' is not assigned and could be declared final | 48 |
Parameter 'qualifiedName' is not assigned and could be declared final | 48 |
Parameter 'invokeOnComponent' is not assigned and could be declared final | 56 |
Parameter 'propertyInfo' is not assigned and could be declared final | 60 |
Avoid if (x != y) ..; else ..; | 64 - 70 |
Parameter 'messages' is not assigned and could be declared final | 101 |
Parameter 'description' is not assigned and could be declared final | 105 |
Parameter 'deprecated' is not assigned and could be declared final | 113 |
org/apache/myfaces/tobago/apt/generate/ComponentPropertyInfo.java
Violation | Line |
---|---|
Parameter 'index' is not assigned and could be declared final | 42 |
Parameter 'index' is not assigned and could be declared final | 54 |
org/apache/myfaces/tobago/apt/generate/Imports.java
Violation | Line |
---|---|
The class 'Imports' has a Cyclomatic Complexity of 2 (Highest = 7). | 26 - 67 |
Private field 'imports' could be made final; it is only initialized in the declaration or constructor. | 28 |
Document empty constructor | 32 - 33 |
Parameter 'packageName' is not assigned and could be declared final | 35 |
Avoid reassigning parameters such as 'qualifiedName' | 39 |
The method 'addImport' has a Cyclomatic Complexity of 7. | 39 - 51 |
These nested if statements could be combined | 41 - 49 |
These nested if statements could be combined | 41 - 49 |
Local variable 'index' could be declared final | 42 |
Deeply nested if..then statements are hard to read | 43 - 45 |
Deeply nested if..then statements are hard to read | 46 - 48 |
Parameter 'newImports' is not assigned and could be declared final | 53 |
Parameter 'qualifiedClassName' is not assigned and could be declared final | 59 |
org/apache/myfaces/tobago/apt/generate/PropertyInfo.java
Violation | Line |
---|---|
The class 'PropertyInfo' has a Cyclomatic Complexity of 1 (Highest = 5). | 24 - 262 |
This class has too many methods, consider refactoring it. | 24 - 262 |
Document empty constructor | 41 - 42 |
Parameter 'name' is not assigned and could be declared final | 44 |
Parameter 'bodyContent' is not assigned and could be declared final | 52 |
Parameter 'literalOnly' is not assigned and could be declared final | 60 |
Parameter 'name' is not assigned and could be declared final | 78 |
Parameter 'type' is not assigned and could be declared final | 98 |
Local variable 'shortType' could be declared final | 107 |
Local variable 'type' could be declared final | 112 |
Local variable 'index' could be declared final | 113 |
Position literals first in String comparisons | 125 |
Parameter 'allowdValues' is not assigned and could be declared final | 135 |
Parameter 'methodSignature' is not assigned and could be declared final | 143 |
Parameter 'defaultValue' is not assigned and could be declared final | 151 |
Parameter 'deprecated' is not assigned and could be declared final | 155 |
The method 'getDefaultCode' has a Cyclomatic Complexity of 5. | 163 - 174 |
Parameter 'defaultCode' is not assigned and could be declared final | 176 |
Parameter 'valueExpressionRequired' is not assigned and could be declared final | 184 |
Parameter 'methodExpressionRequired' is not assigned and could be declared final | 192 |
Parameter 'tagAttribute' is not assigned and could be declared final | 200 |
Parameter 'info' is not assigned and could be declared final | 204 |
Parameter 'o' is not assigned and could be declared final | 221 |
Local variable 'that' could be declared final | 229 |
Parameter 'description' is not assigned and could be declared final | 239 |
Parameter 'transientValue' is not assigned and could be declared final | 251 |
Parameter 'generate' is not assigned and could be declared final | 259 |
org/apache/myfaces/tobago/apt/generate/RendererInfo.java
Violation | Line |
---|---|
Parameter 'sourceClass' is not assigned and could be declared final | 25 |
Parameter 'qualifiedName' is not assigned and could be declared final | 25 |
Parameter 'sourceClass' is not assigned and could be declared final | 29 |
Parameter 'rendererType' is not assigned and could be declared final | 29 |
Parameter 'qualifiedName' is not assigned and could be declared final | 29 |
org/apache/myfaces/tobago/apt/generate/TagInfo.java
Violation | Line |
---|---|
Private field 'properties' could be made final; it is only initialized in the declaration or constructor. | 27 |
Parameter 'sourceClass' is not assigned and could be declared final | 34 |
Parameter 'rendererType' is not assigned and could be declared final | 34 |
Parameter 'qualifiedName' is not assigned and could be declared final | 34 |
Parameter 'sourceClass' is not assigned and could be declared final | 38 |
Parameter 'qualifiedName' is not assigned and could be declared final | 38 |
Parameter 'bodyContent' is not assigned and could be declared final | 55 |
Parameter 'componentClass' is not assigned and could be declared final | 71 |
Parameter 'componentType' is not assigned and could be declared final | 84 |
Parameter 'componentFamily' is not assigned and could be declared final | 92 |
org/apache/myfaces/tobago/apt/processor/AbstractGenerator.java
Violation | Line |
---|---|
The class 'AbstractGenerator' has a Cyclomatic Complexity of 2 (Highest = 11). | 40 - 122 |
The class 'AbstractGenerator' has a Cyclomatic Complexity of 2 (Highest = 11). | 40 - 122 |
Parameter 'roundEnv' is not assigned and could be declared final | 47 |
Parameter 'annotations' is not assigned and could be declared final | 47 |
The method 'process' has a Cyclomatic Complexity of 11. | 47 - 95 |
The method 'process' has a Cyclomatic Complexity of 11. | 47 - 95 |
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 56 |
These nested if statements could be combined | 68 - 70 |
These nested if statements could be combined | 68 - 70 |
These nested if statements could be combined | 73 - 75 |
These nested if statements could be combined | 73 - 75 |
Parameter 'd1' is not assigned and could be declared final | 81 |
Parameter 'd2' is not assigned and could be declared final | 81 |
A method/constructor shouldn't explicitly throw java.lang.Exception | 99 |
Parameter 'message' is not assigned and could be declared final | 101 |
Parameter 'message' is not assigned and could be declared final | 105 |
Parameter 'e' is not assigned and could be declared final | 109 |
Do not add empty strings | 112 |
org/apache/myfaces/tobago/apt/processor/CheckstyleConfigGenerator.java
Violation | Line |
---|---|
A high number of imports can indicate a high degree of coupling within an object. | 20 - 283 |
The class 'CheckstyleConfigGenerator' has a Cyclomatic Complexity of 3 (Highest = 9). | 70 - 283 |
This class has too many methods, consider refactoring it. | 70 - 283 |
Local variable 'dbf' could be declared final | 89 |
Local variable 'parser' could be declared final | 91 |
Local variable 'document' could be declared final | 92 |
Local variable 'module' could be declared final | 93 |
The String literal "name" appears 5 times in this file; the first occurrence is on line 94 | 94 |
Local variable 'taglibAnnotation' could be declared final | 97 |
Parameter 'packageElement' is not assigned and could be declared final | 107 |
Parameter 'taglibAnnotation' is not assigned and could be declared final | 107 |
Parameter 'module' is not assigned and could be declared final | 107 |
Parameter 'document' is not assigned and could be declared final | 107 |
Parameter 'document' is not assigned and could be declared final | 121 |
Local variable 'transFactory' could be declared final | 131 |
Local variable 'transformer' could be declared final | 133 |
Parameter 'document' is not assigned and could be declared final | 143 |
Parameter 'taglib' is not assigned and could be declared final | 143 |
Parameter 'typeElement' is not assigned and could be declared final | 143 |
Parameter 'parent' is not assigned and could be declared final | 143 |
The method 'appendTag' has a Cyclomatic Complexity of 9. | 143 - 170 |
Local variable 'annotationTag' could be declared final | 145 |
Avoid if (x != y) ..; else ..; | 150 - 159 |
Avoid if (x != y) ..; else ..; | 152 - 159 |
Avoid if (x != y) ..; else ..; | 154 - 159 |
Parameter 'document' is not assigned and could be declared final | 172 |
Parameter 'taglib' is not assigned and could be declared final | 172 |
Parameter 'tagName' is not assigned and could be declared final | 172 |
Parameter 'parent' is not assigned and could be declared final | 172 |
Local variable 'tag' could be declared final | 177 |
Parameter 'tagName' is not assigned and could be declared final | 182 |
Parameter 'document' is not assigned and could be declared final | 194 |
Parameter 'taglib' is not assigned and could be declared final | 194 |
Parameter 'tagName' is not assigned and could be declared final | 194 |
Parameter 'tagElement' is not assigned and could be declared final | 194 |
Parameter 'type' is not assigned and could be declared final | 194 |
The method 'addAttributes' has a Cyclomatic Complexity of 5. | 194 - 207 |
Local variable 'executableElement' could be declared final | 199 |
The method 'addAttribute' has a Cyclomatic Complexity of 6. | 209 - 232 |
Parameter 'document' is not assigned and could be declared final | 210 |
Parameter 'declaration' is not assigned and could be declared final | 210 |
Parameter 'taglib' is not assigned and could be declared final | 210 |
Parameter 'tagName' is not assigned and could be declared final | 210 |
Parameter 'parent' is not assigned and could be declared final | 210 |
Local variable 'tagAttribute' could be declared final | 211 |
Local variable 'deprecatedAnnotation' could be declared final | 212 |
Local variable 'simpleName' could be declared final | 214 |
Local variable 'module' could be declared final | 225 |
Parameter 'type' is not assigned and could be declared final | 234 |
Parameter 'd1' is not assigned and could be declared final | 238 |
Parameter 'd2' is not assigned and could be declared final | 238 |
Parameter 'taglibAnnotation' is not assigned and could be declared final | 245 |
Parameter 'document' is not assigned and could be declared final | 245 |
Parameter 'parent' is not assigned and could be declared final | 245 |
Avoid empty if statements | 248 - 250 |
Avoid empty if statements | 248 - 250 |
Parameter 'messageValue' is not assigned and could be declared final | 261 |
Parameter 'document' is not assigned and could be declared final | 261 |
Parameter 'formatValue' is not assigned and could be declared final | 261 |
Local variable 'module' could be declared final | 262 |
Local variable 'format' could be declared final | 265 |
Local variable 'message' could be declared final | 270 |
Local variable 'severity' could be declared final | 275 |
org/apache/myfaces/tobago/apt/processor/ClassesGenerator.java
Violation | Line |
---|---|
A high number of imports can indicate a high degree of coupling within an object. | 20 - 434 |
The class 'ClassesGenerator' has a Cyclomatic Complexity of 4 (Highest = 13). | 75 - 434 |
This class has too many methods, consider refactoring it. | 75 - 434 |
The class 'ClassesGenerator' has a Cyclomatic Complexity of 4 (Highest = 13). | 75 - 434 |
Private field 'renderer' could be made final; it is only initialized in the declaration or constructor. | 83 |
Perhaps 'jsfVersion' could be replaced by a local variable. | 85 |
Perhaps 'tagVersion' could be replaced by a local variable. | 86 |
The method 'generate' has a Cyclomatic Complexity of 6. | 122 - 136 |
A method/constructor shouldn't explicitly throw java.lang.Exception | 122 |
Avoid if (x != y) ..; else ..; | 124 - 134 |
Parameter 'declaration' is not assigned and could be declared final | 138 |
Local variable 'properties' could be declared final | 139 |
Local variable 'className' could be declared final | 141 |
Local variable 'tagInfo' could be declared final | 143 |
Local variable 'stringTemplate' could be declared final | 145 |
Parameter 'declaration' is not assigned and could be declared final | 153 |
The method 'createTagOrComponent' has a Cyclomatic Complexity of 12. | 153 - 242 |
The method createTagOrComponent() has an NPath complexity of 252 | 153 - 242 |
The method 'createTagOrComponent' has a Cyclomatic Complexity of 12. | 153 - 242 |
Local variable 'componentTag' could be declared final | 154 |
Local variable 'tag' could be declared final | 155 |
Local variable 'properties' could be declared final | 156 |
Local variable 'className' could be declared final | 159 |
Local variable 'tagInfo' could be declared final | 160 |
Local variable 'stringTemplate' could be declared final | 175 |
Local variable 'componentStringTemplate' could be declared final | 181 |
Local variable 'componentInfo' could be declared final | 182 |
Local variable 'facesClass' could be declared final | 190 - 191 |
Local variable 'methodName' could be declared final | 195 - 197 |
Position literals first in String comparisons | 196 |
Position literals first in String comparisons | 196 |
Avoid empty catch blocks | 205 - 207 |
Avoid empty catch blocks | 205 - 207 |
Parameter 'componentInfo' is not assigned and could be declared final | 262 |
Parameter 'info' is not assigned and could be declared final | 262 |
Parameter 'declaration' is not assigned and could be declared final | 277 |
The method 'createRenderer' has a Cyclomatic Complexity of 6. | 277 - 301 |
Local variable 'info' could be declared final | 289 |
Local variable 'stringTemplate' could be declared final | 297 |
Parameter 'properties' is not assigned and could be declared final | 303 |
Parameter 'type' is not assigned and could be declared final | 303 |
Parameter 'properties' is not assigned and could be declared final | 314 |
Parameter 'type' is not assigned and could be declared final | 314 |
Parameter 'interfaces' is not assigned and could be declared final | 327 |
Parameter 'properties' is not assigned and could be declared final | 327 |
Parameter 'typeMirror' is not assigned and could be declared final | 333 |
Parameter 'properties' is not assigned and could be declared final | 333 |
Parameter 'declaration' is not assigned and could be declared final | 339 |
Parameter 'properties' is not assigned and could be declared final | 339 |
The method 'addProperty' has a Cyclomatic Complexity of 13. | 339 - 388 |
The method addProperty() has an NPath complexity of 1403 | 339 - 388 |
The method 'addProperty' has a Cyclomatic Complexity of 13. | 339 - 388 |
Local variable 'tagAttribute' could be declared final | 340 |
Local variable 'uiComponentTagAttribute' could be declared final | 341 |
Local variable 'simpleName' could be declared final | 343 |
Local variable 'name' could be declared final | 345 |
Local variable 'propertyInfo' could be declared final | 349 |
Assigning an Object to null is a code smell. Consider refactoring. | 374 |
Assigning an Object to null is a code smell. Consider refactoring. | 376 |
Parameter 'element' is not assigned and could be declared final | 390 |
Local variable 'index' could be declared final | 393 |
Parameter 'declaration' is not assigned and could be declared final | 405 |
Parameter 'properties' is not assigned and could be declared final | 405 |
The method 'addPropertyForTagOnly' has a Cyclomatic Complexity of 5. | 405 - 419 |
Local variable 'tagAttribute' could be declared final | 406 |
Local variable 'simpleName' could be declared final | 408 |
Local variable 'propertyInfo' could be declared final | 414 |
Parameter 'stringTemplate' is not assigned and could be declared final | 421 |
Parameter 'info' is not assigned and could be declared final | 421 |
org/apache/myfaces/tobago/apt/processor/FacesConfigGenerator.java
Violation | Line |
---|---|
A high number of imports can indicate a high degree of coupling within an object. | 20 - 691 |
The class 'FacesConfigGenerator' has a Cyclomatic Complexity of 4 (Highest = 17). | 79 - 691 |
This class has too many methods, consider refactoring it. | 79 - 691 |
The class 'FacesConfigGenerator' has a Cyclomatic Complexity of 4 (Highest = 17). | 79 - 691 |
The method 'generate' has a Cyclomatic Complexity of 17. | 150 - 257 |
The method generate() has an NPath complexity of 4321 | 150 - 257 |
Avoid really long methods. | 150 - 257 |
The method 'generate' has a Cyclomatic Complexity of 17. | 150 - 257 |
A method/constructor shouldn't explicitly throw java.lang.Exception | 150 |
Local variable 'content' could be declared final | 154 |
Local variable 'builder' could be declared final | 155 |
Parameter 'publicId' is not assigned and could be declared final | 157 |
Parameter 'systemId' is not assigned and could be declared final | 157 |
Local variable 'stream' could be declared final | 159 - 160 |
Local variable 'rootElement' could be declared final | 173 |
Local variable 'xsi' could be declared final | 176 |
Local variable 'xsi' could be declared final | 183 |
Local variable 'namespace' could be declared final | 189 |
Local variable 'components' could be declared final | 193 |
Local variable 'newComponents' could be declared final | 195 |
Local variable 'newRenderer' could be declared final | 196 |
Local variable 'newConverters' could be declared final | 197 |
Local variable 'newValidators' could be declared final | 198 |
Avoid if (x != y) ..; else ..; | 201 - 207 |
Avoid if (x != y) ..; else ..; | 203 - 207 |
Local variable 'elementsToAdd' could be declared final | 210 |
Local variable 'found' could be declared final | 213 |
Local variable 'lastIndex' could be declared final | 220 |
Local variable 'renderKit' could be declared final | 224 |
Local variable 'renderKitId' could be declared final | 225 |
Local variable 'renderKitClass' could be declared final | 228 |
Local variable 'lastIndex' could be declared final | 232 |
Local variable 'lastIndex' could be declared final | 236 |
Local variable 'facesConfig' could be declared final | 247 |
Local variable 'format' could be declared final | 248 |
Local variable 'out' could be declared final | 250 |
Parameter 'parent' is not assigned and could be declared final | 259 |
Parameter 'namespace' is not assigned and could be declared final | 259 |
Parameter 'typeElement' is not assigned and could be declared final | 266 |
Parameter 'newConverters' is not assigned and could be declared final | 266 |
Parameter 'namespace' is not assigned and could be declared final | 266 |
Local variable 'converterAnn' could be declared final | 267 |
Local variable 'converter' could be declared final | 268 |
Local variable 'converterId' could be declared final | 270 |
Local variable 'converterForClass' could be declared final | 274 |
Local variable 'converterClass' could be declared final | 279 |
Parameter 'typeElement' is not assigned and could be declared final | 285 |
Parameter 'newValidators' is not assigned and could be declared final | 285 |
Parameter 'namespace' is not assigned and could be declared final | 285 |
Local variable 'validatorAnn' could be declared final | 286 |
Local variable 'validator' could be declared final | 287 |
Local variable 'validatorId' could be declared final | 289 |
Local variable 'validatorForClass' could be declared final | 293 |
Local variable 'validatorClass' could be declared final | 298 |
Parameter 'newElement' is not assigned and could be declared final | 304 |
Parameter 'components' is not assigned and could be declared final | 304 |
Parameter 'newElement' is not assigned and could be declared final | 308 |
Parameter 'components' is not assigned and could be declared final | 308 |
Parameter 'tagNames' is not assigned and could be declared final | 317 |
Parameter 'rootElement' is not assigned and could be declared final | 317 |
Local variable 'index' could be declared final | 319 |
Avoid unused private methods such as 'getIndexAfter(org.jdom.Element,String)'. | 327 |
Parameter 'tagName' is not assigned and could be declared final | 327 |
Parameter 'rootElement' is not assigned and could be declared final | 327 |
Avoid unused private methods such as 'getIndexAfter(org.jdom.Element,String)'. | 327 |
Local variable 'components' could be declared final | 328 |
Parameter 'element2' is not assigned and could be declared final | 335 |
Parameter 'element1' is not assigned and could be declared final | 335 |
The method 'equals' has a Cyclomatic Complexity of 5. | 335 - 345 |
Local variable 'namespace' could be declared final | 336 |
These nested if statements could be combined | 338 - 342 |
These nested if statements could be combined | 338 - 342 |
These nested if statements could be combined | 339 - 341 |
These nested if statements could be combined | 339 - 341 |
Parameter 'componentInfo' is not assigned and could be declared final | 348 |
Parameter 'componentTag' is not assigned and could be declared final | 348 |
Parameter 'namespace' is not assigned and could be declared final | 348 |
Local variable 'element' could be declared final | 350 |
Local variable 'elementDisplayName' could be declared final | 351 |
Local variable 'elementType' could be declared final | 354 |
Local variable 'elementClass' could be declared final | 357 |
Parameter 'componentInfo' is not assigned and could be declared final | 365 |
Parameter 'componentTag' is not assigned and could be declared final | 365 |
Parameter 'renderer' is not assigned and could be declared final | 365 |
Parameter 'namespace' is not assigned and could be declared final | 365 |
Local variable 'rendererType' could be declared final | 367 |
Local variable 'element' could be declared final | 369 |
Position literals first in String comparisons | 371 |
Local variable 'elementDisplayName' could be declared final | 374 |
Local variable 'elementComponentFamily' could be declared final | 377 |
Local variable 'elementType' could be declared final | 380 |
Local variable 'elementClass' could be declared final | 383 |
Local variable 'className' could be declared final | 384 |
Parameter 'typeElement' is not assigned and could be declared final | 393 |
Parameter 'uiComponentTag' is not assigned and could be declared final | 393 |
Parameter 'namespace' is not assigned and could be declared final | 394 |
Local variable 'elementExtension' could be declared final | 395 |
Local variable 'elementAllowedChildComponents' could be declared final | 396 |
Local variable 'allowedChildComponents' could be declared final | 397 |
Prefer StringBuffer over += for concatenating strings | 400 |
Local variable 'elementCategory' could be declared final | 404 |
Local variable 'deprecated' could be declared final | 407 |
Local variable 'elementDeprecated' could be declared final | 409 |
Local variable 'elementHidden' could be declared final | 413 |
The method 'addAttribute' has a Cyclomatic Complexity of 6. | 420 - 476 |
Parameter 'attributes' is not assigned and could be declared final | 421 |
Parameter 'properties' is not assigned and could be declared final | 421 |
Parameter 'executableElement' is not assigned and could be declared final | 421 |
Parameter 'namespace' is not assigned and could be declared final | 422 |
Local variable 'componentAttribute' could be declared final | 423 |
Local variable 'simpleName' could be declared final | 425 |
Local variable 'name' could be declared final | 427 |
Local variable 'attribute' could be declared final | 429 |
Local variable 'attributeName' could be declared final | 430 |
Local variable 'attributeClass' could be declared final | 431 |
Local variable 'defaultValue' could be declared final | 441 |
Local variable 'property' could be declared final | 451 |
Local variable 'propertyName' could be declared final | 452 |
Local variable 'propertyClass' could be declared final | 453 |
Local variable 'defaultValue' could be declared final | 463 |
Parameter 'attributeClass' is not assigned and could be declared final | 478 |
Parameter 'componentAttribute' is not assigned and could be declared final | 478 |
The method 'addClass' has a Cyclomatic Complexity of 5. | 478 - 492 |
Parameter 'element' is not assigned and could be declared final | 494 |
Parameter 'attribute' is not assigned and could be declared final | 494 |
Parameter 'namespace' is not assigned and could be declared final | 494 |
Local variable 'index' could be declared final | 497 |
Local variable 'description' could be declared final | 503 |
The method 'createPropertyOrAttributeExtension' has a Cyclomatic Complexity of 5. | 510 - 548 |
Parameter 'extensionType' is not assigned and could be declared final | 511 |
Parameter 'uiComponentTagAttribute' is not assigned and could be declared final | 511 |
Parameter 'executableElement' is not assigned and could be declared final | 511 |
Parameter 'namespace' is not assigned and could be declared final | 512 |
Local variable 'extensionElement' could be declared final | 514 |
Local variable 'valueExpression' could be declared final | 515 |
Local variable 'allowedValues' could be declared final | 518 |
Local variable 'propertyValues' could be declared final | 520 |
Prefer StringBuffer over += for concatenating strings | 523 |
Local variable 'deprecated' could be declared final | 528 |
Local variable 'elementDeprecated' could be declared final | 530 |
Local variable 'hidden' could be declared final | 534 |
Local variable 'readOnly' could be declared final | 537 |
Local variable 'tagAttribute' could be declared final | 540 |
Local variable 'required' could be declared final | 542 |
Parameter 'typeElement' is not assigned and could be declared final | 551 |
Parameter 'attributes' is not assigned and could be declared final | 551 |
Parameter 'properties' is not assigned and could be declared final | 551 |
Parameter 'namespace' is not assigned and could be declared final | 552 |
Local variable 'executableElement' could be declared final | 560 |
Parameter 'element' is not assigned and could be declared final | 606 |
Parameter 'componentTag' is not assigned and could be declared final | 606 |
Parameter 'namespace' is not assigned and could be declared final | 606 |
The method 'addFacets' has a Cyclomatic Complexity of 5. | 606 - 631 |
Local variable 'facets' could be declared final | 607 |
Local variable 'facetElement' could be declared final | 609 |
Avoid instantiating new objects inside loops | 609 |
Local variable 'description' could be declared final | 610 |
Local variable 'facetDescription' could be declared final | 612 |
Avoid instantiating new objects inside loops | 612 |
Local variable 'facetName' could be declared final | 616 |
Avoid instantiating new objects inside loops | 616 |
Local variable 'facetExtension' could be declared final | 619 |
Avoid instantiating new objects inside loops | 619 |
Local variable 'elementAllowedChildComponents' could be declared final | 620 |
Avoid instantiating new objects inside loops | 620 |
Local variable 'allowedChildComponents' could be declared final | 621 |
Prefer StringBuffer over += for concatenating strings | 624 |
The method 'addElement' has a Cyclomatic Complexity of 9. | 633 - 674 |
Parameter 'typeElement' is not assigned and could be declared final | 634 |
Parameter 'components' is not assigned and could be declared final | 634 |
Parameter 'renderer' is not assigned and could be declared final | 634 |
A method/constructor shouldn't explicitly throw java.lang.Exception | 635 |
Local variable 'componentTag' could be declared final | 636 |
Local variable 'componentInfo' could be declared final | 638 |
Local variable 'element' could be declared final | 640 |
Avoid if (x != y) ..; else ..; | 642 - 669 |
Local variable 'attributes' could be declared final | 644 |
Local variable 'properties' could be declared final | 645 |
Parameter 'd1' is not assigned and could be declared final | 649 |
Parameter 'd2' is not assigned and could be declared final | 649 |
Parameter 'd1' is not assigned and could be declared final | 658 |
Parameter 'd2' is not assigned and could be declared final | 658 |
Avoid empty if statements | 667 - 669 |
Avoid empty if statements | 667 - 669 |
Parameter 'document' is not assigned and could be declared final | 676 |
Local variable 'i' could be declared final | 677 |
Local variable 'c' could be declared final | 679 |
org/apache/myfaces/tobago/apt/processor/TaglibGenerator.java
Violation | Line |
---|---|
A high number of imports can indicate a high degree of coupling within an object. | 20 - 677 |
The class 'TaglibGenerator' has a Cyclomatic Complexity of 3 (Highest = 21). | 77 - 677 |
This class has too many methods, consider refactoring it. | 77 - 677 |
The class 'TaglibGenerator' has a Cyclomatic Complexity of 3 (Highest = 21). | 77 - 677 |
Perhaps 'jsfVersion' could be replaced by a local variable. | 85 |
Local variable 'taglibAnnotation' could be declared final | 102 |
Parameter 'packageElement' is not assigned and could be declared final | 109 |
Parameter 'taglibAnnotation' is not assigned and could be declared final | 109 |
Parameter 'type' is not assigned and could be declared final | 109 |
Local variable 'dbf' could be declared final | 112 |
Local variable 'parser' could be declared final | 117 |
Local variable 'document' could be declared final | 118 |
Local variable 'taglib' could be declared final | 120 |
Local variable 'description' could be declared final | 121 |
Local variable 'name' could be declared final | 151 |
Local variable 'resource' could be declared final | 152 |
Local variable 'transFactory' could be declared final | 156 |
Local variable 'transformer' could be declared final | 158 |
Parameter 'document' is not assigned and could be declared final | 166 |
Parameter 'typeElement' is not assigned and could be declared final | 166 |
Parameter 'parent' is not assigned and could be declared final | 166 |
Parameter 'type' is not assigned and could be declared final | 166 |
The method 'appendTag' has a Cyclomatic Complexity of 8. | 166 - 194 |
Local variable 'annotationTag' could be declared final | 168 |
Avoid if (x != y) ..; else ..; | 174 - 183 |
Avoid if (x != y) ..; else ..; | 176 - 183 |
Avoid if (x != y) ..; else ..; | 178 - 183 |
Local variable 'tag' could be declared final | 185 |
Local variable 'deprecatedTag' could be declared final | 189 |
Parameter 'deprecated' is not assigned and could be declared final | 197 |
Parameter 'document' is not assigned and could be declared final | 197 |
Parameter 'typeElement' is not assigned and could be declared final | 197 |
Parameter 'className' is not assigned and could be declared final | 197 |
Parameter 'type' is not assigned and could be declared final | 197 |
Parameter 'annotationTag' is not assigned and could be declared final | 197 |
Local variable 'tagElement' could be declared final | 198 |
Parameter 'attributeName' is not assigned and could be declared final | 204 |
Parameter 'tagName' is not assigned and could be declared final | 212 |
Parameter 'element' is not assigned and could be declared final | 221 |
Parameter 'document' is not assigned and could be declared final | 221 |
Parameter 'typeElement' is not assigned and could be declared final | 221 |
The method 'addDescription' has a Cyclomatic Complexity of 21. | 225 - 307 |
The method addDescription() has an NPath complexity of 83520 | 225 - 307 |
The method 'addDescription' has a Cyclomatic Complexity of 21. | 225 - 307 |
Parameter 'element' is not assigned and could be declared final | 226 |
Parameter 'deprecated' is not assigned and could be declared final | 226 |
Parameter 'document' is not assigned and could be declared final | 226 |
Parameter 'typeElement' is not assigned and could be declared final | 226 |
Local variable 'annotationTag' could be declared final | 236 |
The String literal "</p>" appears 4 times in this file; the first occurrence is on line 242 | 242 |
Local variable 'preliminary' could be declared final | 245 |
Local variable 'index' could be declared final | 256 |
Local variable 'componentTag' could be declared final | 267 |
Local variable 'attributeTag' could be declared final | 271 |
Local variable 'extensionTag' could be declared final | 289 |
Local variable 'baseName' could be declared final | 291 |
Local variable 'declaration' could be declared final | 296 |
Local variable 'baseComponentTag' could be declared final | 298 |
Avoid reassigning parameters such as 'string' | 309 |
Avoid reassigning parameters such as 'string' | 309 |
String.indexOf(char) is faster than String.indexOf(String). | 317 |
Parameter 'name' is not assigned and could be declared final | 327 |
Parameter 'componentTag' is not assigned and could be declared final | 336 |
Local variable 'description' could be declared final | 337 |
Local variable 'facets' could be declared final | 344 |
Parameter 'document' is not assigned and could be declared final | 361 |
Parameter 'typeElement' is not assigned and could be declared final | 361 |
Parameter 'tagElement' is not assigned and could be declared final | 361 |
Parameter 'type' is not assigned and could be declared final | 361 |
The method 'addAttributes' has a Cyclomatic Complexity of 5. | 361 - 374 |
Local variable 'executableElement' could be declared final | 366 |
Parameter 'type' is not assigned and could be declared final | 376 |
Parameter 'd1' is not assigned and could be declared final | 380 |
Parameter 'd2' is not assigned and could be declared final | 380 |
Parameter 'element' is not assigned and could be declared final | 395 |
Parameter 'document' is not assigned and could be declared final | 395 |
Parameter 'tagElement' is not assigned and could be declared final | 395 |
Parameter 'type' is not assigned and could be declared final | 395 |
The method 'addAttribute' has a Cyclomatic Complexity of 5. | 395 - 418 |
Local variable 'tagAttribute' could be declared final | 397 |
Local variable 'simpleName' could be declared final | 399 |
Local variable 'attribute' could be declared final | 401 |
Local variable 'componentTagAttribute' could be declared final | 411 |
Parameter 'text' is not assigned and could be declared final | 420 |
Parameter 'document' is not assigned and could be declared final | 420 |
Parameter 'parent' is not assigned and could be declared final | 420 |
Local variable 'comment' could be declared final | 421 |
Parameter 'text' is not assigned and could be declared final | 425 |
Parameter 'node' is not assigned and could be declared final | 425 |
Parameter 'document' is not assigned and could be declared final | 425 |
Parameter 'parent' is not assigned and could be declared final | 425 |
Local variable 'element' could be declared final | 426 |
Parameter 'text' is not assigned and could be declared final | 431 |
Parameter 'node' is not assigned and could be declared final | 431 |
Parameter 'document' is not assigned and could be declared final | 431 |
Parameter 'parent' is not assigned and could be declared final | 431 |
Local variable 'element' could be declared final | 432 |
The class 'Type' has a Cyclomatic Complexity of 8(Highest = 18). | 437 - 676 |
The class 'Type' has a Cyclomatic Complexity of 8(Highest = 18). | 437 - 676 |
Avoid reassigning parameters such as 'target' | 441 |
Parameter 'name' is not assigned and could be declared final | 441 |
Parameter 'path' is not assigned and could be declared final | 441 |
The String literal "Program error" appears 6 times in this file; the first occurrence is on line 449 | 449 |
Parameter 'document' is not assigned and could be declared final | 453 |
Parameter 'taglibAnnotation' is not assigned and could be declared final | 478 |
Parameter 'document' is not assigned and could be declared final | 478 |
Parameter 'taglib' is not assigned and could be declared final | 478 |
Parameter 'taglibAnnotation' is not assigned and could be declared final | 493 |
Parameter 'document' is not assigned and could be declared final | 493 |
Parameter 'taglib' is not assigned and could be declared final | 493 |
Local variable 'listener' could be declared final | 497 |
The method 'addTagContent' has a Cyclomatic Complexity of 18. | 509 - 584 |
The method 'addTagContent' has a Cyclomatic Complexity of 18. | 509 - 584 |
Parameter 'deprecated' is not assigned and could be declared final | 510 |
Parameter 'document' is not assigned and could be declared final | 510 |
Parameter 'typeElement' is not assigned and could be declared final | 510 |
Parameter 'tagElement' is not assigned and could be declared final | 510 |
Parameter 'className' is not assigned and could be declared final | 511 |
Parameter 'annotationTag' is not assigned and could be declared final | 511 |
A high ratio of statements to labels in a switch statement. Consider refactoring. | 512 - 583 |
Local variable 'tagExtraInfo' could be declared final | 520 |
Local variable 'bodyContent' could be declared final | 525 |
Local variable 'contentDescription' could be declared final | 526 |
Local variable 'componentTag' could be declared final | 545 |
Local variable 'componentElement' could be declared final | 547 |
The String literal "handler-class" appears 4 times in this file; the first occurrence is on line 554 | 554 |
Local variable 'extensionTag' could be declared final | 557 |
Local variable 'componentElement' could be declared final | 559 |
Local variable 'simpleTag' could be declared final | 566 |
Local variable 'validatorTag' could be declared final | 571 |
Local variable 'validatorElement' could be declared final | 573 |
The method 'addAttributeType' has a Cyclomatic Complexity of 18. | 586 - 675 |
The method 'addAttributeType' has a Cyclomatic Complexity of 18. | 586 - 675 |
Parameter 'document' is not assigned and could be declared final | 587 |
Parameter 'componentTagAttribute' is not assigned and could be declared final | 587 |
Parameter 'attribute' is not assigned and could be declared final | 587 |
Parameter 'tagAttribute' is not assigned and could be declared final | 587 |
Parameter 'attributeName' is not assigned and could be declared final | 588 |
A high ratio of statements to labels in a switch statement. Consider refactoring. | 589 - 673 |
Avoid if (x != y) ..; else ..; | 592 - 634 |
Local variable 'deferredMethod' could be declared final | 594 |
Local variable 'signature' could be declared final | 595 |
Local variable 'deferredValue' could be declared final | 605 |
Local variable 'wrapper' could be declared final | 612 |
The String literal "type" appears 4 times in this file; the first occurrence is on line 627 | 627 |
Local variable 'deferredValue' could be declared final | 631 |
Avoid if (x != y) ..; else ..; | 642 - 668 |
Avoid empty if statements | 643 - 645 |
Avoid empty if statements | 643 - 645 |
Local variable 'wrapper' could be declared final | 649 |