PMD Results

The following document contains the results of PMD 4.2.5.

Files

org/apache/myfaces/tobago/ant/sniplet/CodeSniplet.java

ViolationLine
The class 'CodeSniplet' has a Cyclomatic Complexity of 2 (Highest = 11).25 - 109
The class 'CodeSniplet' has a Cyclomatic Complexity of 2 (Highest = 11).25 - 109
Private field 'code' could be made final; it is only initialized in the declaration or constructor.28
Parameter 'id' is not assigned and could be declared final33
Parameter 'lineStart' is not assigned and could be declared final33
Parameter 'fileName' is not assigned and could be declared final33
Parameter 'line' is not assigned and could be declared final40
Parameter 'id' is not assigned and could be declared final48
Parameter 'stripLeadingSpaces' is not assigned and could be declared final52
The method 'getCode' has a Cyclomatic Complexity of 11.52 - 79
The method 'getCode' has a Cyclomatic Complexity of 11.52 - 79
Local variable 's' could be declared final55
Local variable 'c' could be declared final57
Local variable 'sb' could be declared final66
Local variable 's' could be declared final68
Avoid appending characters as strings in StringBuffer.append.75
Parameter 'fileName' is not assigned and could be declared final85
Parameter 'lineStart' is not assigned and could be declared final93
Parameter 'lineEnd' is not assigned and could be declared final101

org/apache/myfaces/tobago/ant/sniplet/CodeSnipletExtractTask.java

ViolationLine
The class 'CodeSnipletExtractTask' has a Cyclomatic Complexity of 2 (Highest = 11).66 - 211
The class 'CodeSnipletExtractTask' has a Cyclomatic Complexity of 2 (Highest = 11).66 - 211
Parameter 'outputFileNamePattern' is not assigned and could be declared final87
Parameter 'outputDir' is not assigned and could be declared final95
Parameter 'fileSet' is not assigned and could be declared final99
Parameter 'stripLeadingSpaces' is not assigned and could be declared final107
The method 'execute' has a Cyclomatic Complexity of 11.111 - 161
The method 'execute' has a Cyclomatic Complexity of 11.111 - 161
Local variable 'fileSet' could be declared final113
Local variable 'dirScanner' could be declared final114
Local variable 'includedFiles' could be declared final116
Local variable 'fileS' could be declared final118
Avoid instantiating new objects inside loops121 - 122
Local variable 'startMatcher' could be declared final125
Local variable 'endMatcher' could be declared final129
Local variable 'codeSniplet' could be declared final139
The String literal "' at line '" appears 4 times in this file; the first occurrence is on line 142142
Avoid instantiating new objects inside loops147
Local variable 'codeSniplet' could be declared final165
Local variable 'fileName' could be declared final166
Local variable 'file' could be declared final167
Avoid instantiating new objects inside loops167
Local variable 'out' could be declared final168
Avoid instantiating new objects inside loops168
Local variable 'code' could be declared final169
Parameter 'id' is not assigned and could be declared final176
Parameter 'fileName' is not assigned and could be declared final176
Parameter 'lineNumber' is not assigned and could be declared final176
Local variable 'codeSniplet' could be declared final178
Local variable 'codeSniplet' could be declared final185
Parameter 'id' is not assigned and could be declared final189
Parameter 'fileName' is not assigned and could be declared final189
Parameter 'lineNumber' is not assigned and could be declared final189
Local variable 'codeSniplet' could be declared final191
Parameter 'line' is not assigned and could be declared final201
Local variable 'codeSniplet' could be declared final203

org/apache/myfaces/tobago/apt/AnnotationUtils.java

ViolationLine
Parameter 'componentTag' is not assigned and could be declared final31
Parameter 'typeElement' is not assigned and could be declared final40

org/apache/myfaces/tobago/apt/generate/ClassInfo.java

ViolationLine
Private field 'className' could be made final; it is only initialized in the declaration or constructor.27
Private field 'packageName' could be made final; it is only initialized in the declaration or constructor.28
Private field 'imports' could be made final; it is only initialized in the declaration or constructor.29
Private field 'interfaces' could be made final; it is only initialized in the declaration or constructor.31
Private field 'sourceClass' could be made final; it is only initialized in the declaration or constructor.32
Parameter 'sourceClass' is not assigned and could be declared final34
Parameter 'qualifiedName' is not assigned and could be declared final34
Parameter 'qualifiedName' is not assigned and could be declared final49
Local variable 'name' could be declared final50
Avoid if (x != y) ..; else ..;51 - 56
Parameter 'qualifiedName' is not assigned and could be declared final67
Parameter 'qualifiedName' is not assigned and could be declared final75
Local variable 'name' could be declared final76
Avoid if (x != y) ..; else ..;77 - 82

org/apache/myfaces/tobago/apt/generate/ClassUtils.java

ViolationLine
A class which only has private constructors should be final25 - 71
Parameter 'qualifiedName' is not assigned and could be declared final44
Local variable 'pos' could be declared final45
Parameter 'qualifiedName' is not assigned and could be declared final52
Local variable 'pos' could be declared final53
Parameter 'qualifiedClassName' is not assigned and could be declared final60
Parameter 'name' is not assigned and could be declared final64
Parameter 'primitive' is not assigned and could be declared final68

org/apache/myfaces/tobago/apt/generate/ComponentInfo.java

ViolationLine
Private field 'nonTransientProperties' could be made final; it is only initialized in the declaration or constructor.30
Private field 'transientProperties' could be made final; it is only initialized in the declaration or constructor.31
Parameter 'declaration' is not assigned and could be declared final39
Parameter 'componentTag' is not assigned and could be declared final39
Parameter 'sourceClass' is not assigned and could be declared final48
Parameter 'rendererType' is not assigned and could be declared final48
Parameter 'qualifiedName' is not assigned and could be declared final48
Parameter 'invokeOnComponent' is not assigned and could be declared final56
Parameter 'propertyInfo' is not assigned and could be declared final60
Avoid if (x != y) ..; else ..;64 - 70
Parameter 'messages' is not assigned and could be declared final101
Parameter 'description' is not assigned and could be declared final105
Parameter 'deprecated' is not assigned and could be declared final113

org/apache/myfaces/tobago/apt/generate/ComponentPropertyInfo.java

ViolationLine
Parameter 'index' is not assigned and could be declared final42
Parameter 'index' is not assigned and could be declared final54

org/apache/myfaces/tobago/apt/generate/Imports.java

ViolationLine
The class 'Imports' has a Cyclomatic Complexity of 2 (Highest = 7).26 - 67
Private field 'imports' could be made final; it is only initialized in the declaration or constructor.28
Document empty constructor32 - 33
Parameter 'packageName' is not assigned and could be declared final35
Avoid reassigning parameters such as 'qualifiedName'39
The method 'addImport' has a Cyclomatic Complexity of 7.39 - 51
These nested if statements could be combined41 - 49
These nested if statements could be combined41 - 49
Local variable 'index' could be declared final42
Deeply nested if..then statements are hard to read43 - 45
Deeply nested if..then statements are hard to read46 - 48
Parameter 'newImports' is not assigned and could be declared final53
Parameter 'qualifiedClassName' is not assigned and could be declared final59

org/apache/myfaces/tobago/apt/generate/PropertyInfo.java

ViolationLine
The class 'PropertyInfo' has a Cyclomatic Complexity of 1 (Highest = 5).24 - 262
This class has too many methods, consider refactoring it.24 - 262
Document empty constructor41 - 42
Parameter 'name' is not assigned and could be declared final44
Parameter 'bodyContent' is not assigned and could be declared final52
Parameter 'literalOnly' is not assigned and could be declared final60
Parameter 'name' is not assigned and could be declared final78
Parameter 'type' is not assigned and could be declared final98
Local variable 'shortType' could be declared final107
Local variable 'type' could be declared final112
Local variable 'index' could be declared final113
Position literals first in String comparisons125
Parameter 'allowdValues' is not assigned and could be declared final135
Parameter 'methodSignature' is not assigned and could be declared final143
Parameter 'defaultValue' is not assigned and could be declared final151
Parameter 'deprecated' is not assigned and could be declared final155
The method 'getDefaultCode' has a Cyclomatic Complexity of 5.163 - 174
Parameter 'defaultCode' is not assigned and could be declared final176
Parameter 'valueExpressionRequired' is not assigned and could be declared final184
Parameter 'methodExpressionRequired' is not assigned and could be declared final192
Parameter 'tagAttribute' is not assigned and could be declared final200
Parameter 'info' is not assigned and could be declared final204
Parameter 'o' is not assigned and could be declared final221
Local variable 'that' could be declared final229
Parameter 'description' is not assigned and could be declared final239
Parameter 'transientValue' is not assigned and could be declared final251
Parameter 'generate' is not assigned and could be declared final259

org/apache/myfaces/tobago/apt/generate/RendererInfo.java

ViolationLine
Parameter 'sourceClass' is not assigned and could be declared final25
Parameter 'qualifiedName' is not assigned and could be declared final25
Parameter 'sourceClass' is not assigned and could be declared final29
Parameter 'rendererType' is not assigned and could be declared final29
Parameter 'qualifiedName' is not assigned and could be declared final29

org/apache/myfaces/tobago/apt/generate/TagInfo.java

ViolationLine
Private field 'properties' could be made final; it is only initialized in the declaration or constructor.27
Parameter 'sourceClass' is not assigned and could be declared final34
Parameter 'rendererType' is not assigned and could be declared final34
Parameter 'qualifiedName' is not assigned and could be declared final34
Parameter 'sourceClass' is not assigned and could be declared final38
Parameter 'qualifiedName' is not assigned and could be declared final38
Parameter 'bodyContent' is not assigned and could be declared final55
Parameter 'componentClass' is not assigned and could be declared final71
Parameter 'componentType' is not assigned and could be declared final84
Parameter 'componentFamily' is not assigned and could be declared final92

org/apache/myfaces/tobago/apt/processor/AbstractGenerator.java

ViolationLine
The class 'AbstractGenerator' has a Cyclomatic Complexity of 2 (Highest = 11).40 - 122
The class 'AbstractGenerator' has a Cyclomatic Complexity of 2 (Highest = 11).40 - 122
Parameter 'roundEnv' is not assigned and could be declared final47
Parameter 'annotations' is not assigned and could be declared final47
The method 'process' has a Cyclomatic Complexity of 11.47 - 95
The method 'process' has a Cyclomatic Complexity of 11.47 - 95
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()56
These nested if statements could be combined68 - 70
These nested if statements could be combined68 - 70
These nested if statements could be combined73 - 75
These nested if statements could be combined73 - 75
Parameter 'd1' is not assigned and could be declared final81
Parameter 'd2' is not assigned and could be declared final81
A method/constructor shouldn't explicitly throw java.lang.Exception99
Parameter 'message' is not assigned and could be declared final101
Parameter 'message' is not assigned and could be declared final105
Parameter 'e' is not assigned and could be declared final109
Do not add empty strings112

org/apache/myfaces/tobago/apt/processor/CheckstyleConfigGenerator.java

ViolationLine
A high number of imports can indicate a high degree of coupling within an object.20 - 283
The class 'CheckstyleConfigGenerator' has a Cyclomatic Complexity of 3 (Highest = 9).70 - 283
This class has too many methods, consider refactoring it.70 - 283
Local variable 'dbf' could be declared final89
Local variable 'parser' could be declared final91
Local variable 'document' could be declared final92
Local variable 'module' could be declared final93
The String literal "name" appears 5 times in this file; the first occurrence is on line 9494
Local variable 'taglibAnnotation' could be declared final97
Parameter 'packageElement' is not assigned and could be declared final107
Parameter 'taglibAnnotation' is not assigned and could be declared final107
Parameter 'module' is not assigned and could be declared final107
Parameter 'document' is not assigned and could be declared final107
Parameter 'document' is not assigned and could be declared final121
Local variable 'transFactory' could be declared final131
Local variable 'transformer' could be declared final133
Parameter 'document' is not assigned and could be declared final143
Parameter 'taglib' is not assigned and could be declared final143
Parameter 'typeElement' is not assigned and could be declared final143
Parameter 'parent' is not assigned and could be declared final143
The method 'appendTag' has a Cyclomatic Complexity of 9.143 - 170
Local variable 'annotationTag' could be declared final145
Avoid if (x != y) ..; else ..;150 - 159
Avoid if (x != y) ..; else ..;152 - 159
Avoid if (x != y) ..; else ..;154 - 159
Parameter 'document' is not assigned and could be declared final172
Parameter 'taglib' is not assigned and could be declared final172
Parameter 'tagName' is not assigned and could be declared final172
Parameter 'parent' is not assigned and could be declared final172
Local variable 'tag' could be declared final177
Parameter 'tagName' is not assigned and could be declared final182
Parameter 'document' is not assigned and could be declared final194
Parameter 'taglib' is not assigned and could be declared final194
Parameter 'tagName' is not assigned and could be declared final194
Parameter 'tagElement' is not assigned and could be declared final194
Parameter 'type' is not assigned and could be declared final194
The method 'addAttributes' has a Cyclomatic Complexity of 5.194 - 207
Local variable 'executableElement' could be declared final199
The method 'addAttribute' has a Cyclomatic Complexity of 6.209 - 232
Parameter 'document' is not assigned and could be declared final210
Parameter 'declaration' is not assigned and could be declared final210
Parameter 'taglib' is not assigned and could be declared final210
Parameter 'tagName' is not assigned and could be declared final210
Parameter 'parent' is not assigned and could be declared final210
Local variable 'tagAttribute' could be declared final211
Local variable 'deprecatedAnnotation' could be declared final212
Local variable 'simpleName' could be declared final214
Local variable 'module' could be declared final225
Parameter 'type' is not assigned and could be declared final234
Parameter 'd1' is not assigned and could be declared final238
Parameter 'd2' is not assigned and could be declared final238
Parameter 'taglibAnnotation' is not assigned and could be declared final245
Parameter 'document' is not assigned and could be declared final245
Parameter 'parent' is not assigned and could be declared final245
Avoid empty if statements248 - 250
Avoid empty if statements248 - 250
Parameter 'messageValue' is not assigned and could be declared final261
Parameter 'document' is not assigned and could be declared final261
Parameter 'formatValue' is not assigned and could be declared final261
Local variable 'module' could be declared final262
Local variable 'format' could be declared final265
Local variable 'message' could be declared final270
Local variable 'severity' could be declared final275

org/apache/myfaces/tobago/apt/processor/ClassesGenerator.java

ViolationLine
A high number of imports can indicate a high degree of coupling within an object.20 - 434
The class 'ClassesGenerator' has a Cyclomatic Complexity of 4 (Highest = 13).75 - 434
This class has too many methods, consider refactoring it.75 - 434
The class 'ClassesGenerator' has a Cyclomatic Complexity of 4 (Highest = 13).75 - 434
Private field 'renderer' could be made final; it is only initialized in the declaration or constructor.83
Perhaps 'jsfVersion' could be replaced by a local variable.85
Perhaps 'tagVersion' could be replaced by a local variable.86
The method 'generate' has a Cyclomatic Complexity of 6.122 - 136
A method/constructor shouldn't explicitly throw java.lang.Exception122
Avoid if (x != y) ..; else ..;124 - 134
Parameter 'declaration' is not assigned and could be declared final138
Local variable 'properties' could be declared final139
Local variable 'className' could be declared final141
Local variable 'tagInfo' could be declared final143
Local variable 'stringTemplate' could be declared final145
Parameter 'declaration' is not assigned and could be declared final153
The method 'createTagOrComponent' has a Cyclomatic Complexity of 12.153 - 242
The method createTagOrComponent() has an NPath complexity of 252153 - 242
The method 'createTagOrComponent' has a Cyclomatic Complexity of 12.153 - 242
Local variable 'componentTag' could be declared final154
Local variable 'tag' could be declared final155
Local variable 'properties' could be declared final156
Local variable 'className' could be declared final159
Local variable 'tagInfo' could be declared final160
Local variable 'stringTemplate' could be declared final175
Local variable 'componentStringTemplate' could be declared final181
Local variable 'componentInfo' could be declared final182
Local variable 'facesClass' could be declared final190 - 191
Local variable 'methodName' could be declared final195 - 197
Position literals first in String comparisons196
Position literals first in String comparisons196
Avoid empty catch blocks205 - 207
Avoid empty catch blocks205 - 207
Parameter 'componentInfo' is not assigned and could be declared final262
Parameter 'info' is not assigned and could be declared final262
Parameter 'declaration' is not assigned and could be declared final277
The method 'createRenderer' has a Cyclomatic Complexity of 6.277 - 301
Local variable 'info' could be declared final289
Local variable 'stringTemplate' could be declared final297
Parameter 'properties' is not assigned and could be declared final303
Parameter 'type' is not assigned and could be declared final303
Parameter 'properties' is not assigned and could be declared final314
Parameter 'type' is not assigned and could be declared final314
Parameter 'interfaces' is not assigned and could be declared final327
Parameter 'properties' is not assigned and could be declared final327
Parameter 'typeMirror' is not assigned and could be declared final333
Parameter 'properties' is not assigned and could be declared final333
Parameter 'declaration' is not assigned and could be declared final339
Parameter 'properties' is not assigned and could be declared final339
The method 'addProperty' has a Cyclomatic Complexity of 13.339 - 388
The method addProperty() has an NPath complexity of 1403339 - 388
The method 'addProperty' has a Cyclomatic Complexity of 13.339 - 388
Local variable 'tagAttribute' could be declared final340
Local variable 'uiComponentTagAttribute' could be declared final341
Local variable 'simpleName' could be declared final343
Local variable 'name' could be declared final345
Local variable 'propertyInfo' could be declared final349
Assigning an Object to null is a code smell. Consider refactoring.374
Assigning an Object to null is a code smell. Consider refactoring.376
Parameter 'element' is not assigned and could be declared final390
Local variable 'index' could be declared final393
Parameter 'declaration' is not assigned and could be declared final405
Parameter 'properties' is not assigned and could be declared final405
The method 'addPropertyForTagOnly' has a Cyclomatic Complexity of 5.405 - 419
Local variable 'tagAttribute' could be declared final406
Local variable 'simpleName' could be declared final408
Local variable 'propertyInfo' could be declared final414
Parameter 'stringTemplate' is not assigned and could be declared final421
Parameter 'info' is not assigned and could be declared final421

org/apache/myfaces/tobago/apt/processor/FacesConfigGenerator.java

ViolationLine
A high number of imports can indicate a high degree of coupling within an object.20 - 691
The class 'FacesConfigGenerator' has a Cyclomatic Complexity of 4 (Highest = 17).79 - 691
This class has too many methods, consider refactoring it.79 - 691
The class 'FacesConfigGenerator' has a Cyclomatic Complexity of 4 (Highest = 17).79 - 691
The method 'generate' has a Cyclomatic Complexity of 17.150 - 257
The method generate() has an NPath complexity of 4321150 - 257
Avoid really long methods.150 - 257
The method 'generate' has a Cyclomatic Complexity of 17.150 - 257
A method/constructor shouldn't explicitly throw java.lang.Exception150
Local variable 'content' could be declared final154
Local variable 'builder' could be declared final155
Parameter 'publicId' is not assigned and could be declared final157
Parameter 'systemId' is not assigned and could be declared final157
Local variable 'stream' could be declared final159 - 160
Local variable 'rootElement' could be declared final173
Local variable 'xsi' could be declared final176
Local variable 'xsi' could be declared final183
Local variable 'namespace' could be declared final189
Local variable 'components' could be declared final193
Local variable 'newComponents' could be declared final195
Local variable 'newRenderer' could be declared final196
Local variable 'newConverters' could be declared final197
Local variable 'newValidators' could be declared final198
Avoid if (x != y) ..; else ..;201 - 207
Avoid if (x != y) ..; else ..;203 - 207
Local variable 'elementsToAdd' could be declared final210
Local variable 'found' could be declared final213
Local variable 'lastIndex' could be declared final220
Local variable 'renderKit' could be declared final224
Local variable 'renderKitId' could be declared final225
Local variable 'renderKitClass' could be declared final228
Local variable 'lastIndex' could be declared final232
Local variable 'lastIndex' could be declared final236
Local variable 'facesConfig' could be declared final247
Local variable 'format' could be declared final248
Local variable 'out' could be declared final250
Parameter 'parent' is not assigned and could be declared final259
Parameter 'namespace' is not assigned and could be declared final259
Parameter 'typeElement' is not assigned and could be declared final266
Parameter 'newConverters' is not assigned and could be declared final266
Parameter 'namespace' is not assigned and could be declared final266
Local variable 'converterAnn' could be declared final267
Local variable 'converter' could be declared final268
Local variable 'converterId' could be declared final270
Local variable 'converterForClass' could be declared final274
Local variable 'converterClass' could be declared final279
Parameter 'typeElement' is not assigned and could be declared final285
Parameter 'newValidators' is not assigned and could be declared final285
Parameter 'namespace' is not assigned and could be declared final285
Local variable 'validatorAnn' could be declared final286
Local variable 'validator' could be declared final287
Local variable 'validatorId' could be declared final289
Local variable 'validatorForClass' could be declared final293
Local variable 'validatorClass' could be declared final298
Parameter 'newElement' is not assigned and could be declared final304
Parameter 'components' is not assigned and could be declared final304
Parameter 'newElement' is not assigned and could be declared final308
Parameter 'components' is not assigned and could be declared final308
Parameter 'tagNames' is not assigned and could be declared final317
Parameter 'rootElement' is not assigned and could be declared final317
Local variable 'index' could be declared final319
Avoid unused private methods such as 'getIndexAfter(org.jdom.Element,String)'.327
Parameter 'tagName' is not assigned and could be declared final327
Parameter 'rootElement' is not assigned and could be declared final327
Avoid unused private methods such as 'getIndexAfter(org.jdom.Element,String)'.327
Local variable 'components' could be declared final328
Parameter 'element2' is not assigned and could be declared final335
Parameter 'element1' is not assigned and could be declared final335
The method 'equals' has a Cyclomatic Complexity of 5.335 - 345
Local variable 'namespace' could be declared final336
These nested if statements could be combined338 - 342
These nested if statements could be combined338 - 342
These nested if statements could be combined339 - 341
These nested if statements could be combined339 - 341
Parameter 'componentInfo' is not assigned and could be declared final348
Parameter 'componentTag' is not assigned and could be declared final348
Parameter 'namespace' is not assigned and could be declared final348
Local variable 'element' could be declared final350
Local variable 'elementDisplayName' could be declared final351
Local variable 'elementType' could be declared final354
Local variable 'elementClass' could be declared final357
Parameter 'componentInfo' is not assigned and could be declared final365
Parameter 'componentTag' is not assigned and could be declared final365
Parameter 'renderer' is not assigned and could be declared final365
Parameter 'namespace' is not assigned and could be declared final365
Local variable 'rendererType' could be declared final367
Local variable 'element' could be declared final369
Position literals first in String comparisons371
Local variable 'elementDisplayName' could be declared final374
Local variable 'elementComponentFamily' could be declared final377
Local variable 'elementType' could be declared final380
Local variable 'elementClass' could be declared final383
Local variable 'className' could be declared final384
Parameter 'typeElement' is not assigned and could be declared final393
Parameter 'uiComponentTag' is not assigned and could be declared final393
Parameter 'namespace' is not assigned and could be declared final394
Local variable 'elementExtension' could be declared final395
Local variable 'elementAllowedChildComponents' could be declared final396
Local variable 'allowedChildComponents' could be declared final397
Prefer StringBuffer over += for concatenating strings400
Local variable 'elementCategory' could be declared final404
Local variable 'deprecated' could be declared final407
Local variable 'elementDeprecated' could be declared final409
Local variable 'elementHidden' could be declared final413
The method 'addAttribute' has a Cyclomatic Complexity of 6.420 - 476
Parameter 'attributes' is not assigned and could be declared final421
Parameter 'properties' is not assigned and could be declared final421
Parameter 'executableElement' is not assigned and could be declared final421
Parameter 'namespace' is not assigned and could be declared final422
Local variable 'componentAttribute' could be declared final423
Local variable 'simpleName' could be declared final425
Local variable 'name' could be declared final427
Local variable 'attribute' could be declared final429
Local variable 'attributeName' could be declared final430
Local variable 'attributeClass' could be declared final431
Local variable 'defaultValue' could be declared final441
Local variable 'property' could be declared final451
Local variable 'propertyName' could be declared final452
Local variable 'propertyClass' could be declared final453
Local variable 'defaultValue' could be declared final463
Parameter 'attributeClass' is not assigned and could be declared final478
Parameter 'componentAttribute' is not assigned and could be declared final478
The method 'addClass' has a Cyclomatic Complexity of 5.478 - 492
Parameter 'element' is not assigned and could be declared final494
Parameter 'attribute' is not assigned and could be declared final494
Parameter 'namespace' is not assigned and could be declared final494
Local variable 'index' could be declared final497
Local variable 'description' could be declared final503
The method 'createPropertyOrAttributeExtension' has a Cyclomatic Complexity of 5.510 - 548
Parameter 'extensionType' is not assigned and could be declared final511
Parameter 'uiComponentTagAttribute' is not assigned and could be declared final511
Parameter 'executableElement' is not assigned and could be declared final511
Parameter 'namespace' is not assigned and could be declared final512
Local variable 'extensionElement' could be declared final514
Local variable 'valueExpression' could be declared final515
Local variable 'allowedValues' could be declared final518
Local variable 'propertyValues' could be declared final520
Prefer StringBuffer over += for concatenating strings523
Local variable 'deprecated' could be declared final528
Local variable 'elementDeprecated' could be declared final530
Local variable 'hidden' could be declared final534
Local variable 'readOnly' could be declared final537
Local variable 'tagAttribute' could be declared final540
Local variable 'required' could be declared final542
Parameter 'typeElement' is not assigned and could be declared final551
Parameter 'attributes' is not assigned and could be declared final551
Parameter 'properties' is not assigned and could be declared final551
Parameter 'namespace' is not assigned and could be declared final552
Local variable 'executableElement' could be declared final560
Parameter 'element' is not assigned and could be declared final606
Parameter 'componentTag' is not assigned and could be declared final606
Parameter 'namespace' is not assigned and could be declared final606
The method 'addFacets' has a Cyclomatic Complexity of 5.606 - 631
Local variable 'facets' could be declared final607
Local variable 'facetElement' could be declared final609
Avoid instantiating new objects inside loops609
Local variable 'description' could be declared final610
Local variable 'facetDescription' could be declared final612
Avoid instantiating new objects inside loops612
Local variable 'facetName' could be declared final616
Avoid instantiating new objects inside loops616
Local variable 'facetExtension' could be declared final619
Avoid instantiating new objects inside loops619
Local variable 'elementAllowedChildComponents' could be declared final620
Avoid instantiating new objects inside loops620
Local variable 'allowedChildComponents' could be declared final621
Prefer StringBuffer over += for concatenating strings624
The method 'addElement' has a Cyclomatic Complexity of 9.633 - 674
Parameter 'typeElement' is not assigned and could be declared final634
Parameter 'components' is not assigned and could be declared final634
Parameter 'renderer' is not assigned and could be declared final634
A method/constructor shouldn't explicitly throw java.lang.Exception635
Local variable 'componentTag' could be declared final636
Local variable 'componentInfo' could be declared final638
Local variable 'element' could be declared final640
Avoid if (x != y) ..; else ..;642 - 669
Local variable 'attributes' could be declared final644
Local variable 'properties' could be declared final645
Parameter 'd1' is not assigned and could be declared final649
Parameter 'd2' is not assigned and could be declared final649
Parameter 'd1' is not assigned and could be declared final658
Parameter 'd2' is not assigned and could be declared final658
Avoid empty if statements667 - 669
Avoid empty if statements667 - 669
Parameter 'document' is not assigned and could be declared final676
Local variable 'i' could be declared final677
Local variable 'c' could be declared final679

org/apache/myfaces/tobago/apt/processor/TaglibGenerator.java

ViolationLine
A high number of imports can indicate a high degree of coupling within an object.20 - 677
The class 'TaglibGenerator' has a Cyclomatic Complexity of 3 (Highest = 21).77 - 677
This class has too many methods, consider refactoring it.77 - 677
The class 'TaglibGenerator' has a Cyclomatic Complexity of 3 (Highest = 21).77 - 677
Perhaps 'jsfVersion' could be replaced by a local variable.85
Local variable 'taglibAnnotation' could be declared final102
Parameter 'packageElement' is not assigned and could be declared final109
Parameter 'taglibAnnotation' is not assigned and could be declared final109
Parameter 'type' is not assigned and could be declared final109
Local variable 'dbf' could be declared final112
Local variable 'parser' could be declared final117
Local variable 'document' could be declared final118
Local variable 'taglib' could be declared final120
Local variable 'description' could be declared final121
Local variable 'name' could be declared final151
Local variable 'resource' could be declared final152
Local variable 'transFactory' could be declared final156
Local variable 'transformer' could be declared final158
Parameter 'document' is not assigned and could be declared final166
Parameter 'typeElement' is not assigned and could be declared final166
Parameter 'parent' is not assigned and could be declared final166
Parameter 'type' is not assigned and could be declared final166
The method 'appendTag' has a Cyclomatic Complexity of 8.166 - 194
Local variable 'annotationTag' could be declared final168
Avoid if (x != y) ..; else ..;174 - 183
Avoid if (x != y) ..; else ..;176 - 183
Avoid if (x != y) ..; else ..;178 - 183
Local variable 'tag' could be declared final185
Local variable 'deprecatedTag' could be declared final189
Parameter 'deprecated' is not assigned and could be declared final197
Parameter 'document' is not assigned and could be declared final197
Parameter 'typeElement' is not assigned and could be declared final197
Parameter 'className' is not assigned and could be declared final197
Parameter 'type' is not assigned and could be declared final197
Parameter 'annotationTag' is not assigned and could be declared final197
Local variable 'tagElement' could be declared final198
Parameter 'attributeName' is not assigned and could be declared final204
Parameter 'tagName' is not assigned and could be declared final212
Parameter 'element' is not assigned and could be declared final221
Parameter 'document' is not assigned and could be declared final221
Parameter 'typeElement' is not assigned and could be declared final221
The method 'addDescription' has a Cyclomatic Complexity of 21.225 - 307
The method addDescription() has an NPath complexity of 83520225 - 307
The method 'addDescription' has a Cyclomatic Complexity of 21.225 - 307
Parameter 'element' is not assigned and could be declared final226
Parameter 'deprecated' is not assigned and could be declared final226
Parameter 'document' is not assigned and could be declared final226
Parameter 'typeElement' is not assigned and could be declared final226
Local variable 'annotationTag' could be declared final236
The String literal "</p>" appears 4 times in this file; the first occurrence is on line 242242
Local variable 'preliminary' could be declared final245
Local variable 'index' could be declared final256
Local variable 'componentTag' could be declared final267
Local variable 'attributeTag' could be declared final271
Local variable 'extensionTag' could be declared final289
Local variable 'baseName' could be declared final291
Local variable 'declaration' could be declared final296
Local variable 'baseComponentTag' could be declared final298
Avoid reassigning parameters such as 'string'309
Avoid reassigning parameters such as 'string'309
String.indexOf(char) is faster than String.indexOf(String).317
Parameter 'name' is not assigned and could be declared final327
Parameter 'componentTag' is not assigned and could be declared final336
Local variable 'description' could be declared final337
Local variable 'facets' could be declared final344
Parameter 'document' is not assigned and could be declared final361
Parameter 'typeElement' is not assigned and could be declared final361
Parameter 'tagElement' is not assigned and could be declared final361
Parameter 'type' is not assigned and could be declared final361
The method 'addAttributes' has a Cyclomatic Complexity of 5.361 - 374
Local variable 'executableElement' could be declared final366
Parameter 'type' is not assigned and could be declared final376
Parameter 'd1' is not assigned and could be declared final380
Parameter 'd2' is not assigned and could be declared final380
Parameter 'element' is not assigned and could be declared final395
Parameter 'document' is not assigned and could be declared final395
Parameter 'tagElement' is not assigned and could be declared final395
Parameter 'type' is not assigned and could be declared final395
The method 'addAttribute' has a Cyclomatic Complexity of 5.395 - 418
Local variable 'tagAttribute' could be declared final397
Local variable 'simpleName' could be declared final399
Local variable 'attribute' could be declared final401
Local variable 'componentTagAttribute' could be declared final411
Parameter 'text' is not assigned and could be declared final420
Parameter 'document' is not assigned and could be declared final420
Parameter 'parent' is not assigned and could be declared final420
Local variable 'comment' could be declared final421
Parameter 'text' is not assigned and could be declared final425
Parameter 'node' is not assigned and could be declared final425
Parameter 'document' is not assigned and could be declared final425
Parameter 'parent' is not assigned and could be declared final425
Local variable 'element' could be declared final426
Parameter 'text' is not assigned and could be declared final431
Parameter 'node' is not assigned and could be declared final431
Parameter 'document' is not assigned and could be declared final431
Parameter 'parent' is not assigned and could be declared final431
Local variable 'element' could be declared final432
The class 'Type' has a Cyclomatic Complexity of 8(Highest = 18).437 - 676
The class 'Type' has a Cyclomatic Complexity of 8(Highest = 18).437 - 676
Avoid reassigning parameters such as 'target'441
Parameter 'name' is not assigned and could be declared final441
Parameter 'path' is not assigned and could be declared final441
The String literal "Program error" appears 6 times in this file; the first occurrence is on line 449449
Parameter 'document' is not assigned and could be declared final453
Parameter 'taglibAnnotation' is not assigned and could be declared final478
Parameter 'document' is not assigned and could be declared final478
Parameter 'taglib' is not assigned and could be declared final478
Parameter 'taglibAnnotation' is not assigned and could be declared final493
Parameter 'document' is not assigned and could be declared final493
Parameter 'taglib' is not assigned and could be declared final493
Local variable 'listener' could be declared final497
The method 'addTagContent' has a Cyclomatic Complexity of 18.509 - 584
The method 'addTagContent' has a Cyclomatic Complexity of 18.509 - 584
Parameter 'deprecated' is not assigned and could be declared final510
Parameter 'document' is not assigned and could be declared final510
Parameter 'typeElement' is not assigned and could be declared final510
Parameter 'tagElement' is not assigned and could be declared final510
Parameter 'className' is not assigned and could be declared final511
Parameter 'annotationTag' is not assigned and could be declared final511
A high ratio of statements to labels in a switch statement. Consider refactoring.512 - 583
Local variable 'tagExtraInfo' could be declared final520
Local variable 'bodyContent' could be declared final525
Local variable 'contentDescription' could be declared final526
Local variable 'componentTag' could be declared final545
Local variable 'componentElement' could be declared final547
The String literal "handler-class" appears 4 times in this file; the first occurrence is on line 554554
Local variable 'extensionTag' could be declared final557
Local variable 'componentElement' could be declared final559
Local variable 'simpleTag' could be declared final566
Local variable 'validatorTag' could be declared final571
Local variable 'validatorElement' could be declared final573
The method 'addAttributeType' has a Cyclomatic Complexity of 18.586 - 675
The method 'addAttributeType' has a Cyclomatic Complexity of 18.586 - 675
Parameter 'document' is not assigned and could be declared final587
Parameter 'componentTagAttribute' is not assigned and could be declared final587
Parameter 'attribute' is not assigned and could be declared final587
Parameter 'tagAttribute' is not assigned and could be declared final587
Parameter 'attributeName' is not assigned and could be declared final588
A high ratio of statements to labels in a switch statement. Consider refactoring.589 - 673
Avoid if (x != y) ..; else ..;592 - 634
Local variable 'deferredMethod' could be declared final594
Local variable 'signature' could be declared final595
Local variable 'deferredValue' could be declared final605
Local variable 'wrapper' could be declared final612
The String literal "type" appears 4 times in this file; the first occurrence is on line 627627
Local variable 'deferredValue' could be declared final631
Avoid if (x != y) ..; else ..;642 - 668
Avoid empty if statements643 - 645
Avoid empty if statements643 - 645
Local variable 'wrapper' could be declared final649