PMD Results

The following document contains the results of PMD

Files

org/apache/myfaces/tobago/maven/plugin/PackThemeMojo.java

Violation Line
Avoid unused private fields such as 'archive' 107
Private field could be made final. It is only initialized in the declaration or constructor. 107
Avoid unused private fields such as 'archive' 107
Local variable could be declared final 119
Parameter 'jarFile' is not assigned and could be declared final 132
Parameter 'zipDirectory' is not assigned and could be declared final 143
Parameter 'sourceDirectory' is not assigned and could be declared final 158
Parameter 'webappDirectory' is not assigned and could be declared final 158
Local variable could be declared final 163
Avoid instantiating new objects inside loops 165
Avoid instantiating new objects inside loops 166
Parameter 'project' is not assigned and could be declared final 172
Parameter 'webappDirectory' is not assigned and could be declared final 172
Local variable could be declared final 176
Local variable could be declared final 181
Local variable could be declared final 189

org/apache/myfaces/tobago/maven/plugin/UnPackThemeMojo.java

Violation Line
The class 'UnPackThemeMojo' has a Cyclomatic Complexity of 5 (Highest = 8). 44 - 164
Avoid unused private fields such as 'pluginArtifacts' 73
Avoid unused private fields such as 'pluginArtifacts' 73
Parameter 'jarFile' is not assigned and could be declared final 75
The method 'findThemeDescriptor' has a Cyclomatic Complexity of 5. 75 - 102
Local variable could be declared final 80
Local variable could be declared final 84
Position literals first in String comparisons 85
Avoid empty catch blocks 95 - 97
Avoid empty catch blocks 95 - 97
Must handle exceptions 95 - 97
The method 'execute' has a Cyclomatic Complexity of 8. 104 - 148
Local variable could be declared final 106
Local variable could be declared final 111
Local variable could be declared final 117
Local variable could be declared final 119
Avoid instantiating new objects inside loops 119
Avoid if (x != y) ..; else ..; 121 - 126
Local variable could be declared final 128
Local variable could be declared final 131
Local variable could be declared final 134
Avoid instantiating new objects inside loops 134
Local variable could be declared final 135
Avoid instantiating new objects inside loops 135
Parameter 'file' is not assigned and could be declared final 150
Parameter 'location' is not assigned and could be declared final 150
Local variable could be declared final 152
Local variable could be declared final 154

org/apache/myfaces/tobago/maven/plugin/AbstractThemeMojo.java

Violation Line
This abstract class does not have any abstract methods 30 - 53
Parameter 'sourceDir' is not assigned and could be declared final 44
Local variable could be declared final 45