PMD Results
The following document contains the results of PMD 4.2.5.
Files
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/ActionRenderer.java
| Violation | Line |
|---|---|
| Document empty constructor | 27 - 28 |
| Avoid unnecessary constructors - the compiler will generate these for you | 27 - 28 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/BoxRenderer.java
| Violation | Line |
|---|---|
| The class 'BoxRenderer' has a Cyclomatic Complexity of 4 (Highest = 9). | 43 - 127 |
| Parameter 'component' is not assigned and could be declared final | 46 |
| Parameter 'facesContext' is not assigned and could be declared final | 46 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 9. | 46 - 114 |
| Local variable 'box' could be declared final | 48 |
| Local variable 'writer' could be declared final | 49 |
| Local variable 'label' could be declared final | 51 |
| Local variable 'labelString' could be declared final | 52 |
| Local variable 'toolbar' could be declared final | 53 |
| Local variable 'style' could be declared final | 54 |
| Local variable 'padding' could be declared final | 56 |
| Local variable 'title' could be declared final | 63 |
| Avoid if (x != y) ..; else ..; | 74 - 78 |
| Local variable 'contentStyle' could be declared final | 82 |
| Parameter 'component' is not assigned and could be declared final | 117 |
| Parameter 'facesContext' is not assigned and could be declared final | 117 |
| Local variable 'writer' could be declared final | 118 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/BoxToolBarRenderer.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 31 |
| Parameter 'component' is not assigned and could be declared final | 41 |
| Parameter 'toolBar' is not assigned and could be declared final | 51 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/ButtonRenderer.java
| Violation | Line |
|---|---|
| The class 'ButtonRenderer' has a Cyclomatic Complexity of 8 (Highest = 12). | 51 - 147 |
| The class 'ButtonRenderer' has a Cyclomatic Complexity of 8 (Highest = 12). | 51 - 147 |
| Parameter 'component' is not assigned and could be declared final | 55 |
| Parameter 'facesContext' is not assigned and could be declared final | 55 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 12. | 55 - 127 |
| The method encodeEnd() has an NPath complexity of 880 | 55 - 127 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 12. | 55 - 127 |
| Local variable 'style' could be declared final | 88 |
| Avoid empty if statements | 100 - 102 |
| Avoid empty if statements | 100 - 102 |
| Local variable 'tip' could be declared final | 107 |
| Avoid if (x != y) ..; else ..; | 108 |
| Parameter 'component' is not assigned and could be declared final | 130 |
| Parameter 'facesContext' is not assigned and could be declared final | 130 |
| Local variable 'button' could be declared final | 132 |
| Local variable 'image' could be declared final | 134 |
| Local variable 'label' could be declared final | 138 |
| Local variable 'padding' could be declared final | 141 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/CalendarRenderer.java
| Violation | Line |
|---|---|
| The class 'CalendarRenderer' has a Cyclomatic Complexity of 6 (Highest = 8). | 47 - 206 |
| Parameter 'component' is not assigned and could be declared final | 50 |
| Parameter 'facesContext' is not assigned and could be declared final | 50 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 8. | 50 - 189 |
| Avoid really long methods. | 50 - 189 |
| Local variable 'output' could be declared final | 52 |
| Local variable 'id' could be declared final | 53 |
| Local variable 'locale' could be declared final | 55 |
| Local variable 'value' could be declared final | 57 |
| Local variable 'model' could be declared final | 67 |
| Local variable 'writer' could be declared final | 70 |
| Local variable 'style' could be declared final | 76 |
| Local variable 'dateInputId' could be declared final | 78 |
| The String literal "header" appears 5 times in this file; the first occurrence is on line 94 | 94 |
| Local variable 'dayInWeekFormat' could be declared final | 149 |
| Local variable 'date' could be declared final | 151 |
| Local variable 'date' could be declared final | 172 |
| Local variable 'dayDescription' could be declared final | 173 |
| Parameter 'locale' is not assigned and could be declared final | 191 |
| Local variable 'dateFormat' could be declared final | 192 |
| Local variable 'buffer' could be declared final | 193 |
| Local variable 'calendar' could be declared final | 194 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/ColumnRenderer.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 39 |
| Parameter 'facesContext' is not assigned and could be declared final | 39 |
| Parameter 'column' is not assigned and could be declared final | 56 |
| Parameter 'component' is not assigned and could be declared final | 71 |
| Parameter 'facesContext' is not assigned and could be declared final | 71 |
| Local variable 'dropDownMenu' could be declared final | 72 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/DatePickerRenderer.java
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 244 |
| The class 'DatePickerRenderer' has a Cyclomatic Complexity of 4 (Highest = 6). | 54 - 244 |
| Parameter 'component' is not assigned and could be declared final | 59 |
| Parameter 'facesContext' is not assigned and could be declared final | 59 |
| Parameter 'parent' is not assigned and could be declared final | 59 |
| Avoid really long methods. | 59 - 160 |
| Avoid if (x != y) ..; else ..; | 69 |
| Parameter 'component' is not assigned and could be declared final | 163 |
| Parameter 'facesContext' is not assigned and could be declared final | 163 |
| Local variable 'picker' could be declared final | 164 |
| Parameter 'component' is not assigned and could be declared final | 177 |
| Parameter 'facesContext' is not assigned and could be declared final | 177 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 6. | 177 - 213 |
| Local variable 'picker' could be declared final | 178 |
| Local variable 'dateInput' could be declared final | 179 |
| Avoid if (x != y) ..; else ..; | 186 - 195 |
| Avoid if (x != y) ..; else ..; | 190 - 194 |
| Local variable 'popup' could be declared final | 196 |
| Local variable 'converter' could be declared final | 198 |
| Avoid empty if statements | 202 - 205 |
| Avoid empty if statements | 202 - 205 |
| Parameter 'facesContext' is not assigned and could be declared final | 215 |
| Parameter 'popup' is not assigned and could be declared final | 215 |
| Parameter 'converterPattern' is not assigned and could be declared final | 215 |
| The method 'applyConverterPattern' has a Cyclomatic Complexity of 5. | 215 - 232 |
| Local variable 'box' could be declared final | 216 |
| Local variable 'timePanel' could be declared final | 217 |
| Local variable 'time' could be declared final | 219 |
| Local variable 'dateTimeConverter' could be declared final | 220 - 221 |
| Parameter 'component' is not assigned and could be declared final | 235 |
| Parameter 'facesContext' is not assigned and could be declared final | 235 |
| Local variable 'link' could be declared final | 236 |
| Local variable 'dateInput' could be declared final | 237 |
| Avoid if (x != y) ..; else ..; | 238 - 242 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/DateRenderer.java
| Violation | Line |
|---|---|
| Parameter 'input' is not assigned and could be declared final | 40 |
| Parameter 'facesContext' is not assigned and could be declared final | 40 |
| Parameter 'writer' is not assigned and could be declared final | 40 |
| Local variable 'help' could be declared final | 44 |
| Local variable 'converter' could be declared final | 46 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/FileRenderer.java
| Violation | Line |
|---|---|
| The class 'FileRenderer' has a Cyclomatic Complexity of 3 (Highest = 7). | 45 - 147 |
| Parameter 'component' is not assigned and could be declared final | 49 |
| Parameter 'facesContext' is not assigned and could be declared final | 49 |
| Parameter 'component' is not assigned and could be declared final | 58 |
| Parameter 'facesContext' is not assigned and could be declared final | 58 |
| The method 'decode' has a Cyclomatic Complexity of 7. | 58 - 94 |
| Local variable 'input' could be declared final | 63 |
| Local variable 'requestObject' could be declared final | 66 |
| Local variable 'wrappedRequest' could be declared final | 70 - 71 |
| Local variable 'item' could be declared final | 84 |
| Parameter 'component' is not assigned and could be declared final | 96 |
| Parameter 'facesContext' is not assigned and could be declared final | 96 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/FlowLayoutRenderer.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 44 |
| Parameter 'facesContext' is not assigned and could be declared final | 44 |
| Local variable 'writer' could be declared final | 45 |
| Local variable 'layout' could be declared final | 46 |
| Local variable 'style' could be declared final | 49 |
| Parameter 'component' is not assigned and could be declared final | 59 |
| Parameter 'facesContext' is not assigned and could be declared final | 59 |
| Local variable 'container' could be declared final | 60 |
| Parameter 'component' is not assigned and could be declared final | 68 |
| Parameter 'facesContext' is not assigned and could be declared final | 68 |
| Local variable 'writer' could be declared final | 69 |
| Parameter 'component' is not assigned and could be declared final | 73 |
| Parameter 'facesContext' is not assigned and could be declared final | 73 |
| Parameter 'component' is not assigned and could be declared final | 77 |
| Parameter 'facesContext' is not assigned and could be declared final | 77 |
| Parameter 'component' is not assigned and could be declared final | 81 |
| Parameter 'facesContext' is not assigned and could be declared final | 81 |
| Local variable 'parent' could be declared final | 82 |
| Parameter 'component' is not assigned and could be declared final | 86 |
| Parameter 'facesContext' is not assigned and could be declared final | 86 |
| Local variable 'parent' could be declared final | 87 |
| Parameter 'component' is not assigned and could be declared final | 91 |
| Parameter 'facesContext' is not assigned and could be declared final | 91 |
| Local variable 'parent' could be declared final | 92 |
| Parameter 'component' is not assigned and could be declared final | 96 |
| Parameter 'facesContext' is not assigned and could be declared final | 96 |
| Local variable 'parent' could be declared final | 97 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/FormRenderer.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 31 |
| Parameter 'facesContext' is not assigned and could be declared final | 31 |
| Local variable 'form' could be declared final | 32 |
| Local variable 'actionId' could be declared final | 33 |
| Local variable 'clientId' could be declared final | 34 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/GridLayoutRenderer.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 39 |
| Avoid unused private fields such as 'LOG'. | 39 |
| Parameter 'component' is not assigned and could be declared final | 42 |
| Parameter 'facesContext' is not assigned and could be declared final | 42 |
| Parameter 'component' is not assigned and could be declared final | 50 |
| Parameter 'facesContext' is not assigned and could be declared final | 50 |
| Local variable 'container' could be declared final | 51 |
| Parameter 'facesContext' is not assigned and could be declared final | 60 |
| Parameter 'component' is not assigned and could be declared final | 61 |
| Parameter 'component' is not assigned and could be declared final | 66 |
| Parameter 'facesContext' is not assigned and could be declared final | 66 |
| Parameter 'component' is not assigned and could be declared final | 70 |
| Parameter 'facesContext' is not assigned and could be declared final | 70 |
| Parameter 'component' is not assigned and could be declared final | 74 |
| Parameter 'facesContext' is not assigned and could be declared final | 74 |
| Parameter 'component' is not assigned and could be declared final | 78 |
| Parameter 'facesContext' is not assigned and could be declared final | 78 |
| Parameter 'component' is not assigned and could be declared final | 82 |
| Parameter 'facesContext' is not assigned and could be declared final | 82 |
| Parameter 'component' is not assigned and could be declared final | 86 |
| Parameter 'facesContext' is not assigned and could be declared final | 86 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/HiddenRenderer.java
| Violation | Line |
|---|---|
| The class 'HiddenRenderer' has a Cyclomatic Complexity of 5 (Highest = 4). | 38 - 63 |
| Parameter 'component' is not assigned and could be declared final | 40 |
| Parameter 'facesContext' is not assigned and could be declared final | 40 |
| Local variable 'writer' could be declared final | 45 |
| Local variable 'style' could be declared final | 50 |
| Avoid if (x != y) ..; else ..; | 60 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/ImageRenderer.java
| Violation | Line |
|---|---|
| The class 'ImageRenderer' has a Cyclomatic Complexity of 3 (Highest = 8). | 40 - 111 |
| Parameter 'component' is not assigned and could be declared final | 44 |
| Parameter 'facesContext' is not assigned and could be declared final | 44 |
| Parameter 'component' is not assigned and could be declared final | 49 |
| Parameter 'facesContext' is not assigned and could be declared final | 49 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 8. | 49 - 95 |
| Local variable 'writer' could be declared final | 51 |
| Local variable 'image' could be declared final | 53 |
| Avoid empty if statements | 57 - 59 |
| Avoid empty if statements | 57 - 59 |
| Assigning an Object to null is a code smell. Consider refactoring. | 60 |
| Local variable 'style' could be declared final | 90 |
| Avoid unused private methods such as 'createSrc(String,String)'. | 97 |
| Parameter 'src' is not assigned and could be declared final | 97 |
| Parameter 'ext' is not assigned and could be declared final | 97 |
| Avoid unused private methods such as 'createSrc(String,String)'. | 97 |
| Local variable 'dot' could be declared final | 98 |
| Parameter 'graphic' is not assigned and could be declared final | 107 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/InRenderer.java
| Violation | Line |
|---|---|
| The class 'InRenderer' has a Cyclomatic Complexity of 7 (Highest = 16). | 45 - 145 |
| The class 'InRenderer' has a Cyclomatic Complexity of 7 (Highest = 16). | 45 - 145 |
| Parameter 'component' is not assigned and could be declared final | 50 |
| Parameter 'facesContext' is not assigned and could be declared final | 50 |
| Local variable 'clientId' could be declared final | 52 |
| Parameter 'component' is not assigned and could be declared final | 60 |
| Parameter 'facesContext' is not assigned and could be declared final | 60 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 16. | 60 - 140 |
| The method encodeEnd() has an NPath complexity of 34560 | 60 - 140 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 16. | 60 - 140 |
| Local variable 'pattern' could be declared final | 90 |
| Local variable 'lengthValidator' could be declared final | 93 |
| Local variable 'tabIndex' could be declared final | 109 |
| Local variable 'style' could be declared final | 113 |
| Local variable 'required' could be declared final | 134 |
| Document empty method | 143 - 144 |
| Parameter 'input' is not assigned and could be declared final | 143 |
| Parameter 'facesContext' is not assigned and could be declared final | 143 |
| Parameter 'writer' is not assigned and could be declared final | 143 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/LabelRenderer.java
| Violation | Line |
|---|---|
| The class 'LabelRenderer' has a Cyclomatic Complexity of 4 (Highest = 6). | 42 - 108 |
| Parameter 'component' is not assigned and could be declared final | 47 |
| Parameter 'facesContext' is not assigned and could be declared final | 47 |
| Parameter 'component' is not assigned and could be declared final | 62 |
| Parameter 'facesContext' is not assigned and could be declared final | 62 |
| Local variable 'label' could be declared final | 64 |
| Local variable 'writer' could be declared final | 65 |
| Local variable 'forValue' could be declared final | 67 |
| Local variable 'clientId' could be declared final | 69 |
| Parameter 'facesContext' is not assigned and could be declared final | 90 |
| Parameter 'label' is not assigned and could be declared final | 90 |
| Parameter 'writer' is not assigned and could be declared final | 90 |
| The method 'encodeTextContent' has a Cyclomatic Complexity of 6. | 90 - 107 |
| Local variable 'clientId' could be declared final | 92 |
| Local variable 'key' could be declared final | 93 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/LinkRenderer.java
| Violation | Line |
|---|---|
| The class 'LinkRenderer' has a Cyclomatic Complexity of 7 (Highest = 14). | 49 - 163 |
| The class 'LinkRenderer' has a Cyclomatic Complexity of 7 (Highest = 14). | 49 - 163 |
| Parameter 'component' is not assigned and could be declared final | 53 |
| Parameter 'facesContext' is not assigned and could be declared final | 53 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 14. | 53 - 131 |
| The method encodeBegin() has an NPath complexity of 1575 | 53 - 131 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 14. | 53 - 131 |
| Local variable 'label' could be declared final | 63 |
| Local variable 'style' could be declared final | 86 |
| Avoid empty if statements | 98 - 100 |
| Avoid empty if statements | 98 - 100 |
| Local variable 'tip' could be declared final | 107 |
| Avoid if (x != y) ..; else ..; | 108 |
| These nested if statements could be combined | 124 - 127 |
| These nested if statements could be combined | 124 - 127 |
| Parameter 'component' is not assigned and could be declared final | 133 |
| Parameter 'facesContext' is not assigned and could be declared final | 133 |
| Local variable 'link' could be declared final | 134 |
| Local variable 'writer' could be declared final | 135 |
| Parameter 'component' is not assigned and could be declared final | 144 |
| Parameter 'facesContext' is not assigned and could be declared final | 144 |
| The method 'getPreferredWidth' has a Cyclomatic Complexity of 5. | 144 - 162 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/MenuBarRenderer.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 37 |
| Parameter 'facesContext' is not assigned and could be declared final | 37 |
| Local variable 'menuBar' could be declared final | 39 |
| Local variable 'writer' could be declared final | 40 |
| Local variable 'style' could be declared final | 46 |
| Parameter 'component' is not assigned and could be declared final | 51 |
| Parameter 'facesContext' is not assigned and could be declared final | 51 |
| Local variable 'writer' could be declared final | 52 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/MenuCommandRenderer.java
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 221 |
| The class 'MenuCommandRenderer' has a Cyclomatic Complexity of 7 (Highest = 20). | 61 - 221 |
| The class 'MenuCommandRenderer' has a Cyclomatic Complexity of 7 (Highest = 20). | 61 - 221 |
| Parameter 'component' is not assigned and could be declared final | 66 |
| Parameter 'facesContext' is not assigned and could be declared final | 66 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 8. | 66 - 116 |
| Local variable 'menu' could be declared final | 67 |
| Local variable 'writer' could be declared final | 68 |
| Local variable 'disabled' could be declared final | 70 |
| Local variable 'firstLevel' could be declared final | 71 |
| Local variable 'label' could be declared final | 72 |
| Avoid if (x != y) ..; else ..; | 74 - 115 |
| Local variable 'checkbox' could be declared final | 76 |
| Local variable 'checked' could be declared final | 77 |
| Local variable 'image' could be declared final | 78 |
| Assigning an Object to null is a code smell. Consider refactoring. | 78 |
| Local variable 'hiddenId' could be declared final | 79 |
| Avoid if (x != y) ..; else ..; | 83 - 115 |
| Local variable 'clientId' could be declared final | 85 |
| Local variable 'radio' could be declared final | 86 |
| Local variable 'items' could be declared final | 87 |
| Local variable 'hiddenId' could be declared final | 88 |
| Local variable 'checked' could be declared final | 90 |
| Local variable 'image' could be declared final | 91 |
| Assigning an Object to null is a code smell. Consider refactoring. | 91 |
| Avoid if (x != y) ..; else ..; | 95 - 103 |
| Avoid instantiating new objects inside loops | 105 - 106 |
| Local variable 'image' could be declared final | 112 |
| Local variable 'map' could be declared final | 113 |
| Parameter 'hiddenId' is not assigned and could be declared final | 118 |
| Parameter 'value' is not assigned and could be declared final | 118 |
| Parameter 'writer' is not assigned and could be declared final | 118 |
| The method 'encodeItem' has a Cyclomatic Complexity of 20. | 128 - 210 |
| The method encodeItem() has an NPath complexity of 12096 | 128 - 210 |
| Avoid really long parameter lists. | 128 - 130 |
| The method 'encodeItem' has a Cyclomatic Complexity of 20. | 128 - 210 |
| Parameter 'component' is not assigned and could be declared final | 129 |
| Parameter 'facesContext' is not assigned and could be declared final | 129 |
| Parameter 'label' is not assigned and could be declared final | 129 |
| Parameter 'writer' is not assigned and could be declared final | 129 |
| Parameter 'sub' is not assigned and could be declared final | 130 |
| Parameter 'map' is not assigned and could be declared final | 130 |
| Parameter 'value' is not assigned and could be declared final | 130 |
| Parameter 'image' is not assigned and could be declared final | 130 |
| Parameter 'disabled' is not assigned and could be declared final | 130 |
| Parameter 'firstLevel' is not assigned and could be declared final | 130 |
| Prefer StringBuffer over += for concatenating strings | 147 |
| Local variable 'iconStyle' could be declared final | 161 |
| Local variable 'imageWithPath' could be declared final | 168 |
| Local variable 'imageHover' could be declared final | 170 - 171 |
| Local variable 'style' could be declared final | 181 |
| Parameter 'component' is not assigned and could be declared final | 212 |
| Parameter 'facesContext' is not assigned and could be declared final | 212 |
| Document empty method | 213 - 214 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/MenuRenderer.java
| Violation | Line |
|---|---|
| The class 'MenuRenderer' has a Cyclomatic Complexity of 6 (Highest = 14). | 43 - 127 |
| The class 'MenuRenderer' has a Cyclomatic Complexity of 6 (Highest = 14). | 43 - 127 |
| Parameter 'component' is not assigned and could be declared final | 48 |
| Parameter 'facesContext' is not assigned and could be declared final | 48 |
| Parameter 'component' is not assigned and could be declared final | 59 |
| Parameter 'facesContext' is not assigned and could be declared final | 59 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 14. | 59 - 111 |
| The method encodeBegin() has an NPath complexity of 594 | 59 - 111 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 14. | 59 - 111 |
| Local variable 'writer' could be declared final | 62 |
| Local variable 'style' could be declared final | 71 |
| Local variable 'label' could be declared final | 86 |
| Deeply nested if..then statements are hard to read | 89 - 92 |
| Deeply nested if..then statements are hard to read | 93 - 95 |
| Local variable 'arrow' could be declared final | 103 - 104 |
| Parameter 'component' is not assigned and could be declared final | 114 |
| Parameter 'facesContext' is not assigned and could be declared final | 114 |
| Local variable 'menu' could be declared final | 116 |
| Local variable 'writer' could be declared final | 117 |
| Local variable 'isParentMenu' could be declared final | 119 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/MenuSeparatorRenderer.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 35 |
| Parameter 'facesContext' is not assigned and could be declared final | 35 |
| Local variable 'writer' could be declared final | 36 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/MessagesRenderer.java
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 258 |
| The class 'MessagesRenderer' has a Cyclomatic Complexity of 6 (Highest = 9). | 61 - 258 |
| Parameter 'component' is not assigned and could be declared final | 68 |
| Parameter 'facesContext' is not assigned and could be declared final | 68 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 8. | 68 - 134 |
| Local variable 'messages' could be declared final | 70 |
| Local variable 'writer' could be declared final | 77 |
| Local variable 'messageList' could be declared final | 82 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 84 |
| Local variable 'clientId' could be declared final | 119 |
| Parameter 'facesContext' is not assigned and could be declared final | 136 |
| Parameter 'messages' is not assigned and could be declared final | 136 |
| Avoid if (x != y) ..; else ..; | 140 |
| Local variable 'id' could be declared final | 140 |
| Local variable 'page' could be declared final | 145 |
| Local variable 'buttonPanel' could be declared final | 182 - 183 |
| Parameter 'message' is not assigned and could be declared final | 219 |
| Parameter 'writer' is not assigned and could be declared final | 219 |
| Parameter 'messages' is not assigned and could be declared final | 219 |
| Parameter 'clientId' is not assigned and could be declared final | 219 |
| The method 'encodeMessage' has a Cyclomatic Complexity of 9. | 219 - 249 |
| Local variable 'summary' could be declared final | 222 |
| Local variable 'detail' could be declared final | 223 |
| Parameter 'component' is not assigned and could be declared final | 252 |
| Parameter 'facesContext' is not assigned and could be declared final | 252 |
| Local variable 'measure' could be declared final | 253 |
| Local variable 'messages' could be declared final | 254 |
| Local variable 'count' could be declared final | 255 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/ObjectRenderer.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 37 |
| Parameter 'facesContext' is not assigned and could be declared final | 37 |
| Local variable 'object' could be declared final | 38 |
| Local variable 'writer' could be declared final | 39 |
| Avoid if (x != y) ..; else ..; | 47 - 51 |
| Local variable 'style' could be declared final | 53 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/OutRenderer.java
| Violation | Line |
|---|---|
| The class 'OutRenderer' has a Cyclomatic Complexity of 8 (Highest = 7). | 36 - 82 |
| Parameter 'component' is not assigned and could be declared final | 39 |
| Parameter 'facesContext' is not assigned and could be declared final | 39 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 7. | 39 - 81 |
| Local variable 'out' could be declared final | 41 |
| Local variable 'writer' could be declared final | 48 |
| Local variable 'escape' could be declared final | 50 |
| Local variable 'createSpan' could be declared final | 51 |
| Local variable 'id' could be declared final | 54 |
| Local variable 'style' could be declared final | 58 |
| Local variable 'tokenizer' could be declared final | 65 |
| Local variable 'token' could be declared final | 67 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/PageRenderer.java
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 713 |
| The class 'PageRenderer' has a Cyclomatic Complexity of 6 (Highest = 35). | 74 - 713 |
| The class 'PageRenderer' has a Cyclomatic Complexity of 6 (Highest = 35). | 74 - 713 |
| Parameter 'component' is not assigned and could be declared final | 82 |
| Parameter 'facesContext' is not assigned and could be declared final | 82 |
| The method 'decode' has a Cyclomatic Complexity of 9. | 82 - 122 |
| Local variable 'clientId' could be declared final | 84 |
| Local variable 'externalContext' could be declared final | 85 |
| Local variable 'severity' could be declared final | 88 - 89 |
| Local variable 'lastFocusId' could be declared final | 95 - 96 |
| Local variable 'name' could be declared final | 102 |
| The String literal "scrollbarWeight" appears 4 times in this file; the first occurrence is on line 102 | 102 |
| Local variable 'tokenizer' could be declared final | 107 |
| Local variable 'vertical' could be declared final | 108 |
| Local variable 'horizontal' could be declared final | 109 |
| Local variable 'client' could be declared final | 114 |
| Parameter 'component' is not assigned and could be declared final | 125 |
| Parameter 'facesContext' is not assigned and could be declared final | 125 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 35. | 125 - 417 |
| The method encodeBegin() has an NPath complexity of 671893056 | 125 - 417 |
| Avoid really long methods. | 125 - 417 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 35. | 125 - 417 |
| The method encodeBegin() has an NCSS line count of 173 | 125 - 417 |
| Local variable 'layoutContext' could be declared final | 133 |
| Local variable 'writer' could be declared final | 138 |
| Local variable 'entry' could be declared final | 149 |
| Local variable 'application' could be declared final | 154 |
| Local variable 'viewHandler' could be declared final | 155 |
| Local variable 'viewId' could be declared final | 156 |
| Local variable 'contentType' could be declared final | 159 |
| Local variable 'clientId' could be declared final | 161 |
| Local variable 'severity' could be declared final | 169 |
| Avoid empty catch blocks | 180 - 182 |
| Avoid empty catch blocks | 180 - 182 |
| Local variable 'preventFrameAttacks' could be declared final | 185 |
| Local variable 'title' could be declared final | 190 |
| Avoid if (x != y) ..; else ..; | 204 |
| Avoid empty if statements | 224 - 226 |
| Avoid empty if statements | 224 - 226 |
| Local variable 'styleBlocks' could be declared final | 244 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 245 |
| Local variable 'enctype' could be declared final | 305 |
| Local variable 'calculateScrollbarWeight' could be declared final | 338 - 339 |
| Local variable 'hidden' could be declared final | 375 |
| Local variable 'menuBar' could be declared final | 396 |
| Local variable 'style' could be declared final | 409 |
| Local variable 'border' could be declared final | 413 |
| Parameter 'resources' is not assigned and could be declared final | 419 |
| Parameter 'files' is not assigned and could be declared final | 419 |
| Parameter 'styleFile' is not assigned and could be declared final | 429 |
| Parameter 'facesContext' is not assigned and could be declared final | 429 |
| Parameter 'writer' is not assigned and could be declared final | 429 |
| Local variable 'styles' could be declared final | 431 |
| Parameter 'component' is not assigned and could be declared final | 451 |
| Parameter 'facesContext' is not assigned and could be declared final | 451 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 12. | 451 - 581 |
| The method encodeEnd() has an NPath complexity of 2240 | 451 - 581 |
| Avoid really long methods. | 451 - 581 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 12. | 451 - 581 |
| Local variable 'messageClientIds' could be declared final | 482 |
| Local variable 'application' could be declared final | 497 |
| Local variable 'viewHandler' could be declared final | 498 |
| Local variable 'logMessages' could be declared final | 543 |
| Local variable 'ids' could be declared final | 544 |
| Local variable 'id' could be declared final | 546 |
| Local variable 'messages' could be declared final | 547 |
| Local variable 'message' could be declared final | 549 |
| Parameter 'eventFunctions' is not assigned and could be declared final | 583 |
| Parameter 'writer' is not assigned and could be declared final | 583 |
| The method 'writeEventFunction' has a Cyclomatic Complexity of 7. | 583 - 612 |
| Parameter 'returnBoolean' is not assigned and could be declared final | 584 |
| Parameter 'event' is not assigned and could be declared final | 584 |
| Avoid if (x != y) ..; else ..; | 599 - 603 |
| Parameter 'facesContext' is not assigned and could be declared final | 614 |
| Parameter 'writer' is not assigned and could be declared final | 614 |
| Parameter 'script' is not assigned and could be declared final | 614 |
| Avoid unused private methods such as 'errorMessageForDebugging(String,FacesMessage,ResponseWriter)'. | 634 - 635 |
| Parameter 'id' is not assigned and could be declared final | 634 |
| Parameter 'message' is not assigned and could be declared final | 634 |
| Avoid unused private methods such as 'errorMessageForDebugging(String,FacesMessage,ResponseWriter)'. | 634 - 635 |
| Parameter 'writer' is not assigned and could be declared final | 635 |
| Avoid if (x != y) ..; else ..; | 640 |
| The String literal "null" appears 6 times in this file; the first occurrence is on line 640 | 640 |
| Parameter 'id' is not assigned and could be declared final | 652 |
| Parameter 'message' is not assigned and could be declared final | 652 |
| Local variable 'sb' could be declared final | 653 |
| Avoid if (x != y) ..; else ..; | 654 |
| Parameter 's' is not assigned and could be declared final | 663 |
| Parameter 'page' is not assigned and could be declared final | 667 |
| Local variable 'method' could be declared final | 668 |
| Parameter 'component' is not assigned and could be declared final | 678 |
| Parameter 'facesContext' is not assigned and could be declared final | 678 |
| Local variable 'page' could be declared final | 681 |
| Local variable 'menuBar' could be declared final | 682 |
| Avoid if (x != y) ..; else ..; | 683 - 687 |
| Parameter 'component' is not assigned and could be declared final | 691 |
| Parameter 'facesContext' is not assigned and could be declared final | 691 |
| Local variable 'width' could be declared final | 693 - 694 |
| Avoid if (x != y) ..; else ..; | 695 - 699 |
| Parameter 'component' is not assigned and could be declared final | 703 |
| Parameter 'facesContext' is not assigned and could be declared final | 703 |
| Local variable 'height' could be declared final | 705 - 706 |
| Avoid if (x != y) ..; else ..; | 707 - 711 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/PanelRenderer.java
| Violation | Line |
|---|---|
| The class 'PanelRenderer' has a Cyclomatic Complexity of 5 (Highest = 14). | 46 - 145 |
| The class 'PanelRenderer' has a Cyclomatic Complexity of 5 (Highest = 14). | 46 - 145 |
| Avoid unused private fields such as 'LOG'. | 48 |
| Avoid unused private fields such as 'LOG'. | 48 |
| Parameter 'component' is not assigned and could be declared final | 51 |
| Parameter 'facesContext' is not assigned and could be declared final | 51 |
| Parameter 'facesContext' is not assigned and could be declared final | 62 |
| Parameter 'uiComponent' is not assigned and could be declared final | 62 |
| Local variable 'component' could be declared final | 63 |
| Parameter 'component' is not assigned and could be declared final | 70 |
| Parameter 'facesContext' is not assigned and could be declared final | 70 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 14. | 70 - 127 |
| The method encodeBegin() has an NPath complexity of 240 | 70 - 127 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 14. | 70 - 127 |
| Local variable 'panel' could be declared final | 73 |
| Local variable 'writer' could be declared final | 74 |
| Local variable 'clientId' could be declared final | 76 |
| Local variable 'style' could be declared final | 82 |
| Local variable 'facetReload' could be declared final | 94 |
| No need to check for null before an instanceof | 95 |
| Local variable 'update' could be declared final | 96 |
| Parameter 'component' is not assigned and could be declared final | 130 |
| Parameter 'facesContext' is not assigned and could be declared final | 130 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 5. | 130 - 144 |
| Local variable 'writer' could be declared final | 131 |
| Local variable 'panel' could be declared final | 132 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/PopupRenderer.java
| Violation | Line |
|---|---|
| The class 'PopupRenderer' has a Cyclomatic Complexity of 3 (Highest = 8). | 42 - 113 |
| Parameter 'component' is not assigned and could be declared final | 52 |
| Parameter 'facesContext' is not assigned and could be declared final | 52 |
| Parameter 'component' is not assigned and could be declared final | 65 |
| Parameter 'facesContext' is not assigned and could be declared final | 65 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 8. | 65 - 106 |
| Local variable 'page' could be declared final | 86 |
| Local variable 'style' could be declared final | 97 |
| Parameter 'component' is not assigned and could be declared final | 109 |
| Parameter 'facesContext' is not assigned and could be declared final | 109 |
| Local variable 'writer' could be declared final | 110 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/ProgressRenderer.java
| Violation | Line |
|---|---|
| The class 'ProgressRenderer' has a Cyclomatic Complexity of 9 (Highest = 8). | 42 - 92 |
| Parameter 'component' is not assigned and could be declared final | 46 |
| Parameter 'facesContext' is not assigned and could be declared final | 46 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 8. | 46 - 91 |
| Local variable 'progress' could be declared final | 48 |
| Local variable 'writer' could be declared final | 71 |
| Local variable 'facet' could be declared final | 80 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/RichTextEditorRenderer.java
| Violation | Line |
|---|---|
| The class 'RichTextEditorRenderer' has a Cyclomatic Complexity of 4 (Highest = 6). | 52 - 208 |
| Parameter 'component' is not assigned and could be declared final | 59 |
| Parameter 'facesContext' is not assigned and could be declared final | 59 |
| Local variable 'actionId' could be declared final | 65 |
| Local variable 'state' could be declared final | 68 - 69 |
| Parameter 'content' is not assigned and could be declared final | 77 |
| Parameter 'component' is not assigned and could be declared final | 90 |
| Parameter 'facesContext' is not assigned and could be declared final | 90 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 6. | 90 - 155 |
| Local variable 'input' could be declared final | 92 |
| Local variable 'previewState' could be declared final | 94 - 95 |
| Local variable 'clientId' could be declared final | 98 |
| Local variable 'writer' could be declared final | 100 |
| Local variable 'style' could be declared final | 105 |
| Local variable 'content' could be declared final | 119 |
| Local variable 'onchange' could be declared final | 143 |
| Parameter 'component' is not assigned and could be declared final | 157 |
| Parameter 'facesContext' is not assigned and could be declared final | 157 |
| Local variable 'toolbar' could be declared final | 158 - 159 |
| Local variable 'clientId' could be declared final | 160 |
| Local variable 'onClick' could be declared final | 182 - 183 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/ScriptRenderer.java
| Violation | Line |
|---|---|
| The class 'ScriptRenderer' has a Cyclomatic Complexity of 8 (Highest = 7). | 30 - 60 |
| Parameter 'component' is not assigned and could be declared final | 32 |
| Parameter 'facesContext' is not assigned and could be declared final | 32 |
| The method 'prepareRender' has a Cyclomatic Complexity of 7. | 32 - 59 |
| Local variable 'scriptComponent' could be declared final | 34 |
| Local variable 'exit' could be declared final | 35 |
| Local variable 'submit' could be declared final | 39 |
| Local variable 'load' could be declared final | 43 |
| Local variable 'unload' could be declared final | 47 |
| Local variable 'script' could be declared final | 51 |
| Local variable 'file' could be declared final | 55 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SelectBooleanCheckboxRenderer.java
| Violation | Line |
|---|---|
| The class 'SelectBooleanCheckboxRenderer' has a Cyclomatic Complexity of 7 (Highest = 9). | 42 - 134 |
| Parameter 'component' is not assigned and could be declared final | 46 |
| Parameter 'facesContext' is not assigned and could be declared final | 46 |
| Local variable 'input' could be declared final | 48 |
| Local variable 'newValue' could be declared final | 54 - 55 |
| The String literal "true" appears 4 times in this file; the first occurrence is on line 61 | 61 |
| Parameter 'component' is not assigned and could be declared final | 72 |
| Parameter 'facesContext' is not assigned and could be declared final | 72 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 9. | 72 - 133 |
| Local variable 'select' could be declared final | 74 |
| Local variable 'writer' could be declared final | 75 |
| Local variable 'id' could be declared final | 77 |
| Local variable 'currentValue' could be declared final | 78 |
| Local variable 'checked' could be declared final | 79 |
| Local variable 'title' could be declared final | 80 |
| Local variable 'tabIndex' could be declared final | 102 |
| Local variable 'labelWithAccessKey' could be declared final | 114 |
| Deeply nested if..then statements are hard to read | 122 - 125 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SelectManyCheckboxRenderer.java
| Violation | Line |
|---|---|
| The class 'SelectManyCheckboxRenderer' has a Cyclomatic Complexity of 4 (Highest = 6). | 44 - 128 |
| Parameter 'component' is not assigned and could be declared final | 46 |
| Parameter 'facesContext' is not assigned and could be declared final | 46 |
| Local variable 'select' could be declared final | 47 |
| Parameter 'component' is not assigned and could be declared final | 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 54 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 6. | 54 - 115 |
| Local variable 'select' could be declared final | 55 |
| Local variable 'writer' could be declared final | 56 |
| Local variable 'id' could be declared final | 58 |
| Local variable 'items' could be declared final | 59 |
| Local variable 'title' could be declared final | 60 |
| Local variable 'disabled' could be declared final | 61 |
| Local variable 'readonly' could be declared final | 62 |
| Local variable 'required' could be declared final | 63 |
| Local variable 'style' could be declared final | 64 |
| Local variable 'values' could be declared final | 77 |
| Local variable 'itemId' could be declared final | 79 |
| Local variable 'checked' could be declared final | 83 |
| Local variable 'formattedValue' could be declared final | 87 |
| Local variable 'tabIndex' could be declared final | 96 |
| Local variable 'label' could be declared final | 103 |
| Parameter 'component' is not assigned and could be declared final | 118 |
| Parameter 'facesContext' is not assigned and could be declared final | 118 |
| Local variable 'select' could be declared final | 119 |
| Local variable 'heightOfOne' could be declared final | 120 |
| Local variable 'items' could be declared final | 124 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SelectManyListboxRenderer.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 49 |
| Parameter 'facesContext' is not assigned and could be declared final | 49 |
| Local variable 'select' could be declared final | 56 |
| Local variable 'writer' could be declared final | 57 |
| Local variable 'id' could be declared final | 59 |
| Local variable 'items' could be declared final | 60 |
| Local variable 'readonly' could be declared final | 61 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 62 |
| Local variable 'disabled' could be declared final | 62 |
| Local variable 'title' could be declared final | 64 |
| Local variable 'tabIndex' could be declared final | 73 |
| Local variable 'style' could be declared final | 77 |
| Local variable 'values' could be declared final | 85 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SelectManyShuttleRenderer.java
| Violation | Line |
|---|---|
| The class 'SelectManyShuttleRenderer' has a Cyclomatic Complexity of 4 (Highest = 7). | 42 - 175 |
| Parameter 'component' is not assigned and could be declared final | 45 |
| Parameter 'facesContext' is not assigned and could be declared final | 45 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 7. | 45 - 160 |
| Avoid really long methods. | 45 - 160 |
| Local variable 'select' could be declared final | 46 |
| Local variable 'writer' could be declared final | 47 |
| Local variable 'style' could be declared final | 49 |
| Local variable 'clientId' could be declared final | 52 |
| Local variable 'title' could be declared final | 55 |
| Local variable 'hasLabel' could be declared final | 59 |
| Local variable 'buttonWidth' could be declared final | 61 |
| Local variable 'labelHeight' could be declared final | 63 |
| Local variable 'width' could be declared final | 66 |
| Local variable 'selectWidth' could be declared final | 67 |
| Local variable 'items' could be declared final | 76 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 77 |
| Local variable 'disabled' could be declared final | 77 |
| Local variable 'unselectedLabel' could be declared final | 79 |
| Local variable 'unselectedClientId' could be declared final | 89 |
| Local variable 'tabIndex' could be declared final | 94 |
| Local variable 'values' could be declared final | 104 |
| Local variable 'selectedLabel' could be declared final | 120 |
| Local variable 'selectedClientId' could be declared final | 132 |
| Local variable 'hiddenClientId' could be declared final | 149 |
| Parameter 'component' is not assigned and could be declared final | 162 |
| Parameter 'context' is not assigned and could be declared final | 162 |
| Parameter 'writer' is not assigned and could be declared final | 162 |
| Parameter 'sub' is not assigned and could be declared final | 163 |
| Parameter 'image' is not assigned and could be declared final | 163 |
| Parameter 'disabled' is not assigned and could be declared final | 163 |
| Local variable 'imagePath' could be declared final | 169 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SelectOneChoiceRenderer.java
| Violation | Line |
|---|---|
| The class 'SelectOneChoiceRenderer' has a Cyclomatic Complexity of 4 (Highest = 5). | 42 - 94 |
| Parameter 'component' is not assigned and could be declared final | 50 |
| Parameter 'facesContext' is not assigned and could be declared final | 50 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 5. | 50 - 93 |
| Local variable 'select' could be declared final | 57 |
| Local variable 'writer' could be declared final | 58 |
| Local variable 'id' could be declared final | 60 |
| Local variable 'items' could be declared final | 61 |
| Local variable 'title' could be declared final | 62 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 63 |
| Local variable 'disabled' could be declared final | 63 |
| Local variable 'tabIndex' could be declared final | 70 |
| Local variable 'style' could be declared final | 74 |
| Local variable 'onchange' could be declared final | 80 |
| Local variable 'values' could be declared final | 87 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SelectOneListboxRenderer.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 49 |
| Parameter 'facesContext' is not assigned and could be declared final | 49 |
| Local variable 'select' could be declared final | 56 |
| Local variable 'writer' could be declared final | 57 |
| Local variable 'id' could be declared final | 59 |
| Local variable 'items' could be declared final | 60 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 61 |
| Local variable 'disabled' could be declared final | 61 |
| Local variable 'tabIndex' could be declared final | 72 |
| Local variable 'style' could be declared final | 76 |
| Local variable 'values' could be declared final | 82 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SelectOneRadioRenderer.java
| Violation | Line |
|---|---|
| The class 'SelectOneRadioRenderer' has a Cyclomatic Complexity of 4 (Highest = 6). | 44 - 128 |
| Parameter 'component' is not assigned and could be declared final | 46 |
| Parameter 'facesContext' is not assigned and could be declared final | 46 |
| Local variable 'select' could be declared final | 47 |
| Parameter 'component' is not assigned and could be declared final | 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 54 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 6. | 54 - 115 |
| Local variable 'select' could be declared final | 55 |
| Local variable 'writer' could be declared final | 56 |
| Local variable 'id' could be declared final | 58 |
| Local variable 'items' could be declared final | 59 |
| Local variable 'title' could be declared final | 60 |
| Local variable 'disabled' could be declared final | 61 |
| Local variable 'readonly' could be declared final | 62 |
| Local variable 'style' could be declared final | 63 |
| Local variable 'required' could be declared final | 64 |
| Local variable 'value' could be declared final | 77 |
| Local variable 'itemId' could be declared final | 79 |
| Local variable 'checked' could be declared final | 83 |
| Local variable 'formattedValue' could be declared final | 87 |
| Local variable 'tabIndex' could be declared final | 96 |
| Local variable 'label' could be declared final | 103 |
| Parameter 'component' is not assigned and could be declared final | 118 |
| Parameter 'facesContext' is not assigned and could be declared final | 118 |
| Local variable 'select' could be declared final | 119 |
| Local variable 'heightOfOne' could be declared final | 120 |
| Local variable 'items' could be declared final | 124 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SelectReferenceRenderer.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 34 |
| Avoid unused private fields such as 'LOG'. | 34 |
| Parameter 'facesContext' is not assigned and could be declared final | 36 |
| Parameter 'component' is not assigned and could be declared final | 37 |
| Local variable 'referenceId' could be declared final | 39 - 40 |
| Local variable 'reference' could be declared final | 41 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SheetPageCommandRenderer.java
| Violation | Line |
|---|---|
| The class 'SheetPageCommandRenderer' has a Cyclomatic Complexity of 8 (Highest = 7). | 33 - 73 |
| Parameter 'component' is not assigned and could be declared final | 38 |
| Parameter 'facesContext' is not assigned and could be declared final | 38 |
| The method 'decode' has a Cyclomatic Complexity of 7. | 38 - 72 |
| Local variable 'actionId' could be declared final | 39 |
| Local variable 'clientId' could be declared final | 40 |
| Local variable 'event' could be declared final | 54 |
| Local variable 'map' could be declared final | 59 |
| Local variable 'value' could be declared final | 60 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SheetRenderer.java
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 1114 |
| The class 'SheetRenderer' has a Cyclomatic Complexity of 6 (Highest = 51). | 93 - 1114 |
| This class has too many methods, consider refactoring it. | 93 - 1114 |
| Avoid really long classes. | 93 - 1114 |
| The class 'SheetRenderer' has a Cyclomatic Complexity of 6 (Highest = 51). | 93 - 1114 |
| Parameter 'component' is not assigned and could be declared final | 103 |
| Parameter 'facesContext' is not assigned and could be declared final | 103 |
| Parameter 'facesContext' is not assigned and could be declared final | 108 |
| Parameter 'sheet' is not assigned and could be declared final | 108 |
| The method 'ensureHeader' has a Cyclomatic Complexity of 5. | 108 - 137 |
| Avoid if (x != y) ..; else ..; | 121 - 125 |
| Avoid if (x != y) ..; else ..; | 127 - 131 |
| Parameter 'facesContext' is not assigned and could be declared final | 140 |
| Parameter 'uiComponent' is not assigned and could be declared final | 140 |
| Local variable 'sheet' could be declared final | 142 |
| Local variable 'style' could be declared final | 144 |
| Local variable 'writer' could be declared final | 148 |
| Local variable 'facetReload' could be declared final | 156 |
| No need to check for null before an instanceof | 157 |
| Local variable 'update' could be declared final | 158 |
| Local variable 'rowAction' could be declared final | 167 |
| Parameter 'style' is not assigned and could be declared final | 174 |
| Parameter 'hasClickAction' is not assigned and could be declared final | 174 |
| Parameter 'facesContext' is not assigned and could be declared final | 174 |
| Parameter 'sheet' is not assigned and could be declared final | 174 |
| The method 'renderSheet' has a Cyclomatic Complexity of 51. | 174 - 538 |
| The method renderSheet() has an NPath complexity of 818065408 | 174 - 538 |
| Avoid really long methods. | 174 - 538 |
| The method 'renderSheet' has a Cyclomatic Complexity of 51. | 174 - 538 |
| The method renderSheet() has an NCSS line count of 251 | 174 - 538 |
| Local variable 'bodyStyle' could be declared final | 232 |
| Local variable 'sheetBodyStyle' could be declared final | 265 |
| Local variable 'rowRendered' could be declared final | 307 |
| Local variable 'rowMarkups' could be declared final | 338 |
| Local variable 'rowStyle' could be declared final | 344 |
| Avoid instantiating new objects inside loops | 344 |
| Local variable 'alignStyle' could be declared final | 375 |
| Avoid instantiating new objects inside loops | 375 |
| Local variable 'children' could be declared final | 393 |
| Local variable 'base' could be declared final | 399 |
| Local variable 'divWidth' could be declared final | 434 |
| Local variable 'divStyle' could be declared final | 435 |
| Avoid instantiating new objects inside loops | 435 |
| Local variable 'footerStyle' could be declared final | 456 |
| The String literal "tobago" appears 9 times in this file; the first occurrence is on line 478 | 478 |
| Local variable 'atBeginning' could be declared final | 509 |
| Local variable 'atEnd' could be declared final | 519 |
| Parameter 'column' is not assigned and could be declared final | 548 |
| Parameter 'facesContext' is not assigned and could be declared final | 557 |
| Parameter 'sheet' is not assigned and could be declared final | 557 |
| Parameter 'row' is not assigned and could be declared final | 557 |
| Parameter 'pagerCommandId' is not assigned and could be declared final | 557 |
| The method 'createSheetPagingInfo' has a Cyclomatic Complexity of 12. | 557 - 586 |
| The method createSheetPagingInfo() has an NPath complexity of 703130 | 557 - 586 |
| The method 'createSheetPagingInfo' has a Cyclomatic Complexity of 12. | 557 - 586 |
| Avoid if (x != y) ..; else ..; | 559 - 584 |
| Local variable 'locale' could be declared final | 560 |
| Local variable 'first' could be declared final | 561 |
| Local variable 'last' could be declared final | 562 - 564 |
| Local variable 'args' could be declared final | 573 - 578 |
| Parameter 'component' is not assigned and could be declared final | 589 |
| Parameter 'facesContext' is not assigned and could be declared final | 589 |
| The method 'decode' has a Cyclomatic Complexity of 6. | 589 - 623 |
| Local variable 'sheet' could be declared final | 592 |
| Local variable 'requestParameterMap' could be declared final | 596 |
| Local variable 'widths' could be declared final | 598 |
| String.trim().length()==0 is an inefficient way to validate an empty String. | 599 |
| Local variable 'selected' could be declared final | 606 |
| Parameter 'facesContext' is not assigned and could be declared final | 625 |
| Parameter 'sheet' is not assigned and could be declared final | 625 |
| Avoid if (x != y) ..; else ..; | 626 |
| Local variable 'rows' could be declared final | 626 |
| Parameter 'facesContext' is not assigned and could be declared final | 632 |
| Parameter 'sheet' is not assigned and could be declared final | 632 |
| Parameter 'facesContext' is not assigned and could be declared final | 636 |
| Parameter 'sheet' is not assigned and could be declared final | 636 |
| Parameter 'name' is not assigned and could be declared final | 642 |
| Avoid unused private methods such as 'checkPagingAttribute(String)'. | 655 |
| Parameter 'name' is not assigned and could be declared final | 655 |
| Avoid unused private methods such as 'checkPagingAttribute(String)'. | 655 |
| Parameter 'value' is not assigned and could be declared final | 666 |
| Parameter 'data' is not assigned and could be declared final | 676 |
| Parameter 'state' is not assigned and could be declared final | 676 |
| Parameter 'application' is not assigned and could be declared final | 688 |
| Parameter 'facesContext' is not assigned and could be declared final | 688 |
| Parameter 'command' is not assigned and could be declared final | 689 |
| Parameter 'data' is not assigned and could be declared final | 689 |
| Parameter 'disabled' is not assigned and could be declared final | 689 |
| Local variable 'link' could be declared final | 691 |
| Local variable 'tip' could be declared final | 696 - 697 |
| Local variable 'image' could be declared final | 698 - 699 |
| Local variable 'writer' could be declared final | 701 |
| Local variable 'pagerClasses' could be declared final | 705 |
| Assigning an Object to null is a code smell. Consider refactoring. | 705 |
| Avoid unused method parameters such as 'headerWidth'. | 718 - 888 |
| Avoid unused method parameters such as 'sheetId'. | 718 - 888 |
| Avoid unused method parameters such as 'headerWidth'. | 718 - 888 |
| Avoid unused method parameters such as 'sheetId'. | 718 - 888 |
| The method 'renderColumnHeaders' has a Cyclomatic Complexity of 24. | 718 - 888 |
| The method renderColumnHeaders() has an NPath complexity of 67602 | 718 - 888 |
| Avoid really long methods. | 718 - 888 |
| The method 'renderColumnHeaders' has a Cyclomatic Complexity of 24. | 718 - 888 |
| The method renderColumnHeaders() has an NCSS line count of 119 | 718 - 888 |
| Parameter 'resourceManager' is not assigned and could be declared final | 719 |
| Parameter 'facesContext' is not assigned and could be declared final | 719 |
| Parameter 'writer' is not assigned and could be declared final | 719 |
| Parameter 'sheet' is not assigned and could be declared final | 719 |
| Parameter 'headerWidth' is not assigned and could be declared final | 720 |
| Parameter 'sheetId' is not assigned and could be declared final | 720 |
| Parameter 'renderedColumnList' is not assigned and could be declared final | 720 |
| Parameter 'contextPath' is not assigned and could be declared final | 720 |
| Do not add empty strings | 728 |
| Local variable 'headerStyle' could be declared final | 770 |
| Avoid instantiating new objects inside loops | 770 |
| String.indexOf(char) is faster than String.indexOf(String). | 787 |
| Avoid instantiating new objects inside loops | 792 |
| Avoid instantiating new objects inside loops | 793 - 794 |
| Prefer StringBuffer over += for concatenating strings | 801 |
| Prefer StringBuffer over += for concatenating strings | 803 |
| Local variable 'sheetState' could be declared final | 807 |
| Prefer StringBuffer over += for concatenating strings | 820 |
| Local variable 'dropDownMenu' could be declared final | 840 |
| Local variable 'menuImage' could be declared final | 848 |
| Parameter 'columnIndex' is not assigned and could be declared final | 890 |
| Parameter 'writer' is not assigned and could be declared final | 890 |
| Parameter 'sheet' is not assigned and could be declared final | 890 |
| Parameter 'facesContext' is not assigned and could be declared final | 899 |
| Parameter 'writer' is not assigned and could be declared final | 899 |
| Parameter 'sheet' is not assigned and could be declared final | 899 |
| Parameter 'facesContext' is not assigned and could be declared final | 914 |
| Parameter 'sheet' is not assigned and could be declared final | 914 |
| Parameter 'markup' is not assigned and could be declared final | 937 |
| Parameter 'sheetId' is not assigned and could be declared final | 937 |
| Parameter 'menu' is not assigned and could be declared final | 937 |
| Parameter 'label' is not assigned and could be declared final | 937 |
| The method 'writeDirectPagingLinks' has a Cyclomatic Complexity of 24. | 948 - 1035 |
| The method writeDirectPagingLinks() has an NPath complexity of 1296000 | 948 - 1035 |
| The method 'writeDirectPagingLinks' has a Cyclomatic Complexity of 24. | 948 - 1035 |
| Parameter 'application' is not assigned and could be declared final | 949 |
| Parameter 'facesContext' is not assigned and could be declared final | 949 |
| Parameter 'writer' is not assigned and could be declared final | 949 |
| Parameter 'sheet' is not assigned and could be declared final | 949 |
| Local variable 'pagerCommandId' could be declared final | 956 |
| Local variable 'prevs' could be declared final | 959 |
| Local variable 'nexts' could be declared final | 968 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 997 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 1022 |
| Parameter 'application' is not assigned and could be declared final | 1037 |
| Parameter 'command' is not assigned and could be declared final | 1037 |
| Parameter 'disabled' is not assigned and could be declared final | 1037 |
| Parameter 'id' is not assigned and could be declared final | 1049 |
| Parameter 'str' is not assigned and could be declared final | 1049 |
| Parameter 'makeLink' is not assigned and could be declared final | 1049 |
| Parameter 'writer' is not assigned and could be declared final | 1049 |
| Parameter 'skip' is not assigned and could be declared final | 1049 |
| Parameter 'sheet' is not assigned and could be declared final | 1049 |
| Local variable 'type' could be declared final | 1051 |
| Parameter 'facesContext' is not assigned and could be declared final | 1063 |
| Parameter 'data' is not assigned and could be declared final | 1063 |
| Parameter 'component' is not assigned and could be declared final | 1068 |
| Parameter 'facesContext' is not assigned and could be declared final | 1068 |
| Parameter 'component' is not assigned and could be declared final | 1089 |
| Parameter 'context' is not assigned and could be declared final | 1089 |
| Parameter 'component' is not assigned and could be declared final | 1099 |
| Parameter 'facesContext' is not assigned and could be declared final | 1099 |
| Local variable 'sheet' could be declared final | 1100 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/StyleRenderer.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 33 |
| Parameter 'facesContext' is not assigned and could be declared final | 33 |
| Local variable 'styleComponent' could be declared final | 35 |
| Local variable 'file' could be declared final | 36 |
| Local variable 'style' could be declared final | 40 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SubviewRenderer.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 34 |
| Parameter 'facesContext' is not assigned and could be declared final | 34 |
| Parameter 'facesContext' is not assigned and could be declared final | 42 |
| Document empty method | 43 - 45 |
| Parameter 'component' is not assigned and could be declared final | 43 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SuggestRenderer.java
| Violation | Line |
|---|---|
| The class 'SuggestRenderer' has a Cyclomatic Complexity of 6 (Highest = 7). | 43 - 136 |
| Parameter 'component' is not assigned and could be declared final | 46 |
| Parameter 'facesContext' is not assigned and could be declared final | 46 |
| Parameter 'object' is not assigned and could be declared final | 108 |
| The method 'createAutoSuggestItems' has a Cyclomatic Complexity of 7. | 108 - 134 |
| Local variable 'autoSuggestItems' could be declared final | 112 |
| Local variable 'items' could be declared final | 118 |
| Local variable 'item' could be declared final | 120 |
| Avoid instantiating new objects inside loops | 120 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupLayoutRenderer.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 37 |
| Parameter 'facesContext' is not assigned and could be declared final | 37 |
| Local variable 'container' could be declared final | 38 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupRenderer.java
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 340 |
| The class 'TabGroupRenderer' has a Cyclomatic Complexity of 6 (Highest = 14). | 63 - 340 |
| The class 'TabGroupRenderer' has a Cyclomatic Complexity of 6 (Highest = 14). | 63 - 340 |
| Parameter 'component' is not assigned and could be declared final | 70 |
| Parameter 'facesContext' is not assigned and could be declared final | 70 |
| Local variable 'oldIndex' could be declared final | 75 |
| Local variable 'clientId' could be declared final | 77 |
| Local variable 'newValue' could be declared final | 79 |
| Local variable 'activeIndex' could be declared final | 81 |
| Local variable 'event' could be declared final | 83 |
| Parameter 'facesContext' is not assigned and could be declared final | 92 |
| Parameter 'uiComponent' is not assigned and could be declared final | 92 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 6. | 92 - 130 |
| Local variable 'tabGroup' could be declared final | 94 |
| Local variable 'activeIndex' could be declared final | 96 |
| Local variable 'writer' could be declared final | 101 |
| Parameter 'context' is not assigned and could be declared final | 132 |
| Parameter 'tabGroup' is not assigned and could be declared final | 132 |
| The method 'ensureRenderedActiveIndex' has a Cyclomatic Complexity of 10. | 132 - 166 |
| The method 'ensureRenderedActiveIndex' has a Cyclomatic Complexity of 10. | 132 - 166 |
| Local variable 'activeIndex' could be declared final | 133 |
| Deeply nested if..then statements are hard to read | 143 - 145 |
| Avoid if (x != y) ..; else ..; | 160 - 164 |
| The method 'encodeHeader' has a Cyclomatic Complexity of 14. | 168 - 244 |
| The method encodeHeader() has an NPath complexity of 518 | 168 - 244 |
| The method 'encodeHeader' has a Cyclomatic Complexity of 14. | 168 - 244 |
| Parameter 'activeIndex' is not assigned and could be declared final | 169 |
| Parameter 'facesContext' is not assigned and could be declared final | 169 |
| Parameter 'writer' is not assigned and could be declared final | 169 |
| Parameter 'tabGroup' is not assigned and could be declared final | 169 |
| Local variable 'width' could be declared final | 172 |
| Local variable 'headerHeight' could be declared final | 173 |
| Local variable 'toolBarWidth' could be declared final | 174 |
| Local variable 'header' could be declared final | 175 |
| Local variable 'tab' could be declared final | 189 |
| Local variable 'label' could be declared final | 191 |
| Avoid instantiating new objects inside loops | 191 |
| Local variable 'maxSeverity' could be declared final | 195 |
| Local variable 'title' could be declared final | 202 |
| Avoid if (x != y) ..; else ..; | 216 - 220 |
| Local variable 'body' could be declared final | 236 |
| Local variable 'toolBar' could be declared final | 241 |
| Parameter 'facesContext' is not assigned and could be declared final | 246 |
| Parameter 'tabGroup' is not assigned and could be declared final | 246 |
| The method 'createToolBar' has a Cyclomatic Complexity of 5. | 246 - 304 |
| Avoid unused local variables such as 'clientId'. | 247 |
| Avoid unused local variables such as 'clientId'. | 247 |
| Local variable 'application' could be declared final | 248 |
| Local variable 'viewRoot' could be declared final | 249 |
| Local variable 'previous' could be declared final | 252 |
| Local variable 'next' could be declared final | 258 |
| Local variable 'all' could be declared final | 265 - 266 |
| Local variable 'menu' could be declared final | 269 - 270 |
| Local variable 'tab' could be declared final | 277 |
| Local variable 'entry' could be declared final | 279 - 280 |
| Local variable 'label' could be declared final | 283 |
| Avoid instantiating new objects inside loops | 283 |
| Local variable 'toolBar' could be declared final | 295 |
| Parameter 'facesContext' is not assigned and could be declared final | 307 |
| Parameter 'toolBar' is not assigned and could be declared final | 307 |
| Parameter 'writer' is not assigned and could be declared final | 307 |
| Parameter 'tabGroup' is not assigned and could be declared final | 307 |
| Parameter 'index' is not assigned and could be declared final | 315 |
| Parameter 'facesContext' is not assigned and could be declared final | 315 |
| Parameter 'tab' is not assigned and could be declared final | 315 |
| Parameter 'writer' is not assigned and could be declared final | 315 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupToolBarRenderer.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 29 |
| Parameter 'component' is not assigned and could be declared final | 34 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabRenderer.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 28 |
| Avoid unused private fields such as 'LOG'. | 28 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TextareaRenderer.java
| Violation | Line |
|---|---|
| The class 'TextareaRenderer' has a Cyclomatic Complexity of 15 (Highest = 14). | 44 - 134 |
| The class 'TextareaRenderer' has a Cyclomatic Complexity of 15 (Highest = 14). | 44 - 134 |
| Parameter 'component' is not assigned and could be declared final | 49 |
| Parameter 'facesContext' is not assigned and could be declared final | 49 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 14. | 49 - 133 |
| The method encodeEnd() has an NPath complexity of 1920 | 49 - 133 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 14. | 49 - 133 |
| Local variable 'lengthValidator' could be declared final | 94 |
| Prefer StringBuffer over += for concatenating strings | 119 |
| Prefer StringBuffer over += for concatenating strings | 121 |
| Prefer StringBuffer over += for concatenating strings | 123 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TimeRenderer.java
| Violation | Line |
|---|---|
| The class 'TimeRenderer' has a Cyclomatic Complexity of 5 (Highest = 11). | 49 - 182 |
| The class 'TimeRenderer' has a Cyclomatic Complexity of 5 (Highest = 11). | 49 - 182 |
| Parameter 'component' is not assigned and could be declared final | 53 |
| Parameter 'facesContext' is not assigned and could be declared final | 53 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 11. | 53 - 153 |
| The method encodeEnd() has an NPath complexity of 240 | 53 - 153 |
| Avoid really long methods. | 53 - 153 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 11. | 53 - 153 |
| Local variable 'time' could be declared final | 55 |
| Local variable 'title' could be declared final | 57 |
| Local variable 'currentValue' could be declared final | 58 |
| Local variable 'converter' could be declared final | 65 |
| Local variable 'string' could be declared final | 67 |
| Deeply nested if..then statements are hard to read | 68 - 70 |
| Prefer StringBuffer over += for concatenating strings | 69 |
| Local variable 'hasSeconds' could be declared final | 74 |
| Local variable 'value' could be declared final | 76 |
| When instantiating a SimpleDateFormat object, specify a Locale | 86 |
| Local variable 'hour' could be declared final | 86 |
| When instantiating a SimpleDateFormat object, specify a Locale | 87 |
| Local variable 'minute' could be declared final | 87 |
| When instantiating a SimpleDateFormat object, specify a Locale | 88 |
| Local variable 'second' could be declared final | 88 |
| Local variable 'id' could be declared final | 90 |
| Local variable 'style' could be declared final | 99 |
| Local variable 'dateInputId' could be declared final | 101 |
| Parameter 'time' is not assigned and could be declared final | 155 |
| Parameter 'sep' is not assigned and could be declared final | 155 |
| Parameter 'writer' is not assigned and could be declared final | 155 |
| Parameter 'unit' is not assigned and could be declared final | 163 |
| Parameter 'input' is not assigned and could be declared final | 163 |
| Parameter 'title' is not assigned and could be declared final | 163 |
| Parameter 'max' is not assigned and could be declared final | 163 |
| Parameter 'idPrefix' is not assigned and could be declared final | 163 |
| Parameter 'value' is not assigned and could be declared final | 163 |
| Parameter 'writer' is not assigned and could be declared final | 163 |
| Local variable 'tabIndex' could be declared final | 165 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/ToolBarRenderer.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 40 |
| Parameter 'facesContext' is not assigned and could be declared final | 40 |
| Local variable 'toolBar' could be declared final | 42 |
| Local variable 'writer' could be declared final | 44 |
| Local variable 'style' could be declared final | 51 |
| Local variable 'right' could be declared final | 52 |
| Parameter 'facesContext' is not assigned and could be declared final | 62 |
| Parameter 'toolBar' is not assigned and could be declared final | 62 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/ToolBarRendererBase.java
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 598 |
| The class 'ToolBarRendererBase' has a Cyclomatic Complexity of 6 (Highest = 39). | 64 - 598 |
| This class has too many methods, consider refactoring it. | 64 - 598 |
| The class 'ToolBarRendererBase' has a Cyclomatic Complexity of 6 (Highest = 39). | 64 - 598 |
| Parameter 'component' is not assigned and could be declared final | 69 |
| Parameter 'facesContext' is not assigned and could be declared final | 69 |
| Parameter 'component' is not assigned and could be declared final | 74 |
| Parameter 'component' is not assigned and could be declared final | 78 |
| Parameter 'toolBar' is not assigned and could be declared final | 82 |
| Parameter 'component' is not assigned and could be declared final | 87 |
| Parameter 'context' is not assigned and could be declared final | 87 |
| Local variable 'toolBar' could be declared final | 88 |
| Local variable 'writer' could be declared final | 90 |
| Parameter 'facesContext' is not assigned and could be declared final | 104 |
| Parameter 'toolBar' is not assigned and could be declared final | 104 |
| Parameter 'command' is not assigned and could be declared final | 104 |
| The method 'renderToolbarCommand' has a Cyclomatic Complexity of 5. | 104 - 121 |
| Parameter 'width' is not assigned and could be declared final | 105 |
| Parameter 'writer' is not assigned and could be declared final | 105 |
| Avoid if (x != y) ..; else ..; | 111 - 119 |
| Avoid if (x != y) ..; else ..; | 113 - 119 |
| Parameter 'facesContext' is not assigned and could be declared final | 125 |
| Parameter 'toolBar' is not assigned and could be declared final | 125 |
| Parameter 'command' is not assigned and could be declared final | 125 |
| The method 'renderSelectOne' has a Cyclomatic Complexity of 11. | 125 - 193 |
| The method 'renderSelectOne' has a Cyclomatic Complexity of 11. | 125 - 193 |
| Avoid reassigning parameters such as 'width' | 126 |
| Parameter 'writer' is not assigned and could be declared final | 126 |
| Local variable 'value' could be declared final | 142 |
| Local variable 'radioId' could be declared final | 146 |
| Avoid if (x != y) ..; else ..; | 149 - 153 |
| Local variable 'formattedValue' could be declared final | 170 |
| Avoid instantiating new objects inside loops | 180 |
| Parameter 'facesContext' is not assigned and could be declared final | 198 |
| Parameter 'toolBar' is not assigned and could be declared final | 198 |
| Parameter 'command' is not assigned and could be declared final | 198 |
| Avoid reassigning parameters such as 'width' | 199 |
| Parameter 'writer' is not assigned and could be declared final | 199 |
| The method 'renderToolbarButton' has a Cyclomatic Complexity of 39. | 225 - 455 |
| Avoid really long methods. | 225 - 455 |
| The method 'renderToolbarButton' has a Cyclomatic Complexity of 39. | 225 - 455 |
| The method renderToolbarButton() has an NCSS line count of 158 | 225 - 455 |
| Parameter 'facesContext' is not assigned and could be declared final | 226 |
| Parameter 'toolBar' is not assigned and could be declared final | 226 |
| Parameter 'command' is not assigned and could be declared final | 226 |
| Parameter 'writer' is not assigned and could be declared final | 226 |
| Parameter 'selected' is not assigned and could be declared final | 227 |
| Parameter 'width' is not assigned and could be declared final | 227 |
| Parameter 'map' is not assigned and could be declared final | 227 |
| Parameter 'value' is not assigned and could be declared final | 227 |
| Assigning an Object to null is a code smell. Consider refactoring. | 243 |
| Local variable 'imageHover' could be declared final | 408 - 409 |
| Local variable 'dropDownDisabled' could be declared final | 442 |
| Local variable 'menuImage' could be declared final | 443 - 444 |
| Parameter 'facesContext' is not assigned and could be declared final | 458 |
| Parameter 'toolBar' is not assigned and could be declared final | 458 |
| Parameter 'writer' is not assigned and could be declared final | 458 |
| Parameter 'separator' is not assigned and could be declared final | 458 |
| Parameter 'width' is not assigned and could be declared final | 459 |
| Local variable 'itemStyle' could be declared final | 467 |
| Parameter 'facesContext' is not assigned and could be declared final | 482 |
| Parameter 'toolBar' is not assigned and could be declared final | 482 |
| The method 'getItemHeight' has a Cyclomatic Complexity of 6. | 482 - 520 |
| Avoid unused local variables such as 'iconSmall'. | 488 |
| Avoid unused local variables such as 'iconSmall'. | 488 |
| Parameter 'command' is not assigned and could be declared final | 522 |
| Parameter 'command' is not assigned and could be declared final | 526 |
| The method 'getImage' has a Cyclomatic Complexity of 15. | 534 - 577 |
| The method getImage() has an NPath complexity of 1152 | 534 - 577 |
| The method 'getImage' has a Cyclomatic Complexity of 15. | 534 - 577 |
| Parameter 'selected' is not assigned and could be declared final | 535 |
| Parameter 'iconSize' is not assigned and could be declared final | 535 |
| Parameter 'facesContext' is not assigned and could be declared final | 535 |
| Parameter 'name' is not assigned and could be declared final | 535 |
| Parameter 'disabled' is not assigned and could be declared final | 535 |
| Local variable 'key' could be declared final | 540 |
| Local variable 'ext' could be declared final | 541 |
| Local variable 'resourceManager' could be declared final | 550 |
| Parameter 'facesContext' is not assigned and could be declared final | 580 |
| Parameter 'dropDownMenu' is not assigned and could be declared final | 580 |
| Parameter 'writer' is not assigned and could be declared final | 580 |
| An empty method in an abstract class should be abstract instead | 590 - 592 |
| Parameter 'component' is not assigned and could be declared final | 590 |
| Parameter 'facesContext' is not assigned and could be declared final | 590 |
| Document empty method | 591 - 592 |
| An empty method in an abstract class should be abstract instead | 595 - 597 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TreeCommandRenderer.java
| Violation | Line |
|---|---|
| The class 'TreeCommandRenderer' has a Cyclomatic Complexity of 3 (Highest = 7). | 47 - 115 |
| Parameter 'component' is not assigned and could be declared final | 52 |
| Parameter 'facesContext' is not assigned and could be declared final | 52 |
| Parameter 'component' is not assigned and could be declared final | 61 |
| Parameter 'facesContext' is not assigned and could be declared final | 61 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 7. | 61 - 99 |
| Parameter 'facesContext' is not assigned and could be declared final | 101 |
| Parameter 'link' is not assigned and could be declared final | 101 |
| Parameter 'component' is not assigned and could be declared final | 106 |
| Parameter 'facesContext' is not assigned and could be declared final | 106 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TreeDataRenderer.java
| Violation | Line |
|---|---|
| Document empty method | 32 - 33 |
| Parameter 'component' is not assigned and could be declared final | 32 |
| Parameter 'facesContext' is not assigned and could be declared final | 32 |
| Parameter 'component' is not assigned and could be declared final | 36 |
| Parameter 'facesContext' is not assigned and could be declared final | 36 |
| Document empty method | 41 - 42 |
| Parameter 'component' is not assigned and could be declared final | 41 |
| Parameter 'facesContext' is not assigned and could be declared final | 41 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TreeIconRenderer.java
| Violation | Line |
|---|---|
| The class 'TreeIconRenderer' has a Cyclomatic Complexity of 10 (Highest = 9). | 41 - 106 |
| The class 'TreeIconRenderer' has a Cyclomatic Complexity of 10 (Highest = 9). | 41 - 106 |
| Parameter 'component' is not assigned and could be declared final | 51 |
| Parameter 'facesContext' is not assigned and could be declared final | 51 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 9. | 51 - 105 |
| Avoid if (x != y) ..; else ..; | 64 - 68 |
| Avoid if (x != y) ..; else ..; | 70 - 75 |
| Avoid if (x != y) ..; else ..; | 79 - 84 |
| Local variable 'writer' could be declared final | 93 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TreeIndentRenderer.java
| Violation | Line |
|---|---|
| The class 'TreeIndentRenderer' has a Cyclomatic Complexity of 5 (Highest = 12). | 42 - 164 |
| The class 'TreeIndentRenderer' has a Cyclomatic Complexity of 5 (Highest = 12). | 42 - 164 |
| Parameter 'component' is not assigned and could be declared final | 45 |
| Parameter 'facesContext' is not assigned and could be declared final | 45 |
| Parameter 'component' is not assigned and could be declared final | 76 |
| Parameter 'facesContext' is not assigned and could be declared final | 76 |
| The method 'encodeIndent' has a Cyclomatic Complexity of 5. | 81 - 103 |
| Local variable 'junction' could be declared final | 92 |
| The method 'encodeTreeJunction' has a Cyclomatic Complexity of 12. | 105 - 162 |
| The method encodeTreeJunction() has an NPath complexity of 280 | 105 - 162 |
| Avoid really long parameter lists. | 105 - 108 |
| The method 'encodeTreeJunction' has a Cyclomatic Complexity of 12. | 105 - 162 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TreeLabelRenderer.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 43 |
| Avoid unused private fields such as 'LOG'. | 43 |
| Parameter 'component' is not assigned and could be declared final | 45 |
| Parameter 'facesContext' is not assigned and could be declared final | 45 |
| Local variable 'title' could be declared final | 61 |
| Parameter 'facesContext' is not assigned and could be declared final | 72 |
| Parameter 'link' is not assigned and could be declared final | 72 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TreeListboxNodeRenderer.java
| Violation | Line |
|---|---|
| The class 'TreeListboxNodeRenderer' has a Cyclomatic Complexity of 4 (Highest = 8). | 45 - 139 |
| Parameter 'component' is not assigned and could be declared final | 52 |
| Parameter 'facesContext' is not assigned and could be declared final | 52 |
| The method 'decode' has a Cyclomatic Complexity of 8. | 52 - 99 |
| Local variable 'node' could be declared final | 54 |
| Local variable 'expanded' could be declared final | 71 |
| Local variable 'selected' could be declared final | 79 |
| Local variable 'searchString' could be declared final | 80 |
| Local variable 'treeSelect' could be declared final | 81 |
| Local variable 'marked' could be declared final | 88 - 89 |
| Avoid if (x != y) ..; else ..; | 90 - 98 |
| Local variable 'searchString' could be declared final | 91 |
| Local variable 'markedValue' could be declared final | 92 |
| Parameter 'component' is not assigned and could be declared final | 102 |
| Parameter 'facesContext' is not assigned and could be declared final | 102 |
| Parameter 'component' is not assigned and could be declared final | 112 |
| Parameter 'facesContext' is not assigned and could be declared final | 112 |
| Parameter 'component' is not assigned and could be declared final | 129 |
| Parameter 'facesContext' is not assigned and could be declared final | 129 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TreeListboxRenderer.java
| Violation | Line |
|---|---|
| The class 'TreeListboxRenderer' has a Cyclomatic Complexity of 4 (Highest = 7). | 46 - 204 |
| Parameter 'component' is not assigned and could be declared final | 48 |
| Parameter 'facesContext' is not assigned and could be declared final | 48 |
| Parameter 'component' is not assigned and could be declared final | 53 |
| Parameter 'component' is not assigned and could be declared final | 63 |
| Parameter 'context' is not assigned and could be declared final | 63 |
| Parameter 'component' is not assigned and could be declared final | 68 |
| Parameter 'facesContext' is not assigned and could be declared final | 68 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 6. | 68 - 155 |
| Avoid if (x != y) ..; else ..; | 115 - 117 |
| Local variable 'depth' could be declared final | 115 - 117 |
| Local variable 'currentWidth' could be declared final | 119 |
| Local variable 'width' could be declared final | 120 |
| Local variable 'levelStyle' could be declared final | 125 |
| Avoid instantiating new objects inside loops | 125 |
| Local variable 'swap' could be declared final | 144 |
| The method 'encodeSelectBox' has a Cyclomatic Complexity of 7. | 157 - 203 |
| Parameter 'tree' is not assigned and could be declared final | 158 |
| Parameter 'facesContext' is not assigned and could be declared final | 158 |
| Parameter 'writer' is not assigned and could be declared final | 158 |
| Parameter 'parentRowIndex' is not assigned and could be declared final | 159 |
| Parameter 'foldersRowIndices' is not assigned and could be declared final | 159 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TreeMenuCommandRenderer.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 33 |
| Avoid unused private fields such as 'LOG'. | 33 |
| Parameter 'node' is not assigned and could be declared final | 35 |
| Parameter 'facesContext' is not assigned and could be declared final | 35 |
| Local variable 'style' could be declared final | 41 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TreeMenuLabelRenderer.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 33 |
| Avoid unused private fields such as 'LOG'. | 33 |
| Parameter 'node' is not assigned and could be declared final | 35 |
| Parameter 'facesContext' is not assigned and could be declared final | 35 |
| Local variable 'style' could be declared final | 41 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TreeMenuNodeRenderer.java
| Violation | Line |
|---|---|
| The class 'TreeMenuNodeRenderer' has a Cyclomatic Complexity of 4 (Highest = 6). | 42 - 119 |
| Parameter 'component' is not assigned and could be declared final | 45 |
| Parameter 'facesContext' is not assigned and could be declared final | 45 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 6. | 45 - 87 |
| Local variable 'style' could be declared final | 70 |
| Local variable 'style' could be declared final | 82 |
| Parameter 'component' is not assigned and could be declared final | 90 |
| Parameter 'facesContext' is not assigned and could be declared final | 90 |
| Parameter 'node' is not assigned and could be declared final | 105 |
| Parameter 'facesContext' is not assigned and could be declared final | 105 |
| Parameter 'writer' is not assigned and could be declared final | 105 |
| Parameter 'expanded' is not assigned and could be declared final | 105 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TreeMenuRenderer.java
| Violation | Line |
|---|---|
| The class 'TreeMenuRenderer' has a Cyclomatic Complexity of 4 (Highest = 5). | 31 - 54 |
| Parameter 'component' is not assigned and could be declared final | 34 |
| Parameter 'facesContext' is not assigned and could be declared final | 34 |
| Parameter 'component' is not assigned and could be declared final | 40 |
| The method 'setRendererTypeForCommandsAndNodes' has a Cyclomatic Complexity of 5. | 40 - 53 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TreeNodeRenderer.java
| Violation | Line |
|---|---|
| The class 'TreeNodeRenderer' has a Cyclomatic Complexity of 4 (Highest = 6). | 41 - 98 |
| Avoid unused private fields such as 'LOG'. | 43 |
| Avoid unused private fields such as 'LOG'. | 43 |
| Parameter 'component' is not assigned and could be declared final | 53 |
| Parameter 'facesContext' is not assigned and could be declared final | 53 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 6. | 53 - 91 |
| Local variable 'style' could be declared final | 79 |
| Local variable 'widthStyle' could be declared final | 86 |
| Parameter 'component' is not assigned and could be declared final | 94 |
| Parameter 'facesContext' is not assigned and could be declared final | 94 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TreeNodeRendererBase.java
| Violation | Line |
|---|---|
| The class 'TreeNodeRendererBase' has a Cyclomatic Complexity of 6 (Highest = 5). | 33 - 52 |
| Parameter 'component' is not assigned and could be declared final | 36 |
| Parameter 'facesContext' is not assigned and could be declared final | 36 |
| The method 'prepareRender' has a Cyclomatic Complexity of 5. | 36 - 50 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TreeRenderer.java
| Violation | Line |
|---|---|
| The class 'TreeRenderer' has a Cyclomatic Complexity of 3 (Highest = 10). | 47 - 155 |
| The class 'TreeRenderer' has a Cyclomatic Complexity of 3 (Highest = 10). | 47 - 155 |
| Parameter 'component' is not assigned and could be declared final | 52 |
| Parameter 'facesContext' is not assigned and could be declared final | 52 |
| Parameter 'component' is not assigned and could be declared final | 64 |
| Parameter 'context' is not assigned and could be declared final | 64 |
| Parameter 'component' is not assigned and could be declared final | 69 |
| Parameter 'facesContext' is not assigned and could be declared final | 69 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 10. | 69 - 149 |
| The method encodeEnd() has an NPath complexity of 500 | 69 - 149 |
| The method 'encodeEnd' has a Cyclomatic Complexity of 10. | 69 - 149 |
| Local variable 'tree' could be declared final | 71 |
| Local variable 'clientId' could be declared final | 73 |
| Local variable 'root' could be declared final | 74 |
| Local variable 'writer' could be declared final | 81 |
| Local variable 'style' could be declared final | 85 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TreeSelectRenderer.java
| Violation | Line |
|---|---|
| The class 'TreeSelectRenderer' has a Cyclomatic Complexity of 4 (Highest = 9). | 44 - 148 |
| Parameter 'component' is not assigned and could be declared final | 48 |
| Parameter 'facesContext' is not assigned and could be declared final | 48 |
| The method 'decode' has a Cyclomatic Complexity of 6. | 48 - 76 |
| Parameter 'component' is not assigned and could be declared final | 79 |
| Parameter 'facesContext' is not assigned and could be declared final | 79 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 9. | 79 - 138 |
| Local variable 'writer' could be declared final | 85 |
| Parameter 'id' is not assigned and could be declared final | 140 |
| Parameter 'data' is not assigned and could be declared final | 140 |
| Do not add empty strings | 142 |
| Do not add empty strings | 142 |
| Document empty method | 146 - 147 |
| Parameter 'component' is not assigned and could be declared final | 146 |
| Parameter 'facesContext' is not assigned and could be declared final | 146 |
org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/VerbatimRenderer.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 38 |
| Parameter 'component' is not assigned and could be declared final | 39 |
| Local variable 'writer' could be declared final | 43 |
| Local variable 'value' could be declared final | 45 |