PMD Results

The following document contains the results of PMD

Files

org/apache/myfaces/tobago/model/TreeModel.java

Violation Line
Private field could be made final. It is only initialized in the declaration or constructor. 38
Private field could be made final. It is only initialized in the declaration or constructor. 39
Private field could be made final. It is only initialized in the declaration or constructor. 42
Avoid reassigning parameters such as 'index' 49
Avoid reassigning parameters such as 'index' 49
Avoid reassigning parameters such as 'position' 49
Parameter 'node' is not assigned and could be declared final 49
Local variable could be declared final 63
Local variable could be declared final 64
Parameter 'pathIndex' is not assigned and could be declared final 72
Parameter 'pathIndex' is not assigned and could be declared final 84
Local variable could be declared final 85
A switch statement does not contain a break 86 - 93
Parameter 'name' is not assigned and could be declared final 111
Parameter 'start' is not assigned and could be declared final 119

org/apache/myfaces/tobago/model/AbstractCrud.java

Violation Line
Overridable method 'reset' called during object construction 29
Parameter 'defaultOutcome' is not assigned and could be declared final 168

org/apache/myfaces/tobago/model/WizardStep.java

Violation Line
Parameter 'outcome' is not assigned and could be declared final 54
Parameter 'title' is not assigned and could be declared final 62
Parameter 'index' is not assigned and could be declared final 70

org/apache/myfaces/tobago/model/MixedTreeModel.java

Violation Line
Private field could be made final. It is only initialized in the declaration or constructor. 44
Parameter 'node' is not assigned and could be declared final 46
Local variable could be declared final 51
Parameter 'node' is not assigned and could be declared final 62
Parameter 'data' is not assigned and could be declared final 71
Parameter 'data' is not assigned and could be declared final 84
Local variable could be declared final 119
Avoid if (x != y) ..; else ..; 120 - 126
Assigning an Object to null is a code smell. Consider refactoring. 124
Assigning an Object to null is a code smell. Consider refactoring. 125
Local variable could be declared final 142
Consider simply returning the value vs storing it in local variable 'folder' 143
Local variable could be declared final 147
Consider simply returning the value vs storing it in local variable 'depth' 148
Local variable could be declared final 156
Local variable could be declared final 157

org/apache/myfaces/tobago/model/WizardBackwardNavigationStrategy.java

Violation Line
Parameter 'strategy' is not assigned and could be declared final 36

org/apache/myfaces/tobago/model/AbstractWizard.java

Violation Line
The class 'AbstractWizard' has a Cyclomatic Complexity of 2 (Highest = 5). 29 - 610
Overridable method 'reset' called during object construction 59
Local variable could be declared final 72
Parameter 'event' is not assigned and could be declared final 98
Local variable could be declared final 155
Parameter 'immediate' is not assigned and could be declared final 239
Local variable could be declared final 260
Local variable could be declared final 300
Local variable could be declared final 350
Parameter 'size' is not assigned and could be declared final 420
Parameter 'reset' is not assigned and could be declared final 431
Parameter 'size' is not assigned and could be declared final 431
Parameter 'defaultOutcome' is not assigned and could be declared final 476
Parameter 'strategy' is not assigned and could be declared final 514
Parameter 'outcome' is not assigned and could be declared final 540
Parameter 'title' is not assigned and could be declared final 540
Parameter 'index' is not assigned and could be declared final 561
Parameter 'outcome' is not assigned and could be declared final 561
Parameter 'title' is not assigned and could be declared final 561
Parameter 'index' is not assigned and could be declared final 568
Parameter 'outcome' is not assigned and could be declared final 568
Parameter 'title' is not assigned and could be declared final 568
Parameter 'forIndex' is not assigned and could be declared final 606

org/apache/myfaces/tobago/component/UITreeNode.java

Violation Line
Parameter 'markup' is not assigned and could be declared final 50
Parameter 'model' is not assigned and could be declared final 59
Parameter 'model' is not assigned and could be declared final 63
Local variable could be declared final 66
Parameter 'model' is not assigned and could be declared final 74
Parameter 'facesContext' is not assigned and could be declared final 90
Local variable could be declared final 92
Local variable could be declared final 93
Local variable could be declared final 94
Avoid reassigning parameters such as 'component' 102
Parameter 'context' is not assigned and could be declared final 113
Parameter 'state' is not assigned and could be declared final 113
Local variable could be declared final 114
Parameter 'context' is not assigned and could be declared final 122
Parameter 'marked' is not assigned and could be declared final 131
Local variable could be declared final 139
Avoid if (x != y) ..; else ..; 140
Local variable could be declared final 140
Avoid if (x != y) ..; else ..; 141
Parameter 'expanded' is not assigned and could be declared final 144
Local variable could be declared final 152
Avoid if (x != y) ..; else ..; 153
Local variable could be declared final 153
Avoid if (x != y) ..; else ..; 154

org/apache/myfaces/tobago/component/UITreeData.java

Violation Line
The class 'UITreeData' has a Cyclomatic Complexity of 2 (Highest = 6). 37 - 339
Private field could be made final. It is only initialized in the declaration or constructor. 66
Parameter 'facesContext' is not assigned and could be declared final 69
Local variable could be declared final 77
Document empty method 90 - 92
Parameter 'facesContext' is not assigned and could be declared final 90
Parameter 'pathIndex' is not assigned and could be declared final 98
The method 'setPathIndex' has a Cyclomatic Complexity of 6. 98 - 137
Local variable could be declared final 104
Local variable could be declared final 106
Avoid if (x != y) ..; else ..; 116 - 127
Assigning an Object to null is a code smell. Consider refactoring. 124
Assigning an Object to null is a code smell. Consider refactoring. 125
Assigning an Object to null is a code smell. Consider refactoring. 126
Local variable could be declared final 129
Parameter 'model' is not assigned and could be declared final 139
Parameter 'model' is not assigned and could be declared final 143
Local variable could be declared final 146
Parameter 'model' is not assigned and could be declared final 154
Document empty method 159 - 160
Parameter 'context' is not assigned and could be declared final 159
Parameter 'facesContext' is not assigned and could be declared final 163
Parameter 'facesContext' is not assigned and could be declared final 188
Parameter 'context' is not assigned and could be declared final 203
Local variable could be declared final 204
Parameter 'event' is not assigned and could be declared final 212
Parameter 'event' is not assigned and could be declared final 217
Local variable could be declared final 219 - 220
Local variable could be declared final 221
Local variable could be declared final 222
Parameter 'context' is not assigned and could be declared final 235
Parameter 'context' is not assigned and could be declared final 243
Parameter 'state' is not assigned and could be declared final 243
Local variable could be declared final 244
Parameter 'var' is not assigned and could be declared final 253
Parameter 'currentNode' is not assigned and could be declared final 261
Parameter 'currentNodeId' is not assigned and could be declared final 269
Parameter 'currentParentNodeId' is not assigned and could be declared final 277
Private field could be made final. It is only initialized in the declaration or constructor. 285
Private field could be made final. It is only initialized in the declaration or constructor. 286
Parameter 'phaseId' is not assigned and could be declared final 301
Parameter 'faceslistener' is not assigned and could be declared final 317
Parameter 'faceslistener' is not assigned and could be declared final 322

org/apache/myfaces/tobago/component/UIInputNumberSlider.java

Violation Line
Local variable could be declared final 40
Parameter 'readonly' is not assigned and could be declared final 48
Local variable could be declared final 56
Parameter 'disabled' is not assigned and could be declared final 64
Local variable could be declared final 72
Avoid if (x != y) ..; else ..; 73 - 77
Parameter 'min' is not assigned and could be declared final 80
Local variable could be declared final 88
Avoid if (x != y) ..; else ..; 89 - 93
Parameter 'max' is not assigned and could be declared final 96
Parameter 'context' is not assigned and could be declared final 100
Parameter 'state' is not assigned and could be declared final 100
Local variable could be declared final 101
Parameter 'context' is not assigned and could be declared final 109
Parameter 'context' is not assigned and could be declared final 119

org/apache/myfaces/tobago/component/UITree.java

Violation Line
The class 'UITree' has a Cyclomatic Complexity of 2 (Highest = 5). 41 - 313
Local variable could be declared final 71
Avoid if (x != y) ..; else ..; 72 - 76
Parameter 'mode' is not assigned and could be declared final 79
Parameter 'context' is not assigned and could be declared final 96
Local variable could be declared final 106
Parameter 'facesContext' is not assigned and could be declared final 127
Local variable could be declared final 140
Local variable could be declared final 141
Parameter 'context' is not assigned and could be declared final 147
Local variable could be declared final 182
Parameter 'facesContext' is not assigned and could be declared final 192
Parameter 'context' is not assigned and could be declared final 197
Assigning an Object to null is a code smell. Consider refactoring. 200
Assigning an Object to null is a code smell. Consider refactoring. 201
Assigning an Object to null is a code smell. Consider refactoring. 202
Assigning an Object to null is a code smell. Consider refactoring. 203
Parameter 'context' is not assigned and could be declared final 208
Parameter 'state' is not assigned and could be declared final 208
The method 'restoreState' has a Cyclomatic Complexity of 5. 208 - 228
Local variable could be declared final 209
Local variable could be declared final 234
Avoid if (x != y) ..; else ..; 235 - 239
Parameter 'showJunctions' is not assigned and could be declared final 242
Local variable could be declared final 251
Avoid if (x != y) ..; else ..; 252 - 256
Parameter 'showIcons' is not assigned and could be declared final 259
Local variable could be declared final 268
Avoid if (x != y) ..; else ..; 269 - 273
Parameter 'showRoot' is not assigned and could be declared final 276
Local variable could be declared final 285
Avoid if (x != y) ..; else ..; 286 - 290
Parameter 'showRootJunction' is not assigned and could be declared final 293
Private field could be made final. It is only initialized in the declaration or constructor. 299

org/apache/myfaces/tobago/component/UIWizard.java

Violation Line
Local variable could be declared final 34
Avoid if (x != y) ..; else ..; 35 - 39
Parameter 'controller' is not assigned and could be declared final 42

org/apache/myfaces/tobago/taglib/sandbox/TreeNodeTag.java

Violation Line
Parameter 'component' is not assigned and could be declared final 48
Assigning an Object to null is a code smell. Consider refactoring. 63
Assigning an Object to null is a code smell. Consider refactoring. 64
Assigning an Object to null is a code smell. Consider refactoring. 65
Assigning an Object to null is a code smell. Consider refactoring. 66
Assigning an Object to null is a code smell. Consider refactoring. 67
Assigning an Object to null is a code smell. Consider refactoring. 68
Assigning an Object to null is a code smell. Consider refactoring. 69
Parameter 'value' is not assigned and could be declared final 76
Parameter 'markup' is not assigned and could be declared final 84
Parameter 'tip' is not assigned and could be declared final 88
Parameter 'target' is not assigned and could be declared final 92
Parameter 'expanded' is not assigned and could be declared final 100
Parameter 'marked' is not assigned and could be declared final 108
Parameter 'image' is not assigned and could be declared final 116

org/apache/myfaces/tobago/taglib/sandbox/TreeTagDeclaration.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.tobago.apt.annotation.TagAttribute' 22
Avoid unused imports such as 'org.apache.myfaces.tobago.apt.annotation.UIComponentTagAttribute' 24
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.component.TobagoTagDeclaration' 25
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.HasIdBindingAndRendered' 26
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.HasTreeNodeValue' 27
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.IsRequired' 28

org/apache/myfaces/tobago/taglib/sandbox/WizardTagDeclaration.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.tobago.apt.annotation.TagAttribute' 22
Avoid unused imports such as 'org.apache.myfaces.tobago.apt.annotation.UIComponentTagAttribute' 24
Avoid unused imports such as 'org.apache.myfaces.tobago.model.Wizard' 25
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.component.TobagoTagDeclaration' 26
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.HasIdBindingAndRendered' 27

org/apache/myfaces/tobago/taglib/sandbox/TreeDataTag.java

Violation Line
Parameter 'component' is not assigned and could be declared final 39
Assigning an Object to null is a code smell. Consider refactoring. 49
Assigning an Object to null is a code smell. Consider refactoring. 50
Parameter 'value' is not assigned and could be declared final 57
Parameter 'var' is not assigned and could be declared final 65

org/apache/myfaces/tobago/taglib/sandbox/InputNumberSliderTag.java

Violation Line
Parameter 'max' is not assigned and could be declared final 43
Parameter 'min' is not assigned and could be declared final 51
Parameter 'value' is not assigned and could be declared final 59
Parameter 'valueChangeListener' is not assigned and could be declared final 63
Parameter 'component' is not assigned and could be declared final 67
Local variable could be declared final 73
Assigning an Object to null is a code smell. Consider refactoring. 80
Assigning an Object to null is a code smell. Consider refactoring. 81
Assigning an Object to null is a code smell. Consider refactoring. 82
Assigning an Object to null is a code smell. Consider refactoring. 83

org/apache/myfaces/tobago/taglib/sandbox/TreeNodeTagDeclaration.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.tobago.apt.annotation.TagAttribute' 23
Avoid unused imports such as 'org.apache.myfaces.tobago.apt.annotation.UIComponentTagAttribute' 25
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.component.AbstractCommandTagDeclaration' 26
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.HasIdBindingAndRendered' 27
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.HasImage' 28
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.HasLabel' 29
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.HasMarkup' 30
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.HasTarget' 31
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.HasTip' 32
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.HasValue' 33
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.IsDisabled' 34

org/apache/myfaces/tobago/taglib/sandbox/TreeDataTagDeclaration.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.component.TobagoTagDeclaration' 23
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.HasIdBindingAndRendered' 24
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.HasTreeNodeValue' 25
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.HasVar' 26

org/apache/myfaces/tobago/taglib/sandbox/TreeTag.java

Violation Line
Parameter 'component' is not assigned and could be declared final 55
Assigning an Object to null is a code smell. Consider refactoring. 74
Assigning an Object to null is a code smell. Consider refactoring. 75
Assigning an Object to null is a code smell. Consider refactoring. 76
Assigning an Object to null is a code smell. Consider refactoring. 77
Assigning an Object to null is a code smell. Consider refactoring. 78
Assigning an Object to null is a code smell. Consider refactoring. 79
Assigning an Object to null is a code smell. Consider refactoring. 80
Assigning an Object to null is a code smell. Consider refactoring. 81
Parameter 'value' is not assigned and could be declared final 88
Parameter 'showIcons' is not assigned and could be declared final 96
Parameter 'showJunctions' is not assigned and could be declared final 104
Parameter 'showRoot' is not assigned and could be declared final 112
Parameter 'showRootJunction' is not assigned and could be declared final 120
Parameter 'selectable' is not assigned and could be declared final 128
Parameter 'required' is not assigned and could be declared final 136
Parameter 'mode' is not assigned and could be declared final 144

org/apache/myfaces/tobago/taglib/sandbox/WizardTag.java

Violation Line
Avoid unused imports such as 'org.apache.commons.beanutils.PropertyUtils' 20
Avoid unused imports such as 'org.apache.commons.logging.Log' 21
Avoid unused imports such as 'org.apache.commons.logging.LogFactory' 22
Avoid unused imports such as 'org.apache.myfaces.tobago.TobagoConstants.FACET_LAYOUT' 23
Avoid unused imports such as 'org.apache.myfaces.tobago.apt.annotation.TagAttribute' 26
Avoid unused imports such as 'org.apache.myfaces.tobago.apt.annotation.UIComponentTagAttribute' 27
Avoid unused imports such as 'org.apache.myfaces.tobago.model.Wizard' 28
Avoid unused imports such as 'org.apache.myfaces.tobago.model.WizardStep' 29
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.component.AttributeTag' 30
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.component.ButtonTag' 31
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.component.CellTag' 32
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.component.GridLayoutTag' 33
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.component.OutTag' 34
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.component.PanelTag' 35
Avoid unused imports such as 'org.apache.myfaces.tobago.util.VariableResolverUtil' 36
Avoid unused imports such as 'javax.faces.context.FacesContext' 38
Avoid unused imports such as 'javax.faces.webapp.FacetTag' 39
Avoid unused imports such as 'javax.servlet.jsp.JspException' 40
Avoid unused imports such as 'javax.servlet.jsp.tagext.BodyTagSupport' 41
Avoid unused imports such as 'java.util.List' 42

org/apache/myfaces/tobago/taglib/sandbox/InputNumberSliderTagDeclaration.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.tobago.apt.annotation.TagAttribute' 21
Avoid unused imports such as 'org.apache.myfaces.tobago.apt.annotation.UIComponentTagAttribute' 23
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.HasIdBindingAndRendered' 24
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.HasValue' 25
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.HasValueChangeListener' 26
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.IsDisabled' 27
Avoid unused imports such as 'org.apache.myfaces.tobago.taglib.decl.IsReadonly' 28

org/apache/myfaces/tobago/taglib/sandbox/RichTextEditorTag.java

Violation Line
Local variable could be declared final 39
Parameter 'component' is not assigned and could be declared final 44
Assigning an Object to null is a code smell. Consider refactoring. 51
Parameter 'statePreview' is not assigned and could be declared final 58

org/apache/myfaces/tobago/taglib/sandbox/WizardControllerTag.java

Violation Line
Avoid unused private fields such as 'LOG' 30
Avoid unused private fields such as 'LOG' 30
Parameter 'component' is not assigned and could be declared final 40
Assigning an Object to null is a code smell. Consider refactoring. 51
Parameter 'controller' is not assigned and could be declared final 54

org/apache/myfaces/tobago/application/FoViewHandlerImpl.java

Violation Line
The class 'FoViewHandlerImpl' has a Cyclomatic Complexity of 4 (Highest = 6). 41 - 96
Parameter 'facesContext' is not assigned and could be declared final 49
Parameter 'viewRoot' is not assigned and could be declared final 49
The method 'renderView' has a Cyclomatic Complexity of 6. 49 - 94
Local variable could be declared final 51
Local variable could be declared final 53 - 54
Local variable could be declared final 67 - 68
Local variable could be declared final 69 - 70
Local variable could be declared final 71 - 72
Local variable could be declared final 75 - 76
Local variable could be declared final 77 - 78
Local variable could be declared final 85

org/apache/myfaces/tobago/application/FopConverter.java

Violation Line
Parameter 'buffer' is not assigned and could be declared final 36
Parameter 'servletResponse' is not assigned and could be declared final 36
Local variable could be declared final 41
Local variable could be declared final 42
Local variable could be declared final 56
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 74

org/apache/myfaces/tobago/renderkit/wml/standard/standard/tag/BoxRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 34
Parameter 'facesContext' is not assigned and could be declared final 34
Parameter 'component' is not assigned and could be declared final 39
Parameter 'facesContext' is not assigned and could be declared final 39

org/apache/myfaces/tobago/renderkit/wml/standard/standard/tag/ButtonRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 48
Parameter 'facesContext' is not assigned and could be declared final 48
Local variable could be declared final 51
Local variable could be declared final 52
Local variable could be declared final 54
Local variable could be declared final 60 - 61
Local variable could be declared final 62

org/apache/myfaces/tobago/renderkit/wml/standard/standard/tag/PageRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 42
Parameter 'facesContext' is not assigned and could be declared final 42
Local variable could be declared final 45
Local variable could be declared final 47
Local variable could be declared final 50
Local variable could be declared final 51

org/apache/myfaces/tobago/renderkit/wml/standard/standard/tag/SelectOneChoiceRenderer.java

Violation Line
The class 'SelectOneChoiceRenderer' has a Cyclomatic Complexity of 5 (Highest = 4). 42 - 83
Parameter 'component' is not assigned and could be declared final 44
Parameter 'facesContext' is not assigned and could be declared final 44
Local variable could be declared final 47
Local variable could be declared final 48
Local variable could be declared final 50
Local variable could be declared final 52
Local variable could be declared final 58 - 59
Local variable could be declared final 63
Local variable could be declared final 64
Local variable could be declared final 74 - 75

org/apache/myfaces/tobago/renderkit/wml/standard/standard/tag/PanelRenderer.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 40
Parameter 'uiComponent' is not assigned and could be declared final 41
Local variable could be declared final 43
Local variable could be declared final 44
Local variable could be declared final 45
Parameter 'facesContext' is not assigned and could be declared final 50
Parameter 'uiComponent' is not assigned and could be declared final 51

org/apache/myfaces/tobago/renderkit/wml/standard/standard/tag/InRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 41
Parameter 'facesContext' is not assigned and could be declared final 41
Local variable could be declared final 44
Local variable could be declared final 46
Local variable could be declared final 48
Local variable could be declared final 54
Local variable could be declared final 59
Local variable could be declared final 61 - 62

org/apache/myfaces/tobago/renderkit/wml/standard/standard/tag/SelectBooleanCheckboxRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 40
Parameter 'facesContext' is not assigned and could be declared final 40
Local variable could be declared final 43
Local variable could be declared final 45
Local variable could be declared final 54

org/apache/myfaces/tobago/renderkit/fo/standard/standard/tag/PageRenderer.java

Violation Line
Avoid unused private fields such as 'HEADER' 39
Avoid unused private fields such as 'HEADER' 39
Parameter 'component' is not assigned and could be declared final 47
Parameter 'facesContext' is not assigned and could be declared final 47
Parameter 'component' is not assigned and could be declared final 57
Parameter 'facesContext' is not assigned and could be declared final 57
Local variable could be declared final 58
Local variable could be declared final 59
Local variable could be declared final 60
Local variable could be declared final 61
Local variable could be declared final 65
Parameter 'component' is not assigned and could be declared final 96
Parameter 'facesContext' is not assigned and could be declared final 96
Local variable could be declared final 99

org/apache/myfaces/tobago/renderkit/fo/standard/standard/tag/TextAreaRenderer.java

Violation Line
The class 'TextAreaRenderer' has a Cyclomatic Complexity of 4 (Highest = 5). 33 - 65
Avoid unused private fields such as 'LOG' 34
Avoid unused private fields such as 'LOG' 34
Parameter 'facesContext' is not assigned and could be declared final 41
The method 'encodeEnd' has a Cyclomatic Complexity of 5. 41 - 63
Parameter 'component' is not assigned and could be declared final 42
Local variable could be declared final 47
Local variable could be declared final 50

org/apache/myfaces/tobago/renderkit/fo/standard/standard/tag/LabelRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 34
Parameter 'facesContext' is not assigned and could be declared final 34
Local variable could be declared final 36
Local variable could be declared final 39
Avoid empty if statements 43
Avoid empty if statements 43

org/apache/myfaces/tobago/renderkit/fo/standard/standard/tag/GridLayoutRenderer.java

Violation Line
The class 'GridLayoutRenderer' has a Cyclomatic Complexity of 3 (Highest = 7). 38 - 166
Parameter 'component' is not assigned and could be declared final 47
Parameter 'facesContext' is not assigned and could be declared final 47
Parameter 'component' is not assigned and could be declared final 69
Parameter 'facesContext' is not assigned and could be declared final 69
Document empty method 89 - 90
Parameter 'component' is not assigned and could be declared final 89
Parameter 'facesContext' is not assigned and could be declared final 89
Parameter 'component' is not assigned and could be declared final 92
Parameter 'facesContext' is not assigned and could be declared final 92
The method 'layoutEnd' has a Cyclomatic Complexity of 7. 92 - 150
Local variable could be declared final 93
Local variable could be declared final 109
Local variable could be declared final 110
Local variable could be declared final 115
Local variable could be declared final 116
Local variable could be declared final 117
Local variable could be declared final 118
Local variable could be declared final 119
Local variable could be declared final 120
Local variable could be declared final 125
Parameter 'component' is not assigned and could be declared final 152
Parameter 'facesContext' is not assigned and could be declared final 152
Local variable could be declared final 157
Local variable could be declared final 159

org/apache/myfaces/tobago/renderkit/fo/standard/standard/tag/MessageRenderer.java

Violation Line
Avoid unused private fields such as 'LOG' 35
Avoid unused private fields such as 'LOG' 35

org/apache/myfaces/tobago/renderkit/fo/standard/standard/tag/Layout.java

Violation Line
Parameter 'orientation' is not assigned and could be declared final 55
Parameter 'value' is not assigned and could be declared final 63
Parameter 'parent' is not assigned and could be declared final 67
Parameter 'x' is not assigned and could be declared final 91
Parameter 'y' is not assigned and could be declared final 99
Parameter 'width' is not assigned and could be declared final 107
Parameter 'height' is not assigned and could be declared final 115
Parameter 'right' is not assigned and could be declared final 119
Parameter 'top' is not assigned and could be declared final 119
Parameter 'left' is not assigned and could be declared final 119
Parameter 'bottom' is not assigned and could be declared final 119
Parameter 'right' is not assigned and could be declared final 135
Parameter 'top' is not assigned and could be declared final 135
Parameter 'left' is not assigned and could be declared final 135
Parameter 'bottom' is not assigned and could be declared final 135
Parameter 'builder' is not assigned and could be declared final 144
Parameter 'component' is not assigned and could be declared final 158
Parameter 'layout' is not assigned and could be declared final 158
Parameter 'component' is not assigned and could be declared final 162
Parameter 'layout' is not assigned and could be declared final 162
Parameter 'component' is not assigned and could be declared final 166
Parameter 'component' is not assigned and could be declared final 170

org/apache/myfaces/tobago/renderkit/fo/standard/standard/tag/BoxRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 38
Parameter 'facesContext' is not assigned and could be declared final 38
Local variable could be declared final 41
Local variable could be declared final 42
Local variable could be declared final 43
Local variable could be declared final 44
Local variable could be declared final 45
Local variable could be declared final 46
Local variable could be declared final 47
Local variable could be declared final 48
Local variable could be declared final 49
Local variable could be declared final 50
Local variable could be declared final 51
Local variable could be declared final 52
Local variable could be declared final 55
Local variable could be declared final 62
Parameter 'facesContext' is not assigned and could be declared final 79
Parameter 'component' is not assigned and could be declared final 80
Local variable could be declared final 81

org/apache/myfaces/tobago/renderkit/fo/standard/standard/tag/FoUtils.java

Violation Line
Parameter 'writer' is not assigned and could be declared final 32
Parameter 'component' is not assigned and could be declared final 36
Parameter 'writer' is not assigned and could be declared final 36
Parameter 'borderWidth' is not assigned and could be declared final 40
Parameter 'writer' is not assigned and could be declared final 40
Parameter 'writer' is not assigned and could be declared final 46
Parameter 'width' is not assigned and could be declared final 47
Parameter 'height' is not assigned and could be declared final 47
Parameter 'y' is not assigned and could be declared final 47
Parameter 'x' is not assigned and could be declared final 47
Parameter 'writer' is not assigned and could be declared final 56
Parameter 'component' is not assigned and could be declared final 57
Parameter 'text' is not assigned and could be declared final 57
Parameter 'writer' is not assigned and could be declared final 63
Parameter 'component' is not assigned and could be declared final 64
Parameter 'text' is not assigned and could be declared final 64
Parameter 'writer' is not assigned and could be declared final 70
Parameter 'component' is not assigned and could be declared final 71
Parameter 'writer' is not assigned and could be declared final 80
Parameter 'text' is not assigned and could be declared final 81
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 86

org/apache/myfaces/tobago/renderkit/fo/standard/standard/tag/PanelRenderer.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 35
Parameter 'uiComponent' is not assigned and could be declared final 36
Parameter 'facesContext' is not assigned and could be declared final 41
Document empty method 42 - 44
Parameter 'uiComponent' is not assigned and could be declared final 42

org/apache/myfaces/tobago/renderkit/fo/standard/standard/tag/FoRendererBase.java

Violation Line
Avoid unused private fields such as 'LOG' 31
Avoid unused private fields such as 'LOG' 31

org/apache/myfaces/tobago/renderkit/fo/standard/standard/tag/InRenderer.java

Violation Line
The class 'InRenderer' has a Cyclomatic Complexity of 5 (Highest = 8). 37 - 85
Avoid unused private fields such as 'LOG' 39
Avoid unused private fields such as 'LOG' 39
Parameter 'facesContext' is not assigned and could be declared final 42
The method 'encodeEnd' has a Cyclomatic Complexity of 8. 42 - 80
Parameter 'component' is not assigned and could be declared final 43
Local variable could be declared final 44
Local variable could be declared final 46
Local variable could be declared final 47

org/apache/myfaces/tobago/renderkit/fo/standard/standard/tag/OutRenderer.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 35
Parameter 'component' is not assigned and could be declared final 36
Avoid unused local variables such as 'layout' 41
Local variable could be declared final 41
Avoid unused local variables such as 'layout' 41
Local variable could be declared final 43

org/apache/myfaces/tobago/renderkit/fo/standard/standard/tag/MessagesRenderer.java

Violation Line
Avoid unused private fields such as 'LOG' 30
Avoid unused private fields such as 'LOG' 30

org/apache/myfaces/tobago/renderkit/html/sandbox/standard/tag/InputNumberSliderRenderer.java

Violation Line
The class 'InputNumberSliderRenderer' has a Cyclomatic Complexity of 2 (Highest = 7). 43 - 230
Parameter 'component' is not assigned and could be declared final 47
Parameter 'facesContext' is not assigned and could be declared final 47
The method 'encodeEnd' has a Cyclomatic Complexity of 7. 47 - 162
Local variable could be declared final 51
Local variable could be declared final 52
Local variable could be declared final 53
Local variable could be declared final 54
Local variable could be declared final 55
Local variable could be declared final 56
Local variable could be declared final 57
Local variable could be declared final 60
Local variable could be declared final 95
Local variable could be declared final 125
Parameter 'component' is not assigned and could be declared final 164
Parameter 'context' is not assigned and could be declared final 164
Local variable could be declared final 171
Local variable could be declared final 172
Local variable could be declared final 174
Parameter 'relativeImagePath' is not assigned and could be declared final 179
Parameter 'facesContext' is not assigned and could be declared final 179
Local variable could be declared final 180
Local variable could be declared final 181
Local variable could be declared final 182
Parameter 'context' is not assigned and could be declared final 186
Parameter 'component' is not assigned and could be declared final 187
Local variable could be declared final 188
Parameter 'context' is not assigned and could be declared final 192
Parameter 'component' is not assigned and could be declared final 193
Local variable could be declared final 194
Parameter 'context' is not assigned and could be declared final 198
Parameter 'component' is not assigned and could be declared final 199
Local variable could be declared final 200
Parameter 'component' is not assigned and could be declared final 204
Parameter 'context' is not assigned and could be declared final 204
Parameter 'writer' is not assigned and could be declared final 205
Local variable could be declared final 206
Local variable could be declared final 207
Local variable could be declared final 208
Local variable could be declared final 209
Local variable could be declared final 210
Local variable could be declared final 211
Local variable could be declared final 212 - 226

org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TreeDataRenderer.java

Violation Line
Document empty method 29 - 30
Parameter 'component' is not assigned and could be declared final 29
Parameter 'facesContext' is not assigned and could be declared final 29
Document empty method 33 - 34
Parameter 'component' is not assigned and could be declared final 33
Parameter 'facesContext' is not assigned and could be declared final 33

org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TreeRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 72
Parameter 'facesContext' is not assigned and could be declared final 72
Local variable could be declared final 77
Parameter 'tree' is not assigned and could be declared final 81
Parameter 'clientId' is not assigned and could be declared final 85
Parameter 'component' is not assigned and could be declared final 92
Parameter 'context' is not assigned and could be declared final 92
Parameter 'component' is not assigned and could be declared final 97
Parameter 'facesContext' is not assigned and could be declared final 97
Local variable could be declared final 99
Local variable could be declared final 101
Local variable could be declared final 102
Local variable could be declared final 104
Local variable could be declared final 133
Local variable could be declared final 135
Local variable could be declared final 137
Parameter 'facesContext' is not assigned and could be declared final 147
Local variable could be declared final 148
Parameter 'facesContext' is not assigned and could be declared final 174
Parameter 'root' is not assigned and could be declared final 174
Local variable could be declared final 175
Local variable could be declared final 176
Parameter 'node' is not assigned and could be declared final 183
Parameter 'facesContext' is not assigned and could be declared final 183
Local variable could be declared final 185
Local variable could be declared final 186

org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TreeNodeRenderer.java

Violation Line
The class 'TreeNodeRenderer' has a Cyclomatic Complexity of 4 (Highest = 12). 58 - 414
Parameter 'component' is not assigned and could be declared final 63
Parameter 'facesContext' is not assigned and could be declared final 63
The method 'decode' has a Cyclomatic Complexity of 5. 63 - 101
Local variable could be declared final 71
Local variable could be declared final 72
Local variable could be declared final 73
Local variable could be declared final 74
Local variable could be declared final 75
Local variable could be declared final 76
Local variable could be declared final 79
Local variable could be declared final 85
Avoid empty if statements 90
Avoid empty if statements 90
Local variable could be declared final 94
Avoid if (x != y) ..; else ..; 95 - 100
Parameter 'component' is not assigned and could be declared final 104
Parameter 'facesContext' is not assigned and could be declared final 104
The method 'encodeBegin' has a Cyclomatic Complexity of 12. 104 - 213
Local variable could be declared final 106
Local variable could be declared final 107
Local variable could be declared final 108
Local variable could be declared final 112
Local variable could be declared final 114
Local variable could be declared final 116
Local variable could be declared final 118
Local variable could be declared final 120
Local variable could be declared final 121
Local variable could be declared final 122
Local variable could be declared final 123
Local variable could be declared final 125
Local variable could be declared final 126
Local variable could be declared final 127
Local variable could be declared final 128
Local variable could be declared final 129
Local variable could be declared final 130
Local variable could be declared final 131
Local variable could be declared final 132
Local variable could be declared final 133
Local variable could be declared final 139
Local variable could be declared final 148
Local variable could be declared final 161
Avoid if (x != y) ..; else ..; 166 - 170
Local variable could be declared final 190
Local variable could be declared final 199
Local variable could be declared final 205
Local variable could be declared final 206
Local variable could be declared final 207
Parameter 'node' is not assigned and could be declared final 215
Parameter 'expanded' is not assigned and could be declared final 215
Parameter 'writer' is not assigned and could be declared final 215
Parameter 'clientId' is not assigned and could be declared final 215
Parameter 'treeId' is not assigned and could be declared final 226
Parameter 'facesContext' is not assigned and could be declared final 226
Parameter 'expanded' is not assigned and could be declared final 226
Parameter 'writer' is not assigned and could be declared final 226
Parameter 'id' is not assigned and could be declared final 226
Local variable could be declared final 228
Local variable could be declared final 229
Local variable could be declared final 230 - 231
Local variable could be declared final 232
Parameter 'menuMode' is not assigned and could be declared final 243
Parameter 'facesContext' is not assigned and could be declared final 243
Parameter 'writer' is not assigned and could be declared final 243
Parameter 'junctions' is not assigned and could be declared final 243
Local variable could be declared final 246
Local variable could be declared final 247
Parameter 'treeId' is not assigned and could be declared final 262
Parameter 'facesContext' is not assigned and could be declared final 262
Parameter 'writer' is not assigned and could be declared final 262
Parameter 'id' is not assigned and could be declared final 262
Parameter 'showRoot' is not assigned and could be declared final 263
Parameter 'showRootJunction' is not assigned and could be declared final 263
Parameter 'showJunctions' is not assigned and could be declared final 263
Parameter 'hasNextSibling' is not assigned and could be declared final 264
Parameter 'isFolder' is not assigned and could be declared final 264
Parameter 'depth' is not assigned and could be declared final 264
Parameter 'expanded' is not assigned and could be declared final 264
Parameter 'image' is not assigned and could be declared final 264
Local variable could be declared final 272 - 281
Local variable could be declared final 283
Parameter 'treeId' is not assigned and could be declared final 299
Parameter 'facesContext' is not assigned and could be declared final 299
Parameter 'writer' is not assigned and could be declared final 299
Parameter 'id' is not assigned and could be declared final 299
Avoid reassigning parameters such as 'image' 300
Parameter 'showIcons' is not assigned and could be declared final 300
Parameter 'isFolder' is not assigned and could be declared final 300
Parameter 'expanded' is not assigned and could be declared final 300
Local variable could be declared final 311
Avoid reassigning parameters such as 'image' 322
Parameter 'treeId' is not assigned and could be declared final 322
Parameter 'facesContext' is not assigned and could be declared final 322
The method 'encodeLabel' has a Cyclomatic Complexity of 6. 348 - 381
Parameter 'marked' is not assigned and could be declared final 349
Parameter 'treeId' is not assigned and could be declared final 349
Parameter 'helper' is not assigned and could be declared final 349
Parameter 'node' is not assigned and could be declared final 349
Parameter 'writer' is not assigned and could be declared final 349
Local variable could be declared final 362
Local variable could be declared final 366
Local variable could be declared final 371
Parameter 'component' is not assigned and could be declared final 384
Parameter 'facesContext' is not assigned and could be declared final 384
Local variable could be declared final 386
Local variable could be declared final 387
Local variable could be declared final 388
Local variable could be declared final 389
Local variable could be declared final 393
Local variable could be declared final 395
Local variable could be declared final 403
Local variable could be declared final 404
Local variable could be declared final 405
A high number of imports can indicate a high degree of coupling within an object. 414

org/apache/myfaces/tobago/util/CommonsLoggingLogger.java

Violation Line
Private field could be made final. It is only initialized in the declaration or constructor. 25
Parameter 'reference' is not assigned and could be declared final 31
Parameter 'throwable' is not assigned and could be declared final 35
Parameter 'reference' is not assigned and could be declared final 35
Parameter 'reference' is not assigned and could be declared final 43
Parameter 'throwable' is not assigned and could be declared final 47
Parameter 'reference' is not assigned and could be declared final 47
Parameter 'reference' is not assigned and could be declared final 55
Parameter 'throwable' is not assigned and could be declared final 59
Parameter 'reference' is not assigned and could be declared final 59
Parameter 'reference' is not assigned and could be declared final 67
Parameter 'throwable' is not assigned and could be declared final 71
Parameter 'reference' is not assigned and could be declared final 71
Parameter 'reference' is not assigned and could be declared final 79
Parameter 'throwable' is not assigned and could be declared final 83
Parameter 'reference' is not assigned and could be declared final 83
Parameter 'reference' is not assigned and could be declared final 91