PMD Results
The following document contains the results of PMD 4.2.5.
Files
org/apache/myfaces/tobago/application/ActionListenerImpl.java
| Violation | Line |
|---|---|
| The class 'ActionListenerImpl' has a Cyclomatic Complexity of 3 (Highest = 7). | 40 - 92 |
| Private field 'base' could be made final; it is only initialized in the declaration or constructor. | 44 |
| Parameter 'base' is not assigned and could be declared final | 48 |
| Parameter 'event' is not assigned and could be declared final | 52 |
| The method 'processAction' has a Cyclomatic Complexity of 7. | 52 - 83 |
| An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 56 |
| Local variable 'facesContext' could be declared final | 66 |
| Local variable 'facesMessage' could be declared final | 68 |
| Local variable 'source' could be declared final | 71 |
| Local variable 'actionSource' could be declared final | 72 |
| Local variable 'application' could be declared final | 73 |
| Local variable 'binding' could be declared final | 74 |
| Local variable 'navHandler' could be declared final | 76 |
| Avoid if (x != y) ..; else ..; | 78 |
| Local variable 'navBinding' could be declared final | 78 |
| Assigning an Object to null is a code smell. Consider refactoring. | 78 |
| Parameter 'errorOutcome' is not assigned and could be declared final | 89 |
org/apache/myfaces/tobago/application/LabelValueBindingFacesMessage.java
| Violation | Line |
|---|---|
| The class 'LabelValueBindingFacesMessage' has a Cyclomatic Complexity of 2 (Highest = 5). | 29 - 80 |
| Parameter 'summary' is not assigned and could be declared final | 37 |
| Parameter 'detail' is not assigned and could be declared final | 37 |
| Parameter 'severity' is not assigned and could be declared final | 37 |
| Parameter 'args' is not assigned and could be declared final | 38 |
| Parameter 'locale' is not assigned and could be declared final | 38 |
| Parameter 'summary' is not assigned and could be declared final | 44 |
| Parameter 'detail' is not assigned and could be declared final | 44 |
| Parameter 'summary' is not assigned and could be declared final | 48 |
| The method 'getDetail' has a Cyclomatic Complexity of 5. | 53 - 64 |
| Local variable 'detail' could be declared final | 54 |
| Local variable 'facesContext' could be declared final | 57 |
| Local variable 'value' could be declared final | 58 |
| The method 'getSummary' has a Cyclomatic Complexity of 5. | 67 - 78 |
| Local variable 'summary' could be declared final | 68 |
| Local variable 'facesContext' could be declared final | 71 |
| Local variable 'value' could be declared final | 72 |
org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.java
| Violation | Line |
|---|---|
| Parameter 'summary' is not assigned and could be declared final | 29 |
| Parameter 'detail' is not assigned and could be declared final | 29 |
| Parameter 'severity' is not assigned and could be declared final | 29 |
| Parameter 'summary' is not assigned and could be declared final | 33 |
| Parameter 'detail' is not assigned and could be declared final | 33 |
| Parameter 'summary' is not assigned and could be declared final | 37 |
| Local variable 'facesContext' could be declared final | 43 |
| Local variable 'value' could be declared final | 44 - 45 |
| Local variable 'facesContext' could be declared final | 51 |
| Local variable 'value' could be declared final | 52 - 53 |
org/apache/myfaces/tobago/compat/FacesInvokeOnComponent12.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 25 - 64 |
| The class 'FacesInvokeOnComponent12' has a Cyclomatic Complexity of 6 (Highest = 7). | 25 - 64 |
| The method 'invokeOnComponent' has a Cyclomatic Complexity of 7. | 27 - 52 |
| Parameter 'component' is not assigned and could be declared final | 28 |
| Parameter 'context' is not assigned and could be declared final | 28 |
| Parameter 'callback' is not assigned and could be declared final | 28 |
| Parameter 'clientId' is not assigned and could be declared final | 28 |
| Local variable 'thisClientId' could be declared final | 29 |
| These nested if statements could be combined | 41 - 43 |
| These nested if statements could be combined | 41 - 43 |
| Parameter 'component' is not assigned and could be declared final | 55 |
| Parameter 'context' is not assigned and could be declared final | 55 |
| Parameter 'callback' is not assigned and could be declared final | 55 |
| Parameter 'clientId' is not assigned and could be declared final | 55 |
| Local variable 'it' could be declared final | 56 |
| Local variable 'child' could be declared final | 57 |
org/apache/myfaces/tobago/compat/FacesUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 47 - 297 |
| The class 'FacesUtils' has a Cyclomatic Complexity of 3 (Highest = 8). | 47 - 297 |
| This class has too many methods, consider refactoring it. | 47 - 297 |
| The method 'invokeOnComponent' has a Cyclomatic Complexity of 8. | 55 - 82 |
| Parameter 'component' is not assigned and could be declared final | 56 |
| Parameter 'context' is not assigned and could be declared final | 56 |
| Parameter 'callback' is not assigned and could be declared final | 56 |
| Parameter 'clientId' is not assigned and could be declared final | 56 |
| Local variable 'thisClientId' could be declared final | 57 |
| These nested if statements could be combined | 69 - 71 |
| These nested if statements could be combined | 69 - 71 |
| The method 'invokeOnComponentFacetsAndChildren' has a Cyclomatic Complexity of 7. | 84 - 105 |
| Parameter 'component' is not assigned and could be declared final | 85 |
| Parameter 'context' is not assigned and could be declared final | 85 |
| Parameter 'callback' is not assigned and could be declared final | 85 |
| Parameter 'clientId' is not assigned and could be declared final | 85 |
| Local variable 'it' could be declared final | 86 |
| Local variable 'child' could be declared final | 87 |
| Avoid if (x != y) ..; else ..; | 100 |
| Parameter 'facesContext' is not assigned and could be declared final | 107 |
| Parameter 'event' is not assigned and could be declared final | 107 |
| Parameter 'methodBinding' is not assigned and could be declared final | 107 |
| The method 'invokeMethodBinding' has a Cyclomatic Complexity of 5. | 107 - 120 |
| Local variable 'cause' could be declared final | 112 |
| Parameter 'component' is not assigned and could be declared final | 123 |
| Parameter 'name' is not assigned and could be declared final | 123 |
| Parameter 'context' is not assigned and could be declared final | 123 |
| Parameter 'component' is not assigned and could be declared final | 131 |
| Parameter 'name' is not assigned and could be declared final | 131 |
| Parameter 'component' is not assigned and could be declared final | 140 |
| Parameter 'name' is not assigned and could be declared final | 140 |
| Parameter 'context' is not assigned and could be declared final | 140 |
| Parameter 'component' is not assigned and could be declared final | 148 |
| Parameter 'name' is not assigned and could be declared final | 148 |
| Parameter 'component' is not assigned and could be declared final | 157 |
| Parameter 'context' is not assigned and could be declared final | 157 |
| Parameter 'value' is not assigned and could be declared final | 157 |
| Parameter 'bindingName' is not assigned and could be declared final | 157 |
| Local variable 'vb' could be declared final | 159 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 169 |
| Parameter 'context' is not assigned and could be declared final | 169 |
| Parameter 'value' is not assigned and could be declared final | 169 |
| Local variable 'vb' could be declared final | 172 |
| Parameter 'fromComponent' is not assigned and could be declared final | 181 |
| Parameter 'toName' is not assigned and could be declared final | 181 |
| Parameter 'fromName' is not assigned and could be declared final | 181 |
| Parameter 'toComponent' is not assigned and could be declared final | 181 |
| Local variable 'vb' could be declared final | 183 |
| Parameter 'obj' is not assigned and could be declared final | 192 |
| Parameter 'string' is not assigned and could be declared final | 203 |
| Local variable 'facesContext' could be declared final | 205 |
| Local variable 'valueBinding' could be declared final | 206 |
| Consider simply returning the value vs storing it in local variable 'valueBinding' | 207 |
| Parameter 'editableValueHolder' is not assigned and could be declared final | 213 |
| Parameter 'validator' is not assigned and could be declared final | 213 |
| Local variable 'methodBinding' could be declared final | 215 - 216 |
| Parameter 'valueHolder' is not assigned and could be declared final | 223 |
| Parameter 'converterExpression' is not assigned and could be declared final | 223 |
| The method 'setConverter' has a Cyclomatic Complexity of 6. | 223 - 241 |
| No need to check for null before an instanceof | 225 |
| Local variable 'converterExpressionStr' could be declared final | 226 |
| Local variable 'context' could be declared final | 227 |
| Local variable 'valueBinding' could be declared final | 229 |
| Local variable 'converter' could be declared final | 234 |
| Parameter 'component' is not assigned and could be declared final | 243 |
| Parameter 'valueBindingOrExpression' is not assigned and could be declared final | 243 |
| Parameter 'name' is not assigned and could be declared final | 243 |
| Parameter 'source' is not assigned and could be declared final | 251 |
| Parameter 'type' is not assigned and could be declared final | 251 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 252 |
| Parameter 'child' is not assigned and could be declared final | 261 |
| Parameter 'facesContext' is not assigned and could be declared final | 261 |
| Parameter 'var' is not assigned and could be declared final | 261 |
| Parameter 'comparator' is not assigned and could be declared final | 261 |
| Parameter 'descending' is not assigned and could be declared final | 261 |
| Local variable 'valueBinding' could be declared final | 263 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 270 |
| Parameter 'actionSource' is not assigned and could be declared final | 270 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 278 |
| Parameter 'actionSource' is not assigned and could be declared final | 278 |
| Parameter 'context' is not assigned and could be declared final | 286 |
org/apache/myfaces/tobago/compat/FacesUtilsEL.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 45 - 219 |
| The class 'FacesUtilsEL' has a Cyclomatic Complexity of 2 (Highest = 7). | 45 - 219 |
| This class has too many methods, consider refactoring it. | 45 - 219 |
| The method 'invokeOnComponent' has a Cyclomatic Complexity of 7. | 49 - 74 |
| Parameter 'component' is not assigned and could be declared final | 50 |
| Parameter 'context' is not assigned and could be declared final | 50 |
| Parameter 'callback' is not assigned and could be declared final | 50 |
| Parameter 'clientId' is not assigned and could be declared final | 50 |
| Local variable 'thisClientId' could be declared final | 51 |
| These nested if statements could be combined | 63 - 65 |
| These nested if statements could be combined | 63 - 65 |
| Parameter 'component' is not assigned and could be declared final | 77 |
| Parameter 'context' is not assigned and could be declared final | 77 |
| Parameter 'callback' is not assigned and could be declared final | 77 |
| Parameter 'clientId' is not assigned and could be declared final | 77 |
| Local variable 'it' could be declared final | 78 |
| Local variable 'child' could be declared final | 79 |
| Parameter 'facesContext' is not assigned and could be declared final | 88 |
| Parameter 'event' is not assigned and could be declared final | 88 |
| Parameter 'methodBinding' is not assigned and could be declared final | 88 |
| The method 'invokeMethodBinding' has a Cyclomatic Complexity of 5. | 88 - 101 |
| Local variable 'cause' could be declared final | 93 |
| Parameter 'facesContext' is not assigned and could be declared final | 104 |
| Parameter 'event' is not assigned and could be declared final | 104 |
| Parameter 'methodExpression' is not assigned and could be declared final | 104 |
| Parameter 'component' is not assigned and could be declared final | 116 |
| Parameter 'name' is not assigned and could be declared final | 116 |
| Parameter 'context' is not assigned and could be declared final | 116 |
| Parameter 'component' is not assigned and could be declared final | 121 |
| Parameter 'name' is not assigned and could be declared final | 121 |
| Parameter 'component' is not assigned and could be declared final | 126 |
| Parameter 'name' is not assigned and could be declared final | 126 |
| Parameter 'context' is not assigned and could be declared final | 126 |
| Parameter 'component' is not assigned and could be declared final | 131 |
| Parameter 'name' is not assigned and could be declared final | 131 |
| Parameter 'component' is not assigned and could be declared final | 136 |
| Parameter 'context' is not assigned and could be declared final | 136 |
| Parameter 'value' is not assigned and could be declared final | 136 |
| Parameter 'bindingName' is not assigned and could be declared final | 136 |
| Local variable 've' could be declared final | 137 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 144 |
| Parameter 'context' is not assigned and could be declared final | 144 |
| Parameter 'value' is not assigned and could be declared final | 144 |
| Local variable 've' could be declared final | 146 |
| Parameter 'fromComponent' is not assigned and could be declared final | 152 |
| Parameter 'toName' is not assigned and could be declared final | 152 |
| Parameter 'fromName' is not assigned and could be declared final | 152 |
| Parameter 'toComponent' is not assigned and could be declared final | 152 |
| Local variable 've' could be declared final | 153 |
| Parameter 'obj' is not assigned and could be declared final | 159 |
| Local variable 'expression' could be declared final | 161 |
| Parameter 'string' is not assigned and could be declared final | 167 |
| Local variable 'facesContext' could be declared final | 168 |
| Local variable 'expressionFactory' could be declared final | 169 |
| Local variable 'valueExpression' could be declared final | 170 - 171 |
| Parameter 'editableValueHolder' is not assigned and could be declared final | 175 |
| Parameter 'validator' is not assigned and could be declared final | 175 |
| Avoid if (x != y) ..; else ..; | 179 |
| Parameter 'valueHolder' is not assigned and could be declared final | 183 |
| Parameter 'converterExpression' is not assigned and could be declared final | 183 |
| Local variable 'expression' could be declared final | 185 |
| Avoid if (x != y) ..; else ..; | 186 - 191 |
| Parameter 'component' is not assigned and could be declared final | 195 |
| Parameter 'valueBindingOrExpression' is not assigned and could be declared final | 195 |
| Parameter 'name' is not assigned and could be declared final | 195 |
| Parameter 'source' is not assigned and could be declared final | 200 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 200 |
| Parameter 'type' is not assigned and could be declared final | 200 |
| Parameter 'child' is not assigned and could be declared final | 207 |
| Parameter 'facesContext' is not assigned and could be declared final | 207 |
| Parameter 'var' is not assigned and could be declared final | 207 |
| Parameter 'comparator' is not assigned and could be declared final | 207 |
| Parameter 'descending' is not assigned and could be declared final | 207 |
| Local variable 'valueBinding' could be declared final | 208 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 212 |
| Parameter 'actionSource' is not assigned and could be declared final | 212 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 216 |
| Parameter 'actionSource' is not assigned and could be declared final | 216 |
org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.java
| Violation | Line |
|---|---|
| The class 'MethodBindingToMethodExpression' has a Cyclomatic Complexity of 3 (Highest = 7). | 32 - 226 |
| This class has too many methods, consider refactoring it. | 32 - 226 |
| Document empty constructor | 42 - 43 |
| Parameter 'methodBinding' is not assigned and could be declared final | 49 |
| Parameter 'methodBinding' is not assigned and could be declared final | 62 |
| Parameter 'context' is not assigned and could be declared final | 71 |
| Parameter 'context' is not assigned and could be declared final | 88 |
| Local variable 'expr' could be declared final | 106 |
| Parameter 'context' is not assigned and could be declared final | 114 |
| Parameter 'context' is not assigned and could be declared final | 128 |
| Parameter 'state' is not assigned and could be declared final | 128 |
| Assigning an Object to null is a code smell. Consider refactoring. | 131 |
| Local variable 'values' could be declared final | 133 |
| Assigning an Object to null is a code smell. Consider refactoring. | 136 |
| Parameter 'transientFlag' is not assigned and could be declared final | 140 |
| Parameter 'obj' is not assigned and could be declared final | 157 |
| The method 'equals' has a Cyclomatic Complexity of 7. | 157 - 176 |
| Parameter 'instanceName' is not assigned and could be declared final | 178 |
| Parameter 'notNullInstance' is not assigned and could be declared final | 178 |
| Parameter 'instanceName' is not assigned and could be declared final | 184 |
| Parameter 'notNullInstance' is not assigned and could be declared final | 184 |
| Parameter 'invoker' is not assigned and could be declared final | 190 |
| Parameter 'type' is not assigned and could be declared final | 204 |
| The method 'newInstance' has a Cyclomatic Complexity of 7. | 204 - 224 |
org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.java
| Violation | Line |
|---|---|
| Assigning an Object to null is a code smell. Consider refactoring. | 36 |
| Parameter 'methodExpression' is not assigned and could be declared final | 42 |
| Parameter 'facesContext' is not assigned and could be declared final | 51 |
| Parameter 'facesContext' is not assigned and could be declared final | 63 |
| Parameter 'params' is not assigned and could be declared final | 63 |
| Parameter 'context' is not assigned and could be declared final | 76 |
| Parameter 'state' is not assigned and could be declared final | 76 |
| Parameter 'context' is not assigned and could be declared final | 82 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 89 |
org/apache/myfaces/tobago/event/AbstractPopupActionListener.java
| Violation | Line |
|---|---|
| The class 'AbstractPopupActionListener' has a Cyclomatic Complexity of 4 (Highest = 5). | 31 - 54 |
| Parameter 'actionEvent' is not assigned and could be declared final | 35 |
| The method 'processAction' has a Cyclomatic Complexity of 5. | 35 - 51 |
| Local variable 'popup' could be declared final | 36 |
org/apache/myfaces/tobago/event/AbstractResetInputActionListener.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 27 |
| Local variable 'it' could be declared final | 28 |
| Local variable 'child' could be declared final | 30 |
| Parameter 'editableValueHolder' is not assigned and could be declared final | 38 |
org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.java
| Violation | Line |
|---|---|
| Document empty constructor | 33 - 34 |
| Parameter 'methodExpression' is not assigned and could be declared final | 36 |
| Parameter 'actionEvent' is not assigned and could be declared final | 40 |
| Parameter 'context' is not assigned and could be declared final | 44 |
| Parameter 'state' is not assigned and could be declared final | 44 |
| Parameter 'context' is not assigned and could be declared final | 48 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 52 |
org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.java
| Violation | Line |
|---|---|
| Document empty constructor | 33 - 34 |
| Parameter 'methodExpression' is not assigned and could be declared final | 36 |
| Parameter 'actionEvent' is not assigned and could be declared final | 40 |
| Parameter 'context' is not assigned and could be declared final | 44 |
| Parameter 'state' is not assigned and could be declared final | 44 |
| Parameter 'context' is not assigned and could be declared final | 48 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 52 |
org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.java
| Violation | Line |
|---|---|
| Document empty constructor | 34 - 35 |
| Parameter 'methodExpression' is not assigned and could be declared final | 37 |
| Parameter 'event' is not assigned and could be declared final | 41 |
| Avoid unused private methods such as 'elContext()'. | 45 |
| Avoid unused private methods such as 'elContext()'. | 45 |
| Parameter 'context' is not assigned and could be declared final | 49 |
| Parameter 'state' is not assigned and could be declared final | 49 |
| Parameter 'context' is not assigned and could be declared final | 53 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 57 |
org/apache/myfaces/tobago/event/MethodExpressionTreeMarkedListener.java
| Violation | Line |
|---|---|
| Document empty constructor | 34 - 35 |
| Parameter 'methodExpression' is not assigned and could be declared final | 37 |
| Parameter 'event' is not assigned and could be declared final | 41 |
| Avoid unused private methods such as 'elContext()'. | 45 |
| Avoid unused private methods such as 'elContext()'. | 45 |
| Parameter 'context' is not assigned and could be declared final | 49 |
| Parameter 'state' is not assigned and could be declared final | 49 |
| Parameter 'context' is not assigned and could be declared final | 53 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 57 |
org/apache/myfaces/tobago/event/SheetStateChangeEvent.java
| Violation | Line |
|---|---|
| Parameter 'uiComponent' is not assigned and could be declared final | 33 |
| Parameter 'facesListener' is not assigned and could be declared final | 37 |
| Parameter 'facesListener' is not assigned and could be declared final | 41 |
org/apache/myfaces/tobago/event/SortActionEvent.java
| Violation | Line |
|---|---|
| Private field 'column' could be made final; it is only initialized in the declaration or constructor. | 29 |
| Parameter 'column' is not assigned and could be declared final | 31 |
| Parameter 'sheet' is not assigned and could be declared final | 31 |
org/apache/myfaces/tobago/event/TabChangeEvent.java
| Violation | Line |
|---|---|
| Parameter 'oldTabIndex' is not assigned and could be declared final | 36 |
| Parameter 'uiComponent' is not assigned and could be declared final | 36 |
| Parameter 'newTabIndex' is not assigned and could be declared final | 36 |
| Parameter 'oldState' is not assigned and could be declared final | 46 |
| Parameter 'newState' is not assigned and could be declared final | 46 |
| Parameter 'uiComponent' is not assigned and could be declared final | 46 |
| Overridable method 'setOldState' called during object construction | 48 |
| Overridable method 'setNewState' called during object construction | 49 |
| Parameter 'facesListener' is not assigned and could be declared final | 52 |
| Parameter 'facesListener' is not assigned and could be declared final | 56 |
| Parameter 'oldTabIndex' is not assigned and could be declared final | 82 |
| Parameter 'newTabIndex' is not assigned and could be declared final | 98 |
org/apache/myfaces/tobago/event/TreeExpansionEvent.java
| Violation | Line |
|---|---|
| The class 'TreeExpansionEvent' has a Cyclomatic Complexity of 2 (Highest = 6). | 24 - 70 |
| Private field 'oldExpanded' could be made final; it is only initialized in the declaration or constructor. | 28 |
| Private field 'newExpanded' could be made final; it is only initialized in the declaration or constructor. | 29 |
| Parameter 'oldExpanded' is not assigned and could be declared final | 31 |
| Parameter 'node' is not assigned and could be declared final | 31 |
| Parameter 'newExpanded' is not assigned and could be declared final | 31 |
| Parameter 'facesListener' is not assigned and could be declared final | 37 |
| Parameter 'facesListener' is not assigned and could be declared final | 41 |
| The method 'processListener' has a Cyclomatic Complexity of 6. | 41 - 52 |
| Avoid empty if statements | 48 - 50 |
| Avoid empty if statements | 48 - 50 |
org/apache/myfaces/tobago/event/TreeMarkedEvent.java
| Violation | Line |
|---|---|
| The class 'TreeMarkedEvent' has a Cyclomatic Complexity of 2 (Highest = 6). | 24 - 69 |
| Private field 'oldMarked' could be made final; it is only initialized in the declaration or constructor. | 28 |
| Private field 'newMarked' could be made final; it is only initialized in the declaration or constructor. | 29 |
| Parameter 'node' is not assigned and could be declared final | 31 |
| Parameter 'oldMarked' is not assigned and could be declared final | 31 |
| Parameter 'newMarked' is not assigned and could be declared final | 31 |
| Parameter 'facesListener' is not assigned and could be declared final | 37 |
| Parameter 'facesListener' is not assigned and could be declared final | 41 |
| The method 'processListener' has a Cyclomatic Complexity of 6. | 41 - 51 |
| Avoid empty if statements | 47 - 49 |
| Avoid empty if statements | 47 - 49 |
org/apache/myfaces/tobago/event/ValueBindingPopupActionListener.java
| Violation | Line |
|---|---|
| Parameter 'binding' is not assigned and could be declared final | 37 |
| Parameter 'actionEvent' is not assigned and could be declared final | 42 |
| Local variable 'id' could be declared final | 43 |
| Local variable 'popup' could be declared final | 44 |
| Parameter 'context' is not assigned and could be declared final | 58 |
| Parameter 'state' is not assigned and could be declared final | 58 |
| Local variable 'values' could be declared final | 59 |
| Parameter 'context' is not assigned and could be declared final | 63 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 70 |
org/apache/myfaces/tobago/event/ValueBindingResetInputActionListener.java
| Violation | Line |
|---|---|
| The class 'ValueBindingResetInputActionListener' has a Cyclomatic Complexity of 2 (Highest = 5). | 34 - 81 |
| Parameter 'binding' is not assigned and could be declared final | 39 |
| Parameter 'event' is not assigned and could be declared final | 43 |
| The method 'processAction' has a Cyclomatic Complexity of 5. | 43 - 60 |
| Local variable 'obj' could be declared final | 44 |
| Local variable 'component' could be declared final | 55 |
| Parameter 'context' is not assigned and could be declared final | 66 |
| Parameter 'state' is not assigned and could be declared final | 66 |
| Local variable 'values' could be declared final | 67 |
| Parameter 'context' is not assigned and could be declared final | 71 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 77 |
org/apache/myfaces/tobago/event/ValueBindingTabChangeListener.java
| Violation | Line |
|---|---|
| The class 'ValueBindingTabChangeListener' has a Cyclomatic Complexity of 2 (Highest = 8). | 34 - 105 |
| Document empty constructor | 39 - 40 |
| Parameter 'type' is not assigned and could be declared final | 42 |
| Parameter 'valueBinding' is not assigned and could be declared final | 42 |
| Parameter 'tabChangeEvent' is not assigned and could be declared final | 47 |
| Local variable 'handler' could be declared final | 48 |
| Avoid if (x != y) ..; else ..; | 49 - 53 |
| Parameter 'context' is not assigned and could be declared final | 56 |
| Parameter 'context' is not assigned and could be declared final | 63 |
| Parameter 'state' is not assigned and could be declared final | 63 |
| Local variable 'values' could be declared final | 64 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 74 |
| The method 'getTabChangeListener' has a Cyclomatic Complexity of 8. | 78 - 93 |
| Local variable 'obj' could be declared final | 81 |
| No need to check for null before an instanceof | 82 |
| Parameter 'className' is not assigned and could be declared final | 95 |
| Local variable 'clazz' could be declared final | 97 |
org/apache/myfaces/tobago/event/ValueExpressionPopupActionListener.java
| Violation | Line |
|---|---|
| Parameter 'expression' is not assigned and could be declared final | 38 |
| Parameter 'actionEvent' is not assigned and could be declared final | 43 |
| Local variable 'id' could be declared final | 44 |
| Local variable 'popup' could be declared final | 45 |
| Parameter 'context' is not assigned and could be declared final | 59 |
| Parameter 'state' is not assigned and could be declared final | 59 |
| Local variable 'values' could be declared final | 60 |
| Parameter 'context' is not assigned and could be declared final | 64 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 71 |
org/apache/myfaces/tobago/event/ValueExpressionResetInputActionListener.java
| Violation | Line |
|---|---|
| The class 'ValueExpressionResetInputActionListener' has a Cyclomatic Complexity of 2 (Highest = 5). | 33 - 81 |
| Parameter 'binding' is not assigned and could be declared final | 38 |
| Parameter 'event' is not assigned and could be declared final | 42 |
| The method 'processAction' has a Cyclomatic Complexity of 5. | 42 - 59 |
| Local variable 'obj' could be declared final | 43 |
| Local variable 'component' could be declared final | 54 |
| Parameter 'context' is not assigned and could be declared final | 65 |
| Parameter 'state' is not assigned and could be declared final | 65 |
| Local variable 'values' could be declared final | 66 |
| Parameter 'context' is not assigned and could be declared final | 70 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 77 |
org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.java
| Violation | Line |
|---|---|
| The class 'ValueExpressionTabChangeListener' has a Cyclomatic Complexity of 2 (Highest = 8). | 28 - 100 |
| Document empty constructor | 35 - 36 |
| Parameter 'valueExpression' is not assigned and could be declared final | 38 |
| Parameter 'type' is not assigned and could be declared final | 38 |
| Parameter 'tabChangeEvent' is not assigned and could be declared final | 43 |
| Local variable 'handler' could be declared final | 44 |
| Avoid if (x != y) ..; else ..; | 45 - 49 |
| Parameter 'context' is not assigned and could be declared final | 52 |
| Parameter 'context' is not assigned and could be declared final | 59 |
| Parameter 'state' is not assigned and could be declared final | 59 |
| Local variable 'values' could be declared final | 60 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 70 |
| The method 'getTabChangeListener' has a Cyclomatic Complexity of 8. | 74 - 89 |
| Local variable 'obj' could be declared final | 77 |
| No need to check for null before an instanceof | 78 |
| Parameter 'className' is not assigned and could be declared final | 91 |
| Local variable 'clazz' could be declared final | 93 |
org/apache/myfaces/tobago/internal/taglib/TobagoELTag.java
| Violation | Line |
|---|---|
| Local variable 'result' could be declared final | 33 |
| Local variable 'component' could be declared final | 34 |
| Local variable 'component' could be declared final | 45 |
| Local variable 'result' could be declared final | 46 |
| Parameter 'renderers' is not assigned and could be declared final | 55 |
| Local variable 'content' could be declared final | 65 |
| Local variable 'content' could be declared final | 77 |
| Local variable 'tmp' could be declared final | 78 |
| String.trim().length()==0 is an inefficient way to validate an empty String. | 79 |
org/apache/myfaces/tobago/internal/util/FindComponentUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 24 - 60 |
| The class 'FindComponentUtils' has a Cyclomatic Complexity of 11 (Highest = 10). | 24 - 60 |
| The class 'FindComponentUtils' has a Cyclomatic Complexity of 11 (Highest = 10). | 24 - 60 |
| Avoid reassigning parameters such as 'relativeId' | 26 |
| Avoid reassigning parameters such as 'from' | 26 |
| The method 'findComponent' has a Cyclomatic Complexity of 10. | 26 - 59 |
| The method 'findComponent' has a Cyclomatic Complexity of 10. | 26 - 59 |
| Local variable 'idLength' could be declared final | 27 |
| These nested if statements could be combined | 29 - 31 |
| Position literals first in String comparisons | 29 |
| These nested if statements could be combined | 29 - 31 |
org/apache/myfaces/tobago/portlet/PortletUtils.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 62 |
| Parameter 'facesContext' is not assigned and could be declared final | 76 |
| Parameter 'facesContext' is not assigned and could be declared final | 80 |
| Local variable 'request' could be declared final | 81 |
| Parameter 'facesContext' is not assigned and could be declared final | 88 |
| Parameter 'viewId' is not assigned and could be declared final | 88 |
| Local variable 'response' could be declared final | 89 |
| Local variable 'url' could be declared final | 90 |
| Parameter 'facesContext' is not assigned and could be declared final | 95 |
| Local variable 'request' could be declared final | 96 |
org/apache/myfaces/tobago/util/BeanComparator.java
| Violation | Line |
|---|---|
| Private field 'property' could be made final; it is only initialized in the declaration or constructor. | 37 |
| Parameter 'property' is not assigned and could be declared final | 39 |
| Parameter 'reverse' is not assigned and could be declared final | 43 |
| Parameter 'property' is not assigned and could be declared final | 43 |
| Parameter 'property' is not assigned and could be declared final | 48 |
| Parameter 'comparator' is not assigned and could be declared final | 48 |
| Parameter 'reverse' is not assigned and could be declared final | 53 |
| Parameter 'property' is not assigned and could be declared final | 53 |
| Parameter 'comparator' is not assigned and could be declared final | 53 |
| Parameter 'param1' is not assigned and could be declared final | 62 |
| Avoid if (x != y) ..; else ..; | 75 |
| Parameter 'param1' is not assigned and could be declared final | 87 |
| Parameter 'param2' is not assigned and could be declared final | 87 |
org/apache/myfaces/tobago/util/ComparatorBase.java
| Violation | Line |
|---|---|
| The class 'ComparatorBase' has a Cyclomatic Complexity of 3 (Highest = 14). | 25 - 126 |
| The class 'ComparatorBase' has a Cyclomatic Complexity of 3 (Highest = 14). | 25 - 126 |
| Document empty constructor | 33 - 34 |
| Parameter 'reverse' is not assigned and could be declared final | 36 |
| Parameter 'comparator' is not assigned and could be declared final | 36 |
| Parameter 'reverse' is not assigned and could be declared final | 41 |
| Parameter 'comparator' is not assigned and could be declared final | 45 |
| Parameter 'obj1' is not assigned and could be declared final | 49 |
| Parameter 'obj2' is not assigned and could be declared final | 49 |
| The method 'internalCompare' has a Cyclomatic Complexity of 14. | 49 - 89 |
| The method 'internalCompare' has a Cyclomatic Complexity of 14. | 49 - 89 |
| Local variable 'collationKey1' could be declared final | 71 - 72 |
| Local variable 'collationKey2' could be declared final | 73 - 74 |
| Avoid if (x != y) ..; else ..; | 77 - 87 |
| Parameter 'o' is not assigned and could be declared final | 112 |
| Avoid if (x != y) ..; else ..; | 120 |
org/apache/myfaces/tobago/util/FacesVersion.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 42 - 44 |
| Avoid empty catch blocks | 42 - 44 |
| Parameter 'className' is not assigned and could be declared final | 51 |
| Avoid empty catch blocks | 61 - 63 |
| Avoid empty catch blocks | 61 - 63 |
| Avoid empty catch blocks | 65 - 67 |
| Avoid empty catch blocks | 65 - 67 |
org/apache/myfaces/tobago/util/MessageUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 44 - 170 |
| The class 'MessageUtils' has a Cyclomatic Complexity of 4 (Highest = 16). | 44 - 170 |
| The class 'MessageUtils' has a Cyclomatic Complexity of 4 (Highest = 16). | 44 - 170 |
| Parameter 'component' is not assigned and could be declared final | 51 |
| Parameter 'facesContext' is not assigned and could be declared final | 51 |
| Parameter 'severity' is not assigned and could be declared final | 51 |
| Parameter 'args' is not assigned and could be declared final | 52 |
| Parameter 'messageId' is not assigned and could be declared final | 52 |
| The method 'getMessage' has a Cyclomatic Complexity of 16. | 57 - 108 |
| The method getMessage() has an NPath complexity of 546 | 57 - 108 |
| The method 'getMessage' has a Cyclomatic Complexity of 16. | 57 - 108 |
| Parameter 'facesContext' is not assigned and could be declared final | 58 |
| Parameter 'locale' is not assigned and could be declared final | 58 |
| Parameter 'args' is not assigned and could be declared final | 59 |
| Parameter 'severity' is not assigned and could be declared final | 59 |
| Parameter 'messageId' is not assigned and could be declared final | 59 |
| Local variable 'appBundle' could be declared final | 61 |
| Local variable 'tobagoBundle' could be declared final | 66 |
| Local variable 'defBundle' could be declared final | 75 |
| Deeply nested if..then statements are hard to read | 76 - 78 |
| Deeply nested if..then statements are hard to read | 79 - 81 |
| Parameter 'bundle' is not assigned and could be declared final | 110 |
| Parameter 'key' is not assigned and could be declared final | 110 |
| Parameter 'facesContext' is not assigned and could be declared final | 118 |
| Parameter 'locale' is not assigned and could be declared final | 118 |
| Local variable 'bundleName' could be declared final | 119 |
| Avoid if (x != y) ..; else ..; | 120 |
| Local variable 'clazz' could be declared final | 126 |
| Local variable 'bundle' could be declared final | 127 |
| Consider simply returning the value vs storing it in local variable 'bundle' | 128 |
| Parameter 'facesContext' is not assigned and could be declared final | 135 |
| Parameter 'locale' is not assigned and could be declared final | 135 |
| Parameter 'facesContext' is not assigned and could be declared final | 139 |
| Parameter 'locale' is not assigned and could be declared final | 139 |
| Parameter 'bundleName' is not assigned and could be declared final | 139 |
| Parameter 'component' is not assigned and could be declared final | 152 |
| Parameter 'facesContext' is not assigned and could be declared final | 152 |
| Local variable 'label' could be declared final | 153 |
| Parameter 'message' is not assigned and could be declared final | 163 |
| Parameter 'args' is not assigned and could be declared final | 163 |
| Parameter 'locale' is not assigned and could be declared final | 163 |
| Local variable 'format' could be declared final | 165 |
org/apache/myfaces/tobago/util/RequestUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 32 - 52 |
| The class 'RequestUtils' has a Cyclomatic Complexity of 6 (Highest = 5). | 32 - 52 |
| Parameter 'facesContext' is not assigned and could be declared final | 36 |
| The method 'ensureEncoding' has a Cyclomatic Complexity of 5. | 36 - 51 |
| Local variable 'requestObject' could be declared final | 37 |
| Local variable 'request' could be declared final | 40 |
| Do not add empty strings | 49 |
org/apache/myfaces/tobago/util/ValueBindingComparator.java
| Violation | Line |
|---|---|
| The class 'ValueBindingComparator' has a Cyclomatic Complexity of 3 (Highest = 11). | 32 - 130 |
| The class 'ValueBindingComparator' has a Cyclomatic Complexity of 3 (Highest = 11). | 32 - 130 |
| Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. | 36 |
| Private field 'var' could be made final; it is only initialized in the declaration or constructor. | 38 |
| Private field 'valueBinding' could be made final; it is only initialized in the declaration or constructor. | 40 |
| Parameter 'facesContext' is not assigned and could be declared final | 42 |
| Parameter 'var' is not assigned and could be declared final | 42 |
| Parameter 'valueBinding' is not assigned and could be declared final | 42 |
| Parameter 'reverse' is not assigned and could be declared final | 48 |
| Parameter 'facesContext' is not assigned and could be declared final | 48 |
| Parameter 'var' is not assigned and could be declared final | 48 |
| Parameter 'valueBinding' is not assigned and could be declared final | 48 |
| Parameter 'facesContext' is not assigned and could be declared final | 55 |
| Parameter 'var' is not assigned and could be declared final | 55 |
| Parameter 'comparator' is not assigned and could be declared final | 56 |
| Parameter 'valueBinding' is not assigned and could be declared final | 56 |
| Parameter 'facesContext' is not assigned and could be declared final | 63 |
| Parameter 'var' is not assigned and could be declared final | 63 |
| Parameter 'reverse' is not assigned and could be declared final | 64 |
| Parameter 'comparator' is not assigned and could be declared final | 64 |
| Parameter 'valueBinding' is not assigned and could be declared final | 64 |
| Parameter 'o' is not assigned and could be declared final | 71 |
| The method 'equals' has a Cyclomatic Complexity of 11. | 71 - 95 |
| The method 'equals' has a Cyclomatic Complexity of 11. | 71 - 95 |
| Avoid if (x != y) ..; else ..; | 84 |
| Avoid if (x != y) ..; else ..; | 87 |
| Avoid if (x != y) ..; else ..; | 90 |
| Avoid if (x != y) ..; else ..; | 99 |
| Avoid if (x != y) ..; else ..; | 100 |
| Avoid if (x != y) ..; else ..; | 101 |
| Parameter 'param1' is not assigned and could be declared final | 113 |
| Parameter 'param2' is not assigned and could be declared final | 113 |
org/apache/myfaces/tobago/util/ValueExpressionComparator.java
| Violation | Line |
|---|---|
| The class 'ValueExpressionComparator' has a Cyclomatic Complexity of 3 (Highest = 11). | 28 - 126 |
| The class 'ValueExpressionComparator' has a Cyclomatic Complexity of 3 (Highest = 11). | 28 - 126 |
| Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. | 32 |
| Private field 'var' could be made final; it is only initialized in the declaration or constructor. | 34 |
| Private field 'valueExpression' could be made final; it is only initialized in the declaration or constructor. | 36 |
| Parameter 'valueExpression' is not assigned and could be declared final | 38 |
| Parameter 'facesContext' is not assigned and could be declared final | 38 |
| Parameter 'var' is not assigned and could be declared final | 38 |
| Parameter 'valueExpression' is not assigned and could be declared final | 44 |
| Parameter 'facesContext' is not assigned and could be declared final | 44 |
| Parameter 'var' is not assigned and could be declared final | 44 |
| Parameter 'reverse' is not assigned and could be declared final | 45 |
| Parameter 'facesContext' is not assigned and could be declared final | 52 |
| Parameter 'var' is not assigned and could be declared final | 52 |
| Parameter 'valueExpression' is not assigned and could be declared final | 53 |
| Parameter 'comparator' is not assigned and could be declared final | 53 |
| Parameter 'facesContext' is not assigned and could be declared final | 60 |
| Parameter 'var' is not assigned and could be declared final | 60 |
| Parameter 'reverse' is not assigned and could be declared final | 61 |
| Parameter 'valueExpression' is not assigned and could be declared final | 61 |
| Parameter 'comparator' is not assigned and could be declared final | 61 |
| Parameter 'o' is not assigned and could be declared final | 68 |
| The method 'equals' has a Cyclomatic Complexity of 11. | 68 - 92 |
| The method 'equals' has a Cyclomatic Complexity of 11. | 68 - 92 |
| Avoid if (x != y) ..; else ..; | 81 |
| Avoid if (x != y) ..; else ..; | 84 |
| Avoid if (x != y) ..; else ..; | 87 |
| Avoid if (x != y) ..; else ..; | 96 |
| Avoid if (x != y) ..; else ..; | 97 |
| Avoid if (x != y) ..; else ..; | 98 |
| Parameter 'param1' is not assigned and could be declared final | 110 |
| Parameter 'param2' is not assigned and could be declared final | 110 |