Tobago Security - PMD Results

PMD Results

The following document contains the results of PMD 4.2.5.

Violation	Line
A class which only has private constructors should be final	36 - 135
The class 'AuthorizationUtils' has a Cyclomatic Complexity of 6 (Highest = 10).	36 - 135
The class 'AuthorizationUtils' has a Cyclomatic Complexity of 6 (Highest = 10).	36 - 135
Parameter 'expression' is not assigned and could be declared final	45
Parameter 'facesContext' is not assigned and could be declared final	45
The method 'isAuthorized' has a Cyclomatic Complexity of 10.	45 - 78
The method 'isAuthorized' has a Cyclomatic Complexity of 10.	45 - 78
Local variable 'securityAnnotation' could be declared final	47
Local variable 'roles' could be declared final	59
Local variable 'authorised' could be declared final	64
Parameter 'annotatedElement' is not assigned and could be declared final	80
Avoid reassigning parameters such as 'expression'	96
Parameter 'facesContext' is not assigned and could be declared final	96
The method 'getSecurityAnnotation' has a Cyclomatic Complexity of 10.	96 - 134
The method 'getSecurityAnnotation' has a Cyclomatic Complexity of 10.	96 - 134
Local variable 'obj' could be declared final	98
Local variable 'index' could be declared final	107
Local variable 'methodExpression' could be declared final	109
Local variable 'beanExpression' could be declared final	110
Local variable 'bean' could be declared final	112 - 113
Deeply nested if..then statements are hard to read	114 - 124
Local variable 'method' could be declared final	116
Avoid if (x != y) ..; else ..;	127 - 131

Violation	Line
The class 'CheckAuthorisationMethodBinding' has a Cyclomatic Complexity of 2 (Highest = 5).	33 - 92
Document empty constructor	38 - 39
Parameter 'methodBinding' is not assigned and could be declared final	41
Parameter 'facesContext' is not assigned and could be declared final	49
Parameter 'facesContext' is not assigned and could be declared final	53
Parameter 'objects' is not assigned and could be declared final	53
The method 'invoke' has a Cyclomatic Complexity of 5.	53 - 66
Parameter 'facesContext' is not assigned and could be declared final	68
Parameter 'savedState' is not assigned and could be declared final	74
Parameter 'facesContext' is not assigned and could be declared final	74
Local variable 'values' could be declared final	75
Parameter 'bool' is not assigned and could be declared final	83
Parameter 'facesContext' is not assigned and could be declared final	89

Violation	Line
The class 'CheckAuthorisationMethodExpression' has a Cyclomatic Complexity of 1 (Highest = 5).	33 - 110
Document empty constructor	38 - 39
Parameter 'methodExpression' is not assigned and could be declared final	41
Parameter 'context' is not assigned and could be declared final	46
Parameter 'context' is not assigned and could be declared final	51
Parameter 'objects' is not assigned and could be declared final	51
The method 'invoke' has a Cyclomatic Complexity of 5.	51 - 64
Parameter 'obj' is not assigned and could be declared final	72
Parameter 'facesContext' is not assigned and could be declared final	86
Parameter 'savedState' is not assigned and could be declared final	92
Parameter 'facesContext' is not assigned and could be declared final	92
Local variable 'values' could be declared final	93
Parameter 'bool' is not assigned and could be declared final	101
Parameter 'facesContext' is not assigned and could be declared final	107

Violation	Line
Document empty constructor	34 - 35
Avoid unnecessary constructors - the compiler will generate these for you	34 - 35
Parameter 'actionExpression' is not assigned and could be declared final	48
Avoid if (x != y) ..; else ..;	49 - 53

Violation	Line
Document empty constructor	35 - 36
Avoid unnecessary constructors - the compiler will generate these for you	35 - 36
Parameter 'actionExpression' is not assigned and could be declared final	49
Avoid if (x != y) ..; else ..;	50 - 54

Violation	Line
Document empty constructor	34 - 35
Avoid unnecessary constructors - the compiler will generate these for you	34 - 35
Parameter 'actionExpression' is not assigned and could be declared final	48
Avoid if (x != y) ..; else ..;	49 - 53

Violation	Line
Document empty constructor	38 - 39
Avoid unnecessary constructors - the compiler will generate these for you	38 - 39
Parameter 'actionExpression' is not assigned and could be declared final	52
Avoid if (x != y) ..; else ..;	53 - 57

Violation	Line
Document empty constructor	36 - 37
Avoid unnecessary constructors - the compiler will generate these for you	36 - 37
Parameter 'actionExpression' is not assigned and could be declared final	50
Avoid if (x != y) ..; else ..;	51 - 55

Violation	Line
Document empty constructor	34 - 35
Avoid unnecessary constructors - the compiler will generate these for you	34 - 35
Parameter 'actionExpression' is not assigned and could be declared final	48
Avoid if (x != y) ..; else ..;	49 - 53