PMD Results

The following document contains the results of PMD 4.2.5.

Files

org/apache/myfaces/tobago/internal/component/AbstractUINumberSlider.java

ViolationLine
Parameter 'context' is not assigned and could be declared final38

org/apache/myfaces/tobago/internal/taglib/sandbox/RichTextEditorTag.java

ViolationLine
Local variable 'result' could be declared final41
Parameter 'component' is not assigned and could be declared final46
Avoid if (x != y) ..; else ..;51 - 55
Assigning an Object to null is a code smell. Consider refactoring.61
Parameter 'statePreview' is not assigned and could be declared final68

org/apache/myfaces/tobago/internal/webapp/TobagoResponse.java

ViolationLine
Parameter 'base' is not assigned and could be declared final40
Avoid if (x != y) ..; else ..;52 - 57
Parameter 's' is not assigned and could be declared final77

org/apache/myfaces/tobago/model/AbstractCrud.java

ViolationLine
This class has too many methods, consider refactoring it.22 - 182
Overridable method 'reset' called during object construction31
Parameter 'defaultOutcome' is not assigned and could be declared final170

org/apache/myfaces/tobago/renderkit/html/sandbox/standard/tag/NumberSliderRenderer.java

ViolationLine
The class 'NumberSliderRenderer' has a Cyclomatic Complexity of 2 (Highest = 6).41 - 227
Parameter 'component' is not assigned and could be declared final45
Parameter 'facesContext' is not assigned and could be declared final45
Parameter 'component' is not assigned and could be declared final55
Parameter 'facesContext' is not assigned and could be declared final55
The method 'encodeEnd' has a Cyclomatic Complexity of 6.55 - 164
Avoid really long methods.55 - 164
Local variable 'slider' could be declared final57
Local variable 'id' could be declared final59
Local variable 'currentValue' could be declared final60
Local variable 'readonly' could be declared final61
Local variable 'disabled' could be declared final62
Local variable 'min' could be declared final63
The String literal "min" appears 4 times in this file; the first occurrence is on line 6363
Local variable 'max' could be declared final64
The String literal "max" appears 4 times in this file; the first occurrence is on line 6464
Local variable 'writer' could be declared final65
Local variable 'style' could be declared final67
Local variable 'width' could be declared final68
Local variable 'widthStyle' could be declared final95
Local variable 'inputIdAndName' could be declared final122
Local variable 'handleStyle' could be declared final147
Parameter 'component' is not assigned and could be declared final166
Parameter 'context' is not assigned and could be declared final166
Local variable 'inputId' could be declared final173
Local variable 'requestParameterMap' could be declared final174
Local variable 'newValue' could be declared final176
Parameter 'relativeImagePath' is not assigned and could be declared final181
Parameter 'facesContext' is not assigned and could be declared final181
Parameter 'component' is not assigned and could be declared final186
Parameter 'context' is not assigned and could be declared final186
Local variable 'id' could be declared final187
Parameter 'component' is not assigned and could be declared final191
Parameter 'context' is not assigned and could be declared final191
Local variable 'id' could be declared final192
Parameter 'component' is not assigned and could be declared final196
Parameter 'context' is not assigned and could be declared final196
Local variable 'id' could be declared final197
Parameter 'component' is not assigned and could be declared final201
Parameter 'context' is not assigned and could be declared final201
Parameter 'writer' is not assigned and could be declared final201
Local variable 'trackId' could be declared final203
Local variable 'handleId' could be declared final204
Local variable 'inputId' could be declared final205
Local variable 'jsId' could be declared final206
Local variable 'min' could be declared final207
Local variable 'max' could be declared final208
Local variable 'script' could be declared final209 - 223

org/apache/myfaces/tobago/util/Slf4jLogger.java

ViolationLine
This class has too many methods, consider refactoring it.24 - 95
Private field 'log' could be made final; it is only initialized in the declaration or constructor.26
Parameter 'log' is not assigned and could be declared final28
Parameter 'reference' is not assigned and could be declared final32
Parameter 'throwable' is not assigned and could be declared final36
Parameter 'reference' is not assigned and could be declared final36
Parameter 'reference' is not assigned and could be declared final44
Parameter 'throwable' is not assigned and could be declared final48
Parameter 'reference' is not assigned and could be declared final48
Parameter 'reference' is not assigned and could be declared final56
Parameter 'throwable' is not assigned and could be declared final60
Parameter 'reference' is not assigned and could be declared final60
Parameter 'reference' is not assigned and could be declared final68
Parameter 'throwable' is not assigned and could be declared final72
Parameter 'reference' is not assigned and could be declared final72
Parameter 'reference' is not assigned and could be declared final80
Parameter 'throwable' is not assigned and could be declared final84
Parameter 'reference' is not assigned and could be declared final84
Parameter 'reference' is not assigned and could be declared final92