PMD Results

PMD Results

The following document contains the results of PMD 4.2.5.

Files

org/apache/myfaces/tobago/facelets/AbstractTobagoTagLibrary.java

Violation	Line
Parameter 'namespace' is not assigned and could be declared final	27
Parameter 'rendererType' is not assigned and could be declared final	42
Parameter 'name' is not assigned and could be declared final	42
Parameter 'handlerType' is not assigned and could be declared final	42
Parameter 'componentType' is not assigned and could be declared final	42

org/apache/myfaces/tobago/facelets/AttributeHandler.java

Violation	Line
The class 'AttributeHandler' has a Cyclomatic Complexity of 8 (Highest = 60).	50 - 345
The class 'AttributeHandler' has a Cyclomatic Complexity of 8 (Highest = 60).	50 - 345
Parameter 'config' is not assigned and could be declared final	60
Parameter 'parent' is not assigned and could be declared final	67
Parameter 'faceletContext' is not assigned and could be declared final	67
The method 'apply' has a Cyclomatic Complexity of 60.	67 - 279
Avoid really long methods.	67 - 279
The method 'apply' has a Cyclomatic Complexity of 60.	67 - 279
The method apply() has an NCSS line count of 163	67 - 279
Avoid if (x != y) ..; else ..;	75 - 277
Avoid if (x != y) ..; else ..;	79 - 97
Local variable 'expression' could be declared final	82 - 83
Avoid if (x != y) ..; else ..;	102 - 120
Local variable 'expression' could be declared final	105 - 106
Local variable 'expression' could be declared final	126 - 127
Assigning an Object to null is a code smell. Consider refactoring.	133
Local variable 'expressionFactory' could be declared final	143
Local variable 'action' could be declared final	144 - 145
Local variable 'expression' could be declared final	153 - 154
Assigning an Object to null is a code smell. Consider refactoring.	160
Assigning an Object to null is a code smell. Consider refactoring.	167
Local variable 'expressionFactory' could be declared final	172
Local variable 'actionListener' could be declared final	173 - 174
Local variable 'result' could be declared final	180
Local variable 'expression' could be declared final	186 - 187
Assigning an Object to null is a code smell. Consider refactoring.	193
Local variable 'expression' could be declared final	201
Local variable 'nameValue' could be declared final	212
Local variable 'components' could be declared final	223
Local variable 'expression' could be declared final	236
Local variable 'methodExpression' could be declared final	243
Local variable 'methodExpression' could be declared final	250 - 251
Local variable 'action' could be declared final	259
Local variable 'action' could be declared final	265
Parameter 'string' is not assigned and could be declared final	281
Parameter 'string' is not assigned and could be declared final	285
Parameter 'string' is not assigned and could be declared final	290
Parameter 'string' is not assigned and could be declared final	294
Parameter 'faceletContext' is not assigned and could be declared final	298
Local variable 'myValue' could be declared final	299
Parameter 'args' is not assigned and could be declared final	303
Parameter 'faceletContext' is not assigned and could be declared final	303
Parameter 'returnType' is not assigned and could be declared final	303
Local variable 'expression' could be declared final	308
Avoid if (x != y) ..; else ..;	309 - 315
Local variable 'expressionFactory' could be declared final	310
Parameter 'nameValue' is not assigned and could be declared final	321
Parameter 'parent' is not assigned and could be declared final	321
Parameter 'faceletContext' is not assigned and could be declared final	321
Local variable 'expression' could be declared final	326
Parameter 'expression' is not assigned and could be declared final	336
Parameter 'nameValue' is not assigned and could be declared final	336
Parameter 'parent' is not assigned and could be declared final	336
Parameter 'faceletContext' is not assigned and could be declared final	336
Local variable 'converter' could be declared final	338 - 339

org/apache/myfaces/tobago/facelets/ContentTypeRule.java

Violation	Line
Parameter 'metadataTarget' is not assigned and could be declared final	32
Parameter 'name' is not assigned and could be declared final	32
Parameter 'attribute' is not assigned and could be declared final	32
Parameter 'attribute' is not assigned and could be declared final	43
Parameter 'ctx' is not assigned and could be declared final	47
Parameter 'instance' is not assigned and could be declared final	47
Local variable 'components' could be declared final	48

org/apache/myfaces/tobago/facelets/ConverterHandler.java

Violation	Line
The class 'ConverterHandler' has a Cyclomatic Complexity of 5 (Highest = 8).	41 - 84
Parameter 'config' is not assigned and could be declared final	47
Parameter 'parent' is not assigned and could be declared final	53
Parameter 'faceletContext' is not assigned and could be declared final	53
The method 'apply' has a Cyclomatic Complexity of 8.	53 - 83
Local variable 'valueHolder' could be declared final	57
New exception is thrown in catch block, original stack trace may be lost	69
Deeply nested if..then statements are hard to read	71 - 73

org/apache/myfaces/tobago/facelets/DeprecatedDimensionRule.java

Violation	Line
Parameter 'metadataTarget' is not assigned and could be declared final	37
Parameter 'name' is not assigned and could be declared final	37
Parameter 'attribute' is not assigned and could be declared final	37
Parameter 'attribute' is not assigned and could be declared final	50
Parameter 'ctx' is not assigned and could be declared final	54
Parameter 'instance' is not assigned and could be declared final	54
Local variable 'expression' could be declared final	58
Parameter 'attribute' is not assigned and could be declared final	67
Parameter 'ctx' is not assigned and could be declared final	71
Parameter 'instance' is not assigned and could be declared final	71
Local variable 'expression' could be declared final	75

org/apache/myfaces/tobago/facelets/FixCharacterEncodingFilter.java

Violation	Line
Document empty method	34 - 36
Parameter 'filterConfig' is not assigned and could be declared final	34
Parameter 'servletRequest' is not assigned and could be declared final	38
Parameter 'filterChain' is not assigned and could be declared final	39
Parameter 'servletResponse' is not assigned and could be declared final	39
Document empty method	47 - 48

org/apache/myfaces/tobago/facelets/FlowLayoutRule.java

Violation	Line
The class 'FlowLayoutRule' has a Cyclomatic Complexity of 10 (Highest = 9).	30 - 137
The class 'FlowLayoutRule' has a Cyclomatic Complexity of 10 (Highest = 9).	30 - 137
Parameter 'metadataTarget' is not assigned and could be declared final	34
Parameter 'name' is not assigned and could be declared final	34
Parameter 'attribute' is not assigned and could be declared final	34
The method 'applyRule' has a Cyclomatic Complexity of 9.	34 - 58
These nested if statements could be combined	36 - 55
These nested if statements could be combined	36 - 55
Deeply nested if..then statements are hard to read	37 - 39
Deeply nested if..then statements are hard to read	40 - 42
Deeply nested if..then statements are hard to read	43 - 45
Deeply nested if..then statements are hard to read	46 - 48
Deeply nested if..then statements are hard to read	49 - 51
Deeply nested if..then statements are hard to read	52 - 54
Parameter 'attribute' is not assigned and could be declared final	63
Parameter 'ctx' is not assigned and could be declared final	67
Parameter 'instance' is not assigned and could be declared final	67
Local variable 'gridLayout' could be declared final	68
Parameter 'attribute' is not assigned and could be declared final	76
Parameter 'ctx' is not assigned and could be declared final	80
Parameter 'instance' is not assigned and could be declared final	80
Local variable 'gridLayout' could be declared final	81
Parameter 'attribute' is not assigned and could be declared final	89
Parameter 'ctx' is not assigned and could be declared final	93
Parameter 'instance' is not assigned and could be declared final	93
Local variable 'gridLayout' could be declared final	94
Parameter 'attribute' is not assigned and could be declared final	102
Parameter 'ctx' is not assigned and could be declared final	106
Parameter 'instance' is not assigned and could be declared final	106
Local variable 'gridLayout' could be declared final	107
Parameter 'attribute' is not assigned and could be declared final	115
Parameter 'ctx' is not assigned and could be declared final	119
Parameter 'instance' is not assigned and could be declared final	119
Local variable 'gridLayout' could be declared final	120
Parameter 'attribute' is not assigned and could be declared final	128
Parameter 'ctx' is not assigned and could be declared final	132
Parameter 'instance' is not assigned and could be declared final	132
Local variable 'gridLayout' could be declared final	133

org/apache/myfaces/tobago/facelets/GridLayoutConstraintHandler.java

Violation	Line
The class 'GridLayoutConstraintHandler' has a Cyclomatic Complexity of 32 (Highest = 62).	38 - 343
The class 'GridLayoutConstraintHandler' has a Cyclomatic Complexity of 32 (Highest = 62).	38 - 343
Too many fields	38 - 343
Parameter 'config' is not assigned and could be declared final	72
Avoid reassigning parameters such as 'parent'	98
Avoid reassigning parameters such as 'parent'	98
Parameter 'faceletContext' is not assigned and could be declared final	98
The method 'apply' has a Cyclomatic Complexity of 62.	98 - 342
The method apply() has an NPath complexity of 2106404298	98 - 342
Avoid really long methods.	98 - 342
The method 'apply' has a Cyclomatic Complexity of 62.	98 - 342
The method apply() has an NCSS line count of 140	98 - 342
No need to check for null before an instanceof	100
No need to check for null before an instanceof	102 - 103
Local variable 'component' could be declared final	107
Local variable 'container' could be declared final	240

org/apache/myfaces/tobago/facelets/GridLayoutRule.java

Violation	Line
The class 'GridLayoutRule' has a Cyclomatic Complexity of 12 (Highest = 11).	29 - 168
The class 'GridLayoutRule' has a Cyclomatic Complexity of 12 (Highest = 11).	29 - 168
Parameter 'metadataTarget' is not assigned and could be declared final	33
Parameter 'name' is not assigned and could be declared final	33
Parameter 'attribute' is not assigned and could be declared final	33
The method 'applyRule' has a Cyclomatic Complexity of 11.	33 - 63
The method applyRule() has an NPath complexity of 258	33 - 63
The method 'applyRule' has a Cyclomatic Complexity of 11.	33 - 63
These nested if statements could be combined	35 - 60
These nested if statements could be combined	35 - 60
Deeply nested if..then statements are hard to read	36 - 38
Deeply nested if..then statements are hard to read	39 - 41
Deeply nested if..then statements are hard to read	42 - 44
Deeply nested if..then statements are hard to read	45 - 47
Deeply nested if..then statements are hard to read	48 - 50
Deeply nested if..then statements are hard to read	51 - 53
Deeply nested if..then statements are hard to read	54 - 56
Deeply nested if..then statements are hard to read	57 - 59
Parameter 'attribute' is not assigned and could be declared final	68
Parameter 'ctx' is not assigned and could be declared final	72
Parameter 'instance' is not assigned and could be declared final	72
Local variable 'gridLayout' could be declared final	73
Parameter 'attribute' is not assigned and could be declared final	81
Parameter 'ctx' is not assigned and could be declared final	85
Parameter 'instance' is not assigned and could be declared final	85
Local variable 'gridLayout' could be declared final	86
Parameter 'attribute' is not assigned and could be declared final	94
Parameter 'ctx' is not assigned and could be declared final	98
Parameter 'instance' is not assigned and could be declared final	98
Local variable 'gridLayout' could be declared final	99
Parameter 'attribute' is not assigned and could be declared final	107
Parameter 'ctx' is not assigned and could be declared final	111
Parameter 'instance' is not assigned and could be declared final	111
Local variable 'gridLayout' could be declared final	112
Parameter 'attribute' is not assigned and could be declared final	120
Parameter 'ctx' is not assigned and could be declared final	124
Parameter 'instance' is not assigned and could be declared final	124
Local variable 'gridLayout' could be declared final	125
Parameter 'attribute' is not assigned and could be declared final	133
Parameter 'ctx' is not assigned and could be declared final	137
Parameter 'instance' is not assigned and could be declared final	137
Local variable 'gridLayout' could be declared final	138
Parameter 'attribute' is not assigned and could be declared final	146
Parameter 'ctx' is not assigned and could be declared final	150
Parameter 'instance' is not assigned and could be declared final	150
Local variable 'gridLayout' could be declared final	151
Parameter 'attribute' is not assigned and could be declared final	159
Parameter 'ctx' is not assigned and could be declared final	163
Parameter 'instance' is not assigned and could be declared final	163
Local variable 'gridLayout' could be declared final	164

org/apache/myfaces/tobago/facelets/LoadBundleHandler.java

Violation	Line
Parameter 'config' is not assigned and could be declared final	44
Parameter 'parent' is not assigned and could be declared final	50
Parameter 'faceletContext' is not assigned and could be declared final	50
Local variable 'name' could be declared final	52
Local variable 'map' could be declared final	53
Local variable 'facesContext' could be declared final	54

org/apache/myfaces/tobago/facelets/MetaInfResourcesClasspathResourceResolver.java

Violation	Line
The class 'MetaInfResourcesClasspathResourceResolver' has a Cyclomatic Complexity of 4 (Highest = 5).	43 - 71
Avoid reassigning parameters such as 'path'	53
Avoid reassigning parameters such as 'path'	53
The method 'resolveUrl' has a Cyclomatic Complexity of 5.	53 - 70
This call to String.startsWith can be rewritten using String.charAt(0)	59

org/apache/myfaces/tobago/facelets/PopupReferenceHandler.java

Violation	Line
The class 'PopupReferenceHandler' has a Cyclomatic Complexity of 4 (Highest = 5).	44 - 74
Parameter 'config' is not assigned and could be declared final	48
Parameter 'parent' is not assigned and could be declared final	53
Parameter 'faceletContext' is not assigned and could be declared final	53
The method 'apply' has a Cyclomatic Complexity of 5.	53 - 73
Local variable 'actionSource' could be declared final	57
Local variable 'forValueExpression' could be declared final	61

org/apache/myfaces/tobago/facelets/PositionRule.java

Violation	Line
Parameter 'metadataTarget' is not assigned and could be declared final	37
Parameter 'name' is not assigned and could be declared final	37
Parameter 'attribute' is not assigned and could be declared final	37
Parameter 'attribute' is not assigned and could be declared final	50
Parameter 'ctx' is not assigned and could be declared final	54
Parameter 'instance' is not assigned and could be declared final	54
Local variable 'expression' could be declared final	58
Parameter 'attribute' is not assigned and could be declared final	67
Parameter 'ctx' is not assigned and could be declared final	71
Parameter 'instance' is not assigned and could be declared final	71
Local variable 'expression' could be declared final	75

org/apache/myfaces/tobago/facelets/ResetInputActionListenerHandler.java

Violation	Line
The class 'ResetInputActionListenerHandler' has a Cyclomatic Complexity of 4 (Highest = 6).	41 - 73
Parameter 'config' is not assigned and could be declared final	45
Parameter 'parent' is not assigned and could be declared final	50
Parameter 'faceletContext' is not assigned and could be declared final	50
The method 'apply' has a Cyclomatic Complexity of 6.	50 - 72
Local variable 'actionSource' could be declared final	54
Local variable 'forValueExpression' could be declared final	60

org/apache/myfaces/tobago/facelets/ScriptHandler.java

Violation	Line
Parameter 'config' is not assigned and could be declared final	36
Parameter 'component' is not assigned and could be declared final	40
Parameter 'context' is not assigned and could be declared final	40
Parameter 'parent' is not assigned and could be declared final	40
Local variable 'content' could be declared final	41
Local variable 'iter' could be declared final	42
Local variable 'text' could be declared final	44
Document empty method	53 - 54
Parameter 'c' is not assigned and could be declared final	53
Parameter 'ctx' is not assigned and could be declared final	53

org/apache/myfaces/tobago/facelets/SheetStateChangeSourceRule.java

Violation	Line
Parameter 'name' is not assigned and could be declared final	38
Parameter 'attribute' is not assigned and could be declared final	38
Parameter 'metadataTarget' is not assigned and could be declared final	39
These nested if statements could be combined	41 - 43
These nested if statements could be combined	41 - 43
Parameter 'attribute' is not assigned and could be declared final	52
Parameter 'ctx' is not assigned and could be declared final	56
Parameter 'instance' is not assigned and could be declared final	56

org/apache/myfaces/tobago/facelets/SortActionSourceRule.java

Violation	Line
Parameter 'name' is not assigned and could be declared final	39
Parameter 'attribute' is not assigned and could be declared final	39
Parameter 'metadataTarget' is not assigned and could be declared final	40
These nested if statements could be combined	42 - 44
These nested if statements could be combined	42 - 44
Parameter 'attribute' is not assigned and could be declared final	53
Parameter 'ctx' is not assigned and could be declared final	57
Parameter 'instance' is not assigned and could be declared final	57

org/apache/myfaces/tobago/facelets/StyleHandler.java

Violation	Line
Parameter 'config' is not assigned and could be declared final	35
Parameter 'component' is not assigned and could be declared final	39
Parameter 'context' is not assigned and could be declared final	39
Parameter 'parent' is not assigned and could be declared final	39
Local variable 'content' could be declared final	40
Local variable 'iter' could be declared final	41
Local variable 'text' could be declared final	43
Document empty method	51 - 52
Parameter 'c' is not assigned and could be declared final	51
Parameter 'ctx' is not assigned and could be declared final	51

org/apache/myfaces/tobago/facelets/SuggestMethodRule.java

Violation	Line
Parameter 'name' is not assigned and could be declared final	37
Parameter 'attribute' is not assigned and could be declared final	37
Parameter 'metadataTarget' is not assigned and could be declared final	38
These nested if statements could be combined	40 - 42
These nested if statements could be combined	40 - 42
Parameter 'attribute' is not assigned and could be declared final	50
Parameter 'ctx' is not assigned and could be declared final	54
Parameter 'instance' is not assigned and could be declared final	54

org/apache/myfaces/tobago/facelets/SupportsMarkupRule.java

Violation	Line
Parameter 'metadataTarget' is not assigned and could be declared final	37
Parameter 'name' is not assigned and could be declared final	37
Parameter 'attribute' is not assigned and could be declared final	37
These nested if statements could be combined	39 - 41
These nested if statements could be combined	39 - 41
Parameter 'attribute' is not assigned and could be declared final	50
Parameter 'ctx' is not assigned and could be declared final	54
Parameter 'instance' is not assigned and could be declared final	54
Local variable 'expression' could be declared final	58

org/apache/myfaces/tobago/facelets/SupportsRenderedPartiallyRule.java

Violation	Line
Parameter 'metadataTarget' is not assigned and could be declared final	37
Parameter 'name' is not assigned and could be declared final	37
Parameter 'attribute' is not assigned and could be declared final	37
These nested if statements could be combined	39 - 41
These nested if statements could be combined	39 - 41
Parameter 'attribute' is not assigned and could be declared final	50
Parameter 'ctx' is not assigned and could be declared final	54
Parameter 'instance' is not assigned and could be declared final	54
Local variable 'components' could be declared final	56
Local variable 'expression' could be declared final	59

org/apache/myfaces/tobago/facelets/TabChangeListenerHandler.java

Violation	Line
The class 'TabChangeListenerHandler' has a Cyclomatic Complexity of 7 (Highest = 9).	42 - 104
Parameter 'config' is not assigned and could be declared final	51
Parameter 'parent' is not assigned and could be declared final	67
Parameter 'faceletContext' is not assigned and could be declared final	67
The method 'apply' has a Cyclomatic Complexity of 9.	67 - 103
Local variable 'changeSource' could be declared final	72
New exception is thrown in catch block, original stack trace may be lost	83
Deeply nested if..then statements are hard to read	85 - 87
Avoid if (x != y) ..; else ..;	89 - 98

org/apache/myfaces/tobago/facelets/TabChangeSourceRule.java

Violation	Line
Parameter 'name' is not assigned and could be declared final	38
Parameter 'attribute' is not assigned and could be declared final	38
Parameter 'metadataTarget' is not assigned and could be declared final	39
These nested if statements could be combined	41 - 43
These nested if statements could be combined	41 - 43
Parameter 'attribute' is not assigned and could be declared final	52
Parameter 'ctx' is not assigned and could be declared final	56
Parameter 'instance' is not assigned and could be declared final	56

org/apache/myfaces/tobago/facelets/TobagoComponentHandler.java

Violation	Line
The class 'TobagoComponentHandler' has a Cyclomatic Complexity of 5 (Highest = 11).	48 - 136
The class 'TobagoComponentHandler' has a Cyclomatic Complexity of 5 (Highest = 11).	48 - 136
Parameter 'componentConfig' is not assigned and could be declared final	50
Parameter 'aClass' is not assigned and could be declared final	54
The method 'createMetaRuleset' has a Cyclomatic Complexity of 11.	54 - 87
The method createMetaRuleset() has an NPath complexity of 1024	54 - 87
The method 'createMetaRuleset' has a Cyclomatic Complexity of 11.	54 - 87
Local variable 'metaRuleset' could be declared final	55
Parameter 'component' is not assigned and could be declared final	89
Parameter 'context' is not assigned and could be declared final	89
Parameter 'parent' is not assigned and could be declared final	89
Parameter 'component' is not assigned and could be declared final	97
Parameter 'context' is not assigned and could be declared final	97
Parameter 'parent' is not assigned and could be declared final	97
Parameter 'component' is not assigned and could be declared final	109
Parameter 'context' is not assigned and could be declared final	109
The method 'addDefaultValidators' has a Cyclomatic Complexity of 7.	109 - 135
Local variable 'tobagoConfig' could be declared final	110
Local variable 'validatorInfoMap' could be declared final	111
Local variable 'validators' could be declared final	115
Local variable 'classNames' could be declared final	117
Local variable 'it' could be declared final	122
Local variable 'entry' could be declared final	124
Local variable 'it' could be declared final	130

org/apache/myfaces/tobago/facelets/TobagoValidateHandler.java

Violation	Line
Parameter 'config' is not assigned and could be declared final	27
Parameter 'aClass' is not assigned and could be declared final	31
Local variable 'metaRuleset' could be declared final	32

org/apache/myfaces/tobago/facelets/WizardComponentHandler.java

Violation	Line
Private field 'outcomeAttribute' could be made final; it is only initialized in the declaration or constructor.	30
Parameter 'componentConfig' is not assigned and could be declared final	32
Parameter 'parent' is not assigned and could be declared final	37
Parameter 'wizard' is not assigned and could be declared final	37
Parameter 'faceletContext' is not assigned and could be declared final	37
Local variable 'expression' could be declared final	43

org/apache/myfaces/tobago/facelets/extension/DateExtensionHandler.java

Violation	Line
Parameter 'config' is not assigned and could be declared final	34
Parameter 'panel' is not assigned and could be declared final	46
Parameter 'parent' is not assigned and could be declared final	46
Parameter 'faceletContext' is not assigned and could be declared final	46
Local variable 'application' could be declared final	49
Local variable 'picker' could be declared final	50
Local variable 'root' could be declared final	53
Parameter 'first' is not assigned and could be declared final	63

org/apache/myfaces/tobago/facelets/extension/FileExtensionHandler.java

Violation	Line
Parameter 'config' is not assigned and could be declared final	30

org/apache/myfaces/tobago/facelets/extension/InExtensionHandler.java

Violation	Line
Parameter 'config' is not assigned and could be declared final	26

org/apache/myfaces/tobago/facelets/extension/MenuCheckboxExtensionHandler.java

Violation	Line
Parameter 'config' is not assigned and could be declared final	38

org/apache/myfaces/tobago/facelets/extension/MenuRadioExtensionHandler.java

Violation	Line
Parameter 'config' is not assigned and could be declared final	42

org/apache/myfaces/tobago/facelets/extension/SelectBooleanCheckboxExtensionHandler.java

Violation	Line
Private field 'itemLabelAttribute' could be made final; it is only initialized in the declaration or constructor.	33
Parameter 'config' is not assigned and could be declared final	35
Parameter 'input' is not assigned and could be declared final	40
Parameter 'faceletContext' is not assigned and could be declared final	40
Local variable 'checkbox' could be declared final	42
Avoid if (x != y) ..; else ..;	43 - 52
Local variable 'expression' could be declared final	47

org/apache/myfaces/tobago/facelets/extension/SelectManyCheckboxExtensionHandler.java

Violation	Line
Parameter 'config' is not assigned and could be declared final	26

org/apache/myfaces/tobago/facelets/extension/SelectManyListboxExtensionHandler.java

Violation	Line
Parameter 'config' is not assigned and could be declared final	30

org/apache/myfaces/tobago/facelets/extension/SelectManyShuttleExtensionHandler.java

Violation	Line
Parameter 'config' is not assigned and could be declared final	26

org/apache/myfaces/tobago/facelets/extension/SelectOneChoiceExtensionHandler.java

Violation	Line
Parameter 'config' is not assigned and could be declared final	30

org/apache/myfaces/tobago/facelets/extension/SelectOneListboxExtensionHandler.java

Violation	Line
Parameter 'config' is not assigned and could be declared final	30

org/apache/myfaces/tobago/facelets/extension/SelectOneRadioExtensionHandler.java

Violation	Line
Parameter 'config' is not assigned and could be declared final	26

org/apache/myfaces/tobago/facelets/extension/SeparatorExtensionHandler.java

Violation	Line
Private field 'labelAttribute' could be made final; it is only initialized in the declaration or constructor.	42
Parameter 'config' is not assigned and could be declared final	44
Parameter 'faceletContext' is not assigned and could be declared final	49
Parameter 'separator' is not assigned and could be declared final	49
Local variable 'component' could be declared final	52
Parameter 'parent' is not assigned and could be declared final	60
Parameter 'faceletContext' is not assigned and could be declared final	60
Parameter 'separator' is not assigned and could be declared final	60
Local variable 'application' could be declared final	61
Local variable 'root' could be declared final	62
Local variable 'label' could be declared final	63
Local variable 'expression' could be declared final	72
Parameter 'aClass' is not assigned and could be declared final	78
Local variable 'metaRuleset' could be declared final	79
Local variable 'attrs' could be declared final	84
Local variable 'attr' could be declared final	86

org/apache/myfaces/tobago/facelets/extension/TextareaExtensionHandler.java

Violation	Line
Parameter 'config' is not assigned and could be declared final	30

org/apache/myfaces/tobago/facelets/extension/TimeExtensionHandler.java

Violation	Line
Parameter 'config' is not assigned and could be declared final	26

org/apache/myfaces/tobago/facelets/extension/TobagoExtensionTagLibrary.java

Violation	Line
The String literal "Panel" appears 12 times in this file; the first occurrence is on line 30	30

org/apache/myfaces/tobago/facelets/extension/TobagoLabelExtensionHandler.java

Violation	Line
A high number of imports can indicate a high degree of coupling within an object.	1 - 267
The class 'TobagoLabelExtensionHandler' has a Cyclomatic Complexity of 3 (Highest = 8).	60 - 267
Private field 'labelWidthAttribute' could be made final; it is only initialized in the declaration or constructor.	63
Private field 'tipAttribute' could be made final; it is only initialized in the declaration or constructor.	64
Private field 'labelAttribute' could be made final; it is only initialized in the declaration or constructor.	65
Private field 'markupAttribute' could be made final; it is only initialized in the declaration or constructor.	66
Private field 'fieldIdAttribute' could be made final; it is only initialized in the declaration or constructor.	67
Parameter 'config' is not assigned and could be declared final	71
Parameter 'first' is not assigned and could be declared final	88
Parameter 'panel' is not assigned and could be declared final	92
Parameter 'ctx' is not assigned and could be declared final	92
Local variable 'input' could be declared final	96
Local variable 'input' could be declared final	112
Parameter 'panel' is not assigned and could be declared final	117
Parameter 'parent' is not assigned and could be declared final	117
Parameter 'faceletContext' is not assigned and could be declared final	117
Local variable 'application' could be declared final	119
Local variable 'root' could be declared final	120
Avoid if (x != y) ..; else ..;	126 - 130
Local variable 'input' could be declared final	135
Document empty method	145 - 146
An empty method in an abstract class should be abstract instead	145 - 146
Parameter 'input' is not assigned and could be declared final	145
Parameter 'faceletContext' is not assigned and could be declared final	145
Parameter 'panel' is not assigned and could be declared final	148
Parameter 'root' is not assigned and could be declared final	148
Parameter 'faceletContext' is not assigned and could be declared final	148
The method 'addLabel' has a Cyclomatic Complexity of 8.	148 - 183
Local variable 'uid' could be declared final	149
Local variable 'application' could be declared final	153
Local variable 'label' could be declared final	154
Local variable 'expression' could be declared final	162
Local variable 'expression' could be declared final	170
Local variable 'expression' could be declared final	178
Parameter 'panel' is not assigned and could be declared final	185
Parameter 'uid' is not assigned and could be declared final	185
Local variable 'list' could be declared final	187
Local variable 'child' could be declared final	189
Parameter 'component' is not assigned and could be declared final	198
Parameter 'parent' is not assigned and could be declared final	198
Parameter 'faceletContext' is not assigned and could be declared final	198
Parameter 'panel' is not assigned and could be declared final	206
Parameter 'root' is not assigned and could be declared final	206
Parameter 'faceletContext' is not assigned and could be declared final	206
The method 'addGridLayout' has a Cyclomatic Complexity of 5.	206 - 229
Local variable 'application' could be declared final	207
Local variable 'gridLayout' could be declared final	208
Avoid if (x != y) ..; else ..;	210 - 219
Parameter 'ctx' is not assigned and could be declared final	231
Parameter 'instance' is not assigned and could be declared final	231
Local variable 'type' could be declared final	233
Parameter 'aClass' is not assigned and could be declared final	242
Local variable 'metaRuleset' could be declared final	243
Parameter 'aClass' is not assigned and could be declared final	256
Local variable 'metaRuleset' could be declared final	257
Local variable 'attrs' could be declared final	258
Local variable 'attr' could be declared final	260

org/apache/myfaces/tobago/facelets/extension/TobagoMenuExtensionHandler.java

Violation	Line
Parameter 'config' is not assigned and could be declared final	45
Parameter 'menuCommand' is not assigned and could be declared final	55
Parameter 'faceletContext' is not assigned and could be declared final	55
Local variable 'component' could be declared final	58
Parameter 'menuCommand' is not assigned and could be declared final	66
Parameter 'parent' is not assigned and could be declared final	66
Parameter 'faceletContext' is not assigned and could be declared final	66
Local variable 'application' could be declared final	68
Local variable 'root' could be declared final	69
Local variable 'component' could be declared final	70
Parameter 'ctx' is not assigned and could be declared final	77
Parameter 'instance' is not assigned and could be declared final	77
Local variable 'type' could be declared final	79
Parameter 'aClass' is not assigned and could be declared final	88
Local variable 'metaRuleset' could be declared final	89
Local variable 'attrs' could be declared final	90
Local variable 'attr' could be declared final	92
Parameter 'aClass' is not assigned and could be declared final	101
Local variable 'metaRuleset' could be declared final	102