PMD Results
The following document contains the results of PMD 4.2.5.
Files
org/apache/myfaces/tobago/ajax/api/AjaxUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 36 - 158 |
| This class has too many methods, consider refactoring it. | 36 - 158 |
| Parameter 'facesContext' is not assigned and could be declared final | 51 |
| Parameter 'compClass' is not assigned and could be declared final | 51 |
| Parameter 'uiComponent' is not assigned and could be declared final | 51 |
| Parameter 'component' is not assigned and could be declared final | 59 |
| Parameter 'facesContext' is not assigned and could be declared final | 59 |
| Parameter 'facesContext' is not assigned and could be declared final | 67 |
| Parameter 'facesContext' is not assigned and could be declared final | 75 |
| Parameter 'facesContext' is not assigned and could be declared final | 83 |
| Parameter 'facesContext' is not assigned and could be declared final | 91 |
| Parameter 'clientId' is not assigned and could be declared final | 91 |
| Parameter 'facesContext' is not assigned and could be declared final | 99 |
| Parameter 'clientId' is not assigned and could be declared final | 99 |
| Parameter 'component' is not assigned and could be declared final | 107 |
| Parameter 'facesContext' is not assigned and could be declared final | 107 |
| Parameter 'facesContext' is not assigned and could be declared final | 115 |
| Parameter 'clientId' is not assigned and could be declared final | 115 |
| Parameter 'component' is not assigned and could be declared final | 123 |
| Parameter 'facesContext' is not assigned and could be declared final | 123 |
| Parameter 'value' is not assigned and could be declared final | 131 |
| Parameter 'facesContext' is not assigned and could be declared final | 139 |
| Parameter 'url' is not assigned and could be declared final | 139 |
| Parameter 'response' is not assigned and could be declared final | 147 |
| Parameter 'url' is not assigned and could be declared final | 147 |
| Parameter 'context' is not assigned and could be declared final | 155 |
org/apache/myfaces/tobago/application/LabelValueBindingFacesMessage.java
| Violation | Line |
|---|---|
| The class 'LabelValueBindingFacesMessage' has a Cyclomatic Complexity of 2 (Highest = 5). | 34 - 86 |
| Parameter 'summary' is not assigned and could be declared final | 43 |
| Parameter 'detail' is not assigned and could be declared final | 43 |
| Parameter 'severity' is not assigned and could be declared final | 43 |
| Parameter 'args' is not assigned and could be declared final | 44 |
| Parameter 'locale' is not assigned and could be declared final | 44 |
| Parameter 'summary' is not assigned and could be declared final | 50 |
| Parameter 'detail' is not assigned and could be declared final | 50 |
| Parameter 'summary' is not assigned and could be declared final | 54 |
| The method 'getDetail' has a Cyclomatic Complexity of 5. | 59 - 70 |
| Local variable 'detail' could be declared final | 60 |
| Local variable 'facesContext' could be declared final | 63 |
| Local variable 'value' could be declared final | 64 |
| The method 'getSummary' has a Cyclomatic Complexity of 5. | 73 - 84 |
| Local variable 'summary' could be declared final | 74 |
| Local variable 'facesContext' could be declared final | 77 |
| Local variable 'value' could be declared final | 78 |
org/apache/myfaces/tobago/bean/ResourceMap.java
| Violation | Line |
|---|---|
| The class 'ResourceMap' has a Cyclomatic Complexity of 4 (Highest = 6). | 33 - 90 |
| Parameter 'filename' is not assigned and could be declared final | 44 |
| The method 'setFilename' has a Cyclomatic Complexity of 6. | 44 - 63 |
| Local variable 'is' could be declared final | 49 |
| Parameter 'value' is not assigned and could be declared final | 69 |
| Parameter 'key' is not assigned and could be declared final | 69 |
| Parameter 'key' is not assigned and could be declared final | 80 |
| Local variable 'value' could be declared final | 81 |
org/apache/myfaces/tobago/compat/FacesInvokeOnComponent12.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 33 - 83 |
| The class 'FacesInvokeOnComponent12' has a Cyclomatic Complexity of 4 (Highest = 7). | 33 - 83 |
| The method 'invokeOnComponent' has a Cyclomatic Complexity of 7. | 42 - 67 |
| Parameter 'component' is not assigned and could be declared final | 43 |
| Parameter 'context' is not assigned and could be declared final | 43 |
| Parameter 'callback' is not assigned and could be declared final | 43 |
| Parameter 'clientId' is not assigned and could be declared final | 43 |
| Local variable 'thisClientId' could be declared final | 44 |
| These nested if statements could be combined | 56 - 58 |
| These nested if statements could be combined | 56 - 58 |
| Parameter 'component' is not assigned and could be declared final | 74 |
| Parameter 'context' is not assigned and could be declared final | 74 |
| Parameter 'callback' is not assigned and could be declared final | 74 |
| Parameter 'clientId' is not assigned and could be declared final | 74 |
| Local variable 'it' could be declared final | 75 |
| Local variable 'child' could be declared final | 76 |
org/apache/myfaces/tobago/compat/FacesUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 42 - 239 |
| The class 'FacesUtils' has a Cyclomatic Complexity of 1 (Highest = 5). | 42 - 239 |
| Parameter 'component' is not assigned and could be declared final | 58 |
| Parameter 'context' is not assigned and could be declared final | 58 |
| Parameter 'callback' is not assigned and could be declared final | 58 |
| Parameter 'clientId' is not assigned and could be declared final | 58 |
| Parameter 'facesContext' is not assigned and could be declared final | 66 |
| Parameter 'event' is not assigned and could be declared final | 66 |
| Parameter 'methodBinding' is not assigned and could be declared final | 66 |
| The method 'invokeMethodBinding' has a Cyclomatic Complexity of 5. | 66 - 79 |
| Local variable 'cause' could be declared final | 71 |
| Parameter 'component' is not assigned and could be declared final | 86 |
| Parameter 'name' is not assigned and could be declared final | 86 |
| Parameter 'context' is not assigned and could be declared final | 86 |
| Parameter 'component' is not assigned and could be declared final | 94 |
| Parameter 'name' is not assigned and could be declared final | 94 |
| Parameter 'component' is not assigned and could be declared final | 103 |
| Parameter 'name' is not assigned and could be declared final | 103 |
| Parameter 'context' is not assigned and could be declared final | 103 |
| Parameter 'component' is not assigned and could be declared final | 111 |
| Parameter 'name' is not assigned and could be declared final | 111 |
| Parameter 'component' is not assigned and could be declared final | 120 |
| Parameter 'context' is not assigned and could be declared final | 120 |
| Parameter 'value' is not assigned and could be declared final | 120 |
| Parameter 'bindingName' is not assigned and could be declared final | 120 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 129 |
| Parameter 'context' is not assigned and could be declared final | 129 |
| Parameter 'value' is not assigned and could be declared final | 129 |
| Parameter 'fromComponent' is not assigned and could be declared final | 138 |
| Parameter 'toName' is not assigned and could be declared final | 138 |
| Parameter 'fromName' is not assigned and could be declared final | 138 |
| Parameter 'toComponent' is not assigned and could be declared final | 138 |
| Parameter 'obj' is not assigned and could be declared final | 146 |
| Parameter 'string' is not assigned and could be declared final | 154 |
| Parameter 'editableValueHolder' is not assigned and could be declared final | 162 |
| Parameter 'validator' is not assigned and could be declared final | 162 |
| Parameter 'valueHolder' is not assigned and could be declared final | 170 |
| Parameter 'converterExpression' is not assigned and could be declared final | 170 |
| Parameter 'component' is not assigned and could be declared final | 178 |
| Parameter 'valueBindingOrExpression' is not assigned and could be declared final | 178 |
| Parameter 'name' is not assigned and could be declared final | 178 |
| Parameter 'component' is not assigned and could be declared final | 186 |
| Parameter 'valueBindingOrExpression' is not assigned and could be declared final | 186 |
| Parameter 'name' is not assigned and could be declared final | 186 |
| Parameter 'source' is not assigned and could be declared final | 194 |
| Parameter 'type' is not assigned and could be declared final | 194 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 195 |
| Parameter 'child' is not assigned and could be declared final | 204 |
| Parameter 'facesContext' is not assigned and could be declared final | 204 |
| Parameter 'var' is not assigned and could be declared final | 204 |
| Parameter 'comparator' is not assigned and could be declared final | 204 |
| Parameter 'descending' is not assigned and could be declared final | 204 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 212 |
| Parameter 'actionSource' is not assigned and could be declared final | 212 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 220 |
| Parameter 'actionSource' is not assigned and could be declared final | 220 |
| Parameter 'facesContext' is not assigned and could be declared final | 228 |
org/apache/myfaces/tobago/component/ComponentUtil.java
| Violation | Line |
|---|---|
| This class has a bunch of public methods and attributes | 20 - 421 |
| A class which only has private constructors should be final | 56 - 421 |
| This class has too many methods, consider refactoring it. | 56 - 421 |
| Parameter 'context' is not assigned and could be declared final | 66 |
| Parameter 'command' is not assigned and could be declared final | 70 |
| Parameter 'component' is not assigned and could be declared final | 74 |
| Parameter 'facesContext' is not assigned and could be declared final | 74 |
| Parameter 'component' is not assigned and could be declared final | 78 |
| Parameter 'context' is not assigned and could be declared final | 82 |
| Parameter 'component' is not assigned and could be declared final | 86 |
| Parameter 'context' is not assigned and could be declared final | 86 |
| Parameter 'component' is not assigned and could be declared final | 90 |
| Parameter 'component' is not assigned and could be declared final | 94 |
| Parameter 'styles' is not assigned and could be declared final | 94 |
| Parameter 'scripts' is not assigned and could be declared final | 98 |
| Parameter 'component' is not assigned and could be declared final | 98 |
| Parameter 'cmds' is not assigned and could be declared final | 102 |
| Parameter 'component' is not assigned and could be declared final | 102 |
| Parameter 'facesContext' is not assigned and could be declared final | 106 |
| Parameter 'component' is not assigned and could be declared final | 110 |
| Parameter 'component' is not assigned and could be declared final | 114 |
| Parameter 'component' is not assigned and could be declared final | 118 |
| Parameter 'type' is not assigned and could be declared final | 118 |
| Parameter 'component' is not assigned and could be declared final | 122 |
| Parameter 'facesContext' is not assigned and could be declared final | 122 |
| Parameter 'component' is not assigned and could be declared final | 126 |
| Parameter 'component' is not assigned and could be declared final | 130 |
| Parameter 'uiInput' is not assigned and could be declared final | 134 |
| Parameter 'component' is not assigned and could be declared final | 138 |
| Parameter 'component' is not assigned and could be declared final | 142 |
| Parameter 'component' is not assigned and could be declared final | 146 |
| Parameter 'component' is not assigned and could be declared final | 150 |
| Parameter 'component' is not assigned and could be declared final | 154 |
| Parameter 'name' is not assigned and could be declared final | 154 |
| Parameter 'renderers' is not assigned and could be declared final | 158 |
| Parameter 'command' is not assigned and could be declared final | 158 |
| Parameter 'styleClasses' is not assigned and could be declared final | 162 |
| Parameter 'component' is not assigned and could be declared final | 162 |
| Parameter 'markup' is not assigned and could be declared final | 166 |
| Parameter 'markupComponent' is not assigned and could be declared final | 166 |
| Parameter 'component' is not assigned and could be declared final | 170 |
| Parameter 'name' is not assigned and could be declared final | 170 |
| Parameter 'component' is not assigned and could be declared final | 174 |
| Parameter 'name' is not assigned and could be declared final | 174 |
| Parameter 'component' is not assigned and could be declared final | 178 |
| Parameter 'name' is not assigned and could be declared final | 178 |
| Parameter 'component' is not assigned and could be declared final | 182 |
| Parameter 'name' is not assigned and could be declared final | 182 |
| Parameter 'defaultValue' is not assigned and could be declared final | 182 |
| Parameter 'component' is not assigned and could be declared final | 186 |
| Parameter 'name' is not assigned and could be declared final | 186 |
| Parameter 'component' is not assigned and could be declared final | 190 |
| Parameter 'parent' is not assigned and could be declared final | 190 |
| Parameter 'component' is not assigned and could be declared final | 194 |
| Parameter 'facesContext' is not assigned and could be declared final | 194 |
| Parameter 'rendererType' is not assigned and could be declared final | 198 |
| Parameter 'facesContext' is not assigned and could be declared final | 198 |
| Parameter 'family' is not assigned and could be declared final | 198 |
| Parameter 'component' is not assigned and could be declared final | 202 |
| Parameter 'component' is not assigned and could be declared final | 206 |
| Parameter 'component' is not assigned and could be declared final | 210 |
| Parameter 'name' is not assigned and could be declared final | 210 |
| Parameter 'component' is not assigned and could be declared final | 214 |
| Parameter 'offset' is not assigned and could be declared final | 214 |
| Parameter 'type' is not assigned and could be declared final | 218 |
| Parameter 'component' is not assigned and could be declared final | 222 |
| Parameter 'component' is not assigned and could be declared final | 229 |
| Parameter 'component' is not assigned and could be declared final | 234 |
| Parameter 'component' is not assigned and could be declared final | 238 |
| Parameter 'name' is not assigned and could be declared final | 238 |
| Parameter 'value' is not assigned and could be declared final | 238 |
| Parameter 'value' is not assigned and could be declared final | 242 |
| Parameter 'component' is not assigned and could be declared final | 246 |
| Parameter 'name' is not assigned and could be declared final | 246 |
| Parameter 'value' is not assigned and could be declared final | 246 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 251 |
| Parameter 'component' is not assigned and could be declared final | 256 |
| Parameter 'name' is not assigned and could be declared final | 256 |
| Parameter 'value' is not assigned and could be declared final | 256 |
| Parameter 'component' is not assigned and could be declared final | 266 |
| Parameter 'name' is not assigned and could be declared final | 266 |
| Parameter 'value' is not assigned and could be declared final | 266 |
| Parameter 'name' is not assigned and could be declared final | 276 |
| Parameter 'value' is not assigned and could be declared final | 276 |
| Parameter 'value' is not assigned and could be declared final | 280 |
| Avoid reassigning parameters such as 'script' | 284 |
| Local variable 'valueBinding' could be declared final | 286 |
| Parameter 'id' is not assigned and could be declared final | 292 |
| Parameter 'rendererType' is not assigned and could be declared final | 292 |
| Parameter 'componentType' is not assigned and could be declared final | 292 |
| Parameter 'facesContext' is not assigned and could be declared final | 296 |
| Parameter 'componentType' is not assigned and could be declared final | 296 |
| Parameter 'id' is not assigned and could be declared final | 297 |
| Parameter 'rendererType' is not assigned and could be declared final | 297 |
| Parameter 'rendererType' is not assigned and could be declared final | 307 |
| Parameter 'facesContext' is not assigned and could be declared final | 307 |
| Parameter 'componentType' is not assigned and could be declared final | 307 |
| Parameter 'id' is not assigned and could be declared final | 311 |
| Parameter 'sortable' is not assigned and could be declared final | 311 |
| Parameter 'align' is not assigned and could be declared final | 311 |
| Parameter 'value' is not assigned and could be declared final | 311 |
| Parameter 'label' is not assigned and could be declared final | 311 |
| Parameter 'child' is not assigned and could be declared final | 315 |
| Parameter 'sortable' is not assigned and could be declared final | 315 |
| Parameter 'align' is not assigned and could be declared final | 315 |
| Parameter 'label' is not assigned and could be declared final | 315 |
| Parameter 'child' is not assigned and could be declared final | 319 |
| Parameter 'id' is not assigned and could be declared final | 319 |
| Parameter 'sortable' is not assigned and could be declared final | 319 |
| Parameter 'align' is not assigned and could be declared final | 319 |
| Parameter 'label' is not assigned and could be declared final | 319 |
| Parameter 'id' is not assigned and could be declared final | 323 |
| Parameter 'facesContext' is not assigned and could be declared final | 323 |
| Parameter 'command' is not assigned and could be declared final | 323 |
| Parameter 'items' is not assigned and could be declared final | 327 |
| Parameter 'value' is not assigned and could be declared final | 327 |
| Parameter 'id' is not assigned and could be declared final | 331 |
| Parameter 'facesContext' is not assigned and could be declared final | 331 |
| Parameter 'command' is not assigned and could be declared final | 331 |
| Parameter 'valueBinding' is not assigned and could be declared final | 335 |
| Parameter 'postfix' is not assigned and could be declared final | 339 |
| Parameter 'component' is not assigned and could be declared final | 339 |
| Parameter 'facesContext' is not assigned and could be declared final | 339 |
| Parameter 'component' is not assigned and could be declared final | 343 |
| Parameter 'facesContext' is not assigned and could be declared final | 343 |
| Parameter 'component' is not assigned and could be declared final | 347 |
| Parameter 'facesContext' is not assigned and could be declared final | 347 |
| Parameter 'component' is not assigned and could be declared final | 351 |
| Parameter 'component' is not assigned and could be declared final | 355 |
| Parameter 'editableValueHolder' is not assigned and could be declared final | 359 |
| Parameter 'validator' is not assigned and could be declared final | 359 |
| Parameter 'converterId' is not assigned and could be declared final | 363 |
| Parameter 'valueHolder' is not assigned and could be declared final | 363 |
| Parameter 'component' is not assigned and could be declared final | 367 |
| Parameter 'action' is not assigned and could be declared final | 367 |
| Parameter 'type' is not assigned and could be declared final | 367 |
| Parameter 'suggestMethod' is not assigned and could be declared final | 371 |
| Parameter 'component' is not assigned and could be declared final | 371 |
| Parameter 'actionListener' is not assigned and could be declared final | 384 |
| Parameter 'command' is not assigned and could be declared final | 384 |
| Parameter 'valueChangeListener' is not assigned and could be declared final | 388 |
| Parameter 'valueHolder' is not assigned and could be declared final | 388 |
| Parameter 'component' is not assigned and could be declared final | 392 |
| Parameter 'name' is not assigned and could be declared final | 392 |
| Parameter 'state' is not assigned and could be declared final | 392 |
| Parameter 'data' is not assigned and could be declared final | 396 |
| Parameter 'stateChangeListener' is not assigned and could be declared final | 396 |
| Local variable 'arguments' could be declared final | 402 |
| Local variable 'binding' could be declared final | 403 - 404 |
| Parameter 'component' is not assigned and could be declared final | 414 |
| Parameter 'facesContext' is not assigned and could be declared final | 414 |
| Parameter 'relativeId' is not assigned and could be declared final | 418 |
| Parameter 'from' is not assigned and could be declared final | 418 |
org/apache/myfaces/tobago/config/ThemeConfig.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 29 - 53 |
| Parameter 'component' is not assigned and could be declared final | 38 |
| Parameter 'facesContext' is not assigned and could be declared final | 38 |
| Parameter 'name' is not assigned and could be declared final | 38 |
| Parameter 'component' is not assigned and could be declared final | 48 |
| Parameter 'facesContext' is not assigned and could be declared final | 48 |
| Parameter 'name' is not assigned and could be declared final | 48 |
org/apache/myfaces/tobago/context/ResourceManagerFactory.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 32 - 75 |
| Parameter 'facesContext' is not assigned and could be declared final | 48 |
| Parameter 'servletContext' is not assigned and could be declared final | 56 |
| Parameter 'servletContext' is not assigned and could be declared final | 64 |
| Parameter 'tobagoConfig' is not assigned and could be declared final | 64 |
| Parameter 'servletContext' is not assigned and could be declared final | 72 |
org/apache/myfaces/tobago/context/ResourceManagerUtil.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 33 - 196 |
| Parameter 'facesContext' is not assigned and could be declared final | 43 |
| Parameter 'bundle' is not assigned and could be declared final | 43 |
| Parameter 'key' is not assigned and could be declared final | 43 |
| Parameter 'facesContext' is not assigned and could be declared final | 51 |
| Parameter 'bundle' is not assigned and could be declared final | 51 |
| Parameter 'key' is not assigned and could be declared final | 51 |
| Local variable 'result' could be declared final | 52 |
| Parameter 'facesContext' is not assigned and could be declared final | 64 |
| Parameter 'name' is not assigned and could be declared final | 64 |
| Parameter 'facesContext' is not assigned and could be declared final | 73 |
| Parameter 'name' is not assigned and could be declared final | 73 |
| Parameter 'ignoreMissing' is not assigned and could be declared final | 73 |
| Local variable 'image' could be declared final | 74 |
| Parameter 'facesContext' is not assigned and could be declared final | 86 |
| Parameter 'name' is not assigned and could be declared final | 86 |
| Local variable 'contextPath' could be declared final | 87 |
| Local variable 'styles' could be declared final | 88 |
| Parameter 'strings' is not assigned and could be declared final | 96 |
| Parameter 'contextPath' is not assigned and could be declared final | 96 |
| Local variable 'withContext' could be declared final | 97 |
| Parameter 'facesContext' is not assigned and could be declared final | 108 |
| Parameter 'name' is not assigned and could be declared final | 108 |
| Local variable 'contextPath' could be declared final | 109 |
| Local variable 'scripts' could be declared final | 110 |
| Parameter 'facesContext' is not assigned and could be declared final | 118 |
| Parameter 'names' is not assigned and could be declared final | 118 |
| Local variable 'fileNames' could be declared final | 119 |
| Parameter 'facesContext' is not assigned and could be declared final | 130 |
| Parameter 'names' is not assigned and could be declared final | 130 |
| Local variable 'fileNames' could be declared final | 131 |
| Parameter 'list' is not assigned and could be declared final | 142 |
| Local variable 'sb' could be declared final | 143 |
| Parameter 'facesContext' is not assigned and could be declared final | 159 |
| Parameter 'image' is not assigned and could be declared final | 159 |
| Local variable 'filename' could be declared final | 160 |
| Parameter 'facesContext' is not assigned and could be declared final | 168 |
| Parameter 'facesContext' is not assigned and could be declared final | 176 |
| Parameter 'name' is not assigned and could be declared final | 176 |
| Parameter 'configurable' is not assigned and could be declared final | 184 |
| Parameter 'facesContext' is not assigned and could be declared final | 184 |
| Parameter 'name' is not assigned and could be declared final | 184 |
| Parameter 'value' is not assigned and could be declared final | 192 |
org/apache/myfaces/tobago/event/PageActionUtil.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 29 - 52 |
| Parameter 'name' is not assigned and could be declared final | 44 |
| Local variable 'value' could be declared final | 45 |
| Avoid if (x != y) ..; else ..; | 46 - 50 |
org/apache/myfaces/tobago/event/ValueBindingPopupActionListener.java
| Violation | Line |
|---|---|
| Document empty constructor | 47 - 48 |
| Parameter 'binding' is not assigned and could be declared final | 50 |
| Parameter 'actionEvent' is not assigned and could be declared final | 55 |
| Local variable 'id' could be declared final | 56 |
| Local variable 'popup' could be declared final | 57 |
| Parameter 'context' is not assigned and could be declared final | 73 |
| Parameter 'state' is not assigned and could be declared final | 73 |
| Local variable 'values' could be declared final | 74 |
| Parameter 'context' is not assigned and could be declared final | 78 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 85 |
org/apache/myfaces/tobago/event/ValueBindingResetInputActionListener.java
| Violation | Line |
|---|---|
| The class 'ValueBindingResetInputActionListener' has a Cyclomatic Complexity of 2 (Highest = 5). | 40 - 93 |
| Document empty constructor | 48 - 49 |
| Parameter 'binding' is not assigned and could be declared final | 51 |
| Parameter 'event' is not assigned and could be declared final | 55 |
| The method 'processAction' has a Cyclomatic Complexity of 5. | 55 - 72 |
| Local variable 'obj' could be declared final | 56 |
| Local variable 'component' could be declared final | 67 |
| Parameter 'context' is not assigned and could be declared final | 78 |
| Parameter 'state' is not assigned and could be declared final | 78 |
| Local variable 'values' could be declared final | 79 |
| Parameter 'context' is not assigned and could be declared final | 83 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 89 |
org/apache/myfaces/tobago/event/ValueBindingTabChangeListener.java
| Violation | Line |
|---|---|
| The class 'ValueBindingTabChangeListener' has a Cyclomatic Complexity of 2 (Highest = 8). | 34 - 105 |
| Document empty constructor | 39 - 40 |
| Parameter 'type' is not assigned and could be declared final | 42 |
| Parameter 'valueBinding' is not assigned and could be declared final | 42 |
| Parameter 'tabChangeEvent' is not assigned and could be declared final | 47 |
| Local variable 'handler' could be declared final | 48 |
| Avoid if (x != y) ..; else ..; | 49 - 53 |
| Parameter 'context' is not assigned and could be declared final | 56 |
| Parameter 'context' is not assigned and could be declared final | 63 |
| Parameter 'state' is not assigned and could be declared final | 63 |
| Local variable 'values' could be declared final | 64 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 74 |
| The method 'getTabChangeListener' has a Cyclomatic Complexity of 8. | 78 - 93 |
| Local variable 'obj' could be declared final | 81 |
| No need to check for null before an instanceof | 82 |
| Parameter 'className' is not assigned and could be declared final | 95 |
| Local variable 'clazz' could be declared final | 97 |
org/apache/myfaces/tobago/internal/application/ViewHandlerImpl.java
| Violation | Line |
|---|---|
| Private field 'base' could be made final; it is only initialized in the declaration or constructor. | 45 |
| Parameter 'base' is not assigned and could be declared final | 47 |
| Parameter 'facesContext' is not assigned and could be declared final | 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 58 |
| Parameter 'facesContext' is not assigned and could be declared final | 62 |
| Parameter 'viewId' is not assigned and could be declared final | 62 |
| Parameter 'facesContext' is not assigned and could be declared final | 83 |
| Parameter 'viewId' is not assigned and could be declared final | 83 |
| Parameter 'facesContext' is not assigned and could be declared final | 92 |
| Parameter 'path' is not assigned and could be declared final | 92 |
| Parameter 'facesContext' is not assigned and could be declared final | 96 |
| Parameter 'viewRoot' is not assigned and could be declared final | 96 |
| Parameter 'facesContext' is not assigned and could be declared final | 107 |
| Parameter 'viewId' is not assigned and could be declared final | 107 |
| Local variable 'viewRoot' could be declared final | 114 |
| Consider simply returning the value vs storing it in local variable 'viewRoot' | 115 |
| Parameter 'facesContext' is not assigned and could be declared final | 118 |
org/apache/myfaces/tobago/internal/lifecycle/ApplyRequestValuesExecutor.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 37 |
org/apache/myfaces/tobago/internal/lifecycle/InvokeApplicationExecutor.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 36 |
org/apache/myfaces/tobago/internal/lifecycle/PhaseListenerManager.java
| Violation | Line |
|---|---|
| The class 'PhaseListenerManager' has a Cyclomatic Complexity of 4 (Highest = 6). | 43 - 116 |
| Private field 'lifecycle' could be made final; it is only initialized in the declaration or constructor. | 47 |
| Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. | 48 |
| Private field 'phaseListeners' could be made final; it is only initialized in the declaration or constructor. | 49 |
| Private field 'listenerSuccessMap' could be made final; it is only initialized in the declaration or constructor. | 54 |
| Parameter 'phaseListeners' is not assigned and could be declared final | 59 |
| Parameter 'lifecycle' is not assigned and could be declared final | 59 |
| Parameter 'facesContext' is not assigned and could be declared final | 59 |
| Parameter 'phaseListener' is not assigned and could be declared final | 65 |
| Parameter 'phaseId' is not assigned and could be declared final | 65 |
| Local variable 'listenerPhaseId' could be declared final | 66 |
| Parameter 'phaseId' is not assigned and could be declared final | 71 |
| The method 'informPhaseListenersBefore' has a Cyclomatic Complexity of 5. | 71 - 93 |
| Local variable 'phaseListener' could be declared final | 81 |
| Parameter 'phaseId' is not assigned and could be declared final | 95 |
| The method 'informPhaseListenersAfter' has a Cyclomatic Complexity of 6. | 95 - 115 |
| Local variable 'beforePhaseSuccess' could be declared final | 96 |
| Local variable 'phaseListener' could be declared final | 104 |
org/apache/myfaces/tobago/internal/lifecycle/ProcessValidationsExecutor.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 36 |
org/apache/myfaces/tobago/internal/lifecycle/RenderResponseExecutor.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 43 |
| Local variable 'application' could be declared final | 44 |
| Local variable 'viewHandler' could be declared final | 45 |
| Avoid if (x != y) ..; else ..; | 49 - 58 |
| Local variable 'respObj' could be declared final | 52 |
| Local variable 'respHttp' could be declared final | 54 |
org/apache/myfaces/tobago/internal/lifecycle/RestoreViewExecutor.java
| Violation | Line |
|---|---|
| The class 'RestoreViewExecutor' has a Cyclomatic Complexity of 6 (Highest = 16). | 58 - 256 |
| The class 'RestoreViewExecutor' has a Cyclomatic Complexity of 6 (Highest = 16). | 58 - 256 |
| Parameter 'facesContext' is not assigned and could be declared final | 62 |
| The method 'execute' has a Cyclomatic Complexity of 16. | 62 - 144 |
| The method execute() has an NPath complexity of 3360 | 62 - 144 |
| The method 'execute' has a Cyclomatic Complexity of 16. | 62 - 144 |
| Local variable 'externalContext' could be declared final | 63 |
| Local variable 'sessionMap' could be declared final | 65 |
| Local variable 'messageHolders' could be declared final | 71 |
| Local variable 'viewId' could be declared final | 93 |
| Local variable 'application' could be declared final | 112 |
| Local variable 'viewHandler' could be declared final | 113 |
| Local variable 'postBack' could be declared final | 115 |
| Parameter 'facesContext' is not assigned and could be declared final | 146 |
| Local variable 'requestParameterMap' could be declared final | 147 |
| Parameter 'facesContext' is not assigned and could be declared final | 151 |
| Parameter 'facesContext' is not assigned and could be declared final | 163 |
| The method 'deriveViewId' has a Cyclomatic Complexity of 7. | 163 - 200 |
| Local variable 'externalContext' could be declared final | 164 |
| Local variable 'msg' could be declared final | 175 |
| Local variable 'defaultSuffix' could be declared final | 182 |
| Avoid if (x != y) ..; else ..; | 183 |
| Local variable 'suffix' could be declared final | 183 |
| Local variable 'msg' could be declared final | 185 |
| Local variable 'dot' could be declared final | 190 |
| Assigning an Object to null is a code smell. Consider refactoring. | 193 |
| Parameter 'facesContext' is not assigned and could be declared final | 204 |
| The method 'recursivelyHandleComponentReferencesAndSetValid' has a Cyclomatic Complexity of 8. | 204 - 233 |
| Parameter 'parent' is not assigned and could be declared final | 205 |
| Local variable 'forceHandle' could be declared final | 206 |
| Local variable 'handleBindingsMethod' could be declared final | 208 |
| Avoid if (x != y) ..; else ..; | 210 - 232 |
| Local variable 'it' could be declared final | 218 |
| Local variable 'component' could be declared final | 219 |
| Local variable 'binding' could be declared final | 221 |
| Parameter 'parent' is not assigned and could be declared final | 240 |
| Local variable 'interfaces' could be declared final | 241 |
| Avoid instantiating new objects inside loops | 246 |
| Avoid empty catch blocks | 247 - 249 |
| Avoid empty catch blocks | 247 - 249 |
org/apache/myfaces/tobago/internal/lifecycle/TobagoLifecycle.java
| Violation | Line |
|---|---|
| The class 'TobagoLifecycle' has a Cyclomatic Complexity of 4 (Highest = 9). | 43 - 212 |
| Private field 'lifecycleExecutors' could be made final; it is only initialized in the declaration or constructor. | 50 |
| Private field 'renderExecutor' could be made final; it is only initialized in the declaration or constructor. | 51 |
| Parameter 'context' is not assigned and could be declared final | 73 |
| Local variable 'phaseListenerMgr' could be declared final | 75 |
| Parameter 'phaseListenerMgr' is not assigned and could be declared final | 88 |
| Parameter 'facesContext' is not assigned and could be declared final | 88 |
| Parameter 'executor' is not assigned and could be declared final | 88 |
| The method 'executePhase' has a Cyclomatic Complexity of 9. | 88 - 126 |
| The String literal " in " appears 4 times in this file; the first occurrence is on line 93 | 93 |
| Parameter 'facesContext' is not assigned and could be declared final | 128 |
| The method 'render' has a Cyclomatic Complexity of 5. | 128 - 155 |
| Local variable 'phaseListenerMgr' could be declared final | 137 |
| Parameter 'facesContext' is not assigned and could be declared final | 157 |
| Parameter 'before' is not assigned and could be declared final | 157 |
| Parameter 'phase' is not assigned and could be declared final | 157 |
| Parameter 'facesContext' is not assigned and could be declared final | 170 |
| Parameter 'before' is not assigned and could be declared final | 170 |
| Parameter 'phase' is not assigned and could be declared final | 170 |
| Parameter 'phaseListener' is not assigned and could be declared final | 183 |
| Assigning an Object to null is a code smell. Consider refactoring. | 189 |
| Parameter 'phaseListener' is not assigned and could be declared final | 193 |
| Assigning an Object to null is a code smell. Consider refactoring. | 199 |
org/apache/myfaces/tobago/internal/lifecycle/TobagoLifecycleFactory.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 38 |
| Avoid unused private fields such as 'LOG'. | 38 |
| Private field 'factory' could be made final; it is only initialized in the declaration or constructor. | 40 |
| Private field 'defaultLifecycle' could be made final; it is only initialized in the declaration or constructor. | 41 |
| Parameter 'factory' is not assigned and could be declared final | 43 |
| Parameter 'lifecycle' is not assigned and could be declared final | 49 |
| Parameter 'lifecycleId' is not assigned and could be declared final | 49 |
| Do not add empty strings | 51 |
| Parameter 'lifecycleId' is not assigned and could be declared final | 54 |
org/apache/myfaces/tobago/internal/lifecycle/UpdateModelValuesExecutor.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 37 |
org/apache/myfaces/tobago/internal/taglib/TagUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 52 - 310 |
| The class 'TagUtils' has a Cyclomatic Complexity of 3 (Highest = 9). | 52 - 310 |
| Avoid reassigning parameters such as 'value' | 62 |
| Parameter 'component' is not assigned and could be declared final | 62 |
| Parameter 'name' is not assigned and could be declared final | 62 |
| The method 'setIntegerProperty' has a Cyclomatic Complexity of 9. | 62 - 78 |
| These nested if statements could be combined | 71 - 73 |
| Deeply nested if..then statements are hard to read | 71 - 73 |
| These nested if statements could be combined | 71 - 73 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 75 |
| Parameter 'component' is not assigned and could be declared final | 84 |
| Parameter 'name' is not assigned and could be declared final | 84 |
| Parameter 'value' is not assigned and could be declared final | 84 |
| Parameter 'component' is not assigned and could be declared final | 98 |
| Parameter 'name' is not assigned and could be declared final | 98 |
| Parameter 'value' is not assigned and could be declared final | 98 |
| Parameter 'component' is not assigned and could be declared final | 112 |
| Parameter 'name' is not assigned and could be declared final | 112 |
| Parameter 'value' is not assigned and could be declared final | 112 |
| Local variable 'valueBinding' could be declared final | 117 |
| Local variable 'converter' could be declared final | 120 |
| Parameter 'component' is not assigned and could be declared final | 130 |
| Parameter 'name' is not assigned and could be declared final | 130 |
| Parameter 'value' is not assigned and could be declared final | 130 |
| Parameter 'component' is not assigned and could be declared final | 138 |
| Parameter 'name' is not assigned and could be declared final | 138 |
| Parameter 'value' is not assigned and could be declared final | 138 |
| Parameter 'component' is not assigned and could be declared final | 146 |
| Parameter 'name' is not assigned and could be declared final | 146 |
| Parameter 'value' is not assigned and could be declared final | 146 |
| Parameter 'value' is not assigned and could be declared final | 154 |
| Parameter 'component' is not assigned and could be declared final | 162 |
| Parameter 'args' is not assigned and could be declared final | 162 |
| Parameter 'value' is not assigned and could be declared final | 162 |
| Local variable 'methodBinding' could be declared final | 164 |
| Parameter 'component' is not assigned and could be declared final | 173 |
| Parameter 'args' is not assigned and could be declared final | 173 |
| Parameter 'value' is not assigned and could be declared final | 173 |
| Local variable 'methodBinding' could be declared final | 175 |
| Parameter 'component' is not assigned and could be declared final | 184 |
| Parameter 'args' is not assigned and could be declared final | 184 |
| Parameter 'value' is not assigned and could be declared final | 184 |
| Local variable 'methodBinding' could be declared final | 186 |
| Parameter 'component' is not assigned and could be declared final | 195 |
| Parameter 'args' is not assigned and could be declared final | 195 |
| Parameter 'value' is not assigned and could be declared final | 195 |
| Local variable 'methodBinding' could be declared final | 197 |
| Parameter 'component' is not assigned and could be declared final | 206 |
| Parameter 'args' is not assigned and could be declared final | 206 |
| Parameter 'value' is not assigned and could be declared final | 206 |
| Local variable 'methodBinding' could be declared final | 208 |
| Parameter 'component' is not assigned and could be declared final | 217 |
| Parameter 'args' is not assigned and could be declared final | 217 |
| Parameter 'value' is not assigned and could be declared final | 217 |
| Local variable 'methodBinding' could be declared final | 219 |
| Parameter 'component' is not assigned and could be declared final | 228 |
| Parameter 'args' is not assigned and could be declared final | 228 |
| Parameter 'value' is not assigned and could be declared final | 228 |
| Local variable 'methodBinding' could be declared final | 231 - 232 |
| Parameter 'component' is not assigned and could be declared final | 244 |
| Parameter 'args' is not assigned and could be declared final | 244 |
| Parameter 'value' is not assigned and could be declared final | 244 |
| Local variable 'methodBinding' could be declared final | 246 |
| Parameter 'component' is not assigned and could be declared final | 255 |
| Parameter 'name' is not assigned and could be declared final | 255 |
| Parameter 'value' is not assigned and could be declared final | 255 |
| The method 'setStringArrayProperty' has a Cyclomatic Complexity of 6. | 255 - 272 |
| Local variable 'components' could be declared final | 260 |
| Parameter 'component' is not assigned and could be declared final | 278 |
| Parameter 'name' is not assigned and could be declared final | 278 |
| Parameter 'value' is not assigned and could be declared final | 278 |
| Local variable 'valueBinding' could be declared final | 280 |
| Parameter 'component' is not assigned and could be declared final | 289 |
| Parameter 'name' is not assigned and could be declared final | 289 |
| Parameter 'value' is not assigned and could be declared final | 289 |
| Avoid reassigning parameters such as 'script' | 303 |
| Local variable 'valueBinding' could be declared final | 305 |
org/apache/myfaces/tobago/model/DefaultMutableTreeNodeAnalyser.java
| Violation | Line |
|---|---|
| Private field 'node' could be made final; it is only initialized in the declaration or constructor. | 30 |
| Parameter 'node' is not assigned and could be declared final | 32 |
org/apache/myfaces/tobago/renderkit/RenderUtil.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 37 - 129 |
| The class 'RenderUtil' has a Cyclomatic Complexity of 1 (Highest = 5). | 37 - 129 |
| Parameter 'value' is not assigned and could be declared final | 45 |
| Parameter 'list' is not assigned and could be declared final | 45 |
| The method 'contains' has a Cyclomatic Complexity of 5. | 45 - 56 |
| The String literal "Using deprecated API" appears 12 times in this file; the first occurrence is on line 46 | 46 |
| Parameter 'panel' is not assigned and could be declared final | 58 |
| Parameter 'facesContext' is not assigned and could be declared final | 58 |
| Parameter 'facesContext' is not assigned and could be declared final | 63 |
| Parameter 'container' is not assigned and could be declared final | 63 |
| Parameter 'component' is not assigned and could be declared final | 70 |
| Parameter 'facesContext' is not assigned and could be declared final | 70 |
| Parameter 'component' is not assigned and could be declared final | 75 |
| Parameter 'facesContext' is not assigned and could be declared final | 75 |
| Parameter 'onClick' is not assigned and could be declared final | 80 |
| Parameter 'clientId' is not assigned and could be declared final | 80 |
| Parameter 'component' is not assigned and could be declared final | 85 |
| Parameter 'facesContext' is not assigned and could be declared final | 85 |
| Parameter 'component' is not assigned and could be declared final | 91 |
| Parameter 'context' is not assigned and could be declared final | 91 |
| Parameter 'currentValue' is not assigned and could be declared final | 91 |
| Parameter 'text' is not assigned and could be declared final | 97 |
| Parameter 'component' is not assigned and could be declared final | 97 |
| Parameter 'facesContext' is not assigned and could be declared final | 97 |
| Parameter 'text' is not assigned and could be declared final | 102 |
| Parameter 'component' is not assigned and could be declared final | 102 |
| Parameter 'facesContext' is not assigned and could be declared final | 102 |
| Parameter 'component' is not assigned and could be declared final | 107 |
| Parameter 'component' is not assigned and could be declared final | 111 |
| Parameter 'component' is not assigned and could be declared final | 115 |
| Parameter 'component' is not assigned and could be declared final | 120 |
| Parameter 'component' is not assigned and could be declared final | 125 |
org/apache/myfaces/tobago/renderkit/TobagoResponseStateManager.java
| Violation | Line |
|---|---|
| The class 'TobagoResponseStateManager' has a Cyclomatic Complexity of 4 (Highest = 7). | 39 - 119 |
| Parameter 'context' is not assigned and could be declared final | 46 |
| Parameter 'viewId' is not assigned and could be declared final | 46 |
| Local variable 'treeStructure' could be declared final | 47 |
| Local variable 'componentStateToRestore' could be declared final | 48 |
| Parameter 'facescontext' is not assigned and could be declared final | 55 |
| Parameter 'viewId' is not assigned and could be declared final | 55 |
| Local variable 'requestMap' could be declared final | 56 |
| Local variable 'requestViewId' could be declared final | 57 |
| Parameter 'facesContext' is not assigned and could be declared final | 67 |
| Local variable 'requestMap' could be declared final | 68 |
| Parameter 'facesContext' is not assigned and could be declared final | 72 |
| The method 'writeState' has a Cyclomatic Complexity of 7. | 72 - 117 |
| Parameter 'serializedview' is not assigned and could be declared final | 73 |
| Local variable 'responseWriter' could be declared final | 74 |
| Local variable 'treeStruct' could be declared final | 75 |
| Local variable 'compStates' could be declared final | 76 |
| Avoid if (x != y) ..; else ..; | 78 - 91 |
| Avoid if (x != y) ..; else ..; | 97 - 108 |
org/apache/myfaces/tobago/renderkit/html/HtmlRendererUtil.java
| Violation | Line |
|---|---|
| This class has a bunch of public methods and attributes | 20 - 804 |
| The class 'HtmlRendererUtil' has a Cyclomatic Complexity of 2 (Highest = 12). | 54 - 804 |
| This class has too many methods, consider refactoring it. | 54 - 804 |
| The class 'HtmlRendererUtil' has a Cyclomatic Complexity of 2 (Highest = 12). | 54 - 804 |
| Avoid if (x != y) ..; else ..; | 69 - 77 |
| Local variable 'writer' could be declared final | 71 |
| Local variable 'id' could be declared final | 72 |
| The method 'renderFocusId' has a Cyclomatic Complexity of 5. | 97 - 113 |
| Local variable 'page' could be declared final | 103 |
| Local variable 'id' could be declared final | 104 |
| Avoid if (x != y) ..; else ..; | 105 - 111 |
| Local variable 'writer' could be declared final | 109 |
| Parameter 'component' is not assigned and could be declared final | 119 |
| Parameter 'facesContext' is not assigned and could be declared final | 119 |
| Local variable 'rendererName' could be declared final | 120 |
| Local variable 'classes' could be declared final | 122 |
| Parameter 'component' is not assigned and could be declared final | 131 |
| Parameter 'facesContext' is not assigned and could be declared final | 131 |
| Parameter 'label' is not assigned and could be declared final | 139 |
| Parameter 'writer' is not assigned and could be declared final | 139 |
| Local variable 'pos' could be declared final | 141 |
| Local variable 'text' could be declared final | 142 |
| Parameter 'facesContext' is not assigned and could be declared final | 158 |
| Parameter 'transition' is not assigned and could be declared final | 158 |
| Parameter 'facesContext' is not assigned and could be declared final | 168 |
| Parameter 'clientId' is not assigned and could be declared final | 168 |
| Parameter 'key' is not assigned and could be declared final | 168 |
| Parameter 'modifier' is not assigned and could be declared final | 178 |
| Parameter 'facesContext' is not assigned and could be declared final | 178 |
| Parameter 'clientId' is not assigned and could be declared final | 178 |
| Parameter 'key' is not assigned and could be declared final | 178 |
| Local variable 'str' could be declared final | 180 - 181 |
| Parameter 'facesContext' is not assigned and could be declared final | 190 |
| Parameter 'func' is not assigned and could be declared final | 190 |
| Parameter 'key' is not assigned and could be declared final | 190 |
| Parameter 'modifier' is not assigned and could be declared final | 199 |
| Parameter 'facesContext' is not assigned and could be declared final | 199 |
| Parameter 'func' is not assigned and could be declared final | 199 |
| Parameter 'key' is not assigned and could be declared final | 199 |
| Local variable 'str' could be declared final | 201 |
| Parameter 'modifier' is not assigned and could be declared final | 210 |
| Parameter 'clientId' is not assigned and could be declared final | 210 |
| Parameter 'key' is not assigned and could be declared final | 210 |
| Local variable 'func' could be declared final | 211 |
| Parameter 'modifier' is not assigned and could be declared final | 220 |
| Parameter 'func' is not assigned and could be declared final | 220 |
| Parameter 'key' is not assigned and could be declared final | 220 |
| Local variable 'buffer' could be declared final | 221 |
| Parameter 'component' is not assigned and could be declared final | 240 |
| Parameter 'value' is not assigned and could be declared final | 240 |
| Parameter 'styleAttribute' is not assigned and could be declared final | 240 |
| The String literal "HtmlRendererUtils.replaceStyleAttribute() no longer supported. Use setter." appears 4 times in this file; the first occurrence is on line 241 | 241 |
| Parameter 'component' is not assigned and could be declared final | 248 |
| Parameter 'attribute' is not assigned and could be declared final | 248 |
| Parameter 'value' is not assigned and could be declared final | 249 |
| Parameter 'styleAttribute' is not assigned and could be declared final | 249 |
| Parameter 'component' is not assigned and could be declared final | 257 |
| Parameter 'value' is not assigned and could be declared final | 257 |
| Parameter 'styleAttribute' is not assigned and could be declared final | 257 |
| Parameter 'component' is not assigned and could be declared final | 265 |
| Parameter 'attribute' is not assigned and could be declared final | 265 |
| Parameter 'value' is not assigned and could be declared final | 266 |
| Parameter 'styleAttribute' is not assigned and could be declared final | 266 |
| Avoid unused private methods such as 'ensureStyleAttributeMap(UIComponent)'. | 275 |
| Parameter 'component' is not assigned and could be declared final | 275 |
| Avoid unused private methods such as 'ensureStyleAttributeMap(UIComponent)'. | 275 |
| Parameter 'component' is not assigned and could be declared final | 283 |
| Parameter 'attribute' is not assigned and could be declared final | 283 |
| Avoid reassigning parameters such as 'style' | 297 |
| Parameter 'name' is not assigned and could be declared final | 297 |
| Parameter 'value' is not assigned and could be declared final | 298 |
| Avoid if (x != y) ..; else ..; | 299 |
| Parameter 'style' is not assigned and could be declared final | 307 |
| Parameter 'name' is not assigned and could be declared final | 307 |
| Local variable 'pattern' could be declared final | 311 |
| Parameter 'component' is not assigned and could be declared final | 319 |
| Parameter 'name' is not assigned and could be declared final | 319 |
| Parameter 'component' is not assigned and could be declared final | 327 |
| Parameter 'clazz' is not assigned and could be declared final | 327 |
| Parameter 'component' is not assigned and could be declared final | 332 |
| Parameter 'facesContext' is not assigned and could be declared final | 332 |
| Parameter 'component' is not assigned and could be declared final | 337 |
| Parameter 'facesContext' is not assigned and could be declared final | 337 |
| Parameter 'width' is not assigned and could be declared final | 337 |
| Parameter 'component' is not assigned and could be declared final | 345 |
| Parameter 'cssClass' is not assigned and could be declared final | 345 |
| Parameter 'rendererName' is not assigned and could be declared final | 345 |
| Parameter 'component' is not assigned and could be declared final | 354 |
| Parameter 'rendererName' is not assigned and could be declared final | 354 |
| Parameter 'tobagoClass' is not assigned and could be declared final | 355 |
| Parameter 'subComponent' is not assigned and could be declared final | 355 |
| Parameter 'classes' is not assigned and could be declared final | 363 |
| Parameter 'component' is not assigned and could be declared final | 363 |
| Parameter 'rendererName' is not assigned and could be declared final | 363 |
| Parameter 'id' is not assigned and could be declared final | 371 |
| Parameter 'facesContext' is not assigned and could be declared final | 371 |
| Parameter 'src' is not assigned and could be declared final | 371 |
| Parameter 'writer' is not assigned and could be declared final | 371 |
| Parameter 'src' is not assigned and could be declared final | 380 |
| Parameter 'ext' is not assigned and could be declared final | 380 |
| Local variable 'dot' could be declared final | 381 |
| Parameter 'facesContext' is not assigned and could be declared final | 394 |
| Local variable 'writer' could be declared final | 396 |
| Parameter 'writer' is not assigned and could be declared final | 408 |
| Parameter 'script' is not assigned and could be declared final | 408 |
| Parameter 'writer' is not assigned and could be declared final | 418 |
| Parameter 'writer' is not assigned and could be declared final | 428 |
| Parameter 'facesContext' is not assigned and could be declared final | 437 |
| Parameter 'script' is not assigned and could be declared final | 437 |
| Parameter 'scripts' is not assigned and could be declared final | 446 |
| Parameter 'facesContext' is not assigned and could be declared final | 446 |
| Parameter 'afterLoadCmds' is not assigned and could be declared final | 446 |
| The method 'writeScriptLoader' has a Cyclomatic Complexity of 10. | 446 - 490 |
| The method 'writeScriptLoader' has a Cyclomatic Complexity of 10. | 446 - 490 |
| Local variable 'writer' could be declared final | 448 |
| Local variable 'splittedStrings' could be declared final | 472 |
| Parameter 'facesContext' is not assigned and could be declared final | 497 |
| Parameter 'styles' is not assigned and could be declared final | 497 |
| Local variable 'writer' could be declared final | 498 |
| Parameter 'component' is not assigned and could be declared final | 511 |
| Parameter 'facesContext' is not assigned and could be declared final | 511 |
| Local variable 'messages' could be declared final | 512 |
| Avoid reassigning parameters such as 'title' | 520 |
| Avoid reassigning parameters such as 'title' | 520 |
| Avoid reassigning parameters such as 'title' | 520 |
| Parameter 'tip' is not assigned and could be declared final | 520 |
| Parameter 'values' is not assigned and could be declared final | 537 |
| Parameter 'component' is not assigned and could be declared final | 537 |
| Parameter 'items' is not assigned and could be declared final | 537 |
| Parameter 'facesContext' is not assigned and could be declared final | 538 |
| Parameter 'writer' is not assigned and could be declared final | 538 |
| Parameter 'component' is not assigned and could be declared final | 546 |
| Parameter 'context' is not assigned and could be declared final | 546 |
| Parameter 'componentId' is not assigned and could be declared final | 546 |
| The method 'getComponentIds' has a Cyclomatic Complexity of 5. | 546 - 560 |
| Local variable 'sb' could be declared final | 547 |
| Local variable 'clientId' could be declared final | 553 |
| Parameter 'component' is not assigned and could be declared final | 566 |
| Parameter 'context' is not assigned and could be declared final | 566 |
| Parameter 'componentId' is not assigned and could be declared final | 566 |
| The method 'getComponentId' has a Cyclomatic Complexity of 5. | 566 - 580 |
| Local variable 'partiallyComponent' could be declared final | 567 |
| Local variable 'clientId' could be declared final | 569 |
| Local variable 'rowIndex' could be declared final | 571 |
| Parameter 'value' is not assigned and could be declared final | 586 |
| Parameter 'key' is not assigned and could be declared final | 586 |
| Local variable 'buf' could be declared final | 587 |
| Parameter 'value' is not assigned and could be declared final | 599 |
| Parameter 'key' is not assigned and could be declared final | 599 |
| Local variable 'buf' could be declared final | 600 |
| Parameter 'component' is not assigned and could be declared final | 612 |
| Parameter 'writer' is not assigned and could be declared final | 612 |
| Parameter 'component' is not assigned and could be declared final | 620 |
| Parameter 'writer' is not assigned and could be declared final | 620 |
| Parameter 'str' is not assigned and could be declared final | 628 |
| Parameter 'facesContext' is not assigned and could be declared final | 639 |
| Parameter 'command' is not assigned and could be declared final | 639 |
| Local variable 'list' could be declared final | 643 |
| Local variable 'strBuilder' could be declared final | 644 |
| Parameter 'list' is not assigned and could be declared final | 662 |
| Local variable 'strBuilder' could be declared final | 663 |
| Parameter 'component' is not assigned and could be declared final | 681 |
| Parameter 'context' is not assigned and could be declared final | 681 |
| Local variable 'objDojoType' could be declared final | 683 |
| Parameter 'addStyle' is not assigned and could be declared final | 694 |
| Parameter 'component' is not assigned and could be declared final | 694 |
| Parameter 'writer' is not assigned and could be declared final | 694 |
| The method 'renderDojoDndItem' has a Cyclomatic Complexity of 6. | 694 - 708 |
| Local variable 'objDndType' could be declared final | 696 |
| Local variable 'objDndData' could be declared final | 700 |
| Local variable 'styles' could be declared final | 705 |
| Parameter 'dojoType' is not assigned and could be declared final | 714 |
| Parameter 'component' is not assigned and could be declared final | 714 |
| Parameter 'clientId' is not assigned and could be declared final | 714 |
| The method 'createDojoDndType' has a Cyclomatic Complexity of 12. | 714 - 766 |
| The method createDojoDndType() has an NPath complexity of 640 | 714 - 766 |
| The method 'createDojoDndType' has a Cyclomatic Complexity of 12. | 714 - 766 |
| Local variable 'strBuilder' could be declared final | 715 |
| Local variable 'parameter' could be declared final | 717 |
| Local variable 'objHorizontal' could be declared final | 719 |
| Local variable 'objCopyOnly' could be declared final | 723 |
| Local variable 'objSkipForm' could be declared final | 727 |
| Local variable 'objWithHandles' could be declared final | 731 |
| Local variable 'objAccept' could be declared final | 735 |
| Local variable 'allowed' could be declared final | 739 |
| Prefer StringBuffer over += for concatenating strings | 744 |
| Local variable 'objSingular' could be declared final | 752 |
| Local variable 'objCreator' could be declared final | 756 |
| Parameter 'component' is not assigned and could be declared final | 772 |
| Parameter 'facesContext' is not assigned and could be declared final | 772 |
| Parameter 'writer' is not assigned and could be declared final | 772 |
| Parameter 'component' is not assigned and could be declared final | 781 |
| Parameter 'facesContext' is not assigned and could be declared final | 781 |
| Parameter 'clientIds' is not assigned and could be declared final | 781 |
| Parameter 'writer' is not assigned and could be declared final | 782 |
| Parameter 'cell' is not assigned and could be declared final | 790 |
| The method 'removeStyleClasses' has a Cyclomatic Complexity of 6. | 790 - 803 |
| Local variable 'obj' could be declared final | 791 |
| No need to check for null before an instanceof | 792 |
| Local variable 'styleClasses' could be declared final | 793 |
| Local variable 'rendererName' could be declared final | 795 - 796 |
org/apache/myfaces/tobago/renderkit/html/HtmlStyleMap.java
| Violation | Line |
|---|---|
| The class 'HtmlStyleMap' has a Cyclomatic Complexity of 5 (Highest = 5). | 33 - 78 |
| Avoid reassigning parameters such as 'o' | 38 |
| Parameter 's' is not assigned and could be declared final | 38 |
| The method 'put' has a Cyclomatic Complexity of 5. | 38 - 47 |
| Position literals first in String comparisons | 39 |
| Position literals first in String comparisons | 39 |
| Local variable 'str' could be declared final | 40 |
| Parameter 'o' is not assigned and could be declared final | 49 |
| Local variable 'obj' could be declared final | 50 |
| The method 'toString' has a Cyclomatic Complexity of 5. | 61 - 77 |
| Local variable 'buf' could be declared final | 65 |
org/apache/myfaces/tobago/renderkit/html/StyleClasses.java
| Violation | Line |
|---|---|
| The class 'StyleClasses' has a Cyclomatic Complexity of 2 (Highest = 7). | 46 - 296 |
| This class has too many methods, consider refactoring it. | 46 - 296 |
| Parameter 'sub' is not assigned and could be declared final | 66 |
| Parameter 'component' is not assigned and could be declared final | 66 |
| Overridable method 'addClass' called during object construction | 68 |
| Parameter 'base' is not assigned and could be declared final | 71 |
| Parameter 'component' is not assigned and could be declared final | 76 |
| Local variable 'attributes' could be declared final | 77 |
| Parameter 'component' is not assigned and could be declared final | 86 |
| Parameter 'clazz' is not assigned and could be declared final | 94 |
| Parameter 'clazz' is not assigned and could be declared final | 101 |
| Parameter 'sub' is not assigned and could be declared final | 105 |
| Parameter 'renderer' is not assigned and could be declared final | 105 |
| Parameter 'sub' is not assigned and could be declared final | 109 |
| Parameter 'renderer' is not assigned and could be declared final | 109 |
| Parameter 'sub' is not assigned and could be declared final | 117 |
| Parameter 'renderer' is not assigned and could be declared final | 117 |
| Local variable 'builder' could be declared final | 118 |
| Parameter 'markup' is not assigned and could be declared final | 125 |
| Parameter 'renderer' is not assigned and could be declared final | 125 |
| Parameter 'markup' is not assigned and could be declared final | 129 |
| Parameter 'renderer' is not assigned and could be declared final | 129 |
| Parameter 'sub' is not assigned and could be declared final | 133 |
| Parameter 'markup' is not assigned and could be declared final | 133 |
| Parameter 'renderer' is not assigned and could be declared final | 133 |
| Parameter 'sub' is not assigned and could be declared final | 137 |
| Parameter 'markup' is not assigned and could be declared final | 137 |
| Parameter 'renderer' is not assigned and could be declared final | 137 |
| Parameter 'sub' is not assigned and could be declared final | 141 |
| Parameter 'markup' is not assigned and could be declared final | 141 |
| Parameter 'renderer' is not assigned and could be declared final | 141 |
| Local variable 'builder' could be declared final | 142 |
| Parameter 'component' is not assigned and could be declared final | 153 |
| Parameter 'rendererName' is not assigned and could be declared final | 153 |
| Parameter 'sub' is not assigned and could be declared final | 159 |
| Parameter 'supportsMarkup' is not assigned and could be declared final | 159 |
| Parameter 'rendererName' is not assigned and could be declared final | 159 |
| The method 'addMarkupClass' has a Cyclomatic Complexity of 5. | 159 - 173 |
| Local variable 'm' could be declared final | 160 |
| Local variable 'theme' could be declared final | 163 |
| Parameter 'aspect' is not assigned and could be declared final | 175 |
| Parameter 'renderer' is not assigned and could be declared final | 175 |
| Parameter 'aspect' is not assigned and could be declared final | 179 |
| Parameter 'renderer' is not assigned and could be declared final | 179 |
| Parameter 'aspect' is not assigned and could be declared final | 183 |
| Parameter 'renderer' is not assigned and could be declared final | 183 |
| Local variable 'builder' could be declared final | 184 |
| Parameter 'sub' is not assigned and could be declared final | 190 |
| Parameter 'aspect' is not assigned and could be declared final | 190 |
| Parameter 'renderer' is not assigned and could be declared final | 190 |
| Parameter 'sub' is not assigned and could be declared final | 194 |
| Parameter 'aspect' is not assigned and could be declared final | 194 |
| Parameter 'renderer' is not assigned and could be declared final | 194 |
| Parameter 'sub' is not assigned and could be declared final | 198 |
| Parameter 'aspect' is not assigned and could be declared final | 198 |
| Parameter 'renderer' is not assigned and could be declared final | 198 |
| Local variable 'builder' could be declared final | 199 |
| Parameter 'styleClasses' is not assigned and could be declared final | 207 |
| Parameter 'clazz' is not assigned and could be declared final | 213 |
| Parameter 'rendererName' is not assigned and could be declared final | 217 |
| Local variable 'i' could be declared final | 218 |
| Local variable 'clazz' could be declared final | 219 |
| Parameter 'component' is not assigned and could be declared final | 226 |
| Parameter 'rendererName' is not assigned and could be declared final | 226 |
| Parameter 'component' is not assigned and could be declared final | 231 |
| Parameter 'rendererName' is not assigned and could be declared final | 231 |
| The method 'updateClassAttribute' has a Cyclomatic Complexity of 7. | 231 - 254 |
| Local variable 'input' could be declared final | 246 |
| Local variable 'buffer' could be declared final | 261 |
| Local variable 'i' could be declared final | 262 |
| Local variable 'clazz' could be declared final | 263 |
org/apache/myfaces/tobago/renderkit/html/util/CommandRendererHelper.java
| Violation | Line |
|---|---|
| The class 'CommandRendererHelper' has a Cyclomatic Complexity of 4 (Highest = 17). | 42 - 167 |
| The class 'CommandRendererHelper' has a Cyclomatic Complexity of 4 (Highest = 17). | 42 - 167 |
| Parameter 'facesContext' is not assigned and could be declared final | 51 |
| Parameter 'command' is not assigned and could be declared final | 51 |
| Parameter 'facesContext' is not assigned and could be declared final | 55 |
| Parameter 'tag' is not assigned and could be declared final | 55 |
| Parameter 'command' is not assigned and could be declared final | 55 |
| The constructor 'CommandRendererHelper' has a Cyclomatic Complexity of 17. | 55 - 123 |
| The constructor 'CommandRendererHelper' has a Cyclomatic Complexity of 17. | 55 - 123 |
| Local variable 'popup' could be declared final | 64 |
| These nested if statements could be combined | 66 - 68 |
| These nested if statements could be combined | 66 - 68 |
| Local variable 'transition' could be declared final | 71 |
| Local variable 'url' could be declared final | 74 |
| Assigning an Object to null is a code smell. Consider refactoring. | 76 |
| Local variable 'clientId' could be declared final | 86 |
| Local variable 'componentIds' could be declared final | 87 |
| Local variable 'popupAction' could be declared final | 90 |
| Local variable 'clientId' could be declared final | 104 |
| Local variable 'target' could be declared final | 105 |
| Local variable 'value' could be declared final | 111 |
| Position literals first in String comparisons | 112 |
| Position literals first in String comparisons | 114 |
| Parameter 'component' is not assigned and could be declared final | 125 |
| Parameter 'facesContext' is not assigned and could be declared final | 125 |
| Avoid reassigning parameters such as 'onclick' | 133 |
| Parameter 'component' is not assigned and could be declared final | 133 |
| Local variable 'confirmation' could be declared final | 134 |
| Local variable 'script' could be declared final | 136 |
org/apache/myfaces/tobago/renderkit/util/JQueryUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 26 - 102 |
| Parameter 'id' is not assigned and could be declared final | 36 |
| Parameter 'value' is not assigned and could be declared final | 44 |
| Parameter 'value' is not assigned and could be declared final | 53 |
| Local variable 'builder' could be declared final | 54 |
| Parameter 'id' is not assigned and could be declared final | 95 |
| Local variable 'builder' could be declared final | 96 |
org/apache/myfaces/tobago/util/MessageFactory.java
| Violation | Line |
|---|---|
| The class 'MessageFactory' has a Cyclomatic Complexity of 2 (Highest = 6). | 37 - 120 |
| Parameter 'facesContext' is not assigned and could be declared final | 47 |
| Parameter 'args' is not assigned and could be declared final | 47 |
| Parameter 'severity' is not assigned and could be declared final | 47 |
| Parameter 'key' is not assigned and could be declared final | 47 |
| Parameter 'facesContext' is not assigned and could be declared final | 53 |
| Parameter 'severity' is not assigned and could be declared final | 53 |
| Parameter 'key' is not assigned and could be declared final | 53 |
| The method 'createFacesMessage' has a Cyclomatic Complexity of 6. | 58 - 75 |
| Parameter 'facesContext' is not assigned and could be declared final | 59 |
| Parameter 'args' is not assigned and could be declared final | 59 |
| Parameter 'bundle' is not assigned and could be declared final | 59 |
| Parameter 'severity' is not assigned and could be declared final | 59 |
| Parameter 'key' is not assigned and could be declared final | 59 |
| Local variable 'locale' could be declared final | 63 |
| Local variable 'format' could be declared final | 65 |
| Local variable 'format' could be declared final | 70 |
| Avoid if (x != y) ..; else ..; | 74 |
| Parameter 'facesContext' is not assigned and could be declared final | 78 |
| Local variable 'root' could be declared final | 79 |
| Avoid if (x != y) ..; else ..; | 81 - 85 |
| Parameter 'facesContext' is not assigned and could be declared final | 91 |
| Parameter 'bundle' is not assigned and could be declared final | 91 |
| Parameter 'severity' is not assigned and could be declared final | 91 |
| Parameter 'key' is not assigned and could be declared final | 91 |
| Parameter 'facesContext' is not assigned and could be declared final | 97 |
| Parameter 'bundle' is not assigned and could be declared final | 97 |
| Parameter 'key' is not assigned and could be declared final | 97 |
| Local variable 'locale' could be declared final | 101 |
| Avoid empty catch blocks | 103 - 105 |
| Avoid empty catch blocks | 103 - 105 |
| Parameter 'locale' is not assigned and could be declared final | 111 |
org/apache/myfaces/tobago/util/StringUtil.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 32 - 70 |
| Parameter 'string' is not assigned and could be declared final | 38 |
| Parameter 'integerList' is not assigned and could be declared final | 46 |
| Parameter 'list' is not assigned and could be declared final | 55 |
| Parameter 'label' is not assigned and could be declared final | 63 |
org/apache/myfaces/tobago/util/StringUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 33 - 92 |
| The class 'StringUtils' has a Cyclomatic Complexity of 3 (Highest = 5). | 33 - 92 |
| Parameter 'string' is not assigned and could be declared final | 42 |
| The method 'firstToUpperCase' has a Cyclomatic Complexity of 5. | 42 - 57 |
| Parameter 'integerList' is not assigned and could be declared final | 59 |
| Local variable 'list' could be declared final | 61 |
| Local variable 'tokenizer' could be declared final | 63 |
| Local variable 'token' could be declared final | 65 |
| Avoid instantiating new objects inside loops | 67 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 67 |
| Parameter 'list' is not assigned and could be declared final | 74 |
| Local variable 'buffer' could be declared final | 75 |
| Parameter 'label' is not assigned and could be declared final | 84 |
org/apache/myfaces/tobago/util/VariableResolverUtil.java
| Violation | Line |
|---|---|
| Parameter 'context' is not assigned and could be declared final | 42 |
| Parameter 'variable' is not assigned and could be declared final | 42 |
| Local variable 'application' could be declared final | 43 |
| Local variable 'variableResolver' could be declared final | 44 |
| Parameter 'facesContext' is not assigned and could be declared final | 51 |
| Parameter 'context' is not assigned and could be declared final | 61 |
| Parameter 'variable' is not assigned and could be declared final | 61 |
| Local variable 'application' could be declared final | 62 |
| Local variable 'valueBinding' could be declared final | 63 |