FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is low

Effort is max

Summary

Classes Bugs Errors Missing Classes
19 32 0 0

Files

Class Bugs
org.apache.myfaces.tobago.example.addressbook.Address 7
org.apache.myfaces.tobago.example.addressbook.DerbyShutdownServletContextListener 1
org.apache.myfaces.tobago.example.addressbook.InMemoryAddressDao 1
org.apache.myfaces.tobago.example.addressbook.JpaAddressDao 2
org.apache.myfaces.tobago.example.addressbook.KillSession 2
org.apache.myfaces.tobago.example.addressbook.Picture 8
org.apache.myfaces.tobago.example.addressbook.web.AdminController 1
org.apache.myfaces.tobago.example.addressbook.web.Controller 6
org.apache.myfaces.tobago.example.addressbook.web.Countries 2
org.apache.myfaces.tobago.example.addressbook.web.EmailAddressConverter 1
org.apache.myfaces.tobago.example.addressbook.web.PictureServlet 1

org.apache.myfaces.tobago.example.addressbook.Address

Bug Category Details Line Priority
org.apache.myfaces.tobago.example.addressbook.Address.pcCopyKeyFieldsFromObjectId(Object) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR Not available Medium
org.apache.myfaces.tobago.example.addressbook.Address.pcCopyKeyFieldsFromObjectId(FieldConsumer, Object) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR Not available Medium
org.apache.myfaces.tobago.example.addressbook.Address.pcIsDetached() has Boolean return type and returns explicit null BAD_PRACTICE NP_BOOLEAN_RETURN_NULL Not available Medium
Private method org.apache.myfaces.tobago.example.addressbook.Address.load() is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 127-136 Low
Private method org.apache.myfaces.tobago.example.addressbook.Address.pcGetrevision(Address) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD Not available Low
Private method org.apache.myfaces.tobago.example.addressbook.Address.pcSetrevision(Address, Integer) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD Not available Low
Private method org.apache.myfaces.tobago.example.addressbook.Address.store() is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 113-123 Low

org.apache.myfaces.tobago.example.addressbook.DerbyShutdownServletContextListener

Bug Category Details Line Priority
org.apache.myfaces.tobago.example.addressbook.DerbyShutdownServletContextListener.contextDestroyed(ServletContextEvent) may fail to close Connection BAD_PRACTICE ODR_OPEN_DATABASE_RESOURCE 45 Medium

org.apache.myfaces.tobago.example.addressbook.InMemoryAddressDao

Bug Category Details Line Priority
org.apache.myfaces.tobago.example.addressbook.InMemoryAddressDao is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 37-89 Low

org.apache.myfaces.tobago.example.addressbook.JpaAddressDao

Bug Category Details Line Priority
Class org.apache.myfaces.tobago.example.addressbook.JpaAddressDao defines non-transient non-serializable instance field entityManager BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.apache.myfaces.tobago.example.addressbook.JpaAddressDao is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 41-100 Low

org.apache.myfaces.tobago.example.addressbook.KillSession

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.myfaces.tobago.example.addressbook.KillSession.doGet(HttpServletRequest, HttpServletResponse): String.getBytes() I18N DM_DEFAULT_ENCODING 48 High
org.apache.myfaces.tobago.example.addressbook.KillSession is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 34-49 Low

org.apache.myfaces.tobago.example.addressbook.Picture

Bug Category Details Line Priority
org.apache.myfaces.tobago.example.addressbook.Picture.pcCopyKeyFieldsFromObjectId(Object) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR Not available Medium
org.apache.myfaces.tobago.example.addressbook.Picture.pcCopyKeyFieldsFromObjectId(FieldConsumer, Object) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR Not available Medium
org.apache.myfaces.tobago.example.addressbook.Picture.pcIsDetached() has Boolean return type and returns explicit null BAD_PRACTICE NP_BOOLEAN_RETURN_NULL Not available Medium
Private method org.apache.myfaces.tobago.example.addressbook.Picture.pcSetcontent(Picture, byte[]) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD Not available Low
Private method org.apache.myfaces.tobago.example.addressbook.Picture.pcSetcontentType(Picture, String) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD Not available Low
Private method org.apache.myfaces.tobago.example.addressbook.Picture.pcSetid(Picture, Integer) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD Not available Low
Unwritten field: org.apache.myfaces.tobago.example.addressbook.Picture.pcPCSuperclass CORRECTNESS UWF_UNWRITTEN_FIELD Not available Medium
Unwritten field: org.apache.myfaces.tobago.example.addressbook.Picture.pcInheritedFieldCount CORRECTNESS UWF_UNWRITTEN_FIELD Not available Low

org.apache.myfaces.tobago.example.addressbook.web.AdminController

Bug Category Details Line Priority
org.apache.myfaces.tobago.example.addressbook.web.AdminController is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 35-73 Low

org.apache.myfaces.tobago.example.addressbook.web.Controller

Bug Category Details Line Priority
Unchecked/unconfirmed cast from javax.faces.component.UIColumn to org.apache.myfaces.tobago.component.UIColumn of return value in org.apache.myfaces.tobago.example.addressbook.web.Controller.sheetSorter(ActionEvent) STYLE BC_UNCONFIRMED_CAST_OF_RETURN_VALUE 134 Low
Unchecked/unconfirmed cast from javax.faces.component.UIData to org.apache.myfaces.tobago.component.UISheet of return value in org.apache.myfaces.tobago.example.addressbook.web.Controller.sheetSorter(ActionEvent) STYLE BC_UNCONFIRMED_CAST_OF_RETURN_VALUE 136 Low
org.apache.myfaces.tobago.example.addressbook.web.Controller.FLAGS is a mutable collection which should be package protected MALICIOUS_CODE MS_MUTABLE_COLLECTION_PKGPROTECT 100 Medium
Class org.apache.myfaces.tobago.example.addressbook.web.Controller defines non-transient non-serializable instance field part BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.apache.myfaces.tobago.example.addressbook.web.Controller defines non-transient non-serializable instance field theme BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.apache.myfaces.tobago.example.addressbook.web.Controller is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 60-431 Low

org.apache.myfaces.tobago.example.addressbook.web.Countries

Bug Category Details Line Priority
Redundant nullcheck of displayCountry, which is known to be non-null in org.apache.myfaces.tobago.example.addressbook.web.Countries.init(Locale) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 38 Low
org.apache.myfaces.tobago.example.addressbook.web.Countries is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 31-43 Low

org.apache.myfaces.tobago.example.addressbook.web.EmailAddressConverter

Bug Category Details Line Priority
Redundant nullcheck of parts, which is known to be non-null in org.apache.myfaces.tobago.example.addressbook.web.EmailAddressConverter.getAsObject(FacesContext, UIComponent, String) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 44 Low

org.apache.myfaces.tobago.example.addressbook.web.PictureServlet

Bug Category Details Line Priority
org.apache.myfaces.tobago.example.addressbook.web.PictureServlet is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 37-61 Low