FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 2.0.0

Threshold is low

Effort is max

Summary

Classes Bugs Errors Missing Classes
20 19 0 0

Files

Class Bugs
org.apache.myfaces.tobago.example.addressbook.Address 6
org.apache.myfaces.tobago.example.addressbook.DerbyShutdownServletContextListener 1
org.apache.myfaces.tobago.example.addressbook.InMemoryAddressDao 1
org.apache.myfaces.tobago.example.addressbook.JpaAddressDao 2
org.apache.myfaces.tobago.example.addressbook.KillSession 2
org.apache.myfaces.tobago.example.addressbook.Picture 2
org.apache.myfaces.tobago.example.addressbook.web.AdminController 1
org.apache.myfaces.tobago.example.addressbook.web.Controller 2
org.apache.myfaces.tobago.example.addressbook.web.Countries 1
org.apache.myfaces.tobago.example.addressbook.web.PictureServlet 1

org.apache.myfaces.tobago.example.addressbook.Address

Bug Category Details Line Priority
org.apache.myfaces.tobago.example.addressbook.Address.getDayOfBirth() may expose internal representation by returning Address.dayOfBirth MALICIOUS_CODE EI_EXPOSE_REP 254 Medium
org.apache.myfaces.tobago.example.addressbook.Address.setDayOfBirth(Date) may expose internal representation by storing an externally mutable object into Address.dayOfBirth MALICIOUS_CODE EI_EXPOSE_REP2 258 Medium
Class org.apache.myfaces.tobago.example.addressbook.Address defines non-transient non-serializable instance field email BAD_PRACTICE SE_BAD_FIELD Not available High
Class org.apache.myfaces.tobago.example.addressbook.Address defines non-transient non-serializable instance field jobEmail BAD_PRACTICE SE_BAD_FIELD Not available High
Private method org.apache.myfaces.tobago.example.addressbook.Address.load() is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 127-136 Low
Private method org.apache.myfaces.tobago.example.addressbook.Address.store() is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 113-123 Low

org.apache.myfaces.tobago.example.addressbook.DerbyShutdownServletContextListener

Bug Category Details Line Priority
org.apache.myfaces.tobago.example.addressbook.DerbyShutdownServletContextListener.contextDestroyed(ServletContextEvent) may fail to close Connection BAD_PRACTICE ODR_OPEN_DATABASE_RESOURCE 43 Medium

org.apache.myfaces.tobago.example.addressbook.InMemoryAddressDao

Bug Category Details Line Priority
org.apache.myfaces.tobago.example.addressbook.InMemoryAddressDao is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 37-84 Low

org.apache.myfaces.tobago.example.addressbook.JpaAddressDao

Bug Category Details Line Priority
Class org.apache.myfaces.tobago.example.addressbook.JpaAddressDao defines non-transient non-serializable instance field entityManager BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.apache.myfaces.tobago.example.addressbook.JpaAddressDao is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 41-95 Low

org.apache.myfaces.tobago.example.addressbook.KillSession

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.myfaces.tobago.example.addressbook.KillSession.doGet(HttpServletRequest, HttpServletResponse): String.getBytes() I18N DM_DEFAULT_ENCODING 48 High
org.apache.myfaces.tobago.example.addressbook.KillSession is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 34-49 Low

org.apache.myfaces.tobago.example.addressbook.Picture

Bug Category Details Line Priority
org.apache.myfaces.tobago.example.addressbook.Picture.getContent() may expose internal representation by returning Picture.content MALICIOUS_CODE EI_EXPOSE_REP 60 Medium
new org.apache.myfaces.tobago.example.addressbook.Picture(String, byte[]) may expose internal representation by storing an externally mutable object into Picture.content MALICIOUS_CODE EI_EXPOSE_REP2 48 Medium

org.apache.myfaces.tobago.example.addressbook.web.AdminController

Bug Category Details Line Priority
org.apache.myfaces.tobago.example.addressbook.web.AdminController is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 35-73 Low

org.apache.myfaces.tobago.example.addressbook.web.Controller

Bug Category Details Line Priority
Class org.apache.myfaces.tobago.example.addressbook.web.Controller defines non-transient non-serializable instance field theme BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.apache.myfaces.tobago.example.addressbook.web.Controller is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 60-432 Low

org.apache.myfaces.tobago.example.addressbook.web.Countries

Bug Category Details Line Priority
org.apache.myfaces.tobago.example.addressbook.web.Countries is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 31-43 Low

org.apache.myfaces.tobago.example.addressbook.web.PictureServlet

Bug Category Details Line Priority
org.apache.myfaces.tobago.example.addressbook.web.PictureServlet is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 37-60 Low