PMD Results
The following document contains the results of PMD 4.2.5.
Files
org/apache/myfaces/tobago/ajax/AjaxUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 43 - 152 |
| The class 'AjaxUtils' has a Cyclomatic Complexity of 2 (Highest = 6). | 43 - 152 |
| Parameter 'facesContext' is not assigned and could be declared final | 50 |
| Local variable 'parameterMap' could be declared final | 51 |
| Local variable 'ajaxComponentIds' could be declared final | 52 |
| Parameter 'facesContext' is not assigned and could be declared final | 56 |
| Parameter 'clientId' is not assigned and could be declared final | 56 |
| Local variable 'ajaxComponents' could be declared final | 57 |
| Parameter 'facesContext' is not assigned and could be declared final | 63 |
| Parameter 'clientId' is not assigned and could be declared final | 63 |
| Parameter 'component' is not assigned and could be declared final | 67 |
| Parameter 'facesContext' is not assigned and could be declared final | 67 |
| Local variable 'ajaxComponents' could be declared final | 72 |
| Parameter 'facesContext' is not assigned and could be declared final | 78 |
| Local variable 'parameterMap' could be declared final | 79 |
| Local variable 'ajaxComponentIds' could be declared final | 80 |
| Local variable 'tokenizer' could be declared final | 82 |
| Local variable 'ajaxComponents' could be declared final | 83 |
| Local variable 'ajaxId' could be declared final | 85 |
| Parameter 'context' is not assigned and could be declared final | 96 |
| The method 'addUIMessagesToRenderedPartially' has a Cyclomatic Complexity of 6. | 96 - 117 |
| Local variable 'list' could be declared final | 100 |
| Local variable 'clientIds' could be declared final | 101 |
| Parameter 'facesContext' is not assigned and could be declared final | 119 |
| Parameter 'url' is not assigned and could be declared final | 119 |
| Local variable 'httpServletResponse' could be declared final | 123 - 124 |
| Local variable 'writer' could be declared final | 125 |
| Local variable 'contentType' could be declared final | 126 |
| Parameter 'writer' is not assigned and could be declared final | 135 |
| Parameter 'url' is not assigned and could be declared final | 135 |
| Parameter 'response' is not assigned and could be declared final | 145 |
| Parameter 'url' is not assigned and could be declared final | 145 |
| Local variable 'writer' could be declared final | 146 |
| Local variable 'contentType' could be declared final | 147 |
org/apache/myfaces/tobago/application/ActionListenerImpl.java
| Violation | Line |
|---|---|
| The class 'ActionListenerImpl' has a Cyclomatic Complexity of 3 (Highest = 7). | 37 - 89 |
| Private field 'base' could be made final; it is only initialized in the declaration or constructor. | 41 |
| Parameter 'base' is not assigned and could be declared final | 45 |
| Parameter 'event' is not assigned and could be declared final | 49 |
| The method 'processAction' has a Cyclomatic Complexity of 7. | 49 - 80 |
| An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 53 |
| Local variable 'facesContext' could be declared final | 63 |
| Local variable 'facesMessage' could be declared final | 65 |
| Local variable 'source' could be declared final | 68 |
| Local variable 'actionSource' could be declared final | 69 |
| Local variable 'application' could be declared final | 70 |
| Local variable 'expression' could be declared final | 71 |
| Local variable 'navHandler' could be declared final | 73 |
| Avoid if (x != y) ..; else ..; | 75 |
| Local variable 'navBinding' could be declared final | 75 |
| Assigning an Object to null is a code smell. Consider refactoring. | 75 |
| Parameter 'errorOutcome' is not assigned and could be declared final | 86 |
org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.java
| Violation | Line |
|---|---|
| Parameter 'summary' is not assigned and could be declared final | 31 |
| Parameter 'detail' is not assigned and could be declared final | 31 |
| Parameter 'severity' is not assigned and could be declared final | 31 |
| Parameter 'summary' is not assigned and could be declared final | 35 |
| Parameter 'detail' is not assigned and could be declared final | 35 |
| Parameter 'summary' is not assigned and could be declared final | 39 |
| Local variable 'facesContext' could be declared final | 45 |
| Local variable 'value' could be declared final | 46 - 47 |
| Local variable 'facesContext' could be declared final | 53 |
| Local variable 'value' could be declared final | 54 - 55 |
org/apache/myfaces/tobago/compat/FacesUtilsEL.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 48 - 263 |
| The class 'FacesUtilsEL' has a Cyclomatic Complexity of 2 (Highest = 7). | 48 - 263 |
| This class has too many methods, consider refactoring it. | 48 - 263 |
| The method 'invokeOnComponent' has a Cyclomatic Complexity of 7. | 58 - 83 |
| Parameter 'component' is not assigned and could be declared final | 59 |
| Parameter 'context' is not assigned and could be declared final | 59 |
| Parameter 'callback' is not assigned and could be declared final | 59 |
| Parameter 'clientId' is not assigned and could be declared final | 59 |
| Local variable 'thisClientId' could be declared final | 60 |
| These nested if statements could be combined | 72 - 74 |
| These nested if statements could be combined | 72 - 74 |
| Parameter 'component' is not assigned and could be declared final | 86 |
| Parameter 'context' is not assigned and could be declared final | 86 |
| Parameter 'callback' is not assigned and could be declared final | 86 |
| Parameter 'clientId' is not assigned and could be declared final | 86 |
| Local variable 'it' could be declared final | 87 |
| Local variable 'child' could be declared final | 88 |
| Parameter 'facesContext' is not assigned and could be declared final | 101 |
| Parameter 'event' is not assigned and could be declared final | 101 |
| Parameter 'methodBinding' is not assigned and could be declared final | 101 |
| The method 'invokeMethodBinding' has a Cyclomatic Complexity of 5. | 101 - 114 |
| Local variable 'cause' could be declared final | 106 |
| Parameter 'facesContext' is not assigned and could be declared final | 117 |
| Parameter 'event' is not assigned and could be declared final | 117 |
| Parameter 'methodExpression' is not assigned and could be declared final | 117 |
| Parameter 'component' is not assigned and could be declared final | 133 |
| Parameter 'name' is not assigned and could be declared final | 133 |
| Parameter 'context' is not assigned and could be declared final | 133 |
| Parameter 'component' is not assigned and could be declared final | 138 |
| Parameter 'name' is not assigned and could be declared final | 138 |
| Parameter 'component' is not assigned and could be declared final | 143 |
| Parameter 'name' is not assigned and could be declared final | 143 |
| Parameter 'context' is not assigned and could be declared final | 143 |
| Parameter 'component' is not assigned and could be declared final | 148 |
| Parameter 'name' is not assigned and could be declared final | 148 |
| Parameter 'component' is not assigned and could be declared final | 153 |
| Parameter 'context' is not assigned and could be declared final | 153 |
| Parameter 'value' is not assigned and could be declared final | 153 |
| Parameter 'bindingName' is not assigned and could be declared final | 153 |
| Local variable 've' could be declared final | 154 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 161 |
| Parameter 'context' is not assigned and could be declared final | 161 |
| Parameter 'value' is not assigned and could be declared final | 161 |
| Local variable 've' could be declared final | 163 |
| Parameter 'fromComponent' is not assigned and could be declared final | 169 |
| Parameter 'toName' is not assigned and could be declared final | 169 |
| Parameter 'fromName' is not assigned and could be declared final | 169 |
| Parameter 'toComponent' is not assigned and could be declared final | 169 |
| Local variable 've' could be declared final | 170 |
| Parameter 'obj' is not assigned and could be declared final | 176 |
| Local variable 'expression' could be declared final | 178 |
| Parameter 'string' is not assigned and could be declared final | 188 |
| Parameter 'string' is not assigned and could be declared final | 192 |
| Local variable 'facesContext' could be declared final | 193 |
| Local variable 'expressionFactory' could be declared final | 194 |
| Parameter 'editableValueHolder' is not assigned and could be declared final | 201 |
| Parameter 'validator' is not assigned and could be declared final | 201 |
| Avoid if (x != y) ..; else ..; | 205 |
| Parameter 'valueHolder' is not assigned and could be declared final | 212 |
| Parameter 'converterExpression' is not assigned and could be declared final | 212 |
| Local variable 'expression' could be declared final | 214 |
| Avoid if (x != y) ..; else ..; | 215 - 220 |
| Parameter 'component' is not assigned and could be declared final | 227 |
| Parameter 'valueBindingOrExpression' is not assigned and could be declared final | 227 |
| Parameter 'name' is not assigned and could be declared final | 227 |
| Parameter 'source' is not assigned and could be declared final | 235 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 235 |
| Parameter 'type' is not assigned and could be declared final | 235 |
| Parameter 'child' is not assigned and could be declared final | 245 |
| Parameter 'facesContext' is not assigned and could be declared final | 245 |
| Parameter 'var' is not assigned and could be declared final | 245 |
| Parameter 'comparator' is not assigned and could be declared final | 245 |
| Parameter 'descending' is not assigned and could be declared final | 245 |
| Local variable 'valueBinding' could be declared final | 246 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 253 |
| Parameter 'actionSource' is not assigned and could be declared final | 253 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 260 |
| Parameter 'actionSource' is not assigned and could be declared final | 260 |
org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.java
| Violation | Line |
|---|---|
| The class 'MethodBindingToMethodExpression' has a Cyclomatic Complexity of 3 (Highest = 7). | 37 - 231 |
| This class has too many methods, consider refactoring it. | 37 - 231 |
| Document empty constructor | 47 - 48 |
| Parameter 'methodBinding' is not assigned and could be declared final | 54 |
| Parameter 'methodBinding' is not assigned and could be declared final | 67 |
| Parameter 'context' is not assigned and could be declared final | 76 |
| Parameter 'context' is not assigned and could be declared final | 93 |
| Local variable 'expr' could be declared final | 111 |
| Parameter 'context' is not assigned and could be declared final | 119 |
| Parameter 'context' is not assigned and could be declared final | 133 |
| Parameter 'state' is not assigned and could be declared final | 133 |
| Assigning an Object to null is a code smell. Consider refactoring. | 136 |
| Local variable 'values' could be declared final | 138 |
| Assigning an Object to null is a code smell. Consider refactoring. | 141 |
| Parameter 'transientFlag' is not assigned and could be declared final | 145 |
| Parameter 'obj' is not assigned and could be declared final | 162 |
| The method 'equals' has a Cyclomatic Complexity of 7. | 162 - 181 |
| Parameter 'instanceName' is not assigned and could be declared final | 183 |
| Parameter 'notNullInstance' is not assigned and could be declared final | 183 |
| Parameter 'instanceName' is not assigned and could be declared final | 189 |
| Parameter 'notNullInstance' is not assigned and could be declared final | 189 |
| Parameter 'invoker' is not assigned and could be declared final | 195 |
| Parameter 'type' is not assigned and could be declared final | 209 |
| The method 'newInstance' has a Cyclomatic Complexity of 7. | 209 - 229 |
org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.java
| Violation | Line |
|---|---|
| Assigning an Object to null is a code smell. Consider refactoring. | 41 |
| Parameter 'methodExpression' is not assigned and could be declared final | 47 |
| Parameter 'facesContext' is not assigned and could be declared final | 56 |
| Parameter 'facesContext' is not assigned and could be declared final | 68 |
| Parameter 'params' is not assigned and could be declared final | 68 |
| Parameter 'context' is not assigned and could be declared final | 81 |
| Parameter 'state' is not assigned and could be declared final | 81 |
| Parameter 'context' is not assigned and could be declared final | 87 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 94 |
org/apache/myfaces/tobago/component/Sorter.java
| Violation | Line |
|---|---|
| The class 'Sorter' has a Cyclomatic Complexity of 8 (Highest = 28). | 49 - 238 |
| The class 'Sorter' has a Cyclomatic Complexity of 8 (Highest = 28). | 49 - 238 |
| Parameter 'sortEvent' is not assigned and could be declared final | 55 |
| The method 'perform' has a Cyclomatic Complexity of 28. | 55 - 181 |
| The method perform() has an NPath complexity of 34968 | 55 - 181 |
| Avoid really long methods. | 55 - 181 |
| The method 'perform' has a Cyclomatic Complexity of 28. | 55 - 181 |
| Local variable 'column' could be declared final | 59 |
| Local variable 'data' could be declared final | 60 |
| Local variable 'facesContext' could be declared final | 66 |
| Local variable 'sheetState' could be declared final | 67 |
| Local variable 'child' could be declared final | 75 |
| Avoid if (x != y) ..; else ..; | 76 - 117 |
| Local variable 'attributeName' could be declared final | 78 |
| Avoid if (x != y) ..; else ..; | 79 - 112 |
| Local variable 'var' could be declared final | 80 |
| Local variable 'descending' could be declared final | 104 |
| Local variable 'expression' could be declared final | 105 |
| Avoid if (x != y) ..; else ..; | 179 |
| Parameter 'expressionString' is not assigned and could be declared final | 185 |
| The method 'isSimpleProperty' has a Cyclomatic Complexity of 5. | 185 - 197 |
| Local variable 'inner' could be declared final | 187 |
| Local variable 'parts' could be declared final | 188 |
| Parameter 'uiColumn' is not assigned and could be declared final | 199 |
| Parameter 'children' is not assigned and could be declared final | 204 |
| The method 'getFirstSortableChild' has a Cyclomatic Complexity of 13. | 204 - 229 |
| The method 'getFirstSortableChild' has a Cyclomatic Complexity of 13. | 204 - 229 |
| Parameter 'comparator' is not assigned and could be declared final | 235 |
org/apache/myfaces/tobago/component/UIViewRoot.java
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 344 |
| The class 'UIViewRoot' has a Cyclomatic Complexity of 4 (Highest = 12). | 54 - 344 |
| This class has too many methods, consider refactoring it. | 54 - 344 |
| The class 'UIViewRoot' has a Cyclomatic Complexity of 4 (Highest = 12). | 54 - 344 |
| Parameter 'locale' is not assigned and could be declared final | 68 |
| Local variable 'clientProperties' could be declared final | 70 |
| Parameter 'context' is not assigned and could be declared final | 114 |
| Parameter 'phaseId' is not assigned and could be declared final | 114 |
| Parameter 'event' is not assigned and could be declared final | 133 |
| Parameter 'phaseId' is not assigned and could be declared final | 144 |
| The method 'broadcastForPhase' has a Cyclomatic Complexity of 12. | 144 - 196 |
| The method 'broadcastForPhase' has a Cyclomatic Complexity of 12. | 144 - 196 |
| Local variable 'phaseIdOrdinal' could be declared final | 151 |
| Local variable 'listiterator' could be declared final | 152 |
| Local variable 'event' could be declared final | 153 |
| Local variable 'ordinal' could be declared final | 154 |
| Local variable 'source' could be declared final | 156 |
| Deeply nested if..then statements are hard to read | 163 - 165 |
| Avoid if (x != y) ..; else ..; | 174 - 178 |
| Local variable 'eventIndex' could be declared final | 184 |
| Assigning an Object to null is a code smell. Consider refactoring. | 200 |
| Parameter 'context' is not assigned and could be declared final | 205 |
| The method 'processDecodes' has a Cyclomatic Complexity of 6. | 205 - 233 |
| The String literal "context" appears 4 times in this file; the first occurrence is on line 207 | 207 |
| Local variable 'ajaxComponents' could be declared final | 209 |
| Avoid if (x != y) ..; else ..; | 210 - 228 |
| Local variable 'page' could be declared final | 212 |
| Parameter 'page' is not assigned and could be declared final | 235 |
| Parameter 'facesContext' is not assigned and could be declared final | 235 |
| Parameter 'ajaxComponents' is not assigned and could be declared final | 235 - 236 |
| The method 'decodeActionComponent' has a Cyclomatic Complexity of 10. | 235 - 264 |
| The method 'decodeActionComponent' has a Cyclomatic Complexity of 10. | 235 - 264 |
| Local variable 'actionId' could be declared final | 237 |
| Local variable 'bugActionId' could be declared final | 242 |
| Avoid empty catch blocks | 246 - 248 |
| Avoid empty catch blocks | 246 - 248 |
| Parameter 'context' is not assigned and could be declared final | 268 |
| The method 'processValidators' has a Cyclomatic Complexity of 6. | 268 - 286 |
| Local variable 'ajaxComponents' could be declared final | 273 |
| Avoid if (x != y) ..; else ..; | 274 - 281 |
| Parameter 'context' is not assigned and could be declared final | 289 |
| The method 'processUpdates' has a Cyclomatic Complexity of 6. | 289 - 305 |
| Local variable 'ajaxComponents' could be declared final | 293 |
| Avoid if (x != y) ..; else ..; | 294 - 300 |
| Parameter 'context' is not assigned and could be declared final | 308 |
| Parameter 'context' is not assigned and could be declared final | 330 |
| Parameter 'context' is not assigned and could be declared final | 340 |
| Parameter 'callback' is not assigned and could be declared final | 340 |
| Parameter 'clientId' is not assigned and could be declared final | 340 |
org/apache/myfaces/tobago/config/TobagoConfig.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 34 |
| Parameter 'servletContext' is not assigned and could be declared final | 38 |
org/apache/myfaces/tobago/context/ClientProperties.java
| Violation | Line |
|---|---|
| The class 'ClientProperties' has a Cyclomatic Complexity of 1 (Highest = 6). | 48 - 241 |
| Parameter 'tobagoConfig' is not assigned and could be declared final | 79 |
| Parameter 'facesContext' is not assigned and could be declared final | 84 |
| The constructor 'ClientProperties' has a Cyclomatic Complexity of 6. | 84 - 116 |
| Local variable 'externalContext' could be declared final | 86 |
| Local variable 'accept' could be declared final | 89 |
| These nested if statements could be combined | 91 - 93 |
| These nested if statements could be combined | 91 - 93 |
| Local variable 'requestUserAgent' could be declared final | 100 |
| Local variable 'requestTheme' could be declared final | 107 |
| Local variable 'config' could be declared final | 108 |
| Parameter 'facesContext' is not assigned and could be declared final | 122 |
| Parameter 'viewRoot' is not assigned and could be declared final | 131 |
| Parameter 'facesContext' is not assigned and could be declared final | 135 |
| Parameter 'propertyPathMode' is not assigned and could be declared final | 144 |
| Parameter 'locale' is not assigned and could be declared final | 144 |
| Local variable 'prefix' could be declared final | 146 |
| Local variable 'locales' could be declared final | 147 |
| Parameter 'contentType' is not assigned and could be declared final | 168 |
| Parameter 'theme' is not assigned and could be declared final | 177 |
| Parameter 'userAgent' is not assigned and could be declared final | 186 |
| Parameter 'debugMode' is not assigned and could be declared final | 195 |
| Parameter 'locale' is not assigned and could be declared final | 208 |
| Parameter 'verticalScrollbarWeight' is not assigned and could be declared final | 220 |
| Parameter 'horizontalScrollbarWeight' is not assigned and could be declared final | 228 |
| Parameter 'facesContext' is not assigned and could be declared final | 232 |
| Local variable 'externalContext' could be declared final | 233 |
| Local variable 'requestUserAgent' could be declared final | 234 |
| Use equals() to compare object references. | 236 |
org/apache/myfaces/tobago/context/FacesContextFactoryWrapper.java
| Violation | Line |
|---|---|
| Private field 'facesContextFactory' could be made final; it is only initialized in the declaration or constructor. | 28 |
| Parameter 'facesContextFactory' is not assigned and could be declared final | 30 |
| Parameter 'response' is not assigned and could be declared final | 34 |
| Parameter 'lifecycle' is not assigned and could be declared final | 34 |
| Parameter 'request' is not assigned and could be declared final | 34 |
| Parameter 'context' is not assigned and could be declared final | 34 |
org/apache/myfaces/tobago/context/FacesContextWrapper.java
| Violation | Line |
|---|---|
| Private field 'context' could be made final; it is only initialized in the declaration or constructor. | 33 |
| Parameter 'context' is not assigned and could be declared final | 35 |
| Parameter 'clientId' is not assigned and could be declared final | 63 |
| Parameter 'responseStream' is not assigned and could be declared final | 83 |
| Parameter 'responseWriter' is not assigned and could be declared final | 91 |
| Parameter 'root' is not assigned and could be declared final | 99 |
| Parameter 'message' is not assigned and could be declared final | 103 |
| Parameter 'clientId' is not assigned and could be declared final | 103 |
org/apache/myfaces/tobago/context/Markup.java
| Violation | Line |
|---|---|
| The class 'Markup' has a Cyclomatic Complexity of 4 (Highest = 8). | 50 - 315 |
| This class has too many methods, consider refactoring it. | 50 - 315 |
| Parameter 'values' is not assigned and could be declared final | 95 |
| Assigning an Object to null is a code smell. Consider refactoring. | 97 |
| Parameter 'value' is not assigned and could be declared final | 100 |
| Assigning an Object to null is a code smell. Consider refactoring. | 101 |
| Parameter 'values' is not assigned and could be declared final | 105 |
| The method 'valueOf' has a Cyclomatic Complexity of 5. | 105 - 117 |
| Local variable 'markup' could be declared final | 111 |
| Parameter 'value' is not assigned and could be declared final | 119 |
| Local variable 'strings' could be declared final | 124 |
| Parameter 'value' is not assigned and could be declared final | 131 |
| The method 'valueOf' has a Cyclomatic Complexity of 7. | 131 - 152 |
| Local variable 'list' could be declared final | 145 |
| Parameter 'o' is not assigned and could be declared final | 155 |
| The method 'equals' has a Cyclomatic Complexity of 7. | 155 - 173 |
| Local variable 'markup' could be declared final | 163 |
| Avoid if (x != y) ..; else ..; | 165 |
| Avoid if (x != y) ..; else ..; | 177 |
| Avoid if (x != y) ..; else ..; | 178 |
| Parameter 'markup' is not assigned and could be declared final | 196 |
| The method 'add' has a Cyclomatic Complexity of 6. | 196 - 215 |
| Use equals() to compare object references. | 200 |
| Avoid if (x != y) ..; else ..; | 203 - 214 |
| Parameter 'summand' is not assigned and could be declared final | 217 |
| The method 'add' has a Cyclomatic Complexity of 6. | 217 - 241 |
| Parameter 'markup' is not assigned and could be declared final | 243 |
| Avoid if (x != y) ..; else ..; | 244 - 253 |
| Parameter 'summand' is not assigned and could be declared final | 256 |
| The method 'remove' has a Cyclomatic Complexity of 8. | 256 - 285 |
| Parameter 'markup' is not assigned and could be declared final | 287 |
| The method 'contains' has a Cyclomatic Complexity of 6. | 287 - 303 |
org/apache/myfaces/tobago/context/MarkupConfig.java
| Violation | Line |
|---|---|
| Private field 'markups' could be made final; it is only initialized in the declaration or constructor. | 30 |
| Parameter 'markup' is not assigned and could be declared final | 32 |
| Parameter 'markup' is not assigned and could be declared final | 36 |
org/apache/myfaces/tobago/context/MarkupEditor.java
| Violation | Line |
|---|---|
| Parameter 'text' is not assigned and could be declared final | 30 |
org/apache/myfaces/tobago/context/ResourceManagerUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 30 - 177 |
| Parameter 'facesContext' is not assigned and could be declared final | 36 |
| Parameter 'bundle' is not assigned and could be declared final | 36 |
| Parameter 'key' is not assigned and could be declared final | 36 |
| Parameter 'facesContext' is not assigned and could be declared final | 41 |
| Parameter 'bundle' is not assigned and could be declared final | 41 |
| Parameter 'key' is not assigned and could be declared final | 41 |
| Local variable 'result' could be declared final | 42 - 43 |
| Parameter 'facesContext' is not assigned and could be declared final | 54 |
| Parameter 'name' is not assigned and could be declared final | 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 63 |
| Parameter 'name' is not assigned and could be declared final | 63 |
| Parameter 'ignoreMissing' is not assigned and could be declared final | 63 |
| Local variable 'image' could be declared final | 64 - 65 |
| Parameter 'facesContext' is not assigned and could be declared final | 73 |
| Parameter 'name' is not assigned and could be declared final | 73 |
| Local variable 'contextPath' could be declared final | 74 |
| Local variable 'styles' could be declared final | 75 - 76 |
| Parameter 'strings' is not assigned and could be declared final | 80 |
| Parameter 'contextPath' is not assigned and could be declared final | 80 |
| Local variable 'withContext' could be declared final | 81 |
| Parameter 'facesContext' is not assigned and could be declared final | 88 |
| Parameter 'name' is not assigned and could be declared final | 88 |
| Local variable 'contextPath' could be declared final | 89 |
| Local variable 'scripts' could be declared final | 90 - 91 |
| Parameter 'facesContext' is not assigned and could be declared final | 95 |
| Parameter 'names' is not assigned and could be declared final | 95 |
| Local variable 'fileNames' could be declared final | 96 |
| Parameter 'facesContext' is not assigned and could be declared final | 103 |
| Parameter 'names' is not assigned and could be declared final | 103 |
| Local variable 'fileNames' could be declared final | 104 |
| Parameter 'list' is not assigned and could be declared final | 111 |
| Local variable 'sb' could be declared final | 112 |
| Parameter 'facesContext' is not assigned and could be declared final | 124 |
| Parameter 'image' is not assigned and could be declared final | 124 |
| Local variable 'filename' could be declared final | 125 |
| Parameter 'facesContext' is not assigned and could be declared final | 132 |
| Parameter 'facesContext' is not assigned and could be declared final | 137 |
| Parameter 'name' is not assigned and could be declared final | 137 |
| Parameter 'configurable' is not assigned and could be declared final | 142 |
| Parameter 'facesContext' is not assigned and could be declared final | 142 |
| Parameter 'name' is not assigned and could be declared final | 142 |
| Parameter 'value' is not assigned and could be declared final | 156 |
| Local variable 'upper' could be declared final | 160 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 161 |
| Parameter 'facesContext' is not assigned and could be declared final | 167 |
| Parameter 'image' is not assigned and could be declared final | 167 |
| Parameter 'disabled' is not assigned and could be declared final | 167 |
org/apache/myfaces/tobago/context/ResourceUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 22 - 70 |
| Parameter 'folder' is not assigned and could be declared final | 30 |
| Parameter 'extension' is not assigned and could be declared final | 30 |
| Parameter 'postfix' is not assigned and could be declared final | 30 |
| Parameter 'component' is not assigned and could be declared final | 30 |
| Parameter 'name' is not assigned and could be declared final | 30 |
| Parameter 'folder' is not assigned and could be declared final | 44 |
| Parameter 'extension' is not assigned and could be declared final | 44 |
| Parameter 'component' is not assigned and could be declared final | 44 |
| Parameter 'name' is not assigned and could be declared final | 44 |
| Parameter 'postfix' is not assigned and could be declared final | 56 |
| Parameter 'filename' is not assigned and could be declared final | 56 |
| Local variable 'dotIndex' could be declared final | 57 |
| Local variable 'name' could be declared final | 58 |
| Local variable 'extension' could be declared final | 59 |
org/apache/myfaces/tobago/context/ThemeImpl.java
| Violation | Line |
|---|---|
| The class 'ThemeImpl' has a Cyclomatic Complexity of 2 (Highest = 8). | 33 - 261 |
| Private field 'productionResources' could be made final; it is only initialized in the declaration or constructor. | 53 |
| Private field 'resources' could be made final; it is only initialized in the declaration or constructor. | 55 |
| Parameter 'name' is not assigned and could be declared final | 79 |
| Parameter 'displayName' is not assigned and could be declared final | 87 |
| Parameter 'resourcePath' is not assigned and could be declared final | 95 |
| Parameter 'fallback' is not assigned and could be declared final | 103 |
| Parameter 'fallbackName' is not assigned and could be declared final | 111 |
| Parameter 'rendererConfigFromTobagoConfig' is not assigned and could be declared final | 134 |
| The method 'resolveRendererConfig' has a Cyclomatic Complexity of 8. | 134 - 158 |
| Local variable 'fallback' could be declared final | 139 |
| Local variable 'fallbackRenderersConfig' could be declared final | 142 |
| Deeply nested if..then statements are hard to read | 143 - 148 |
| Local variable 'fallback' could be declared final | 161 |
| Local variable 'builder' could be declared final | 170 |
| Parameter 'renderersConfig' is not assigned and could be declared final | 183 |
| Parameter 'themeResources' is not assigned and could be declared final | 203 |
| The method 'init' has a Cyclomatic Complexity of 5. | 211 - 230 |
| Parameter 'production' is not assigned and could be declared final | 232 |
| Parameter 'production' is not assigned and could be declared final | 239 |
| Parameter 'versioned' is not assigned and could be declared final | 250 |
| Parameter 'version' is not assigned and could be declared final | 258 |
org/apache/myfaces/tobago/context/ThemeResource.java
| Violation | Line |
|---|---|
| Parameter 'name' is not assigned and could be declared final | 35 |
| Parameter 'o' is not assigned and could be declared final | 40 |
| Local variable 'that' could be declared final | 48 |
| Avoid if (x != y) ..; else ..; | 50 |
| Avoid if (x != y) ..; else ..; | 56 |
org/apache/myfaces/tobago/context/ThemeResources.java
| Violation | Line |
|---|---|
| Private field 'scriptList' could be made final; it is only initialized in the declaration or constructor. | 34 |
| Private field 'styleList' could be made final; it is only initialized in the declaration or constructor. | 35 |
| Parameter 'toAddResources' is not assigned and could be declared final | 37 |
| Local variable 'script' could be declared final | 42 |
| Local variable 'style' could be declared final | 47 |
| Parameter 'production' is not assigned and could be declared final | 57 |
| Parameter 'script' is not assigned and could be declared final | 61 |
| Parameter 'style' is not assigned and could be declared final | 65 |
org/apache/myfaces/tobago/context/TobagoBundle.java
| Violation | Line |
|---|---|
| Private field 'bundleName' could be made final; it is only initialized in the declaration or constructor. | 41 |
| Parameter 'bundleName' is not assigned and could be declared final | 43 |
| Parameter 'key' is not assigned and could be declared final | 47 |
| Local variable 'facesContext' could be declared final | 51 |
org/apache/myfaces/tobago/context/TobagoContext.java
| Violation | Line |
|---|---|
| Local variable 'facesContext' could be declared final | 35 |
| Local variable 'page' could be declared final | 36 |
| Local variable 'facesContext' could be declared final | 45 |
| Local variable 'page' could be declared final | 46 |
org/apache/myfaces/tobago/context/TobagoFacesContext.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 36 |
| Avoid unused private fields such as 'LOG'. | 36 |
| Private field 'scriptFiles' could be made final; it is only initialized in the declaration or constructor. | 38 |
| Private field 'scriptBlocks' could be made final; it is only initialized in the declaration or constructor. | 40 |
| Private field 'styleFiles' could be made final; it is only initialized in the declaration or constructor. | 42 |
| Private field 'styleBlocks' could be made final; it is only initialized in the declaration or constructor. | 44 |
| Private field 'onloadScripts' could be made final; it is only initialized in the declaration or constructor. | 46 |
| Private field 'onunloadScripts' could be made final; it is only initialized in the declaration or constructor. | 48 |
| Private field 'onexitScripts' could be made final; it is only initialized in the declaration or constructor. | 50 |
| Private field 'onsubmitScripts' could be made final; it is only initialized in the declaration or constructor. | 52 |
| Private field 'popups' could be made final; it is only initialized in the declaration or constructor. | 54 |
| Parameter 'context' is not assigned and could be declared final | 64 |
| Parameter 'ajax' is not assigned and could be declared final | 81 |
| Parameter 'ajaxComponentId' is not assigned and could be declared final | 89 |
| Parameter 'enctype' is not assigned and could be declared final | 97 |
org/apache/myfaces/tobago/context/TransientStateHolder.java
| Violation | Line |
|---|---|
| Document empty constructor | 33 - 34 |
| Parameter 'object' is not assigned and could be declared final | 36 |
| Parameter 'context' is not assigned and could be declared final | 40 |
| Parameter 'object' is not assigned and could be declared final | 45 |
| Parameter 'context' is not assigned and could be declared final | 57 |
| Parameter 'state' is not assigned and could be declared final | 57 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 65 |
org/apache/myfaces/tobago/context/UserAgent.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 33 - 379 |
| The class 'UserAgent' has a Cyclomatic Complexity of 3 (Highest = 18). | 33 - 379 |
| The class 'UserAgent' has a Cyclomatic Complexity of 3 (Highest = 18). | 33 - 379 |
| The String literal "msie" appears 11 times in this file; the first occurrence is on line 43 | 43 |
| The String literal "opera" appears 4 times in this file; the first occurrence is on line 103 | 103 |
| The String literal "mozilla" appears 4 times in this file; the first occurrence is on line 127 | 127 |
| The String literal "gecko" appears 5 times in this file; the first occurrence is on line 150 | 150 |
| Parameter 'name' is not assigned and could be declared final | 200 |
| Parameter 'version' is not assigned and could be declared final | 200 |
| Parameter 'name' is not assigned and could be declared final | 204 |
| Parameter 'capabilities' is not assigned and could be declared final | 204 |
| Parameter 'version' is not assigned and could be declared final | 204 |
| Parameter 'csproHeader' is not assigned and could be declared final | 209 |
| Parameter 'name' is not assigned and could be declared final | 209 |
| Parameter 'cspHeader' is not assigned and could be declared final | 209 |
| Parameter 'capabilities' is not assigned and could be declared final | 209 |
| Parameter 'version' is not assigned and could be declared final | 209 |
| Parameter 'capability' is not assigned and could be declared final | 217 |
| Parameter 'reverseOrder' is not assigned and could be declared final | 241 |
| Local variable 'list' could be declared final | 242 |
| Parameter 'header' is not assigned and could be declared final | 270 |
| The method 'getInstance' has a Cyclomatic Complexity of 18. | 270 - 323 |
| The method 'getInstance' has a Cyclomatic Complexity of 18. | 270 - 323 |
| Local variable 'version' could be declared final | 305 |
| Parameter 'id' is not assigned and could be declared final | 329 |
| Avoid if (x != y) ..; else ..; | 339 - 341 |
| Parameter 'names' is not assigned and could be declared final | 353 |
| Parameter 'names' is not assigned and could be declared final | 371 |
org/apache/myfaces/tobago/convert/CurrencyConverter.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 36 |
| Parameter 'facesContext' is not assigned and could be declared final | 36 |
| Parameter 'string' is not assigned and could be declared final | 36 |
| Parameter 'component' is not assigned and could be declared final | 45 |
| Parameter 'facesContext' is not assigned and could be declared final | 45 |
| Parameter 'object' is not assigned and could be declared final | 45 |
org/apache/myfaces/tobago/convert/DurationConverter.java
| Violation | Line |
|---|---|
| The class 'DurationConverter' has a Cyclomatic Complexity of 8 (Highest = 10). | 37 - 150 |
| The class 'DurationConverter' has a Cyclomatic Complexity of 8 (Highest = 10). | 37 - 150 |
| The method 'getAsString' has a Cyclomatic Complexity of 8. | 51 - 85 |
| Parameter 'component' is not assigned and could be declared final | 52 |
| Parameter 'facesContext' is not assigned and could be declared final | 52 |
| Parameter 'object' is not assigned and could be declared final | 52 |
| Local variable 'factor' could be declared final | 63 |
| Local variable 'format' could be declared final | 66 |
| Unnecessary wrapper object creation | 67 |
| Local variable 'seconds' could be declared final | 68 |
| Local variable 'minutes' could be declared final | 70 |
| The method 'getAsObject' has a Cyclomatic Complexity of 5. | 87 - 119 |
| Parameter 'component' is not assigned and could be declared final | 88 |
| Parameter 'facesContext' is not assigned and could be declared final | 88 |
| Parameter 'string' is not assigned and could be declared final | 88 |
| Local variable 'negative' could be declared final | 90 |
| Local variable 'tokenizer' could be declared final | 91 |
| Local variable 'elements' could be declared final | 92 |
| Local variable 'factor' could be declared final | 112 |
| Local variable 'value' could be declared final | 113 |
| Parameter 'component' is not assigned and could be declared final | 121 |
| The method 'getUnitFactor' has a Cyclomatic Complexity of 10. | 121 - 148 |
| The method 'getUnitFactor' has a Cyclomatic Complexity of 10. | 121 - 148 |
org/apache/myfaces/tobago/convert/LocaleConverter.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 35 |
| Parameter 'facesContext' is not assigned and could be declared final | 35 |
| Parameter 'value' is not assigned and could be declared final | 35 |
| Local variable 'locale' could be declared final | 36 |
| Parameter 'component' is not assigned and could be declared final | 44 |
| Parameter 'facesContext' is not assigned and could be declared final | 44 |
| Parameter 'value' is not assigned and could be declared final | 44 |
org/apache/myfaces/tobago/convert/ThemeConverter.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 40 |
| Parameter 'facesContext' is not assigned and could be declared final | 40 |
| Parameter 'object' is not assigned and could be declared final | 40 |
| Parameter 'component' is not assigned and could be declared final | 50 |
| Parameter 'facesContext' is not assigned and could be declared final | 50 |
| Parameter 'string' is not assigned and could be declared final | 50 |
org/apache/myfaces/tobago/el/ConstantMethodBinding.java
| Violation | Line |
|---|---|
| Parameter 'outcome' is not assigned and could be declared final | 33 |
| Document empty constructor | 38 - 39 |
| Parameter 'facesContext' is not assigned and could be declared final | 41 |
| Parameter 'parameters' is not assigned and could be declared final | 41 |
| Parameter 'facesContext' is not assigned and could be declared final | 45 |
org/apache/myfaces/tobago/el/UserWrapper.java
| Violation | Line |
|---|---|
| This class has too many methods, consider refactoring it. | 31 - 110 |
| Private field 'roles' could be made final; it is only initialized in the declaration or constructor. | 35 |
| Local variable 'facesContext' could be declared final | 42 |
| Local variable 'principal' could be declared final | 43 |
| This class has too many methods, consider refactoring it. | 54 - 109 |
| Parameter 'key' is not assigned and could be declared final | 56 |
| Local variable 'role' could be declared final | 57 |
| Local variable 'facesContext' could be declared final | 58 |
| Local variable 'inRole' could be declared final | 59 |
| Parameter 'key' is not assigned and could be declared final | 78 |
| Parameter 'value' is not assigned and could be declared final | 82 |
| Parameter 't' is not assigned and could be declared final | 90 |
| Parameter 'key' is not assigned and could be declared final | 102 |
| Parameter 'value' is not assigned and could be declared final | 106 |
| Parameter 'key' is not assigned and could be declared final | 106 |
org/apache/myfaces/tobago/event/AbstractPopupActionListener.java
| Violation | Line |
|---|---|
| Parameter 'actionEvent' is not assigned and could be declared final | 35 |
| Local variable 'popup' could be declared final | 36 |
org/apache/myfaces/tobago/event/AbstractResetInputActionListener.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 29 |
| Local variable 'it' could be declared final | 30 |
| Local variable 'child' could be declared final | 32 |
| Parameter 'editableValueHolder' is not assigned and could be declared final | 40 |
org/apache/myfaces/tobago/event/FacesEventWrapper.java
| Violation | Line |
|---|---|
| Private field 'wrappedFacesEvent' could be made final; it is only initialized in the declaration or constructor. | 31 |
| Parameter 'facesEvent' is not assigned and could be declared final | 33 |
| Parameter 'redirectComponent' is not assigned and could be declared final | 33 |
| Parameter 'phaseId' is not assigned and could be declared final | 44 |
| Parameter 'faceslistener' is not assigned and could be declared final | 60 |
| Parameter 'faceslistener' is not assigned and could be declared final | 65 |
org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.java
| Violation | Line |
|---|---|
| Document empty constructor | 35 - 36 |
| Parameter 'methodExpression' is not assigned and could be declared final | 38 |
| Parameter 'actionEvent' is not assigned and could be declared final | 42 |
| Parameter 'context' is not assigned and could be declared final | 46 |
| Parameter 'state' is not assigned and could be declared final | 46 |
| Parameter 'context' is not assigned and could be declared final | 50 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 54 |
org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.java
| Violation | Line |
|---|---|
| Document empty constructor | 35 - 36 |
| Parameter 'methodExpression' is not assigned and could be declared final | 38 |
| Parameter 'actionEvent' is not assigned and could be declared final | 42 |
| Parameter 'context' is not assigned and could be declared final | 46 |
| Parameter 'state' is not assigned and could be declared final | 46 |
| Parameter 'context' is not assigned and could be declared final | 50 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 54 |
org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.java
| Violation | Line |
|---|---|
| Document empty constructor | 36 - 37 |
| Parameter 'methodExpression' is not assigned and could be declared final | 39 |
| Parameter 'event' is not assigned and could be declared final | 43 |
| Avoid unused private methods such as 'elContext()'. | 47 |
| Avoid unused private methods such as 'elContext()'. | 47 |
| Parameter 'context' is not assigned and could be declared final | 51 |
| Parameter 'state' is not assigned and could be declared final | 51 |
| Parameter 'context' is not assigned and could be declared final | 55 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 59 |
org/apache/myfaces/tobago/event/MethodExpressionTreeMarkedListener.java
| Violation | Line |
|---|---|
| Document empty constructor | 39 - 40 |
| Parameter 'methodExpression' is not assigned and could be declared final | 42 |
| Parameter 'event' is not assigned and could be declared final | 46 |
| Avoid unused private methods such as 'elContext()'. | 50 |
| Avoid unused private methods such as 'elContext()'. | 50 |
| Parameter 'context' is not assigned and could be declared final | 54 |
| Parameter 'state' is not assigned and could be declared final | 54 |
| Parameter 'context' is not assigned and could be declared final | 58 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 62 |
org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.java
| Violation | Line |
|---|---|
| Document empty constructor | 35 - 36 |
| Parameter 'methodExpression' is not assigned and could be declared final | 38 |
| Parameter 'event' is not assigned and could be declared final | 42 |
| Avoid unused private methods such as 'elContext()'. | 46 |
| Avoid unused private methods such as 'elContext()'. | 46 |
| Parameter 'context' is not assigned and could be declared final | 50 |
| Parameter 'state' is not assigned and could be declared final | 50 |
| Parameter 'context' is not assigned and could be declared final | 54 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 58 |
org/apache/myfaces/tobago/event/PageAction.java
| Violation | Line |
|---|---|
| Parameter 'token' is not assigned and could be declared final | 59 |
| Parameter 'name' is not assigned and could be declared final | 83 |
| Local variable 'value' could be declared final | 84 |
| Avoid if (x != y) ..; else ..; | 85 - 89 |
org/apache/myfaces/tobago/event/PageActionEvent.java
| Violation | Line |
|---|---|
| Private field 'action' could be made final; it is only initialized in the declaration or constructor. | 31 |
| Parameter 'component' is not assigned and could be declared final | 34 |
| Parameter 'action' is not assigned and could be declared final | 34 |
| Parameter 'value' is not assigned and could be declared final | 46 |
org/apache/myfaces/tobago/event/PopupActionListener.java
| Violation | Line |
|---|---|
| Document empty constructor | 37 - 38 |
| Parameter 'popupId' is not assigned and could be declared final | 40 |
| Parameter 'actionEvent' is not assigned and could be declared final | 48 |
| Local variable 'facesContext' could be declared final | 49 |
| Local variable 'popup' could be declared final | 50 |
| Parameter 'context' is not assigned and could be declared final | 62 |
| Parameter 'state' is not assigned and could be declared final | 62 |
| Local variable 'values' could be declared final | 63 |
| Parameter 'context' is not assigned and could be declared final | 67 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 73 |
org/apache/myfaces/tobago/event/PopupFacetActionListener.java
| Violation | Line |
|---|---|
| Parameter 'actionEvent' is not assigned and could be declared final | 36 |
| Local variable 'component' could be declared final | 37 |
| Avoid if (x != y) ..; else ..; | 40 - 46 |
org/apache/myfaces/tobago/event/ResetFormActionListener.java
| Violation | Line |
|---|---|
| Parameter 'actionEvent' is not assigned and could be declared final | 30 |
org/apache/myfaces/tobago/event/ResetInputActionListener.java
| Violation | Line |
|---|---|
| Document empty constructor | 34 - 35 |
| Parameter 'clientIds' is not assigned and could be declared final | 37 |
| Parameter 'clientIds' is not assigned and could be declared final | 41 |
| Parameter 'event' is not assigned and could be declared final | 45 |
| Local variable 'component' could be declared final | 47 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 58 |
| Parameter 'context' is not assigned and could be declared final | 62 |
| Parameter 'state' is not assigned and could be declared final | 62 |
| Local variable 'values' could be declared final | 63 |
| Parameter 'context' is not assigned and could be declared final | 67 |
org/apache/myfaces/tobago/event/SheetStateChangeEvent.java
| Violation | Line |
|---|---|
| Parameter 'uiComponent' is not assigned and could be declared final | 30 |
| Parameter 'facesListener' is not assigned and could be declared final | 34 |
| Parameter 'facesListener' is not assigned and could be declared final | 38 |
org/apache/myfaces/tobago/event/SortActionEvent.java
| Violation | Line |
|---|---|
| Private field 'column' could be made final; it is only initialized in the declaration or constructor. | 31 |
| Parameter 'column' is not assigned and could be declared final | 33 |
| Parameter 'sheet' is not assigned and could be declared final | 33 |
org/apache/myfaces/tobago/event/TabChangeEvent.java
| Violation | Line |
|---|---|
| Parameter 'oldTabIndex' is not assigned and could be declared final | 33 |
| Parameter 'uiComponent' is not assigned and could be declared final | 33 |
| Parameter 'newTabIndex' is not assigned and could be declared final | 33 |
| Parameter 'oldState' is not assigned and could be declared final | 43 |
| Parameter 'newState' is not assigned and could be declared final | 43 |
| Parameter 'uiComponent' is not assigned and could be declared final | 43 |
| Overridable method 'setOldState' called during object construction | 45 |
| Overridable method 'setNewState' called during object construction | 46 |
| Parameter 'facesListener' is not assigned and could be declared final | 49 |
| Parameter 'facesListener' is not assigned and could be declared final | 53 |
| Parameter 'oldTabIndex' is not assigned and could be declared final | 79 |
| Parameter 'newTabIndex' is not assigned and could be declared final | 95 |
org/apache/myfaces/tobago/event/TreeExpansionEvent.java
| Violation | Line |
|---|---|
| The class 'TreeExpansionEvent' has a Cyclomatic Complexity of 2 (Highest = 6). | 26 - 72 |
| Private field 'oldExpanded' could be made final; it is only initialized in the declaration or constructor. | 30 |
| Private field 'newExpanded' could be made final; it is only initialized in the declaration or constructor. | 31 |
| Parameter 'oldExpanded' is not assigned and could be declared final | 33 |
| Parameter 'node' is not assigned and could be declared final | 33 |
| Parameter 'newExpanded' is not assigned and could be declared final | 33 |
| Parameter 'facesListener' is not assigned and could be declared final | 39 |
| Parameter 'facesListener' is not assigned and could be declared final | 43 |
| The method 'processListener' has a Cyclomatic Complexity of 6. | 43 - 54 |
| Avoid empty if statements | 50 - 52 |
| Avoid empty if statements | 50 - 52 |
org/apache/myfaces/tobago/event/TreeMarkedEvent.java
| Violation | Line |
|---|---|
| The class 'TreeMarkedEvent' has a Cyclomatic Complexity of 2 (Highest = 6). | 30 - 71 |
| Private field 'oldMarked' could be made final; it is only initialized in the declaration or constructor. | 34 |
| Private field 'newMarked' could be made final; it is only initialized in the declaration or constructor. | 35 |
| Parameter 'node' is not assigned and could be declared final | 37 |
| Parameter 'oldMarked' is not assigned and could be declared final | 37 |
| Parameter 'newMarked' is not assigned and could be declared final | 37 |
| Parameter 'facesListener' is not assigned and could be declared final | 43 |
| Parameter 'facesListener' is not assigned and could be declared final | 47 |
| The method 'processListener' has a Cyclomatic Complexity of 6. | 47 - 57 |
| Avoid empty if statements | 53 - 55 |
| Avoid empty if statements | 53 - 55 |
org/apache/myfaces/tobago/event/TreeSelectedEvent.java
| Violation | Line |
|---|---|
| The class 'TreeSelectedEvent' has a Cyclomatic Complexity of 2 (Highest = 6). | 26 - 67 |
| Private field 'oldSelected' could be made final; it is only initialized in the declaration or constructor. | 30 |
| Private field 'newSelected' could be made final; it is only initialized in the declaration or constructor. | 31 |
| Parameter 'node' is not assigned and could be declared final | 33 |
| Parameter 'oldSelected' is not assigned and could be declared final | 33 |
| Parameter 'newSelected' is not assigned and could be declared final | 33 |
| Parameter 'facesListener' is not assigned and could be declared final | 39 |
| Parameter 'facesListener' is not assigned and could be declared final | 43 |
| The method 'processListener' has a Cyclomatic Complexity of 6. | 43 - 53 |
| Avoid empty if statements | 49 - 51 |
| Avoid empty if statements | 49 - 51 |
org/apache/myfaces/tobago/event/ValueExpressionPopupActionListener.java
| Violation | Line |
|---|---|
| Parameter 'expression' is not assigned and could be declared final | 41 |
| Parameter 'expression' is not assigned and could be declared final | 49 |
| Document empty constructor | 56 - 57 |
| Parameter 'actionEvent' is not assigned and could be declared final | 60 |
| Local variable 'id' could be declared final | 61 |
| Local variable 'popup' could be declared final | 62 |
| Parameter 'context' is not assigned and could be declared final | 78 |
| Parameter 'state' is not assigned and could be declared final | 78 |
| Local variable 'values' could be declared final | 79 |
| Parameter 'context' is not assigned and could be declared final | 83 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 90 |
org/apache/myfaces/tobago/event/ValueExpressionResetInputActionListener.java
| Violation | Line |
|---|---|
| The class 'ValueExpressionResetInputActionListener' has a Cyclomatic Complexity of 2 (Highest = 5). | 35 - 90 |
| Document empty constructor | 44 - 45 |
| Parameter 'clientIdsExpression' is not assigned and could be declared final | 47 |
| Parameter 'event' is not assigned and could be declared final | 51 |
| The method 'processAction' has a Cyclomatic Complexity of 5. | 51 - 68 |
| Local variable 'obj' could be declared final | 52 |
| Local variable 'component' could be declared final | 63 |
| Parameter 'context' is not assigned and could be declared final | 74 |
| Parameter 'state' is not assigned and could be declared final | 74 |
| Local variable 'values' could be declared final | 75 |
| Parameter 'context' is not assigned and could be declared final | 79 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 86 |
org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.java
| Violation | Line |
|---|---|
| The class 'ValueExpressionSheetStateChangeListener' has a Cyclomatic Complexity of 2 (Highest = 8). | 30 - 102 |
| Document empty constructor | 37 - 38 |
| Parameter 'valueExpression' is not assigned and could be declared final | 40 |
| Parameter 'type' is not assigned and could be declared final | 40 |
| Parameter 'sheetStateChangeEvent' is not assigned and could be declared final | 45 |
| Local variable 'handler' could be declared final | 46 |
| Avoid if (x != y) ..; else ..; | 47 - 51 |
| Parameter 'context' is not assigned and could be declared final | 54 |
| Parameter 'context' is not assigned and could be declared final | 61 |
| Parameter 'state' is not assigned and could be declared final | 61 |
| Local variable 'values' could be declared final | 62 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 72 |
| The method 'getSheetStateChangeListener' has a Cyclomatic Complexity of 8. | 76 - 91 |
| Local variable 'obj' could be declared final | 79 |
| No need to check for null before an instanceof | 80 |
| Parameter 'className' is not assigned and could be declared final | 93 |
| Local variable 'clazz' could be declared final | 95 |
org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.java
| Violation | Line |
|---|---|
| The class 'ValueExpressionTabChangeListener' has a Cyclomatic Complexity of 2 (Highest = 8). | 30 - 102 |
| Document empty constructor | 37 - 38 |
| Parameter 'valueExpression' is not assigned and could be declared final | 40 |
| Parameter 'type' is not assigned and could be declared final | 40 |
| Parameter 'tabChangeEvent' is not assigned and could be declared final | 45 |
| Local variable 'handler' could be declared final | 46 |
| Avoid if (x != y) ..; else ..; | 47 - 51 |
| Parameter 'context' is not assigned and could be declared final | 54 |
| Parameter 'context' is not assigned and could be declared final | 61 |
| Parameter 'state' is not assigned and could be declared final | 61 |
| Local variable 'values' could be declared final | 62 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 72 |
| The method 'getTabChangeListener' has a Cyclomatic Complexity of 8. | 76 - 91 |
| Local variable 'obj' could be declared final | 79 |
| No need to check for null before an instanceof | 80 |
| Parameter 'className' is not assigned and could be declared final | 93 |
| Local variable 'clazz' could be declared final | 95 |
org/apache/myfaces/tobago/facelets/AttributeHandler.java
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 362 |
| The class 'AttributeHandler' has a Cyclomatic Complexity of 7 (Highest = 59). | 56 - 362 |
| The class 'AttributeHandler' has a Cyclomatic Complexity of 7 (Highest = 59). | 56 - 362 |
| Parameter 'config' is not assigned and could be declared final | 66 |
| Parameter 'parent' is not assigned and could be declared final | 73 |
| Parameter 'faceletContext' is not assigned and could be declared final | 73 |
| The method 'apply' has a Cyclomatic Complexity of 59. | 73 - 281 |
| Avoid really long methods. | 73 - 281 |
| The method 'apply' has a Cyclomatic Complexity of 59. | 73 - 281 |
| The method apply() has an NCSS line count of 165 | 73 - 281 |
| Avoid if (x != y) ..; else ..; | 81 - 279 |
| Avoid if (x != y) ..; else ..; | 85 - 103 |
| Local variable 'expression' could be declared final | 88 - 89 |
| Avoid if (x != y) ..; else ..; | 108 - 126 |
| Local variable 'expression' could be declared final | 111 - 112 |
| Local variable 'expression' could be declared final | 132 - 133 |
| Assigning an Object to null is a code smell. Consider refactoring. | 139 |
| Local variable 'expressionFactory' could be declared final | 149 |
| Local variable 'action' could be declared final | 150 - 151 |
| Local variable 'expression' could be declared final | 158 - 159 |
| Assigning an Object to null is a code smell. Consider refactoring. | 165 |
| Assigning an Object to null is a code smell. Consider refactoring. | 172 |
| Local variable 'expressionFactory' could be declared final | 177 |
| Local variable 'actionListener' could be declared final | 178 - 179 |
| Local variable 'result' could be declared final | 184 |
| Local variable 'expression' could be declared final | 191 - 192 |
| Avoid if (x != y) ..; else ..; | 193 - 200 |
| Local variable 'expression' could be declared final | 205 |
| Local variable 'nameValue' could be declared final | 217 |
| Local variable 'components' could be declared final | 228 |
| Local variable 'expression' could be declared final | 241 |
| Local variable 'methodExpression' could be declared final | 248 |
| Local variable 'methodExpression' could be declared final | 254 - 255 |
| Local variable 'action' could be declared final | 263 |
| Local variable 'action' could be declared final | 268 |
| Parameter 'string' is not assigned and could be declared final | 283 |
| Parameter 'string' is not assigned and could be declared final | 287 |
| Parameter 'string' is not assigned and could be declared final | 292 |
| Parameter 'string' is not assigned and could be declared final | 296 |
| Parameter 'faceletContext' is not assigned and could be declared final | 300 |
| Local variable 'myValue' could be declared final | 301 |
| Parameter 'args' is not assigned and could be declared final | 305 |
| Parameter 'faceletContext' is not assigned and could be declared final | 305 |
| Parameter 'returnType' is not assigned and could be declared final | 305 |
| Local variable 'expression' could be declared final | 310 |
| Avoid if (x != y) ..; else ..; | 311 - 317 |
| Local variable 'expressionFactory' could be declared final | 312 |
| Parameter 'attributeName' is not assigned and could be declared final | 324 |
| Parameter 'expressionString' is not assigned and could be declared final | 324 |
| Parameter 'parent' is not assigned and could be declared final | 324 |
| Parameter 'faceletContext' is not assigned and could be declared final | 324 |
| Local variable 'expressionFactory' could be declared final | 332 |
| Parameter 'nameValue' is not assigned and could be declared final | 338 |
| Parameter 'parent' is not assigned and could be declared final | 338 |
| Parameter 'faceletContext' is not assigned and could be declared final | 338 |
| Local variable 'expression' could be declared final | 343 |
| Parameter 'expression' is not assigned and could be declared final | 353 |
| Parameter 'nameValue' is not assigned and could be declared final | 353 |
| Parameter 'parent' is not assigned and could be declared final | 353 |
| Parameter 'faceletContext' is not assigned and could be declared final | 353 |
| Local variable 'converter' could be declared final | 355 - 356 |
org/apache/myfaces/tobago/facelets/ContentTypeRule.java
| Violation | Line |
|---|---|
| Parameter 'metadataTarget' is not assigned and could be declared final | 35 |
| Parameter 'name' is not assigned and could be declared final | 35 |
| Parameter 'attribute' is not assigned and could be declared final | 35 |
| Parameter 'attribute' is not assigned and could be declared final | 46 |
| Parameter 'ctx' is not assigned and could be declared final | 50 |
| Parameter 'instance' is not assigned and could be declared final | 50 |
| Local variable 'components' could be declared final | 51 |
org/apache/myfaces/tobago/facelets/ConverterHandler.java
| Violation | Line |
|---|---|
| The class 'ConverterHandler' has a Cyclomatic Complexity of 5 (Highest = 8). | 38 - 81 |
| Parameter 'config' is not assigned and could be declared final | 44 |
| Parameter 'parent' is not assigned and could be declared final | 50 |
| Parameter 'faceletContext' is not assigned and could be declared final | 50 |
| The method 'apply' has a Cyclomatic Complexity of 8. | 50 - 80 |
| Local variable 'valueHolder' could be declared final | 54 |
| New exception is thrown in catch block, original stack trace may be lost | 66 |
| Deeply nested if..then statements are hard to read | 68 - 70 |
org/apache/myfaces/tobago/facelets/DataAttributeHandler.java
| Violation | Line |
|---|---|
| The class 'DataAttributeHandler' has a Cyclomatic Complexity of 4 (Highest = 5). | 35 - 64 |
| Parameter 'config' is not assigned and could be declared final | 41 |
| Parameter 'parent' is not assigned and could be declared final | 47 |
| Parameter 'faceletContext' is not assigned and could be declared final | 47 |
| The method 'apply' has a Cyclomatic Complexity of 5. | 47 - 63 |
| Local variable 'attributeName' could be declared final | 55 - 57 |
| Local variable 'attributeValue' could be declared final | 58 - 60 |
org/apache/myfaces/tobago/facelets/DefaultResourceResolver.java
| Violation | Line |
|---|---|
| Avoid unnecessary constructors - the compiler will generate these for you | 33 - 35 |
| Parameter 'path' is not assigned and could be declared final | 37 |
org/apache/myfaces/tobago/facelets/DeprecatedDimensionRule.java
| Violation | Line |
|---|---|
| Parameter 'metadataTarget' is not assigned and could be declared final | 38 |
| Parameter 'name' is not assigned and could be declared final | 38 |
| Parameter 'attribute' is not assigned and could be declared final | 38 |
| Parameter 'attribute' is not assigned and could be declared final | 51 |
| Parameter 'ctx' is not assigned and could be declared final | 55 |
| Parameter 'instance' is not assigned and could be declared final | 55 |
| Local variable 'expression' could be declared final | 59 |
| Parameter 'attribute' is not assigned and could be declared final | 68 |
| Parameter 'ctx' is not assigned and could be declared final | 72 |
| Parameter 'instance' is not assigned and could be declared final | 72 |
| Local variable 'expression' could be declared final | 76 |
org/apache/myfaces/tobago/facelets/FixCharacterEncodingFilter.java
| Violation | Line |
|---|---|
| Document empty method | 31 - 33 |
| Parameter 'filterConfig' is not assigned and could be declared final | 31 |
| Parameter 'servletRequest' is not assigned and could be declared final | 35 |
| Parameter 'filterChain' is not assigned and could be declared final | 36 |
| Parameter 'servletResponse' is not assigned and could be declared final | 36 |
| Document empty method | 44 - 45 |
org/apache/myfaces/tobago/facelets/FlowLayoutRule.java
| Violation | Line |
|---|---|
| The class 'FlowLayoutRule' has a Cyclomatic Complexity of 10 (Highest = 9). | 33 - 140 |
| The class 'FlowLayoutRule' has a Cyclomatic Complexity of 10 (Highest = 9). | 33 - 140 |
| Parameter 'metadataTarget' is not assigned and could be declared final | 37 |
| Parameter 'name' is not assigned and could be declared final | 37 |
| Parameter 'attribute' is not assigned and could be declared final | 37 |
| The method 'applyRule' has a Cyclomatic Complexity of 9. | 37 - 61 |
| These nested if statements could be combined | 39 - 58 |
| These nested if statements could be combined | 39 - 58 |
| Deeply nested if..then statements are hard to read | 40 - 42 |
| Deeply nested if..then statements are hard to read | 43 - 45 |
| Deeply nested if..then statements are hard to read | 46 - 48 |
| Deeply nested if..then statements are hard to read | 49 - 51 |
| Deeply nested if..then statements are hard to read | 52 - 54 |
| Deeply nested if..then statements are hard to read | 55 - 57 |
| Parameter 'attribute' is not assigned and could be declared final | 66 |
| Parameter 'ctx' is not assigned and could be declared final | 70 |
| Parameter 'instance' is not assigned and could be declared final | 70 |
| Local variable 'gridLayout' could be declared final | 71 |
| Parameter 'attribute' is not assigned and could be declared final | 79 |
| Parameter 'ctx' is not assigned and could be declared final | 83 |
| Parameter 'instance' is not assigned and could be declared final | 83 |
| Local variable 'gridLayout' could be declared final | 84 |
| Parameter 'attribute' is not assigned and could be declared final | 92 |
| Parameter 'ctx' is not assigned and could be declared final | 96 |
| Parameter 'instance' is not assigned and could be declared final | 96 |
| Local variable 'gridLayout' could be declared final | 97 |
| Parameter 'attribute' is not assigned and could be declared final | 105 |
| Parameter 'ctx' is not assigned and could be declared final | 109 |
| Parameter 'instance' is not assigned and could be declared final | 109 |
| Local variable 'gridLayout' could be declared final | 110 |
| Parameter 'attribute' is not assigned and could be declared final | 118 |
| Parameter 'ctx' is not assigned and could be declared final | 122 |
| Parameter 'instance' is not assigned and could be declared final | 122 |
| Local variable 'gridLayout' could be declared final | 123 |
| Parameter 'attribute' is not assigned and could be declared final | 131 |
| Parameter 'ctx' is not assigned and could be declared final | 135 |
| Parameter 'instance' is not assigned and could be declared final | 135 |
| Local variable 'gridLayout' could be declared final | 136 |
org/apache/myfaces/tobago/facelets/GridLayoutConstraintHandler.java
| Violation | Line |
|---|---|
| The class 'GridLayoutConstraintHandler' has a Cyclomatic Complexity of 32 (Highest = 62). | 40 - 345 |
| The class 'GridLayoutConstraintHandler' has a Cyclomatic Complexity of 32 (Highest = 62). | 40 - 345 |
| Too many fields | 40 - 345 |
| Parameter 'config' is not assigned and could be declared final | 74 |
| Avoid reassigning parameters such as 'parent' | 100 |
| Avoid reassigning parameters such as 'parent' | 100 |
| Parameter 'faceletContext' is not assigned and could be declared final | 100 |
| The method 'apply' has a Cyclomatic Complexity of 62. | 100 - 344 |
| The method apply() has an NPath complexity of 2106404298 | 100 - 344 |
| Avoid really long methods. | 100 - 344 |
| The method 'apply' has a Cyclomatic Complexity of 62. | 100 - 344 |
| The method apply() has an NCSS line count of 140 | 100 - 344 |
| No need to check for null before an instanceof | 102 |
| No need to check for null before an instanceof | 104 - 105 |
| Local variable 'component' could be declared final | 109 |
| Local variable 'container' could be declared final | 242 |
org/apache/myfaces/tobago/facelets/GridLayoutRule.java
| Violation | Line |
|---|---|
| The class 'GridLayoutRule' has a Cyclomatic Complexity of 12 (Highest = 11). | 32 - 171 |
| The class 'GridLayoutRule' has a Cyclomatic Complexity of 12 (Highest = 11). | 32 - 171 |
| Parameter 'metadataTarget' is not assigned and could be declared final | 36 |
| Parameter 'name' is not assigned and could be declared final | 36 |
| Parameter 'attribute' is not assigned and could be declared final | 36 |
| The method 'applyRule' has a Cyclomatic Complexity of 11. | 36 - 66 |
| The method applyRule() has an NPath complexity of 258 | 36 - 66 |
| The method 'applyRule' has a Cyclomatic Complexity of 11. | 36 - 66 |
| These nested if statements could be combined | 38 - 63 |
| These nested if statements could be combined | 38 - 63 |
| Deeply nested if..then statements are hard to read | 39 - 41 |
| Deeply nested if..then statements are hard to read | 42 - 44 |
| Deeply nested if..then statements are hard to read | 45 - 47 |
| Deeply nested if..then statements are hard to read | 48 - 50 |
| Deeply nested if..then statements are hard to read | 51 - 53 |
| Deeply nested if..then statements are hard to read | 54 - 56 |
| Deeply nested if..then statements are hard to read | 57 - 59 |
| Deeply nested if..then statements are hard to read | 60 - 62 |
| Parameter 'attribute' is not assigned and could be declared final | 71 |
| Parameter 'ctx' is not assigned and could be declared final | 75 |
| Parameter 'instance' is not assigned and could be declared final | 75 |
| Local variable 'gridLayout' could be declared final | 76 |
| Parameter 'attribute' is not assigned and could be declared final | 84 |
| Parameter 'ctx' is not assigned and could be declared final | 88 |
| Parameter 'instance' is not assigned and could be declared final | 88 |
| Local variable 'gridLayout' could be declared final | 89 |
| Parameter 'attribute' is not assigned and could be declared final | 97 |
| Parameter 'ctx' is not assigned and could be declared final | 101 |
| Parameter 'instance' is not assigned and could be declared final | 101 |
| Local variable 'gridLayout' could be declared final | 102 |
| Parameter 'attribute' is not assigned and could be declared final | 110 |
| Parameter 'ctx' is not assigned and could be declared final | 114 |
| Parameter 'instance' is not assigned and could be declared final | 114 |
| Local variable 'gridLayout' could be declared final | 115 |
| Parameter 'attribute' is not assigned and could be declared final | 123 |
| Parameter 'ctx' is not assigned and could be declared final | 127 |
| Parameter 'instance' is not assigned and could be declared final | 127 |
| Local variable 'gridLayout' could be declared final | 128 |
| Parameter 'attribute' is not assigned and could be declared final | 136 |
| Parameter 'ctx' is not assigned and could be declared final | 140 |
| Parameter 'instance' is not assigned and could be declared final | 140 |
| Local variable 'gridLayout' could be declared final | 141 |
| Parameter 'attribute' is not assigned and could be declared final | 149 |
| Parameter 'ctx' is not assigned and could be declared final | 153 |
| Parameter 'instance' is not assigned and could be declared final | 153 |
| Local variable 'gridLayout' could be declared final | 154 |
| Parameter 'attribute' is not assigned and could be declared final | 162 |
| Parameter 'ctx' is not assigned and could be declared final | 166 |
| Parameter 'instance' is not assigned and could be declared final | 166 |
| Local variable 'gridLayout' could be declared final | 167 |
org/apache/myfaces/tobago/facelets/LoadBundleHandler.java
| Violation | Line |
|---|---|
| Parameter 'config' is not assigned and could be declared final | 41 |
| Parameter 'parent' is not assigned and could be declared final | 47 |
| Parameter 'faceletContext' is not assigned and could be declared final | 47 |
| Local variable 'name' could be declared final | 49 |
| Local variable 'map' could be declared final | 50 |
| Local variable 'facesContext' could be declared final | 51 |
org/apache/myfaces/tobago/facelets/MetaInfResourcesClasspathResourceResolver.java
| Violation | Line |
|---|---|
| The class 'MetaInfResourcesClasspathResourceResolver' has a Cyclomatic Complexity of 4 (Highest = 5). | 42 - 70 |
| Avoid reassigning parameters such as 'path' | 52 |
| Avoid reassigning parameters such as 'path' | 52 |
| The method 'resolveUrl' has a Cyclomatic Complexity of 5. | 52 - 69 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 58 |
org/apache/myfaces/tobago/facelets/PopupReferenceHandler.java
| Violation | Line |
|---|---|
| Parameter 'config' is not assigned and could be declared final | 43 |
| Parameter 'parent' is not assigned and could be declared final | 48 |
| Parameter 'faceletContext' is not assigned and could be declared final | 48 |
| Local variable 'actionSource' could be declared final | 52 |
| Local variable 'forValueExpression' could be declared final | 56 |
org/apache/myfaces/tobago/facelets/PositionRule.java
| Violation | Line |
|---|---|
| Parameter 'metadataTarget' is not assigned and could be declared final | 38 |
| Parameter 'name' is not assigned and could be declared final | 38 |
| Parameter 'attribute' is not assigned and could be declared final | 38 |
| Parameter 'attribute' is not assigned and could be declared final | 51 |
| Parameter 'ctx' is not assigned and could be declared final | 55 |
| Parameter 'instance' is not assigned and could be declared final | 55 |
| Local variable 'expression' could be declared final | 59 |
| Parameter 'attribute' is not assigned and could be declared final | 68 |
| Parameter 'ctx' is not assigned and could be declared final | 72 |
| Parameter 'instance' is not assigned and could be declared final | 72 |
| Local variable 'expression' could be declared final | 76 |
org/apache/myfaces/tobago/facelets/ResetInputActionListenerHandler.java
| Violation | Line |
|---|---|
| The class 'ResetInputActionListenerHandler' has a Cyclomatic Complexity of 4 (Highest = 5). | 41 - 68 |
| Parameter 'config' is not assigned and could be declared final | 45 |
| Parameter 'parent' is not assigned and could be declared final | 50 |
| Parameter 'faceletContext' is not assigned and could be declared final | 50 |
| The method 'apply' has a Cyclomatic Complexity of 5. | 50 - 67 |
| Local variable 'actionSource' could be declared final | 54 |
| Local variable 'forValueExpression' could be declared final | 60 |
org/apache/myfaces/tobago/facelets/Resource.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 39 - 142 |
| The class 'Resource' has a Cyclomatic Complexity of 5 (Highest = 8). | 39 - 142 |
| Parameter 'ctx' is not assigned and could be declared final | 59 |
| Parameter 'path' is not assigned and could be declared final | 59 |
| These nested if statements could be combined | 73 - 75 |
| These nested if statements could be combined | 73 - 75 |
| Parameter 'externalContext' is not assigned and could be declared final | 83 |
| Parameter 'path' is not assigned and could be declared final | 83 |
| The method 'resourceExist' has a Cyclomatic Complexity of 5. | 83 - 103 |
| Local variable 'ctx' could be declared final | 88 |
| Local variable 'servletContext' could be declared final | 90 |
| Local variable 'stream' could be declared final | 91 |
| Avoid empty catch blocks | 95 - 98 |
| Avoid empty catch blocks | 95 - 98 |
| Parameter 'path' is not assigned and could be declared final | 107 |
| The method 'getUrlForResourceAsStream' has a Cyclomatic Complexity of 8. | 107 - 141 |
| Local variable 'handler' could be declared final | 109 - 139 |
| Parameter 'u' is not assigned and could be declared final | 110 |
| The method 'openConnection' has a Cyclomatic Complexity of 7. | 110 - 138 |
| Document empty method | 113 - 114 |
| The method 'getInputStream' has a Cyclomatic Complexity of 5. | 116 - 136 |
| Avoid if (x != y) ..; else ..; | 134 |
org/apache/myfaces/tobago/facelets/ScriptHandler.java
| Violation | Line |
|---|---|
| Parameter 'config' is not assigned and could be declared final | 34 |
| Parameter 'component' is not assigned and could be declared final | 38 |
| Parameter 'context' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 38 |
| Document empty method | 48 - 49 |
| Parameter 'c' is not assigned and could be declared final | 48 |
| Parameter 'ctx' is not assigned and could be declared final | 48 |
org/apache/myfaces/tobago/facelets/SheetStateChangeSourceRule.java
| Violation | Line |
|---|---|
| Parameter 'metadataTarget' is not assigned and could be declared final | 38 |
| Parameter 'name' is not assigned and could be declared final | 38 |
| Parameter 'attribute' is not assigned and could be declared final | 38 |
| These nested if statements could be combined | 40 - 42 |
| These nested if statements could be combined | 40 - 42 |
| Parameter 'attribute' is not assigned and could be declared final | 51 |
| Parameter 'ctx' is not assigned and could be declared final | 55 |
| Parameter 'instance' is not assigned and could be declared final | 55 |
org/apache/myfaces/tobago/facelets/SortActionSourceRule.java
| Violation | Line |
|---|---|
| Parameter 'name' is not assigned and could be declared final | 38 |
| Parameter 'attribute' is not assigned and could be declared final | 38 |
| Parameter 'metadataTarget' is not assigned and could be declared final | 39 |
| These nested if statements could be combined | 41 - 43 |
| These nested if statements could be combined | 41 - 43 |
| Parameter 'attribute' is not assigned and could be declared final | 52 |
| Parameter 'ctx' is not assigned and could be declared final | 56 |
| Parameter 'instance' is not assigned and could be declared final | 56 |
org/apache/myfaces/tobago/facelets/StyleHandler.java
| Violation | Line |
|---|---|
| Parameter 'config' is not assigned and could be declared final | 34 |
| Parameter 'component' is not assigned and could be declared final | 38 |
| Parameter 'context' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 38 |
| Document empty method | 49 - 50 |
| Parameter 'c' is not assigned and could be declared final | 49 |
| Parameter 'ctx' is not assigned and could be declared final | 49 |
org/apache/myfaces/tobago/facelets/SuggestMethodRule.java
| Violation | Line |
|---|---|
| The class 'SuggestMethodRule' has a Cyclomatic Complexity of 7 (Highest = 6). | 32 - 80 |
| Parameter 'metadataTarget' is not assigned and could be declared final | 38 |
| Parameter 'name' is not assigned and could be declared final | 38 |
| Parameter 'attribute' is not assigned and could be declared final | 38 |
| The method 'applyRule' has a Cyclomatic Complexity of 6. | 38 - 53 |
| These nested if statements could be combined | 41 - 43 |
| These nested if statements could be combined | 41 - 43 |
| These nested if statements could be combined | 46 - 50 |
| These nested if statements could be combined | 46 - 50 |
| These nested if statements could be combined | 47 - 49 |
| Deeply nested if..then statements are hard to read | 47 - 49 |
| These nested if statements could be combined | 47 - 49 |
| Parameter 'attribute' is not assigned and could be declared final | 58 |
| Parameter 'ctx' is not assigned and could be declared final | 62 |
| Parameter 'instance' is not assigned and could be declared final | 62 |
| Parameter 'attribute' is not assigned and could be declared final | 71 |
| Parameter 'ctx' is not assigned and could be declared final | 75 |
| Parameter 'instance' is not assigned and could be declared final | 75 |
org/apache/myfaces/tobago/facelets/SupportsMarkupRule.java
| Violation | Line |
|---|---|
| Parameter 'metadataTarget' is not assigned and could be declared final | 38 |
| Parameter 'name' is not assigned and could be declared final | 38 |
| Parameter 'attribute' is not assigned and could be declared final | 38 |
| These nested if statements could be combined | 40 - 42 |
| These nested if statements could be combined | 40 - 42 |
| Parameter 'attribute' is not assigned and could be declared final | 51 |
| Parameter 'ctx' is not assigned and could be declared final | 55 |
| Parameter 'instance' is not assigned and could be declared final | 55 |
| Local variable 'expression' could be declared final | 59 |
org/apache/myfaces/tobago/facelets/SupportsRenderedPartiallyRule.java
| Violation | Line |
|---|---|
| Parameter 'metadataTarget' is not assigned and could be declared final | 38 |
| Parameter 'name' is not assigned and could be declared final | 38 |
| Parameter 'attribute' is not assigned and could be declared final | 38 |
| These nested if statements could be combined | 40 - 42 |
| These nested if statements could be combined | 40 - 42 |
| Parameter 'attribute' is not assigned and could be declared final | 51 |
| Parameter 'ctx' is not assigned and could be declared final | 55 |
| Parameter 'instance' is not assigned and could be declared final | 55 |
| Local variable 'components' could be declared final | 57 |
| Local variable 'expression' could be declared final | 60 |
org/apache/myfaces/tobago/facelets/TabChangeListenerHandler.java
| Violation | Line |
|---|---|
| The class 'TabChangeListenerHandler' has a Cyclomatic Complexity of 6 (Highest = 8). | 38 - 96 |
| Parameter 'config' is not assigned and could be declared final | 47 |
| Parameter 'parent' is not assigned and could be declared final | 63 |
| Parameter 'faceletContext' is not assigned and could be declared final | 63 |
| The method 'apply' has a Cyclomatic Complexity of 8. | 63 - 95 |
| Local variable 'changeSource' could be declared final | 68 |
| New exception is thrown in catch block, original stack trace may be lost | 79 |
| Deeply nested if..then statements are hard to read | 81 - 83 |
| Avoid if (x != y) ..; else ..; | 85 - 90 |
org/apache/myfaces/tobago/facelets/TabChangeSourceRule.java
| Violation | Line |
|---|---|
| Parameter 'metadataTarget' is not assigned and could be declared final | 35 |
| Parameter 'name' is not assigned and could be declared final | 35 |
| Parameter 'attribute' is not assigned and could be declared final | 35 |
| These nested if statements could be combined | 37 - 39 |
| These nested if statements could be combined | 37 - 39 |
| Parameter 'attribute' is not assigned and could be declared final | 48 |
| Parameter 'ctx' is not assigned and could be declared final | 52 |
| Parameter 'instance' is not assigned and could be declared final | 52 |
org/apache/myfaces/tobago/facelets/TagMethodExpression.java
| Violation | Line |
|---|---|
| Parameter 'attr' is not assigned and could be declared final | 54 |
| Parameter 'orig' is not assigned and could be declared final | 54 |
| Parameter 'context' is not assigned and could be declared final | 59 |
| New exception is thrown in catch block, original stack trace may be lost | 63 |
| New exception is thrown in catch block, original stack trace may be lost | 65 |
| New exception is thrown in catch block, original stack trace may be lost | 67 |
| Parameter 'context' is not assigned and could be declared final | 71 |
| Parameter 'params' is not assigned and could be declared final | 71 |
| New exception is thrown in catch block, original stack trace may be lost | 75 |
| New exception is thrown in catch block, original stack trace may be lost | 77 |
| New exception is thrown in catch block, original stack trace may be lost | 79 |
| Parameter 'obj' is not assigned and could be declared final | 87 |
| Parameter 'out' is not assigned and could be declared final | 99 |
| Parameter 'in' is not assigned and could be declared final | 104 |
org/apache/myfaces/tobago/facelets/TobagoComponentHandler.java
| Violation | Line |
|---|---|
| The class 'TobagoComponentHandler' has a Cyclomatic Complexity of 5 (Highest = 11). | 52 - 146 |
| The class 'TobagoComponentHandler' has a Cyclomatic Complexity of 5 (Highest = 11). | 52 - 146 |
| Parameter 'componentConfig' is not assigned and could be declared final | 60 |
| Parameter 'aClass' is not assigned and could be declared final | 64 |
| The method 'createMetaRuleset' has a Cyclomatic Complexity of 11. | 64 - 97 |
| The method createMetaRuleset() has an NPath complexity of 1024 | 64 - 97 |
| The method 'createMetaRuleset' has a Cyclomatic Complexity of 11. | 64 - 97 |
| Local variable 'metaRuleset' could be declared final | 65 |
| Parameter 'component' is not assigned and could be declared final | 99 |
| Parameter 'context' is not assigned and could be declared final | 99 |
| Parameter 'parent' is not assigned and could be declared final | 99 |
| Parameter 'component' is not assigned and could be declared final | 107 |
| Parameter 'context' is not assigned and could be declared final | 107 |
| Parameter 'parent' is not assigned and could be declared final | 107 |
| Parameter 'component' is not assigned and could be declared final | 119 |
| Parameter 'context' is not assigned and could be declared final | 119 |
| The method 'addDefaultValidators' has a Cyclomatic Complexity of 7. | 119 - 145 |
| Local variable 'tobagoConfig' could be declared final | 120 |
| Local variable 'validatorInfoMap' could be declared final | 121 |
| Local variable 'validators' could be declared final | 125 |
| Local variable 'classNames' could be declared final | 127 |
| Local variable 'it' could be declared final | 132 |
| Local variable 'entry' could be declared final | 134 |
| Local variable 'it' could be declared final | 140 |
org/apache/myfaces/tobago/facelets/TobagoValidateHandler.java
| Violation | Line |
|---|---|
| Parameter 'config' is not assigned and could be declared final | 30 |
| Parameter 'aClass' is not assigned and could be declared final | 34 |
| Local variable 'metaRuleset' could be declared final | 35 |
org/apache/myfaces/tobago/facelets/WizardComponentHandler.java
| Violation | Line |
|---|---|
| Private field 'outcomeAttribute' could be made final; it is only initialized in the declaration or constructor. | 30 |
| Parameter 'componentConfig' is not assigned and could be declared final | 32 |
| Parameter 'parent' is not assigned and could be declared final | 37 |
| Parameter 'wizard' is not assigned and could be declared final | 37 |
| Parameter 'faceletContext' is not assigned and could be declared final | 37 |
| Local variable 'expression' could be declared final | 43 |
org/apache/myfaces/tobago/facelets/extension/DateExtensionHandler.java
| Violation | Line |
|---|---|
| The class 'DateExtensionHandler' has a Cyclomatic Complexity of 2 (Highest = 7). | 39 - 100 |
| Private field 'pickerIdAttribute' could be made final; it is only initialized in the declaration or constructor. | 41 |
| Private field 'formIdAttribute' could be made final; it is only initialized in the declaration or constructor. | 42 |
| Private field 'markupAttribute' could be made final; it is only initialized in the declaration or constructor. | 43 |
| Parameter 'config' is not assigned and could be declared final | 45 |
| Parameter 'panel' is not assigned and could be declared final | 60 |
| Parameter 'parent' is not assigned and could be declared final | 60 |
| Parameter 'faceletContext' is not assigned and could be declared final | 60 |
| The method 'onComponentPopulated' has a Cyclomatic Complexity of 7. | 60 - 95 |
| Local variable 'application' could be declared final | 63 |
| Avoid unused local variables such as 'root'. | 64 |
| Local variable 'root' could be declared final | 64 |
| Avoid unused local variables such as 'root'. | 64 |
| Local variable 'form' could be declared final | 66 |
| Avoid if (x != y) ..; else ..; | 68 - 70 |
| Local variable 'picker' could be declared final | 74 |
| Avoid if (x != y) ..; else ..; | 77 - 79 |
| Local variable 'expression' could be declared final | 89 |
| Parameter 'first' is not assigned and could be declared final | 97 |
org/apache/myfaces/tobago/facelets/extension/FileExtensionHandler.java
| Violation | Line |
|---|---|
| Parameter 'config' is not assigned and could be declared final | 29 |
org/apache/myfaces/tobago/facelets/extension/InExtensionHandler.java
| Violation | Line |
|---|---|
| Parameter 'config' is not assigned and could be declared final | 29 |
org/apache/myfaces/tobago/facelets/extension/LabelExtensionHandler.java
| Violation | Line |
|---|---|
| Parameter 'config' is not assigned and could be declared final | 32 |
org/apache/myfaces/tobago/facelets/extension/MenuCheckboxExtensionHandler.java
| Violation | Line |
|---|---|
| Parameter 'config' is not assigned and could be declared final | 41 |
org/apache/myfaces/tobago/facelets/extension/MenuRadioExtensionHandler.java
| Violation | Line |
|---|---|
| Parameter 'config' is not assigned and could be declared final | 45 |
org/apache/myfaces/tobago/facelets/extension/SelectBooleanCheckboxExtensionHandler.java
| Violation | Line |
|---|---|
| Private field 'itemLabelAttribute' could be made final; it is only initialized in the declaration or constructor. | 34 |
| Parameter 'config' is not assigned and could be declared final | 36 |
| Parameter 'input' is not assigned and could be declared final | 41 |
| Parameter 'faceletContext' is not assigned and could be declared final | 41 |
| Local variable 'checkbox' could be declared final | 43 |
| Avoid if (x != y) ..; else ..; | 44 - 53 |
| Local variable 'expression' could be declared final | 48 |
org/apache/myfaces/tobago/facelets/extension/SelectManyCheckboxExtensionHandler.java
| Violation | Line |
|---|---|
| Parameter 'config' is not assigned and could be declared final | 29 |
org/apache/myfaces/tobago/facelets/extension/SelectManyListboxExtensionHandler.java
| Violation | Line |
|---|---|
| Parameter 'config' is not assigned and could be declared final | 28 |
org/apache/myfaces/tobago/facelets/extension/SelectManyShuttleExtensionHandler.java
| Violation | Line |
|---|---|
| Parameter 'config' is not assigned and could be declared final | 29 |
org/apache/myfaces/tobago/facelets/extension/SelectOneChoiceExtensionHandler.java
| Violation | Line |
|---|---|
| Parameter 'config' is not assigned and could be declared final | 28 |
org/apache/myfaces/tobago/facelets/extension/SelectOneListboxExtensionHandler.java
| Violation | Line |
|---|---|
| Parameter 'config' is not assigned and could be declared final | 28 |
org/apache/myfaces/tobago/facelets/extension/SelectOneRadioExtensionHandler.java
| Violation | Line |
|---|---|
| Parameter 'config' is not assigned and could be declared final | 28 |
org/apache/myfaces/tobago/facelets/extension/SeparatorExtensionHandler.java
| Violation | Line |
|---|---|
| Private field 'labelAttribute' could be made final; it is only initialized in the declaration or constructor. | 43 |
| Parameter 'config' is not assigned and could be declared final | 45 |
| Parameter 'faceletContext' is not assigned and could be declared final | 50 |
| Parameter 'separator' is not assigned and could be declared final | 50 |
| Local variable 'component' could be declared final | 53 |
| Parameter 'parent' is not assigned and could be declared final | 61 |
| Parameter 'faceletContext' is not assigned and could be declared final | 61 |
| Parameter 'separator' is not assigned and could be declared final | 61 |
| Local variable 'application' could be declared final | 62 |
| Avoid unused local variables such as 'root'. | 63 |
| Local variable 'root' could be declared final | 63 |
| Avoid unused local variables such as 'root'. | 63 |
| Local variable 'label' could be declared final | 64 |
| Local variable 'expression' could be declared final | 73 |
| Parameter 'aClass' is not assigned and could be declared final | 79 |
| Local variable 'metaRuleset' could be declared final | 80 |
| Local variable 'attrs' could be declared final | 85 |
| Local variable 'attr' could be declared final | 87 |
org/apache/myfaces/tobago/facelets/extension/TextareaExtensionHandler.java
| Violation | Line |
|---|---|
| Parameter 'config' is not assigned and could be declared final | 29 |
org/apache/myfaces/tobago/facelets/extension/TimeExtensionHandler.java
| Violation | Line |
|---|---|
| Parameter 'config' is not assigned and could be declared final | 29 |
org/apache/myfaces/tobago/facelets/extension/TobagoLabelExtensionHandler.java
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 265 |
| The class 'TobagoLabelExtensionHandler' has a Cyclomatic Complexity of 3 (Highest = 8). | 54 - 265 |
| Private field 'labelWidthAttribute' could be made final; it is only initialized in the declaration or constructor. | 60 |
| Private field 'tipAttribute' could be made final; it is only initialized in the declaration or constructor. | 61 |
| Private field 'labelAttribute' could be made final; it is only initialized in the declaration or constructor. | 62 |
| Private field 'markupAttribute' could be made final; it is only initialized in the declaration or constructor. | 63 |
| Private field 'fieldIdAttribute' could be made final; it is only initialized in the declaration or constructor. | 64 |
| Parameter 'config' is not assigned and could be declared final | 68 |
| Parameter 'first' is not assigned and could be declared final | 85 |
| Parameter 'panel' is not assigned and could be declared final | 89 |
| Parameter 'ctx' is not assigned and could be declared final | 89 |
| Local variable 'input' could be declared final | 93 |
| Local variable 'input' could be declared final | 109 |
| Parameter 'panel' is not assigned and could be declared final | 114 |
| Parameter 'parent' is not assigned and could be declared final | 114 |
| Parameter 'faceletContext' is not assigned and could be declared final | 114 |
| Avoid if (x != y) ..; else ..; | 122 - 126 |
| Local variable 'input' could be declared final | 131 |
| Document empty method | 141 - 142 |
| An empty method in an abstract class should be abstract instead | 141 - 142 |
| Parameter 'input' is not assigned and could be declared final | 141 |
| Parameter 'faceletContext' is not assigned and could be declared final | 141 |
| Parameter 'panel' is not assigned and could be declared final | 144 |
| Parameter 'faceletContext' is not assigned and could be declared final | 144 |
| The method 'addLabel' has a Cyclomatic Complexity of 8. | 144 - 178 |
| Parameter 'panel' is not assigned and could be declared final | 180 |
| Parameter 'uid' is not assigned and could be declared final | 180 |
| Parameter 'component' is not assigned and could be declared final | 191 |
| Parameter 'parent' is not assigned and could be declared final | 191 |
| Parameter 'faceletContext' is not assigned and could be declared final | 191 |
| Local variable 'input' could be declared final | 195 |
| Parameter 'panel' is not assigned and could be declared final | 205 |
| Parameter 'faceletContext' is not assigned and could be declared final | 205 |
| The method 'addGridLayout' has a Cyclomatic Complexity of 5. | 205 - 227 |
| Avoid if (x != y) ..; else ..; | 208 - 217 |
| Parameter 'ctx' is not assigned and could be declared final | 229 |
| Parameter 'instance' is not assigned and could be declared final | 229 |
| Local variable 'type' could be declared final | 231 |
| Parameter 'aClass' is not assigned and could be declared final | 240 |
| Local variable 'metaRuleset' could be declared final | 241 |
| Parameter 'aClass' is not assigned and could be declared final | 254 |
| Local variable 'metaRuleset' could be declared final | 255 |
| Local variable 'attrs' could be declared final | 256 |
| Local variable 'attr' could be declared final | 258 |
org/apache/myfaces/tobago/facelets/extension/TobagoMenuExtensionHandler.java
| Violation | Line |
|---|---|
| Private field 'fieldIdAttribute' could be made final; it is only initialized in the declaration or constructor. | 44 |
| Parameter 'config' is not assigned and could be declared final | 46 |
| Parameter 'menuCommand' is not assigned and could be declared final | 57 |
| Parameter 'faceletContext' is not assigned and could be declared final | 57 |
| Local variable 'component' could be declared final | 60 |
| Parameter 'menuCommand' is not assigned and could be declared final | 68 |
| Parameter 'parent' is not assigned and could be declared final | 68 |
| Parameter 'faceletContext' is not assigned and could be declared final | 68 |
| Avoid if (x != y) ..; else ..; | 72 - 74 |
| Parameter 'ctx' is not assigned and could be declared final | 81 |
| Parameter 'instance' is not assigned and could be declared final | 81 |
| Local variable 'type' could be declared final | 83 |
| Parameter 'aClass' is not assigned and could be declared final | 92 |
| Local variable 'metaRuleset' could be declared final | 93 |
| Local variable 'attrs' could be declared final | 94 |
| Local variable 'attr' could be declared final | 96 |
| Parameter 'aClass' is not assigned and could be declared final | 105 |
| Local variable 'metaRuleset' could be declared final | 106 |
org/apache/myfaces/tobago/internal/ajax/AjaxInternalUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 41 - 217 |
| The class 'AjaxInternalUtils' has a Cyclomatic Complexity of 3 (Highest = 6). | 41 - 217 |
| Parameter 'facesContext' is not assigned and could be declared final | 53 |
| Parameter 'compClass' is not assigned and could be declared final | 53 |
| Parameter 'uiComponent' is not assigned and could be declared final | 53 |
| The method 'checkParamValidity' has a Cyclomatic Complexity of 5. | 53 - 67 |
| Parameter 'component' is not assigned and could be declared final | 69 |
| Parameter 'facesContext' is not assigned and could be declared final | 69 |
| The method 'encodeAjaxComponent' has a Cyclomatic Complexity of 5. | 69 - 80 |
| Local variable 'renderer' could be declared final | 76 |
| No need to check for null before an instanceof | 77 |
| Parameter 'facesContext' is not assigned and could be declared final | 82 |
| Local variable 'ajaxComponents' could be declared final | 83 |
| Local variable 'viewRoot' could be declared final | 85 |
| Local variable 'page' could be declared final | 86 |
| Parameter 'facesContext' is not assigned and could be declared final | 90 |
| Parameter 'messages' is not assigned and could be declared final | 90 |
| Local variable 'attributes' could be declared final | 91 |
| Parameter 'facesContext' is not assigned and could be declared final | 102 |
| Parameter 'facesContext' is not assigned and could be declared final | 106 |
| Local variable 'parameterMap' could be declared final | 107 |
| Local variable 'component' could be declared final | 108 |
| Local variable 'clientId' could be declared final | 109 |
| Local variable 'ids' could be declared final | 110 |
| Local variable 'list' could be declared final | 111 |
| Local variable 'tokenizer' could be declared final | 113 |
| Local variable 'id' could be declared final | 115 |
| Parameter 'facesContext' is not assigned and could be declared final | 123 |
| The method 'parseAndStoreComponents' has a Cyclomatic Complexity of 6. | 123 - 148 |
| Local variable 'parameterMap' could be declared final | 124 |
| Local variable 'ajaxComponentIds' could be declared final | 125 |
| Local variable 'tokenizer' could be declared final | 130 |
| Local variable 'ajaxComponents' could be declared final | 131 |
| Local variable 'viewRoot' could be declared final | 134 |
| Local variable 'ajaxId' could be declared final | 136 |
| Local variable 'ajaxComponent' could be declared final | 137 |
| Parameter 'facesContext' is not assigned and could be declared final | 150 |
| Parameter 'component' is not assigned and could be declared final | 156 |
| Parameter 'facesContext' is not assigned and could be declared final | 156 |
| Local variable 'ajaxComponents' could be declared final | 157 - 158 |
| These nested if statements could be combined | 160 - 162 |
| These nested if statements could be combined | 160 - 162 |
| Parameter 'value' is not assigned and could be declared final | 166 |
| Parameter 'component' is not assigned and could be declared final | 173 |
| Parameter 'ajaxComponents' is not assigned and could be declared final | 173 |
| Parameter 'context' is not assigned and could be declared final | 188 |
| Parameter 'componentClientId' is not assigned and could be declared final | 188 |
| Parameter 'facesContext' is not assigned and could be declared final | 201 |
| Parameter 'clientId' is not assigned and could be declared final | 201 |
| Parameter 'component' is not assigned and could be declared final | 205 |
| Parameter 'facesContext' is not assigned and could be declared final | 205 |
| Local variable 'ajaxComponents' could be declared final | 210 |
| These nested if statements could be combined | 212 - 214 |
| These nested if statements could be combined | 212 - 214 |
org/apache/myfaces/tobago/internal/ajax/AjaxNavigationListener.java
| Violation | Line |
|---|---|
| Parameter 'phaseEvent' is not assigned and could be declared final | 28 |
| Parameter 'phaseEvent' is not assigned and could be declared final | 34 |
org/apache/myfaces/tobago/internal/ajax/AjaxNavigationState.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 37 - 163 |
| The class 'AjaxNavigationState' has a Cyclomatic Complexity of 4 (Highest = 6). | 37 - 163 |
| Private field 'viewRoot' could be made final; it is only initialized in the declaration or constructor. | 45 |
| Private field 'messages' could be made final; it is only initialized in the declaration or constructor. | 51 |
| Parameter 'facesContext' is not assigned and could be declared final | 53 |
| The constructor 'AjaxNavigationState' has a Cyclomatic Complexity of 5. | 53 - 76 |
| Local variable 'externalContext' could be declared final | 54 |
| Local variable 'iterator' could be declared final | 62 |
| Parameter 'facesContext' is not assigned and could be declared final | 78 |
| Parameter 'clientId' is not assigned and could be declared final | 78 |
| Local variable 'facesMessages' could be declared final | 79 |
| Parameter 'facesMessage' is not assigned and could be declared final | 85 |
| Parameter 'clientId' is not assigned and could be declared final | 85 |
| Parameter 'facesContext' is not assigned and could be declared final | 94 |
| The method 'restoreView' has a Cyclomatic Complexity of 6. | 94 - 116 |
| Local variable 'requestMap' could be declared final | 96 |
| Parameter 'facesContext' is not assigned and could be declared final | 118 |
| Avoid if (x != y) ..; else ..; | 121 - 125 |
| Parameter 'facesContext' is not assigned and could be declared final | 130 |
| The method 'isNavigation' has a Cyclomatic Complexity of 5. | 130 - 153 |
| Avoid if (x != y) ..; else ..; | 134 - 138 |
| Local variable 'externalContext' could be declared final | 141 |
| Local variable 'requestMap' could be declared final | 142 |
| Local variable 'incomingViewRoot' could be declared final | 143 |
| Use equals() to compare object references. | 144 |
| Parameter 'facesContext' is not assigned and could be declared final | 155 |
| Local variable 'sessionMap' could be declared final | 156 |
| Local variable 'navigationState' could be declared final | 157 |
org/apache/myfaces/tobago/internal/ajax/AjaxResponseRenderer.java
| Violation | Line |
|---|---|
| The class 'AjaxResponseRenderer' has a Cyclomatic Complexity of 2 (Highest = 7). | 48 - 192 |
| Private field 'callback' could be made final; it is only initialized in the declaration or constructor. | 61 |
| Parameter 'facesContext' is not assigned and could be declared final | 67 |
| Local variable 'renderFactory' could be declared final | 69 |
| Local variable 'renderKit' could be declared final | 70 |
| Parameter 'renderKit' is not assigned and could be declared final | 74 |
| Parameter 'component' is not assigned and could be declared final | 74 |
| Parameter 'facesContext' is not assigned and could be declared final | 74 |
| Parameter 'clientId' is not assigned and could be declared final | 74 |
| Parameter 'renderKit' is not assigned and could be declared final | 105 |
| Parameter 'facesContext' is not assigned and could be declared final | 105 |
| Local variable 'stateWriter' could be declared final | 107 |
| Local variable 'stateManager' could be declared final | 110 |
| Local variable 'serializedView' could be declared final | 111 |
| Avoid reassigning parameters such as 'charset' | 115 |
| Parameter 'facesContext' is not assigned and could be declared final | 115 |
| Parameter 'contentType' is not assigned and could be declared final | 115 |
| Local variable 'sb' could be declared final | 116 |
| Parameter 'renderKit' is not assigned and could be declared final | 125 |
| Parameter 'facesContext' is not assigned and could be declared final | 125 |
| Parameter 'reloadRequired' is not assigned and could be declared final | 125 |
| The method 'writeResponse' has a Cyclomatic Complexity of 7. | 125 - 169 |
| Local variable 'page' could be declared final | 130 |
| Avoid if (x != y) ..; else ..; | 132 - 136 |
| Local variable 'writer' could be declared final | 139 |
| Local variable 'ajaxComponents' could be declared final | 144 |
| Local variable 'component' could be declared final | 153 |
| Parameter 'facesContext' is not assigned and could be declared final | 171 |
| Local variable 'externalContext' could be declared final | 172 |
| Parameter 'renderKit' is not assigned and could be declared final | 182 |
| Parameter 'writer' is not assigned and could be declared final | 182 |
| Local variable 'newWriter' could be declared final | 184 |
org/apache/myfaces/tobago/internal/component/AbstractUIBox.java
| Violation | Line |
|---|---|
| Parameter 'context' is not assigned and could be declared final | 27 |
| Parameter 'context' is not assigned and could be declared final | 36 |
| Parameter 'context' is not assigned and could be declared final | 43 |
org/apache/myfaces/tobago/internal/component/AbstractUIButton.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 24 - 26 |
org/apache/myfaces/tobago/internal/component/AbstractUICell.java
| Violation | Line |
|---|---|
| Parameter 'spanX' is not assigned and could be declared final | 40 |
| Parameter 'spanY' is not assigned and could be declared final | 48 |
org/apache/myfaces/tobago/internal/component/AbstractUIColumn.java
| Violation | Line |
|---|---|
| An empty method in an abstract class should be abstract instead | 31 - 33 |
org/apache/myfaces/tobago/internal/component/AbstractUIColumnNode.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 27 - 28 |
org/apache/myfaces/tobago/internal/component/AbstractUIColumnSelector.java
| Violation | Line |
|---|---|
| An empty method in an abstract class should be abstract instead | 27 - 29 |
org/apache/myfaces/tobago/internal/component/AbstractUICommand.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 24 - 27 |
org/apache/myfaces/tobago/internal/component/AbstractUICommandBase.java
| Violation | Line |
|---|---|
| The class 'AbstractUICommandBase' has a Cyclomatic Complexity of 2 (Highest = 5). | 34 - 98 |
| Parameter 'facesContext' is not assigned and could be declared final | 37 |
| Parameter 'parent' is not assigned and could be declared final | 37 |
| Local variable 'popup' could be declared final | 38 |
| These nested if statements could be combined | 40 - 42 |
| These nested if statements could be combined | 40 - 42 |
| Parameter 'context' is not assigned and could be declared final | 46 |
| The method 'processDecodes' has a Cyclomatic Complexity of 5. | 46 - 69 |
| Local variable 'kids' could be declared final | 64 |
| Local variable 'kid' could be declared final | 66 |
| Parameter 'facesEvent' is not assigned and could be declared final | 71 |
org/apache/myfaces/tobago/internal/component/AbstractUIData.java
| Violation | Line |
|---|---|
| The class 'AbstractUIData' has a Cyclomatic Complexity of 2 (Highest = 7). | 42 - 258 |
| This class has too many methods, consider refactoring it. | 42 - 258 |
| The String literal "Not a tree model" appears 4 times in this file; the first occurrence is on line 73 | 73 |
| Avoid if (x != y) ..; else ..; | 82 - 86 |
| Local variable 'value' could be declared final | 91 |
| Local variable 'showRoot' could be declared final | 92 |
| Avoid if (x != y) ..; else ..; | 104 |
| Parameter 'showRoot' is not assigned and could be declared final | 115 |
| Parameter 'value' is not assigned and could be declared final | 115 |
| Parameter 'context' is not assigned and could be declared final | 123 |
| Avoid if (x != y) ..; else ..; | 147 - 151 |
| Avoid if (x != y) ..; else ..; | 156 |
| Avoid if (x != y) ..; else ..; | 161 |
| An empty method in an abstract class should be abstract instead | 166 - 168 |
| An empty method in an abstract class should be abstract instead | 183 - 185 |
| Parameter 'facesContext' is not assigned and could be declared final | 188 |
| Parameter 'callback' is not assigned and could be declared final | 188 |
| Parameter 'clientId' is not assigned and could be declared final | 188 |
| The method 'invokeOnComponent' has a Cyclomatic Complexity of 7. | 188 - 224 |
| Local variable 'oldRowIndex' could be declared final | 191 |
| Local variable 'sheetId' could be declared final | 193 |
| Local variable 'idx' could be declared final | 201 |
| String.indexOf(char) is faster than String.indexOf(String). | 201 |
| Local variable 'rowIndex' could be declared final | 203 |
org/apache/myfaces/tobago/internal/component/AbstractUIDate.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 22 - 23 |
org/apache/myfaces/tobago/internal/component/AbstractUIDatePicker.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 37 |
| Avoid unused private fields such as 'LOG'. | 37 |
| Parameter 'facesEvent' is not assigned and could be declared final | 48 |
| Local variable 'facesContext' could be declared final | 49 |
| Local variable 'popup' could be declared final | 50 |
| Local variable 'clientId' could be declared final | 51 |
| Local variable 'box' could be declared final | 52 |
| Local variable 'calendar' could be declared final | 53 |
| Local variable 'time' could be declared final | 55 |
| Parameter 'context' is not assigned and could be declared final | 62 |
| Parameter 'parent' is not assigned and could be declared final | 62 |
| Local variable 'renderer' could be declared final | 63 |
| An empty method in an abstract class should be abstract instead | 69 - 71 |
| An empty method in an abstract class should be abstract instead | 73 - 75 |
| An empty method in an abstract class should be abstract instead | 77 - 79 |
org/apache/myfaces/tobago/internal/component/AbstractUIFile.java
| Violation | Line |
|---|---|
| The class 'AbstractUIFile' has a Cyclomatic Complexity of 2 (Highest = 5). | 31 - 59 |
| Parameter 'facesContext' is not assigned and could be declared final | 33 |
| The method 'validate' has a Cyclomatic Complexity of 5. | 33 - 47 |
| Local variable 'file' could be declared final | 36 |
| Parameter 'facesContext' is not assigned and could be declared final | 49 |
org/apache/myfaces/tobago/internal/component/AbstractUIFlowLayout.java
| Violation | Line |
|---|---|
| Document empty method | 30 - 31 |
| An empty method in an abstract class should be abstract instead | 30 - 31 |
| Document empty method | 33 - 34 |
| An empty method in an abstract class should be abstract instead | 33 - 34 |
| Parameter 'orientation' is not assigned and could be declared final | 33 |
| Parameter 'auto' is not assigned and could be declared final | 33 |
| Document empty method | 36 - 37 |
| An empty method in an abstract class should be abstract instead | 36 - 37 |
| Parameter 'orientation' is not assigned and could be declared final | 36 |
| Document empty method | 39 - 41 |
| An empty method in an abstract class should be abstract instead | 39 - 41 |
| Parameter 'orientation' is not assigned and could be declared final | 39 |
| Document empty method | 43 - 44 |
| An empty method in an abstract class should be abstract instead | 43 - 44 |
| Parameter 'orientation' is not assigned and could be declared final | 43 |
org/apache/myfaces/tobago/internal/component/AbstractUIForm.java
| Violation | Line |
|---|---|
| The class 'AbstractUIForm' has a Cyclomatic Complexity of 4 (Highest = 5). | 37 - 121 |
| Parameter 'facesContext' is not assigned and could be declared final | 45 |
| Local variable 'kids' could be declared final | 52 |
| Local variable 'kid' could be declared final | 54 |
| Parameter 'b' is not assigned and could be declared final | 60 |
| Parameter 'facesContext' is not assigned and could be declared final | 70 |
| The method 'processValidators' has a Cyclomatic Complexity of 5. | 70 - 87 |
| Avoid if (x != y) ..; else ..; | 75 - 86 |
| Local variable 'kids' could be declared final | 81 |
| Local variable 'kid' could be declared final | 83 |
| Parameter 'facesContext' is not assigned and could be declared final | 90 |
| The method 'processUpdates' has a Cyclomatic Complexity of 5. | 90 - 107 |
| Avoid if (x != y) ..; else ..; | 95 - 106 |
| Local variable 'kids' could be declared final | 101 |
| Local variable 'kid' could be declared final | 103 |
| Parameter 'context' is not assigned and could be declared final | 110 |
| Parameter 'callback' is not assigned and could be declared final | 110 |
| Parameter 'clientId' is not assigned and could be declared final | 110 |
| These nested if statements could be combined | 114 - 116 |
| These nested if statements could be combined | 114 - 116 |
org/apache/myfaces/tobago/internal/component/AbstractUIGridLayout.java
| Violation | Line |
|---|---|
| The class 'AbstractUIGridLayout' has a Cyclomatic Complexity of 4 (Highest = 24). | 51 - 501 |
| This class has too many methods, consider refactoring it. | 51 - 501 |
| The class 'AbstractUIGridLayout' has a Cyclomatic Complexity of 4 (Highest = 24). | 51 - 501 |
| The method 'init' has a Cyclomatic Complexity of 7. | 62 - 85 |
| Local variable 'components' could be declared final | 70 |
| Avoid instantiating new objects inside loops | 74 |
| Parameter 'orientation' is not assigned and could be declared final | 87 |
| Parameter 'auto' is not assigned and could be declared final | 87 |
| The method 'fixRelativeInsideAuto' has a Cyclomatic Complexity of 15. | 87 - 132 |
| The method fixRelativeInsideAuto() has an NPath complexity of 400 | 87 - 132 |
| The method 'fixRelativeInsideAuto' has a Cyclomatic Complexity of 15. | 87 - 132 |
| Local variable 'heads' could be declared final | 93 |
| Local variable 'heads2' could be declared final | 94 |
| Deeply nested if..then statements are hard to read | 99 - 102 |
| Local variable 'cell' could be declared final | 111 |
| Local variable 'origin' could be declared final | 118 |
| Local variable 'component' could be declared final | 119 |
| Local variable 'layoutManager' could be declared final | 121 |
| Local variable 'childAuto' could be declared final | 123 |
| Parameter 'orientation' is not assigned and could be declared final | 134 |
| The method 'preProcessing' has a Cyclomatic Complexity of 24. | 134 - 234 |
| The method preProcessing() has an NPath complexity of 14420 | 134 - 234 |
| Avoid really long methods. | 134 - 234 |
| The method 'preProcessing' has a Cyclomatic Complexity of 24. | 134 - 234 |
| Local variable 'token' could be declared final | 147 |
| Local variable 'intervalList' could be declared final | 157 |
| Avoid instantiating new objects inside loops | 157 |
| Local variable 'cell' could be declared final | 159 |
| Local variable 'origin' could be declared final | 161 |
| Local variable 'component' could be declared final | 162 |
| Avoid instantiating new objects inside loops | 170 |
| Avoid empty if statements | 210 - 213 |
| Avoid empty if statements | 210 - 213 |
| Assigning an Object to null is a code smell. Consider refactoring. | 217 |
| Parameter 'orientation' is not assigned and could be declared final | 236 |
| The method 'mainProcessing' has a Cyclomatic Complexity of 23. | 236 - 335 |
| The method mainProcessing() has an NPath complexity of 30400 | 236 - 335 |
| The method 'mainProcessing' has a Cyclomatic Complexity of 23. | 236 - 335 |
| Local variable 'factorList' could be declared final | 246 |
| Local variable 'container' could be declared final | 254 |
| Avoid if (x != y) ..; else ..; | 256 - 290 |
| Local variable 'client' could be declared final | 269 |
| Local variable 'partition' could be declared final | 275 |
| Local variable 'cell' could be declared final | 296 |
| Local variable 'component' could be declared final | 298 |
| Local variable 'span' could be declared final | 302 |
| Local variable 'current' could be declared final | 310 |
| Parameter 'orientation' is not assigned and could be declared final | 337 |
| The method 'postProcessing' has a Cyclomatic Complexity of 15. | 337 - 391 |
| The method 'postProcessing' has a Cyclomatic Complexity of 15. | 337 - 391 |
| Local variable 'cell' could be declared final | 349 |
| Local variable 'component' could be declared final | 351 |
| Parameter 'orientation' is not assigned and could be declared final | 398 |
| Parameter 'orientation' is not assigned and could be declared final | 402 |
| Parameter 'orientation' is not assigned and could be declared final | 406 |
| Parameter 'orientation' is not assigned and could be declared final | 414 |
| Parameter 'startIndex' is not assigned and could be declared final | 414 |
| Parameter 'length' is not assigned and could be declared final | 414 |
| The method 'computeSpacing' has a Cyclomatic Complexity of 6. | 414 - 430 |
| An empty method in an abstract class should be abstract instead | 462 - 464 |
| Parameter 'depth' is not assigned and could be declared final | 466 |
| The method 'toString' has a Cyclomatic Complexity of 6. | 466 - 495 |
| Local variable 'builder' could be declared final | 467 |
org/apache/myfaces/tobago/internal/component/AbstractUIIn.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 33 |
| Parameter 'parent' is not assigned and could be declared final | 33 |
| These nested if statements could be combined | 35 - 42 |
| These nested if statements could be combined | 35 - 42 |
| Local variable 'suggest' could be declared final | 36 - 37 |
org/apache/myfaces/tobago/internal/component/AbstractUIInput.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 32 |
org/apache/myfaces/tobago/internal/component/AbstractUILabel.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 24 - 26 |
org/apache/myfaces/tobago/internal/component/AbstractUILayoutBase.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 24 - 25 |
org/apache/myfaces/tobago/internal/component/AbstractUIMediator.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 34 |
| Avoid unused private fields such as 'LOG'. | 34 |
| Parameter 'facesContext' is not assigned and could be declared final | 39 |
| Parameter 'facesContext' is not assigned and could be declared final | 47 |
| Parameter 'event' is not assigned and could be declared final | 55 |
| Local variable 'requestMap' could be declared final | 56 |
| Parameter 'context' is not assigned and could be declared final | 66 |
| Parameter 'context' is not assigned and could be declared final | 74 |
| Parameter 'state' is not assigned and could be declared final | 74 |
| Local variable 'values' could be declared final | 75 |
| Parameter 'var' is not assigned and could be declared final | 84 |
org/apache/myfaces/tobago/internal/component/AbstractUIMenu.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 24 - 25 |
org/apache/myfaces/tobago/internal/component/AbstractUIMenuBar.java
| Violation | Line |
|---|---|
| Parameter 'context' is not assigned and could be declared final | 33 |
| Parameter 'parent' is not assigned and could be declared final | 33 |
| Local variable 'renderer' could be declared final | 34 |
org/apache/myfaces/tobago/internal/component/AbstractUIMessages.java
| Violation | Line |
|---|---|
| The class 'AbstractUIMessages' has a Cyclomatic Complexity of 3 (Highest = 7). | 33 - 136 |
| Parameter 'facesContext' is not assigned and could be declared final | 36 |
| Avoid if (x != y) ..; else ..; | 41 - 45 |
| Local variable 'messages' could be declared final | 47 |
| Parameter 'facesContext' is not assigned and could be declared final | 57 |
| Parameter 'clientIds' is not assigned and could be declared final | 57 |
| The method 'collectMessageList' has a Cyclomatic Complexity of 7. | 57 - 77 |
| Local variable 'messages' could be declared final | 58 |
| Local variable 'clientId' could be declared final | 60 |
| Local variable 'i' could be declared final | 61 |
| Local variable 'facesMessage' could be declared final | 63 |
| Avoid instantiating new objects inside loops | 73 |
| Parameter 'facesMessage' is not assigned and could be declared final | 84 |
| Parameter 'clientId' is not assigned and could be declared final | 84 |
| Parameter 'clientId' is not assigned and could be declared final | 93 |
| Parameter 'facesMessage' is not assigned and could be declared final | 101 |
| Parameter 'item2' is not assigned and could be declared final | 107 |
| Parameter 'item1' is not assigned and could be declared final | 107 |
| Parameter 'key' is not assigned and could be declared final | 132 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 133 |
org/apache/myfaces/tobago/internal/component/AbstractUIOut.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 26 - 27 |
org/apache/myfaces/tobago/internal/component/AbstractUIPage.java
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 299 |
| The class 'AbstractUIPage' has a Cyclomatic Complexity of 2 (Highest = 11). | 57 - 299 |
| The class 'AbstractUIPage' has a Cyclomatic Complexity of 2 (Highest = 11). | 57 - 299 |
| An empty method in an abstract class should be abstract instead | 75 - 77 |
| Parameter 'facesContext' is not assigned and could be declared final | 79 |
| Parameter 'facesContext' is not assigned and could be declared final | 87 |
| Parameter 'facesContext' is not assigned and could be declared final | 94 |
| Parameter 'facesContext' is not assigned and could be declared final | 100 |
| Parameter 'facesContext' is not assigned and could be declared final | 107 |
| Local variable 'kids' could be declared final | 116 |
| Local variable 'kid' could be declared final | 117 |
| Parameter 'facesContext' is not assigned and could be declared final | 122 |
| The method 'markSubmittedForm' has a Cyclomatic Complexity of 11. | 122 - 177 |
| The method 'markSubmittedForm' has a Cyclomatic Complexity of 11. | 122 - 177 |
| Avoid empty catch blocks | 152 - 154 |
| Avoid empty catch blocks | 152 - 154 |
| Avoid if (x != y) ..; else ..; | 163 - 176 |
| Local variable 'form' could be declared final | 164 |
| Parameter 'facesContext' is not assigned and could be declared final | 179 |
| The method 'checkTobagoRequest' has a Cyclomatic Complexity of 7. | 179 - 203 |
| Local variable 'contentType' could be declared final | 181 - 182 |
| Local variable 'request' could be declared final | 184 |
| Local variable 'wrappedRequest' could be declared final | 189 - 190 |
| Parameter 'context' is not assigned and could be declared final | 213 |
| Document empty method | 223 - 224 |
| An empty method in an abstract class should be abstract instead | 223 - 224 |
| Parameter 'facesContext' is not assigned and could be declared final | 223 |
| Parameter 'facesContext' is not assigned and could be declared final | 231 |
| Avoid if (x != y) ..; else ..; | 233 - 243 |
| Parameter 'actionId' is not assigned and could be declared final | 250 |
| Parameter 'actionPosition' is not assigned and could be declared final | 258 |
| Parameter 'defaultActionId' is not assigned and could be declared final | 269 |
| Parameter 'facesContext' is not assigned and could be declared final | 273 |
| Parameter 'parent' is not assigned and could be declared final | 273 |
| Parameter 'layoutManager' is not assigned and could be declared final | 288 |
org/apache/myfaces/tobago/internal/component/AbstractUIPanel.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 41 |
| Parameter 'facesContext' is not assigned and could be declared final | 48 |
| Parameter 'facesContext' is not assigned and could be declared final | 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 60 |
| Parameter 'parent' is not assigned and could be declared final | 60 |
| Parameter 'layoutManager' is not assigned and could be declared final | 75 |
org/apache/myfaces/tobago/internal/component/AbstractUIPanelBase.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 22 - 25 |
org/apache/myfaces/tobago/internal/component/AbstractUIPopup.java
| Violation | Line |
|---|---|
| The class 'AbstractUIPopup' has a Cyclomatic Complexity of 2 (Highest = 5). | 50 - 217 |
| This class has too many methods, consider refactoring it. | 52 - 217 |
| Avoid unused private fields such as 'LOG'. | 54 |
| Avoid unused private fields such as 'LOG'. | 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 60 |
| Parameter 'parent' is not assigned and could be declared final | 60 |
| Parameter 'facesContext' is not assigned and could be declared final | 71 |
| Parameter 'parent' is not assigned and could be declared final | 71 |
| Parameter 'activated' is not assigned and could be declared final | 83 |
| Parameter 'facesContext' is not assigned and could be declared final | 88 |
| The method 'processDecodes' has a Cyclomatic Complexity of 5. | 88 - 104 |
| Local variable 'it' could be declared final | 90 |
| Local variable 'childOrFacet' could be declared final | 91 |
| Avoid if (x != y) ..; else ..; | 109 - 114 |
| Local variable 'context' could be declared final | 110 |
| The method 'isRedisplay' has a Cyclomatic Complexity of 5. | 124 - 136 |
| Local variable 'action' could be declared final | 126 |
| No need to check for null before an instanceof | 130 |
| Parameter 'context' is not assigned and could be declared final | 144 |
| Local variable 'it' could be declared final | 146 |
| Local variable 'childOrFacet' could be declared final | 147 |
| Parameter 'context' is not assigned and could be declared final | 158 |
| Local variable 'it' could be declared final | 160 |
| Local variable 'childOrFacet' could be declared final | 161 |
| Parameter 'context' is not assigned and could be declared final | 168 |
| Parameter 'savedState' is not assigned and could be declared final | 176 |
| Parameter 'context' is not assigned and could be declared final | 176 |
| Local variable 'values' could be declared final | 177 |
| Parameter 'context' is not assigned and could be declared final | 183 |
| Parameter 'layoutManager' is not assigned and could be declared final | 192 |
org/apache/myfaces/tobago/internal/component/AbstractUISelectBooleanCheckbox.java
| Violation | Line |
|---|---|
| The class 'AbstractUISelectBooleanCheckbox' has a Cyclomatic Complexity of 5 (Highest = 6). | 30 - 58 |
| Parameter 'facesContext' is not assigned and could be declared final | 45 |
| Parameter 'convertedValue' is not assigned and could be declared final | 45 |
| The method 'validateValue' has a Cyclomatic Complexity of 6. | 45 - 57 |
| These nested if statements could be combined | 47 - 54 |
| These nested if statements could be combined | 47 - 54 |
org/apache/myfaces/tobago/internal/component/AbstractUISelectItem.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 37 |
| Parameter 'parent' is not assigned and could be declared final | 37 |
| Local variable 'converted' could be declared final | 39 - 40 |
| Parameter 'itemValue' is not assigned and could be declared final | 46 |
| Avoid empty if statements | 49 - 51 |
| Avoid empty if statements | 49 - 51 |
org/apache/myfaces/tobago/internal/component/AbstractUISelectMany.java
| Violation | Line |
|---|---|
| Local variable 'value' could be declared final | 32 |
org/apache/myfaces/tobago/internal/component/AbstractUISelectOneBase.java
| Violation | Line |
|---|---|
| The class 'AbstractUISelectOneBase' has a Cyclomatic Complexity of 4 (Highest = 6). | 30 - 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 35 |
| The method 'validate' has a Cyclomatic Complexity of 6. | 35 - 51 |
| Local variable 'submittedValue' could be declared final | 37 |
| Avoid if (x != y) ..; else ..; | 39 - 46 |
| Local variable 'requiredMessage' could be declared final | 40 |
org/apache/myfaces/tobago/internal/component/AbstractUISelectOneChoice.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 22 - 23 |
org/apache/myfaces/tobago/internal/component/AbstractUISelectOneListbox.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 22 - 23 |
org/apache/myfaces/tobago/internal/component/AbstractUISelectOneRadio.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 22 - 23 |
org/apache/myfaces/tobago/internal/component/AbstractUISeparator.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 26 - 27 |
org/apache/myfaces/tobago/internal/component/AbstractUISheet.java
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 662 |
| This class has a bunch of public methods and attributes | 20 - 662 |
| The class 'AbstractUISheet' has a Cyclomatic Complexity of 3 (Highest = 19). | 66 - 662 |
| The class 'AbstractUISheet' has a Cyclomatic Complexity of 3 (Highest = 19). | 66 - 662 |
| This class has too many methods, consider refactoring it. | 68 - 662 |
| Avoid unused private fields such as 'ajaxResponseCode'. | 94 |
| Avoid unused private fields such as 'ajaxResponseCode'. | 94 |
| Parameter 'context' is not assigned and could be declared final | 102 |
| Parameter 'facesContext' is not assigned and could be declared final | 107 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 5. | 107 - 119 |
| Local variable 'state' could be declared final | 108 |
| Avoid if (x != y) ..; else ..; | 112 - 116 |
| Parameter 'state' is not assigned and could be declared final | 121 |
| Parameter 'facesContext' is not assigned and could be declared final | 129 |
| Local variable 'columns' could be declared final | 153 |
| Local variable 'state' could be declared final | 166 |
| Local variable 'last' could be declared final | 178 |
| Local variable 'last' could be declared final | 195 |
| Local variable 'rows' could be declared final | 203 |
| Local variable 'first' could be declared final | 208 |
| Parameter 'column' is not assigned and could be declared final | 241 |
| Local variable 'children' could be declared final | 242 |
| Avoid if (x != y) ..; else ..; | 279 - 283 |
| Avoid if (x != y) ..; else ..; | 289 - 297 |
| Avoid if (x != y) ..; else ..; | 323 - 331 |
| Local variable 'rows' could be declared final | 327 |
| Local variable 'rowCount' could be declared final | 328 |
| Local variable 'tail' could be declared final | 329 |
| Avoid if (x != y) ..; else ..; | 330 |
| Parameter 'context' is not assigned and could be declared final | 335 |
| Parameter 'facesContext' is not assigned and could be declared final | 340 |
| Local variable 'state' could be declared final | 341 |
| Local variable 'attributes' could be declared final | 347 |
| Avoid if (x != y) ..; else ..; | 350 |
| Parameter 'context' is not assigned and could be declared final | 360 |
| Parameter 'savedState' is not assigned and could be declared final | 368 |
| Parameter 'context' is not assigned and could be declared final | 368 |
| Local variable 'values' could be declared final | 369 |
| Local variable 'columns' could be declared final | 375 |
| Local variable 'columns' could be declared final | 383 |
| Parameter 'facesEvent' is not assigned and could be declared final | 401 |
| The method 'queueEvent' has a Cyclomatic Complexity of 8. | 401 - 423 |
| Local variable 'parent' could be declared final | 402 |
| Local variable 'source' could be declared final | 413 |
| Local variable 'sourceParent' could be declared final | 414 |
| Parameter 'facesEvent' is not assigned and could be declared final | 426 |
| The method 'broadcast' has a Cyclomatic Complexity of 7. | 426 - 450 |
| Local variable 'expression' could be declared final | 440 |
| Avoid if (x != y) ..; else ..; | 441 - 448 |
| Parameter 'listener' is not assigned and could be declared final | 452 |
| Parameter 'listener' is not assigned and could be declared final | 460 |
| Parameter 'widthList' is not assigned and could be declared final | 468 |
| Parameter 'searchId' is not assigned and could be declared final | 484 |
| Avoid reassigning parameters such as 'searchId' | 488 |
| The method 'stripRowIndex' has a Cyclomatic Complexity of 6. | 488 - 502 |
| Local variable 'c' could be declared final | 491 |
| Parameter 'pageEvent' is not assigned and could be declared final | 504 |
| The method 'performPaging' has a Cyclomatic Complexity of 19. | 504 - 566 |
| The method 'performPaging' has a Cyclomatic Complexity of 19. | 504 - 566 |
| Local variable 'pageIndex' could be declared final | 544 |
| Avoid if (x != y) ..; else ..; | 558 - 562 |
| The method 'getComponents' has a Cyclomatic Complexity of 11. | 568 - 610 |
| The method 'getComponents' has a Cyclomatic Complexity of 11. | 568 - 610 |
| Avoid empty if statements | 576 - 578 |
| Avoid empty if statements | 576 - 578 |
| Avoid if (x != y) ..; else ..; | 594 - 606 |
| Parameter 'facesContext' is not assigned and could be declared final | 612 |
| Parameter 'parent' is not assigned and could be declared final | 612 |
| Parameter 'layoutManager' is not assigned and could be declared final | 623 |
| An empty method in an abstract class should be abstract instead | 631 - 633 |
| Parameter 'needVerticalScrollbar' is not assigned and could be declared final | 641 |
| Parameter 'headerGrid' is not assigned and could be declared final | 659 |
org/apache/myfaces/tobago/internal/component/AbstractUISheetLayout.java
| Violation | Line |
|---|---|
| The class 'AbstractUISheetLayout' has a Cyclomatic Complexity of 6 (Highest = 16). | 54 - 408 |
| The class 'AbstractUISheetLayout' has a Cyclomatic Complexity of 6 (Highest = 16). | 54 - 408 |
| Parameter 'orientation' is not assigned and could be declared final | 72 |
| Parameter 'auto' is not assigned and could be declared final | 72 |
| The method 'fixRelativeInsideAuto' has a Cyclomatic Complexity of 5. | 72 - 85 |
| Parameter 'orientation' is not assigned and could be declared final | 87 |
| The method 'preProcessing' has a Cyclomatic Complexity of 5. | 87 - 116 |
| Avoid unused local variables such as 'intervals'. | 90 |
| Local variable 'intervals' could be declared final | 90 |
| Avoid unused local variables such as 'intervals'. | 90 |
| These nested if statements could be combined | 94 - 96 |
| These nested if statements could be combined | 94 - 96 |
| Parameter 'orientation' is not assigned and could be declared final | 118 |
| The method 'mainProcessing' has a Cyclomatic Complexity of 12. | 118 - 168 |
| The method 'mainProcessing' has a Cyclomatic Complexity of 12. | 118 - 168 |
| Local variable 'box' could be declared final | 149 |
| Deeply nested if..then statements are hard to read | 160 - 162 |
| Parameter 'orientation' is not assigned and could be declared final | 170 |
| The method 'postProcessing' has a Cyclomatic Complexity of 6. | 170 - 195 |
| Local variable 'position' could be declared final | 180 |
| An empty method in an abstract class should be abstract instead | 203 - 205 |
| Parameter 'facesContext' is not assigned and could be declared final | 207 |
| Parameter 'data' is not assigned and could be declared final | 207 |
| The method 'ensureColumnWidthList' has a Cyclomatic Complexity of 16. | 207 - 284 |
| The method ensureColumnWidthList() has an NPath complexity of 1080 | 207 - 284 |
| The method 'ensureColumnWidthList' has a Cyclomatic Complexity of 16. | 207 - 284 |
| Local variable 'renderedColumns' could be declared final | 210 |
| Local variable 'state' could be declared final | 214 |
| Assigning an Object to null is a code smell. Consider refactoring. | 230 |
| Local variable 'tokens' could be declared final | 234 |
| Local variable 'allColumns' could be declared final | 235 |
| Local variable 'newTokens' could be declared final | 236 |
| Local variable 'column' could be declared final | 238 |
| Local variable 'layoutInfo' could be declared final | 267 - 268 |
| Avoid if (x != y) ..; else ..; | 277 - 283 |
| Parameter 'facesContext' is not assigned and could be declared final | 286 |
| Parameter 'sheet' is not assigned and could be declared final | 286 |
| The method 'needVerticalScrollbar' has a Cyclomatic Complexity of 13. | 286 - 331 |
| The method needVerticalScrollbar() has an NPath complexity of 660 | 286 - 331 |
| The method 'needVerticalScrollbar' has a Cyclomatic Complexity of 13. | 286 - 331 |
| Avoid if (x != y) ..; else ..; | 312 - 327 |
| Local variable 'first' could be declared final | 313 |
| Local variable 'rows' could be declared final | 314 - 316 |
| The method 'parseFixedWidth' has a Cyclomatic Complexity of 9. | 333 - 364 |
| Parameter 'columnSelectorWidth' is not assigned and could be declared final | 334 |
| Parameter 'layoutInfo' is not assigned and could be declared final | 334 |
| Parameter 'renderedColumns' is not assigned and could be declared final | 334 |
| Local variable 'tokens' could be declared final | 335 |
| Local variable 'token' could be declared final | 337 |
| Local variable 'column' could be declared final | 342 |
| Parameter 'facesContext' is not assigned and could be declared final | 366 |
| Parameter 'sheet' is not assigned and could be declared final | 366 |
| Parameter 'facesContext' is not assigned and could be declared final | 372 |
| Parameter 'sheet' is not assigned and could be declared final | 372 |
| Parameter 'facesContext' is not assigned and could be declared final | 376 |
| Parameter 'sheet' is not assigned and could be declared final | 376 |
| The method 'layoutHeader' has a Cyclomatic Complexity of 6. | 382 - 407 |
| Avoid instantiating new objects inside loops | 398 |
org/apache/myfaces/tobago/internal/component/AbstractUITabGroup.java
| Violation | Line |
|---|---|
| The class 'AbstractUITabGroup' has a Cyclomatic Complexity of 2 (Highest = 6). | 51 - 324 |
| This class has too many methods, consider refactoring it. | 53 - 324 |
| Parameter 'facesContext' is not assigned and could be declared final | 64 |
| An empty method in an abstract class should be abstract instead | 72 - 75 |
| Parameter 'facesContext' is not assigned and could be declared final | 72 |
| Parameter 'facesContext' is not assigned and could be declared final | 78 |
| An empty method in an abstract class should be abstract instead | 89 - 91 |
| Parameter 'event' is not assigned and could be declared final | 93 |
| Local variable 'tabs' could be declared final | 113 |
| Parameter 'context' is not assigned and could be declared final | 132 |
| The method 'processDecodes' has a Cyclomatic Complexity of 6. | 132 - 155 |
| Avoid if (x != y) ..; else ..; | 133 - 154 |
| Local variable 'renderedTab' could be declared final | 141 |
| Parameter 'context' is not assigned and could be declared final | 158 |
| The method 'processValidators' has a Cyclomatic Complexity of 5. | 158 - 174 |
| Avoid if (x != y) ..; else ..; | 159 - 173 |
| Local variable 'renderedTab' could be declared final | 166 |
| Parameter 'context' is not assigned and could be declared final | 177 |
| The method 'processUpdates' has a Cyclomatic Complexity of 5. | 177 - 194 |
| Avoid if (x != y) ..; else ..; | 178 - 193 |
| Local variable 'renderedTab' could be declared final | 185 |
| Parameter 'facesEvent' is not assigned and could be declared final | 196 |
| The method 'broadcast' has a Cyclomatic Complexity of 6. | 196 - 227 |
| Local variable 'defaultActionListener' could be declared final | 214 |
| Local variable 'index' could be declared final | 219 |
| Local variable 'expression' could be declared final | 220 |
| Avoid if (x != y) ..; else ..; | 221 - 225 |
| Parameter 'listener' is not assigned and could be declared final | 229 |
| Local variable 'switchType' could be declared final | 237 |
| Parameter 'listener' is not assigned and could be declared final | 241 |
| Parameter 'index' is not assigned and could be declared final | 259 |
| Parameter 'listener' is not assigned and could be declared final | 283 |
| Parameter 'listener' is not assigned and could be declared final | 297 |
| Parameter 'facesContext' is not assigned and could be declared final | 305 |
| Parameter 'parent' is not assigned and could be declared final | 305 |
| Parameter 'layoutManager' is not assigned and could be declared final | 316 |
org/apache/myfaces/tobago/internal/component/AbstractUITabGroupLayout.java
| Violation | Line |
|---|---|
| The class 'AbstractUITabGroupLayout' has a Cyclomatic Complexity of 5 (Highest = 10). | 33 - 137 |
| The class 'AbstractUITabGroupLayout' has a Cyclomatic Complexity of 5 (Highest = 10). | 33 - 137 |
| Parameter 'orientation' is not assigned and could be declared final | 48 |
| Parameter 'auto' is not assigned and could be declared final | 48 |
| The method 'fixRelativeInsideAuto' has a Cyclomatic Complexity of 5. | 48 - 61 |
| Parameter 'orientation' is not assigned and could be declared final | 63 |
| The method 'preProcessing' has a Cyclomatic Complexity of 9. | 63 - 88 |
| Local variable 'intervals' could be declared final | 66 |
| Avoid instantiating new objects inside loops | 75 |
| Local variable 'size' could be declared final | 81 |
| Parameter 'orientation' is not assigned and could be declared final | 90 |
| The method 'mainProcessing' has a Cyclomatic Complexity of 10. | 90 - 113 |
| The method 'mainProcessing' has a Cyclomatic Complexity of 10. | 90 - 113 |
| Local variable 'container' could be declared final | 96 |
| Local variable 'available' could be declared final | 97 |
| Avoid if (x != y) ..; else ..; | 98 - 104 |
| Parameter 'orientation' is not assigned and could be declared final | 115 |
| An empty method in an abstract class should be abstract instead | 134 - 136 |
org/apache/myfaces/tobago/internal/component/AbstractUITextarea.java
| Violation | Line |
|---|---|
| An empty method in an abstract class should be abstract instead | 25 - 27 |
org/apache/myfaces/tobago/internal/component/AbstractUITime.java
| Violation | Line |
|---|---|
| Local variable 'converter' could be declared final | 32 |
| Local variable 'application' could be declared final | 35 - 36 |
| Local variable 'dateTimeConverter' could be declared final | 37 - 38 |
| An empty method in an abstract class should be abstract instead | 47 - 49 |
org/apache/myfaces/tobago/internal/component/AbstractUIToolBar.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 24 - 38 |
org/apache/myfaces/tobago/internal/component/AbstractUIToolBarCommand.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 24 - 27 |
org/apache/myfaces/tobago/internal/component/AbstractUITree.java
| Violation | Line |
|---|---|
| The class 'AbstractUITree' has a Cyclomatic Complexity of 3 (Highest = 6). | 38 - 253 |
| Avoid unused private fields such as 'LOG'. | 42 |
| Avoid unused private fields such as 'LOG'. | 42 |
| Parameter 'facesContext' is not assigned and could be declared final | 67 |
| The method 'processValidators' has a Cyclomatic Complexity of 5. | 67 - 79 |
| Parameter 'facesContext' is not assigned and could be declared final | 82 |
| The method 'processUpdates' has a Cyclomatic Complexity of 5. | 82 - 94 |
| An empty method in an abstract class should be abstract instead | 123 - 125 |
| Parameter 'facesContext' is not assigned and could be declared final | 128 |
| The method 'processDecodes' has a Cyclomatic Complexity of 6. | 128 - 147 |
| Parameter 'state' is not assigned and could be declared final | 204 |
| Parameter 'context' is not assigned and could be declared final | 240 |
| Parameter 'componentState' is not assigned and could be declared final | 240 |
| Local variable 'values' could be declared final | 241 |
| Parameter 'context' is not assigned and could be declared final | 247 |
org/apache/myfaces/tobago/internal/component/AbstractUITreeData.java
| Violation | Line |
|---|---|
| The class 'AbstractUITreeData' has a Cyclomatic Complexity of 2 (Highest = 5). | 36 - 111 |
| Parameter 'facesContext' is not assigned and could be declared final | 46 |
| Parameter 'parent' is not assigned and could be declared final | 46 |
| The method 'onComponentCreated' has a Cyclomatic Complexity of 5. | 46 - 65 |
| Local variable 've' could be declared final | 49 |
| Avoid if (x != y) ..; else ..; | 50 - 54 |
| Local variable 've' could be declared final | 58 |
| Avoid if (x != y) ..; else ..; | 59 - 63 |
| Parameter 'var' is not assigned and could be declared final | 71 |
| Parameter 'context' is not assigned and could be declared final | 75 |
| Parameter 'componentState' is not assigned and could be declared final | 75 |
| Local variable 'values' could be declared final | 76 |
| Parameter 'context' is not assigned and could be declared final | 81 |
| Parameter 'model' is not assigned and could be declared final | 92 |
| Parameter 'facesContext' is not assigned and could be declared final | 92 |
| Parameter 'model' is not assigned and could be declared final | 100 |
| Parameter 'facesContext' is not assigned and could be declared final | 100 |
| Parameter 'model' is not assigned and could be declared final | 108 |
| Parameter 'facesContext' is not assigned and could be declared final | 108 |
org/apache/myfaces/tobago/internal/component/AbstractUITreeIndent.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 26 - 27 |
org/apache/myfaces/tobago/internal/component/AbstractUITreeListbox.java
| Violation | Line |
|---|---|
| An empty method in an abstract class should be abstract instead | 25 - 27 |
org/apache/myfaces/tobago/internal/component/AbstractUITreeNode.java
| Violation | Line |
|---|---|
| This class has too many methods, consider refactoring it. | 41 - 311 |
| Parameter 'facesContext' is not assigned and could be declared final | 44 |
| Parameter 'facesContext' is not assigned and could be declared final | 75 |
| Local variable 'dataId' could be declared final | 78 |
| Consider simply returning the value vs storing it in local variable 'rowData' | 92 |
| Parameter 'model' is not assigned and could be declared final | 99 |
| Parameter 'facesContext' is not assigned and could be declared final | 99 |
| The String literal "Doesn't work anymore." appears 10 times in this file; the first occurrence is on line 100 | 100 |
| Parameter 'model' is not assigned and could be declared final | 107 |
| Parameter 'facesContext' is not assigned and could be declared final | 107 |
| Parameter 'model' is not assigned and could be declared final | 115 |
| Parameter 'facesContext' is not assigned and could be declared final | 115 |
| Parameter 'depth' is not assigned and could be declared final | 132 |
| Parameter 'folder' is not assigned and could be declared final | 140 |
| Parameter 'path' is not assigned and could be declared final | 148 |
| Parameter 'junctions' is not assigned and could be declared final | 156 |
| Parameter 'hasNextSibling' is not assigned and could be declared final | 173 |
| The String literal "treeExpansionListener!" appears 5 times in this file; the first occurrence is on line 182 | 182 |
| Parameter 'treeExpansionListener' is not assigned and could be declared final | 190 |
| Parameter 'listener' is not assigned and could be declared final | 198 |
| Return an empty array rather than null. | 206 - 209 |
| Parameter 'listener' is not assigned and could be declared final | 215 |
| The String literal "treeMarkedListener!" appears 5 times in this file; the first occurrence is on line 224 | 224 |
| Parameter 'treeMarkedListener' is not assigned and could be declared final | 232 |
| Parameter 'listener' is not assigned and could be declared final | 240 |
| Return an empty array rather than null. | 248 - 251 |
| Parameter 'listener' is not assigned and could be declared final | 257 |
| Parameter 'b' is not assigned and could be declared final | 274 |
| Parameter 'expanded' is not assigned and could be declared final | 291 |
| Parameter 'selected' is not assigned and could be declared final | 308 |
org/apache/myfaces/tobago/internal/component/AbstractUITreeSelect.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 32 - 34 |
| Parameter 'context' is not assigned and could be declared final | 32 |
| Overriding method merely calls super | 32 - 34 |
org/apache/myfaces/tobago/internal/component/AbstractUIWizard.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 47 |
| Parameter 'facesContext' is not assigned and could be declared final | 55 |
| Parameter 'event' is not assigned and could be declared final | 63 |
| Parameter 'event' is not assigned and could be declared final | 68 |
| Local variable 'facesContext' could be declared final | 70 |
| Local variable 'originalEvent' could be declared final | 74 |
| Parameter 'facesContext' is not assigned and could be declared final | 85 |
| Parameter 'facesContext' is not assigned and could be declared final | 93 |
| Parameter 'context' is not assigned and could be declared final | 100 |
| Parameter 'parent' is not assigned and could be declared final | 100 |
| Local variable 'wizard' could be declared final | 101 |
| Parameter 'facesContext' is not assigned and could be declared final | 112 |
| Parameter 'facesContext' is not assigned and could be declared final | 121 |
| Parameter 'state' is not assigned and could be declared final | 121 |
| Local variable 'values' could be declared final | 122 |
| Local variable 'vb' could be declared final | 132 |
| Avoid if (x != y) ..; else ..; | 133 - 137 |
| Parameter 'controller' is not assigned and could be declared final | 140 |
| Parameter 'var' is not assigned and could be declared final | 148 |
| Local variable 'vb' could be declared final | 156 |
| Parameter 'outcome' is not assigned and could be declared final | 164 |
| Local variable 'vb' could be declared final | 172 |
| Parameter 'title' is not assigned and could be declared final | 180 |
| Local variable 'vb' could be declared final | 188 |
| Local variable 'bool' could be declared final | 190 |
| Parameter 'allowJumpForward' is not assigned and could be declared final | 198 |
org/apache/myfaces/tobago/internal/config/ContentSecurityPolicy.java
| Violation | Line |
|---|---|
| Parameter 'mode' is not assigned and could be declared final | 30 |
| Parameter 'other' is not assigned and could be declared final | 35 |
| Parameter 'value' is not assigned and could be declared final | 55 |
| Parameter 'string' is not assigned and could be declared final | 63 |
org/apache/myfaces/tobago/internal/config/RendererConfig.java
| Violation | Line |
|---|---|
| Parameter 'name' is not assigned and could be declared final | 38 |
| Parameter 'o' is not assigned and could be declared final | 42 |
| Parameter 'markup' is not assigned and could be declared final | 55 |
| Parameter 'markup' is not assigned and could be declared final | 63 |
| Parameter 'rendererConfig' is not assigned and could be declared final | 67 |
org/apache/myfaces/tobago/internal/config/RenderersConfigImpl.java
| Violation | Line |
|---|---|
| Private field 'rendererMap' could be made final; it is only initialized in the declaration or constructor. | 38 |
| Parameter 'merged' is not assigned and could be declared final | 46 |
| Parameter 'rendererConfig' is not assigned and could be declared final | 56 |
| Parameter 'markup' is not assigned and could be declared final | 65 |
| Parameter 'rendererName' is not assigned and could be declared final | 65 |
| Local variable 'rendererConfig' could be declared final | 69 |
| Avoid if (x != y) ..; else ..; | 70 - 75 |
| Parameter 'renderersConfig' is not assigned and could be declared final | 78 |
| Parameter 'override' is not assigned and could be declared final | 78 |
| Local variable 'renderers' could be declared final | 79 |
org/apache/myfaces/tobago/internal/config/TobagoConfigBuilder.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 38 - 122 |
| The class 'TobagoConfigBuilder' has a Cyclomatic Complexity of 4 (Highest = 8). | 38 - 122 |
| Private field 'list' could be made final; it is only initialized in the declaration or constructor. | 45 |
| Parameter 'servletContext' is not assigned and could be declared final | 47 |
| Parameter 'servletContext' is not assigned and could be declared final | 68 |
| Avoid unused local variables such as 'builder'. | 70 |
| Avoid unused local variables such as 'builder'. | 70 |
| Local variable 'error' could be declared final | 73 |
| Parameter 'servletContext' is not assigned and could be declared final | 80 |
| The method 'configFromClasspath' has a Cyclomatic Complexity of 8. | 89 - 121 |
| Avoid instantiating new objects inside loops | 101 |
org/apache/myfaces/tobago/internal/config/TobagoConfigEntityResolver.java
| Violation | Line |
|---|---|
| The class 'TobagoConfigEntityResolver' has a Cyclomatic Complexity of 8 (Highest = 7). | 31 - 69 |
| The method 'resolveEntity' has a Cyclomatic Complexity of 7. | 45 - 68 |
| Position literals first in String comparisons | 50 |
| Position literals first in String comparisons | 52 |
| Position literals first in String comparisons | 54 |
| Position literals first in String comparisons | 56 |
| Avoid if (x != y) ..; else ..; | 61 - 67 |
org/apache/myfaces/tobago/internal/config/TobagoConfigFragment.java
| Violation | Line |
|---|---|
| Private field 'before' could be made final; it is only initialized in the declaration or constructor. | 36 |
| Private field 'after' could be made final; it is only initialized in the declaration or constructor. | 37 |
| Private field 'supportedThemeNames' could be made final; it is only initialized in the declaration or constructor. | 39 |
| Private field 'resourceDirs' could be made final; it is only initialized in the declaration or constructor. | 41 |
| Private field 'themeDefinitions' could be made final; it is only initialized in the declaration or constructor. | 47 |
| Parameter 'name' is not assigned and could be declared final | 58 |
| Parameter 'defaultThemeName' is not assigned and could be declared final | 70 |
| Parameter 'resourceDir' is not assigned and could be declared final | 74 |
| Parameter 'value' is not assigned and could be declared final | 89 |
| Parameter 'renderersConfig' is not assigned and could be declared final | 97 |
| Parameter 'name' is not assigned and could be declared final | 105 |
| Parameter 'name' is not assigned and could be declared final | 113 |
| Parameter 'name' is not assigned and could be declared final | 121 |
| Parameter 'theme' is not assigned and could be declared final | 125 |
| Parameter 'createSessionSecret' is not assigned and could be declared final | 137 |
| Parameter 'checkSessionSecret' is not assigned and could be declared final | 145 |
| Parameter 'preventFrameAttacks' is not assigned and could be declared final | 153 |
| Parameter 'contentSecurityPolicy' is not assigned and could be declared final | 161 |
| Parameter 'value' is not assigned and could be declared final | 167 |
| Parameter 'value' is not assigned and could be declared final | 173 |
| Parameter 'url' is not assigned and could be declared final | 181 |
| Avoid if (x != y) ..; else ..; | 187 |
org/apache/myfaces/tobago/internal/config/TobagoConfigImpl.java
| Violation | Line |
|---|---|
| The class 'TobagoConfigImpl' has a Cyclomatic Complexity of 2 (Highest = 10). | 44 - 326 |
| This class has too many methods, consider refactoring it. | 44 - 326 |
| The class 'TobagoConfigImpl' has a Cyclomatic Complexity of 2 (Highest = 10). | 44 - 326 |
| Private field 'supportedThemes' could be made final; it is only initialized in the declaration or constructor. | 50 |
| Private field 'supportedThemeNames' could be made final; it is only initialized in the declaration or constructor. | 51 |
| Private field 'resourceDirs' could be made final; it is only initialized in the declaration or constructor. | 54 |
| Private field 'contentSecurityPolicy' could be made final; it is only initialized in the declaration or constructor. | 61 |
| Parameter 'name' is not assigned and could be declared final | 75 |
| The method 'resolveThemes' has a Cyclomatic Complexity of 10. | 79 - 119 |
| The method 'resolveThemes' has a Cyclomatic Complexity of 10. | 79 - 119 |
| Avoid if (x != y) ..; else ..; | 80 - 107 |
| Local variable 'theme' could be declared final | 90 |
| Local variable 'error' could be declared final | 97 - 99 |
| Local variable 'theme' could be declared final | 110 |
| Parameter 'name' is not assigned and could be declared final | 121 |
| Parameter 'theme' is not assigned and could be declared final | 121 |
| Local variable 'error' could be declared final | 123 - 125 |
| Parameter 'name' is not assigned and could be declared final | 131 |
| The method 'getTheme' has a Cyclomatic Complexity of 5. | 131 - 146 |
| Parameter 'defaultThemeName' is not assigned and could be declared final | 148 |
| Parameter 'resourceDir' is not assigned and could be declared final | 156 |
| Parameter 'availableThemes' is not assigned and could be declared final | 180 |
| Parameter 'renderersConfig' is not assigned and could be declared final | 191 |
| Parameter 'servletContext' is not assigned and could be declared final | 199 |
| The method 'initProjectState' has a Cyclomatic Complexity of 10. | 199 - 237 |
| The method 'initProjectState' has a Cyclomatic Complexity of 10. | 199 - 237 |
| Local variable 'ctx' could be declared final | 202 |
| Local variable 'obj' could be declared final | 203 |
| Avoid empty catch blocks | 212 - 214 |
| Avoid empty catch blocks | 212 - 214 |
| Use block level rather than method level synchronization | 239 - 256 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 245 |
| Parameter 'createSessionSecret' is not assigned and could be declared final | 262 |
| Parameter 'checkSessionSecret' is not assigned and could be declared final | 270 |
| Parameter 'preventFrameAttacks' is not assigned and could be declared final | 279 |
| Local variable 'all' could be declared final | 321 |
org/apache/myfaces/tobago/internal/config/TobagoConfigParser.java
| Violation | Line |
|---|---|
| The class 'TobagoConfigParser' has a Cyclomatic Complexity of 4 (Highest = 23). | 48 - 387 |
| This class has too many methods, consider refactoring it. | 48 - 387 |
| The class 'TobagoConfigParser' has a Cyclomatic Complexity of 4 (Highest = 23). | 48 - 387 |
| Document empty constructor | 88 - 89 |
| Avoid unnecessary constructors - the compiler will generate these for you | 88 - 89 |
| Parameter 'url' is not assigned and could be declared final | 91 |
| Parameter 'start' is not assigned and could be declared final | 122 |
| Parameter 'length' is not assigned and could be declared final | 122 |
| Parameter 'ch' is not assigned and could be declared final | 122 |
| Assigning an Object to null is a code smell. Consider refactoring. | 136 |
| Parameter 'localName' is not assigned and could be declared final | 140 |
| Parameter 'qName' is not assigned and could be declared final | 140 |
| Parameter 'attributes' is not assigned and could be declared final | 140 |
| Parameter 'uri' is not assigned and could be declared final | 140 |
| The method 'startElement' has a Cyclomatic Complexity of 13. | 140 - 224 |
| The method 'startElement' has a Cyclomatic Complexity of 13. | 140 - 224 |
| Avoid if (x != y) ..; else ..; | 160 - 164 |
| Parameter 'start' is not assigned and could be declared final | 227 |
| Parameter 'length' is not assigned and could be declared final | 227 |
| Parameter 'ch' is not assigned and could be declared final | 227 |
| Parameter 'localName' is not assigned and could be declared final | 232 |
| Parameter 'qName' is not assigned and could be declared final | 232 |
| Parameter 'uri' is not assigned and could be declared final | 232 |
| The method 'endElement' has a Cyclomatic Complexity of 23. | 232 - 349 |
| Avoid really long methods. | 232 - 349 |
| The method 'endElement' has a Cyclomatic Complexity of 23. | 232 - 349 |
| Avoid if (x != y) ..; else ..; | 258 - 262 |
| Assigning an Object to null is a code smell. Consider refactoring. | 319 |
| Assigning an Object to null is a code smell. Consider refactoring. | 327 |
| Parameter 'e' is not assigned and could be declared final | 352 |
| Parameter 'e' is not assigned and could be declared final | 357 |
| Parameter 'e' is not assigned and could be declared final | 362 |
org/apache/myfaces/tobago/internal/config/TobagoConfigSorter.java
| Violation | Line |
|---|---|
| The class 'TobagoConfigSorter' has a Cyclomatic Complexity of 4 (Highest = 9). | 30 - 275 |
| This class has too many methods, consider refactoring it. | 30 - 275 |
| Private field 'list' could be made final; it is only initialized in the declaration or constructor. | 34 |
| Parameter 'list' is not assigned and could be declared final | 37 |
| Prefer StringBuffer over += for concatenating strings | 60 |
| The method 'merge' has a Cyclomatic Complexity of 9. | 67 - 123 |
| Local variable 'result' could be declared final | 71 |
| The method 'makeTransitive' has a Cyclomatic Complexity of 6. | 125 - 140 |
| Avoid instantiation through private constructors from outside of the constructor's class. | 134 |
| Avoid instantiating new objects inside loops | 134 |
| Local variable 'buffer' could be declared final | 145 |
| Avoid instantiating new objects inside loops | 145 |
| The String literal "' < '" appears 4 times in this file; the first occurrence is on line 148 | 148 |
| StringBuffer.append is called 2 consecutive times with literal Strings. Use a single append with a single String. | 150 |
| Avoid appending characters as strings in StringBuffer.append. | 153 |
| The method 'ensureAntiSymmetric' has a Cyclomatic Complexity of 6. | 165 - 192 |
| Local variable 'buffer' could be declared final | 169 |
| Avoid instantiating new objects inside loops | 169 |
| StringBuffer.append is called 2 consecutive times with literal Strings. Use a single append with a single String. | 178 |
| Avoid appending characters as strings in StringBuffer.append. | 181 |
| Parameter 'b' is not assigned and could be declared final | 194 |
| Parameter 'a' is not assigned and could be declared final | 194 |
| The method 'createRelevantPairs' has a Cyclomatic Complexity of 6. | 204 - 223 |
| Local variable 'before' could be declared final | 211 |
| Avoid instantiation through private constructors from outside of the constructor's class. | 213 |
| Avoid instantiating new objects inside loops | 213 |
| Local variable 'after' could be declared final | 217 |
| Avoid instantiation through private constructors from outside of the constructor's class. | 219 |
| Avoid instantiating new objects inside loops | 219 |
| Parameter 'lower' is not assigned and could be declared final | 229 |
| Parameter 'higher' is not assigned and could be declared final | 229 |
| Parameter 'name' is not assigned and could be declared final | 238 |
| Parameter 'lower' is not assigned and could be declared final | 256 |
| Parameter 'higher' is not assigned and could be declared final | 256 |
org/apache/myfaces/tobago/internal/config/TobagoConfigVersion.java
| Violation | Line |
|---|---|
| Parameter 'url' is not assigned and could be declared final | 40 |
| Local variable 'factory' could be declared final | 46 |
| Local variable 'saxParser' could be declared final | 47 |
| Parameter 'localName' is not assigned and could be declared final | 55 |
| Parameter 'qName' is not assigned and could be declared final | 55 |
| Parameter 'attributes' is not assigned and could be declared final | 55 |
| Parameter 'uri' is not assigned and could be declared final | 55 |
org/apache/myfaces/tobago/internal/context/ClientPropertiesKey.java
| Violation | Line |
|---|---|
| The class 'ClientPropertiesKey' has a Cyclomatic Complexity of 2 (Highest = 10). | 32 - 137 |
| The class 'ClientPropertiesKey' has a Cyclomatic Complexity of 2 (Highest = 10). | 32 - 137 |
| Parameter 'facesContext' is not assigned and could be declared final | 43 |
| Local variable 'requestMap' could be declared final | 45 |
| Local variable 'clientProperties' could be declared final | 48 |
| Parameter 'facesContext' is not assigned and could be declared final | 56 |
| Local variable 'requestMap' could be declared final | 57 |
| Parameter 'clientProperties' is not assigned and could be declared final | 61 |
| Parameter 'o' is not assigned and could be declared final | 70 |
| The method 'equals' has a Cyclomatic Complexity of 10. | 70 - 100 |
| The method 'equals' has a Cyclomatic Complexity of 10. | 70 - 100 |
| Local variable 'that' could be declared final | 78 |
org/apache/myfaces/tobago/internal/context/ImageCacheKey.java
| Violation | Line |
|---|---|
| Parameter 'clientPropertiesKey' is not assigned and could be declared final | 27 |
| Parameter 'name' is not assigned and could be declared final | 27 |
| Parameter 'o' is not assigned and could be declared final | 34 |
| Local variable 'that' could be declared final | 42 |
org/apache/myfaces/tobago/internal/context/JspCacheKey.java
| Violation | Line |
|---|---|
| Parameter 'cacheKey' is not assigned and could be declared final | 27 |
| Parameter 'name' is not assigned and could be declared final | 27 |
| Parameter 'o' is not assigned and could be declared final | 34 |
| Local variable 'that' could be declared final | 42 |
org/apache/myfaces/tobago/internal/context/MeasureValue.java
| Violation | Line |
|---|---|
| The class 'MeasureValue' has a Cyclomatic Complexity of 2 (Highest = 6). | 27 - 68 |
| Private field 'value' could be made final; it is only initialized in the declaration or constructor. | 31 |
| Parameter 'value' is not assigned and could be declared final | 33 |
| Parameter 'o' is not assigned and could be declared final | 42 |
| The method 'equals' has a Cyclomatic Complexity of 6. | 42 - 57 |
| Local variable 'that' could be declared final | 50 |
| Avoid if (x != y) ..; else ..; | 52 |
| Avoid if (x != y) ..; else ..; | 61 |
| Do not add empty strings | 66 |
org/apache/myfaces/tobago/internal/context/MiscCacheKey.java
| Violation | Line |
|---|---|
| Parameter 'cacheKey' is not assigned and could be declared final | 27 |
| Parameter 'name' is not assigned and could be declared final | 27 |
| Parameter 'o' is not assigned and could be declared final | 34 |
| Local variable 'that' could be declared final | 42 |
org/apache/myfaces/tobago/internal/context/PropertyCacheKey.java
| Violation | Line |
|---|---|
| Parameter 'cacheKey' is not assigned and could be declared final | 28 |
| Parameter 'name' is not assigned and could be declared final | 28 |
| Parameter 'key' is not assigned and could be declared final | 28 |
| Parameter 'o' is not assigned and could be declared final | 36 |
| Local variable 'that' could be declared final | 44 |
org/apache/myfaces/tobago/internal/context/RendererCacheKey.java
| Violation | Line |
|---|---|
| Parameter 'cacheKey' is not assigned and could be declared final | 27 |
| Parameter 'name' is not assigned and could be declared final | 27 |
| Parameter 'o' is not assigned and could be declared final | 34 |
| Local variable 'that' could be declared final | 42 |
org/apache/myfaces/tobago/internal/context/ResourceLocator.java
| Violation | Line |
|---|---|
| The class 'ResourceLocator' has a Cyclomatic Complexity of 6 (Highest = 14). | 61 - 451 |
| This class has too many methods, consider refactoring it. | 61 - 451 |
| The class 'ResourceLocator' has a Cyclomatic Complexity of 6 (Highest = 14). | 61 - 451 |
| Private field 'servletContext' could be made final; it is only initialized in the declaration or constructor. | 69 |
| Private field 'resourceManager' could be made final; it is only initialized in the declaration or constructor. | 70 |
| Private field 'themeBuilder' could be made final; it is only initialized in the declaration or constructor. | 71 |
| Parameter 'servletContext' is not assigned and could be declared final | 74 |
| Parameter 'resourceManager' is not assigned and could be declared final | 74 |
| Parameter 'themeBuilder' is not assigned and could be declared final | 74 |
| The method 'locateResourcesInWar' has a Cyclomatic Complexity of 14. | 88 - 139 |
| The method locateResourcesInWar() has an NPath complexity of 240 | 88 - 139 |
| The method 'locateResourcesInWar' has a Cyclomatic Complexity of 14. | 88 - 139 |
| Avoid reassigning parameters such as 'path' | 89 |
| Parameter 'resources' is not assigned and could be declared final | 89 |
| Parameter 'servletContext' is not assigned and could be declared final | 89 |
| Local variable 'resourcePaths' could be declared final | 99 |
| Local variable 'inputStream' could be declared final | 118 |
| Local variable 'inputStream' could be declared final | 125 |
| Parameter 'resources' is not assigned and could be declared final | 141 |
| The method 'locateResourcesFromClasspath' has a Cyclomatic Complexity of 9. | 141 - 173 |
| Local variable 'tobagoConfigUrl' could be declared final | 152 |
| Local variable 'tobagoConfig' could be declared final | 153 |
| Avoid instantiating new objects inside loops | 153 |
| An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 167 |
| Parameter 'resources' is not assigned and could be declared final | 182 |
| The method 'locateResourcesServlet30Alike' has a Cyclomatic Complexity of 8. | 182 - 221 |
| Local variable 'classLoader' could be declared final | 188 |
| Local variable 'urls' could be declared final | 189 |
| Local variable 'resourcesUrl' could be declared final | 192 |
| Local variable 'protocol' could be declared final | 202 |
| Local variable 'msg' could be declared final | 217 |
| Avoid if (x != y) ..; else ..; | 240 - 244 |
| Assigning an Object to null is a code smell. Consider refactoring. | 264 |
| Parameter 'resources' is not assigned and could be declared final | 270 |
| The method 'addResourcesFromZip' has a Cyclomatic Complexity of 12. | 279 - 334 |
| The method addResourcesFromZip() has an NPath complexity of 288 | 279 - 334 |
| The method 'addResourcesFromZip' has a Cyclomatic Complexity of 12. | 279 - 334 |
| Avoid reassigning parameters such as 'fileName' | 280 |
| Avoid reassigning parameters such as 'fileName' | 280 |
| Avoid reassigning parameters such as 'fileName' | 280 |
| String.indexOf(char) is faster than String.indexOf(String). | 284 |
| Do not add empty strings | 289 |
| Position literals first in String comparisons | 293 |
| Position literals first in String comparisons | 302 |
| Local variable 'name' could be declared final | 325 |
| Parameter 'skipPrefix' is not assigned and could be declared final | 336 |
| Parameter 'resources' is not assigned and could be declared final | 336 |
| Parameter 'name' is not assigned and could be declared final | 336 |
| The method 'addResource' has a Cyclomatic Complexity of 6. | 336 - 364 |
| Avoid empty if statements | 339 - 341 |
| Avoid empty if statements | 339 - 341 |
| Local variable 'inputStream' could be declared final | 345 |
| Local variable 'inputStream' could be declared final | 355 |
| Avoid reassigning parameters such as 'resourcePath' | 366 |
| Avoid reassigning parameters such as 'resourcePath' | 366 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 367 |
| The method 'addProperties' has a Cyclomatic Complexity of 8. | 376 - 420 |
| Parameter 'skipPrefix' is not assigned and could be declared final | 377 |
| Parameter 'resources' is not assigned and could be declared final | 377 |
| Parameter 'stream' is not assigned and could be declared final | 377 |
| Parameter 'xml' is not assigned and could be declared final | 377 |
| Parameter 'childPath' is not assigned and could be declared final | 377 |
| Avoid if (x != y) ..; else ..; | 441 - 447 |
org/apache/myfaces/tobago/internal/context/ResourceManagerFactory.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 29 - 71 |
| Parameter 'facesContext' is not assigned and could be declared final | 39 |
| Parameter 'servletContext' is not assigned and could be declared final | 45 |
| Parameter 'servletContext' is not assigned and could be declared final | 51 |
| Parameter 'tobagoConfig' is not assigned and could be declared final | 51 |
| Local variable 'resourceManager' could be declared final | 54 |
| Local variable 'themeBuilder' could be declared final | 56 |
| Local variable 'resourceLocator' could be declared final | 57 |
| Parameter 'servletContext' is not assigned and could be declared final | 66 |
org/apache/myfaces/tobago/internal/context/ResourceManagerImpl.java
| Violation | Line |
|---|---|
| The class 'ResourceManagerImpl' has a Cyclomatic Complexity of 5 (Highest = 30). | 43 - 595 |
| The class 'ResourceManagerImpl' has a Cyclomatic Complexity of 5 (Highest = 30). | 43 - 595 |
| Private field 'production' could be made final; it is only initialized in the declaration or constructor. | 50 |
| Private field 'tobagoConfig' could be made final; it is only initialized in the declaration or constructor. | 68 |
| Parameter 'tobagoConfig' is not assigned and could be declared final | 70 |
| Parameter 'resourceKey' is not assigned and could be declared final | 75 |
| Parameter 'resourceKey' is not assigned and could be declared final | 82 |
| Parameter 'value' is not assigned and could be declared final | 82 |
| Parameter 'name' is not assigned and could be declared final | 90 |
| Parameter 'viewRoot' is not assigned and could be declared final | 90 |
| Local variable 'clientKey' could be declared final | 94 |
| Local variable 'cacheKey' could be declared final | 95 |
| The String literal "name = '" appears 4 times in this file; the first occurrence is on line 106 | 106 |
| The String literal "' clientProperties = '" appears 4 times in this file; the first occurrence is on line 106 | 106 |
| Parameter 'bundle' is not assigned and could be declared final | 113 |
| Parameter 'propertyKey' is not assigned and could be declared final | 113 |
| Parameter 'viewRoot' is not assigned and could be declared final | 113 |
| Parameter 'facesContext' is not assigned and could be declared final | 117 |
| Parameter 'bundle' is not assigned and could be declared final | 117 |
| Parameter 'propertyKey' is not assigned and could be declared final | 117 |
| The method 'getProperty' has a Cyclomatic Complexity of 5. | 117 - 136 |
| Local variable 'clientKey' could be declared final | 120 |
| Local variable 'cacheKey' could be declared final | 121 |
| Local variable 'properties' could be declared final | 125 |
| Avoid if (x != y) ..; else ..; | 126 - 130 |
| Parameter 'rendererType' is not assigned and could be declared final | 139 |
| Parameter 'viewRoot' is not assigned and could be declared final | 139 |
| Parameter 'rendererType' is not assigned and could be declared final | 143 |
| Parameter 'facesContext' is not assigned and could be declared final | 143 |
| The method 'getRenderer' has a Cyclomatic Complexity of 7. | 143 - 172 |
| Local variable 'clientKey' could be declared final | 147 |
| Local variable 'cacheKey' could be declared final | 148 |
| Local variable 'classes' could be declared final | 157 |
| Avoid if (x != y) ..; else ..; | 158 - 164 |
| Local variable 'clazz' could be declared final | 159 |
| Parameter 'name' is not assigned and could be declared final | 175 |
| Parameter 'viewRoot' is not assigned and could be declared final | 175 |
| Parameter 'facesContext' is not assigned and could be declared final | 179 |
| Parameter 'name' is not assigned and could be declared final | 179 |
| Parameter 'name' is not assigned and could be declared final | 184 |
| Parameter 'viewRoot' is not assigned and could be declared final | 184 |
| Parameter 'facesContext' is not assigned and could be declared final | 188 |
| Parameter 'name' is not assigned and could be declared final | 188 |
| Parameter 'bundle' is not assigned and could be declared final | 193 |
| Parameter 'propertyKey' is not assigned and could be declared final | 193 |
| Parameter 'viewRoot' is not assigned and could be declared final | 193 |
| The method 'getThemeProperty' has a Cyclomatic Complexity of 5. | 193 - 212 |
| Local variable 'clientKey' could be declared final | 196 |
| Local variable 'cacheKey' could be declared final | 197 |
| Local variable 'properties' could be declared final | 201 |
| Avoid if (x != y) ..; else ..; | 202 - 206 |
| Parameter 'configurable' is not assigned and could be declared final | 214 |
| Parameter 'facesContext' is not assigned and could be declared final | 214 |
| Parameter 'name' is not assigned and could be declared final | 214 |
| Parameter 'rendererType' is not assigned and could be declared final | 218 |
| Parameter 'markup' is not assigned and could be declared final | 218 |
| Parameter 'facesContext' is not assigned and could be declared final | 218 |
| Parameter 'name' is not assigned and could be declared final | 218 |
| The method 'getThemeMeasure' has a Cyclomatic Complexity of 7. | 218 - 253 |
| Local variable 'clientKey' could be declared final | 220 |
| Local variable 'cacheKey' could be declared final | 221 |
| Local variable 'properties' could be declared final | 226 - 227 |
| Local variable 'mProperties' could be declared final | 236 - 237 |
| Avoid if (x != y) ..; else ..; | 245 - 249 |
| Parameter 'name' is not assigned and could be declared final | 256 |
| Parameter 'viewRoot' is not assigned and could be declared final | 256 |
| Parameter 'facesContext' is not assigned and could be declared final | 260 |
| Parameter 'name' is not assigned and could be declared final | 260 |
| Parameter 'name' is not assigned and could be declared final | 265 |
| Parameter 'ignoreMissing' is not assigned and could be declared final | 265 |
| Parameter 'viewRoot' is not assigned and could be declared final | 265 |
| Parameter 'facesContext' is not assigned and could be declared final | 269 |
| Parameter 'name' is not assigned and could be declared final | 269 |
| Parameter 'ignoreMissing' is not assigned and could be declared final | 269 |
| The method 'getImage' has a Cyclomatic Complexity of 7. | 269 - 300 |
| Local variable 'clientKey' could be declared final | 276 |
| Local variable 'cacheKey' could be declared final | 277 |
| Local variable 'paths' could be declared final | 281 - 282 |
| Avoid if (x != y) ..; else ..; | 283 - 287 |
| These nested if statements could be combined | 291 - 293 |
| These nested if statements could be combined | 291 - 293 |
| The method 'getPaths' has a Cyclomatic Complexity of 30. | 302 - 387 |
| The method getPaths() has an NPath complexity of 2100 | 302 - 387 |
| Avoid really long parameter lists. | 302 - 305 |
| The method 'getPaths' has a Cyclomatic Complexity of 30. | 302 - 387 |
| Parameter 'prefix' is not assigned and could be declared final | 303 |
| Parameter 'subDir' is not assigned and could be declared final | 303 |
| Parameter 'name' is not assigned and could be declared final | 303 |
| Parameter 'suffix' is not assigned and could be declared final | 303 |
| Parameter 'clientkey' is not assigned and could be declared final | 303 |
| Parameter 'reverseOrder' is not assigned and could be declared final | 304 |
| Parameter 'single' is not assigned and could be declared final | 304 |
| Parameter 'returnKey' is not assigned and could be declared final | 304 |
| Parameter 'returnStrings' is not assigned and could be declared final | 304 |
| Parameter 'key' is not assigned and could be declared final | 304 |
| Parameter 'ignoreMissing' is not assigned and could be declared final | 305 |
| Local variable 'matches' could be declared final | 306 |
| Local variable 'contentType' could be declared final | 307 |
| Local variable 'theme' could be declared final | 308 |
| Local variable 'browser' could be declared final | 309 |
| Local variable 'locales' could be declared final | 310 |
| Local variable 'found' could be declared final | 328 - 329 |
| Local variable 'found' could be declared final | 358 - 360 |
| The method 'checkPath' has a Cyclomatic Complexity of 11. | 389 - 430 |
| Avoid really long parameter lists. | 389 - 391 |
| The method 'checkPath' has a Cyclomatic Complexity of 11. | 389 - 430 |
| Parameter 'reverseOrder' is not assigned and could be declared final | 390 |
| Parameter 'returnKey' is not assigned and could be declared final | 390 |
| Parameter 'prefix' is not assigned and could be declared final | 390 |
| Parameter 'returnStrings' is not assigned and could be declared final | 390 |
| Parameter 'extension' is not assigned and could be declared final | 391 |
| Parameter 'matches' is not assigned and could be declared final | 391 |
| Parameter 'localeSuffix' is not assigned and could be declared final | 391 |
| Parameter 'name' is not assigned and could be declared final | 391 |
| Parameter 'minimizeSuffix' is not assigned and could be declared final | 391 |
| Parameter 'key' is not assigned and could be declared final | 391 |
| Local variable 'result' could be declared final | 394 - 397 |
| Avoid if (x != y) ..; else ..; | 409 - 428 |
| Local variable 'clazz' could be declared final | 412 |
| The String literal "testing path: " appears 6 times in this file; the first occurrence is on line 414 | 414 |
| The method 'checkPath' has a Cyclomatic Complexity of 14. | 432 - 478 |
| Avoid really long parameter lists. | 432 - 435 |
| The method 'checkPath' has a Cyclomatic Complexity of 14. | 432 - 478 |
| Parameter 'reverseOrder' is not assigned and could be declared final | 433 |
| Parameter 'returnKey' is not assigned and could be declared final | 433 |
| Parameter 'prefix' is not assigned and could be declared final | 433 |
| Parameter 'returnStrings' is not assigned and could be declared final | 433 |
| Parameter 'browserType' is not assigned and could be declared final | 434 |
| Parameter 'contentType' is not assigned and could be declared final | 434 |
| Parameter 'currentTheme' is not assigned and could be declared final | 434 |
| Parameter 'matches' is not assigned and could be declared final | 434 |
| Parameter 'resourceDirectory' is not assigned and could be declared final | 434 |
| Parameter 'localeSuffix' is not assigned and could be declared final | 435 |
| Parameter 'subDir' is not assigned and could be declared final | 435 |
| Parameter 'minimizeSuffix' is not assigned and could be declared final | 435 |
| Parameter 'suffix' is not assigned and could be declared final | 435 |
| Parameter 'name' is not assigned and could be declared final | 435 |
| Parameter 'key' is not assigned and could be declared final | 435 |
| Avoid if (x != y) ..; else ..; | 457 - 476 |
| Local variable 'clazz' could be declared final | 460 |
| The method 'makePath' has a Cyclomatic Complexity of 5. | 480 - 514 |
| Avoid really long parameter lists. | 480 - 482 |
| Parameter 'project' is not assigned and could be declared final | 481 |
| Parameter 'theme' is not assigned and could be declared final | 481 |
| Parameter 'subDir' is not assigned and could be declared final | 481 |
| Parameter 'browser' is not assigned and could be declared final | 481 |
| Parameter 'language' is not assigned and could be declared final | 481 |
| Parameter 'extension' is not assigned and could be declared final | 482 |
| Parameter 'localeSuffix' is not assigned and could be declared final | 482 |
| Parameter 'name' is not assigned and could be declared final | 482 |
| Parameter 'minimizeSuffix' is not assigned and could be declared final | 482 |
| Parameter 'key' is not assigned and could be declared final | 482 |
| Parameter 'version' is not assigned and could be declared final | 482 |
| Local variable 'searchtext' could be declared final | 483 |
| Parameter 'extension' is not assigned and could be declared final | 517 |
| Parameter 'localeSuffix' is not assigned and could be declared final | 517 |
| Parameter 'name' is not assigned and could be declared final | 517 |
| Parameter 'minimizeSuffix' is not assigned and could be declared final | 517 |
| Parameter 'key' is not assigned and could be declared final | 517 |
| Local variable 'searchtext' could be declared final | 518 |
| Parameter 'rendererType' is not assigned and could be declared final | 535 |
| Prefer StringBuffer over += for concatenating strings | 545 |
| Parameter 'facesContext' is not assigned and could be declared final | 554 |
| Parameter 'name' is not assigned and could be declared final | 554 |
| Parameter 'type' is not assigned and could be declared final | 554 |
| The method 'getStrings' has a Cyclomatic Complexity of 6. | 554 - 580 |
| Local variable 'key' could be declared final | 562 |
| Local variable 'miscKey' could be declared final | 563 |
| Local variable 'cacheResult' could be declared final | 564 |
| Local variable 'matches' could be declared final | 569 - 570 |
org/apache/myfaces/tobago/internal/context/ResponseWriterDivider.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 37 - 155 |
| Private field 'writers' could be made final; it is only initialized in the declaration or constructor. | 41 |
| Private field 'buffers' could be made final; it is only initialized in the declaration or constructor. | 42 |
| Private field 'original' could be made final; it is only initialized in the declaration or constructor. | 44 |
| Parameter 'facesContext' is not assigned and could be declared final | 50 |
| Parameter 'nameInRequest' is not assigned and could be declared final | 50 |
| Parameter 'facesContext' is not assigned and could be declared final | 62 |
| Parameter 'facesContext' is not assigned and could be declared final | 76 |
| Local variable 'buffer' could be declared final | 83 |
| Local variable 'newWriter' could be declared final | 85 |
| Parameter 'facesContext' is not assigned and could be declared final | 103 |
| Parameter 'facesContext' is not assigned and could be declared final | 127 |
| Local variable 'builder' could be declared final | 139 |
org/apache/myfaces/tobago/internal/context/StringValue.java
| Violation | Line |
|---|---|
| The class 'StringValue' has a Cyclomatic Complexity of 3 (Highest = 6). | 25 - 61 |
| Private field 'value' could be made final; it is only initialized in the declaration or constructor. | 29 |
| Parameter 'value' is not assigned and could be declared final | 31 |
| Parameter 'o' is not assigned and could be declared final | 40 |
| The method 'equals' has a Cyclomatic Complexity of 6. | 40 - 55 |
| Local variable 'that' could be declared final | 48 |
| Avoid if (x != y) ..; else ..; | 50 |
| Avoid if (x != y) ..; else ..; | 59 |
org/apache/myfaces/tobago/internal/context/ThemeBuilder.java
| Violation | Line |
|---|---|
| The class 'ThemeBuilder' has a Cyclomatic Complexity of 4 (Highest = 9). | 34 - 80 |
| Private field 'availableThemes' could be made final; it is only initialized in the declaration or constructor. | 38 |
| Private field 'tobagoConfig' could be made final; it is only initialized in the declaration or constructor. | 39 |
| Parameter 'tobagoConfig' is not assigned and could be declared final | 41 |
| The method 'resolveThemes' has a Cyclomatic Complexity of 9. | 45 - 75 |
| Local variable 'map' could be declared final | 46 |
| Local variable 'fallbackName' could be declared final | 54 |
| Local variable 'fallback' could be declared final | 55 |
| Local variable 'result' could be declared final | 64 |
| Parameter 'theme' is not assigned and could be declared final | 77 |
org/apache/myfaces/tobago/internal/context/ThemeConfigCacheKey.java
| Violation | Line |
|---|---|
| The class 'ThemeConfigCacheKey' has a Cyclomatic Complexity of 3 (Highest = 9). | 24 - 89 |
| Parameter 'rendererType' is not assigned and could be declared final | 33 |
| Parameter 'markup' is not assigned and could be declared final | 33 |
| Parameter 'clientPropertiesKey' is not assigned and could be declared final | 33 |
| Parameter 'name' is not assigned and could be declared final | 33 |
| Parameter 'o' is not assigned and could be declared final | 42 |
| The method 'equals' has a Cyclomatic Complexity of 9. | 42 - 66 |
| Local variable 'cacheKey' could be declared final | 50 |
| Avoid if (x != y) ..; else ..; | 58 |
| Avoid if (x != y) ..; else ..; | 72 |
org/apache/myfaces/tobago/internal/layout/BankHead.java
| Violation | Line |
|---|---|
| Parameter 'token' is not assigned and could be declared final | 39 |
| Parameter 'token' is not assigned and could be declared final | 48 |
| Parameter 'intervalList' is not assigned and could be declared final | 56 |
| Parameter 'current' is not assigned and could be declared final | 64 |
| Parameter 'rendered' is not assigned and could be declared final | 72 |
org/apache/myfaces/tobago/internal/layout/FactorList.java
| Violation | Line |
|---|---|
| The class 'FactorList' has a Cyclomatic Complexity of 5 (Highest = 4). | 29 - 56 |
| Avoid unused private fields such as 'LOG'. | 31 |
| Avoid unused private fields such as 'LOG'. | 31 |
| Parameter 'size' is not assigned and could be declared final | 33 |
| Local variable 'result' could be declared final | 35 |
org/apache/myfaces/tobago/internal/layout/Grid.java
| Violation | Line |
|---|---|
| The class 'Grid' has a Cyclomatic Complexity of 5 (Highest = 55). | 32 - 498 |
| This class has too many methods, consider refactoring it. | 32 - 498 |
| The class 'Grid' has a Cyclomatic Complexity of 5 (Highest = 55). | 32 - 498 |
| Private field 'cells' could be made final; it is only initialized in the declaration or constructor. | 40 |
| Private field 'columnHeads' could be made final; it is only initialized in the declaration or constructor. | 42 |
| Private field 'columnCount' could be made final; it is only initialized in the declaration or constructor. | 45 |
| Parameter 'columns' is not assigned and could be declared final | 56 |
| Parameter 'rows' is not assigned and could be declared final | 56 |
| Avoid instantiating new objects inside loops | 65 |
| Avoid instantiating new objects inside loops | 69 |
| Local variable 'size' could be declared final | 71 |
| Avoid reassigning parameters such as 'columnSpan' | 78 |
| Avoid reassigning parameters such as 'columnSpan' | 78 |
| Parameter 'cell' is not assigned and could be declared final | 78 |
| Parameter 'rowSpan' is not assigned and could be declared final | 78 |
| The method 'add' has a Cyclomatic Complexity of 9. | 78 - 121 |
| Avoid instantiating new objects inside loops | 110 |
| Parameter 'orientation' is not assigned and could be declared final | 123 |
| Parameter 'j' is not assigned and could be declared final | 123 |
| Parameter 'i' is not assigned and could be declared final | 123 |
| Parameter 'column' is not assigned and could be declared final | 127 |
| Parameter 'row' is not assigned and could be declared final | 127 |
| Parameter 'cell' is not assigned and could be declared final | 138 |
| Parameter 'column' is not assigned and could be declared final | 138 |
| Parameter 'row' is not assigned and could be declared final | 138 |
| Parameter 'orientation' is not assigned and could be declared final | 156 |
| Parameter 'newRows' is not assigned and could be declared final | 160 |
| Local variable 'newRowHeads' could be declared final | 170 |
| Avoid instantiating new objects inside loops | 176 |
| Parameter 'orientation' is not assigned and could be declared final | 182 |
| Parameter 'orientation' is not assigned and could be declared final | 186 |
| Parameter 'overflow' is not assigned and could be declared final | 186 |
| Parameter 'columnOverflow' is not assigned and could be declared final | 198 |
| Parameter 'rowOverflow' is not assigned and could be declared final | 206 |
| Parameter 'j' is not assigned and could be declared final | 210 |
| Parameter 'i' is not assigned and could be declared final | 210 |
| Parameter 'j' is not assigned and could be declared final | 217 |
| Parameter 'i' is not assigned and could be declared final | 217 |
| The method 'gridAsString' has a Cyclomatic Complexity of 55. | 246 - 474 |
| The method gridAsString() has an NPath complexity of 11503356 | 246 - 474 |
| Avoid really long methods. | 246 - 474 |
| The method 'gridAsString' has a Cyclomatic Complexity of 55. | 246 - 474 |
| The method gridAsString() has an NCSS line count of 175 | 246 - 474 |
| Local variable 'builder' could be declared final | 248 |
| Avoid if (x != y) ..; else ..; | 253 - 257 |
| Local variable 'c' could be declared final | 259 |
| Local variable 'd' could be declared final | 260 |
| Avoid if (x != y) ..; else ..; | 277 - 281 |
| Avoid if (x != y) ..; else ..; | 284 - 288 |
| Local variable 'b' could be declared final | 297 |
| Local variable 'd' could be declared final | 298 |
| Local variable 'a' could be declared final | 315 |
| Local variable 'b' could be declared final | 316 |
| Local variable 'c' could be declared final | 317 |
| Local variable 'd' could be declared final | 318 |
| Local variable 'a' could be declared final | 358 |
| Local variable 'c' could be declared final | 359 |
| Local variable 'a' could be declared final | 366 |
| Local variable 'c' could be declared final | 367 |
| Avoid if (x != y) ..; else ..; | 389 - 393 |
| Local variable 'c' could be declared final | 395 |
| Local variable 'd' could be declared final | 396 |
| Local variable 'a' could be declared final | 412 |
| Local variable 'c' could be declared final | 413 |
| Avoid if (x != y) ..; else ..; | 425 - 429 |
| Avoid if (x != y) ..; else ..; | 436 - 440 |
| Local variable 'a' could be declared final | 442 |
| Local variable 'b' could be declared final | 443 |
| Avoid if (x != y) ..; else ..; | 460 - 464 |
| Avoid if (x != y) ..; else ..; | 466 - 470 |
| Local variable 'builder' could be declared final | 478 |
| Parameter 'b' is not assigned and could be declared final | 489 |
| Parameter 'a' is not assigned and could be declared final | 489 |
| The method 'connected' has a Cyclomatic Complexity of 5. | 489 - 497 |
org/apache/myfaces/tobago/internal/layout/Interval.java
| Violation | Line |
|---|---|
| The class 'Interval' has a Cyclomatic Complexity of 3 (Highest = 6). | 29 - 103 |
| Parameter 'orientation' is not assigned and could be declared final | 41 |
| Parameter 'component' is not assigned and could be declared final | 41 |
| The constructor 'Interval' has a Cyclomatic Complexity of 5. | 41 - 47 |
| Parameter 'minimum' is not assigned and could be declared final | 49 |
| Parameter 'maximum' is not assigned and could be declared final | 49 |
| Parameter 'current' is not assigned and could be declared final | 49 |
| Parameter 'preferred' is not assigned and could be declared final | 49 |
| The constructor 'Interval' has a Cyclomatic Complexity of 6. | 49 - 62 |
| Parameter 'interval' is not assigned and could be declared final | 65 |
| Parameter 'divider' is not assigned and could be declared final | 65 |
| The constructor 'Interval' has a Cyclomatic Complexity of 5. | 65 - 71 |
| Avoid if (x != y) ..; else ..; | 66 - 67 |
| Avoid if (x != y) ..; else ..; | 68 |
| Avoid if (x != y) ..; else ..; | 69 |
| Avoid if (x != y) ..; else ..; | 70 |
| Local variable 'builder' could be declared final | 91 |
org/apache/myfaces/tobago/internal/layout/IntervalList.java
| Violation | Line |
|---|---|
| The class 'IntervalList' has a Cyclomatic Complexity of 3 (Highest = 6). | 29 - 101 |
| Local variable 'minimumList' could be declared final | 37 |
| Local variable 'maximumList' could be declared final | 38 |
| Local variable 'maximum' could be declared final | 40 |
| Local variable 'preferred' could be declared final | 48 |
| Avoid if (x != y) ..; else ..; | 49 - 53 |
| Local variable 'result' could be declared final | 58 |
| Local variable 'result' could be declared final | 71 |
| Parameter 'min' is not assigned and could be declared final | 80 |
| Parameter 'max' is not assigned and could be declared final | 80 |
| The method 'findPreferredInInterval' has a Cyclomatic Complexity of 6. | 80 - 92 |
| Local variable 'result' could be declared final | 81 |
org/apache/myfaces/tobago/internal/layout/LayoutContext.java
| Violation | Line |
|---|---|
| The class 'LayoutContext' has a Cyclomatic Complexity of 5 (Highest = 12). | 59 - 159 |
| The class 'LayoutContext' has a Cyclomatic Complexity of 5 (Highest = 12). | 59 - 159 |
| Private field 'container' could be made final; it is only initialized in the declaration or constructor. | 63 |
| Parameter 'container' is not assigned and could be declared final | 65 |
| The method 'layout' has a Cyclomatic Complexity of 12. | 69 - 120 |
| The method layout() has an NPath complexity of 2048 | 69 - 120 |
| The method 'layout' has a Cyclomatic Complexity of 12. | 69 - 120 |
| Local variable 'layoutManager' could be declared final | 78 |
| Parameter 'message' is not assigned and could be declared final | 122 |
| Parameter 'trace' is not assigned and could be declared final | 122 |
| Local variable 'buffer' could be declared final | 123 |
| Avoid concatenating nonliterals in a StringBuffer constructor or append(). | 123 |
| Parameter 'buffer' is not assigned and could be declared final | 132 |
| Parameter 'component' is not assigned and could be declared final | 132 |
| Parameter 'depth' is not assigned and could be declared final | 132 |
| The method 'log' has a Cyclomatic Complexity of 5. | 132 - 158 |
| Local variable 'facesContext' could be declared final | 133 |
| Avoid appending characters as strings in StringBuffer.append. | 136 |
| Avoid appending characters as strings in StringBuffer.append. | 139 |
| Avoid appending characters as strings in StringBuffer.append. | 143 |
| Local variable 'layoutManager' could be declared final | 146 |
| Avoid appending characters as strings in StringBuffer.append. | 148 |
| Avoid appending characters as strings in StringBuffer.append. | 154 |
org/apache/myfaces/tobago/internal/layout/LayoutUtils.java
| Violation | Line |
|---|---|
| The class 'LayoutUtils' has a Cyclomatic Complexity of 3 (Highest = 8). | 37 - 129 |
| Avoid unused private fields such as 'LOG'. | 39 |
| Avoid unused private fields such as 'LOG'. | 39 |
| Parameter 'columns' is not assigned and could be declared final | 47 |
| Local variable 'st' could be declared final | 48 |
| Local variable 'token' could be declared final | 50 |
| Parameter 'container' is not assigned and could be declared final | 58 |
| Local variable 'result' could be declared final | 59 |
| Parameter 'result' is not assigned and could be declared final | 64 |
| Parameter 'component' is not assigned and could be declared final | 64 |
| Parameter 'orientation' is not assigned and could be declared final | 76 |
| Parameter 'container' is not assigned and could be declared final | 76 |
| Parameter 'orientation' is not assigned and could be declared final | 80 |
| Parameter 'container' is not assigned and could be declared final | 80 |
| Parameter 'orientation' is not assigned and could be declared final | 84 |
| Parameter 'container' is not assigned and could be declared final | 84 |
| Parameter 'orientation' is not assigned and could be declared final | 88 |
| Parameter 'container' is not assigned and could be declared final | 88 |
| Parameter 'orientation' is not assigned and could be declared final | 92 |
| Parameter 'component' is not assigned and could be declared final | 92 |
| Avoid reassigning parameters such as 'size' | 96 |
| Avoid reassigning parameters such as 'size' | 96 |
| Avoid reassigning parameters such as 'size' | 96 |
| Avoid reassigning parameters such as 'size' | 96 |
| Avoid reassigning parameters such as 'size' | 96 |
| Avoid reassigning parameters such as 'size' | 96 |
| Parameter 'orientation' is not assigned and could be declared final | 96 |
| Parameter 'component' is not assigned and could be declared final | 96 |
| The method 'setCurrentSize' has a Cyclomatic Complexity of 8. | 96 - 128 |
| Avoid if (x != y) ..; else ..; | 99 - 110 |
| Avoid if (x != y) ..; else ..; | 114 - 125 |
org/apache/myfaces/tobago/internal/layout/MathUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 22 - 111 |
| The class 'MathUtils' has a Cyclomatic Complexity of 2 (Highest = 5). | 22 - 111 |
| Avoid reassigning parameters such as 'bias' | 38 |
| Parameter 'list' is not assigned and could be declared final | 38 |
| Local variable 'remainder' could be declared final | 59 |
| The method 'findAndAdjustMinRemainder' has a Cyclomatic Complexity of 5. | 72 - 90 |
| Local variable 'remainder' could be declared final | 76 |
| Parameter 'v' is not assigned and could be declared final | 92 |
| Parameter 'factor' is not assigned and could be declared final | 96 |
| Parameter 'factor' is not assigned and could be declared final | 100 |
| Parameter 'value' is not assigned and could be declared final | 104 |
| Parameter 'value' is not assigned and could be declared final | 108 |
org/apache/myfaces/tobago/internal/layout/OriginCell.java
| Violation | Line |
|---|---|
| Private field 'component' could be made final; it is only initialized in the declaration or constructor. | 27 |
| Parameter 'component' is not assigned and could be declared final | 31 |
| Parameter 'orientation' is not assigned and could be declared final | 51 |
| Parameter 'columnSpan' is not assigned and could be declared final | 59 |
| Parameter 'rowSpan' is not assigned and could be declared final | 67 |
org/apache/myfaces/tobago/internal/layout/SpanCell.java
| Violation | Line |
|---|---|
| Private field 'origin' could be made final; it is only initialized in the declaration or constructor. | 26 |
| Private field 'horizontalFirst' could be made final; it is only initialized in the declaration or constructor. | 27 |
| Private field 'verticalFirst' could be made final; it is only initialized in the declaration or constructor. | 28 |
| Parameter 'verticalFirst' is not assigned and could be declared final | 30 |
| Parameter 'horizontalFirst' is not assigned and could be declared final | 30 |
| Parameter 'origin' is not assigned and could be declared final | 30 |
org/apache/myfaces/tobago/internal/taglib/TobagoBodyTag.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 31 |
| Avoid unused private fields such as 'LOG'. | 31 |
| Document empty method | 39 - 40 |
| An empty method in an abstract class should be abstract instead | 39 - 40 |
| Local variable 'content' could be declared final | 43 |
| Local variable 'content' could be declared final | 50 |
| Local variable 'tmp' could be declared final | 51 |
| String.trim().length()==0 is an inefficient way to validate an empty String. | 52 |
| Assigning an Object to null is a code smell. Consider refactoring. | 69 |
| Parameter 'bodyContent' is not assigned and could be declared final | 72 |
org/apache/myfaces/tobago/internal/taglib/TobagoELTag.java
| Violation | Line |
|---|---|
| Local variable 'result' could be declared final | 35 |
| Local variable 'component' could be declared final | 36 |
| Local variable 'component' could be declared final | 47 |
| Local variable 'result' could be declared final | 48 |
| Parameter 'renderers' is not assigned and could be declared final | 57 |
| Local variable 'content' could be declared final | 67 |
| Local variable 'content' could be declared final | 79 |
| Local variable 'tmp' could be declared final | 80 |
| String.trim().length()==0 is an inefficient way to validate an empty String. | 81 |
org/apache/myfaces/tobago/internal/taglib/TobagoTag.java
| Violation | Line |
|---|---|
| Local variable 'result' could be declared final | 32 |
| Local variable 'component' could be declared final | 34 |
| Parameter 'renderers' is not assigned and could be declared final | 43 |
org/apache/myfaces/tobago/internal/taglib/component/AttributeTag.java
| Violation | Line |
|---|---|
| The class 'AttributeTag' has a Cyclomatic Complexity of 3 (Highest = 8). | 48 - 142 |
| The method 'doStartTag' has a Cyclomatic Complexity of 8. | 60 - 96 |
| Local variable 'tag' could be declared final | 63 - 64 |
| Local variable 'component' could be declared final | 74 |
| Avoid if (x != y) ..; else ..; | 84 - 94 |
| Local variable 'components' could be declared final | 90 |
| Assigning an Object to null is a code smell. Consider refactoring. | 101 |
| Assigning an Object to null is a code smell. Consider refactoring. | 102 |
| Parameter 'name' is not assigned and could be declared final | 109 |
| Parameter 'value' is not assigned and could be declared final | 117 |
| Parameter 'mode' is not assigned and could be declared final | 138 |
org/apache/myfaces/tobago/internal/taglib/component/CellTagDeclaration.java
| Violation | Line |
|---|---|
| The String literal "java.lang.Integer" appears 4 times in this file; the first occurrence is on line 52 | 52 |
org/apache/myfaces/tobago/internal/taglib/component/CommandTagExtraInfo.java
| Violation | Line |
|---|---|
| Parameter 'data' is not assigned and could be declared final | 29 |
| Local variable 'action' could be declared final | 30 |
| Local variable 'onclick' could be declared final | 31 |
| Local variable 'link' could be declared final | 32 |
| Parameter 'data' is not assigned and could be declared final | 40 |
org/apache/myfaces/tobago/internal/taglib/component/ConverterTag.java
| Violation | Line |
|---|---|
| The class 'ConverterTag' has a Cyclomatic Complexity of 4 (Highest = 12). | 46 - 138 |
| The class 'ConverterTag' has a Cyclomatic Complexity of 4 (Highest = 12). | 46 - 138 |
| The method 'doStartTag' has a Cyclomatic Complexity of 12. | 62 - 114 |
| The method doStartTag() has an NPath complexity of 576 | 62 - 114 |
| The method 'doStartTag' has a Cyclomatic Complexity of 12. | 62 - 114 |
| Local variable 'tag' could be declared final | 65 - 66 |
| Local variable 'component' could be declared final | 76 |
| Local variable 'valueHolder' could be declared final | 85 |
| Local variable 'localConverterId' could be declared final | 97 |
| Avoid if (x != y) ..; else ..; | 103 - 110 |
| Local variable 've' could be declared final | 104 |
| Assigning an Object to null is a code smell. Consider refactoring. | 119 |
| Assigning an Object to null is a code smell. Consider refactoring. | 120 |
| Parameter 'converterId' is not assigned and could be declared final | 127 |
| Parameter 'binding' is not assigned and could be declared final | 135 |
org/apache/myfaces/tobago/internal/taglib/component/DataAttributeTag.java
| Violation | Line |
|---|---|
| Assigning an Object to null is a code smell. Consider refactoring. | 60 |
| Assigning an Object to null is a code smell. Consider refactoring. | 61 |
| Local variable 'tag' could be declared final | 70 - 71 |
| Parameter 'name' is not assigned and could be declared final | 103 |
| Parameter 'value' is not assigned and could be declared final | 113 |
org/apache/myfaces/tobago/internal/taglib/component/GridLayoutConstraintTag.java
| Violation | Line |
|---|---|
| The class 'GridLayoutConstraintTag' has a Cyclomatic Complexity of 3 (Highest = 39). | 47 - 461 |
| The class 'GridLayoutConstraintTag' has a Cyclomatic Complexity of 3 (Highest = 39). | 47 - 461 |
| Too many fields | 47 - 461 |
| The method 'doStartTag' has a Cyclomatic Complexity of 39. | 77 - 237 |
| Avoid really long methods. | 77 - 237 |
| The method 'doStartTag' has a Cyclomatic Complexity of 39. | 77 - 237 |
| Local variable 'tag' could be declared final | 80 - 81 |
| The String literal "Ignoring '" appears 10 times in this file; the first occurrence is on line 114 | 114 |
| The String literal "', because the parent is not a LayoutContainer!" appears 8 times in this file; the first occurrence is on line 178 | 178 |
| Assigning an Object to null is a code smell. Consider refactoring. | 242 |
| Assigning an Object to null is a code smell. Consider refactoring. | 243 |
| Assigning an Object to null is a code smell. Consider refactoring. | 244 |
| Assigning an Object to null is a code smell. Consider refactoring. | 245 |
| Assigning an Object to null is a code smell. Consider refactoring. | 246 |
| Assigning an Object to null is a code smell. Consider refactoring. | 247 |
| Assigning an Object to null is a code smell. Consider refactoring. | 248 |
| Assigning an Object to null is a code smell. Consider refactoring. | 249 |
| Assigning an Object to null is a code smell. Consider refactoring. | 250 |
| Assigning an Object to null is a code smell. Consider refactoring. | 251 |
| Assigning an Object to null is a code smell. Consider refactoring. | 252 |
| Assigning an Object to null is a code smell. Consider refactoring. | 253 |
| Assigning an Object to null is a code smell. Consider refactoring. | 254 |
| Assigning an Object to null is a code smell. Consider refactoring. | 255 |
| Assigning an Object to null is a code smell. Consider refactoring. | 256 |
| Assigning an Object to null is a code smell. Consider refactoring. | 257 |
| Assigning an Object to null is a code smell. Consider refactoring. | 258 |
| Assigning an Object to null is a code smell. Consider refactoring. | 259 |
| Assigning an Object to null is a code smell. Consider refactoring. | 260 |
| Assigning an Object to null is a code smell. Consider refactoring. | 261 |
| Assigning an Object to null is a code smell. Consider refactoring. | 262 |
| Assigning an Object to null is a code smell. Consider refactoring. | 263 |
| Parameter 'columnSpan' is not assigned and could be declared final | 270 |
| Parameter 'rowSpan' is not assigned and could be declared final | 278 |
| The String literal "org.apache.myfaces.tobago.layout.Measure" appears 40 times in this file; the first occurrence is on line 285 | 285 |
| Parameter 'width' is not assigned and could be declared final | 287 |
| Parameter 'height' is not assigned and could be declared final | 296 |
| Parameter 'minimumWidth' is not assigned and could be declared final | 305 |
| Parameter 'minimumHeight' is not assigned and could be declared final | 314 |
| Parameter 'preferredWidth' is not assigned and could be declared final | 323 |
| Parameter 'preferredHeight' is not assigned and could be declared final | 332 |
| Parameter 'maximumWidth' is not assigned and could be declared final | 341 |
| Parameter 'maximumHeight' is not assigned and could be declared final | 350 |
| Parameter 'marginLeft' is not assigned and could be declared final | 359 |
| Parameter 'marginRight' is not assigned and could be declared final | 368 |
| Parameter 'marginTop' is not assigned and could be declared final | 377 |
| Parameter 'marginBottom' is not assigned and could be declared final | 386 |
| Parameter 'borderLeft' is not assigned and could be declared final | 395 |
| Parameter 'borderRight' is not assigned and could be declared final | 404 |
| Parameter 'borderTop' is not assigned and could be declared final | 413 |
| Parameter 'borderBottom' is not assigned and could be declared final | 422 |
| Parameter 'paddingLeft' is not assigned and could be declared final | 431 |
| Parameter 'paddingRight' is not assigned and could be declared final | 440 |
| Parameter 'paddingTop' is not assigned and could be declared final | 449 |
| Parameter 'paddingBottom' is not assigned and could be declared final | 458 |
org/apache/myfaces/tobago/internal/taglib/component/LoadBundleTag.java
| Violation | Line |
|---|---|
| Local variable 'facesContext' could be declared final | 60 |
| Local variable 'toStore' could be declared final | 63 |
| Assigning an Object to null is a code smell. Consider refactoring. | 73 |
| Assigning an Object to null is a code smell. Consider refactoring. | 74 |
| Parameter 'basename' is not assigned and could be declared final | 81 |
| Parameter 'var' is not assigned and could be declared final | 91 |
org/apache/myfaces/tobago/internal/taglib/component/PopupReferenceTag.java
| Violation | Line |
|---|---|
| The class 'PopupReferenceTag' has a Cyclomatic Complexity of 4 (Highest = 6). | 45 - 95 |
| The method 'doStartTag' has a Cyclomatic Complexity of 6. | 51 - 85 |
| Local variable 'tag' could be declared final | 54 - 55 |
| Local variable 'component' could be declared final | 65 |
| Local variable 'actionSource' could be declared final | 74 |
| Parameter 'forValue' is not assigned and could be declared final | 91 |
org/apache/myfaces/tobago/internal/taglib/component/ResetInputActionListenerTag.java
| Violation | Line |
|---|---|
| The class 'ResetInputActionListenerTag' has a Cyclomatic Complexity of 3 (Highest = 7). | 49 - 108 |
| The method 'doStartTag' has a Cyclomatic Complexity of 7. | 55 - 91 |
| Local variable 'tag' could be declared final | 58 - 59 |
| Local variable 'component' could be declared final | 69 |
| Local variable 'actionSource' could be declared final | 81 |
| Assigning an Object to null is a code smell. Consider refactoring. | 96 |
| Parameter 'execute' is not assigned and could be declared final | 104 |
org/apache/myfaces/tobago/internal/taglib/component/SheetTagDeclaration.java
| Violation | Line |
|---|---|
| The String literal "center" appears 4 times in this file; the first occurrence is on line 152 | 152 |
| The String literal "left" appears 4 times in this file; the first occurrence is on line 153 | 153 |
| The String literal "none" appears 4 times in this file; the first occurrence is on line 153 | 153 |
| The String literal "right" appears 4 times in this file; the first occurrence is on line 153 | 153 |
org/apache/myfaces/tobago/internal/taglib/component/SuggestTagDeclaration.java
| Violation | Line |
|---|---|
| The String literal "java.lang.Integer" appears 4 times in this file; the first occurrence is on line 84 | 84 |
org/apache/myfaces/tobago/internal/taglib/component/TabChangeListenerTag.java
| Violation | Line |
|---|---|
| The class 'TabChangeListenerTag' has a Cyclomatic Complexity of 5 (Highest = 14). | 46 - 147 |
| The class 'TabChangeListenerTag' has a Cyclomatic Complexity of 5 (Highest = 14). | 46 - 147 |
| Parameter 'type' is not assigned and could be declared final | 58 |
| Parameter 'binding' is not assigned and could be declared final | 66 |
| The method 'doStartTag' has a Cyclomatic Complexity of 14. | 79 - 131 |
| The method doStartTag() has an NPath complexity of 960 | 79 - 131 |
| The method 'doStartTag' has a Cyclomatic Complexity of 14. | 79 - 131 |
| Local variable 'tag' could be declared final | 82 - 83 |
| Local variable 'component' could be declared final | 93 |
| Local variable 'changeSource' could be declared final | 102 |
| Local variable 'value' could be declared final | 108 |
| Avoid if (x != y) ..; else ..; | 122 - 127 |
| Parameter 'className' is not assigned and could be declared final | 139 |
| Local variable 'clazz' could be declared final | 141 |
org/apache/myfaces/tobago/internal/taglib/component/ValidateFileItemTag.java
| Violation | Line |
|---|---|
| Assigning an Object to null is a code smell. Consider refactoring. | 78 |
| Assigning an Object to null is a code smell. Consider refactoring. | 79 |
| Parameter 'maxSize' is not assigned and could be declared final | 83 |
| Parameter 'contentType' is not assigned and could be declared final | 88 |
org/apache/myfaces/tobago/internal/taglib/component/ValidateSubmittedValueLengthTag.java
| Violation | Line |
|---|---|
| The class 'ValidateSubmittedValueLengthTag' has a Cyclomatic Complexity of 3 (Highest = 5). | 44 - 85 |
| The method 'createValidator' has a Cyclomatic Complexity of 5. | 51 - 73 |
| Avoid empty catch blocks | 61 - 63 |
| Avoid empty catch blocks | 61 - 63 |
| Avoid empty catch blocks | 68 - 70 |
| Avoid empty catch blocks | 68 - 70 |
| Parameter 'minimum' is not assigned and could be declared final | 76 |
| Parameter 'maximum' is not assigned and could be declared final | 81 |
org/apache/myfaces/tobago/internal/taglib/declaration/HasMargins.java
| Violation | Line |
|---|---|
| The String literal "org.apache.myfaces.tobago.layout.Measure" appears 4 times in this file; the first occurrence is on line 32 | 32 |
| The String literal "getMargin() != null\n" appears 4 times in this file; the first occurrence is on line 33 | 33 |
| The String literal " ? getMargin()\n : getRendererType() != null" appears 4 times in this file; the first occurrence is on line 34 | 34 |
org/apache/myfaces/tobago/internal/taglib/declaration/IsGridLayoutComponentBase.java
| Violation | Line |
|---|---|
| The String literal "org.apache.myfaces.tobago.layout.Measure" appears 14 times in this file; the first occurrence is on line 35 | 35 |
| The String literal "java.lang.Integer" appears 4 times in this file; the first occurrence is on line 51 | 51 |
| The String literal "getRendererType() != null ? ((LayoutComponentRenderer) " appears 10 times in this file; the first occurrence is on line 64 | 64 |
org/apache/myfaces/tobago/internal/taglib/declaration/IsGridLayoutContainer.java
| Violation | Line |
|---|---|
| The String literal "org.apache.myfaces.tobago.layout.Measure" appears 8 times in this file; the first occurrence is on line 32 | 32 |
| The String literal "getRendererType() != null ? ((org.apache.myfaces.tobago.renderkit.LayoutComponentRenderer)\n" appears 8 times in this file; the first occurrence is on line 33 | 33 |
org/apache/myfaces/tobago/internal/taglib/extension/DateExtensionTag.java
| Violation | Line |
|---|---|
| The class 'DateExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 26). | 56 - 505 |
| The class 'DateExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 26). | 56 - 505 |
| Too many fields | 56 - 505 |
| The method 'doStartTag' has a Cyclomatic Complexity of 26. | 89 - 182 |
| The method doStartTag() has an NPath complexity of 33554432 | 89 - 182 |
| The method 'doStartTag' has a Cyclomatic Complexity of 26. | 89 - 182 |
| Avoid if (x != y) ..; else ..; | 99 - 103 |
| The method 'doEndTag' has a Cyclomatic Complexity of 5. | 185 - 216 |
| Local variable 'formTag' could be declared final | 187 |
| Local variable 'datePicker' could be declared final | 196 |
| Assigning an Object to null is a code smell. Consider refactoring. | 221 |
| Assigning an Object to null is a code smell. Consider refactoring. | 222 |
| Assigning an Object to null is a code smell. Consider refactoring. | 223 |
| Assigning an Object to null is a code smell. Consider refactoring. | 224 |
| Assigning an Object to null is a code smell. Consider refactoring. | 225 |
| Assigning an Object to null is a code smell. Consider refactoring. | 226 |
| Assigning an Object to null is a code smell. Consider refactoring. | 227 |
| Assigning an Object to null is a code smell. Consider refactoring. | 228 |
| Assigning an Object to null is a code smell. Consider refactoring. | 229 |
| Assigning an Object to null is a code smell. Consider refactoring. | 230 |
| Assigning an Object to null is a code smell. Consider refactoring. | 231 |
| Assigning an Object to null is a code smell. Consider refactoring. | 232 |
| Assigning an Object to null is a code smell. Consider refactoring. | 233 |
| Assigning an Object to null is a code smell. Consider refactoring. | 234 |
| Assigning an Object to null is a code smell. Consider refactoring. | 235 |
| Assigning an Object to null is a code smell. Consider refactoring. | 236 |
| Assigning an Object to null is a code smell. Consider refactoring. | 237 |
| Assigning an Object to null is a code smell. Consider refactoring. | 238 |
| Assigning an Object to null is a code smell. Consider refactoring. | 239 |
| Assigning an Object to null is a code smell. Consider refactoring. | 240 |
| Assigning an Object to null is a code smell. Consider refactoring. | 241 |
| Assigning an Object to null is a code smell. Consider refactoring. | 242 |
| Assigning an Object to null is a code smell. Consider refactoring. | 243 |
| Assigning an Object to null is a code smell. Consider refactoring. | 244 |
| Assigning an Object to null is a code smell. Consider refactoring. | 245 |
| Assigning an Object to null is a code smell. Consider refactoring. | 246 |
| Parameter 'value' is not assigned and could be declared final | 254 |
| Parameter 'valueChangeListener' is not assigned and could be declared final | 269 |
| Parameter 'label' is not assigned and could be declared final | 279 |
| Parameter 'onchange' is not assigned and could be declared final | 288 |
| The String literal "boolean" appears 6 times in this file; the first occurrence is on line 296 | 296 |
| The String literal "false" appears 5 times in this file; the first occurrence is on line 296 | 296 |
| Parameter 'focus' is not assigned and could be declared final | 297 |
| Parameter 'binding' is not assigned and could be declared final | 307 |
| Parameter 'rendered' is not assigned and could be declared final | 317 |
| Parameter 'converter' is not assigned and could be declared final | 333 |
| Parameter 'validator' is not assigned and could be declared final | 347 |
| Parameter 'inline' is not assigned and could be declared final | 358 |
| Parameter 'readonly' is not assigned and could be declared final | 367 |
| Parameter 'disabled' is not assigned and could be declared final | 376 |
| Parameter 'required' is not assigned and could be declared final | 387 |
| Parameter 'tip' is not assigned and could be declared final | 396 |
| Parameter 'placeholder' is not assigned and could be declared final | 406 |
| Parameter 'labelWidth' is not assigned and could be declared final | 417 |
| Parameter 'markup' is not assigned and could be declared final | 427 |
| Parameter 'tabIndex' is not assigned and could be declared final | 433 |
| Parameter 'validatorMessage' is not assigned and could be declared final | 442 |
| Parameter 'converterMessage' is not assigned and could be declared final | 451 |
| Parameter 'requiredMessage' is not assigned and could be declared final | 460 |
| Parameter 'fieldId' is not assigned and could be declared final | 470 |
| Parameter 'pickerId' is not assigned and could be declared final | 480 |
| Parameter 'formId' is not assigned and could be declared final | 490 |
| Parameter 'id' is not assigned and could be declared final | 502 |
org/apache/myfaces/tobago/internal/taglib/extension/ExtensionPanelTag.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 33 |
| Avoid unused private fields such as 'LOG'. | 33 |
| Avoid unused local variables such as 'application'. | 51 |
| Avoid unused local variables such as 'application'. | 51 |
| Avoid if (x != y) ..; else ..; | 53 - 57 |
| Assigning an Object to null is a code smell. Consider refactoring. | 84 |
| Assigning an Object to null is a code smell. Consider refactoring. | 85 |
org/apache/myfaces/tobago/internal/taglib/extension/FileExtensionTag.java
| Violation | Line |
|---|---|
| The class 'FileExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 20). | 53 - 363 |
| The class 'FileExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 20). | 53 - 363 |
| Too many fields | 53 - 363 |
| The method 'doStartTag' has a Cyclomatic Complexity of 20. | 77 - 149 |
| The method doStartTag() has an NPath complexity of 524288 | 77 - 149 |
| The method 'doStartTag' has a Cyclomatic Complexity of 20. | 77 - 149 |
| Avoid empty if statements | 132 - 134 |
| Avoid empty if statements | 132 - 134 |
| Assigning an Object to null is a code smell. Consider refactoring. | 161 |
| Assigning an Object to null is a code smell. Consider refactoring. | 162 |
| Assigning an Object to null is a code smell. Consider refactoring. | 163 |
| Assigning an Object to null is a code smell. Consider refactoring. | 164 |
| Assigning an Object to null is a code smell. Consider refactoring. | 165 |
| Assigning an Object to null is a code smell. Consider refactoring. | 166 |
| Assigning an Object to null is a code smell. Consider refactoring. | 167 |
| Assigning an Object to null is a code smell. Consider refactoring. | 168 |
| Assigning an Object to null is a code smell. Consider refactoring. | 169 |
| Assigning an Object to null is a code smell. Consider refactoring. | 170 |
| Assigning an Object to null is a code smell. Consider refactoring. | 171 |
| Assigning an Object to null is a code smell. Consider refactoring. | 172 |
| Assigning an Object to null is a code smell. Consider refactoring. | 173 |
| Assigning an Object to null is a code smell. Consider refactoring. | 174 |
| Assigning an Object to null is a code smell. Consider refactoring. | 175 |
| Assigning an Object to null is a code smell. Consider refactoring. | 176 |
| Assigning an Object to null is a code smell. Consider refactoring. | 177 |
| Assigning an Object to null is a code smell. Consider refactoring. | 178 |
| Assigning an Object to null is a code smell. Consider refactoring. | 179 |
| Parameter 'label' is not assigned and could be declared final | 188 |
| Parameter 'value' is not assigned and could be declared final | 197 |
| Parameter 'valueChangeListener' is not assigned and could be declared final | 214 |
| Parameter 'onchange' is not assigned and could be declared final | 223 |
| Parameter 'binding' is not assigned and could be declared final | 233 |
| The String literal "boolean" appears 4 times in this file; the first occurrence is on line 242 | 242 |
| Parameter 'rendered' is not assigned and could be declared final | 243 |
| Parameter 'validator' is not assigned and could be declared final | 257 |
| Parameter 'disabled' is not assigned and could be declared final | 266 |
| Parameter 'tip' is not assigned and could be declared final | 275 |
| Parameter 'labelWidth' is not assigned and could be declared final | 285 |
| Parameter 'required' is not assigned and could be declared final | 296 |
| Parameter 'tabIndex' is not assigned and could be declared final | 302 |
| Parameter 'focus' is not assigned and could be declared final | 311 |
| Parameter 'validatorMessage' is not assigned and could be declared final | 320 |
| Parameter 'converterMessage' is not assigned and could be declared final | 329 |
| Parameter 'requiredMessage' is not assigned and could be declared final | 338 |
| Parameter 'fieldId' is not assigned and could be declared final | 348 |
| Parameter 'id' is not assigned and could be declared final | 360 |
org/apache/myfaces/tobago/internal/taglib/extension/InExtensionTag.java
| Violation | Line |
|---|---|
| The class 'InExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 29). | 57 - 505 |
| The class 'InExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 29). | 57 - 505 |
| Too many fields | 57 - 505 |
| The method 'doStartTag' has a Cyclomatic Complexity of 29. | 89 - 188 |
| The method doStartTag() has an NPath complexity of 268435456 | 89 - 188 |
| The method 'doStartTag' has a Cyclomatic Complexity of 29. | 89 - 188 |
| Avoid unused private fields such as 'LOG'. | 197 |
| Avoid unused private fields such as 'LOG'. | 197 |
| Assigning an Object to null is a code smell. Consider refactoring. | 202 |
| Assigning an Object to null is a code smell. Consider refactoring. | 203 |
| Assigning an Object to null is a code smell. Consider refactoring. | 204 |
| Assigning an Object to null is a code smell. Consider refactoring. | 205 |
| Assigning an Object to null is a code smell. Consider refactoring. | 206 |
| Assigning an Object to null is a code smell. Consider refactoring. | 207 |
| Assigning an Object to null is a code smell. Consider refactoring. | 208 |
| Assigning an Object to null is a code smell. Consider refactoring. | 209 |
| Assigning an Object to null is a code smell. Consider refactoring. | 210 |
| Assigning an Object to null is a code smell. Consider refactoring. | 211 |
| Assigning an Object to null is a code smell. Consider refactoring. | 212 |
| Assigning an Object to null is a code smell. Consider refactoring. | 213 |
| Assigning an Object to null is a code smell. Consider refactoring. | 214 |
| Assigning an Object to null is a code smell. Consider refactoring. | 215 |
| Assigning an Object to null is a code smell. Consider refactoring. | 216 |
| Assigning an Object to null is a code smell. Consider refactoring. | 217 |
| Assigning an Object to null is a code smell. Consider refactoring. | 218 |
| Assigning an Object to null is a code smell. Consider refactoring. | 219 |
| Assigning an Object to null is a code smell. Consider refactoring. | 220 |
| Assigning an Object to null is a code smell. Consider refactoring. | 221 |
| Assigning an Object to null is a code smell. Consider refactoring. | 222 |
| Assigning an Object to null is a code smell. Consider refactoring. | 223 |
| Assigning an Object to null is a code smell. Consider refactoring. | 224 |
| Assigning an Object to null is a code smell. Consider refactoring. | 225 |
| Assigning an Object to null is a code smell. Consider refactoring. | 226 |
| Assigning an Object to null is a code smell. Consider refactoring. | 227 |
| Assigning an Object to null is a code smell. Consider refactoring. | 228 |
| Parameter 'markup' is not assigned and could be declared final | 237 |
| Parameter 'value' is not assigned and could be declared final | 246 |
| Parameter 'valueChangeListener' is not assigned and could be declared final | 263 |
| Parameter 'label' is not assigned and could be declared final | 273 |
| The String literal "boolean" appears 6 times in this file; the first occurrence is on line 281 | 281 |
| The String literal "false" appears 5 times in this file; the first occurrence is on line 281 | 281 |
| Parameter 'focus' is not assigned and could be declared final | 282 |
| Parameter 'binding' is not assigned and could be declared final | 292 |
| Parameter 'rendered' is not assigned and could be declared final | 302 |
| Parameter 'converter' is not assigned and could be declared final | 318 |
| Parameter 'onchange' is not assigned and could be declared final | 327 |
| Parameter 'suggestMethod' is not assigned and could be declared final | 342 |
| Parameter 'suggestMinChars' is not assigned and could be declared final | 353 |
| Parameter 'suggestDelay' is not assigned and could be declared final | 364 |
| Parameter 'validator' is not assigned and could be declared final | 378 |
| Parameter 'password' is not assigned and could be declared final | 388 |
| Parameter 'readonly' is not assigned and could be declared final | 397 |
| Parameter 'disabled' is not assigned and could be declared final | 406 |
| Parameter 'required' is not assigned and could be declared final | 417 |
| Parameter 'tip' is not assigned and could be declared final | 426 |
| Parameter 'placeholder' is not assigned and could be declared final | 436 |
| Parameter 'labelWidth' is not assigned and could be declared final | 447 |
| Parameter 'tabIndex' is not assigned and could be declared final | 453 |
| Parameter 'validatorMessage' is not assigned and could be declared final | 462 |
| Parameter 'converterMessage' is not assigned and could be declared final | 471 |
| Parameter 'requiredMessage' is not assigned and could be declared final | 480 |
| Parameter 'fieldId' is not assigned and could be declared final | 490 |
| Parameter 'id' is not assigned and could be declared final | 502 |
org/apache/myfaces/tobago/internal/taglib/extension/LabelExtensionTag.java
| Violation | Line |
|---|---|
| The class 'LabelExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 8). | 68 - 225 |
| The method 'doStartTag' has a Cyclomatic Complexity of 8. | 85 - 142 |
| Local variable 'facetTag' could be declared final | 102 |
| Avoid if (x != y) ..; else ..; | 109 - 113 |
| Local variable 'gridLayoutTag' could be declared final | 115 |
| Local variable 've' could be declared final | 118 |
| Local variable 'labelTag' could be declared final | 127 |
| Assigning an Object to null is a code smell. Consider refactoring. | 153 |
| Assigning an Object to null is a code smell. Consider refactoring. | 154 |
| Assigning an Object to null is a code smell. Consider refactoring. | 155 |
| Assigning an Object to null is a code smell. Consider refactoring. | 156 |
| Assigning an Object to null is a code smell. Consider refactoring. | 158 |
| Assigning an Object to null is a code smell. Consider refactoring. | 159 |
| Assigning an Object to null is a code smell. Consider refactoring. | 160 |
| Parameter 'value' is not assigned and could be declared final | 168 |
| Parameter 'tip' is not assigned and could be declared final | 177 |
| Parameter 'rendered' is not assigned and could be declared final | 187 |
| Parameter 'columns' is not assigned and could be declared final | 191 |
| Avoid if (x != y) ..; else ..; | 192 - 198 |
| Parameter 'rows' is not assigned and could be declared final | 201 |
| Parameter 'labelWidth' is not assigned and could be declared final | 212 |
| Parameter 'markup' is not assigned and could be declared final | 222 |
org/apache/myfaces/tobago/internal/taglib/extension/MenuCheckboxExtensionTag.java
| Violation | Line |
|---|---|
| The class 'MenuCheckboxExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 15). | 58 - 339 |
| The class 'MenuCheckboxExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 15). | 58 - 339 |
| Too many fields | 58 - 339 |
| The method 'doStartTag' has a Cyclomatic Complexity of 15. | 78 - 141 |
| The method doStartTag() has an NPath complexity of 16384 | 78 - 141 |
| The method 'doStartTag' has a Cyclomatic Complexity of 15. | 78 - 141 |
| Local variable 'inComponent' could be declared final | 148 |
| Local variable 'command' could be declared final | 149 |
| Local variable 'expression' could be declared final | 150 |
| Avoid if (x != y) ..; else ..; | 151 - 156 |
| Local variable 'renderedPartially' could be declared final | 154 |
| Assigning an Object to null is a code smell. Consider refactoring. | 168 |
| Assigning an Object to null is a code smell. Consider refactoring. | 169 |
| Assigning an Object to null is a code smell. Consider refactoring. | 170 |
| Assigning an Object to null is a code smell. Consider refactoring. | 171 |
| Assigning an Object to null is a code smell. Consider refactoring. | 172 |
| Assigning an Object to null is a code smell. Consider refactoring. | 173 |
| Assigning an Object to null is a code smell. Consider refactoring. | 174 |
| Assigning an Object to null is a code smell. Consider refactoring. | 175 |
| Assigning an Object to null is a code smell. Consider refactoring. | 176 |
| Assigning an Object to null is a code smell. Consider refactoring. | 177 |
| Assigning an Object to null is a code smell. Consider refactoring. | 178 |
| Assigning an Object to null is a code smell. Consider refactoring. | 179 |
| Assigning an Object to null is a code smell. Consider refactoring. | 180 |
| Assigning an Object to null is a code smell. Consider refactoring. | 181 |
| Assigning an Object to null is a code smell. Consider refactoring. | 182 |
| Assigning an Object to null is a code smell. Consider refactoring. | 183 |
| Parameter 'action' is not assigned and could be declared final | 198 |
| Parameter 'actionListener' is not assigned and could be declared final | 211 |
| Parameter 'onclick' is not assigned and could be declared final | 222 |
| Parameter 'link' is not assigned and could be declared final | 233 |
| Parameter 'binding' is not assigned and could be declared final | 243 |
| The String literal "boolean" appears 4 times in this file; the first occurrence is on line 252 | 252 |
| Parameter 'rendered' is not assigned and could be declared final | 253 |
| Parameter 'disabled' is not assigned and could be declared final | 262 |
| Parameter 'value' is not assigned and could be declared final | 271 |
| Parameter 'label' is not assigned and could be declared final | 281 |
| Parameter 'immediate' is not assigned and could be declared final | 293 |
| Parameter 'transition' is not assigned and could be declared final | 305 |
| Parameter 'renderedPartially' is not assigned and could be declared final | 314 |
| Parameter 'fieldId' is not assigned and could be declared final | 324 |
| Parameter 'id' is not assigned and could be declared final | 336 |
org/apache/myfaces/tobago/internal/taglib/extension/MenuRadioExtensionTag.java
| Violation | Line |
|---|---|
| The class 'MenuRadioExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 16). | 62 - 365 |
| The class 'MenuRadioExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 16). | 62 - 365 |
| Too many fields | 62 - 365 |
| The method 'doStartTag' has a Cyclomatic Complexity of 16. | 84 - 150 |
| The method doStartTag() has an NPath complexity of 32768 | 84 - 150 |
| The method 'doStartTag' has a Cyclomatic Complexity of 16. | 84 - 150 |
| Local variable 'inComponent' could be declared final | 157 |
| Local variable 'command' could be declared final | 158 |
| Local variable 'expression' could be declared final | 159 |
| Avoid if (x != y) ..; else ..; | 160 - 165 |
| Local variable 'renderedPartially' could be declared final | 163 |
| Assigning an Object to null is a code smell. Consider refactoring. | 177 |
| Assigning an Object to null is a code smell. Consider refactoring. | 178 |
| Assigning an Object to null is a code smell. Consider refactoring. | 179 |
| Assigning an Object to null is a code smell. Consider refactoring. | 180 |
| Assigning an Object to null is a code smell. Consider refactoring. | 181 |
| Assigning an Object to null is a code smell. Consider refactoring. | 182 |
| Assigning an Object to null is a code smell. Consider refactoring. | 183 |
| Assigning an Object to null is a code smell. Consider refactoring. | 184 |
| Assigning an Object to null is a code smell. Consider refactoring. | 185 |
| Assigning an Object to null is a code smell. Consider refactoring. | 186 |
| Assigning an Object to null is a code smell. Consider refactoring. | 187 |
| Assigning an Object to null is a code smell. Consider refactoring. | 188 |
| Assigning an Object to null is a code smell. Consider refactoring. | 189 |
| Assigning an Object to null is a code smell. Consider refactoring. | 190 |
| Assigning an Object to null is a code smell. Consider refactoring. | 191 |
| Assigning an Object to null is a code smell. Consider refactoring. | 192 |
| Assigning an Object to null is a code smell. Consider refactoring. | 193 |
| Parameter 'action' is not assigned and could be declared final | 208 |
| Parameter 'actionListener' is not assigned and could be declared final | 221 |
| Parameter 'onclick' is not assigned and could be declared final | 232 |
| Parameter 'link' is not assigned and could be declared final | 243 |
| Parameter 'binding' is not assigned and could be declared final | 253 |
| The String literal "boolean" appears 4 times in this file; the first occurrence is on line 262 | 262 |
| Parameter 'rendered' is not assigned and could be declared final | 263 |
| Parameter 'disabled' is not assigned and could be declared final | 272 |
| Parameter 'value' is not assigned and could be declared final | 281 |
| Parameter 'label' is not assigned and could be declared final | 291 |
| Parameter 'immediate' is not assigned and could be declared final | 303 |
| Parameter 'transition' is not assigned and could be declared final | 315 |
| Parameter 'converter' is not assigned and could be declared final | 331 |
| Parameter 'renderedPartially' is not assigned and could be declared final | 340 |
| Parameter 'fieldId' is not assigned and could be declared final | 350 |
| Parameter 'id' is not assigned and could be declared final | 362 |
org/apache/myfaces/tobago/internal/taglib/extension/SelectBooleanCheckboxExtensionTag.java
| Violation | Line |
|---|---|
| The class 'SelectBooleanCheckboxExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 25). | 40 - 421 |
| The class 'SelectBooleanCheckboxExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 25). | 40 - 421 |
| Too many fields | 40 - 421 |
| The method 'doStartTag' has a Cyclomatic Complexity of 25. | 68 - 157 |
| The method doStartTag() has an NPath complexity of 16777216 | 68 - 157 |
| The method 'doStartTag' has a Cyclomatic Complexity of 25. | 68 - 157 |
| Avoid if (x != y) ..; else ..; | 132 - 136 |
| Assigning an Object to null is a code smell. Consider refactoring. | 169 |
| Assigning an Object to null is a code smell. Consider refactoring. | 170 |
| Assigning an Object to null is a code smell. Consider refactoring. | 171 |
| Assigning an Object to null is a code smell. Consider refactoring. | 172 |
| Assigning an Object to null is a code smell. Consider refactoring. | 173 |
| Assigning an Object to null is a code smell. Consider refactoring. | 174 |
| Assigning an Object to null is a code smell. Consider refactoring. | 175 |
| Assigning an Object to null is a code smell. Consider refactoring. | 176 |
| Assigning an Object to null is a code smell. Consider refactoring. | 177 |
| Assigning an Object to null is a code smell. Consider refactoring. | 178 |
| Assigning an Object to null is a code smell. Consider refactoring. | 179 |
| Assigning an Object to null is a code smell. Consider refactoring. | 180 |
| Assigning an Object to null is a code smell. Consider refactoring. | 181 |
| Assigning an Object to null is a code smell. Consider refactoring. | 182 |
| Assigning an Object to null is a code smell. Consider refactoring. | 183 |
| Assigning an Object to null is a code smell. Consider refactoring. | 184 |
| Assigning an Object to null is a code smell. Consider refactoring. | 185 |
| Assigning an Object to null is a code smell. Consider refactoring. | 186 |
| Assigning an Object to null is a code smell. Consider refactoring. | 187 |
| Assigning an Object to null is a code smell. Consider refactoring. | 188 |
| Assigning an Object to null is a code smell. Consider refactoring. | 189 |
| Assigning an Object to null is a code smell. Consider refactoring. | 190 |
| Assigning an Object to null is a code smell. Consider refactoring. | 191 |
| Parameter 'value' is not assigned and could be declared final | 199 |
| Parameter 'valueChangeListener' is not assigned and could be declared final | 216 |
| The String literal "boolean" appears 5 times in this file; the first occurrence is on line 224 | 224 |
| The String literal "false" appears 4 times in this file; the first occurrence is on line 224 | 224 |
| Parameter 'disabled' is not assigned and could be declared final | 225 |
| Parameter 'readonly' is not assigned and could be declared final | 234 |
| Parameter 'onchange' is not assigned and could be declared final | 243 |
| Parameter 'label' is not assigned and could be declared final | 253 |
| Parameter 'itemLabel' is not assigned and could be declared final | 263 |
| Parameter 'validator' is not assigned and could be declared final | 277 |
| Parameter 'converter' is not assigned and could be declared final | 293 |
| Parameter 'rendered' is not assigned and could be declared final | 303 |
| Parameter 'binding' is not assigned and could be declared final | 313 |
| Parameter 'tip' is not assigned and could be declared final | 322 |
| Parameter 'labelWidth' is not assigned and could be declared final | 333 |
| Parameter 'markup' is not assigned and could be declared final | 343 |
| Parameter 'tabIndex' is not assigned and could be declared final | 349 |
| Parameter 'focus' is not assigned and could be declared final | 358 |
| Parameter 'required' is not assigned and could be declared final | 369 |
| Parameter 'validatorMessage' is not assigned and could be declared final | 378 |
| Parameter 'converterMessage' is not assigned and could be declared final | 387 |
| Parameter 'requiredMessage' is not assigned and could be declared final | 396 |
| Parameter 'fieldId' is not assigned and could be declared final | 406 |
| Parameter 'id' is not assigned and could be declared final | 418 |
org/apache/myfaces/tobago/internal/taglib/extension/SelectManyCheckboxExtensionTag.java
| Violation | Line |
|---|---|
| The class 'SelectManyCheckboxExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 26). | 38 - 438 |
| The class 'SelectManyCheckboxExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 26). | 38 - 438 |
| Too many fields | 38 - 438 |
| The method 'doStartTag' has a Cyclomatic Complexity of 26. | 68 - 162 |
| The method doStartTag() has an NPath complexity of 33554432 | 68 - 162 |
| The method 'doStartTag' has a Cyclomatic Complexity of 26. | 68 - 162 |
| Assigning an Object to null is a code smell. Consider refactoring. | 174 |
| Assigning an Object to null is a code smell. Consider refactoring. | 175 |
| Assigning an Object to null is a code smell. Consider refactoring. | 176 |
| Assigning an Object to null is a code smell. Consider refactoring. | 177 |
| Assigning an Object to null is a code smell. Consider refactoring. | 178 |
| Assigning an Object to null is a code smell. Consider refactoring. | 179 |
| Assigning an Object to null is a code smell. Consider refactoring. | 181 |
| Assigning an Object to null is a code smell. Consider refactoring. | 182 |
| Assigning an Object to null is a code smell. Consider refactoring. | 183 |
| Assigning an Object to null is a code smell. Consider refactoring. | 184 |
| Assigning an Object to null is a code smell. Consider refactoring. | 185 |
| Assigning an Object to null is a code smell. Consider refactoring. | 186 |
| Assigning an Object to null is a code smell. Consider refactoring. | 187 |
| Assigning an Object to null is a code smell. Consider refactoring. | 188 |
| Assigning an Object to null is a code smell. Consider refactoring. | 189 |
| Assigning an Object to null is a code smell. Consider refactoring. | 190 |
| Assigning an Object to null is a code smell. Consider refactoring. | 191 |
| Assigning an Object to null is a code smell. Consider refactoring. | 192 |
| Assigning an Object to null is a code smell. Consider refactoring. | 193 |
| Assigning an Object to null is a code smell. Consider refactoring. | 194 |
| Assigning an Object to null is a code smell. Consider refactoring. | 195 |
| Assigning an Object to null is a code smell. Consider refactoring. | 196 |
| Assigning an Object to null is a code smell. Consider refactoring. | 197 |
| Assigning an Object to null is a code smell. Consider refactoring. | 198 |
| The String literal "boolean" appears 6 times in this file; the first occurrence is on line 207 | 207 |
| The String literal "false" appears 5 times in this file; the first occurrence is on line 207 | 207 |
| Parameter 'required' is not assigned and could be declared final | 208 |
| Parameter 'value' is not assigned and could be declared final | 217 |
| Parameter 'valueChangeListener' is not assigned and could be declared final | 232 |
| Parameter 'disabled' is not assigned and could be declared final | 241 |
| Parameter 'readonly' is not assigned and could be declared final | 250 |
| Parameter 'onchange' is not assigned and could be declared final | 259 |
| Parameter 'inline' is not assigned and could be declared final | 268 |
| Parameter 'label' is not assigned and could be declared final | 278 |
| Parameter 'validator' is not assigned and could be declared final | 296 |
| Parameter 'converter' is not assigned and could be declared final | 312 |
| Parameter 'rendered' is not assigned and could be declared final | 322 |
| Parameter 'binding' is not assigned and could be declared final | 332 |
| Parameter 'tip' is not assigned and could be declared final | 341 |
| Parameter 'labelWidth' is not assigned and could be declared final | 352 |
| Parameter 'markup' is not assigned and could be declared final | 362 |
| Parameter 'tabIndex' is not assigned and could be declared final | 368 |
| Parameter 'focus' is not assigned and could be declared final | 377 |
| Parameter 'renderRange' is not assigned and could be declared final | 386 |
| Parameter 'validatorMessage' is not assigned and could be declared final | 395 |
| Parameter 'converterMessage' is not assigned and could be declared final | 404 |
| Parameter 'requiredMessage' is not assigned and could be declared final | 413 |
| Parameter 'fieldId' is not assigned and could be declared final | 423 |
| Parameter 'id' is not assigned and could be declared final | 435 |
org/apache/myfaces/tobago/internal/taglib/extension/SelectManyListboxExtensionTag.java
| Violation | Line |
|---|---|
| The class 'SelectManyListboxExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 25). | 38 - 419 |
| The class 'SelectManyListboxExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 25). | 38 - 419 |
| Too many fields | 38 - 419 |
| The method 'doStartTag' has a Cyclomatic Complexity of 25. | 66 - 154 |
| The method doStartTag() has an NPath complexity of 16777216 | 66 - 154 |
| The method 'doStartTag' has a Cyclomatic Complexity of 25. | 66 - 154 |
| Assigning an Object to null is a code smell. Consider refactoring. | 166 |
| Assigning an Object to null is a code smell. Consider refactoring. | 167 |
| Assigning an Object to null is a code smell. Consider refactoring. | 168 |
| Assigning an Object to null is a code smell. Consider refactoring. | 169 |
| Assigning an Object to null is a code smell. Consider refactoring. | 170 |
| Assigning an Object to null is a code smell. Consider refactoring. | 171 |
| Assigning an Object to null is a code smell. Consider refactoring. | 172 |
| Assigning an Object to null is a code smell. Consider refactoring. | 173 |
| Assigning an Object to null is a code smell. Consider refactoring. | 174 |
| Assigning an Object to null is a code smell. Consider refactoring. | 175 |
| Assigning an Object to null is a code smell. Consider refactoring. | 176 |
| Assigning an Object to null is a code smell. Consider refactoring. | 177 |
| Assigning an Object to null is a code smell. Consider refactoring. | 178 |
| Assigning an Object to null is a code smell. Consider refactoring. | 179 |
| Assigning an Object to null is a code smell. Consider refactoring. | 180 |
| Assigning an Object to null is a code smell. Consider refactoring. | 181 |
| Assigning an Object to null is a code smell. Consider refactoring. | 182 |
| Assigning an Object to null is a code smell. Consider refactoring. | 183 |
| Assigning an Object to null is a code smell. Consider refactoring. | 184 |
| Assigning an Object to null is a code smell. Consider refactoring. | 185 |
| Assigning an Object to null is a code smell. Consider refactoring. | 186 |
| Assigning an Object to null is a code smell. Consider refactoring. | 187 |
| Assigning an Object to null is a code smell. Consider refactoring. | 188 |
| The String literal "boolean" appears 6 times in this file; the first occurrence is on line 197 | 197 |
| The String literal "false" appears 5 times in this file; the first occurrence is on line 197 | 197 |
| Parameter 'required' is not assigned and could be declared final | 198 |
| Parameter 'value' is not assigned and could be declared final | 207 |
| Parameter 'valueChangeListener' is not assigned and could be declared final | 224 |
| Parameter 'disabled' is not assigned and could be declared final | 233 |
| Parameter 'readonly' is not assigned and could be declared final | 242 |
| Parameter 'onchange' is not assigned and could be declared final | 251 |
| Parameter 'inline' is not assigned and could be declared final | 262 |
| Parameter 'label' is not assigned and could be declared final | 272 |
| Parameter 'validator' is not assigned and could be declared final | 286 |
| Parameter 'converter' is not assigned and could be declared final | 302 |
| Parameter 'rendered' is not assigned and could be declared final | 312 |
| Parameter 'binding' is not assigned and could be declared final | 322 |
| Parameter 'tip' is not assigned and could be declared final | 331 |
| Parameter 'labelWidth' is not assigned and could be declared final | 342 |
| Parameter 'markup' is not assigned and could be declared final | 352 |
| Parameter 'tabIndex' is not assigned and could be declared final | 358 |
| Parameter 'focus' is not assigned and could be declared final | 367 |
| Parameter 'validatorMessage' is not assigned and could be declared final | 376 |
| Parameter 'converterMessage' is not assigned and could be declared final | 385 |
| Parameter 'requiredMessage' is not assigned and could be declared final | 394 |
| Parameter 'fieldId' is not assigned and could be declared final | 404 |
| Parameter 'id' is not assigned and could be declared final | 416 |
org/apache/myfaces/tobago/internal/taglib/extension/SelectManyShuttleExtensionTag.java
| Violation | Line |
|---|---|
| The class 'SelectManyShuttleExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 26). | 38 - 432 |
| The class 'SelectManyShuttleExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 26). | 38 - 432 |
| Too many fields | 38 - 432 |
| The method 'doStartTag' has a Cyclomatic Complexity of 26. | 67 - 158 |
| The method doStartTag() has an NPath complexity of 33554432 | 67 - 158 |
| The method 'doStartTag' has a Cyclomatic Complexity of 26. | 67 - 158 |
| Assigning an Object to null is a code smell. Consider refactoring. | 170 |
| Assigning an Object to null is a code smell. Consider refactoring. | 171 |
| Assigning an Object to null is a code smell. Consider refactoring. | 172 |
| Assigning an Object to null is a code smell. Consider refactoring. | 173 |
| Assigning an Object to null is a code smell. Consider refactoring. | 174 |
| Assigning an Object to null is a code smell. Consider refactoring. | 175 |
| Assigning an Object to null is a code smell. Consider refactoring. | 176 |
| Assigning an Object to null is a code smell. Consider refactoring. | 177 |
| Assigning an Object to null is a code smell. Consider refactoring. | 178 |
| Assigning an Object to null is a code smell. Consider refactoring. | 179 |
| Assigning an Object to null is a code smell. Consider refactoring. | 180 |
| Assigning an Object to null is a code smell. Consider refactoring. | 181 |
| Assigning an Object to null is a code smell. Consider refactoring. | 182 |
| Assigning an Object to null is a code smell. Consider refactoring. | 183 |
| Assigning an Object to null is a code smell. Consider refactoring. | 184 |
| Assigning an Object to null is a code smell. Consider refactoring. | 185 |
| Assigning an Object to null is a code smell. Consider refactoring. | 186 |
| Assigning an Object to null is a code smell. Consider refactoring. | 187 |
| Assigning an Object to null is a code smell. Consider refactoring. | 188 |
| Assigning an Object to null is a code smell. Consider refactoring. | 189 |
| Assigning an Object to null is a code smell. Consider refactoring. | 190 |
| Assigning an Object to null is a code smell. Consider refactoring. | 191 |
| Assigning an Object to null is a code smell. Consider refactoring. | 192 |
| Assigning an Object to null is a code smell. Consider refactoring. | 193 |
| Assigning an Object to null is a code smell. Consider refactoring. | 194 |
| The String literal "boolean" appears 5 times in this file; the first occurrence is on line 203 | 203 |
| The String literal "false" appears 4 times in this file; the first occurrence is on line 203 | 203 |
| Parameter 'required' is not assigned and could be declared final | 204 |
| Parameter 'value' is not assigned and could be declared final | 213 |
| Parameter 'valueChangeListener' is not assigned and could be declared final | 230 |
| Parameter 'disabled' is not assigned and could be declared final | 239 |
| Parameter 'readonly' is not assigned and could be declared final | 248 |
| Parameter 'onchange' is not assigned and could be declared final | 257 |
| Parameter 'label' is not assigned and could be declared final | 267 |
| Parameter 'unselectedLabel' is not assigned and could be declared final | 276 |
| Parameter 'selectedLabel' is not assigned and could be declared final | 285 |
| Parameter 'validator' is not assigned and could be declared final | 299 |
| Parameter 'converter' is not assigned and could be declared final | 315 |
| Parameter 'rendered' is not assigned and could be declared final | 325 |
| Parameter 'binding' is not assigned and could be declared final | 335 |
| Parameter 'tip' is not assigned and could be declared final | 344 |
| Parameter 'labelWidth' is not assigned and could be declared final | 355 |
| Parameter 'markup' is not assigned and could be declared final | 365 |
| Parameter 'tabIndex' is not assigned and could be declared final | 371 |
| Parameter 'focus' is not assigned and could be declared final | 380 |
| Parameter 'validatorMessage' is not assigned and could be declared final | 389 |
| Parameter 'converterMessage' is not assigned and could be declared final | 398 |
| Parameter 'requiredMessage' is not assigned and could be declared final | 407 |
| Parameter 'fieldId' is not assigned and could be declared final | 417 |
| Parameter 'id' is not assigned and could be declared final | 429 |
org/apache/myfaces/tobago/internal/taglib/extension/SelectOneChoiceExtensionTag.java
| Violation | Line |
|---|---|
| The class 'SelectOneChoiceExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 25). | 39 - 419 |
| The class 'SelectOneChoiceExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 25). | 39 - 419 |
| Too many fields | 39 - 419 |
| The method 'doStartTag' has a Cyclomatic Complexity of 25. | 67 - 154 |
| The method doStartTag() has an NPath complexity of 16777216 | 67 - 154 |
| The method 'doStartTag' has a Cyclomatic Complexity of 25. | 67 - 154 |
| Assigning an Object to null is a code smell. Consider refactoring. | 166 |
| Assigning an Object to null is a code smell. Consider refactoring. | 167 |
| Assigning an Object to null is a code smell. Consider refactoring. | 168 |
| Assigning an Object to null is a code smell. Consider refactoring. | 169 |
| Assigning an Object to null is a code smell. Consider refactoring. | 170 |
| Assigning an Object to null is a code smell. Consider refactoring. | 171 |
| Assigning an Object to null is a code smell. Consider refactoring. | 172 |
| Assigning an Object to null is a code smell. Consider refactoring. | 173 |
| Assigning an Object to null is a code smell. Consider refactoring. | 174 |
| Assigning an Object to null is a code smell. Consider refactoring. | 175 |
| Assigning an Object to null is a code smell. Consider refactoring. | 176 |
| Assigning an Object to null is a code smell. Consider refactoring. | 177 |
| Assigning an Object to null is a code smell. Consider refactoring. | 178 |
| Assigning an Object to null is a code smell. Consider refactoring. | 179 |
| Assigning an Object to null is a code smell. Consider refactoring. | 180 |
| Assigning an Object to null is a code smell. Consider refactoring. | 181 |
| Assigning an Object to null is a code smell. Consider refactoring. | 182 |
| Assigning an Object to null is a code smell. Consider refactoring. | 183 |
| Assigning an Object to null is a code smell. Consider refactoring. | 184 |
| Assigning an Object to null is a code smell. Consider refactoring. | 185 |
| Assigning an Object to null is a code smell. Consider refactoring. | 186 |
| Assigning an Object to null is a code smell. Consider refactoring. | 187 |
| Assigning an Object to null is a code smell. Consider refactoring. | 188 |
| The String literal "boolean" appears 6 times in this file; the first occurrence is on line 197 | 197 |
| The String literal "false" appears 5 times in this file; the first occurrence is on line 197 | 197 |
| Parameter 'required' is not assigned and could be declared final | 198 |
| Parameter 'value' is not assigned and could be declared final | 207 |
| Parameter 'valueChangeListener' is not assigned and could be declared final | 224 |
| Parameter 'validator' is not assigned and could be declared final | 238 |
| Parameter 'disabled' is not assigned and could be declared final | 247 |
| Parameter 'readonly' is not assigned and could be declared final | 256 |
| Parameter 'onchange' is not assigned and could be declared final | 265 |
| Parameter 'converter' is not assigned and could be declared final | 281 |
| Parameter 'inline' is not assigned and could be declared final | 292 |
| Parameter 'label' is not assigned and could be declared final | 302 |
| Parameter 'rendered' is not assigned and could be declared final | 312 |
| Parameter 'binding' is not assigned and could be declared final | 322 |
| Parameter 'tip' is not assigned and could be declared final | 331 |
| Parameter 'labelWidth' is not assigned and could be declared final | 342 |
| Parameter 'tabIndex' is not assigned and could be declared final | 348 |
| Parameter 'focus' is not assigned and could be declared final | 357 |
| Parameter 'markup' is not assigned and could be declared final | 367 |
| Parameter 'validatorMessage' is not assigned and could be declared final | 376 |
| Parameter 'converterMessage' is not assigned and could be declared final | 385 |
| Parameter 'requiredMessage' is not assigned and could be declared final | 394 |
| Parameter 'fieldId' is not assigned and could be declared final | 404 |
| Parameter 'id' is not assigned and could be declared final | 416 |
org/apache/myfaces/tobago/internal/taglib/extension/SelectOneListboxExtensionTag.java
| Violation | Line |
|---|---|
| The class 'SelectOneListboxExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 24). | 38 - 407 |
| The class 'SelectOneListboxExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 24). | 38 - 407 |
| Too many fields | 38 - 407 |
| The method 'doStartTag' has a Cyclomatic Complexity of 24. | 65 - 153 |
| The method doStartTag() has an NPath complexity of 8388608 | 65 - 153 |
| The method 'doStartTag' has a Cyclomatic Complexity of 24. | 65 - 153 |
| Assigning an Object to null is a code smell. Consider refactoring. | 165 |
| Assigning an Object to null is a code smell. Consider refactoring. | 166 |
| Assigning an Object to null is a code smell. Consider refactoring. | 167 |
| Assigning an Object to null is a code smell. Consider refactoring. | 169 |
| Assigning an Object to null is a code smell. Consider refactoring. | 170 |
| Assigning an Object to null is a code smell. Consider refactoring. | 171 |
| Assigning an Object to null is a code smell. Consider refactoring. | 172 |
| Assigning an Object to null is a code smell. Consider refactoring. | 173 |
| Assigning an Object to null is a code smell. Consider refactoring. | 174 |
| Assigning an Object to null is a code smell. Consider refactoring. | 175 |
| Assigning an Object to null is a code smell. Consider refactoring. | 176 |
| Assigning an Object to null is a code smell. Consider refactoring. | 177 |
| Assigning an Object to null is a code smell. Consider refactoring. | 178 |
| Assigning an Object to null is a code smell. Consider refactoring. | 179 |
| Assigning an Object to null is a code smell. Consider refactoring. | 180 |
| Assigning an Object to null is a code smell. Consider refactoring. | 181 |
| Assigning an Object to null is a code smell. Consider refactoring. | 182 |
| Assigning an Object to null is a code smell. Consider refactoring. | 183 |
| Assigning an Object to null is a code smell. Consider refactoring. | 184 |
| Assigning an Object to null is a code smell. Consider refactoring. | 185 |
| Assigning an Object to null is a code smell. Consider refactoring. | 186 |
| Assigning an Object to null is a code smell. Consider refactoring. | 187 |
| The String literal "boolean" appears 5 times in this file; the first occurrence is on line 196 | 196 |
| The String literal "false" appears 4 times in this file; the first occurrence is on line 196 | 196 |
| Parameter 'required' is not assigned and could be declared final | 197 |
| Parameter 'value' is not assigned and could be declared final | 206 |
| Parameter 'valueChangeListener' is not assigned and could be declared final | 223 |
| Parameter 'disabled' is not assigned and could be declared final | 232 |
| Parameter 'readonly' is not assigned and could be declared final | 241 |
| Parameter 'onchange' is not assigned and could be declared final | 250 |
| Parameter 'label' is not assigned and could be declared final | 260 |
| Parameter 'validator' is not assigned and could be declared final | 274 |
| Parameter 'converter' is not assigned and could be declared final | 290 |
| Parameter 'rendered' is not assigned and could be declared final | 300 |
| Parameter 'binding' is not assigned and could be declared final | 310 |
| Parameter 'tip' is not assigned and could be declared final | 319 |
| Parameter 'labelWidth' is not assigned and could be declared final | 330 |
| Parameter 'tabIndex' is not assigned and could be declared final | 336 |
| Parameter 'focus' is not assigned and could be declared final | 345 |
| Parameter 'validatorMessage' is not assigned and could be declared final | 354 |
| Parameter 'converterMessage' is not assigned and could be declared final | 363 |
| Parameter 'requiredMessage' is not assigned and could be declared final | 372 |
| Parameter 'markup' is not assigned and could be declared final | 382 |
| Parameter 'fieldId' is not assigned and could be declared final | 392 |
| Parameter 'id' is not assigned and could be declared final | 404 |
org/apache/myfaces/tobago/internal/taglib/extension/SelectOneRadioExtensionTag.java
| Violation | Line |
|---|---|
| The class 'SelectOneRadioExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 26). | 40 - 432 |
| The class 'SelectOneRadioExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 26). | 40 - 432 |
| Too many fields | 40 - 432 |
| The method 'doStartTag' has a Cyclomatic Complexity of 26. | 69 - 160 |
| The method doStartTag() has an NPath complexity of 33554432 | 69 - 160 |
| The method 'doStartTag' has a Cyclomatic Complexity of 26. | 69 - 160 |
| Assigning an Object to null is a code smell. Consider refactoring. | 172 |
| Assigning an Object to null is a code smell. Consider refactoring. | 173 |
| Assigning an Object to null is a code smell. Consider refactoring. | 174 |
| Assigning an Object to null is a code smell. Consider refactoring. | 175 |
| Assigning an Object to null is a code smell. Consider refactoring. | 176 |
| Assigning an Object to null is a code smell. Consider refactoring. | 177 |
| Assigning an Object to null is a code smell. Consider refactoring. | 178 |
| Assigning an Object to null is a code smell. Consider refactoring. | 179 |
| Assigning an Object to null is a code smell. Consider refactoring. | 180 |
| Assigning an Object to null is a code smell. Consider refactoring. | 181 |
| Assigning an Object to null is a code smell. Consider refactoring. | 182 |
| Assigning an Object to null is a code smell. Consider refactoring. | 183 |
| Assigning an Object to null is a code smell. Consider refactoring. | 184 |
| Assigning an Object to null is a code smell. Consider refactoring. | 185 |
| Assigning an Object to null is a code smell. Consider refactoring. | 186 |
| Assigning an Object to null is a code smell. Consider refactoring. | 187 |
| Assigning an Object to null is a code smell. Consider refactoring. | 188 |
| Assigning an Object to null is a code smell. Consider refactoring. | 189 |
| Assigning an Object to null is a code smell. Consider refactoring. | 190 |
| Assigning an Object to null is a code smell. Consider refactoring. | 191 |
| Assigning an Object to null is a code smell. Consider refactoring. | 192 |
| Assigning an Object to null is a code smell. Consider refactoring. | 193 |
| Assigning an Object to null is a code smell. Consider refactoring. | 194 |
| Assigning an Object to null is a code smell. Consider refactoring. | 195 |
| The String literal "boolean" appears 6 times in this file; the first occurrence is on line 204 | 204 |
| The String literal "false" appears 5 times in this file; the first occurrence is on line 204 | 204 |
| Parameter 'required' is not assigned and could be declared final | 205 |
| Parameter 'value' is not assigned and could be declared final | 214 |
| Parameter 'valueChangeListener' is not assigned and could be declared final | 231 |
| Parameter 'validator' is not assigned and could be declared final | 245 |
| Parameter 'disabled' is not assigned and could be declared final | 254 |
| Parameter 'readonly' is not assigned and could be declared final | 263 |
| Parameter 'onchange' is not assigned and could be declared final | 272 |
| Parameter 'converter' is not assigned and could be declared final | 288 |
| Parameter 'inline' is not assigned and could be declared final | 296 |
| Parameter 'label' is not assigned and could be declared final | 306 |
| Parameter 'rendered' is not assigned and could be declared final | 316 |
| Parameter 'binding' is not assigned and could be declared final | 326 |
| Parameter 'tip' is not assigned and could be declared final | 335 |
| Parameter 'labelWidth' is not assigned and could be declared final | 346 |
| Parameter 'tabIndex' is not assigned and could be declared final | 352 |
| Parameter 'focus' is not assigned and could be declared final | 361 |
| Parameter 'renderRange' is not assigned and could be declared final | 370 |
| Parameter 'validatorMessage' is not assigned and could be declared final | 379 |
| Parameter 'converterMessage' is not assigned and could be declared final | 388 |
| Parameter 'requiredMessage' is not assigned and could be declared final | 397 |
| Parameter 'markup' is not assigned and could be declared final | 407 |
| Parameter 'fieldId' is not assigned and could be declared final | 417 |
| Parameter 'id' is not assigned and could be declared final | 429 |
org/apache/myfaces/tobago/internal/taglib/extension/SeparatorExtensionTag.java
| Violation | Line |
|---|---|
| Assigning an Object to null is a code smell. Consider refactoring. | 102 |
| Assigning an Object to null is a code smell. Consider refactoring. | 103 |
| Assigning an Object to null is a code smell. Consider refactoring. | 104 |
| Assigning an Object to null is a code smell. Consider refactoring. | 105 |
| Assigning an Object to null is a code smell. Consider refactoring. | 106 |
| Assigning an Object to null is a code smell. Consider refactoring. | 107 |
| Parameter 'binding' is not assigned and could be declared final | 116 |
| Parameter 'rendered' is not assigned and could be declared final | 126 |
| Parameter 'label' is not assigned and could be declared final | 136 |
org/apache/myfaces/tobago/internal/taglib/extension/TextareaExtensionTag.java
| Violation | Line |
|---|---|
| The class 'TextareaExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 24). | 53 - 418 |
| The class 'TextareaExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 24). | 53 - 418 |
| Too many fields | 53 - 418 |
| The method 'doStartTag' has a Cyclomatic Complexity of 24. | 80 - 165 |
| The method doStartTag() has an NPath complexity of 8388608 | 80 - 165 |
| The method 'doStartTag' has a Cyclomatic Complexity of 24. | 80 - 165 |
| Assigning an Object to null is a code smell. Consider refactoring. | 177 |
| Assigning an Object to null is a code smell. Consider refactoring. | 178 |
| Assigning an Object to null is a code smell. Consider refactoring. | 179 |
| Assigning an Object to null is a code smell. Consider refactoring. | 180 |
| Assigning an Object to null is a code smell. Consider refactoring. | 181 |
| Assigning an Object to null is a code smell. Consider refactoring. | 182 |
| Assigning an Object to null is a code smell. Consider refactoring. | 183 |
| Assigning an Object to null is a code smell. Consider refactoring. | 184 |
| Assigning an Object to null is a code smell. Consider refactoring. | 185 |
| Assigning an Object to null is a code smell. Consider refactoring. | 186 |
| Assigning an Object to null is a code smell. Consider refactoring. | 187 |
| Assigning an Object to null is a code smell. Consider refactoring. | 188 |
| Assigning an Object to null is a code smell. Consider refactoring. | 189 |
| Assigning an Object to null is a code smell. Consider refactoring. | 190 |
| Assigning an Object to null is a code smell. Consider refactoring. | 191 |
| Assigning an Object to null is a code smell. Consider refactoring. | 192 |
| Assigning an Object to null is a code smell. Consider refactoring. | 193 |
| Assigning an Object to null is a code smell. Consider refactoring. | 194 |
| Assigning an Object to null is a code smell. Consider refactoring. | 195 |
| Assigning an Object to null is a code smell. Consider refactoring. | 196 |
| Assigning an Object to null is a code smell. Consider refactoring. | 197 |
| Assigning an Object to null is a code smell. Consider refactoring. | 198 |
| Parameter 'value' is not assigned and could be declared final | 206 |
| Parameter 'valueChangeListener' is not assigned and could be declared final | 223 |
| Parameter 'label' is not assigned and could be declared final | 233 |
| The String literal "boolean" appears 5 times in this file; the first occurrence is on line 241 | 241 |
| The String literal "false" appears 4 times in this file; the first occurrence is on line 241 | 241 |
| Parameter 'focus' is not assigned and could be declared final | 242 |
| Parameter 'binding' is not assigned and could be declared final | 252 |
| Parameter 'rendered' is not assigned and could be declared final | 262 |
| Parameter 'converter' is not assigned and could be declared final | 278 |
| Parameter 'validator' is not assigned and could be declared final | 292 |
| Parameter 'onchange' is not assigned and could be declared final | 301 |
| Parameter 'markup' is not assigned and could be declared final | 311 |
| Parameter 'readonly' is not assigned and could be declared final | 320 |
| Parameter 'disabled' is not assigned and could be declared final | 329 |
| Parameter 'required' is not assigned and could be declared final | 340 |
| Parameter 'tip' is not assigned and could be declared final | 349 |
| Parameter 'labelWidth' is not assigned and could be declared final | 360 |
| Parameter 'tabIndex' is not assigned and could be declared final | 366 |
| Parameter 'validatorMessage' is not assigned and could be declared final | 375 |
| Parameter 'converterMessage' is not assigned and could be declared final | 384 |
| Parameter 'requiredMessage' is not assigned and could be declared final | 393 |
| Parameter 'fieldId' is not assigned and could be declared final | 403 |
| Parameter 'id' is not assigned and could be declared final | 415 |
org/apache/myfaces/tobago/internal/taglib/extension/TimeExtensionTag.java
| Violation | Line |
|---|---|
| The class 'TimeExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 24). | 52 - 432 |
| The class 'TimeExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 24). | 52 - 432 |
| Too many fields | 52 - 432 |
| Avoid unused private fields such as 'converter'. | 55 |
| Avoid unused private fields such as 'converter'. | 55 |
| The method 'doStartTag' has a Cyclomatic Complexity of 24. | 80 - 167 |
| The method doStartTag() has an NPath complexity of 8388608 | 80 - 167 |
| The method 'doStartTag' has a Cyclomatic Complexity of 24. | 80 - 167 |
| Assigning an Object to null is a code smell. Consider refactoring. | 179 |
| Assigning an Object to null is a code smell. Consider refactoring. | 180 |
| Assigning an Object to null is a code smell. Consider refactoring. | 181 |
| Assigning an Object to null is a code smell. Consider refactoring. | 182 |
| Assigning an Object to null is a code smell. Consider refactoring. | 183 |
| Assigning an Object to null is a code smell. Consider refactoring. | 184 |
| Assigning an Object to null is a code smell. Consider refactoring. | 185 |
| Assigning an Object to null is a code smell. Consider refactoring. | 186 |
| Assigning an Object to null is a code smell. Consider refactoring. | 187 |
| Assigning an Object to null is a code smell. Consider refactoring. | 188 |
| Assigning an Object to null is a code smell. Consider refactoring. | 189 |
| Assigning an Object to null is a code smell. Consider refactoring. | 190 |
| Assigning an Object to null is a code smell. Consider refactoring. | 191 |
| Assigning an Object to null is a code smell. Consider refactoring. | 192 |
| Assigning an Object to null is a code smell. Consider refactoring. | 193 |
| Assigning an Object to null is a code smell. Consider refactoring. | 194 |
| Assigning an Object to null is a code smell. Consider refactoring. | 195 |
| Assigning an Object to null is a code smell. Consider refactoring. | 196 |
| Assigning an Object to null is a code smell. Consider refactoring. | 197 |
| Assigning an Object to null is a code smell. Consider refactoring. | 198 |
| Assigning an Object to null is a code smell. Consider refactoring. | 199 |
| Assigning an Object to null is a code smell. Consider refactoring. | 200 |
| Assigning an Object to null is a code smell. Consider refactoring. | 201 |
| Parameter 'markup' is not assigned and could be declared final | 210 |
| Parameter 'value' is not assigned and could be declared final | 219 |
| Parameter 'valueChangeListener' is not assigned and could be declared final | 236 |
| Parameter 'label' is not assigned and could be declared final | 246 |
| The String literal "boolean" appears 6 times in this file; the first occurrence is on line 254 | 254 |
| The String literal "false" appears 5 times in this file; the first occurrence is on line 254 | 254 |
| Parameter 'focus' is not assigned and could be declared final | 255 |
| Parameter 'binding' is not assigned and could be declared final | 265 |
| Parameter 'rendered' is not assigned and could be declared final | 275 |
| Parameter 'converter' is not assigned and could be declared final | 291 |
| Parameter 'validator' is not assigned and could be declared final | 305 |
| Parameter 'onchange' is not assigned and could be declared final | 314 |
| Parameter 'inline' is not assigned and could be declared final | 325 |
| Parameter 'readonly' is not assigned and could be declared final | 334 |
| Parameter 'disabled' is not assigned and could be declared final | 343 |
| Parameter 'required' is not assigned and could be declared final | 354 |
| Parameter 'tip' is not assigned and could be declared final | 363 |
| Parameter 'labelWidth' is not assigned and could be declared final | 374 |
| Parameter 'tabIndex' is not assigned and could be declared final | 380 |
| Parameter 'validatorMessage' is not assigned and could be declared final | 389 |
| Parameter 'converterMessage' is not assigned and could be declared final | 398 |
| Parameter 'requiredMessage' is not assigned and could be declared final | 407 |
| Parameter 'fieldId' is not assigned and could be declared final | 417 |
| Parameter 'id' is not assigned and could be declared final | 429 |
org/apache/myfaces/tobago/internal/taglib/extension/TobagoExtensionBodyTagSupport.java
| Violation | Line |
|---|---|
| Parameter 'expression' is not assigned and could be declared final | 34 |
| Parameter 'jspId' is not assigned and could be declared final | 39 |
| Assigning an Object to null is a code smell. Consider refactoring. | 49 |
org/apache/myfaces/tobago/internal/util/AccessKeyMap.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 27 - 91 |
| Private field 'set' could be made final; it is only initialized in the declaration or constructor. | 35 |
| Avoid using implementation types like 'HashSet'; use the interface instead | 35 |
| Avoid using implementation types like 'HashSet'; use the interface instead | 35 |
| Parameter 'facesContext' is not assigned and could be declared final | 39 |
| Avoid using implementation types like 'HashSet'; use the interface instead | 53 |
| Avoid using implementation types like 'HashSet'; use the interface instead | 53 |
| Parameter 'key' is not assigned and could be declared final | 61 |
| Avoid reassigning parameters such as 'key' | 65 |
| Parameter 'facesContext' is not assigned and could be declared final | 65 |
| Parameter 'facesContext' is not assigned and could be declared final | 77 |
| Parameter 'facesContext' is not assigned and could be declared final | 81 |
| Local variable 'set' could be declared final | 82 |
| Local variable 'sb' could be declared final | 83 |
org/apache/myfaces/tobago/internal/util/ComponentAttributeUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 28 - 71 |
| Parameter 'component' is not assigned and could be declared final | 33 |
| Parameter 'name' is not assigned and could be declared final | 33 |
| Parameter 'value' is not assigned and could be declared final | 33 |
| Parameter 'component' is not assigned and could be declared final | 43 |
| Parameter 'name' is not assigned and could be declared final | 43 |
| Parameter 'value' is not assigned and could be declared final | 43 |
| Parameter 'value' is not assigned and could be declared final | 53 |
| Local variable 'start' could be declared final | 55 |
| Local variable 'end' could be declared final | 59 |
| Parameter 'value' is not assigned and could be declared final | 67 |
org/apache/myfaces/tobago/internal/util/ContentType.java
| Violation | Line |
|---|---|
| Parameter 'contentType' is not assigned and could be declared final | 28 |
| Parameter 'contentType' is not assigned and could be declared final | 32 |
| Local variable 'values' could be declared final | 34 |
| Parameter 'contentType' is not assigned and could be declared final | 51 |
| Parameter 's' is not assigned and could be declared final | 60 |
org/apache/myfaces/tobago/internal/util/DateFormatUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 33 - 109 |
| The class 'DateFormatUtils' has a Cyclomatic Complexity of 4 (Highest = 6). | 33 - 109 |
| Parameter 'converter' is not assigned and could be declared final | 54 |
| Local variable 'dateFormat' could be declared final | 58 - 60 |
| Local variable 'format' could be declared final | 62 |
| Parameter 'dateStyle' is not assigned and could be declared final | 70 |
| Parameter 'locale' is not assigned and could be declared final | 70 |
| Parameter 'timeStyle' is not assigned and could be declared final | 70 |
| Parameter 'type' is not assigned and could be declared final | 70 |
| Parameter 'name' is not assigned and could be declared final | 89 |
| The method 'calcStyle' has a Cyclomatic Complexity of 6. | 89 - 107 |
org/apache/myfaces/tobago/internal/util/FacesContextUtils.java
| Violation | Line |
|---|---|
| This class has too many methods, consider refactoring it. | 33 - 280 |
| Parameter 'context' is not assigned and could be declared final | 53 |
| Parameter 'ajax' is not assigned and could be declared final | 57 |
| Parameter 'context' is not assigned and could be declared final | 57 |
| Parameter 'context' is not assigned and could be declared final | 61 |
| Parameter 'focusId' is not assigned and could be declared final | 61 |
| Parameter 'context' is not assigned and could be declared final | 65 |
| Parameter 'context' is not assigned and could be declared final | 69 |
| Parameter 'actionId' is not assigned and could be declared final | 69 |
| Parameter 'context' is not assigned and could be declared final | 73 |
| Parameter 'context' is not assigned and could be declared final | 78 |
| Parameter 'context' is not assigned and could be declared final | 82 |
| Parameter 'ajaxComponentId' is not assigned and could be declared final | 82 |
| Parameter 'context' is not assigned and could be declared final | 86 |
| Parameter 'enctype' is not assigned and could be declared final | 90 |
| Parameter 'context' is not assigned and could be declared final | 90 |
| Parameter 'context' is not assigned and could be declared final | 94 |
| Local variable 'list' could be declared final | 95 |
| Parameter 'file' is not assigned and could be declared final | 102 |
| Parameter 'context' is not assigned and could be declared final | 102 |
| Parameter 'context' is not assigned and could be declared final | 112 |
| Local variable 'set' could be declared final | 113 |
| Parameter 'context' is not assigned and could be declared final | 120 |
| Parameter 'script' is not assigned and could be declared final | 120 |
| Parameter 'context' is not assigned and could be declared final | 130 |
| Local variable 'set' could be declared final | 131 |
| Parameter 'context' is not assigned and could be declared final | 138 |
| Parameter 'script' is not assigned and could be declared final | 138 |
| Parameter 'context' is not assigned and could be declared final | 147 |
| Local variable 'set' could be declared final | 148 |
| Parameter 'context' is not assigned and could be declared final | 155 |
| Parameter 'script' is not assigned and could be declared final | 155 |
| Parameter 'context' is not assigned and could be declared final | 164 |
| Local variable 'list' could be declared final | 165 |
| Parameter 'file' is not assigned and could be declared final | 173 |
| Parameter 'context' is not assigned and could be declared final | 173 |
| Parameter 'position' is not assigned and could be declared final | 182 |
| Parameter 'file' is not assigned and could be declared final | 182 |
| Parameter 'context' is not assigned and could be declared final | 182 |
| Parameter 'context' is not assigned and could be declared final | 191 |
| Local variable 'set' could be declared final | 192 |
| Parameter 'context' is not assigned and could be declared final | 199 |
| Parameter 'script' is not assigned and could be declared final | 199 |
| Parameter 'context' is not assigned and could be declared final | 208 |
| Local variable 'set' could be declared final | 209 |
| Parameter 'context' is not assigned and could be declared final | 216 |
| Parameter 'script' is not assigned and could be declared final | 216 |
| Parameter 'context' is not assigned and could be declared final | 225 |
| Local variable 'set' could be declared final | 226 |
| Parameter 'context' is not assigned and could be declared final | 233 |
| Parameter 'script' is not assigned and could be declared final | 233 |
| Parameter 'context' is not assigned and could be declared final | 242 |
| Local variable 'set' could be declared final | 243 |
| Parameter 'context' is not assigned and could be declared final | 247 |
| Local variable 'set' could be declared final | 248 |
| Parameter 'context' is not assigned and could be declared final | 255 |
| Parameter 'script' is not assigned and could be declared final | 255 |
| Parameter 'context' is not assigned and could be declared final | 264 |
| Local variable 'set' could be declared final | 265 |
| Parameter 'popup' is not assigned and could be declared final | 272 |
| Parameter 'context' is not assigned and could be declared final | 272 |
org/apache/myfaces/tobago/internal/util/FastStringWriter.java
| Violation | Line |
|---|---|
| Parameter 'initialSize' is not assigned and could be declared final | 33 |
| Parameter 'c' is not assigned and could be declared final | 37 |
| Parameter 'cbuf' is not assigned and could be declared final | 41 |
| Parameter 'off' is not assigned and could be declared final | 41 |
| Parameter 'len' is not assigned and could be declared final | 41 |
| Parameter 'str' is not assigned and could be declared final | 45 |
| Parameter 'str' is not assigned and could be declared final | 49 |
| Parameter 'off' is not assigned and could be declared final | 49 |
| Parameter 'len' is not assigned and could be declared final | 49 |
org/apache/myfaces/tobago/internal/util/FindComponentUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 28 - 67 |
| The class 'FindComponentUtils' has a Cyclomatic Complexity of 6 (Highest = 10). | 28 - 67 |
| The class 'FindComponentUtils' has a Cyclomatic Complexity of 6 (Highest = 10). | 28 - 67 |
| Avoid reassigning parameters such as 'relativeId' | 33 |
| Avoid reassigning parameters such as 'from' | 33 |
| The method 'findComponent' has a Cyclomatic Complexity of 10. | 33 - 66 |
| The method 'findComponent' has a Cyclomatic Complexity of 10. | 33 - 66 |
| Local variable 'idLength' could be declared final | 34 |
| These nested if statements could be combined | 36 - 38 |
| Position literals first in String comparisons | 36 |
| These nested if statements could be combined | 36 - 38 |
org/apache/myfaces/tobago/internal/util/HtmlWriterUtils.java
| Violation | Line |
|---|---|
| The class 'HtmlWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). | 25 - 122 |
| The class 'HtmlWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). | 25 - 122 |
| The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. | 60 - 121 |
| The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. | 60 - 121 |
| Local variable 'ch' could be declared final | 67 |
| Avoid if (x != y) ..; else ..; | 93 - 97 |
| Local variable 'chars' could be declared final | 105 |
org/apache/myfaces/tobago/internal/util/JavascriptWriterUtils.java
| Violation | Line |
|---|---|
| The class 'JavascriptWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). | 25 - 120 |
| The class 'JavascriptWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). | 25 - 120 |
| The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. | 58 - 119 |
| The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. | 58 - 119 |
| Local variable 'ch' could be declared final | 65 |
| Avoid if (x != y) ..; else ..; | 91 - 95 |
| Local variable 'chars' could be declared final | 103 |
org/apache/myfaces/tobago/internal/util/JndiUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 30 - 77 |
| The class 'JndiUtils' has a Cyclomatic Complexity of 3 (Highest = 5). | 30 - 77 |
| Parameter 'ctx' is not assigned and could be declared final | 37 |
| Parameter 'path' is not assigned and could be declared final | 37 |
| Parameter 'ctx' is not assigned and could be declared final | 41 |
| Parameter 'path' is not assigned and could be declared final | 41 |
| Parameter 'defaultValue' is not assigned and could be declared final | 41 |
| The method 'getJndiProperty' has a Cyclomatic Complexity of 5. | 41 - 60 |
| Local variable 'b' could be declared final | 45 |
| Local variable 'obj' could be declared final | 50 |
| Prefer StringBuffer over += for concatenating strings | 56 |
| Parameter 'name' is not assigned and could be declared final | 62 |
| Parameter 'ctx' is not assigned and could be declared final | 62 |
| Parameter 'path' is not assigned and could be declared final | 62 |
| Local variable 'ne' could be declared final | 64 |
| Local variable 'b' could be declared final | 66 |
org/apache/myfaces/tobago/internal/util/JsonWriterUtils.java
| Violation | Line |
|---|---|
| The class 'JsonWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). | 26 - 124 |
| The class 'JsonWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). | 26 - 124 |
| The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. | 62 - 123 |
| The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. | 62 - 123 |
| Local variable 'ch' could be declared final | 69 |
| Avoid if (x != y) ..; else ..; | 95 - 99 |
| Local variable 'chars' could be declared final | 107 |
org/apache/myfaces/tobago/internal/util/MimeTypeUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 22 - 47 |
| The class 'MimeTypeUtils' has a Cyclomatic Complexity of 6 (Highest = 9). | 22 - 47 |
| Parameter 'file' is not assigned and could be declared final | 29 |
| The method 'getMimeTypeForFile' has a Cyclomatic Complexity of 9. | 29 - 46 |
org/apache/myfaces/tobago/internal/util/ResponseUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 32 - 110 |
| The class 'ResponseUtils' has a Cyclomatic Complexity of 3 (Highest = 7). | 32 - 110 |
| Parameter 'facesContext' is not assigned and could be declared final | 40 |
| Local variable 'externalContext' could be declared final | 42 |
| Local variable 'response' could be declared final | 44 |
| Parameter 'response' is not assigned and could be declared final | 49 |
| Parameter 'facesContext' is not assigned and could be declared final | 56 |
| Parameter 'contentType' is not assigned and could be declared final | 56 |
| Local variable 'response' could be declared final | 59 |
| Parameter 'response' is not assigned and could be declared final | 64 |
| Parameter 'contentType' is not assigned and could be declared final | 64 |
| Avoid if (x != y) ..; else ..; | 65 - 76 |
| Local variable 'responseContentType' could be declared final | 68 |
| The method 'ensureContentSecurityPolicyHeader' has a Cyclomatic Complexity of 7. | 79 - 109 |
| Parameter 'contentSecurityPolicy' is not assigned and could be declared final | 80 |
| Parameter 'facesContext' is not assigned and could be declared final | 80 |
| Local variable 'value' could be declared final | 103 |
org/apache/myfaces/tobago/internal/util/StringUtils.java
| Violation | Line |
|---|---|
| The class 'StringUtils' has a Cyclomatic Complexity of 5 (Highest = 14). | 27 - 165 |
| The class 'StringUtils' has a Cyclomatic Complexity of 5 (Highest = 14). | 27 - 165 |
| Parameter 'integerList' is not assigned and could be declared final | 33 |
| Parameter 'delimiters' is not assigned and could be declared final | 37 |
| Parameter 'integerList' is not assigned and could be declared final | 37 |
| Local variable 'list' could be declared final | 38 |
| Local variable 'tokenizer' could be declared final | 40 |
| Local variable 'token' could be declared final | 42 |
| Avoid instantiating new objects inside loops | 44 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 44 |
| Parameter 'list' is not assigned and could be declared final | 51 |
| Local variable 'buffer' could be declared final | 52 |
| Parameter 'list' is not assigned and could be declared final | 60 |
| The method 'getIndices' has a Cyclomatic Complexity of 7. | 60 - 88 |
| Local variable 'indexList' could be declared final | 61 |
| Local variable 'st' could be declared final | 62 |
| Local variable 'token' could be declared final | 64 |
| Local variable 'idx' could be declared final | 65 |
| Local variable 'start' could be declared final | 69 |
| Local variable 'end' could be declared final | 70 |
| Parameter 'constant' is not assigned and could be declared final | 90 |
| The method 'equalsIgnoreCaseAndWhitespace' has a Cyclomatic Complexity of 14. | 110 - 164 |
| The method equalsIgnoreCaseAndWhitespace() has an NPath complexity of 378 | 110 - 164 |
| The method 'equalsIgnoreCaseAndWhitespace' has a Cyclomatic Complexity of 14. | 110 - 164 |
| Use equals() to compare object references. | 113 |
org/apache/myfaces/tobago/internal/webapp/DebugContentTypeFilter.java
| Violation | Line |
|---|---|
| Parameter 'filterConfig' is not assigned and could be declared final | 37 |
| Parameter 'response' is not assigned and could be declared final | 43 |
| Parameter 'chain' is not assigned and could be declared final | 43 |
| Parameter 'request' is not assigned and could be declared final | 43 |
| Document empty method | 58 - 60 |
org/apache/myfaces/tobago/internal/webapp/DebugContentTypeResponse.java
| Violation | Line |
|---|---|
| Parameter 'response' is not assigned and could be declared final | 31 |
| Parameter 'type' is not assigned and could be declared final | 36 |
| Local variable 'type' could be declared final | 45 |
| Parameter 'name' is not assigned and could be declared final | 53 |
| Parameter 'value' is not assigned and could be declared final | 53 |
| These nested if statements could be combined | 55 - 57 |
| These nested if statements could be combined | 55 - 57 |
| Parameter 'name' is not assigned and could be declared final | 63 |
| Parameter 'value' is not assigned and could be declared final | 63 |
| These nested if statements could be combined | 65 - 67 |
| These nested if statements could be combined | 65 - 67 |
org/apache/myfaces/tobago/internal/webapp/DebugResponseWriterWrapper.java
| Violation | Line |
|---|---|
| This class has too many methods, consider refactoring it. | 37 - 176 |
| Private field 'stack' could be made final; it is only initialized in the declaration or constructor. | 39 |
| Parameter 'responseWriter' is not assigned and could be declared final | 45 |
| Parameter 'string' is not assigned and could be declared final | 49 |
| Parameter 'comment' is not assigned and could be declared final | 53 |
| Parameter 'writer' is not assigned and could be declared final | 64 |
| Parameter 'name' is not assigned and could be declared final | 69 |
| Parameter 'value' is not assigned and could be declared final | 69 |
| Parameter 'property' is not assigned and could be declared final | 69 |
| Parameter 'text' is not assigned and could be declared final | 74 |
| Parameter 'property' is not assigned and could be declared final | 74 |
| Parameter 'name' is not assigned and could be declared final | 82 |
| Parameter 'value' is not assigned and could be declared final | 82 |
| Parameter 'escape' is not assigned and could be declared final | 82 |
| Parameter 'script' is not assigned and could be declared final | 118 |
| Parameter 'name' is not assigned and could be declared final | 132 |
| Parameter 'value' is not assigned and could be declared final | 132 |
| Parameter 'property' is not assigned and could be declared final | 132 |
| Parameter 'text' is not assigned and could be declared final | 136 |
| Parameter 'off' is not assigned and could be declared final | 136 |
| Parameter 'len' is not assigned and could be declared final | 136 |
| Parameter 'chars' is not assigned and could be declared final | 140 |
| Parameter 'i' is not assigned and could be declared final | 140 |
| Parameter 'i1' is not assigned and could be declared final | 140 |
| Parameter 'name' is not assigned and could be declared final | 149 |
| Parameter 'currentComponent' is not assigned and could be declared final | 149 |
| Parameter 'name' is not assigned and could be declared final | 159 |
org/apache/myfaces/tobago/internal/webapp/HtmlResponseWriter.java
| Violation | Line |
|---|---|
| This class has too many methods, consider refactoring it. | 39 - 171 |
| Private field 'javascriptWriter' could be made final; it is only initialized in the declaration or constructor. | 45 |
| Parameter 'contentType' is not assigned and could be declared final | 49 |
| Parameter 'writer' is not assigned and could be declared final | 49 |
| Parameter 'characterEncoding' is not assigned and could be declared final | 49 |
| Parameter 'string' is not assigned and could be declared final | 70 |
| Parameter 'script' is not assigned and could be declared final | 79 |
| Avoid empty if statements | 107 - 109 |
| Avoid empty if statements | 107 - 109 |
| Parameter 'value' is not assigned and could be declared final | 120 |
| Parameter 'escape' is not assigned and could be declared final | 120 |
| Avoid reassigning parameters such as 'styles' | 137 |
| Parameter 'component' is not assigned and could be declared final | 137 |
| Parameter 'name' is not assigned and could be declared final | 153 |
| Local variable 'javascript' could be declared final | 155 |
org/apache/myfaces/tobago/internal/webapp/JsonResponseWriter.java
| Violation | Line |
|---|---|
| The class 'JsonResponseWriter' has a Cyclomatic Complexity of 2 (Highest = 5). | 34 - 190 |
| This class has too many methods, consider refactoring it. | 34 - 190 |
| Private field 'javascriptWriter' could be made final; it is only initialized in the declaration or constructor. | 38 |
| Private field 'encodeInJavascriptBlock' could be made final; it is only initialized in the declaration or constructor. | 40 |
| Private field 'encodeOutsideJavascriptBlock' could be made final; it is only initialized in the declaration or constructor. | 41 |
| Parameter 'contentType' is not assigned and could be declared final | 43 |
| Parameter 'writer' is not assigned and could be declared final | 43 |
| Parameter 'characterEncoding' is not assigned and could be declared final | 43 |
| Parameter 'string' is not assigned and could be declared final | 61 |
| The method 'write' has a Cyclomatic Complexity of 5. | 61 - 72 |
| Parameter 'chars' is not assigned and could be declared final | 75 |
| Local variable 'stackTraceElements' could be declared final | 81 |
| Parameter 'script' is not assigned and could be declared final | 91 |
| Parameter 'name' is not assigned and could be declared final | 101 |
| Parameter 'writer' is not assigned and could be declared final | 101 |
| Parameter 'currentComponent' is not assigned and could be declared final | 101 |
| Parameter 'name' is not assigned and could be declared final | 113 |
| Parameter 'writer' is not assigned and could be declared final | 113 |
| Parameter 'name' is not assigned and could be declared final | 136 |
| Parameter 'value' is not assigned and could be declared final | 136 |
| Parameter 'writer' is not assigned and could be declared final | 136 |
| Parameter 'escape' is not assigned and could be declared final | 136 |
| Local variable 'trace' could be declared final | 139 |
| Local variable 'error' could be declared final | 140 - 143 |
| Local variable 'value' could be declared final | 165 |
| Document empty method | 184 - 185 |
| Document empty method | 188 - 189 |
org/apache/myfaces/tobago/internal/webapp/TobagoMultipartFormdataRequest.java
| Violation | Line |
|---|---|
| The class 'TobagoMultipartFormdataRequest' has a Cyclomatic Complexity of 3 (Highest = 13). | 43 - 199 |
| The class 'TobagoMultipartFormdataRequest' has a Cyclomatic Complexity of 3 (Highest = 13). | 43 - 199 |
| Parameter 'request' is not assigned and could be declared final | 55 |
| Parameter 'request' is not assigned and could be declared final | 59 |
| Parameter 'repositoryPath' is not assigned and could be declared final | 59 |
| Parameter 'maxSize' is not assigned and could be declared final | 59 |
| Parameter 'request' is not assigned and could be declared final | 64 |
| Parameter 'repositoryPath' is not assigned and could be declared final | 64 |
| Parameter 'maxSize' is not assigned and could be declared final | 64 |
| The method 'init' has a Cyclomatic Complexity of 13. | 64 - 133 |
| The method init() has an NPath complexity of 401 | 64 - 133 |
| The method 'init' has a Cyclomatic Complexity of 13. | 64 - 133 |
| Avoid if (x != y) ..; else ..; | 65 - 132 |
| Local variable 'errorText' could be declared final | 66 |
| Local variable 'factory' could be declared final | 72 |
| Local variable 'upload' could be declared final | 76 |
| Local variable 'key' could be declared final | 95 |
| Local variable 'e' could be declared final | 121 |
| Parameter 'newValue' is not assigned and could be declared final | 135 |
| Parameter 'key' is not assigned and could be declared final | 135 |
| Parameter 'key' is not assigned and could be declared final | 148 |
| Parameter 'key' is not assigned and could be declared final | 155 |
| Local variable 'values' could be declared final | 157 |
| Parameter 'key' is not assigned and could be declared final | 168 |
| Parameter 'param' is not assigned and could be declared final | 176 |
| The method 'getMaxSize' has a Cyclomatic Complexity of 6. | 176 - 198 |
org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterBase.java
| Violation | Line |
|---|---|
| The class 'TobagoResponseWriterBase' has a Cyclomatic Complexity of 2 (Highest = 7). | 36 - 328 |
| This class has too many methods, consider refactoring it. | 36 - 328 |
| Parameter 'contentType' is not assigned and could be declared final | 72 |
| Parameter 'writer' is not assigned and could be declared final | 72 |
| Parameter 'characterEncoding' is not assigned and could be declared final | 72 |
| Avoid if (x != y) ..; else ..; | 75 |
| Parameter 'component' is not assigned and could be declared final | 86 |
| Parameter 'startStillOpen' is not assigned and could be declared final | 94 |
| The method 'findValue' has a Cyclomatic Complexity of 7. | 98 - 127 |
| Avoid if (x != y) ..; else ..; | 99 - 126 |
| Avoid if (x != y) ..; else ..; | 101 - 126 |
| Avoid if (x != y) ..; else ..; | 102 - 117 |
| Avoid if (x != y) ..; else ..; | 104 - 108 |
| Parameter 'string' is not assigned and could be declared final | 135 |
| Parameter 'string' is not assigned and could be declared final | 139 |
| Parameter 'writer' is not assigned and could be declared final | 139 |
| Parameter 'i' is not assigned and could be declared final | 145 |
| Parameter 'chars' is not assigned and could be declared final | 151 |
| Parameter 'string' is not assigned and could be declared final | 157 |
| Parameter 'i' is not assigned and could be declared final | 157 |
| Parameter 'i1' is not assigned and could be declared final | 157 |
| An empty method in an abstract class should be abstract instead | 189 - 191 |
| An empty method in an abstract class should be abstract instead | 193 - 195 |
| Parameter 'name' is not assigned and could be declared final | 210 |
| Parameter 'writer' is not assigned and could be declared final | 210 |
| Parameter 'currentComponent' is not assigned and could be declared final | 210 |
| Local variable 'comment' could be declared final | 228 |
| Parameter 'name' is not assigned and could be declared final | 289 |
| Parameter 'writer' is not assigned and could be declared final | 289 |
| Parameter 'name' is not assigned and could be declared final | 305 |
| Parameter 'value' is not assigned and could be declared final | 305 |
| Parameter 'writer' is not assigned and could be declared final | 305 |
| Parameter 'escape' is not assigned and could be declared final | 305 |
| Local variable 'trace' could be declared final | 308 |
| Local variable 'error' could be declared final | 309 - 312 |
org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterWrapper.java
| Violation | Line |
|---|---|
| This class has too many methods, consider refactoring it. | 32 - 125 |
| Private field 'responseWriter' could be made final; it is only initialized in the declaration or constructor. | 34 |
| Parameter 'responseWriter' is not assigned and could be declared final | 36 |
| Parameter 'component' is not assigned and could be declared final | 40 |
| Parameter 'name' is not assigned and could be declared final | 40 |
| Parameter 'name' is not assigned and could be declared final | 44 |
| Parameter 'string' is not assigned and could be declared final | 49 |
| Parameter 'comment' is not assigned and could be declared final | 53 |
| Parameter 'writer' is not assigned and could be declared final | 57 |
| Parameter 'name' is not assigned and could be declared final | 62 |
| Parameter 'value' is not assigned and could be declared final | 62 |
| Parameter 'property' is not assigned and could be declared final | 62 |
| Parameter 'text' is not assigned and could be declared final | 67 |
| Parameter 'property' is not assigned and could be declared final | 67 |
| Parameter 'name' is not assigned and could be declared final | 75 |
| Parameter 'value' is not assigned and could be declared final | 75 |
| Parameter 'escape' is not assigned and could be declared final | 75 |
| Parameter 'name' is not assigned and could be declared final | 110 |
| Parameter 'value' is not assigned and could be declared final | 110 |
| Parameter 'property' is not assigned and could be declared final | 110 |
| Parameter 'text' is not assigned and could be declared final | 114 |
| Parameter 'off' is not assigned and could be declared final | 114 |
| Parameter 'len' is not assigned and could be declared final | 114 |
| Parameter 'chars' is not assigned and could be declared final | 118 |
| Parameter 'i' is not assigned and could be declared final | 118 |
| Parameter 'i1' is not assigned and could be declared final | 118 |
org/apache/myfaces/tobago/internal/webapp/XmlResponseWriter.java
| Violation | Line |
|---|---|
| Parameter 'contentType' is not assigned and could be declared final | 38 |
| Parameter 'writer' is not assigned and could be declared final | 38 |
| Parameter 'characterEncoding' is not assigned and could be declared final | 38 |
| Avoid empty if statements | 58 - 60 |
| Avoid empty if statements | 58 - 60 |
| Parameter 'value' is not assigned and could be declared final | 76 |
| Parameter 'escape' is not assigned and could be declared final | 76 |
org/apache/myfaces/tobago/layout/Box.java
| Violation | Line |
|---|---|
| Parameter 'position' is not assigned and could be declared final | 27 |
| Parameter 'dimension' is not assigned and could be declared final | 27 |
| Parameter 'string' is not assigned and could be declared final | 32 |
| Parameter 'left' is not assigned and could be declared final | 63 |
| Parameter 'top' is not assigned and could be declared final | 71 |
| Parameter 'width' is not assigned and could be declared final | 79 |
| Parameter 'height' is not assigned and could be declared final | 87 |
org/apache/myfaces/tobago/layout/Dimension.java
| Violation | Line |
|---|---|
| Parameter 'height' is not assigned and could be declared final | 27 |
| Parameter 'width' is not assigned and could be declared final | 27 |
| Parameter 'string' is not assigned and could be declared final | 32 |
| Local variable 'comma' could be declared final | 33 |
| Parameter 'width' is not assigned and could be declared final | 46 |
| Parameter 'height' is not assigned and could be declared final | 54 |
org/apache/myfaces/tobago/layout/Display.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 30 |
org/apache/myfaces/tobago/layout/LayoutTokens.java
| Violation | Line |
|---|---|
| The class 'LayoutTokens' has a Cyclomatic Complexity of 2 (Highest = 10). | 31 - 171 |
| This class has too many methods, consider refactoring it. | 31 - 171 |
| The class 'LayoutTokens' has a Cyclomatic Complexity of 2 (Highest = 10). | 31 - 171 |
| Private field 'tokens' could be made final; it is only initialized in the declaration or constructor. | 35 |
| Document empty constructor | 37 - 38 |
| Avoid unnecessary constructors - the compiler will generate these for you | 37 - 38 |
| Parameter 'index' is not assigned and could be declared final | 44 |
| Parameter 'token' is not assigned and could be declared final | 44 |
| Parameter 'index' is not assigned and could be declared final | 52 |
| Parameter 'size' is not assigned and could be declared final | 56 |
| Parameter 'token' is not assigned and could be declared final | 62 |
| Parameter 'size' is not assigned and could be declared final | 62 |
| Parameter 'token' is not assigned and could be declared final | 68 |
| Parameter 'tokens' is not assigned and could be declared final | 80 |
| Local variable 'layoutTokens' could be declared final | 81 |
| Parameter 'tokens' is not assigned and could be declared final | 88 |
| Parameter 'defaultToken' is not assigned and could be declared final | 92 |
| Parameter 'tokens' is not assigned and could be declared final | 92 |
| Local variable 'layoutTokens' could be declared final | 93 |
| Local variable 'tokenizer' could be declared final | 98 |
| Local variable 'token' could be declared final | 101 |
| Parameter 'layoutTokens' is not assigned and could be declared final | 107 |
| Parameter 'token' is not assigned and could be declared final | 107 |
| Local variable 'layoutToken' could be declared final | 108 |
| Parameter 'token' is not assigned and could be declared final | 114 |
| The method 'parseToken' has a Cyclomatic Complexity of 10. | 114 - 139 |
| The method 'parseToken' has a Cyclomatic Complexity of 10. | 114 - 139 |
| Parameter 'token' is not assigned and could be declared final | 141 |
| Parameter 'token' is not assigned and could be declared final | 145 |
| Parameter 'token' is not assigned and could be declared final | 149 |
| Parameter 'token' is not assigned and could be declared final | 153 |
| Parameter 'suffix' is not assigned and could be declared final | 153 |
| Parameter 'token' is not assigned and could be declared final | 158 |
| Parameter 'suffix' is not assigned and could be declared final | 158 |
| Local variable 'str' could be declared final | 163 |
org/apache/myfaces/tobago/layout/Measure.java
| Violation | Line |
|---|---|
| The class 'Measure' has a Cyclomatic Complexity of 2 (Highest = 5). | 32 - 196 |
| This class has too many methods, consider refactoring it. | 32 - 196 |
| Avoid unused private fields such as 'LOG'. | 36 |
| Avoid unused private fields such as 'LOG'. | 36 |
| Parameter 'value' is not assigned and could be declared final | 43 |
| Parameter 'value' is not assigned and could be declared final | 50 |
| Parameter 'value' is not assigned and could be declared final | 54 |
| Parameter 'value' is not assigned and could be declared final | 61 |
| Parameter 'value' is not assigned and could be declared final | 68 |
| Parameter 'object' is not assigned and could be declared final | 83 |
| The method 'valueOf' has a Cyclomatic Complexity of 5. | 83 - 97 |
| Parameter 'value' is not assigned and could be declared final | 103 |
| Parameter 'm' is not assigned and could be declared final | 119 |
| Parameter 'measure' is not assigned and could be declared final | 129 |
| Parameter 'measure' is not assigned and could be declared final | 133 |
| Parameter 'measure' is not assigned and could be declared final | 137 |
| Parameter 'measure' is not assigned and could be declared final | 141 |
| Parameter 'list' is not assigned and could be declared final | 152 |
| Parameter 'list' is not assigned and could be declared final | 165 |
| Parameter 'm1' is not assigned and could be declared final | 178 |
| Parameter 'm2' is not assigned and could be declared final | 178 |
| Avoid if (x != y) ..; else ..; | 179 - 183 |
| Avoid if (x != y) ..; else ..; | 182 |
| Parameter 'm1' is not assigned and could be declared final | 189 |
| Parameter 'm2' is not assigned and could be declared final | 189 |
| Avoid if (x != y) ..; else ..; | 190 - 194 |
| Avoid if (x != y) ..; else ..; | 193 |
org/apache/myfaces/tobago/layout/MeasureEditor.java
| Violation | Line |
|---|---|
| Parameter 'text' is not assigned and could be declared final | 30 |
org/apache/myfaces/tobago/layout/PercentLayoutToken.java
| Violation | Line |
|---|---|
| The class 'PercentLayoutToken' has a Cyclomatic Complexity of 2 (Highest = 5). | 22 - 60 |
| Private field 'percent' could be made final; it is only initialized in the declaration or constructor. | 26 |
| Parameter 'percent' is not assigned and could be declared final | 28 |
| Parameter 'o' is not assigned and could be declared final | 40 |
| The method 'equals' has a Cyclomatic Complexity of 5. | 40 - 55 |
| Local variable 'that' could be declared final | 48 |
org/apache/myfaces/tobago/layout/PixelLayoutToken.java
| Violation | Line |
|---|---|
| The class 'PixelLayoutToken' has a Cyclomatic Complexity of 2 (Highest = 5). | 23 - 70 |
| Parameter 'pixel' is not assigned and could be declared final | 29 |
| Parameter 'pixel' is not assigned and could be declared final | 34 |
| Parameter 'o' is not assigned and could be declared final | 50 |
| The method 'equals' has a Cyclomatic Complexity of 5. | 50 - 65 |
| Local variable 'that' could be declared final | 58 |
org/apache/myfaces/tobago/layout/PixelMeasure.java
| Violation | Line |
|---|---|
| The class 'PixelMeasure' has a Cyclomatic Complexity of 2 (Highest = 5). | 25 - 131 |
| This class has too many methods, consider refactoring it. | 25 - 131 |
| Avoid instantiating new objects inside loops | 35 |
| Parameter 'pixel' is not assigned and could be declared final | 41 |
| Parameter 'value' is not assigned and could be declared final | 45 |
| Parameter 'm' is not assigned and could be declared final | 52 |
| Parameter 'm' is not assigned and could be declared final | 60 |
| Parameter 'times' is not assigned and could be declared final | 64 |
| Parameter 'times' is not assigned and could be declared final | 68 |
| Parameter 'm' is not assigned and could be declared final | 72 |
| Parameter 'm' is not assigned and could be declared final | 83 |
| Parameter 'm' is not assigned and could be declared final | 91 |
| Parameter 'o' is not assigned and could be declared final | 110 |
| The method 'equals' has a Cyclomatic Complexity of 5. | 110 - 125 |
| Local variable 'that' could be declared final | 118 |
org/apache/myfaces/tobago/layout/Position.java
| Violation | Line |
|---|---|
| Parameter 'left' is not assigned and could be declared final | 27 |
| Parameter 'top' is not assigned and could be declared final | 27 |
| Parameter 'string' is not assigned and could be declared final | 32 |
| Local variable 'comma' could be declared final | 33 |
| Parameter 'left' is not assigned and could be declared final | 46 |
| Parameter 'top' is not assigned and could be declared final | 54 |
org/apache/myfaces/tobago/layout/RelativeLayoutToken.java
| Violation | Line |
|---|---|
| The class 'RelativeLayoutToken' has a Cyclomatic Complexity of 2 (Highest = 5). | 22 - 63 |
| Private field 'factor' could be made final; it is only initialized in the declaration or constructor. | 29 |
| Parameter 'factor' is not assigned and could be declared final | 31 |
| Parameter 'o' is not assigned and could be declared final | 43 |
| The method 'equals' has a Cyclomatic Complexity of 5. | 43 - 58 |
| Local variable 'that' could be declared final | 51 |
org/apache/myfaces/tobago/layout/TextAlign.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 41 |
| Parameter 'string' is not assigned and could be declared final | 59 |
| Local variable 'value' could be declared final | 63 |
| Avoid if (x != y) ..; else ..; | 64 - 68 |
org/apache/myfaces/tobago/lifecycle/SecretPhaseListener.java
| Violation | Line |
|---|---|
| The class 'SecretPhaseListener' has a Cyclomatic Complexity of 3 (Highest = 5). | 32 - 54 |
| Parameter 'event' is not assigned and could be declared final | 36 |
| The method 'afterPhase' has a Cyclomatic Complexity of 5. | 36 - 46 |
| Document empty method | 48 - 49 |
| Parameter 'event' is not assigned and could be declared final | 48 |
org/apache/myfaces/tobago/model/AutoSuggestExtensionItem.java
| Violation | Line |
|---|---|
| Parameter 'id' is not assigned and could be declared final | 31 |
| Parameter 'value' is not assigned and could be declared final | 39 |
org/apache/myfaces/tobago/model/AutoSuggestItem.java
| Violation | Line |
|---|---|
| Parameter 'label' is not assigned and could be declared final | 36 |
| Parameter 'nextFocusId' is not assigned and could be declared final | 44 |
| Parameter 'extensionItems' is not assigned and could be declared final | 52 |
org/apache/myfaces/tobago/model/AutoSuggestItems.java
| Violation | Line |
|---|---|
| Parameter 'items' is not assigned and could be declared final | 37 |
| Parameter 'nextFocusId' is not assigned and could be declared final | 45 |
| Parameter 'maxSuggestedCount' is not assigned and could be declared final | 53 |
org/apache/myfaces/tobago/model/CalendarModel.java
| Violation | Line |
|---|---|
| Private field 'calendarArray' could be made final; it is only initialized in the declaration or constructor. | 28 |
| Private field 'firstDayOffset' could be made final; it is only initialized in the declaration or constructor. | 29 |
| Parameter 'calendar' is not assigned and could be declared final | 31 |
| Local variable 'weekCount' could be declared final | 33 |
| Local variable 'c' could be declared final | 35 |
| Avoid instantiating new objects inside loops | 43 |
| Parameter 'day' is not assigned and could be declared final | 61 |
| Parameter 'week' is not assigned and could be declared final | 61 |
| Parameter 'calendar' is not assigned and could be declared final | 65 |
| Local variable 'c' could be declared final | 66 |
| Local variable 'day' could be declared final | 69 |
| Local variable 'firstDayOfWeek' could be declared final | 70 |
| Local variable 'buffer' could be declared final | 76 |
| Local variable 'weekCount' could be declared final | 78 |
| Local variable 'format' could be declared final | 79 |
| When instantiating a SimpleDateFormat object, specify a Locale | 80 |
| Local variable 'dateFormat' could be declared final | 80 |
| Local variable 'date' could be declared final | 82 |
| Local variable 'dayName' could be declared final | 83 |
| Local variable 'date' could be declared final | 89 |
org/apache/myfaces/tobago/model/DateModel.java
| Violation | Line |
|---|---|
| Parameter 'month' is not assigned and could be declared final | 31 |
| Parameter 'year' is not assigned and could be declared final | 31 |
| Parameter 'day' is not assigned and could be declared final | 31 |
| Parameter 'calendar' is not assigned and could be declared final | 37 |
| Parameter 'year' is not assigned and could be declared final | 47 |
| Parameter 'month' is not assigned and could be declared final | 55 |
| Parameter 'day' is not assigned and could be declared final | 63 |
| Parameter 'locale' is not assigned and could be declared final | 71 |
| Avoid if (x != y) ..; else ..; | 72 - 73 |
| Local variable 'calendar' could be declared final | 72 - 73 |
org/apache/myfaces/tobago/model/ExpandedState.java
| Violation | Line |
|---|---|
| The class 'ExpandedState' has a Cyclomatic Complexity of 2 (Highest = 6). | 34 - 228 |
| This class has too many methods, consider refactoring it. | 34 - 228 |
| Private field 'expandedSet' could be made final; it is only initialized in the declaration or constructor. | 37 |
| Private field 'collapsedSet' could be made final; it is only initialized in the declaration or constructor. | 38 |
| Parameter 'defaultExpandedLevels' is not assigned and could be declared final | 45 |
| Parameter 'node' is not assigned and could be declared final | 57 |
| Parameter 'path' is not assigned and could be declared final | 68 |
| Parameter 'node' is not assigned and could be declared final | 83 |
| Parameter 'path' is not assigned and could be declared final | 93 |
| Parameter 'level' is not assigned and could be declared final | 106 |
| The method 'expand' has a Cyclomatic Complexity of 6. | 106 - 125 |
| Local variable 'toRemove' could be declared final | 107 |
| Parameter 'node' is not assigned and could be declared final | 141 |
| Parameter 'path' is not assigned and could be declared final | 151 |
| Avoid reassigning parameters such as 'level' | 164 |
| The method 'collapse' has a Cyclomatic Complexity of 6. | 164 - 186 |
| Local variable 'toRemove' could be declared final | 168 |
org/apache/myfaces/tobago/model/MixedTreeModel.java
| Violation | Line |
|---|---|
| The class 'MixedTreeModel' has a Cyclomatic Complexity of 2 (Highest = 6). | 33 - 98 |
| Private field 'junctions' could be made final; it is only initialized in the declaration or constructor. | 39 |
| Local variable 'newNode' could be declared final | 42 |
| The method 'onEncodeBegin' has a Cyclomatic Complexity of 6. | 56 - 82 |
| Local variable 'nextSibling' could be declared final | 71 |
| Assigning an Object to null is a code smell. Consider refactoring. | 79 |
| Local variable 'top' could be declared final | 89 |
| Local variable 'result' could be declared final | 90 |
org/apache/myfaces/tobago/model/Node.java
| Violation | Line |
|---|---|
| Parameter 'node' is not assigned and could be declared final | 36 |
| Parameter 'index' is not assigned and could be declared final | 53 |
| Parameter 'node' is not assigned and could be declared final | 62 |
| Local variable 'child' could be declared final | 64 |
| Assigning an Object to null is a code smell. Consider refactoring. | 85 |
| Local variable 'result' could be declared final | 89 |
| Local variable 'index' could be declared final | 93 |
| Parameter 'parent' is not assigned and could be declared final | 107 |
org/apache/myfaces/tobago/model/PageStateImpl.java
| Violation | Line |
|---|---|
| Parameter 'clientWidth' is not assigned and could be declared final | 36 |
| Parameter 'clientHeight' is not assigned and could be declared final | 44 |
org/apache/myfaces/tobago/model/SelectItem.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 37 |
| Parameter 'value' is not assigned and could be declared final | 41 |
| Parameter 'label' is not assigned and could be declared final | 41 |
| Parameter 'description' is not assigned and could be declared final | 45 |
| Parameter 'value' is not assigned and could be declared final | 45 |
| Parameter 'label' is not assigned and could be declared final | 45 |
| Parameter 'description' is not assigned and could be declared final | 49 |
| Parameter 'value' is not assigned and could be declared final | 49 |
| Parameter 'image' is not assigned and could be declared final | 49 |
| Parameter 'label' is not assigned and could be declared final | 49 |
| Parameter 'markup' is not assigned and could be declared final | 55 |
| Parameter 'description' is not assigned and could be declared final | 55 |
| Parameter 'value' is not assigned and could be declared final | 55 |
| Parameter 'image' is not assigned and could be declared final | 55 |
| Parameter 'label' is not assigned and could be declared final | 55 |
| Parameter 'markup' is not assigned and could be declared final | 59 |
| Parameter 'description' is not assigned and could be declared final | 59 |
| Parameter 'value' is not assigned and could be declared final | 59 |
| Parameter 'image' is not assigned and could be declared final | 59 |
| Parameter 'label' is not assigned and could be declared final | 59 |
| Parameter 'description' is not assigned and could be declared final | 63 |
| Parameter 'value' is not assigned and could be declared final | 63 |
| Parameter 'image' is not assigned and could be declared final | 63 |
| Parameter 'label' is not assigned and could be declared final | 63 |
| Parameter 'disabled' is not assigned and could be declared final | 63 |
| Parameter 'markup' is not assigned and could be declared final | 68 |
| Parameter 'description' is not assigned and could be declared final | 68 |
| Parameter 'value' is not assigned and could be declared final | 68 |
| Parameter 'image' is not assigned and could be declared final | 68 |
| Parameter 'label' is not assigned and could be declared final | 68 |
| Parameter 'disabled' is not assigned and could be declared final | 68 |
| Parameter 'markup' is not assigned and could be declared final | 72 |
| Parameter 'description' is not assigned and could be declared final | 72 |
| Parameter 'value' is not assigned and could be declared final | 72 |
| Parameter 'image' is not assigned and could be declared final | 72 |
| Parameter 'label' is not assigned and could be declared final | 72 |
| Parameter 'disabled' is not assigned and could be declared final | 72 |
| Parameter 'image' is not assigned and could be declared final | 82 |
| Parameter 'markup' is not assigned and could be declared final | 90 |
| Parameter 'currentMarkup' is not assigned and could be declared final | 98 |
org/apache/myfaces/tobago/model/Selectable.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 98 |
| Parameter 'name' is not assigned and could be declared final | 119 |
| Local variable 'value' could be declared final | 126 |
| Avoid if (x != y) ..; else ..; | 127 - 131 |
org/apache/myfaces/tobago/model/SelectedState.java
| Violation | Line |
|---|---|
| Private field 'selected' could be made final; it is only initialized in the declaration or constructor. | 32 |
| Parameter 'path' is not assigned and could be declared final | 37 |
| Parameter 'path' is not assigned and could be declared final | 44 |
| Parameter 'path' is not assigned and could be declared final | 51 |
| Parameter 'path' is not assigned and could be declared final | 59 |
| Parameter 'selected' is not assigned and could be declared final | 74 |
| Parameter 'path' is not assigned and could be declared final | 74 |
org/apache/myfaces/tobago/model/SheetState.java
| Violation | Line |
|---|---|
| Overridable method 'resetSelected' called during object construction | 50 |
| Parameter 'selectedRows' is not assigned and could be declared final | 61 |
| Parameter 'sortedColumnId' is not assigned and could be declared final | 70 |
| Parameter 'ascending' is not assigned and could be declared final | 78 |
| Parameter 'columnWidths' is not assigned and could be declared final | 86 |
| Parameter 'first' is not assigned and could be declared final | 94 |
| Parameter 'sortEvent' is not assigned and could be declared final | 98 |
| Local variable 'actualColumn' could be declared final | 100 |
| Parameter 'scrollPosition' is not assigned and could be declared final | 114 |
| Parameter 'expandedState' is not assigned and could be declared final | 125 |
| Parameter 'selectedState' is not assigned and could be declared final | 136 |
| Parameter 'value' is not assigned and could be declared final | 140 |
| Local variable 'sep' could be declared final | 143 |
| String.indexOf(char) is faster than String.indexOf(String). | 143 |
| Do not add empty strings | 145 |
| Local variable 'left' could be declared final | 150 |
| Local variable 'top' could be declared final | 151 |
org/apache/myfaces/tobago/model/SuggestFilter.java
| Violation | Line |
|---|---|
| Parameter 'string' is not assigned and could be declared final | 36 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 40 |
org/apache/myfaces/tobago/model/TreeNodeDataModel.java
| Violation | Line |
|---|---|
| The class 'TreeNodeDataModel' has a Cyclomatic Complexity of 2 (Highest = 8). | 37 - 300 |
| Private field 'mapping' could be made final; it is only initialized in the declaration or constructor. | 43 |
| Private field 'back' could be made final; it is only initialized in the declaration or constructor. | 44 |
| Private field 'showRoot' could be made final; it is only initialized in the declaration or constructor. | 45 |
| Parameter 'expandedState' is not assigned and could be declared final | 53 |
| Parameter 'showRoot' is not assigned and could be declared final | 53 |
| Parameter 'data' is not assigned and could be declared final | 53 |
| Overridable method 'reset' called during object construction | 59 |
| Avoid instantiation through private constructors from outside of the constructor's class. | 69 |
| Avoid instantiating new objects inside loops | 69 |
| Parameter 'expandedState' is not assigned and could be declared final | 82 |
| The method 'update' has a Cyclomatic Complexity of 5. | 82 - 101 |
| Avoid instantiation through private constructors from outside of the constructor's class. | 89 |
| Avoid instantiating new objects inside loops | 89 |
| Avoid reassigning parameters such as 'node' | 103 |
| Parameter 'node' is not assigned and could be declared final | 119 |
| Local variable 'parent' could be declared final | 120 |
| Parameter 'rowIndex' is not assigned and could be declared final | 184 |
| Parameter 'data' is not assigned and could be declared final | 189 |
| The method 'isRowVisible' has a Cyclomatic Complexity of 8. | 194 - 214 |
| Avoid instantiating new objects inside loops | 208 |
| Parameter 'clientId' is not assigned and could be declared final | 224 |
| Avoid if (x != y) ..; else ..; | 235 - 239 |
| Parameter 'node' is not assigned and could be declared final | 270 |
| Private field 'node' could be made final; it is only initialized in the declaration or constructor. | 281 |
| Parameter 'node' is not assigned and could be declared final | 284 |
| Parameter 'clientId' is not assigned and could be declared final | 296 |
org/apache/myfaces/tobago/model/TreePath.java
| Violation | Line |
|---|---|
| The class 'TreePath' has a Cyclomatic Complexity of 2 (Highest = 6). | 57 - 192 |
| Parameter 'path' is not assigned and could be declared final | 61 |
| Parameter 'pathList' is not assigned and could be declared final | 65 |
| Parameter 'position' is not assigned and could be declared final | 76 |
| Parameter 'addendum' is not assigned and could be declared final | 76 |
| Parameter 'string' is not assigned and could be declared final | 86 |
| Avoid reassigning parameters such as 'node' | 90 |
| The constructor 'TreePath' has a Cyclomatic Complexity of 6. | 90 - 113 |
| Local variable 'parent' could be declared final | 104 |
| Local variable 'child' could be declared final | 105 |
| Local variable 'builder' could be declared final | 127 |
| Local variable 'builder' could be declared final | 140 |
| Avoid reassigning parameters such as 'tree' | 156 |
| Local variable 'pos' could be declared final | 161 |
| Parameter 'o' is not assigned and could be declared final | 171 |
| Local variable 'nodeIndex' could be declared final | 178 |
| Avoid if (x != y) ..; else ..; | 185 |
org/apache/myfaces/tobago/model/TreeSelectable.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 45 |
| Parameter 'name' is not assigned and could be declared final | 68 |
| Local variable 'value' could be declared final | 69 |
| Avoid if (x != y) ..; else ..; | 70 - 74 |
org/apache/myfaces/tobago/model/TreeState.java
| Violation | Line |
|---|---|
| Private field 'expandedState' could be made final; it is only initialized in the declaration or constructor. | 26 |
| Private field 'selectedState' could be made final; it is only initialized in the declaration or constructor. | 27 |
| Parameter 'expandedState' is not assigned and could be declared final | 29 |
| Parameter 'selectedState' is not assigned and could be declared final | 29 |
org/apache/myfaces/tobago/model/Wizard.java
| Violation | Line |
|---|---|
| Overridable method 'reset' called during object construction | 38 |
| Parameter 'event' is not assigned and could be declared final | 41 |
| Parameter 'event' is not assigned and could be declared final | 47 |
| Local variable 'step' could be declared final | 48 |
| Local variable 'outcome' could be declared final | 59 |
| Parameter 'event' is not assigned and could be declared final | 74 |
| Parameter 'event' is not assigned and could be declared final | 82 |
org/apache/myfaces/tobago/model/WizardStep.java
| Violation | Line |
|---|---|
| Parameter 'index' is not assigned and could be declared final | 28 |
| Parameter 'outcome' is not assigned and could be declared final | 36 |
| Parameter 'title' is not assigned and could be declared final | 44 |
| Parameter 'index' is not assigned and could be declared final | 52 |
| Local variable 'builder' could be declared final | 57 |
org/apache/myfaces/tobago/portlet/PortletUtils.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 65 |
| Parameter 'facesContext' is not assigned and could be declared final | 79 |
| Parameter 'facesContext' is not assigned and could be declared final | 83 |
| Local variable 'request' could be declared final | 84 |
| Parameter 'facesContext' is not assigned and could be declared final | 91 |
| Parameter 'viewId' is not assigned and could be declared final | 91 |
| Local variable 'response' could be declared final | 92 |
| Local variable 'url' could be declared final | 93 |
| Parameter 'facesContext' is not assigned and could be declared final | 98 |
| Local variable 'request' could be declared final | 99 |
| Parameter 'session' is not assigned and could be declared final | 105 |
| Parameter 'name' is not assigned and could be declared final | 105 |
org/apache/myfaces/tobago/renderkit/AbstractAjaxRendererBaseWrapper.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 31 |
| Parameter 'context' is not assigned and could be declared final | 31 |
org/apache/myfaces/tobago/renderkit/AbstractLayoutRendererWrapper.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 31 |
| Parameter 'facesContext' is not assigned and could be declared final | 31 |
| Parameter 'component' is not assigned and could be declared final | 35 |
| Parameter 'facesContext' is not assigned and could be declared final | 35 |
| Parameter 'component' is not assigned and could be declared final | 39 |
| Parameter 'facesContext' is not assigned and could be declared final | 39 |
| Parameter 'component' is not assigned and could be declared final | 43 |
| Parameter 'facesContext' is not assigned and could be declared final | 43 |
| Parameter 'component' is not assigned and could be declared final | 47 |
| Parameter 'facesContext' is not assigned and could be declared final | 47 |
| Parameter 'component' is not assigned and could be declared final | 51 |
| Parameter 'facesContext' is not assigned and could be declared final | 51 |
org/apache/myfaces/tobago/renderkit/AbstractLayoutableRendererBaseWrapper.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 31 |
| Parameter 'facesContext' is not assigned and could be declared final | 31 |
| Parameter 'name' is not assigned and could be declared final | 31 |
| Parameter 'component' is not assigned and could be declared final | 35 |
| Parameter 'facesContext' is not assigned and could be declared final | 35 |
| Parameter 'component' is not assigned and could be declared final | 39 |
| Parameter 'facesContext' is not assigned and could be declared final | 39 |
| Parameter 'component' is not assigned and could be declared final | 43 |
| Parameter 'facesContext' is not assigned and could be declared final | 43 |
| Parameter 'component' is not assigned and could be declared final | 47 |
| Parameter 'facesContext' is not assigned and could be declared final | 47 |
| Parameter 'component' is not assigned and could be declared final | 51 |
| Parameter 'facesContext' is not assigned and could be declared final | 51 |
| Parameter 'component' is not assigned and could be declared final | 55 |
| Parameter 'facesContext' is not assigned and could be declared final | 55 |
| Parameter 'component' is not assigned and could be declared final | 59 |
| Parameter 'facesContext' is not assigned and could be declared final | 59 |
| Parameter 'component' is not assigned and could be declared final | 63 |
| Parameter 'facesContext' is not assigned and could be declared final | 63 |
| Parameter 'component' is not assigned and could be declared final | 67 |
| Parameter 'facesContext' is not assigned and could be declared final | 67 |
| Parameter 'component' is not assigned and could be declared final | 71 |
| Parameter 'facesContext' is not assigned and could be declared final | 71 |
| Parameter 'component' is not assigned and could be declared final | 75 |
| Parameter 'facesContext' is not assigned and could be declared final | 75 |
| Parameter 'component' is not assigned and could be declared final | 79 |
| Parameter 'facesContext' is not assigned and could be declared final | 79 |
| Parameter 'component' is not assigned and could be declared final | 83 |
| Parameter 'facesContext' is not assigned and could be declared final | 83 |
| Parameter 'component' is not assigned and could be declared final | 87 |
| Parameter 'facesContext' is not assigned and could be declared final | 87 |
| Parameter 'component' is not assigned and could be declared final | 91 |
| Parameter 'facesContext' is not assigned and could be declared final | 91 |
| Parameter 'component' is not assigned and could be declared final | 95 |
| Parameter 'facesContext' is not assigned and could be declared final | 95 |
| Parameter 'component' is not assigned and could be declared final | 99 |
| Parameter 'facesContext' is not assigned and could be declared final | 99 |
| Parameter 'component' is not assigned and could be declared final | 103 |
| Parameter 'facesContext' is not assigned and could be declared final | 103 |
| Parameter 'component' is not assigned and could be declared final | 107 |
| Parameter 'facesContext' is not assigned and could be declared final | 107 |
| Parameter 'component' is not assigned and could be declared final | 111 |
| Parameter 'facesContext' is not assigned and could be declared final | 111 |
| Parameter 'component' is not assigned and could be declared final | 115 |
| Parameter 'facesContext' is not assigned and could be declared final | 115 |
org/apache/myfaces/tobago/renderkit/AbstractRendererBaseWrapper.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 35 |
| Avoid unused private fields such as 'LOG'. | 35 |
| Parameter 'component' is not assigned and could be declared final | 38 |
| Parameter 'facesContext' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 38 |
| Parameter 'component' is not assigned and could be declared final | 43 |
| Parameter 'facesContext' is not assigned and could be declared final | 43 |
| Parameter 'component' is not assigned and could be declared final | 51 |
| Parameter 'context' is not assigned and could be declared final | 51 |
| Parameter 'component' is not assigned and could be declared final | 61 |
| Parameter 'facesContext' is not assigned and could be declared final | 61 |
| Parameter 'input' is not assigned and could be declared final | 66 |
| Parameter 'component' is not assigned and could be declared final | 71 |
| Parameter 'facesContext' is not assigned and could be declared final | 71 |
| Parameter 'component' is not assigned and could be declared final | 76 |
| Parameter 'component' is not assigned and could be declared final | 81 |
| Parameter 'facesContext' is not assigned and could be declared final | 81 |
| Parameter 'component' is not assigned and could be declared final | 86 |
| Parameter 'facesContext' is not assigned and could be declared final | 86 |
| Parameter 'submittedValue' is not assigned and could be declared final | 86 |
| Parameter 'component' is not assigned and could be declared final | 92 |
| Parameter 'facesContext' is not assigned and could be declared final | 92 |
| Parameter 'component' is not assigned and could be declared final | 97 |
| Parameter 'facesContext' is not assigned and could be declared final | 97 |
| Parameter 'component' is not assigned and could be declared final | 102 |
| Parameter 'facesContext' is not assigned and could be declared final | 102 |
| Parameter 'facesContext' is not assigned and could be declared final | 107 |
| Parameter 'clientId' is not assigned and could be declared final | 107 |
| Parameter 'facesContext' is not assigned and could be declared final | 111 |
| Local variable 'renderer' could be declared final | 112 - 113 |
org/apache/myfaces/tobago/renderkit/HtmlUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 28 - 84 |
| The class 'HtmlUtils' has a Cyclomatic Complexity of 3 (Highest = 5). | 28 - 84 |
| Parameter 'name' is not assigned and could be declared final | 36 |
| Parameter 'value' is not assigned and could be declared final | 36 |
| The method 'generateAttribute' has a Cyclomatic Complexity of 5. | 36 - 48 |
| Assigning an Object to null is a code smell. Consider refactoring. | 39 |
| Parameter 'component' is not assigned and could be declared final | 50 |
| Parameter 'name' is not assigned and could be declared final | 50 |
| Parameter 'appendValue' is not assigned and could be declared final | 51 |
| Local variable 'attribute' could be declared final | 52 |
| Avoid if (x != y) ..; else ..; | 53 - 54 |
| Parameter 'component' is not assigned and could be declared final | 57 |
| Parameter 'facesContext' is not assigned and could be declared final | 58 |
| Local variable 'onchange' could be declared final | 77 |
org/apache/myfaces/tobago/renderkit/InputRendererBase.java
| Violation | Line |
|---|---|
| The class 'InputRendererBase' has a Cyclomatic Complexity of 7 (Highest = 6). | 33 - 63 |
| Parameter 'component' is not assigned and could be declared final | 37 |
| Parameter 'context' is not assigned and could be declared final | 37 |
| The method 'decode' has a Cyclomatic Complexity of 6. | 37 - 62 |
org/apache/myfaces/tobago/renderkit/LabelWithAccessKey.java
| Violation | Line |
|---|---|
| Parameter 'label' is not assigned and could be declared final | 41 |
| Parameter 'component' is not assigned and could be declared final | 46 |
| Assigning an Object to null is a code smell. Consider refactoring. | 53 |
| Avoid reassigning parameters such as 'index' | 57 |
| Avoid reassigning parameters such as 'escapedIndicatorCount' | 57 |
| Parameter 'label' is not assigned and could be declared final | 57 |
| Parameter 'label' is not assigned and could be declared final | 77 |
| Avoid if (x != y) ..; else ..; | 78 - 86 |
| Assigning an Object to null is a code smell. Consider refactoring. | 90 |
| Assigning an Object to null is a code smell. Consider refactoring. | 91 |
| Parameter 'text' is not assigned and could be declared final | 107 |
| Parameter 'accessKey' is not assigned and could be declared final | 111 |
| Parameter 'accessKey' is not assigned and could be declared final | 122 |
org/apache/myfaces/tobago/renderkit/LayoutComponentRendererBase.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 32 |
| Parameter 'facesContext' is not assigned and could be declared final | 32 |
| Parameter 'name' is not assigned and could be declared final | 32 |
| Parameter 'component' is not assigned and could be declared final | 36 |
| Parameter 'facesContext' is not assigned and could be declared final | 36 |
| Parameter 'component' is not assigned and could be declared final | 40 |
| Parameter 'facesContext' is not assigned and could be declared final | 40 |
| Parameter 'component' is not assigned and could be declared final | 44 |
| Parameter 'facesContext' is not assigned and could be declared final | 44 |
| Parameter 'component' is not assigned and could be declared final | 48 |
| Parameter 'facesContext' is not assigned and could be declared final | 48 |
| Parameter 'component' is not assigned and could be declared final | 52 |
| Parameter 'facesContext' is not assigned and could be declared final | 52 |
| Parameter 'component' is not assigned and could be declared final | 56 |
| Parameter 'facesContext' is not assigned and could be declared final | 56 |
| Parameter 'component' is not assigned and could be declared final | 60 |
| Parameter 'facesContext' is not assigned and could be declared final | 60 |
| Parameter 'component' is not assigned and could be declared final | 64 |
| Parameter 'facesContext' is not assigned and could be declared final | 64 |
| Parameter 'component' is not assigned and could be declared final | 68 |
| Parameter 'facesContext' is not assigned and could be declared final | 68 |
| Parameter 'component' is not assigned and could be declared final | 72 |
| Parameter 'facesContext' is not assigned and could be declared final | 72 |
| Parameter 'component' is not assigned and could be declared final | 76 |
| Parameter 'facesContext' is not assigned and could be declared final | 76 |
| Parameter 'component' is not assigned and could be declared final | 80 |
| Parameter 'facesContext' is not assigned and could be declared final | 80 |
| Parameter 'component' is not assigned and could be declared final | 84 |
| Parameter 'facesContext' is not assigned and could be declared final | 84 |
| Parameter 'component' is not assigned and could be declared final | 88 |
| Parameter 'facesContext' is not assigned and could be declared final | 88 |
| Parameter 'component' is not assigned and could be declared final | 92 |
| Parameter 'facesContext' is not assigned and could be declared final | 92 |
| Parameter 'component' is not assigned and could be declared final | 96 |
| Parameter 'facesContext' is not assigned and could be declared final | 96 |
| Parameter 'component' is not assigned and could be declared final | 100 |
| Parameter 'facesContext' is not assigned and could be declared final | 100 |
| Parameter 'component' is not assigned and could be declared final | 104 |
| Parameter 'facesContext' is not assigned and could be declared final | 104 |
| Parameter 'component' is not assigned and could be declared final | 108 |
| Parameter 'facesContext' is not assigned and could be declared final | 108 |
| Parameter 'component' is not assigned and could be declared final | 112 |
| Parameter 'facesContext' is not assigned and could be declared final | 112 |
| Parameter 'component' is not assigned and could be declared final | 116 |
| Parameter 'facesContext' is not assigned and could be declared final | 116 |
| Avoid if (x != y) ..; else ..; | 119 - 123 |
org/apache/myfaces/tobago/renderkit/PageRendererBase.java
| Violation | Line |
|---|---|
| The class 'PageRendererBase' has a Cyclomatic Complexity of 4 (Highest = 5). | 36 - 99 |
| Parameter 'component' is not assigned and could be declared final | 40 |
| Parameter 'facesContext' is not assigned and could be declared final | 40 |
| Local variable 'page' could be declared final | 42 |
| Parameter 'page' is not assigned and could be declared final | 49 |
| Parameter 'facesContext' is not assigned and could be declared final | 49 |
| The method 'decodeActionPosition' has a Cyclomatic Complexity of 5. | 49 - 73 |
| Local variable 'actionIdName' could be declared final | 50 |
| Local variable 'newActionId' could be declared final | 51 |
| Local variable 'actionPositionName' could be declared final | 58 |
| Local variable 'actionPositionString' could be declared final | 59 - 60 |
| Local variable 'actionPosition' could be declared final | 65 |
| Parameter 'page' is not assigned and could be declared final | 76 |
| Parameter 'facesContext' is not assigned and could be declared final | 76 |
| Local variable 'tokenizer' could be declared final | 83 |
| Local variable 'width' could be declared final | 84 |
| Local variable 'height' could be declared final | 85 |
| Local variable 'pageState' could be declared final | 87 |
org/apache/myfaces/tobago/renderkit/RendererBase.java
| Violation | Line |
|---|---|
| The class 'RendererBase' has a Cyclomatic Complexity of 3 (Highest = 8). | 45 - 196 |
| Parameter 'component' is not assigned and could be declared final | 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 54 |
| Local variable 'markup' could be declared final | 58 |
| Document empty method | 67 - 68 |
| Parameter 'component' is not assigned and could be declared final | 67 |
| Parameter 'context' is not assigned and could be declared final | 67 |
| Parameter 'rendererType' is not assigned and could be declared final | 74 |
| Parameter 'component' is not assigned and could be declared final | 82 |
| Parameter 'facesContext' is not assigned and could be declared final | 82 |
| Parameter 'key' is not assigned and could be declared final | 82 |
| Parameter 'input' is not assigned and could be declared final | 86 |
| Local variable 'submittedValue' could be declared final | 87 |
| Parameter 'component' is not assigned and could be declared final | 94 |
| Parameter 'facesContext' is not assigned and could be declared final | 94 |
| The method 'getCurrentValue' has a Cyclomatic Complexity of 5. | 94 - 109 |
| Local variable 'editableValueHolder' could be declared final | 97 |
| Local variable 'submittedValue' could be declared final | 98 |
| Local variable 'currentObj' could be declared final | 104 |
| Parameter 'component' is not assigned and could be declared final | 111 |
| Parameter 'context' is not assigned and could be declared final | 111 |
| Parameter 'currentValue' is not assigned and could be declared final | 111 |
| The method 'getFormattedValue' has a Cyclomatic Complexity of 7. | 111 - 140 |
| Local variable 'converterType' could be declared final | 131 |
| Parameter 'component' is not assigned and could be declared final | 142 |
| Parameter 'component' is not assigned and could be declared final | 150 |
| Parameter 'context' is not assigned and could be declared final | 150 |
| The method 'getConverter' has a Cyclomatic Complexity of 8. | 150 - 171 |
| Local variable 'valueExpression' could be declared final | 156 |
| Local variable 'converterType' could be declared final | 158 |
| Parameter 'component' is not assigned and could be declared final | 174 |
| Parameter 'submittedValue' is not assigned and could be declared final | 174 |
| Parameter 'context' is not assigned and could be declared final | 174 |
| Local variable 'converter' could be declared final | 179 |
| Avoid if (x != y) ..; else ..; | 180 - 184 |
| Document empty method | 187 - 188 |
| Parameter 'component' is not assigned and could be declared final | 187 |
| Parameter 'facesContext' is not assigned and could be declared final | 187 |
| Parameter 'parent' is not assigned and could be declared final | 187 |
| Use block level rather than method level synchronization | 190 - 195 |
org/apache/myfaces/tobago/renderkit/RendererBaseWrapper.java
| Violation | Line |
|---|---|
| Private field 'renderer' could be made final; it is only initialized in the declaration or constructor. | 29 |
| Parameter 'renderer' is not assigned and could be declared final | 31 |
| Document empty method | 35 - 36 |
| Parameter 'component' is not assigned and could be declared final | 35 |
| Parameter 'facesContext' is not assigned and could be declared final | 35 |
| Parameter 'component' is not assigned and could be declared final | 38 |
| Parameter 'submittedValue' is not assigned and could be declared final | 38 |
| Parameter 'context' is not assigned and could be declared final | 38 |
| Parameter 'component' is not assigned and could be declared final | 43 |
| Parameter 'facesContext' is not assigned and could be declared final | 43 |
| Parameter 'component' is not assigned and could be declared final | 47 |
| Parameter 'context' is not assigned and could be declared final | 47 |
| Parameter 'component' is not assigned and could be declared final | 51 |
| Parameter 'context' is not assigned and could be declared final | 51 |
| Parameter 'component' is not assigned and could be declared final | 55 |
| Parameter 'context' is not assigned and could be declared final | 55 |
| Parameter 'context' is not assigned and could be declared final | 59 |
| Parameter 'clientId' is not assigned and could be declared final | 59 |
org/apache/myfaces/tobago/renderkit/SelectManyRendererBase.java
| Violation | Line |
|---|---|
| The class 'SelectManyRendererBase' has a Cyclomatic Complexity of 13 (Highest = 26). | 39 - 199 |
| The class 'SelectManyRendererBase' has a Cyclomatic Complexity of 13 (Highest = 26). | 39 - 199 |
| Parameter 'component' is not assigned and could be declared final | 43 |
| Parameter 'facesContext' is not assigned and could be declared final | 43 |
| The method 'decode' has a Cyclomatic Complexity of 8. | 43 - 68 |
| Local variable 'uiSelectMany' could be declared final | 48 |
| Avoid if (x != y) ..; else ..; | 55 |
| Deeply nested if..then statements are hard to read | 56 - 60 |
| Parameter 'component' is not assigned and could be declared final | 71 |
| Parameter 'facesContext' is not assigned and could be declared final | 71 |
| Parameter 'submittedValue' is not assigned and could be declared final | 71 |
| Parameter 'facesContext' is not assigned and could be declared final | 85 |
| The method 'getConvertedUISelectManyValue' has a Cyclomatic Complexity of 26. | 85 - 197 |
| The method getConvertedUISelectManyValue() has an NPath complexity of 823680 | 85 - 197 |
| Avoid really long methods. | 85 - 197 |
| The method 'getConvertedUISelectManyValue' has a Cyclomatic Complexity of 26. | 85 - 197 |
| Parameter 'component' is not assigned and could be declared final | 86 |
| Parameter 'submittedValue' is not assigned and could be declared final | 87 |
| Local variable 'vb' could be declared final | 97 |
| These nested if statements could be combined | 145 - 147 |
| These nested if statements could be combined | 145 - 147 |
| Local variable 'len' could be declared final | 153 |
| Local variable 'length' could be declared final | 167 |
| Local variable 'list' could be declared final | 168 |
| Local variable 'len' could be declared final | 181 |
| Local variable 'convertedValues' could be declared final | 182 |
| Local variable 'length' could be declared final | 190 |
| Local variable 'convertedValues' could be declared final | 191 |
org/apache/myfaces/tobago/renderkit/SelectOneRendererBase.java
| Violation | Line |
|---|---|
| The class 'SelectOneRendererBase' has a Cyclomatic Complexity of 5 (Highest = 4). | 30 - 51 |
| Parameter 'component' is not assigned and could be declared final | 34 |
| Parameter 'facesContext' is not assigned and could be declared final | 34 |
| Local variable 'uiSelectOne' could be declared final | 39 |
| Local variable 'clientId' could be declared final | 41 |
| Local variable 'newValue' could be declared final | 42 - 43 |
org/apache/myfaces/tobago/renderkit/TobagoRenderKit.java
| Violation | Line |
|---|---|
| The class 'TobagoRenderKit' has a Cyclomatic Complexity of 4 (Highest = 13). | 48 - 195 |
| The class 'TobagoRenderKit' has a Cyclomatic Complexity of 4 (Highest = 13). | 48 - 195 |
| Private field 'renderers' could be made final; it is only initialized in the declaration or constructor. | 56 |
| Parameter 'rendererType' is not assigned and could be declared final | 65 |
| Parameter 'family' is not assigned and could be declared final | 65 |
| Avoid instantiation through private constructors from outside of the constructor's class. | 66 |
| Local variable 'renderKit' could be declared final | 68 |
| Local variable 'rkFactory' could be declared final | 85 |
| The method 'createResponseWriter' has a Cyclomatic Complexity of 13. | 93 - 142 |
| The method createResponseWriter() has an NPath complexity of 400 | 93 - 142 |
| The method 'createResponseWriter' has a Cyclomatic Complexity of 13. | 93 - 142 |
| Parameter 'writer' is not assigned and could be declared final | 94 |
| Parameter 'contentTypeList' is not assigned and could be declared final | 94 |
| Parameter 'characterEncoding' is not assigned and could be declared final | 94 |
| Local variable 'facesContext' could be declared final | 96 |
| The String literal "text/html" appears 5 times in this file; the first occurrence is on line 101 | 101 |
| Parameter 'rendererType' is not assigned and could be declared final | 145 |
| Parameter 'family' is not assigned and could be declared final | 145 |
| Parameter 'renderer' is not assigned and could be declared final | 145 |
| Avoid instantiation through private constructors from outside of the constructor's class. | 146 |
| Parameter 'outputStream' is not assigned and could be declared final | 155 |
| The class 'Key' has a Cyclomatic Complexity of 3 (Highest = 6). | 159 - 194 |
| Parameter 'rendererType' is not assigned and could be declared final | 163 |
| Parameter 'family' is not assigned and could be declared final | 163 |
| Parameter 'o' is not assigned and could be declared final | 168 |
| The method 'equals' has a Cyclomatic Complexity of 6. | 168 - 186 |
| Local variable 'key' could be declared final | 176 |
org/apache/myfaces/tobago/renderkit/css/Classes.java
| Violation | Line |
|---|---|
| The class 'Classes' has a Cyclomatic Complexity of 2 (Highest = 9). | 61 - 164 |
| Parameter 'component' is not assigned and could be declared final | 69 |
| Parameter 'sub' is not assigned and could be declared final | 73 |
| Parameter 'component' is not assigned and could be declared final | 73 |
| Parameter 'component' is not assigned and could be declared final | 77 |
| Parameter 'explicit' is not assigned and could be declared final | 77 |
| Parameter 'sub' is not assigned and could be declared final | 81 |
| Parameter 'component' is not assigned and could be declared final | 81 |
| Parameter 'explicit' is not assigned and could be declared final | 81 |
| Use block level rather than method level synchronization | 86 - 100 |
| Parameter 'sub' is not assigned and could be declared final | 87 |
| Parameter 'component' is not assigned and could be declared final | 87 |
| Parameter 'explicit' is not assigned and could be declared final | 87 |
| Parameter 'markupFromComponent' is not assigned and could be declared final | 87 |
| Parameter 'ignoreCheck' is not assigned and could be declared final | 87 |
| Parameter 'markup' is not assigned and could be declared final | 102 |
| Parameter 'sub' is not assigned and could be declared final | 102 |
| Parameter 'ignoreMarkupCheck' is not assigned and could be declared final | 102 |
| Parameter 'rendererName' is not assigned and could be declared final | 102 |
| The constructor 'Classes' has a Cyclomatic Complexity of 9. | 102 - 135 |
| Avoid if (x != y) ..; else ..; | 107 |
| Local variable 'builder' could be declared final | 107 |
| Local variable 'theme' could be declared final | 115 |
| Parameter 'component' is not assigned and could be declared final | 143 |
| Parameter 'sub' is not assigned and could be declared final | 152 |
| Parameter 'explicit' is not assigned and could be declared final | 152 |
| Parameter 'rendererName' is not assigned and could be declared final | 152 |
| Parameter 'explicit' is not assigned and could be declared final | 160 |
| Parameter 'rendererName' is not assigned and could be declared final | 160 |
org/apache/myfaces/tobago/renderkit/css/Overflow.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 30 |
org/apache/myfaces/tobago/renderkit/css/Position.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 31 |
org/apache/myfaces/tobago/renderkit/css/Style.java
| Violation | Line |
|---|---|
| This class has a bunch of public methods and attributes | 20 - 536 |
| The class 'Style' has a Cyclomatic Complexity of 2 (Highest = 23). | 33 - 536 |
| The class 'Style' has a Cyclomatic Complexity of 2 (Highest = 23). | 33 - 536 |
| Too many fields | 33 - 536 |
| Document empty constructor | 59 - 60 |
| Parameter 'map' is not assigned and could be declared final | 62 |
| Parameter 'facesContext' is not assigned and could be declared final | 86 |
| Parameter 'layout' is not assigned and could be declared final | 86 |
| The constructor 'Style' has a Cyclomatic Complexity of 10. | 86 - 131 |
| The constructor 'Style' has a Cyclomatic Complexity of 10. | 86 - 131 |
| Local variable 'rendererType' could be declared final | 88 |
| Overridable method 'getDisplay' called during object construction | 124 |
| Assigning an Object to null is a code smell. Consider refactoring. | 128 |
| Assigning an Object to null is a code smell. Consider refactoring. | 129 |
| The method 'encode' has a Cyclomatic Complexity of 22. | 142 - 251 |
| The method encode() has an NPath complexity of 2097152 | 142 - 251 |
| Avoid really long methods. | 142 - 251 |
| The method 'encode' has a Cyclomatic Complexity of 22. | 142 - 251 |
| Local variable 'buf' could be declared final | 143 |
| The method 'encodeJson' has a Cyclomatic Complexity of 23. | 253 - 367 |
| The method encodeJson() has an NPath complexity of 4194304 | 253 - 367 |
| Avoid really long methods. | 253 - 367 |
| The method 'encodeJson' has a Cyclomatic Complexity of 23. | 253 - 367 |
| Local variable 'buf' could be declared final | 254 |
| The String literal "\"," appears 20 times in this file; the first occurrence is on line 258 | 258 |
| Parameter 'width' is not assigned and could be declared final | 373 |
| Parameter 'height' is not assigned and could be declared final | 381 |
| Parameter 'left' is not assigned and could be declared final | 389 |
| Parameter 'top' is not assigned and could be declared final | 397 |
| Parameter 'display' is not assigned and could be declared final | 405 |
| Parameter 'position' is not assigned and could be declared final | 413 |
| Parameter 'overflowX' is not assigned and could be declared final | 421 |
| Parameter 'overflowY' is not assigned and could be declared final | 429 |
| Parameter 'marginLeft' is not assigned and could be declared final | 437 |
| Parameter 'marginRight' is not assigned and could be declared final | 445 |
| Parameter 'marginTop' is not assigned and could be declared final | 453 |
| Parameter 'marginBottom' is not assigned and could be declared final | 461 |
| Parameter 'margin' is not assigned and could be declared final | 469 |
| Parameter 'paddingLeft' is not assigned and could be declared final | 477 |
| Parameter 'paddingRight' is not assigned and could be declared final | 485 |
| Parameter 'paddingTop' is not assigned and could be declared final | 493 |
| Parameter 'paddingBottom' is not assigned and could be declared final | 501 |
| Parameter 'padding' is not assigned and could be declared final | 509 |
| Parameter 'backgroundImage' is not assigned and could be declared final | 517 |
| Parameter 'zIndex' is not assigned and could be declared final | 525 |
| Parameter 'textAlign' is not assigned and could be declared final | 533 |
org/apache/myfaces/tobago/servlet/NonFacesRequestServlet.java
| Violation | Line |
|---|---|
| Parameter 'response' is not assigned and could be declared final | 46 |
| Parameter 'request' is not assigned and could be declared final | 46 |
| Local variable 'lFactory' could be declared final | 49 |
| Local variable 'lifecycle' could be declared final | 50 |
| Local variable 'fcFactory' could be declared final | 51 |
| Local variable 'facesContext' could be declared final | 52 |
| Local variable 'outcome' could be declared final | 56 |
| Local variable 'application' could be declared final | 65 |
| Local variable 'navigationHandler' could be declared final | 70 |
| Parameter 'facesContext' is not assigned and could be declared final | 80 |
| An empty method in an abstract class should be abstract instead | 90 - 92 |
org/apache/myfaces/tobago/servlet/ResourceServlet.java
| Violation | Line |
|---|---|
| The class 'ResourceServlet' has a Cyclomatic Complexity of 4 (Highest = 8). | 68 - 193 |
| Private field 'resourceDirs' could be made final; it is only initialized in the declaration or constructor. | 76 |
| Parameter 'servletConfig' is not assigned and could be declared final | 79 |
| The method 'init' has a Cyclomatic Complexity of 7. | 79 - 106 |
| Local variable 'tobagoConfig' could be declared final | 81 |
| Local variable 'defaultTheme' could be declared final | 85 |
| Local variable 'expiresString' could be declared final | 89 |
| Avoid instantiating Long objects.Call Long.valueOf() instead | 92 |
| Local variable 'bufferSizeString' could be declared final | 97 |
| Parameter 'themes' is not assigned and could be declared final | 108 |
| Parameter 'theme' is not assigned and could be declared final | 114 |
| Local variable 'dir' could be declared final | 115 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 116 |
| The method 'doGet' has a Cyclomatic Complexity of 8. | 124 - 175 |
| Parameter 'response' is not assigned and could be declared final | 125 |
| Parameter 'request' is not assigned and could be declared final | 125 |
| Local variable 'requestURI' could be declared final | 128 |
| Local variable 'contentType' could be declared final | 143 |
| Avoid if (x != y) ..; else ..; | 144 - 151 |
| Local variable 'message' could be declared final | 147 |
| Local variable 'classLoader' could be declared final | 155 |
| Avoid if (x != y) ..; else ..; | 165 - 171 |
| Local variable 'message' could be declared final | 168 |
| Parameter 'request' is not assigned and could be declared final | 178 |
| Avoid if (x != y) ..; else ..; | 179 - 183 |
| Parameter 'inputStream' is not assigned and could be declared final | 186 |
| Parameter 'outputStream' is not assigned and could be declared final | 186 |
| Local variable 'buffer' could be declared final | 187 |
org/apache/myfaces/tobago/util/ApplyRequestValuesCallback.java
| Violation | Line |
|---|---|
| The class 'ApplyRequestValuesCallback' has a Cyclomatic Complexity of 7 (Highest = 12). | 34 - 65 |
| The class 'ApplyRequestValuesCallback' has a Cyclomatic Complexity of 7 (Highest = 12). | 34 - 65 |
| Avoid unused private fields such as 'LOG'. | 37 |
| Avoid unused private fields such as 'LOG'. | 37 |
| Parameter 'component' is not assigned and could be declared final | 39 |
| Parameter 'context' is not assigned and could be declared final | 39 |
| The method 'invokeContextCallback' has a Cyclomatic Complexity of 12. | 39 - 60 |
| The method 'invokeContextCallback' has a Cyclomatic Complexity of 12. | 39 - 60 |
| Local variable 'reload' could be declared final | 42 |
| Local variable 'immediate' could be declared final | 45 |
| Deeply nested if..then statements are hard to read | 46 - 56 |
| Local variable 'update' could be declared final | 47 |
org/apache/myfaces/tobago/util/BeanComparator.java
| Violation | Line |
|---|---|
| Private field 'property' could be made final; it is only initialized in the declaration or constructor. | 35 |
| Parameter 'property' is not assigned and could be declared final | 37 |
| Parameter 'reverse' is not assigned and could be declared final | 41 |
| Parameter 'property' is not assigned and could be declared final | 41 |
| Parameter 'property' is not assigned and could be declared final | 46 |
| Parameter 'comparator' is not assigned and could be declared final | 46 |
| Parameter 'reverse' is not assigned and could be declared final | 51 |
| Parameter 'property' is not assigned and could be declared final | 51 |
| Parameter 'comparator' is not assigned and could be declared final | 51 |
| Parameter 'param1' is not assigned and could be declared final | 60 |
| Avoid if (x != y) ..; else ..; | 73 |
| Parameter 'param1' is not assigned and could be declared final | 85 |
| Parameter 'param2' is not assigned and could be declared final | 85 |
org/apache/myfaces/tobago/util/BundleMapWrapper.java
| Violation | Line |
|---|---|
| This class has too many methods, consider refactoring it. | 30 - 109 |
| Private field 'basename' could be made final; it is only initialized in the declaration or constructor. | 32 |
| Parameter 'basename' is not assigned and could be declared final | 34 |
| Parameter 'key' is not assigned and could be declared final | 42 |
| Local variable 'value' could be declared final | 46 - 47 |
| Parameter 'value' is not assigned and could be declared final | 51 |
| Parameter 'key' is not assigned and could be declared final | 59 |
| Parameter 'o' is not assigned and could be declared final | 71 |
| Local variable 'that' could be declared final | 78 |
| Parameter 'v' is not assigned and could be declared final | 90 |
| Parameter 'k' is not assigned and could be declared final | 90 |
| Parameter 't' is not assigned and could be declared final | 94 |
| Parameter 'k' is not assigned and could be declared final | 98 |
org/apache/myfaces/tobago/util/ComparatorBase.java
| Violation | Line |
|---|---|
| The class 'ComparatorBase' has a Cyclomatic Complexity of 3 (Highest = 14). | 27 - 126 |
| The class 'ComparatorBase' has a Cyclomatic Complexity of 3 (Highest = 14). | 27 - 126 |
| Document empty constructor | 33 - 34 |
| Parameter 'reverse' is not assigned and could be declared final | 36 |
| Parameter 'comparator' is not assigned and could be declared final | 36 |
| Parameter 'reverse' is not assigned and could be declared final | 41 |
| Parameter 'comparator' is not assigned and could be declared final | 45 |
| Parameter 'obj1' is not assigned and could be declared final | 49 |
| Parameter 'obj2' is not assigned and could be declared final | 49 |
| The method 'internalCompare' has a Cyclomatic Complexity of 14. | 49 - 89 |
| The method 'internalCompare' has a Cyclomatic Complexity of 14. | 49 - 89 |
| Local variable 'collationKey1' could be declared final | 71 - 72 |
| Local variable 'collationKey2' could be declared final | 73 - 74 |
| Avoid if (x != y) ..; else ..; | 77 - 87 |
| Parameter 'o' is not assigned and could be declared final | 112 |
| Avoid if (x != y) ..; else ..; | 120 |
org/apache/myfaces/tobago/util/ComponentUtils.java
| Violation | Line |
|---|---|
| High amount of different objects as members denotes a high coupling | 20 - 1033 |
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 1033 |
| This class has a bunch of public methods and attributes | 20 - 1033 |
| A class which only has private constructors should be final | 75 - 1033 |
| The class 'ComponentUtils' has a Cyclomatic Complexity of 3 (Highest = 10). | 75 - 1033 |
| This class has too many methods, consider refactoring it. | 75 - 1033 |
| The class 'ComponentUtils' has a Cyclomatic Complexity of 3 (Highest = 10). | 75 - 1033 |
| Parameter 'context' is not assigned and could be declared final | 101 |
| Local variable 'iter' could be declared final | 102 |
| Local variable 'message' could be declared final | 103 |
| Parameter 'command' is not assigned and could be declared final | 111 |
| Local variable 'actionListeners' could be declared final | 112 |
| Parameter 'component' is not assigned and could be declared final | 121 |
| Parameter 'facesContext' is not assigned and could be declared final | 121 |
| Local variable 'messages' could be declared final | 122 - 123 |
| Local variable 'stringBuffer' could be declared final | 124 |
| Local variable 'message' could be declared final | 126 |
| Avoid reassigning parameters such as 'component' | 136 |
| Parameter 'context' is not assigned and could be declared final | 146 |
| Local variable 'view' could be declared final | 147 |
| Parameter 'component' is not assigned and could be declared final | 157 |
| Parameter 'faceletContext' is not assigned and could be declared final | 157 |
| Local variable 'viewRoot' could be declared final | 158 |
| Avoid if (x != y) ..; else ..; | 159 - 163 |
| Parameter 'component' is not assigned and could be declared final | 166 |
| Parameter 'context' is not assigned and could be declared final | 166 |
| Local variable 'view' could be declared final | 167 |
| Avoid if (x != y) ..; else ..; | 168 - 178 |
| Local variable 'page' could be declared final | 171 |
| Avoid reassigning parameters such as 'component' | 181 |
| Parameter 'facesContext' is not assigned and could be declared final | 195 |
| Parameter 'component' is not assigned and could be declared final | 199 |
| The method 'findPageBreadthFirst' has a Cyclomatic Complexity of 5. | 199 - 212 |
| Local variable 'result' could be declared final | 206 |
| Avoid reassigning parameters such as 'component' | 215 |
| Avoid reassigning parameters such as 'component' | 225 |
| Parameter 'type' is not assigned and could be declared final | 225 |
| Parameter 'component' is not assigned and could be declared final | 240 |
| Local variable 'collect' could be declared final | 241 |
| Parameter 'component' is not assigned and could be declared final | 247 |
| Parameter 'collect' is not assigned and could be declared final | 247 |
| Local variable 'kids' could be declared final | 248 |
| Local variable 'child' could be declared final | 250 |
| Parameter 'component' is not assigned and could be declared final | 262 |
| Parameter 'type' is not assigned and could be declared final | 262 |
| Parameter 'component' is not assigned and could be declared final | 279 |
| Parameter 'type' is not assigned and could be declared final | 279 |
| Local variable 'result' could be declared final | 281 |
| Parameter 'component' is not assigned and could be declared final | 299 |
| Parameter 'facesContext' is not assigned and could be declared final | 299 |
| Local variable 'forComponent' could be declared final | 300 |
| Local variable 'clientId' could be declared final | 302 |
| Parameter 'component' is not assigned and could be declared final | 314 |
| Local variable 'forValue' could be declared final | 315 |
| Parameter 'component' is not assigned and could be declared final | 330 |
| The method 'evaluateAutoFor' has a Cyclomatic Complexity of 5. | 330 - 342 |
| Local variable 'forComponent' could be declared final | 331 |
| Parameter 'component' is not assigned and could be declared final | 350 |
| Parameter 'clazz' is not assigned and could be declared final | 350 |
| The method 'evaluateAutoFor' has a Cyclomatic Complexity of 7. | 350 - 369 |
| Local variable 'forComponent' could be declared final | 351 |
| Parameter 'child' is not assigned and could be declared final | 372 |
| Parameter 'namingContainer' is not assigned and could be declared final | 372 |
| Parameter 'component' is not assigned and could be declared final | 372 |
| Parameter 'clazz' is not assigned and could be declared final | 372 |
| Avoid reassigning parameters such as 'component' | 386 |
| Local variable 'form' could be declared final | 389 |
| Parameter 'component' is not assigned and could be declared final | 399 |
| The method 'getMaximumSeverity' has a Cyclomatic Complexity of 5. | 399 - 411 |
| Assigning an Object to null is a code smell. Consider refactoring. | 401 |
| Local variable 'facesContext' could be declared final | 402 |
| Local variable 'message' could be declared final | 405 |
| Parameter 'uiInput' is not assigned and could be declared final | 413 |
| Local variable 'facesContext' could be declared final | 414 |
| Parameter 'component' is not assigned and could be declared final | 419 |
| Parameter 'component' is not assigned and could be declared final | 426 |
| Parameter 'component' is not assigned and could be declared final | 431 |
| Parameter 'component' is not assigned and could be declared final | 436 |
| Parameter 'component' is not assigned and could be declared final | 440 |
| Parameter 'name' is not assigned and could be declared final | 440 |
| The method 'getBooleanAttribute' has a Cyclomatic Complexity of 5. | 440 - 462 |
| Parameter 'value' is not assigned and could be declared final | 466 |
| Parameter 'styleClasses' is not assigned and could be declared final | 476 |
| Parameter 'component' is not assigned and could be declared final | 476 |
| Parameter 'markup' is not assigned and could be declared final | 484 |
| Parameter 'markupComponent' is not assigned and could be declared final | 484 |
| Parameter 'component' is not assigned and could be declared final | 488 |
| Parameter 'name' is not assigned and could be declared final | 488 |
| Parameter 'component' is not assigned and could be declared final | 496 |
| Parameter 'name' is not assigned and could be declared final | 496 |
| Parameter 'component' is not assigned and could be declared final | 500 |
| Parameter 'name' is not assigned and could be declared final | 500 |
| Parameter 'component' is not assigned and could be declared final | 504 |
| Parameter 'name' is not assigned and could be declared final | 504 |
| Parameter 'component' is not assigned and could be declared final | 508 |
| Parameter 'name' is not assigned and could be declared final | 508 |
| The method 'getIntAttribute' has a Cyclomatic Complexity of 5. | 508 - 527 |
| Parameter 'defaultValue' is not assigned and could be declared final | 509 |
| Local variable 'integer' could be declared final | 510 |
| Parameter 'component' is not assigned and could be declared final | 529 |
| Parameter 'name' is not assigned and could be declared final | 529 |
| The method 'getCharacterAttribute' has a Cyclomatic Complexity of 5. | 529 - 543 |
| Local variable 'character' could be declared final | 530 |
| Local variable 'asString' could be declared final | 536 |
| Assigning an Object to null is a code smell. Consider refactoring. | 537 |
| Parameter 'component' is not assigned and could be declared final | 545 |
| Parameter 'parent' is not assigned and could be declared final | 545 |
| Local variable 'facet' could be declared final | 547 |
| Parameter 'component' is not assigned and could be declared final | 555 |
| Parameter 'facesContext' is not assigned and could be declared final | 555 |
| Parameter 'rendererType' is not assigned and could be declared final | 559 |
| Parameter 'facesContext' is not assigned and could be declared final | 559 |
| Parameter 'family' is not assigned and could be declared final | 559 |
| Local variable 'requestMap' could be declared final | 564 |
| Local variable 'key' could be declared final | 565 |
| Local variable 'myRenderer' could be declared final | 570 |
| Parameter 'rendererType' is not assigned and could be declared final | 582 |
| Parameter 'facesContext' is not assigned and could be declared final | 582 |
| Parameter 'family' is not assigned and could be declared final | 582 |
| Local variable 'rkFactory' could be declared final | 583 |
| Local variable 'renderKit' could be declared final | 584 |
| Local variable 'myRenderer' could be declared final | 585 |
| Consider simply returning the value vs storing it in local variable 'myRenderer' | 586 |
| Parameter 'component' is not assigned and could be declared final | 589 |
| Parameter 'name' is not assigned and could be declared final | 589 |
| The method 'findParameter' has a Cyclomatic Complexity of 5. | 589 - 603 |
| Local variable 'parameter' could be declared final | 592 |
| Parameter 'type' is not assigned and could be declared final | 605 |
| Local variable 'clazz' could be declared final | 612 |
| Parameter 'component' is not assigned and could be declared final | 622 |
| Parameter 'component' is not assigned and could be declared final | 633 |
| Parameter 'component' is not assigned and could be declared final | 637 |
| Parameter 'component' is not assigned and could be declared final | 650 |
| Parameter 'name' is not assigned and could be declared final | 650 |
| Parameter 'value' is not assigned and could be declared final | 650 |
| Avoid reassigning parameters such as 'value' | 654 |
| Parameter 'name' is not assigned and could be declared final | 661 |
| Parameter 'value' is not assigned and could be declared final | 661 |
| Local variable 'context' could be declared final | 662 |
| Local variable 'valueBinding' could be declared final | 663 |
| Parameter 'items' is not assigned and could be declared final | 668 |
| Parameter 'value' is not assigned and could be declared final | 668 |
| Parameter 'valueBinding' is not assigned and could be declared final | 677 |
| Parameter 'value' is not assigned and could be declared final | 681 |
| Parameter 'postfix' is not assigned and could be declared final | 694 |
| Parameter 'component' is not assigned and could be declared final | 694 |
| Parameter 'facesContext' is not assigned and could be declared final | 694 |
| Local variable 'id' could be declared final | 696 |
| Parameter 'component' is not assigned and could be declared final | 700 |
| Parameter 'facesContext' is not assigned and could be declared final | 700 |
| Local variable 'id' could be declared final | 701 |
| Parameter 'component' is not assigned and could be declared final | 714 |
| Parameter 'facesContext' is not assigned and could be declared final | 714 |
| The method 'provideLabel' has a Cyclomatic Complexity of 5. | 714 - 743 |
| Local variable 'application' could be declared final | 726 |
| Local variable 'idprefix' could be declared final | 729 |
| Parameter 'editableValueHolder' is not assigned and could be declared final | 749 |
| Parameter 'validator' is not assigned and could be declared final | 749 |
| Parameter 'converterId' is not assigned and could be declared final | 757 |
| Parameter 'valueHolder' is not assigned and could be declared final | 757 |
| Parameter 'component' is not assigned and could be declared final | 765 |
| Parameter 'action' is not assigned and could be declared final | 765 |
| Parameter 'actionListener' is not assigned and could be declared final | 773 |
| Parameter 'command' is not assigned and could be declared final | 773 |
| Parameter 'valueChangeListener' is not assigned and could be declared final | 781 |
| Parameter 'valueHolder' is not assigned and could be declared final | 781 |
| Parameter 'component' is not assigned and could be declared final | 789 |
| Parameter 'name' is not assigned and could be declared final | 789 |
| Parameter 'state' is not assigned and could be declared final | 789 |
| Parameter 'component' is not assigned and could be declared final | 797 |
| Parameter 'facesContext' is not assigned and could be declared final | 797 |
| The method 'getMarkupBinding' has a Cyclomatic Complexity of 7. | 797 - 820 |
| Local variable 'vb' could be declared final | 798 |
| Local variable 'markups' could be declared final | 800 |
| Local variable 'strings' could be declared final | 804 |
| Local variable 'result' could be declared final | 805 |
| Parameter 'relativeId' is not assigned and could be declared final | 834 |
| Parameter 'from' is not assigned and could be declared final | 834 |
| Parameter 'renderers' is not assigned and could be declared final | 838 |
| The method 'getConvertedValue' has a Cyclomatic Complexity of 10. | 842 - 873 |
| The method 'getConvertedValue' has a Cyclomatic Complexity of 10. | 842 - 873 |
| Parameter 'component' is not assigned and could be declared final | 843 |
| Parameter 'facesContext' is not assigned and could be declared final | 843 |
| Parameter 'stringValue' is not assigned and could be declared final | 843 |
| Local variable 'renderer' could be declared final | 845 |
| Avoid if (x != y) ..; else ..; | 846 - 868 |
| Local variable 'vb' could be declared final | 857 |
| Local variable 'valueType' could be declared final | 859 |
| Avoid reassigning parameters such as 'markup' | 875 |
| Avoid reassigning parameters such as 'markup' | 875 |
| Avoid reassigning parameters such as 'markup' | 875 |
| Avoid reassigning parameters such as 'markup' | 875 |
| Avoid reassigning parameters such as 'markup' | 875 |
| Parameter 'component' is not assigned and could be declared final | 875 |
| The method 'updateMarkup' has a Cyclomatic Complexity of 6. | 875 - 896 |
| Local variable 'input' could be declared final | 886 |
| Parameter 'maximumSeverity' is not assigned and could be declared final | 898 |
| The method 'markupOfSeverity' has a Cyclomatic Complexity of 5. | 898 - 909 |
| Parameter 'markup' is not assigned and could be declared final | 911 |
| Parameter 'component' is not assigned and could be declared final | 911 |
| Parameter 'facesContext' is not assigned and could be declared final | 915 |
| Parameter 'container' is not assigned and could be declared final | 915 |
| Local variable 'clientId' could be declared final | 917 |
| Local variable 'ids' could be declared final | 918 |
| Local variable 'id' could be declared final | 919 |
| The method 'getMaximumSeverityOfChildrenMessages' has a Cyclomatic Complexity of 8. | 928 - 948 |
| Parameter 'facesContext' is not assigned and could be declared final | 929 |
| Parameter 'container' is not assigned and could be declared final | 929 |
| Local variable 'clientId' could be declared final | 931 |
| Local variable 'ids' could be declared final | 933 |
| Local variable 'id' could be declared final | 934 |
| Local variable 'message' could be declared final | 938 |
| Parameter 'facesContext' is not assigned and could be declared final | 950 |
| Parameter 'container' is not assigned and could be declared final | 950 |
| Local variable 'clientIds' could be declared final | 952 |
| Local variable 'clientId' could be declared final | 953 |
| Local variable 'ids' could be declared final | 954 |
| Local variable 'id' could be declared final | 955 |
| Parameter 'component' is not assigned and could be declared final | 969 |
| Parameter 'name' is not assigned and could be declared final | 969 |
| Parameter 'value' is not assigned and could be declared final | 969 |
| Parameter 'component' is not assigned and could be declared final | 981 |
| Parameter 'name' is not assigned and could be declared final | 981 |
| Parameter 'value' is not assigned and could be declared final | 981 |
| Parameter 'component' is not assigned and could be declared final | 991 |
| The method 'invokeOnComponent' has a Cyclomatic Complexity of 7. | 995 - 1020 |
| Parameter 'component' is not assigned and could be declared final | 996 |
| Parameter 'context' is not assigned and could be declared final | 996 |
| Parameter 'callback' is not assigned and could be declared final | 996 |
| Parameter 'clientId' is not assigned and could be declared final | 996 |
| Local variable 'thisClientId' could be declared final | 997 |
| These nested if statements could be combined | 1009 - 1011 |
| These nested if statements could be combined | 1009 - 1011 |
| Parameter 'component' is not assigned and could be declared final | 1023 |
| Parameter 'context' is not assigned and could be declared final | 1023 |
| Parameter 'callback' is not assigned and could be declared final | 1023 |
| Parameter 'clientId' is not assigned and could be declared final | 1023 |
| Local variable 'it' could be declared final | 1024 |
| Local variable 'child' could be declared final | 1025 |
org/apache/myfaces/tobago/util/CreateComponentUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 41 - 171 |
| This class has too many methods, consider refactoring it. | 41 - 171 |
| Parameter 'rendererType' is not assigned and could be declared final | 47 |
| Parameter 'componentType' is not assigned and could be declared final | 47 |
| Parameter 'rendererType' is not assigned and could be declared final | 51 |
| Parameter 'componentType' is not assigned and could be declared final | 51 |
| Parameter 'clientId' is not assigned and could be declared final | 51 |
| Parameter 'rendererType' is not assigned and could be declared final | 57 |
| Parameter 'facesContext' is not assigned and could be declared final | 57 |
| Parameter 'componentType' is not assigned and could be declared final | 57 |
| Parameter 'rendererType' is not assigned and could be declared final | 62 |
| Parameter 'facesContext' is not assigned and could be declared final | 62 |
| Parameter 'componentType' is not assigned and could be declared final | 62 |
| Parameter 'clientId' is not assigned and could be declared final | 62 |
| Local variable 'component' could be declared final | 63 |
| Parameter 'sortable' is not assigned and could be declared final | 70 |
| Parameter 'align' is not assigned and could be declared final | 70 |
| Parameter 'value' is not assigned and could be declared final | 70 |
| Parameter 'label' is not assigned and could be declared final | 70 |
| Parameter 'sortable' is not assigned and could be declared final | 75 |
| Parameter 'align' is not assigned and could be declared final | 75 |
| Parameter 'value' is not assigned and could be declared final | 75 |
| Parameter 'label' is not assigned and could be declared final | 75 |
| Parameter 'clientId' is not assigned and could be declared final | 75 |
| Local variable 'text' could be declared final | 76 |
| Parameter 'child' is not assigned and could be declared final | 85 |
| Parameter 'sortable' is not assigned and could be declared final | 85 |
| Parameter 'align' is not assigned and could be declared final | 85 |
| Parameter 'label' is not assigned and could be declared final | 85 |
| Parameter 'child' is not assigned and could be declared final | 90 |
| Parameter 'sortable' is not assigned and could be declared final | 90 |
| Parameter 'align' is not assigned and could be declared final | 90 |
| Parameter 'label' is not assigned and could be declared final | 90 |
| Parameter 'clientId' is not assigned and could be declared final | 90 |
| Local variable 'column' could be declared final | 91 |
| Parameter 'sortable' is not assigned and could be declared final | 98 |
| Parameter 'align' is not assigned and could be declared final | 98 |
| Parameter 'label' is not assigned and could be declared final | 98 |
| Parameter 'sortable' is not assigned and could be declared final | 102 |
| Parameter 'align' is not assigned and could be declared final | 102 |
| Parameter 'label' is not assigned and could be declared final | 102 |
| Parameter 'clientId' is not assigned and could be declared final | 102 |
| Local variable 'column' could be declared final | 103 |
| Parameter 'facesContext' is not assigned and could be declared final | 111 |
| Parameter 'command' is not assigned and could be declared final | 112 |
| Parameter 'facesContext' is not assigned and could be declared final | 117 |
| Parameter 'command' is not assigned and could be declared final | 117 |
| Parameter 'clientId' is not assigned and could be declared final | 117 |
| Local variable 'radio' could be declared final | 119 - 120 |
| Avoid if (x != y) ..; else ..; | 124 - 128 |
| Parameter 'facesContext' is not assigned and could be declared final | 133 |
| Parameter 'command' is not assigned and could be declared final | 133 |
| Parameter 'facesContext' is not assigned and could be declared final | 137 |
| Parameter 'command' is not assigned and could be declared final | 138 |
| Parameter 'facesContext' is not assigned and could be declared final | 142 |
| Parameter 'command' is not assigned and could be declared final | 142 |
| Parameter 'clientId' is not assigned and could be declared final | 143 |
| Local variable 'checkbox' could be declared final | 144 - 145 |
| Local variable 'valueBinding' could be declared final | 148 |
| Avoid if (x != y) ..; else ..; | 149 - 154 |
| Parameter 'rendererType' is not assigned and could be declared final | 159 |
| Parameter 'facesContext' is not assigned and could be declared final | 159 |
| Parameter 'parent' is not assigned and could be declared final | 159 |
| Parameter 'componentType' is not assigned and could be declared final | 159 |
| Local variable 'layoutManager' could be declared final | 161 - 162 |
org/apache/myfaces/tobago/util/DebugActionListener.java
| Violation | Line |
|---|---|
| Private field 'actionListener' could be made final; it is only initialized in the declaration or constructor. | 33 |
| Parameter 'actionListener' is not assigned and could be declared final | 36 |
| Parameter 'actionEvent' is not assigned and could be declared final | 40 |
org/apache/myfaces/tobago/util/DebugNavigationHandler.java
| Violation | Line |
|---|---|
| The class 'DebugNavigationHandler' has a Cyclomatic Complexity of 4 (Highest = 5). | 29 - 57 |
| Private field 'navigationHandler' could be made final; it is only initialized in the declaration or constructor. | 33 |
| Parameter 'navigationHandler' is not assigned and could be declared final | 35 |
| Parameter 'fromAction' is not assigned and could be declared final | 39 |
| Parameter 'facesContext' is not assigned and could be declared final | 39 |
| Parameter 'outcome' is not assigned and could be declared final | 39 |
| The method 'handleNavigation' has a Cyclomatic Complexity of 5. | 39 - 56 |
org/apache/myfaces/tobago/util/DebugPhaseListener.java
| Violation | Line |
|---|---|
| The class 'DebugPhaseListener' has a Cyclomatic Complexity of 9 (Highest = 15). | 39 - 150 |
| The class 'DebugPhaseListener' has a Cyclomatic Complexity of 9 (Highest = 15). | 39 - 150 |
| Parameter 'phaseEvent' is not assigned and could be declared final | 45 |
| The method 'afterPhase' has a Cyclomatic Complexity of 10. | 45 - 91 |
| The method 'afterPhase' has a Cyclomatic Complexity of 10. | 45 - 91 |
| Deeply nested if..then statements are hard to read | 67 - 72 |
| Deeply nested if..then statements are hard to read | 75 - 77 |
| Local variable 'iterator' could be declared final | 79 |
| Local variable 'messageIterator' could be declared final | 82 |
| Parameter 'phaseEvent' is not assigned and could be declared final | 93 |
| The method 'beforePhase' has a Cyclomatic Complexity of 15. | 93 - 145 |
| The method beforePhase() has an NPath complexity of 286 | 93 - 145 |
| The method 'beforePhase' has a Cyclomatic Complexity of 15. | 93 - 145 |
| Deeply nested if..then statements are hard to read | 107 - 123 |
| Local variable 'servletRequest' could be declared final | 112 |
| Deeply nested if..then statements are hard to read | 129 - 139 |
| Deeply nested if..then statements are hard to read | 140 - 142 |
org/apache/myfaces/tobago/util/DebugUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 32 - 103 |
| The class 'DebugUtils' has a Cyclomatic Complexity of 2 (Highest = 6). | 32 - 103 |
| Parameter 'component' is not assigned and could be declared final | 38 |
| Parameter 'offset' is not assigned and could be declared final | 38 |
| Parameter 'asFacet' is not assigned and could be declared final | 42 |
| Parameter 'component' is not assigned and could be declared final | 42 |
| Parameter 'offset' is not assigned and could be declared final | 42 |
| The method 'toString' has a Cyclomatic Complexity of 6. | 42 - 70 |
| Local variable 'result' could be declared final | 43 |
| Local variable 'facets' could be declared final | 52 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 53 |
| Local variable 'facet' could be declared final | 55 |
| Parameter 'component' is not assigned and could be declared final | 72 |
| Local variable 'buf' could be declared final | 73 |
| Parameter 'n' is not assigned and could be declared final | 89 |
| Local variable 'buffer' could be declared final | 90 |
| Parameter 'message' is not assigned and could be declared final | 97 |
| Parameter 'facesContext' is not assigned and could be declared final | 97 |
org/apache/myfaces/tobago/util/EncodeAjaxCallback.java
| Violation | Line |
|---|---|
| The class 'EncodeAjaxCallback' has a Cyclomatic Complexity of 5 (Highest = 9). | 37 - 111 |
| Parameter 'component' is not assigned and could be declared final | 39 |
| Parameter 'facesContext' is not assigned and could be declared final | 39 |
| The method 'invokeContextCallback' has a Cyclomatic Complexity of 9. | 39 - 68 |
| Local variable 'reload' could be declared final | 41 |
| Local variable 'immediate' could be declared final | 43 |
| Local variable 'update' could be declared final | 45 |
| Deeply nested if..then statements are hard to read | 46 - 48 |
| Local variable 'layoutContainer' could be declared final | 53 |
| Local variable 'width' could be declared final | 54 |
| Local variable 'height' could be declared final | 55 |
| Local variable 'oldWidth' could be declared final | 56 |
| Local variable 'oldHeight' could be declared final | 57 |
| Parameter 'component' is not assigned and could be declared final | 76 |
| Parameter 'facesContext' is not assigned and could be declared final | 76 |
| Parameter 'component' is not assigned and could be declared final | 91 |
| Parameter 'facesContext' is not assigned and could be declared final | 91 |
| The method 'prepareRendererAll' has a Cyclomatic Complexity of 5. | 91 - 110 |
| Local variable 'renderer' could be declared final | 95 |
| Local variable 'it' could be declared final | 104 |
| Local variable 'child' could be declared final | 106 |
org/apache/myfaces/tobago/util/FacesVersion.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 48 - 50 |
| Avoid empty catch blocks | 48 - 50 |
| Parameter 'className' is not assigned and could be declared final | 57 |
| Avoid empty catch blocks | 67 - 69 |
| Avoid empty catch blocks | 67 - 69 |
| Avoid empty catch blocks | 71 - 73 |
| Avoid empty catch blocks | 71 - 73 |
org/apache/myfaces/tobago/util/FacetUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 30 - 56 |
| Parameter 'component' is not assigned and could be declared final | 38 |
| Parameter 'component' is not assigned and could be declared final | 42 |
| Parameter 'menu' is not assigned and could be declared final | 42 |
| Parameter 'component' is not assigned and could be declared final | 49 |
| Parameter 'component' is not assigned and could be declared final | 53 |
| Parameter 'menu' is not assigned and could be declared final | 53 |
org/apache/myfaces/tobago/util/LayoutInfo.java
| Violation | Line |
|---|---|
| The class 'LayoutInfo' has a Cyclomatic Complexity of 4 (Highest = 13). | 39 - 388 |
| This class has too many methods, consider refactoring it. | 39 - 388 |
| The class 'LayoutInfo' has a Cyclomatic Complexity of 4 (Highest = 13). | 39 - 388 |
| Parameter 'layoutTokens' is not assigned and could be declared final | 52 |
| Parameter 'space' is not assigned and could be declared final | 52 |
| Parameter 'cellCount' is not assigned and could be declared final | 52 |
| Parameter 'clientIdForLogging' is not assigned and could be declared final | 52 |
| Parameter 'layoutTokens' is not assigned and could be declared final | 56 |
| Parameter 'space' is not assigned and could be declared final | 56 |
| Parameter 'cellCount' is not assigned and could be declared final | 56 |
| The constructor 'LayoutInfo' has a Cyclomatic Complexity of 6. | 56 - 94 |
| Parameter 'ignoreMismatch' is not assigned and could be declared final | 57 |
| Parameter 'clientIdForLogging' is not assigned and could be declared final | 57 |
| The String literal " clientId='" appears 17 times in this file; the first occurrence is on line 72 | 72 |
| Parameter 'initValue' is not assigned and could be declared final | 96 |
| Parameter 'columns' is not assigned and could be declared final | 96 |
| Parameter 'index' is not assigned and could be declared final | 103 |
| Parameter 'space' is not assigned and could be declared final | 103 |
| Avoid reassigning parameters such as 'space' | 107 |
| Avoid reassigning parameters such as 'space' | 107 |
| Parameter 'index' is not assigned and could be declared final | 107 |
| Parameter 'force' is not assigned and could be declared final | 107 |
| The method 'update' has a Cyclomatic Complexity of 10. | 107 - 142 |
| The method 'update' has a Cyclomatic Complexity of 10. | 107 - 142 |
| These nested if statements could be combined | 130 - 136 |
| These nested if statements could be combined | 130 - 136 |
| Parameter 'list' is not assigned and could be declared final | 162 |
| Parameter 'tokens' is not assigned and could be declared final | 170 |
| Parameter 'tokens' is not assigned and could be declared final | 178 |
| Local variable 'sb' could be declared final | 179 |
| Parameter 'column' is not assigned and could be declared final | 191 |
| Local variable 'list' could be declared final | 208 |
| The method 'handleSpaceLeft' has a Cyclomatic Complexity of 13. | 215 - 249 |
| The method handleSpaceLeft() has an NPath complexity of 330 | 215 - 249 |
| The method 'handleSpaceLeft' has a Cyclomatic Complexity of 13. | 215 - 249 |
| Parameter 'currentSpaces' is not assigned and could be declared final | 252 |
| Local variable 'sb' could be declared final | 253 |
| Parameter 'space' is not assigned and could be declared final | 262 |
| Parameter 'i' is not assigned and could be declared final | 262 |
| Parameter 'portions' is not assigned and could be declared final | 274 |
| The method 'parsePortions' has a Cyclomatic Complexity of 9. | 274 - 302 |
| These nested if statements could be combined | 278 - 300 |
| These nested if statements could be combined | 278 - 300 |
| Local variable 'widthForPortions' could be declared final | 279 |
| Local variable 'token' could be declared final | 281 |
| Local variable 'portion' could be declared final | 283 |
| Local variable 'w' could be declared final | 284 |
| The String literal " from " appears 5 times in this file; the first occurrence is on line 288 | 288 |
| The String literal "set column " appears 5 times in this file; the first occurrence is on line 288 | 288 |
| The String literal " to with " appears 4 times in this file; the first occurrence is on line 289 | 289 |
| Parameter 'space' is not assigned and could be declared final | 334 |
| Parameter 'space' is not assigned and could be declared final | 338 |
| Parameter 'padding' is not assigned and could be declared final | 338 |
| The method 'parseColumnLayout' has a Cyclomatic Complexity of 12. | 338 - 378 |
| The method 'parseColumnLayout' has a Cyclomatic Complexity of 12. | 338 - 378 |
| Local variable 'token' could be declared final | 343 |
| Local variable 'w' could be declared final | 352 |
| Local variable 'percent' could be declared final | 361 |
| Local variable 'w' could be declared final | 362 |
org/apache/myfaces/tobago/util/LocaleUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 29 - 97 |
| Parameter 'value' is not assigned and could be declared final | 34 |
| Local variable 'strings' could be declared final | 36 |
| Parameter 'locale' is not assigned and could be declared final | 57 |
| Local variable 'locales' could be declared final | 60 |
| Parameter 'locale' is not assigned and could be declared final | 76 |
| Local variable 'prefix' could be declared final | 83 |
| Local variable 'locales' could be declared final | 84 |
org/apache/myfaces/tobago/util/MessageUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 43 - 159 |
| The class 'MessageUtils' has a Cyclomatic Complexity of 4 (Highest = 15). | 43 - 159 |
| The class 'MessageUtils' has a Cyclomatic Complexity of 4 (Highest = 15). | 43 - 159 |
| Parameter 'component' is not assigned and could be declared final | 51 |
| Parameter 'facesContext' is not assigned and could be declared final | 51 |
| Parameter 'severity' is not assigned and could be declared final | 51 |
| Parameter 'args' is not assigned and could be declared final | 52 |
| Parameter 'messageId' is not assigned and could be declared final | 52 |
| The method 'getMessage' has a Cyclomatic Complexity of 15. | 57 - 104 |
| The method getMessage() has an NPath complexity of 468 | 57 - 104 |
| The method 'getMessage' has a Cyclomatic Complexity of 15. | 57 - 104 |
| Parameter 'facesContext' is not assigned and could be declared final | 58 |
| Parameter 'locale' is not assigned and could be declared final | 58 |
| Parameter 'args' is not assigned and could be declared final | 59 |
| Parameter 'severity' is not assigned and could be declared final | 59 |
| Parameter 'messageId' is not assigned and could be declared final | 59 |
| Local variable 'appBundle' could be declared final | 61 |
| Local variable 'tobagoBundle' could be declared final | 66 |
| Local variable 'defBundle' could be declared final | 75 |
| Deeply nested if..then statements are hard to read | 76 - 78 |
| Deeply nested if..then statements are hard to read | 79 - 81 |
| Parameter 'bundle' is not assigned and could be declared final | 106 |
| Parameter 'key' is not assigned and could be declared final | 106 |
| Parameter 'facesContext' is not assigned and could be declared final | 114 |
| Parameter 'locale' is not assigned and could be declared final | 114 |
| Local variable 'bundleName' could be declared final | 115 |
| Avoid if (x != y) ..; else ..; | 116 |
| Parameter 'facesContext' is not assigned and could be declared final | 119 |
| Parameter 'locale' is not assigned and could be declared final | 119 |
| Parameter 'facesContext' is not assigned and could be declared final | 123 |
| Parameter 'locale' is not assigned and could be declared final | 123 |
| Parameter 'bundleName' is not assigned and could be declared final | 123 |
| Parameter 'component' is not assigned and could be declared final | 136 |
| Parameter 'facesContext' is not assigned and could be declared final | 136 |
| Local variable 'label' could be declared final | 137 |
| Parameter 'message' is not assigned and could be declared final | 152 |
| Parameter 'args' is not assigned and could be declared final | 152 |
| Parameter 'locale' is not assigned and could be declared final | 152 |
| Local variable 'format' could be declared final | 154 |
org/apache/myfaces/tobago/util/ProcessValidationsCallback.java
| Violation | Line |
|---|---|
| The class 'ProcessValidationsCallback' has a Cyclomatic Complexity of 5 (Highest = 4). | 28 - 41 |
| Parameter 'component' is not assigned and could be declared final | 30 |
| Parameter 'facesContext' is not assigned and could be declared final | 30 |
org/apache/myfaces/tobago/util/RequestUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 30 - 53 |
| The class 'RequestUtils' has a Cyclomatic Complexity of 4 (Highest = 5). | 30 - 53 |
| Parameter 'facesContext' is not assigned and could be declared final | 37 |
| The method 'ensureEncoding' has a Cyclomatic Complexity of 5. | 37 - 52 |
| Local variable 'requestObject' could be declared final | 38 |
| Local variable 'request' could be declared final | 41 |
| Do not add empty strings | 50 |
org/apache/myfaces/tobago/util/UpdateModelValuesCallback.java
| Violation | Line |
|---|---|
| The class 'UpdateModelValuesCallback' has a Cyclomatic Complexity of 5 (Highest = 4). | 28 - 41 |
| Parameter 'component' is not assigned and could be declared final | 30 |
| Parameter 'facesContext' is not assigned and could be declared final | 30 |
org/apache/myfaces/tobago/util/ValueBindingComparator.java
| Violation | Line |
|---|---|
| The class 'ValueBindingComparator' has a Cyclomatic Complexity of 3 (Highest = 11). | 34 - 132 |
| The class 'ValueBindingComparator' has a Cyclomatic Complexity of 3 (Highest = 11). | 34 - 132 |
| Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. | 38 |
| Private field 'var' could be made final; it is only initialized in the declaration or constructor. | 40 |
| Private field 'valueBinding' could be made final; it is only initialized in the declaration or constructor. | 42 |
| Parameter 'facesContext' is not assigned and could be declared final | 44 |
| Parameter 'var' is not assigned and could be declared final | 44 |
| Parameter 'valueBinding' is not assigned and could be declared final | 44 |
| Parameter 'reverse' is not assigned and could be declared final | 50 |
| Parameter 'facesContext' is not assigned and could be declared final | 50 |
| Parameter 'var' is not assigned and could be declared final | 50 |
| Parameter 'valueBinding' is not assigned and could be declared final | 50 |
| Parameter 'facesContext' is not assigned and could be declared final | 57 |
| Parameter 'var' is not assigned and could be declared final | 57 |
| Parameter 'comparator' is not assigned and could be declared final | 58 |
| Parameter 'valueBinding' is not assigned and could be declared final | 58 |
| Parameter 'facesContext' is not assigned and could be declared final | 65 |
| Parameter 'var' is not assigned and could be declared final | 65 |
| Parameter 'reverse' is not assigned and could be declared final | 66 |
| Parameter 'comparator' is not assigned and could be declared final | 66 |
| Parameter 'valueBinding' is not assigned and could be declared final | 66 |
| Parameter 'o' is not assigned and could be declared final | 73 |
| The method 'equals' has a Cyclomatic Complexity of 11. | 73 - 97 |
| The method 'equals' has a Cyclomatic Complexity of 11. | 73 - 97 |
| Avoid if (x != y) ..; else ..; | 86 |
| Avoid if (x != y) ..; else ..; | 89 |
| Avoid if (x != y) ..; else ..; | 92 |
| Avoid if (x != y) ..; else ..; | 101 |
| Avoid if (x != y) ..; else ..; | 102 |
| Avoid if (x != y) ..; else ..; | 103 |
| Parameter 'param1' is not assigned and could be declared final | 115 |
| Parameter 'param2' is not assigned and could be declared final | 115 |
org/apache/myfaces/tobago/util/ValueExpressionComparator.java
| Violation | Line |
|---|---|
| The class 'ValueExpressionComparator' has a Cyclomatic Complexity of 3 (Highest = 11). | 30 - 128 |
| The class 'ValueExpressionComparator' has a Cyclomatic Complexity of 3 (Highest = 11). | 30 - 128 |
| Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. | 34 |
| Private field 'var' could be made final; it is only initialized in the declaration or constructor. | 36 |
| Private field 'valueExpression' could be made final; it is only initialized in the declaration or constructor. | 38 |
| Parameter 'valueExpression' is not assigned and could be declared final | 40 |
| Parameter 'facesContext' is not assigned and could be declared final | 40 |
| Parameter 'var' is not assigned and could be declared final | 40 |
| Parameter 'valueExpression' is not assigned and could be declared final | 46 |
| Parameter 'facesContext' is not assigned and could be declared final | 46 |
| Parameter 'var' is not assigned and could be declared final | 46 |
| Parameter 'reverse' is not assigned and could be declared final | 47 |
| Parameter 'facesContext' is not assigned and could be declared final | 54 |
| Parameter 'var' is not assigned and could be declared final | 54 |
| Parameter 'valueExpression' is not assigned and could be declared final | 55 |
| Parameter 'comparator' is not assigned and could be declared final | 55 |
| Parameter 'facesContext' is not assigned and could be declared final | 62 |
| Parameter 'var' is not assigned and could be declared final | 62 |
| Parameter 'reverse' is not assigned and could be declared final | 63 |
| Parameter 'valueExpression' is not assigned and could be declared final | 63 |
| Parameter 'comparator' is not assigned and could be declared final | 63 |
| Parameter 'o' is not assigned and could be declared final | 70 |
| The method 'equals' has a Cyclomatic Complexity of 11. | 70 - 94 |
| The method 'equals' has a Cyclomatic Complexity of 11. | 70 - 94 |
| Avoid if (x != y) ..; else ..; | 83 |
| Avoid if (x != y) ..; else ..; | 86 |
| Avoid if (x != y) ..; else ..; | 89 |
| Avoid if (x != y) ..; else ..; | 98 |
| Avoid if (x != y) ..; else ..; | 99 |
| Avoid if (x != y) ..; else ..; | 100 |
| Parameter 'param1' is not assigned and could be declared final | 112 |
| Parameter 'param2' is not assigned and could be declared final | 112 |
org/apache/myfaces/tobago/util/VariableResolverUtils.java
| Violation | Line |
|---|---|
| Parameter 'context' is not assigned and could be declared final | 36 |
| Parameter 'variable' is not assigned and could be declared final | 36 |
| Parameter 'facesContext' is not assigned and could be declared final | 44 |
| Parameter 'context' is not assigned and could be declared final | 54 |
| Parameter 'variable' is not assigned and could be declared final | 54 |
org/apache/myfaces/tobago/util/XmlUtils.java
| Violation | Line |
|---|---|
| The class 'XmlUtils' has a Cyclomatic Complexity of 3 (Highest = 8). | 38 - 168 |
| Local variable 'len' could be declared final | 51 |
| Local variable 'buffer' could be declared final | 52 |
| Local variable 'buffer' could be declared final | 63 |
| The method 'appendEntityRef' has a Cyclomatic Complexity of 8. | 70 - 101 |
| Local variable 'propertiesElement' could be declared final | 113 - 114 |
| Local variable 'factory' could be declared final | 120 |
| Local variable 'builder' could be declared final | 126 |
| Local variable 'source' could be declared final | 128 |
| The method 'importProperties' has a Cyclomatic Complexity of 6. | 135 - 151 |
| Local variable 'entries' could be declared final | 136 |
| Local variable 'numEntries' could be declared final | 137 |
| Local variable 'start' could be declared final | 138 - 139 |
| Local variable 'child' could be declared final | 141 |
| Local variable 'entry' could be declared final | 143 |
| Local variable 'node' could be declared final | 145 |
| Local variable 'value' could be declared final | 146 |
| Local variable 'dtd' could be declared final | 157 - 161 |
| Local variable 'inputSource' could be declared final | 162 |
org/apache/myfaces/tobago/validator/ClearValidatorsActionListener.java
| Violation | Line |
|---|---|
| The class 'ClearValidatorsActionListener' has a Cyclomatic Complexity of 5 (Highest = 8). | 34 - 83 |
| Parameter 'actionEvent' is not assigned and could be declared final | 42 |
| The method 'processAction' has a Cyclomatic Complexity of 8. | 42 - 81 |
| Local variable 'source' could be declared final | 46 |
| Local variable 'clearValidatorsFieldIds' could be declared final | 47 - 48 |
| Local variable 'tokenizer' could be declared final | 56 - 57 |
| Local variable 'clearValidatorsFieldId' could be declared final | 59 |
| Local variable 'facesContext' could be declared final | 70 |
org/apache/myfaces/tobago/validator/FileItemValidator.java
| Violation | Line |
|---|---|
| The class 'FileItemValidator' has a Cyclomatic Complexity of 2 (Highest = 12). | 40 - 126 |
| The class 'FileItemValidator' has a Cyclomatic Complexity of 2 (Highest = 12). | 40 - 126 |
| Document empty constructor | 51 - 52 |
| Avoid unnecessary constructors - the compiler will generate these for you | 51 - 52 |
| Parameter 'component' is not assigned and could be declared final | 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 54 |
| Parameter 'value' is not assigned and could be declared final | 54 |
| The method 'validate' has a Cyclomatic Complexity of 12. | 54 - 86 |
| The method 'validate' has a Cyclomatic Complexity of 12. | 54 - 86 |
| Local variable 'file' could be declared final | 56 |
| Local variable 'facesMessage' could be declared final | 58 - 60 |
| Deeply nested if..then statements are hard to read | 67 - 70 |
| Deeply nested if..then statements are hard to read | 74 - 78 |
| Local variable 'facesMessage' could be declared final | 79 - 81 |
| Parameter 'maxSize' is not assigned and could be declared final | 92 |
| Parameter 'contentType' is not assigned and could be declared final | 102 |
| Parameter 'context' is not assigned and could be declared final | 106 |
| Parameter 'context' is not assigned and could be declared final | 113 |
| Parameter 'state' is not assigned and could be declared final | 113 |
| Local variable 'values' could be declared final | 114 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 123 |
org/apache/myfaces/tobago/validator/SubmittedValueLengthValidator.java
| Violation | Line |
|---|---|
| The class 'SubmittedValueLengthValidator' has a Cyclomatic Complexity of 3 (Highest = 9). | 38 - 136 |
| Document empty constructor | 44 - 45 |
| Parameter 'maximum' is not assigned and could be declared final | 47 |
| Overridable method 'setMaximum' called during object construction | 48 |
| Parameter 'minimum' is not assigned and could be declared final | 51 |
| Parameter 'maximum' is not assigned and could be declared final | 51 |
| Overridable method 'setMaximum' called during object construction | 52 |
| Overridable method 'setMinimum' called during object construction | 53 |
| Avoid if (x != y) ..; else ..; | 57 |
| Parameter 'minimum' is not assigned and could be declared final | 60 |
| Avoid if (x != y) ..; else ..; | 67 |
| Parameter 'maximum' is not assigned and could be declared final | 70 |
| Parameter 'facesContext' is not assigned and could be declared final | 76 |
| Parameter 'value' is not assigned and could be declared final | 76 |
| Parameter 'uiComponent' is not assigned and could be declared final | 76 |
| The method 'validate' has a Cyclomatic Complexity of 7. | 76 - 92 |
| Local variable 'submittedValue' could be declared final | 78 |
| Local variable 'args' could be declared final | 80 |
| Local variable 'facesMessage' could be declared final | 81 - 82 |
| Local variable 'args' could be declared final | 86 |
| Local variable 'facesMessage' could be declared final | 87 - 88 |
| Parameter 'context' is not assigned and could be declared final | 94 |
| Parameter 'context' is not assigned and could be declared final | 101 |
| Parameter 'state' is not assigned and could be declared final | 101 |
| Local variable 'values' could be declared final | 102 |
| Parameter 'o' is not assigned and could be declared final | 107 |
| The method 'equals' has a Cyclomatic Complexity of 9. | 107 - 128 |
| Local variable 'validator' could be declared final | 118 |
| Avoid if (x != y) ..; else ..; | 120 |
| Avoid if (x != y) ..; else ..; | 123 |
| Avoid if (x != y) ..; else ..; | 132 |
| Avoid if (x != y) ..; else ..; | 133 |
org/apache/myfaces/tobago/webapp/LogoutActionListener.java
| Violation | Line |
|---|---|
| The class 'LogoutActionListener' has a Cyclomatic Complexity of 5 (Highest = 4). | 34 - 59 |
| Parameter 'event' is not assigned and could be declared final | 38 |
| Local variable 'facesContext' could be declared final | 39 |
| Local variable 'externalContext' could be declared final | 40 |
| Local variable 'session' could be declared final | 41 |
| These nested if statements could be combined | 43 - 45 |
| These nested if statements could be combined | 43 - 45 |
| Local variable 'forward' could be declared final | 48 |
| New exception is thrown in catch block, original stack trace may be lost | 54 |
org/apache/myfaces/tobago/webapp/Secret.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 35 - 119 |
| Private field 'secret' could be made final; it is only initialized in the declaration or constructor. | 56 |
| Local variable 'bytes' could be declared final | 59 |
| Parameter 'bytes' is not assigned and could be declared final | 64 |
| Parameter 'bytes' is not assigned and could be declared final | 68 |
| Local variable 'builder' could be declared final | 69 |
| Parameter 'session' is not assigned and could be declared final | 116 |
org/apache/myfaces/tobago/webapp/SecretSessionListener.java
| Violation | Line |
|---|---|
| Parameter 'sessionEvent' is not assigned and could be declared final | 29 |
| Document empty method | 36 - 37 |
| Parameter 'se' is not assigned and could be declared final | 36 |
org/apache/myfaces/tobago/webapp/TobagoMultipartFormdataFilter.java
| Violation | Line |
|---|---|
| The class 'TobagoMultipartFormdataFilter' has a Cyclomatic Complexity of 4 (Highest = 6). | 69 - 130 |
| Parameter 'filterConfig' is not assigned and could be declared final | 76 |
| The method 'init' has a Cyclomatic Complexity of 5. | 76 - 96 |
| Local variable 'repositoryPath' could be declared final | 77 |
| Local variable 'file' could be declared final | 79 |
| Avoid if (x != y) ..; else ..; | 80 - 86 |
| Avoid if (x != y) ..; else ..; | 82 - 86 |
| Parameter 'response' is not assigned and could be declared final | 98 |
| Parameter 'chain' is not assigned and could be declared final | 98 |
| Parameter 'request' is not assigned and could be declared final | 98 |
| The method 'doFilter' has a Cyclomatic Complexity of 6. | 98 - 125 |
| Local variable 'contentType' could be declared final | 105 |
| Document empty method | 127 - 128 |
org/apache/myfaces/tobago/webapp/TobagoResponseWriter.java
| Violation | Line |
|---|---|
| This class has too many methods, consider refactoring it. | 38 - 221 |
| Parameter 'name' is not assigned and could be declared final | 49 |
| Parameter 'name' is not assigned and could be declared final | 90 |
| Parameter 'on' is not assigned and could be declared final | 90 |
| Parameter 'name' is not assigned and could be declared final | 99 |
| Parameter 'number' is not assigned and could be declared final | 99 |
| Parameter 'name' is not assigned and could be declared final | 106 |
| Parameter 'property' is not assigned and could be declared final | 106 |
| Parameter 'id' is not assigned and could be declared final | 113 |
| Parameter 'name' is not assigned and could be declared final | 120 |
| Parameter 'cssClass' is not assigned and could be declared final | 129 |
| Parameter 'classes' is not assigned and could be declared final | 137 |
| Parameter 'style' is not assigned and could be declared final | 154 |
| Parameter 'style' is not assigned and could be declared final | 169 |
| Parameter 'script' is not assigned and could be declared final | 173 |
| Parameter 'text' is not assigned and could be declared final | 194 |
| Parameter 'property' is not assigned and could be declared final | 201 |
| Local variable 'builder' could be declared final | 215 |
org/apache/myfaces/tobago/webapp/TobagoServletContextListener.java
| Violation | Line |
|---|---|
| The class 'TobagoServletContextListener' has a Cyclomatic Complexity of 4 (Highest = 5). | 33 - 87 |
| Parameter 'event' is not assigned and could be declared final | 37 |
| The method 'contextInitialized' has a Cyclomatic Complexity of 5. | 37 - 69 |
| Local variable 'servletContext' could be declared final | 43 |
| Local variable 'builder' could be declared final | 55 |
| Parameter 'event' is not assigned and could be declared final | 71 |
| Local variable 'servletContext' could be declared final | 77 |
org/apache/myfaces/tobago/webapp/WeblogicWorkaroundServlet.java
| Violation | Line |
|---|---|
| The class 'WeblogicWorkaroundServlet' has a Cyclomatic Complexity of 6 (Highest = 8). | 41 - 94 |
| The method 'init' has a Cyclomatic Complexity of 8. | 47 - 79 |
| Local variable 'factory' could be declared final | 51 - 52 |
| Local variable 'tobagoConfig' could be declared final | 65 - 66 |
| Parameter 'className' is not assigned and could be declared final | 81 |
| Local variable 'aClass' could be declared final | 83 |
| Local variable 'listener' could be declared final | 84 |