FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
Files
org.apache.myfaces.tobago.application.LabelValueExpressionFacesMessage
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.application.LabelValueExpressionFacesMessage is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 28-57 | Low |
org.apache.myfaces.tobago.component.UINamingContainer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.tobago.component.UINamingContainer shadows the simple name of the superclass javax.faces.component.UINamingContainer | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 22 | High |
org.apache.myfaces.tobago.context.Markup
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.context.Markup is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 61-494 | Low |
org.apache.myfaces.tobago.context.ThemeImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.context.ThemeImpl.getScriptResources(boolean) may expose internal representation by returning ThemeImpl.productionScripts | MALICIOUS_CODE | EI_EXPOSE_REP | 198 | Medium |
| org.apache.myfaces.tobago.context.ThemeImpl.getScriptResources(boolean) may expose internal representation by returning ThemeImpl.scripts | MALICIOUS_CODE | EI_EXPOSE_REP | 200 | Medium |
| org.apache.myfaces.tobago.context.ThemeImpl.getStyleResources(boolean) may expose internal representation by returning ThemeImpl.productionStyles | MALICIOUS_CODE | EI_EXPOSE_REP | 207 | Medium |
| org.apache.myfaces.tobago.context.ThemeImpl.getStyleResources(boolean) may expose internal representation by returning ThemeImpl.styles | MALICIOUS_CODE | EI_EXPOSE_REP | 209 | Medium |
org.apache.myfaces.tobago.context.ThemeResources
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.context.ThemeResources is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 38-201 | Low |
org.apache.myfaces.tobago.context.ThemeScript
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.context.ThemeScript is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 27-64 | Low |
org.apache.myfaces.tobago.context.ThemeStyle
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.context.ThemeStyle is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 25-31 | Low |
org.apache.myfaces.tobago.context.TobagoContext
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.context.TobagoContext is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 42-150 | Low |
org.apache.myfaces.tobago.context.TransientStateHolder
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The field org.apache.myfaces.tobago.context.TransientStateHolder.object is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Medium |
org.apache.myfaces.tobago.convert.DateTimeConverter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.tobago.convert.DateTimeConverter shadows the simple name of the superclass javax.faces.convert.DateTimeConverter | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 48-173 | High |
org.apache.myfaces.tobago.event.MethodExpressionTreeExpansionListener
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Private method org.apache.myfaces.tobago.event.MethodExpressionTreeExpansionListener.elContext() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 49 | Low |
org.apache.myfaces.tobago.event.MethodExpressionTreeSelectedListener
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Private method org.apache.myfaces.tobago.event.MethodExpressionTreeSelectedListener.elContext() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 48 | Low |
org.apache.myfaces.tobago.event.ResetInputActionListener
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.apache.myfaces.tobago.event.ResetInputActionListener(String[]) may expose internal representation by storing an externally mutable object into ResetInputActionListener.clientIds | MALICIOUS_CODE | EI_EXPOSE_REP2 | 38 | Medium |
org.apache.myfaces.tobago.facelets.AttributeHandler$ConstantMethodExpression
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Self assignment of field AttributeHandler$ConstantMethodExpression.transientFlag in org.apache.myfaces.tobago.facelets.AttributeHandler$ConstantMethodExpression.setTransient(boolean) | CORRECTNESS | SA_FIELD_SELF_ASSIGNMENT | 425 | High |
| org.apache.myfaces.tobago.facelets.AttributeHandler$ConstantMethodExpression is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 365-430 | Low |
| Unwritten field: org.apache.myfaces.tobago.facelets.AttributeHandler$ConstantMethodExpression.transientFlag | CORRECTNESS | UWF_UNWRITTEN_FIELD | 425 | Low |
org.apache.myfaces.tobago.facelets.EventHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to faceletContext in org.apache.myfaces.tobago.facelets.EventHandler.applyAttachedObject(FacesContext, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 138 | Medium |
| org.apache.myfaces.tobago.facelets.EventHandler.AJAX_BEHAVIOR_LISTENER_SIG should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 71 | Low |
org.apache.myfaces.tobago.facelets.HackResourceExtentionFilter$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.tobago.facelets.HackResourceExtentionFilter$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 65-79 | Low |
org.apache.myfaces.tobago.facelets.SuggestMethodRule
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.facelets.SuggestMethodRule.SUGGEST_METHOD should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 34 | Medium |
org.apache.myfaces.tobago.internal.behavior.EventBehavior
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxed value is unboxed and then immediately reboxed in org.apache.myfaces.tobago.internal.behavior.EventBehavior.isDisabled() | PERFORMANCE | BX_UNBOXING_IMMEDIATELY_REBOXED | 171 | Medium |
| Boxed value is unboxed and then immediately reboxed in org.apache.myfaces.tobago.internal.behavior.EventBehavior.isImmediate() | PERFORMANCE | BX_UNBOXING_IMMEDIATELY_REBOXED | 181 | Medium |
org.apache.myfaces.tobago.internal.component.AbstractUIGridLayout
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxed value is unboxed and then immediately reboxed in org.apache.myfaces.tobago.internal.component.AbstractUIGridLayout.layout(int, int, List) | PERFORMANCE | BX_UNBOXING_IMMEDIATELY_REBOXED | 188 | Medium |
org.apache.myfaces.tobago.internal.component.AbstractUISheet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of sheetState, which is known to be non-null in org.apache.myfaces.tobago.internal.component.AbstractUISheet.processUpdates(FacesContext) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 344 | Low |
org.apache.myfaces.tobago.internal.component.AbstractUISplitLayout
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: org.apache.myfaces.tobago.internal.component.AbstractUISplitLayout.submittedLayout | PERFORMANCE | UUF_UNUSED_FIELD | Not available | Medium |
org.apache.myfaces.tobago.internal.component.AbstractUIStars
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive org.apache.myfaces.tobago.internal.component.AbstractUIStars.processEvent(ComponentSystemEvent) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 49 | High |
org.apache.myfaces.tobago.internal.config.TobagoConfigBuilder
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.tobago.internal.config.TobagoConfigBuilder.configFromClasspath(List) | STYLE | REC_CATCH_EXCEPTION | 118 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.tobago.internal.config.TobagoConfigBuilder.init() | STYLE | REC_CATCH_EXCEPTION | 78 | Low |
org.apache.myfaces.tobago.internal.config.TobagoConfigEntityResolver
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Usage of GetResource in org.apache.myfaces.tobago.internal.config.TobagoConfigEntityResolver.resolveEntity(String, String) may be unsafe if class is extended | BAD_PRACTICE | UI_INHERITANCE_UNSAFE_GETRESOURCE | 59 | Low |
org.apache.myfaces.tobago.internal.config.TobagoConfigImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.myfaces.tobago.internal.config.TobagoConfigImpl.defaultValidatorInfo; locked 57% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 298 | Medium |
org.apache.myfaces.tobago.internal.config.TobagoConfigParser
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Usage of GetResource in org.apache.myfaces.tobago.internal.config.TobagoConfigParser.validate(URL, TobagoConfigVersion) may be unsafe if class is extended | BAD_PRACTICE | UI_INHERITANCE_UNSAFE_GETRESOURCE | 493 | Low |
org.apache.myfaces.tobago.internal.context.DateTimeI18n
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.internal.context.DateTimeI18n.getDayNames() may expose internal representation by returning DateTimeI18n.dayNames | MALICIOUS_CODE | EI_EXPOSE_REP | 107 | Medium |
| org.apache.myfaces.tobago.internal.context.DateTimeI18n.getDayNamesMin() may expose internal representation by returning DateTimeI18n.dayNamesMin | MALICIOUS_CODE | EI_EXPOSE_REP | 115 | Medium |
| org.apache.myfaces.tobago.internal.context.DateTimeI18n.getDayNamesShort() may expose internal representation by returning DateTimeI18n.dayNamesShort | MALICIOUS_CODE | EI_EXPOSE_REP | 111 | Medium |
| org.apache.myfaces.tobago.internal.context.DateTimeI18n.getMonthNames() may expose internal representation by returning DateTimeI18n.monthNames | MALICIOUS_CODE | EI_EXPOSE_REP | 99 | Medium |
| org.apache.myfaces.tobago.internal.context.DateTimeI18n.getMonthNamesShort() may expose internal representation by returning DateTimeI18n.monthNamesShort | MALICIOUS_CODE | EI_EXPOSE_REP | 103 | Medium |
org.apache.myfaces.tobago.internal.context.Nonce
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.internal.context.Nonce is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 33-48 | Low |
org.apache.myfaces.tobago.internal.renderkit.renderer.ColumnRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Private method org.apache.myfaces.tobago.internal.renderkit.renderer.ColumnRenderer.isPure(AbstractUIColumn) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 40-45 | Low |
org.apache.myfaces.tobago.internal.renderkit.renderer.CommandRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.tobago.internal.renderkit.renderer.CommandRendererBase.getCssItems(FacesContext, AbstractUICommand) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 251 | Low |
| Should org.apache.myfaces.tobago.internal.renderkit.renderer.CommandRendererBase.getOuterCssItems(FacesContext, AbstractUICommand) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 245 | Low |
org.apache.myfaces.tobago.internal.renderkit.renderer.PageRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of locale in org.apache.myfaces.tobago.internal.renderkit.renderer.PageRenderer.encodeBeginInternal(FacesContext, AbstractUIPage) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 242 | Medium |
| Unwritten field: org.apache.myfaces.tobago.internal.renderkit.renderer.PageRenderer.projectStage | CORRECTNESS | UWF_UNWRITTEN_FIELD | 165 | Medium |
org.apache.myfaces.tobago.internal.renderkit.renderer.SelectManyCheckboxRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to markup in org.apache.myfaces.tobago.internal.renderkit.renderer.SelectManyCheckboxRenderer.encodeBeginField(FacesContext, AbstractUISelectManyCheckbox) | STYLE | DLS_DEAD_LOCAL_STORE | 59 | Medium |
| Should org.apache.myfaces.tobago.internal.renderkit.renderer.SelectManyCheckboxRenderer.getRenderRangeList(AbstractUISelectManyCheckbox, AbstractUISelectReference) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 139 | Low |
org.apache.myfaces.tobago.internal.renderkit.renderer.SelectManyRendererBase$SelectItemsIterator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of itemValue in org.apache.myfaces.tobago.internal.renderkit.renderer.SelectManyRendererBase$SelectItemsIterator.next() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 698 | Medium |
| SelectManyRendererBase$SelectItemsIterator.currentUISelectItems not initialized in constructor and dereferenced in org.apache.myfaces.tobago.internal.renderkit.renderer.SelectManyRendererBase$SelectItemsIterator.next() | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 656 | Low |
org.apache.myfaces.tobago.internal.renderkit.renderer.SelectOneRadioRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to markup in org.apache.myfaces.tobago.internal.renderkit.renderer.SelectOneRadioRenderer.encodeBeginField(FacesContext, AbstractUISelectOneRadio) | STYLE | DLS_DEAD_LOCAL_STORE | 61 | Medium |
| Should org.apache.myfaces.tobago.internal.renderkit.renderer.SelectOneRadioRenderer.getRenderRangeList(AbstractUISelectOneRadio, AbstractUISelectReference) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 138 | Low |
org.apache.myfaces.tobago.internal.renderkit.renderer.TreeNodeRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to treeSelect in org.apache.myfaces.tobago.internal.renderkit.renderer.TreeNodeRenderer.decodeInternal(FacesContext, AbstractUITreeNode) | STYLE | DLS_DEAD_LOCAL_STORE | 102 | Medium |
org.apache.myfaces.tobago.internal.util.CookieUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to path in org.apache.myfaces.tobago.internal.util.CookieUtils.removeThemeNameCookie(HttpServletRequest, HttpServletResponse) | STYLE | DLS_DEAD_LOCAL_STORE | 110 | Medium |
org.apache.myfaces.tobago.internal.util.SelectItemUtils$SelectItemsIterator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to attributeMap in org.apache.myfaces.tobago.internal.util.SelectItemUtils$SelectItemsIterator.next() | STYLE | DLS_DEAD_LOCAL_STORE | 218 | Medium |
org.apache.myfaces.tobago.internal.util.StringUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Comparison of String parameter using == or != in org.apache.myfaces.tobago.internal.util.StringUtils.equalsIgnoreCaseAndWhitespace(String, String) | BAD_PRACTICE | ES_COMPARING_PARAMETER_STRING_WITH_EQ | 101 | High |
| Should org.apache.myfaces.tobago.internal.util.StringUtils.split(String, char) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 175 | Low |
| Should org.apache.myfaces.tobago.internal.util.StringUtils.split(String, String) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 213 | Low |
org.apache.myfaces.tobago.internal.util.WriterHelper
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.internal.util.WriterHelper.ISO8859_1_ENTITIES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 130 | Medium |
org.apache.myfaces.tobago.internal.webapp.DebugResponseWriterWrapper
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.internal.webapp.DebugResponseWriterWrapper.writeComment(Object) checks to see if result of String.indexOf is positive | STYLE | RV_CHECK_FOR_POSITIVE_INDEXOF | 62 | Low |
org.apache.myfaces.tobago.internal.webapp.TobagoResponseWriterBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.internal.webapp.TobagoResponseWriterBase.XML_VERSION_1_0_ENCODING_UTF_8_CHARS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 43 | Medium |
org.apache.myfaces.tobago.internal.webapp.TobagoResponseWriterBase$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.tobago.internal.webapp.TobagoResponseWriterBase$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 291-294 | Low |
org.apache.myfaces.tobago.layout.Measure
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.myfaces.tobago.layout.Measure.valueOf(String, Measure$Unit) | I18N | DM_CONVERT_CASE | 116 | Low |
org.apache.myfaces.tobago.layout.Measure$Unit
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase() in new org.apache.myfaces.tobago.layout.Measure$Unit(String, int) | I18N | DM_CONVERT_CASE | 217 | Low |
org.apache.myfaces.tobago.layout.MeasureList
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.layout.MeasureList is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 31-78 | Low |
org.apache.myfaces.tobago.layout.SegmentMeasureList
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.layout.SegmentMeasureList is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 27-37 | Low |
org.apache.myfaces.tobago.model.ExpandedState
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.model.ExpandedState is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 45-250 | Low |
org.apache.myfaces.tobago.model.ScrollPosition
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.model.ScrollPosition is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 30-67 | Low |
org.apache.myfaces.tobago.model.SelectItem
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.myfaces.tobago.model.SelectItem shadows the simple name of the superclass javax.faces.model.SelectItem | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 31-116 | High |
org.apache.myfaces.tobago.model.SelectedState
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.model.SelectedState is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 30-100 | Low |
org.apache.myfaces.tobago.model.SuggestFilter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.myfaces.tobago.model.SuggestFilter.getValue() | I18N | DM_CONVERT_CASE | 33 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.myfaces.tobago.model.SuggestFilter.parse(String) | I18N | DM_CONVERT_CASE | 40 | Low |
org.apache.myfaces.tobago.model.TreePath
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.model.TreePath.getPath() may expose internal representation by returning TreePath.path | MALICIOUS_CODE | EI_EXPOSE_REP | 96 | Medium |
| org.apache.myfaces.tobago.model.TreePath is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 58-131 | Low |
org.apache.myfaces.tobago.model.TreeState
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.model.TreeState is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 31-55 | Low |
org.apache.myfaces.tobago.renderkit.css.BootstrapClass
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Test for floating point equality in org.apache.myfaces.tobago.renderkit.css.BootstrapClass.valueOf(Measure, Attributes) | STYLE | FE_FLOATING_POINT_EQUALITY | 819 | Low |
org.apache.myfaces.tobago.renderkit.css.CustomClass
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.renderkit.css.CustomClass is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 38-95 | Low |
org.apache.myfaces.tobago.renderkit.css.Icons
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase() in new org.apache.myfaces.tobago.renderkit.css.Icons(String, int) | I18N | DM_CONVERT_CASE | 68 | Low |
org.apache.myfaces.tobago.renderkit.css.TobagoClass
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.tobago.renderkit.css.TobagoClass.createMarkup(Markup) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 300 | Low |
org.apache.myfaces.tobago.renderkit.css.TobagoClass$MarkupClass
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.renderkit.css.TobagoClass$MarkupClass is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 304-317 | Low |
org.apache.myfaces.tobago.util.ComponentUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.util.ComponentUtils.ACTION_LISTENER_ARGS is a mutable array | MALICIOUS_CODE | MS_MUTABLE_ARRAY | 81 | High |
| org.apache.myfaces.tobago.util.ComponentUtils.VALIDATOR_ARGS is a mutable array | MALICIOUS_CODE | MS_MUTABLE_ARRAY | 83 | High |
| org.apache.myfaces.tobago.util.ComponentUtils.VALUE_CHANGE_LISTENER_ARGS is a mutable array | MALICIOUS_CODE | MS_MUTABLE_ARRAY | 82 | High |
org.apache.myfaces.tobago.util.DebugPhaseListener
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.util.DebugPhaseListener.beforePhase(PhaseEvent) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 123 | Medium |
org.apache.myfaces.tobago.util.ValueExpressionComparator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.util.ValueExpressionComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 34-97 | Low |
org.apache.myfaces.tobago.util.WebXmlUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.apache.myfaces.tobago.util.WebXmlUtils.init() | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 108 | Medium |
| Redundant nullcheck of input, which is known to be non-null in org.apache.myfaces.tobago.util.WebXmlUtils.getWebXml(DocumentBuilder, URL) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 155 | Low |
| Redundant nullcheck of exceptionType which is known to be null in org.apache.myfaces.tobago.util.WebXmlUtils.init() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 108 | Low |
org.apache.myfaces.tobago.validator.FileItemValidator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.tobago.validator.FileItemValidator.getContentType() may expose internal representation by returning FileItemValidator.contentType | MALICIOUS_CODE | EI_EXPOSE_REP | 97 | Medium |
| org.apache.myfaces.tobago.validator.FileItemValidator.setContentType(String[]) may expose internal representation by storing an externally mutable object into FileItemValidator.contentType | MALICIOUS_CODE | EI_EXPOSE_REP2 | 101 | Medium |