PMD Results

The following document contains the results of PMD 3.7.

Files

org/apache/myfaces/tobago/security/CheckAuthorisationMethodBinding.java

ViolationLine
The class 'CheckAuthorisationMethodBinding' has a Cyclomatic Complexity of 3 (Highest = 10).46 - 184
Document empty constructor52 - 53
Parameter 'facesContext' is not assigned and could be declared final63
Parameter 'objects' is not assigned and could be declared final67
Parameter 'facesContext' is not assigned and could be declared final67
Parameter 'facesContext' is not assigned and could be declared final82
The method 'isAuthorized' has a Cyclomatic Complexity of 10.82 - 115
Local variable could be declared final84
Local variable could be declared final96
Local variable could be declared final101
Parameter 'facesContext' is not assigned and could be declared final116
The method 'getSecurityAnnotation' has a Cyclomatic Complexity of 6.116 - 147
Local variable could be declared final124
Local variable could be declared final126
Local variable could be declared final127
Local variable could be declared final129 - 130
Local variable could be declared final133
Deeply nested if..then statements are hard to read135 - 137
Parameter 'annotatedElement' is not assigned and could be declared final148
Parameter 'facesContext' is not assigned and could be declared final164
Parameter 'facesContext' is not assigned and could be declared final170
Parameter 'savedState' is not assigned and could be declared final170
Local variable could be declared final171
Parameter 'bool' is not assigned and could be declared final179

org/apache/myfaces/tobago/security/ApplicationImpl.java

ViolationLine
Private field 'application' could be made final; it is only initialized in the declaration or constructor.45
Parameter 'actionListener' is not assigned and could be declared final58
Parameter 'locale' is not assigned and could be declared final66
Parameter 's' is not assigned and could be declared final74
Parameter 's' is not assigned and could be declared final82
Parameter 'navigationHandler' is not assigned and could be declared final90
Parameter 'propertyResolver' is not assigned and could be declared final98
Parameter 'variableResolver' is not assigned and could be declared final106
Parameter 'viewHandler' is not assigned and could be declared final114
Parameter 'stateManager' is not assigned and could be declared final122
Parameter 's1' is not assigned and could be declared final126
Parameter 's' is not assigned and could be declared final126
Parameter 's' is not assigned and could be declared final130
Parameter 'facesContext' is not assigned and could be declared final134
Parameter 'valueBinding' is not assigned and could be declared final134
Parameter 's' is not assigned and could be declared final134
Parameter 's1' is not assigned and could be declared final143
Parameter 's' is not assigned and could be declared final143
Parameter 'aClass' is not assigned and could be declared final147
Parameter 's' is not assigned and could be declared final147
Parameter 's' is not assigned and could be declared final151
Parameter 'aClass' is not assigned and could be declared final155
Parameter 'classes' is not assigned and could be declared final167
Parameter 's' is not assigned and could be declared final167
Parameter 'collection' is not assigned and could be declared final175
Parameter 's1' is not assigned and could be declared final179
Parameter 's' is not assigned and could be declared final179
Parameter 's' is not assigned and could be declared final183
Parameter 's' is not assigned and could be declared final191

org/apache/myfaces/tobago/security/ApplicationFactoryImpl.java

ViolationLine
Private field 'applicationFactory' could be made final; it is only initialized in the declaration or constructor.35
Parameter 'application' is not assigned and could be declared final48