PMD Results

The following document contains the results of PMD 3.7.

Files

org/apache/myfaces/tobago/fileupload/FileUploadFacesContextFactoryImpl.java

ViolationLine
The class 'FileUploadFacesContextFactoryImpl' has a Cyclomatic Complexity of 5 (Highest = 5).62 - 131
Private field 'facesContextFactory' could be made final; it is only initialized in the declaration or constructor.64
Private field 'repositoryPath' could be made final; it is only initialized in the declaration or constructor.65
Private field 'maxSize' could be made final; it is only initialized in the declaration or constructor.66
The constructor 'FileUploadFacesContextFactoryImpl' has a Cyclomatic Complexity of 5.68 - 106
Avoid if (x != y) ..; else ..;82 - 90
Avoid if (x != y) ..; else ..;85 - 90
Avoid empty catch blocks92 - 94
Avoid empty catch blocks92 - 94
Must handle exceptions92 - 94
Avoid empty catch blocks98 - 100
Avoid empty catch blocks98 - 100
Must handle exceptions98 - 100
Avoid empty catch blocks101 - 103
Avoid empty catch blocks101 - 103
Must handle exceptions101 - 103
Avoid reassigning parameters such as 'request'108
Parameter 'context' is not assigned and could be declared final108
Parameter 'lifecycle' is not assigned and could be declared final108
Parameter 'response' is not assigned and could be declared final108
Local variable could be declared final111
When doing a String.toLowerCase()/toUpperCase() call, use a Locale112
Local variable could be declared final120
Local variable could be declared final122