MyFaces Shared Tomahawk - FindBugs Bug Detector Report

Apache MyFaces

Documentation

Project Documentation

Foundation

FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.9

Threshold is low

Effort is min

Summary

Classes	Bugs	Errors	Missing Classes
142	140	0	1

Files

Class	Bugs
org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils	4
org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils$1	1
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML	49
org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlButtonRendererBase	1
org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlCheckboxRendererBase	3
org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlFormRendererBase	3
org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlGroupRendererBase	1
org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlLinkRendererBase	1
org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRadioRendererBase	5
org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRendererUtils	7
org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlResponseWriterImpl	4
org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlSecretRendererBase	1
org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlTableRendererBase	8
org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlTextRendererBase	1
org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlTextareaRendererBase	1
org.apache.myfaces.shared_tomahawk.renderkit.html.util.HTMLEncoder	2
org.apache.myfaces.shared_tomahawk.renderkit.html.util.JavascriptUtils	2
org.apache.myfaces.shared_tomahawk.taglib.UIComponentBodyELTagBase	1
org.apache.myfaces.shared_tomahawk.test.ClassElementHandler	1
org.apache.myfaces.shared_tomahawk.trace.TracingIterator	1
org.apache.myfaces.shared_tomahawk.util.ClassUtils	2
org.apache.myfaces.shared_tomahawk.util.ExceptionUtils	1
org.apache.myfaces.shared_tomahawk.util.LocaleUtils	1
org.apache.myfaces.shared_tomahawk.util.MessageUtils	5
org.apache.myfaces.shared_tomahawk.util.ParametrizableFacesMessage	3
org.apache.myfaces.shared_tomahawk.util.StateUtils	28
org.apache.myfaces.shared_tomahawk.util.StringUtils	1
org.apache.myfaces.shared_tomahawk.util.servlet.SourceCodeServlet	1
org.apache.myfaces.shared_tomahawk.webapp.webxml.WebXmlParser	1

org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils

Bug	Category	Details	Line	Priority
instanceof will always return true in org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils.getConvertedUISelectOneValue(FacesContext, UISelectOne, Object), since all String are instances of String	STYLE	BC_VACUOUS_INSTANCEOF	735	Medium
Method org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils.getViewSequence(FacesContext) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead	PERFORMANCE	DM_NUMBER_CTOR	919	Medium
Can't close content since it is always null in org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils.loadResourceFile(FacesContext, String)	CORRECTNESS	NP_CLOSING_NULL	1090	High
Possible null pointer dereference of content in org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils.loadResourceFile(FacesContext, String)	CORRECTNESS	NP_NULL_ON_SOME_PATH	1109	Medium

org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils$1

Bug	Category	Details	Line	Priority
org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils$1 defines equals and uses Object.hashCode()	BAD_PRACTICE	HE_EQUALS_USE_HASHCODE	85	Medium

org.apache.myfaces.shared_tomahawk.renderkit.html.HTML

Bug	Category	Details	Line	Priority
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.ANCHOR_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	205	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	218	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES_WITHOUT_ONCLICK_WITHOUT_STYLE should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	228	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES_WITHOUT_STYLE should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	223	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.BUTTON_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	323	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.BUTTON_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	328	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.BUTTON_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONCLICK should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	332	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.COMMON_FIELD_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	138	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.COMMON_FIELD_EVENT_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	89	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.COMMON_FIELD_EVENT_ATTRIBUTES_WITHOUT_ONFOCUS should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	97	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.COMMON_FIELD_EVENT_ATTRIBUTES_WITHOUT_ONSELECT_AND_ONCHANGE should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	104	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	165	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONCLICK should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	185	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS_AND_ONCLICK should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	180	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_STYLE should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	170	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	149	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES_WITHOUT_ONCLICK should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	157	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES_WITHOUT_ONCLICK_WITHOUT_STYLE should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	161	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES_WITHOUT_ONMOUSEOVER_AND_ONMOUSEOUT should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	190	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES_WITHOUT_STYLE should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	153	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.EVENT_HANDLER_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	81	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.EVENT_HANDLER_ATTRIBUTES_WITHOUT_ONCLICK should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	58	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.EVENT_HANDLER_ATTRIBUTES_WITHOUT_ONMOUSEOVER_AND_ONMOUSEOUT should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	70	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.FORM_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	239	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.FORM_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	248	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.IMG_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	263	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.IMG_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	276	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.INPUT_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	290	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.INPUT_FILE_UPLOAD_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	401	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	298	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_STYLE should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	302	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.LABEL_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	343	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.MESSAGE_PASSTHROUGH_ATTRIBUTES_WITHOUT_TITLE_STYLE_AND_STYLE_CLASS should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	418	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.SELECT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	358	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.SELECT_TABLE_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	425	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.TABLE_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	368	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.TABLE_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	379	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.TEXTAREA_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	388	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.TEXTAREA_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	395	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.UL_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	429	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.UNIVERSAL_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	125	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.UNIVERSAL_ATTRIBUTES_WITHOUT_STYLE should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	117	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.COMMON_FIELD_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	143	Low
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	175	Low
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.IMG_PASSTHROUGH_ATTRIBUTES_WITHOUT_ONMOUSEOVER_AND_ONMOUSEOUT should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	280	Low
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.INPUT_FILE_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	405	Low
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS_AND_ONCLICK should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	307	Low
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.LABEL_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	350	Low
org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.UL_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected	MALICIOUS_CODE	MS_OOI_PKGPROTECT	433	Low

org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlButtonRendererBase

Bug	Category	Details	Line	Priority
Dead store to nestingForm in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlButtonRendererBase.buildOnClick(UIComponent, FacesContext, ResponseWriter)	STYLE	DLS_DEAD_LOCAL_STORE	197	Medium

org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlCheckboxRendererBase

Bug	Category	Details	Line	Priority
Unchecked/unconfirmed cast from javax.faces.model.SelectItem to javax.faces.model.SelectItemGroup in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlCheckboxRendererBase.renderGroupOrItemCheckbox(FacesContext, UIComponent, SelectItem, boolean, Set, Converter, boolean, Integer)	STYLE	BC_UNCONFIRMED_CAST	176	Low
Method org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlCheckboxRendererBase.renderCheckboxList(FacesContext, UISelectMany) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead	PERFORMANCE	DM_NUMBER_CTOR	121	Medium
Method org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlCheckboxRendererBase.renderGroupOrItemCheckbox(FacesContext, UIComponent, SelectItem, boolean, Set, Converter, boolean, Integer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead	PERFORMANCE	DM_NUMBER_CTOR	181	Medium

org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlFormRendererBase

Bug	Category	Details	Line	Priority
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIForm in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlFormRendererBase.decode(FacesContext, UIComponent)	STYLE	BC_UNCONFIRMED_CAST	178	Low
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIForm in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlFormRendererBase.encodeBegin(FacesContext, UIComponent)	STYLE	BC_UNCONFIRMED_CAST	59	Low
Private method org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlFormRendererBase.getAcceptCharset(UIComponent) is never called	PERFORMANCE	UPM_UNCALLED_PRIVATE_METHOD	222	Medium

org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlGroupRendererBase

Bug	Category	Details	Line	Priority
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.html.HtmlPanelGroup in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlGroupRendererBase.encodeEnd(FacesContext, UIComponent)	STYLE	BC_UNCONFIRMED_CAST	65	Low

org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlLinkRendererBase

Bug	Category	Details	Line	Priority
Private method org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlLinkRendererBase.renderLinkParameter(String, Object, StringBuffer, String, UIComponent) is never called	PERFORMANCE	UPM_UNCALLED_PRIVATE_METHOD	532	Low

org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRadioRendererBase

Bug	Category	Details	Line	Priority
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectOne in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRadioRendererBase.encodeEnd(FacesContext, UIComponent)	STYLE	BC_UNCONFIRMED_CAST	55	Low
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectOne in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRadioRendererBase.getConvertedValue(FacesContext, UIComponent, Object)	STYLE	BC_UNCONFIRMED_CAST	303	Low
Unchecked/unconfirmed cast from javax.faces.model.SelectItem to javax.faces.model.SelectItemGroup in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRadioRendererBase.renderGroupOrItemRadio(FacesContext, UIComponent, SelectItem, Object, Converter, boolean, Integer)	STYLE	BC_UNCONFIRMED_CAST	166	Low
Method org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRadioRendererBase.encodeEnd(FacesContext, UIComponent) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead	PERFORMANCE	DM_NUMBER_CTOR	99	Medium
Method org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRadioRendererBase.renderGroupOrItemRadio(FacesContext, UIComponent, SelectItem, Object, Converter, boolean, Integer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead	PERFORMANCE	DM_NUMBER_CTOR	170	Medium

org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRendererUtils

Bug	Category	Details	Line	Priority
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRendererUtils.findUIOutputConverterFailSafe(FacesContext, UIComponent)	STYLE	BC_UNCONFIRMED_CAST	393	Low
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectMany in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRendererUtils.findUISelectManyConverterFailsafe(FacesContext, UIComponent)	STYLE	BC_UNCONFIRMED_CAST	380	Low
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectMany in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRendererUtils.getSubmittedOrSelectedValuesAsSet(boolean, UIComponent, FacesContext, Converter)	STYLE	BC_UNCONFIRMED_CAST	350	Low
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectOne in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRendererUtils.getSubmittedOrSelectedValuesAsSet(boolean, UIComponent, FacesContext, Converter)	STYLE	BC_UNCONFIRMED_CAST	357	Low
public static org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRendererUtils.getSupportedContentTypes() may expose internal representation by returning HtmlRendererUtils.SUPPORTED_CONTENT_TYPES	MALICIOUS_CODE	MS_EXPOSE_REP	1695	Medium
org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRendererUtils.DEFAULT_CHAR_ENCODING isn't final but should be	MALICIOUS_CODE	MS_SHOULD_BE_FINAL	1606	Low
Method call in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRendererUtils.renderDisplayValueOnlyForSelects(FacesContext, UIComponent) passes null for nonnull parameter of renderSelectOptionsAsText(FacesContext, UIComponent, Converter, Set, List, boolean)	CORRECTNESS	NP_NULL_PARAM_DEREF	724	Medium

org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlResponseWriterImpl

Bug	Category	Details	Line	Priority
Use of non-localized String.toUpperCase() or String.toLowerCase	I18N	DM_CONVERT_CASE	117	Low
Use of non-localized String.toUpperCase() or String.toLowerCase	I18N	DM_CONVERT_CASE	185	Low
Use of non-localized String.toUpperCase() or String.toLowerCase	I18N	DM_CONVERT_CASE	259	Low
Use of non-localized String.toUpperCase() or String.toLowerCase	I18N	DM_CONVERT_CASE	355	Low

org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlSecretRendererBase

Bug	Category	Details	Line	Priority
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlSecretRendererBase.getConvertedValue(FacesContext, UIComponent, Object)	STYLE	BC_UNCONFIRMED_CAST	127	Low

org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlTableRendererBase

Bug	Category	Details	Line	Priority
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIData in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlTableRendererBase.encodeBegin(FacesContext, UIComponent)	STYLE	BC_UNCONFIRMED_CAST	109	Low
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIData in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlTableRendererBase.encodeChildren(FacesContext, UIComponent)	STYLE	BC_UNCONFIRMED_CAST	137	Low
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIData in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlTableRendererBase.encodeEnd(FacesContext, UIComponent)	STYLE	BC_UNCONFIRMED_CAST	560	Low
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIData in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlTableRendererBase.encodeInnerHtml(FacesContext, UIComponent)	STYLE	BC_UNCONFIRMED_CAST	231	Low
Method org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlTableRendererBase.renderColumnFooterCell(FacesContext, ResponseWriter, UIComponent, UIComponent, String, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead	PERFORMANCE	DM_NUMBER_CTOR	973	Medium
Method org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlTableRendererBase.renderColumnHeaderCell(FacesContext, ResponseWriter, UIComponent, UIComponent, String, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead	PERFORMANCE	DM_NUMBER_CTOR	919	Medium
Method org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlTableRendererBase.renderTableHeaderOrFooterRow(FacesContext, ResponseWriter, UIComponent, UIComponent, String, String, int, boolean) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead	PERFORMANCE	DM_NUMBER_CTOR	775	Medium
Redundant nullcheck of elemName, which is known to be non-null in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlTableRendererBase.renderFacet(FacesContext, ResponseWriter, UIComponent, boolean)	STYLE	RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE	644	Low

org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlTextRendererBase

Bug	Category	Details	Line	Priority
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlTextRendererBase.getConvertedValue(FacesContext, UIComponent, Object)	STYLE	BC_UNCONFIRMED_CAST	219	Low

org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlTextareaRendererBase

Bug	Category	Details	Line	Priority
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlTextareaRendererBase.getConvertedValue(FacesContext, UIComponent, Object)	STYLE	BC_UNCONFIRMED_CAST	94	Low

org.apache.myfaces.shared_tomahawk.renderkit.html.util.HTMLEncoder

Bug	Category	Details	Line	Priority
Switch statement found in org.apache.myfaces.shared_tomahawk.renderkit.html.util.HTMLEncoder.encode(String, boolean, boolean, boolean) where default case is missing	STYLE	SF_SWITCH_NO_DEFAULT	100	Low
Switch statement found in org.apache.myfaces.shared_tomahawk.renderkit.html.util.HTMLEncoder.encode(char[], int, int, boolean, boolean, boolean, Writer) where default case is missing	STYLE	SF_SWITCH_NO_DEFAULT	226	Low

org.apache.myfaces.shared_tomahawk.renderkit.html.util.JavascriptUtils

Bug	Category	Details	Line	Priority
Use of non-localized String.toUpperCase() or String.toLowerCase	I18N	DM_CONVERT_CASE	155	Low
Switch statement found in org.apache.myfaces.shared_tomahawk.renderkit.html.util.JavascriptUtils.encodeString(String) where default case is missing	STYLE	SF_SWITCH_NO_DEFAULT	212	Low

org.apache.myfaces.shared_tomahawk.taglib.UIComponentBodyELTagBase

Bug	Category	Details	Line	Priority
Private method org.apache.myfaces.shared_tomahawk.taglib.UIComponentBodyELTagBase.setConverterProperty(UIComponent, String) is never called	PERFORMANCE	UPM_UNCALLED_PRIVATE_METHOD	209	Medium

org.apache.myfaces.shared_tomahawk.test.ClassElementHandler

Bug	Category	Details	Line	Priority
ClassElementHandler.buffer not initialized in constructor	STYLE	UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR		Low

org.apache.myfaces.shared_tomahawk.trace.TracingIterator

Bug	Category	Details	Line	Priority
org.apache.myfaces.shared_tomahawk.trace.TracingIterator.next() can't throw NoSuchElementException	BAD_PRACTICE	IT_NO_SUCH_ELEMENT	69	Low

org.apache.myfaces.shared_tomahawk.util.ClassUtils

Bug	Category	Details	Line	Priority
Dead store to plugins in org.apache.myfaces.shared_tomahawk.util.ClassUtils.classForName(String)	STYLE	DLS_DEAD_LOCAL_STORE	155	Medium
org.apache.myfaces.shared_tomahawk.util.ClassUtils.classLoadingExtensions should be package protected	MALICIOUS_CODE	MS_PKGPROTECT	66	Medium

org.apache.myfaces.shared_tomahawk.util.ExceptionUtils

Bug	Category	Details	Line	Priority
Exception is caught when Exception is not thrown in org.apache.myfaces.shared_tomahawk.util.ExceptionUtils.getExceptions(Throwable)	STYLE	REC_CATCH_EXCEPTION	59	Low

org.apache.myfaces.shared_tomahawk.util.LocaleUtils

Bug	Category	Details	Line	Priority
Exception is caught when Exception is not thrown in org.apache.myfaces.shared_tomahawk.util.LocaleUtils.converterTagLocaleFromString(String)	STYLE	REC_CATCH_EXCEPTION	136	Low

org.apache.myfaces.shared_tomahawk.util.MessageUtils

Bug	Category	Details	Line	Priority
Method call in org.apache.myfaces.shared_tomahawk.util.MessageUtils.getMessageFromBundle(String, String, Object[]) passes null for nonnull parameter of getMessageFromBundle(String, FacesContext, Locale, String, Object[])	CORRECTNESS	NP_NULL_PARAM_DEREF	265	Medium
Redundant comparison of non-null value to null in org.apache.myfaces.shared_tomahawk.util.MessageUtils.getMessage(String, FacesContext, String, Object[])	STYLE	RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE	590	Low
Redundant comparison of non-null value to null in org.apache.myfaces.shared_tomahawk.util.MessageUtils.getMessage(FacesContext, String, Object[])	STYLE	RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE	570	Low
Redundant nullcheck of message, which is known to be non-null in org.apache.myfaces.shared_tomahawk.util.MessageUtils.getMessage(String, FacesContext, String, Object[])	STYLE	RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE	593	Low
Redundant nullcheck of message, which is known to be non-null in org.apache.myfaces.shared_tomahawk.util.MessageUtils.getMessage(FacesContext, String, Object[])	STYLE	RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE	573	Low

org.apache.myfaces.shared_tomahawk.util.ParametrizableFacesMessage

Bug	Category	Details	Line	Priority
new org.apache.myfaces.shared_tomahawk.util.ParametrizableFacesMessage(String, String, Object[], Locale) may expose internal representation by storing an externally mutable object into ParametrizableFacesMessage._args	MALICIOUS_CODE	EI_EXPOSE_REP2	55	Medium
new org.apache.myfaces.shared_tomahawk.util.ParametrizableFacesMessage(FacesMessage$Severity, String, String, Object[], Locale) may expose internal representation by storing an externally mutable object into ParametrizableFacesMessage._args	MALICIOUS_CODE	EI_EXPOSE_REP2	64	Medium
The field org.apache.myfaces.shared_tomahawk.util.ParametrizableFacesMessage._evaluatedArgs is transient but isn't set by deserialization	BAD_PRACTICE	SE_TRANSIENT_FIELD_NOT_RESTORED		Low

org.apache.myfaces.shared_tomahawk.util.StateUtils

Bug	Category	Details	Line	Priority
instanceof will always return true in org.apache.myfaces.shared_tomahawk.util.StateUtils.getMacSecret(ExternalContext), since all javax.crypto.SecretKey are instances of javax.crypto.SecretKey	STYLE	BC_VACUOUS_INSTANCEOF	932	Medium
instanceof will always return true in org.apache.myfaces.shared_tomahawk.util.StateUtils.getSecret(ExternalContext), since all javax.crypto.SecretKey are instances of javax.crypto.SecretKey	STYLE	BC_VACUOUS_INSTANCEOF	787	Medium
Dead store of null to baos in org.apache.myfaces.shared_tomahawk.util.StateUtils.compress(byte[])	STYLE	DLS_DEAD_LOCAL_STORE_OF_NULL	348	Low
Dead store of null to gzip in org.apache.myfaces.shared_tomahawk.util.StateUtils.compress(byte[])	STYLE	DLS_DEAD_LOCAL_STORE_OF_NULL	347	Low
Dead store of null to bais in org.apache.myfaces.shared_tomahawk.util.StateUtils.decompress(byte[])	STYLE	DLS_DEAD_LOCAL_STORE_OF_NULL	419	Low
Dead store of null to baos in org.apache.myfaces.shared_tomahawk.util.StateUtils.decompress(byte[])	STYLE	DLS_DEAD_LOCAL_STORE_OF_NULL	418	Low
Dead store of null to gis in org.apache.myfaces.shared_tomahawk.util.StateUtils.decompress(byte[])	STYLE	DLS_DEAD_LOCAL_STORE_OF_NULL	420	Low
Dead store of null to outputStream in org.apache.myfaces.shared_tomahawk.util.StateUtils.getAsByteArray(Object, ExternalContext)	STYLE	DLS_DEAD_LOCAL_STORE_OF_NULL	276	Low
Dead store of null to writer in org.apache.myfaces.shared_tomahawk.util.StateUtils.getAsByteArray(Object, ExternalContext)	STYLE	DLS_DEAD_LOCAL_STORE_OF_NULL	275	Low
Random object created and used only once in org.apache.myfaces.shared_tomahawk.util.StateUtils.findMacSecret(String, String)	BAD_PRACTICE	DMI_RANDOM_USED_ONLY_ONCE	982	High
Random object created and used only once in org.apache.myfaces.shared_tomahawk.util.StateUtils.findSecret(String, String)	BAD_PRACTICE	DMI_RANDOM_USED_ONLY_ONCE	837	High
Use of non-localized String.toUpperCase() or String.toLowerCase	I18N	DM_CONVERT_CASE	663	Low
Use of non-localized String.toUpperCase() or String.toLowerCase	I18N	DM_CONVERT_CASE	675	Low
Use of non-localized String.toUpperCase() or String.toLowerCase	I18N	DM_CONVERT_CASE	641	Low
Use of non-localized String.toUpperCase() or String.toLowerCase	I18N	DM_CONVERT_CASE	626	Low
Use of non-localized String.toUpperCase() or String.toLowerCase	I18N	DM_CONVERT_CASE	857	Low
Use of non-localized String.toUpperCase() or String.toLowerCase	I18N	DM_CONVERT_CASE	870	Low
Use of non-localized String.toUpperCase() or String.toLowerCase	I18N	DM_CONVERT_CASE	946	Low
Use of non-localized String.toUpperCase() or String.toLowerCase	I18N	DM_CONVERT_CASE	958	Low
Use of non-localized String.toUpperCase() or String.toLowerCase	I18N	DM_CONVERT_CASE	801	Low
Use of non-localized String.toUpperCase() or String.toLowerCase	I18N	DM_CONVERT_CASE	813	Low
Use of non-localized String.toUpperCase() or String.toLowerCase	I18N	DM_CONVERT_CASE	903	Low
Use of non-localized String.toUpperCase() or String.toLowerCase	I18N	DM_CONVERT_CASE	758	Low
Use of non-localized String.toUpperCase() or String.toLowerCase	I18N	DM_CONVERT_CASE	720	Low
Use of non-localized String.toUpperCase() or String.toLowerCase	I18N	DM_CONVERT_CASE	191	Low
Exception is caught when Exception is not thrown in org.apache.myfaces.shared_tomahawk.util.StateUtils.decrypt(byte[], ExternalContext)	STYLE	REC_CATCH_EXCEPTION	486	Low
Exception is caught when Exception is not thrown in org.apache.myfaces.shared_tomahawk.util.StateUtils.encrypt(byte[], ExternalContext)	STYLE	REC_CATCH_EXCEPTION	330	Low
Exception is caught when Exception is not thrown in org.apache.myfaces.shared_tomahawk.util.StateUtils.getAsObject(byte[], ExternalContext)	STYLE	REC_CATCH_EXCEPTION	548	Low

org.apache.myfaces.shared_tomahawk.util.StringUtils

Bug	Category	Details	Line	Priority
Should org.apache.myfaces.shared_tomahawk.util.StringUtils.trim(String[]) return a zero length array rather than null?	STYLE	PZLA_PREFER_ZERO_LENGTH_ARRAYS	685	Low

org.apache.myfaces.shared_tomahawk.util.servlet.SourceCodeServlet

Bug	Category	Details	Line	Priority
org.apache.myfaces.shared_tomahawk.util.servlet.SourceCodeServlet is Serializable; consider declaring a serialVersionUID	BAD_PRACTICE	SE_NO_SERIALVERSIONID	25	Low

org.apache.myfaces.shared_tomahawk.webapp.webxml.WebXmlParser

Bug	Category	Details	Line	Priority
Exception is caught when Exception is not thrown in org.apache.myfaces.shared_tomahawk.webapp.webxml.WebXmlParser.parse()	STYLE	REC_CATCH_EXCEPTION	113	Low