FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.0.0

Threshold is Low

Effort is Default

Files

org.apache.myfaces.portlet.faces.util.QueryString$Parameter

Bug Category Details Line
org.apache.myfaces.portlet.faces.util.QueryString$Parameter defines equals and uses Object.hashCode() CORRECTNESS HE_EQUALS_USE_HASHCODE 499-504

org.apache.myfaces.portlet.faces.util.config.WebConfigurationProcessor

Bug Category Details Line
org.apache.myfaces.portlet.faces.util.config.WebConfigurationProcessor.scanForFacesMappings(javax.portlet.PortletContext) might ignore java.lang.Exception CORRECTNESS DE_MIGHT_IGNORE 83
Method org.apache.myfaces.portlet.faces.util.config.WebConfigurationProcessor.scanForFacesMappings(javax.portlet.PortletContext) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught STYLE REC_CATCH_EXCEPTION 83

org.apache.myfaces.portlet.faces.util.config.FacesConfigurationProcessor

Bug Category Details Line
Method org.apache.myfaces.portlet.faces.util.config.FacesConfigurationProcessor.scanForFacesMappings(javax.portlet.PortletContext) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught STYLE REC_CATCH_EXCEPTION 117

org.apache.myfaces.portlet.faces.util.map.PortletRequestHeaders

Bug Category Details Line
Method org.apache.myfaces.portlet.faces.util.map.PortletRequestHeaders.getHeader(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead I18N DM_CONVERT_CASE 50
Method org.apache.myfaces.portlet.faces.util.map.PortletRequestHeaders.getHeaders(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead I18N DM_CONVERT_CASE 59
Method org.apache.myfaces.portlet.faces.util.map.PortletRequestHeaders.containsHeader(java.util.List,String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead I18N DM_CONVERT_CASE 242
Method org.apache.myfaces.portlet.faces.util.map.PortletRequestHeaders.addProperty(String,String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead I18N DM_CONVERT_CASE 259

org.apache.myfaces.portlet.faces.util.map.PortletAbstractMap

Bug Category Details Line
Method org.apache.myfaces.portlet.faces.util.map.PortletAbstractMap.put(String,Object) invokes toString() method on a String; just use the String PERFORMANCE DM_STRING_TOSTRING 102

org.apache.myfaces.portlet.faces.util.HTTPUtils

Bug Category Details Line
Dead store to aChar in method org.apache.myfaces.portlet.faces.util.HTTPUtils.decode(String,String) STYLE DLS_DEAD_LOCAL_STORE 302

org.apache.myfaces.portlet.faces.context.PortletFacesContextImpl

Bug Category Details Line
org.apache.myfaces.portlet.faces.context.PortletFacesContextImpl.setViewRoot(javax.faces.component.UIViewRoot) might ignore java.lang.Exception CORRECTNESS DE_MIGHT_IGNORE 286

org.apache.myfaces.portlet.faces.context.PortletExternalContextImpl

Bug Category Details Line
org.apache.myfaces.portlet.faces.context.PortletExternalContextImpl.encodeActionURL(String) might ignore java.lang.Exception CORRECTNESS DE_MIGHT_IGNORE 272
Method org.apache.myfaces.portlet.faces.context.PortletExternalContextImpl.encodeActionURL(String) invokes toString() method on a String; just use the String PERFORMANCE DM_STRING_TOSTRING 265

org.apache.myfaces.portlet.faces.bridge.BridgeImpl

Bug Category Details Line
org.apache.myfaces.portlet.faces.bridge.BridgeImpl.attributeAdded(javax.servlet.ServletRequestAttributeEvent) might ignore java.lang.Exception CORRECTNESS DE_MIGHT_IGNORE 537
org.apache.myfaces.portlet.faces.bridge.BridgeImpl.notifyPreDestroy(Object) might ignore java.lang.Exception CORRECTNESS DE_MIGHT_IGNORE 1125
org.apache.myfaces.portlet.faces.bridge.BridgeImpl.attributeAdded(javax.servlet.ServletRequestAttributeEvent) uses reflection to check for the presense of an annotation that has default retention CORRECTNESS DMI_ANNOTATION_IS_NOT_VISIBLE_TO_REFLECTION 531
org.apache.myfaces.portlet.faces.bridge.BridgeImpl.notifyPreDestroy(Object) uses reflection to check for the presense of an annotation that has default retention CORRECTNESS DMI_ANNOTATION_IS_NOT_VISIBLE_TO_REFLECTION 1119
Possible null pointer dereference in org.apache.myfaces.portlet.faces.bridge.BridgeImpl.doFacesRequest(javax.portlet.ActionRequest,javax.portlet.ActionResponse) on exception path CORRECTNESS NP_NULL_ON_SOME_PATH_EXCEPTION 282
Possible null pointer dereference in org.apache.myfaces.portlet.faces.bridge.BridgeImpl.doFacesRequest(javax.portlet.RenderRequest,javax.portlet.RenderResponse) on exception path CORRECTNESS NP_NULL_ON_SOME_PATH_EXCEPTION 454
Suspicious comparison of java.lang.Boolean references in org.apache.myfaces.portlet.faces.bridge.BridgeImpl.saveActionParams(javax.faces.context.FacesContext) CORRECTNESS RC_REF_COMPARISON 659
Method org.apache.myfaces.portlet.faces.bridge.BridgeImpl.doFacesRequest(javax.portlet.ActionRequest,javax.portlet.ActionResponse) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught STYLE REC_CATCH_EXCEPTION 280
Method org.apache.myfaces.portlet.faces.bridge.BridgeImpl.doFacesRequest(javax.portlet.RenderRequest,javax.portlet.RenderResponse) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught STYLE REC_CATCH_EXCEPTION 445
Method org.apache.myfaces.portlet.faces.bridge.BridgeImpl.attributeAdded(javax.servlet.ServletRequestAttributeEvent) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught STYLE REC_CATCH_EXCEPTION 537
Method org.apache.myfaces.portlet.faces.bridge.BridgeImpl.notifyPreDestroy(Object) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught STYLE REC_CATCH_EXCEPTION 1125

org.apache.myfaces.portlet.faces.bridge.wrapper.ActionRequestDecorator

Bug Category Details Line
Class org.apache.myfaces.portlet.faces.bridge.wrapper.ActionRequestDecorator defines field that obscures superclass field org.apache.myfaces.portlet.faces.bridge.wrapper.PortletRequestDecorator.mRequest CORRECTNESS MF_CLASS_MASKS_FIELD Not available

org.apache.myfaces.portlet.faces.el.PortletELContextImpl

Bug Category Details Line
org.apache.myfaces.portlet.faces.el.PortletELResolver.IMPLICIT_OBJECTS should be package protected MALICIOUS_CODE MS_PKGPROTECT 46
Read of unwritten field in org.apache.myfaces.portlet.faces.bridge.wrapper.ActionRequestDecorator.setCharacterEncoding(String) CORRECTNESS NP_UNWRITTEN_FIELD 77
Read of unwritten field in org.apache.myfaces.portlet.faces.bridge.wrapper.ActionRequestDecorator.getPortletInputStream() CORRECTNESS NP_UNWRITTEN_FIELD 55
Read of unwritten field in org.apache.myfaces.portlet.faces.bridge.wrapper.ActionRequestDecorator.getCharacterEncoding() CORRECTNESS NP_UNWRITTEN_FIELD 119
Read of unwritten field in org.apache.myfaces.portlet.faces.bridge.wrapper.ActionRequestDecorator.getContentLength() CORRECTNESS NP_UNWRITTEN_FIELD 145
Read of unwritten field in org.apache.myfaces.portlet.faces.bridge.wrapper.ActionRequestDecorator.getReader() CORRECTNESS NP_UNWRITTEN_FIELD 106
Read of unwritten field in org.apache.myfaces.portlet.faces.bridge.wrapper.ActionRequestDecorator.getContentType() CORRECTNESS NP_UNWRITTEN_FIELD 131
Field only ever set to null: org.apache.myfaces.portlet.faces.bridge.wrapper.ActionRequestDecorator.mRequest CORRECTNESS UWF_NULL_FIELD Not available
Should org.apache.myfaces.portlet.faces.bridge.BridgeImpl$FacesMessageState be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC Not available