FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is low
Effort is min
Files
org.apache.myfaces.application.ApplicationImpl
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in org.apache.myfaces.application.ApplicationImpl.internalCreateConverter(Class) | STYLE | REC_CATCH_EXCEPTION | 773 | Medium |
Exception is caught when Exception is not thrown in org.apache.myfaces.application.ApplicationImpl.internalCreateConverter(Class) | STYLE | REC_CATCH_EXCEPTION | 793 | Low |
org.apache.myfaces.application.DefaultViewHandlerSupport
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of mapping, which is known to be non-null in org.apache.myfaces.application.DefaultViewHandlerSupport.calculateViewId(FacesContext, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 53 | Low |
org.apache.myfaces.application.NavigationHandlerImpl
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Inconsistent synchronization of org.apache.myfaces.application.NavigationHandlerImpl._navigationCases; locked 40% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 218 | Medium |
Inconsistent synchronization of org.apache.myfaces.application.NavigationHandlerImpl._wildcardKeys; locked 50% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 210 | Low |
org.apache.myfaces.application.NavigationHandlerImpl$KeyComparator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.application.NavigationHandlerImpl$KeyComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 277-282 | Medium |
org.apache.myfaces.application.jsp.JspStateManagerImpl
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of component, which is known to be non-null in org.apache.myfaces.application.jsp.JspStateManagerImpl.getPathToComponent(UIComponent, StringBuffer) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 486 | Low |
org.apache.myfaces.application.jsp.JspStateManagerImpl$1
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class org.apache.myfaces.application.jsp.JspStateManagerImpl$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 777-780 | Low |
org.apache.myfaces.application.jsp.JspStateManagerImpl$SerializedViewCollection
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.application.jsp.JspStateManagerImpl$SerializedViewCollection defines non-transient non-serializable instance field _serializedViews | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
The field org.apache.myfaces.application.jsp.JspStateManagerImpl$SerializedViewCollection._oldSerializedViews is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Low |
org.apache.myfaces.application.jsp.ViewResponseWrapper
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.application.jsp.ViewResponseWrapper.toString() may return null | BAD_PRACTICE | NP_TOSTRING_COULD_RETURN_NULL | 165 | Medium |
org.apache.myfaces.config.FacesConfigValidator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of managedBeansMap, which is known to be non-null in org.apache.myfaces.config.FacesConfigValidator.validate(ExternalContext, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 50 | Low |
Redundant nullcheck of org.apache.myfaces.config.RuntimeConfig.getNavigationRules(), which is known to be non-null in org.apache.myfaces.config.FacesConfigValidator.validate(ExternalContext, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 54 | Low |
org.apache.myfaces.config.FacesConfigurator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Write to static field org.apache.myfaces.config.FacesConfigurator.lastUpdate from instance method org.apache.myfaces.config.FacesConfigurator.configure() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 425 | Medium |
org.apache.myfaces.config.ManagedBeanBuilder
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Switch statement found in org.apache.myfaces.config.ManagedBeanBuilder.initializeProperties(FacesContext, Iterator, String, Object) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 248-251 | Low |
org.apache.myfaces.config.annotation.ResourceAnnotationLifecycleProvider
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.config.annotation.ResourceAnnotationLifecycleProvider.lookupFieldResource(Context, Object, Field, String) invokes reflect.Field.setAccessible(boolean), which should be invoked from within a doPrivileged block | BAD_PRACTICE | DP_DO_INSIDE_DO_PRIVILEGED | 129 | Low |
org.apache.myfaces.config.annotation.ResourceAnnotationLifecycleProvider.lookupMethodResource(Context, Object, Method, String) invokes reflect.Method.setAccessible(boolean), which should be invoked from within a doPrivileged block | BAD_PRACTICE | DP_DO_INSIDE_DO_PRIVILEGED | 165 | Low |
org.apache.myfaces.config.annotation.TomcatAnnotationLifecycleProvider
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in org.apache.myfaces.config.annotation.TomcatAnnotationLifecycleProvider.isAvailable() | STYLE | REC_CATCH_EXCEPTION | 68 | Low |
org.apache.myfaces.config.impl.FacesConfigEntityResolver
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method call in org.apache.myfaces.config.impl.FacesConfigEntityResolver.resolveEntity(String, String) passes null for nonnull parameter of java.util.jar.JarFile.getInputStream(ZipEntry) | CORRECTNESS | NP_NULL_PARAM_DEREF | 89 | High |
org.apache.myfaces.context.FacesContextFactoryImpl
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
new org.apache.myfaces.context.FacesContextFactoryImpl() invokes reflect.Field.setAccessible(boolean), which should be invoked from within a doPrivileged block | BAD_PRACTICE | DP_DO_INSIDE_DO_PRIVILEGED | 61 | Low |
Redundant nullcheck of facesContext, which is known to be non-null in org.apache.myfaces.context.FacesContextFactoryImpl.getFacesContext(Object, Object, Object, Lifecycle) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 128 | Low |
Redundant nullcheck of firstExternalContextInstance which is known to be null in new org.apache.myfaces.context.FacesContextFactoryImpl() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 65 | Low |
org.apache.myfaces.el.CompositeELResolver
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Inconsistent synchronization of org.apache.myfaces.el.CompositeELResolver._elResolvers; locked 75% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 42 | Low |
org.apache.myfaces.el.ResolverForJSPInitializer
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.el.ResolverForJSPInitializer defines non-transient non-serializable instance field _resolverForJSP | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
org.apache.myfaces.el.convert.ValueBindingToValueExpression
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.el.convert.ValueBindingToValueExpression defines non-transient non-serializable instance field _valueBinding | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
org.apache.myfaces.el.unified.CustomFirstELResolverComparator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.el.unified.CustomFirstELResolverComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 39-101 | Medium |
org.apache.myfaces.el.unified.CustomLastELResolverComparator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.el.unified.CustomLastELResolverComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 34-42 | Low |
org.apache.myfaces.el.unified.OpenWebBeansELResolverComparator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.el.unified.OpenWebBeansELResolverComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 33-48 | Medium |
org.apache.myfaces.el.unified.resolver.GuiceResolver
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of property, which is known to be non-null in org.apache.myfaces.el.unified.resolver.GuiceResolver.getValue(ELContext, Object, Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 81 | Low |
org.apache.myfaces.lifecycle.RestoreViewExecutor
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Private method org.apache.myfaces.lifecycle.RestoreViewExecutor.deriveViewId(FacesContext) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 136-175 | Low |
org.apache.myfaces.renderkit.html.HtmlHiddenRenderer
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.renderkit.html.HtmlHiddenRenderer.getConvertedValue(FacesContext, UIComponent, Object) | STYLE | BC_UNCONFIRMED_CAST | 77 | Low |
org.apache.myfaces.renderkit.html.HtmlResponseStateManager
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Load of known null value in org.apache.myfaces.renderkit.html.HtmlResponseStateManager.getSavedState(FacesContext) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 203 | Medium |
Should org.apache.myfaces.renderkit.html.HtmlResponseStateManager.getSavedState(FacesContext) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 184 | Low |
org.apache.myfaces.shared_impl.renderkit.RendererUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
instanceof will always return true in org.apache.myfaces.shared_impl.renderkit.RendererUtils.getConvertedUISelectOneValue(FacesContext, UISelectOne, Object), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 735 | Medium |
Method org.apache.myfaces.shared_impl.renderkit.RendererUtils.getViewSequence(FacesContext) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 919 | Medium |
Can't close content since it is always null in org.apache.myfaces.shared_impl.renderkit.RendererUtils.loadResourceFile(FacesContext, String) | CORRECTNESS | NP_CLOSING_NULL | 1090 | High |
Possible null pointer dereference of content in org.apache.myfaces.shared_impl.renderkit.RendererUtils.loadResourceFile(FacesContext, String) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 1109 | Medium |
org.apache.myfaces.shared_impl.renderkit.RendererUtils$1
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.shared_impl.renderkit.RendererUtils$1 defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 85-92 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.shared_impl.renderkit.html.HTML.LABEL_PASSTHROUGH_ATTRIBUTES is a mutable array | MALICIOUS_CODE | MS_MUTABLE_ARRAY | 350 | High |
org.apache.myfaces.shared_impl.renderkit.html.HTML.ANCHOR_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 205 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 218 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES_WITHOUT_ONCLICK_WITHOUT_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 228 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES_WITHOUT_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 223 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.BUTTON_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 323 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.BUTTON_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 328 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.BUTTON_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONCLICK should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 332 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.COMMON_FIELD_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 138 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.COMMON_FIELD_EVENT_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 89 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.COMMON_FIELD_EVENT_ATTRIBUTES_WITHOUT_ONFOCUS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 97 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.COMMON_FIELD_EVENT_ATTRIBUTES_WITHOUT_ONSELECT_AND_ONCHANGE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 104 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 165 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONCLICK should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 185 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS_AND_ONCLICK should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 180 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 170 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 149 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES_WITHOUT_ONCLICK should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 157 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES_WITHOUT_ONCLICK_WITHOUT_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 161 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES_WITHOUT_ONMOUSEOVER_AND_ONMOUSEOUT should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 190 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES_WITHOUT_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 153 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.EVENT_HANDLER_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 81 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.EVENT_HANDLER_ATTRIBUTES_WITHOUT_ONCLICK should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 58 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.EVENT_HANDLER_ATTRIBUTES_WITHOUT_ONMOUSEOVER_AND_ONMOUSEOUT should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 70 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.FORM_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 239 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.FORM_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 248 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.IMG_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 263 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.IMG_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 276 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.INPUT_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 290 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.INPUT_FILE_UPLOAD_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 401 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 298 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 302 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.LABEL_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 343 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.MESSAGE_PASSTHROUGH_ATTRIBUTES_WITHOUT_TITLE_STYLE_AND_STYLE_CLASS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 418 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.SELECT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 358 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.SELECT_TABLE_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 425 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.TABLE_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 368 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.TABLE_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 379 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.TEXTAREA_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 388 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.TEXTAREA_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 395 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.UL_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 429 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.UNIVERSAL_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 125 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.UNIVERSAL_ATTRIBUTES_WITHOUT_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 117 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HTML.COMMON_FIELD_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 143 | Low |
org.apache.myfaces.shared_impl.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 175 | Low |
org.apache.myfaces.shared_impl.renderkit.html.HTML.IMG_PASSTHROUGH_ATTRIBUTES_WITHOUT_ONMOUSEOVER_AND_ONMOUSEOUT should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 280 | Low |
org.apache.myfaces.shared_impl.renderkit.html.HTML.INPUT_FILE_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 405 | Low |
org.apache.myfaces.shared_impl.renderkit.html.HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS_AND_ONCLICK should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 307 | Low |
org.apache.myfaces.shared_impl.renderkit.html.HTML.UL_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 433 | Low |
org.apache.myfaces.shared_impl.renderkit.html.HtmlButtonRendererBase
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to nestingForm in org.apache.myfaces.shared_impl.renderkit.html.HtmlButtonRendererBase.buildOnClick(UIComponent, FacesContext, ResponseWriter) | STYLE | DLS_DEAD_LOCAL_STORE | 197 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HtmlCheckboxRendererBase
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.model.SelectItem to javax.faces.model.SelectItemGroup in org.apache.myfaces.shared_impl.renderkit.html.HtmlCheckboxRendererBase.renderGroupOrItemCheckbox(FacesContext, UIComponent, SelectItem, boolean, Set, Converter, boolean, Integer) | STYLE | BC_UNCONFIRMED_CAST | 176 | Low |
Method org.apache.myfaces.shared_impl.renderkit.html.HtmlCheckboxRendererBase.renderCheckboxList(FacesContext, UISelectMany) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 121 | Medium |
Method org.apache.myfaces.shared_impl.renderkit.html.HtmlCheckboxRendererBase.renderGroupOrItemCheckbox(FacesContext, UIComponent, SelectItem, boolean, Set, Converter, boolean, Integer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 181 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HtmlFormRendererBase
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIForm in org.apache.myfaces.shared_impl.renderkit.html.HtmlFormRendererBase.decode(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 178 | Low |
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIForm in org.apache.myfaces.shared_impl.renderkit.html.HtmlFormRendererBase.encodeBegin(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 59 | Low |
Private method org.apache.myfaces.shared_impl.renderkit.html.HtmlFormRendererBase.getAcceptCharset(UIComponent) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 222-226 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HtmlGroupRendererBase
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.html.HtmlPanelGroup in org.apache.myfaces.shared_impl.renderkit.html.HtmlGroupRendererBase.encodeEnd(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 65 | Low |
org.apache.myfaces.shared_impl.renderkit.html.HtmlLinkRendererBase
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Private method org.apache.myfaces.shared_impl.renderkit.html.HtmlLinkRendererBase.renderLinkParameter(String, Object, StringBuffer, String, UIComponent) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 532-543 | Low |
org.apache.myfaces.shared_impl.renderkit.html.HtmlRadioRendererBase
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectOne in org.apache.myfaces.shared_impl.renderkit.html.HtmlRadioRendererBase.encodeEnd(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 55 | Low |
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectOne in org.apache.myfaces.shared_impl.renderkit.html.HtmlRadioRendererBase.getConvertedValue(FacesContext, UIComponent, Object) | STYLE | BC_UNCONFIRMED_CAST | 303 | Low |
Unchecked/unconfirmed cast from javax.faces.model.SelectItem to javax.faces.model.SelectItemGroup in org.apache.myfaces.shared_impl.renderkit.html.HtmlRadioRendererBase.renderGroupOrItemRadio(FacesContext, UIComponent, SelectItem, Object, Converter, boolean, Integer) | STYLE | BC_UNCONFIRMED_CAST | 166 | Low |
Method org.apache.myfaces.shared_impl.renderkit.html.HtmlRadioRendererBase.encodeEnd(FacesContext, UIComponent) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 99 | Medium |
Method org.apache.myfaces.shared_impl.renderkit.html.HtmlRadioRendererBase.renderGroupOrItemRadio(FacesContext, UIComponent, SelectItem, Object, Converter, boolean, Integer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 170 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HtmlRendererUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared_impl.renderkit.html.HtmlRendererUtils.findUIOutputConverterFailSafe(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 393 | Low |
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectMany in org.apache.myfaces.shared_impl.renderkit.html.HtmlRendererUtils.findUISelectManyConverterFailsafe(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 380 | Low |
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectMany in org.apache.myfaces.shared_impl.renderkit.html.HtmlRendererUtils.getSubmittedOrSelectedValuesAsSet(boolean, UIComponent, FacesContext, Converter) | STYLE | BC_UNCONFIRMED_CAST | 350 | Low |
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectOne in org.apache.myfaces.shared_impl.renderkit.html.HtmlRendererUtils.getSubmittedOrSelectedValuesAsSet(boolean, UIComponent, FacesContext, Converter) | STYLE | BC_UNCONFIRMED_CAST | 357 | Low |
public static org.apache.myfaces.shared_impl.renderkit.html.HtmlRendererUtils.getSupportedContentTypes() may expose internal representation by returning HtmlRendererUtils.SUPPORTED_CONTENT_TYPES | MALICIOUS_CODE | MS_EXPOSE_REP | 1695 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HtmlRendererUtils.DEFAULT_CHAR_ENCODING isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 1606 | High |
Method call in org.apache.myfaces.shared_impl.renderkit.html.HtmlRendererUtils.renderDisplayValueOnlyForSelects(FacesContext, UIComponent) passes null for nonnull parameter of renderSelectOptionsAsText(FacesContext, UIComponent, Converter, Set, List, boolean) | CORRECTNESS | NP_NULL_PARAM_DEREF | 724 | Medium |
org.apache.myfaces.shared_impl.renderkit.html.HtmlResponseWriterImpl
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 117 | Low |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 185 | Low |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 259 | Low |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 355 | Low |
org.apache.myfaces.shared_impl.renderkit.html.HtmlSecretRendererBase
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared_impl.renderkit.html.HtmlSecretRendererBase.getConvertedValue(FacesContext, UIComponent, Object) | STYLE | BC_UNCONFIRMED_CAST | 127 | Low |
org.apache.myfaces.shared_impl.renderkit.html.HtmlTableRendererBase
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIData in org.apache.myfaces.shared_impl.renderkit.html.HtmlTableRendererBase.encodeBegin(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 109 | Low |
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIData in org.apache.myfaces.shared_impl.renderkit.html.HtmlTableRendererBase.encodeChildren(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 137 | Low |
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIData in org.apache.myfaces.shared_impl.renderkit.html.HtmlTableRendererBase.encodeEnd(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 673 | Low |
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIData in org.apache.myfaces.shared_impl.renderkit.html.HtmlTableRendererBase.encodeInnerHtml(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 232 | Low |
Method org.apache.myfaces.shared_impl.renderkit.html.HtmlTableRendererBase.renderColumnFooterCell(FacesContext, ResponseWriter, UIComponent, UIComponent, String, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 1090 | Medium |
Method org.apache.myfaces.shared_impl.renderkit.html.HtmlTableRendererBase.renderColumnHeaderCell(FacesContext, ResponseWriter, UIComponent, UIComponent, String, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 1036 | Medium |
Method org.apache.myfaces.shared_impl.renderkit.html.HtmlTableRendererBase.renderTableHeaderOrFooterRow(FacesContext, ResponseWriter, UIComponent, UIComponent, String, String, int, boolean) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 891 | Medium |
Redundant nullcheck of elemName, which is known to be non-null in org.apache.myfaces.shared_impl.renderkit.html.HtmlTableRendererBase.renderFacet(FacesContext, ResponseWriter, UIComponent, boolean) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 757 | Low |
org.apache.myfaces.shared_impl.renderkit.html.HtmlTextRendererBase
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared_impl.renderkit.html.HtmlTextRendererBase.getConvertedValue(FacesContext, UIComponent, Object) | STYLE | BC_UNCONFIRMED_CAST | 219 | Low |
org.apache.myfaces.shared_impl.renderkit.html.HtmlTextareaRendererBase
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared_impl.renderkit.html.HtmlTextareaRendererBase.getConvertedValue(FacesContext, UIComponent, Object) | STYLE | BC_UNCONFIRMED_CAST | 94 | Low |
org.apache.myfaces.shared_impl.renderkit.html.util.HTMLEncoder
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Switch statement found in org.apache.myfaces.shared_impl.renderkit.html.util.HTMLEncoder.encode(String, boolean, boolean, boolean) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 100-102 | Low |
Switch statement found in org.apache.myfaces.shared_impl.renderkit.html.util.HTMLEncoder.encode(char[], int, int, boolean, boolean, boolean, Writer) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 226-228 | Low |
org.apache.myfaces.shared_impl.renderkit.html.util.JavascriptUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 155 | Low |
Switch statement found in org.apache.myfaces.shared_impl.renderkit.html.util.JavascriptUtils.encodeString(String) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 212-214 | Low |
org.apache.myfaces.shared_impl.taglib.UIComponentBodyELTagBase
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Private method org.apache.myfaces.shared_impl.taglib.UIComponentBodyELTagBase.setConverterProperty(UIComponent, String) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 209-210 | Medium |
org.apache.myfaces.shared_impl.test.ClassElementHandler
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
ClassElementHandler.buffer not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
org.apache.myfaces.shared_impl.trace.TracingIterator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.shared_impl.trace.TracingIterator.next() can't throw NoSuchElementException | BAD_PRACTICE | IT_NO_SUCH_ELEMENT | 69 | Low |
org.apache.myfaces.shared_impl.util.ClassUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to plugins in org.apache.myfaces.shared_impl.util.ClassUtils.classForName(String) | STYLE | DLS_DEAD_LOCAL_STORE | 155 | Medium |
org.apache.myfaces.shared_impl.util.ClassUtils.classLoadingExtensions should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 66 | Medium |
org.apache.myfaces.shared_impl.util.ExceptionUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in org.apache.myfaces.shared_impl.util.ExceptionUtils.getExceptions(Throwable) | STYLE | REC_CATCH_EXCEPTION | 59 | Low |
org.apache.myfaces.shared_impl.util.LocaleUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in org.apache.myfaces.shared_impl.util.LocaleUtils.converterTagLocaleFromString(String) | STYLE | REC_CATCH_EXCEPTION | 136 | Low |
org.apache.myfaces.shared_impl.util.MessageUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method call in org.apache.myfaces.shared_impl.util.MessageUtils.getMessageFromBundle(String, String, Object[]) passes null for nonnull parameter of getMessageFromBundle(String, FacesContext, Locale, String, Object[]) | CORRECTNESS | NP_NULL_PARAM_DEREF | 265 | Medium |
Redundant comparison of non-null value to null in org.apache.myfaces.shared_impl.util.MessageUtils.getMessage(String, FacesContext, String, Object[]) | STYLE | RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE | 590 | Low |
Redundant comparison of non-null value to null in org.apache.myfaces.shared_impl.util.MessageUtils.getMessage(FacesContext, String, Object[]) | STYLE | RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE | 570 | Low |
Redundant nullcheck of message, which is known to be non-null in org.apache.myfaces.shared_impl.util.MessageUtils.getMessage(String, FacesContext, String, Object[]) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 593 | Low |
Redundant nullcheck of message, which is known to be non-null in org.apache.myfaces.shared_impl.util.MessageUtils.getMessage(FacesContext, String, Object[]) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 573 | Low |
org.apache.myfaces.shared_impl.util.ParametrizableFacesMessage
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
new org.apache.myfaces.shared_impl.util.ParametrizableFacesMessage(String, String, Object[], Locale) may expose internal representation by storing an externally mutable object into ParametrizableFacesMessage._args | MALICIOUS_CODE | EI_EXPOSE_REP2 | 55 | Medium |
new org.apache.myfaces.shared_impl.util.ParametrizableFacesMessage(FacesMessage$Severity, String, String, Object[], Locale) may expose internal representation by storing an externally mutable object into ParametrizableFacesMessage._args | MALICIOUS_CODE | EI_EXPOSE_REP2 | 64 | Medium |
org.apache.myfaces.shared_impl.util.StateUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
instanceof will always return true in org.apache.myfaces.shared_impl.util.StateUtils.getMacSecret(ExternalContext), since all javax.crypto.SecretKey are instances of javax.crypto.SecretKey | STYLE | BC_VACUOUS_INSTANCEOF | 938 | Medium |
instanceof will always return true in org.apache.myfaces.shared_impl.util.StateUtils.getSecret(ExternalContext), since all javax.crypto.SecretKey are instances of javax.crypto.SecretKey | STYLE | BC_VACUOUS_INSTANCEOF | 793 | Medium |
Dead store of null to baos in org.apache.myfaces.shared_impl.util.StateUtils.compress(byte[]) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 348 | Low |
Dead store of null to gzip in org.apache.myfaces.shared_impl.util.StateUtils.compress(byte[]) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 347 | Low |
Dead store of null to bais in org.apache.myfaces.shared_impl.util.StateUtils.decompress(byte[]) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 419 | Low |
Dead store of null to baos in org.apache.myfaces.shared_impl.util.StateUtils.decompress(byte[]) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 418 | Low |
Dead store of null to gis in org.apache.myfaces.shared_impl.util.StateUtils.decompress(byte[]) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 420 | Low |
Dead store of null to outputStream in org.apache.myfaces.shared_impl.util.StateUtils.getAsByteArray(Object, ExternalContext) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 276 | Low |
Dead store of null to writer in org.apache.myfaces.shared_impl.util.StateUtils.getAsByteArray(Object, ExternalContext) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 275 | Low |
Random object created and used only once in org.apache.myfaces.shared_impl.util.StateUtils.findMacSecret(String, String) | BAD_PRACTICE | DMI_RANDOM_USED_ONLY_ONCE | 988 | High |
Random object created and used only once in org.apache.myfaces.shared_impl.util.StateUtils.findSecret(String, String) | BAD_PRACTICE | DMI_RANDOM_USED_ONLY_ONCE | 843 | High |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 669 | Low |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 681 | Low |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 647 | Low |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 632 | Low |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 863 | Low |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 876 | Low |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 952 | Low |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 964 | Low |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 807 | Low |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 819 | Low |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 909 | Low |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 764 | Low |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 726 | Low |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 191 | Low |
Exception is caught when Exception is not thrown in org.apache.myfaces.shared_impl.util.StateUtils.decrypt(byte[], ExternalContext) | STYLE | REC_CATCH_EXCEPTION | 492 | Low |
Exception is caught when Exception is not thrown in org.apache.myfaces.shared_impl.util.StateUtils.encrypt(byte[], ExternalContext) | STYLE | REC_CATCH_EXCEPTION | 330 | Low |
Exception is caught when Exception is not thrown in org.apache.myfaces.shared_impl.util.StateUtils.getAsObject(byte[], ExternalContext) | STYLE | REC_CATCH_EXCEPTION | 554 | Low |
org.apache.myfaces.shared_impl.util.StringUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.apache.myfaces.shared_impl.util.StringUtils.trim(String[]) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 685 | Low |
org.apache.myfaces.shared_impl.util.servlet.SourceCodeServlet
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.shared_impl.util.servlet.SourceCodeServlet is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 25-61 | Low |
org.apache.myfaces.shared_impl.webapp.webxml.WebXmlParser
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in org.apache.myfaces.shared_impl.webapp.webxml.WebXmlParser.parse() | STYLE | REC_CATCH_EXCEPTION | 113 | Low |
org.apache.myfaces.taglib.core.ConvertNumberTag
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant comparison of non-null value to null in org.apache.myfaces.taglib.core.ConvertNumberTag.createConverter() | STYLE | RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE | 167 | Low |
org.apache.myfaces.taglib.core.DelegateValueChangeListener
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to className in org.apache.myfaces.taglib.core.DelegateValueChangeListener._createValueChangeListener() | STYLE | DLS_DEAD_LOCAL_STORE | 126 | Low |
Load of known null value in org.apache.myfaces.taglib.core.DelegateValueChangeListener._createValueChangeListener() | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 139 | Low |
org.apache.myfaces.taglib.core.LoadBundleTag$BundleMap
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of java.util.ResourceBundle.getObject(String), which is known to be non-null in org.apache.myfaces.taglib.core.LoadBundleTag$BundleMap.containsKey(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 188 | Low |
org.apache.myfaces.taglib.core.PhaseListenerTag
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.taglib.core.PhaseListenerTag defines non-transient non-serializable instance field log | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
org.apache.myfaces.taglib.core.PhaseListenerTag is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 50-136 | Low |
org.apache.myfaces.taglib.core.PhaseListenerTag$BindingPhaseListener
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.apache.myfaces.taglib.core.PhaseListenerTag$BindingPhaseListener defines non-transient non-serializable instance field log | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
org.apache.myfaces.taglib.core.SetPropertyActionListenerTag
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.taglib.core.SetPropertyActionListenerTag is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 43-129 | Low |
org.apache.myfaces.taglib.core.ValidatorImplTag
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.taglib.core.ValidatorImplTag is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 61-170 | Low |
org.apache.myfaces.taglib.core.ValidatorTag
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.taglib.core.ValidatorTag is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36-116 | Low |
org.apache.myfaces.util.DebugUtils
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.apache.myfaces.util.DebugUtils.printAttribute(PrintStream, String, Object) invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 360 | Low |
org.apache.myfaces.webapp.Jsp20FacesInitializer$ErrorExpressionFactory
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.apache.myfaces.webapp.Jsp20FacesInitializer$ErrorExpressionFactory be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 137-162 | Medium |
org.apache.myfaces.webapp.MyFacesServlet
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.myfaces.webapp.MyFacesServlet._facesInitializer is a mutable servlet field | MT_CORRECTNESS | MSF_MUTABLE_SERVLET_FIELD | 54 | Low |