The following document contains the results of FindBugs Report
FindBugs Version is 1.2.0
Threshold is Low
Effort is Default
Classes | Bugs | Errors | Missing Classes |
---|---|---|---|
316 | 87 | 0 | 0 |
Bug | Category | Details | Line |
---|---|---|---|
Method org.apache.myfaces.buildtools.maven2.plugin.faces.AbstractFacesMojo.createCompileClassLoader(MavenProject) uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 361 |
Method org.apache.myfaces.buildtools.maven2.plugin.faces.AbstractFacesMojo.readIndex(MavenProject) uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 164 |
org.apache.myfaces.buildtools.maven2.plugin.faces.AbstractFacesMojo.readLicenseHeader() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 234 |
AbstractFacesMojo._facesConfig not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.AbstractFacesMojo.licenseHeaderFile | CORRECTNESS | UWF_UNWRITTEN_FIELD | 213 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.AbstractFacesMojo.localResource | CORRECTNESS | UWF_UNWRITTEN_FIELD | 108 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.AbstractFacesMojo.skipApiOrBaseClasses | CORRECTNESS | UWF_UNWRITTEN_FIELD | 59 |
Bug | Category | Details | Line |
---|---|---|---|
Read of unwritten field generatedSourceDirectory in org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateComponentsMojo._generateComponents() | CORRECTNESS | NP_UNWRITTEN_FIELD | 72 |
Read of unwritten field project in org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateComponentsMojo._generateComponents() | CORRECTNESS | NP_UNWRITTEN_FIELD | 72 |
org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateComponentsMojo._generateComponent(ComponentBean) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 257 |
Unused field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateComponentsMojo.packageContains | PERFORMANCE | UUF_UNUSED_FIELD | Not available |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateComponentsMojo.generatedSourceDirectory | CORRECTNESS | UWF_UNWRITTEN_FIELD | 72 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateComponentsMojo.jsfVersion | CORRECTNESS | UWF_UNWRITTEN_FIELD | 289 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateComponentsMojo.project | CORRECTNESS | UWF_UNWRITTEN_FIELD | 56 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateComponentsMojo.templateSourceDirectory | CORRECTNESS | UWF_UNWRITTEN_FIELD | 181 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateComponentsMojo.typePrefix | CORRECTNESS | UWF_UNWRITTEN_FIELD | 88 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateComponentsMojo.force | CORRECTNESS | UWF_UNWRITTEN_FIELD | 92 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateComponentsMojo.suppressListenerMethods | CORRECTNESS | UWF_UNWRITTEN_FIELD | 81 |
Bug | Category | Details | Line |
---|---|---|---|
Read of unwritten field generatedResourcesDirectory in org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFaceletsTaglibsMojo.execute() | CORRECTNESS | NP_UNWRITTEN_FIELD | 80 |
Read of unwritten field taglibs in org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFaceletsTaglibsMojo.execute() | CORRECTNESS | NP_UNWRITTEN_FIELD | 86 |
Unused field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFaceletsTaglibsMojo.force | PERFORMANCE | UUF_UNUSED_FIELD | Not available |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFaceletsTaglibsMojo.configSourceDirectory | CORRECTNESS | UWF_UNWRITTEN_FIELD | 108 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFaceletsTaglibsMojo.faceletHandlerClass | CORRECTNESS | UWF_UNWRITTEN_FIELD | 297 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFaceletsTaglibsMojo.generatedResourcesDirectory | CORRECTNESS | UWF_UNWRITTEN_FIELD | 80 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFaceletsTaglibsMojo.project | CORRECTNESS | UWF_UNWRITTEN_FIELD | 80 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFaceletsTaglibsMojo.resourcePath | CORRECTNESS | UWF_UNWRITTEN_FIELD | 82 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFaceletsTaglibsMojo.taglibs | CORRECTNESS | UWF_UNWRITTEN_FIELD | 86 |
Bug | Category | Details | Line |
---|---|---|---|
The class org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFaceletsTaglibsMojo$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Read of unwritten field targetDirectory in org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFacesConfigMojo.execute() | CORRECTNESS | NP_UNWRITTEN_FIELD | 59 |
Usage of GetResource in org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFacesConfigMojo.execute() may be unsafe if class is extended | BAD_PRACTICE | UI_INHERITANCE_UNSAFE_GETRESOURCE | 149 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFacesConfigMojo.configDirectory | CORRECTNESS | UWF_UNWRITTEN_FIELD | 73 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFacesConfigMojo.jsfVersion | CORRECTNESS | UWF_UNWRITTEN_FIELD | 217 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFacesConfigMojo.project | CORRECTNESS | UWF_UNWRITTEN_FIELD | 59 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFacesConfigMojo.targetDirectory | CORRECTNESS | UWF_UNWRITTEN_FIELD | 59 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFacesConfigMojo.transformStylesheet | CORRECTNESS | UWF_UNWRITTEN_FIELD | 135 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFacesConfigMojo.force | CORRECTNESS | UWF_UNWRITTEN_FIELD | 65 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFacesConfigMojo.removeRenderers | CORRECTNESS | UWF_UNWRITTEN_FIELD | 158 |
Bug | Category | Details | Line |
---|---|---|---|
The class org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateFacesConfigMojo$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Method org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateJspTaglibsMojo._writeTagAttributeDescription(XMLStreamWriter, String, String[]) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 528 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateJspTaglibsMojo.jsfVersion | CORRECTNESS | UWF_UNWRITTEN_FIELD | 950 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateJspTaglibsMojo.type | CORRECTNESS | UWF_UNWRITTEN_FIELD | 780 |
Bug | Category | Details | Line |
---|---|---|---|
The class org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateJspTaglibsMojo$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
Bug | Category | Details | Line |
---|---|---|---|
org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateJspTaglibsMojo$ComponentTagHandlerGenerator.generateTagHandler(ComponentBean) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 935 |
Bug | Category | Details | Line |
---|---|---|---|
Read of unwritten field targetDirectory in org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateMasterFacesConfigMojo.execute() | CORRECTNESS | NP_UNWRITTEN_FIELD | 52 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateMasterFacesConfigMojo.excludes | CORRECTNESS | UWF_UNWRITTEN_FIELD | 65 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateMasterFacesConfigMojo.inheritedDirectory | CORRECTNESS | UWF_UNWRITTEN_FIELD | 57 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateMasterFacesConfigMojo.project | CORRECTNESS | UWF_UNWRITTEN_FIELD | 52 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateMasterFacesConfigMojo.sourceDirectory | CORRECTNESS | UWF_UNWRITTEN_FIELD | 62 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateMasterFacesConfigMojo.sourcePath | CORRECTNESS | UWF_UNWRITTEN_FIELD | 62 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateMasterFacesConfigMojo.targetDirectory | CORRECTNESS | UWF_UNWRITTEN_FIELD | 52 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateMasterFacesConfigMojo.force | CORRECTNESS | UWF_UNWRITTEN_FIELD | 120 |
Bug | Category | Details | Line |
---|---|---|---|
Read of unwritten field generatedSourceDirectory in org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateRendererMapMojo._generateRendererMap() | CORRECTNESS | NP_UNWRITTEN_FIELD | 64 |
Read of unwritten field project in org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateRendererMapMojo._generateRendererMap() | CORRECTNESS | NP_UNWRITTEN_FIELD | 64 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateRendererMapMojo.generatedSourceDirectory | CORRECTNESS | UWF_UNWRITTEN_FIELD | 64 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateRendererMapMojo.project | CORRECTNESS | UWF_UNWRITTEN_FIELD | 48 |
Unwritten field: org.apache.myfaces.buildtools.maven2.plugin.faces.GenerateRendererMapMojo.renderKitPrefix | CORRECTNESS | UWF_UNWRITTEN_FIELD | 78 |
Bug | Category | Details | Line |
---|---|---|---|
Call to equals() comparing different types in org.apache.myfaces.buildtools.maven2.plugin.faces.generator.GeneratorHelper.isAction(PropertyBean) | CORRECTNESS | EC_UNRELATED_TYPES | 83 |
Bug | Category | Details | Line |
---|---|---|---|
Comparison of String parameter using == or != in org.apache.myfaces.buildtools.maven2.plugin.faces.generator.component.AbstractComponentGenerator.writeImports(PrettyWriter, SourceTemplate, String, String, String, ComponentBean) | BAD_PRACTICE | ES_COMPARING_PARAMETER_STRING_WITH_EQ | 307 |
Bug | Category | Details | Line |
---|---|---|---|
Should org.apache.myfaces.buildtools.maven2.plugin.faces.generator.component.AbstractComponentGenerator$NonVirtualFilter be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Should org.apache.myfaces.buildtools.maven2.plugin.faces.generator.component.AbstractComponentGenerator$ResolvableTypeFilter be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 237 |
Bug | Category | Details | Line |
---|---|---|---|
Dead store to propertyClassParams in org.apache.myfaces.buildtools.maven2.plugin.faces.generator.taglib.AbstractComponentTagGenerator.writeImports(PrettyWriter, SourceTemplate, String, String, String, Collection) | STYLE | DLS_DEAD_LOCAL_STORE | 87 |
Bug | Category | Details | Line |
---|---|---|---|
org.apache.myfaces.buildtools.maven2.plugin.faces.generator.taglib.AbstractConverterTagGenerator.generateTagHandler(ConverterBean, File) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 70 |
Bug | Category | Details | Line |
---|---|---|---|
org.apache.myfaces.buildtools.maven2.plugin.faces.generator.taglib.AbstractValidatorTagGenerator.generateTagHandler(ValidatorBean, File) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 72 |
Bug | Category | Details | Line |
---|---|---|---|
Dead store to propKey in org.apache.myfaces.buildtools.maven2.plugin.faces.generator.taglib.MyFacesComponentTagGenerator._writeSetConverter(PrettyWriter, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 571 |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 311 |
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 367 |
Private method org.apache.myfaces.buildtools.maven2.plugin.faces.generator.taglib.MyFacesComponentTagGenerator._writeSetKeyStroke(PrettyWriter, String, String) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 513-564 |
Bug | Category | Details | Line |
---|---|---|---|
Private method org.apache.myfaces.buildtools.maven2.plugin.faces.generator.taglib.TrinidadComponentTagGenerator._writeSetValueBinding(PrettyWriter, String, String, String) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 395-398 |
Bug | Category | Details | Line |
---|---|---|---|
org.apache.myfaces.buildtools.maven2.plugin.faces.parse.AttributeBean.getAttributeClassParameters() may expose internal representation by returning AttributeBean._attributeClassParameters | MALICIOUS_CODE | EI_EXPOSE_REP | 82 |
org.apache.myfaces.buildtools.maven2.plugin.faces.parse.AttributeBean defines compareTo(Object) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 202-209 |
AttributeBean._attributeName not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
Bug | Category | Details | Line |
---|---|---|---|
org.apache.myfaces.buildtools.maven2.plugin.faces.parse.ComponentBean.getUnsupportedAgents() may expose internal representation by returning ComponentBean._unsupportedAgents | MALICIOUS_CODE | EI_EXPOSE_REP | 240 |
org.apache.myfaces.buildtools.maven2.plugin.faces.parse.ComponentBean.setUnsupportedAgents(String[]) may expose internal representation by storing an externally mutable object into ComponentBean._unsupportedAgents | MALICIOUS_CODE | EI_EXPOSE_REP2 | 230 |
Bug | Category | Details | Line |
---|---|---|---|
org.apache.myfaces.buildtools.maven2.plugin.faces.parse.EventRefBean.getEventDeliveryPhases() may expose internal representation by returning EventRefBean._deliveryPhases | MALICIOUS_CODE | EI_EXPOSE_REP | 85 |
org.apache.myfaces.buildtools.maven2.plugin.faces.parse.EventRefBean.setEventDeliveryPhases(String[]) may expose internal representation by storing an externally mutable object into EventRefBean._deliveryPhases | MALICIOUS_CODE | EI_EXPOSE_REP2 | 73 |
Bug | Category | Details | Line |
---|---|---|---|
Method org.apache.myfaces.buildtools.maven2.plugin.faces.parse.MethodSignatureBean.getParameterTypes() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 56 |
Bug | Category | Details | Line |
---|---|---|---|
org.apache.myfaces.buildtools.maven2.plugin.faces.parse.PropertyBean.getPropertyValues() may expose internal representation by returning PropertyBean._propertyValues | MALICIOUS_CODE | EI_EXPOSE_REP | 108 |
org.apache.myfaces.buildtools.maven2.plugin.faces.parse.PropertyBean.getUnsupportedAgents() may expose internal representation by returning PropertyBean._unsupportedAgents | MALICIOUS_CODE | EI_EXPOSE_REP | 259 |
org.apache.myfaces.buildtools.maven2.plugin.faces.parse.PropertyBean.getUnsupportedRenderKits() may expose internal representation by returning PropertyBean._unsupportedRenderKits | MALICIOUS_CODE | EI_EXPOSE_REP | 283 |
org.apache.myfaces.buildtools.maven2.plugin.faces.parse.PropertyBean.setPropertyValues(String[]) may expose internal representation by storing an externally mutable object into PropertyBean._propertyValues | MALICIOUS_CODE | EI_EXPOSE_REP2 | 98 |
org.apache.myfaces.buildtools.maven2.plugin.faces.parse.PropertyBean.setUnsupportedAgents(String[]) may expose internal representation by storing an externally mutable object into PropertyBean._unsupportedAgents | MALICIOUS_CODE | EI_EXPOSE_REP2 | 249 |
org.apache.myfaces.buildtools.maven2.plugin.faces.parse.PropertyBean.setUnsupportedRenderKits(String[]) may expose internal representation by storing an externally mutable object into PropertyBean._unsupportedRenderKits | MALICIOUS_CODE | EI_EXPOSE_REP2 | 273 |
Bug | Category | Details | Line |
---|---|---|---|
org.apache.myfaces.buildtools.maven2.plugin.faces.util.CompoundIterator.CompoundIterator(Iterator[]) may expose internal representation by storing an externally mutable object into CompoundIterator._iterators | MALICIOUS_CODE | EI_EXPOSE_REP2 | 40 |
Bug | Category | Details | Line |
---|---|---|---|
SourceTemplate._reader not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 207 |
Method org.apache.myfaces.buildtools.maven2.plugin.faces.util.Util.getGenericsFromProperty(PropertyBean) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 51 |