PMD 4.2.5 Report
2009-03-06 - 12:34:29


Summary

FilesTotalPriority 1Priority 2Priority 3Priority 4Priority 5
46104
0
1
87
16
0

src\test\java\org\apache\mina\filter\firewall\SubnetIPv4Test

PrioBegin LineMethodDescription
3
37test24 Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
3
38test24 Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
3
39test24 Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
3
40test24 Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
3
51test16 Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
3
52test16 Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
3
53test16 Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
3
54test16 Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
3
65testSingleIp Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
3
66testSingleIp Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
3
67testSingleIp Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
3
68testSingleIp Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
3
79testToString Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
3
94testEquals Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
3
95testEquals Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
3
96testEquals Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
3
97testEquals Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
Total number of violations for this class: 17

src\test\java\org\apache\mina\core\IoBufferTest

PrioBegin LineMethodDescription
3
20 Too many static imports may lead to messy code
3
88testAutoExpand Avoid empty catch blocks
3
102testAutoExpand Avoid empty catch blocks
3
308testGetString Avoid empty catch blocks
3
460testPutPrefixedString Avoid empty catch blocks
3
709testDuplicate Avoid empty catch blocks
3
716testDuplicate Avoid empty catch blocks
3
763testReadOnlyBuffer Avoid empty catch blocks
3
1018testBitVectorOverFlow Avoid empty catch blocks
3
1025testBitVectorOverFlow Avoid empty catch blocks
3
1032testBitVectorOverFlow Avoid empty catch blocks
3
1039testBitVectorOverFlow Avoid empty catch blocks
Total number of violations for this class: 12

src\main\java\org\apache\mina\filter\errorgenerating\ErrorGeneratingFilter

PrioBegin LineMethodDescription
3
99filterWrite Avoid empty if statements
3
124messageReceived Avoid empty if statements
3
131 Avoid unused method parameters such as 'session'.
3
158 Avoid unused method parameters such as 'session'.
Total number of violations for this class: 4

src\main\java\org\apache\mina\util\AvailablePortFinder

PrioBegin LineMethodDescription
3
113available Avoid empty catch blocks
3
122available Avoid empty catch blocks
3
154getAvailablePorts Avoid empty catch blocks
3
159getAvailablePorts Avoid empty catch blocks
Total number of violations for this class: 4

src\test\java\org\apache\mina\util\CircularQueueTest

PrioBegin LineMethodDescription
3
95testRandomAddOnQueue Avoid empty catch blocks
3
128testRandomAddOnRotatedQueue Avoid empty catch blocks
3
153testRandomRemoveOnQueue Avoid empty catch blocks
3
176testRandomRemoveOnRotatedQueue Avoid empty catch blocks
Total number of violations for this class: 4

src\main\java\org\apache\mina\core\service\SimpleIoProcessorPool

PrioBegin LineMethodDescription
3
134 Avoid empty catch blocks
3
141 Avoid empty catch blocks
3
149 Avoid empty catch blocks
Total number of violations for this class: 3

src\main\java\org\apache\mina\filter\codec\demux\MessageDecoderResult

PrioBegin LineMethodDescription
4
22 Avoid unused imports such as 'org.apache.mina.core.buffer.IoBuffer'
4
23 Avoid unused imports such as 'org.apache.mina.core.session.IoSession'
4
24 Avoid unused imports such as 'org.apache.mina.filter.codec.ProtocolDecoderOutput'
Total number of violations for this class: 3

src\main\java\org\apache\mina\filter\stream\FileRegionWriteFilter

PrioBegin LineMethodDescription
4
26 Avoid unused imports such as 'org.apache.mina.core.filterchain.IoFilter'
4
27 Avoid unused imports such as 'org.apache.mina.core.session.IoSession'
4
28 Avoid unused imports such as 'org.apache.mina.core.write.WriteRequest'
Total number of violations for this class: 3

src\test\java\org\apache\mina\transport\AbstractBindTest

PrioBegin LineMethodDescription
3
83bind Avoid empty catch blocks
3
109tearDown Avoid empty catch blocks
3
136testDuplicateBind Avoid empty catch blocks
Total number of violations for this class: 3

src\main\java\org\apache\mina\core\session\DummySession

PrioBegin LineMethodDescription
3
288 Overriding method merely calls super
3
293 Overriding method merely calls super
Total number of violations for this class: 2

src\main\java\org\apache\mina\filter\codec\CumulativeProtocolDecoder

PrioBegin LineMethodDescription
3
141decode Avoid empty catch blocks
3
144decode Avoid empty catch blocks
Total number of violations for this class: 2

src\main\java\org\apache\mina\filter\codec\RecoverableProtocolDecoderException

PrioBegin LineMethodDescription
4
22 Avoid unused imports such as 'org.apache.mina.core.buffer.IoBuffer'
4
23 Avoid unused imports such as 'org.apache.mina.core.session.IoSession'
Total number of violations for this class: 2

src\main\java\org\apache\mina\filter\keepalive\KeepAliveFilter

PrioBegin LineMethodDescription
3
381sessionIdle These nested if statements could be combined
3
382sessionIdle These nested if statements could be combined
Total number of violations for this class: 2

src\main\java\org\apache\mina\filter\ssl\KeyStoreFactory

PrioBegin LineMethodDescription
3
73newInstance Avoid empty catch blocks
3
150setData Avoid empty catch blocks
Total number of violations for this class: 2

src\main\java\org\apache\mina\filter\stream\StreamWriteFilter

PrioBegin LineMethodDescription
4
26 Avoid unused imports such as 'org.apache.mina.core.filterchain.IoFilter'
4
28 Avoid unused imports such as 'org.apache.mina.core.write.WriteRequest'
Total number of violations for this class: 2

src\main\java\org\apache\mina\transport\socket\nio\NioDatagramConnector

PrioBegin LineMethodDescription
4
27 Avoid unused imports such as 'java.util.concurrent.Executor'
3
114 Overriding method merely calls super
Total number of violations for this class: 2

src\main\java\org\apache\mina\util\Base64

PrioBegin LineMethodDescription
3
305encodeBase64 These nested if statements could be combined
3
351encodeBase64 These nested if statements could be combined
Total number of violations for this class: 2

src\test\java\org\apache\mina\core\FutureTest

PrioBegin LineMethodDescription
3
20 Too many static imports may lead to messy code
3
101testConnectFuture Avoid empty catch blocks
Total number of violations for this class: 2

src\test\java\org\apache\mina\filter\codec\textline\TextLineDecoderTest

PrioBegin LineMethodDescription
3
284testOverflow Avoid empty catch blocks
3
308testOverflow Avoid empty catch blocks
Total number of violations for this class: 2

src\test\java\org\apache\mina\filter\firewall\SubnetIPv6Test

PrioBegin LineMethodDescription
3
38testIPv6 Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
3
44testIPv6 Avoid empty catch blocks
Total number of violations for this class: 2

src\test\java\org\apache\mina\filter\reqres\RequestResponseFilterTest

PrioBegin LineMethodDescription
3
125assertNoSuchElementException Avoid empty catch blocks
3
196assertRequestTimeoutException Avoid empty catch blocks
Total number of violations for this class: 2

src\test\java\org\apache\mina\filter\stream\AbstractStreamWriteFilterTest

PrioBegin LineMethodDescription
3
303testSetWriteBufferSize Avoid empty catch blocks
3
310testSetWriteBufferSize Avoid empty catch blocks
Total number of violations for this class: 2

src\test\java\org\apache\mina\transport\AbstractConnectorTest

PrioBegin LineMethodDescription
3
118testConnectFutureFailureTiming Avoid empty catch blocks
3
154testSessionCallbackInvocation Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
Total number of violations for this class: 2

src\main\java\org\apache\mina\core\buffer\IoBuffer

PrioBegin LineMethodDescription
4
33 Avoid unused imports such as 'java.nio.ReadOnlyBufferException'
Total number of violations for this class: 1

src\main\java\org\apache\mina\core\future\DefaultIoFuture

PrioBegin LineMethodDescription
3
254checkDeadLock Avoid empty catch blocks
Total number of violations for this class: 1

src\main\java\org\apache\mina\core\service\IoService

PrioBegin LineMethodDescription
4
22 Avoid unused imports such as 'java.util.Collection'
Total number of violations for this class: 1

src\main\java\org\apache\mina\core\session\AbstractIoSession

PrioBegin LineMethodDescription
3
688updateThroughput These nested if statements could be combined
Total number of violations for this class: 1

src\main\java\org\apache\mina\filter\codec\ProtocolCodecFilter

PrioBegin LineMethodDescription
3
541 Avoid unused method parameters such as 'nextFilter'.
Total number of violations for this class: 1

src\main\java\org\apache\mina\filter\codec\demux\DemuxingProtocolEncoder

PrioBegin LineMethodDescription
3
228 Avoid unused private fields such as 'findEncoderCache'.
Total number of violations for this class: 1

src\main\java\org\apache\mina\filter\firewall\Subnet

PrioBegin LineMethodDescription
3
111equals Ensure you override both equals() and hashCode()
Total number of violations for this class: 1

src\main\java\org\apache\mina\filter\logging\LoggingFilter

PrioBegin LineMethodDescription
4
22 Avoid unused imports such as 'org.apache.mina.core.filterchain.IoFilter'
Total number of violations for this class: 1

src\main\java\org\apache\mina\filter\ssl\SslFilter

PrioBegin LineMethodDescription
3
454messageSent Avoid empty if statements
Total number of violations for this class: 1

src\main\java\org\apache\mina\filter\ssl\SslHandler

PrioBegin LineMethodDescription
3
185destroy Avoid empty catch blocks
Total number of violations for this class: 1

src\main\java\org\apache\mina\handler\stream\IoSessionInputStream

PrioBegin LineMethodDescription
4
27 Avoid unused imports such as 'org.apache.mina.core.session.IoSession'
Total number of violations for this class: 1

src\main\java\org\apache\mina\proxy\handlers\http\digest\DigestUtilities

PrioBegin LineMethodDescription
2
73computeResponseValue Using multiple unary operators may be a bug, and/or is confusing.
Total number of violations for this class: 1

src\main\java\org\apache\mina\proxy\handlers\http\ntlm\NTLMUtilities

PrioBegin LineMethodDescription
3
97getOsVersion Avoid empty while statements
Total number of violations for this class: 1

src\main\java\org\apache\mina\proxy\handlers\socks\SocksProxyRequest

PrioBegin LineMethodDescription
3
165getHost These nested if statements could be combined
Total number of violations for this class: 1

src\main\java\org\apache\mina\proxy\utils\IoBufferDecoder

PrioBegin LineMethodDescription
4
23 Avoid unused imports such as 'org.apache.mina.core.session.IoSession'
Total number of violations for this class: 1

src\main\java\org\apache\mina\transport\socket\nio\NioSocketConnector

PrioBegin LineMethodDescription
3
170 Overriding method merely calls super
Total number of violations for this class: 1

src\main\java\org\apache\mina\transport\vmpipe\VmPipeAcceptor

PrioBegin LineMethodDescription
3
92 Overriding method merely calls super
Total number of violations for this class: 1

src\main\java\org\apache\mina\util\Log4jXmlFormatter

PrioBegin LineMethodDescription
3
144format These nested if statements could be combined
Total number of violations for this class: 1

src\main\java\org\apache\mina\util\byteaccess\AbstractByteArray

PrioBegin LineMethodDescription
3
47equals Ensure you override both equals() and hashCode()
Total number of violations for this class: 1

src\test\java\org\apache\mina\filter\buffer\BufferedWriteFilterTest

PrioBegin LineMethodDescription
3
29 No need to import a type that lives in the same package
Total number of violations for this class: 1

src\test\java\org\apache\mina\filter\codec\CumulativeProtocolDecoderTest

PrioBegin LineMethodDescription
3
112testWrongImplementationDetection Avoid empty catch blocks
Total number of violations for this class: 1

src\test\java\org\apache\mina\filter\keepalive\KeepAliveFilterTest

PrioBegin LineMethodDescription
3
120keepAliveFilterForIdleStatus Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
Total number of violations for this class: 1

src\test\java\org\apache\mina\transport\socket\nio\DatagramConfigTest

PrioBegin LineMethodDescription
3
78testAcceptorFilterChain Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !
Total number of violations for this class: 1

Generated by PMD 4.2.5 on 2009-03-06 - 12:34:29.