/[Apache-SVN]
ViewVC logotype

Revision 279334


Jump to revision: Previous Next
Author: kenney
Date: Wed Sep 7 14:57:24 2005 UTC (19 years, 2 months ago)
Changed paths: 3
Log Message:
Changed ReactorManager's api for blackList and other methods that require
an 'id' to use MavenProject instead. 
In some parts of the code a DAG is constructed using a version-less key,
and in the api what the id should be is unspecified.
This could result in NPE's (it does!) because the code in plexus-utils
assumes a known id (vertex in the DAG) is supplied.

So, moved the project.getId() calls outside of ReactorManager into the
ReactorManager, so that there's just one place where the decision is made on
how to generate an id (DAG vertex label) from a project. This centralizes
that knowledge for increased maintainability and reduced chances on NPE's.




Changed paths

Path Details
Directorymaven/components/trunk/maven-core/src/main/java/org/apache/maven/DefaultMaven.java modified , text changed
Directorymaven/components/trunk/maven-core/src/main/java/org/apache/maven/execution/ReactorManager.java modified , text changed
Directorymaven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26