/[Apache-SVN]
ViewVC logotype

Revision 1694798


Jump to revision: Previous Next
Author: andyetitmoves
Date: Sat Aug 8 13:39:58 2015 UTC (9 years, 3 months ago)
Changed paths: 92
Log Message:
SOLR-7859: Clamp down on use of System.currentTimeMillis

 - Use RTimer where currentTimeMillis is used for timing
 - Abstract out a new class TimeOut for when currentTimeMillis/nanoTime
   is used to timeout operations.
 - Used `new Date()` in some cases where that is the logical intent.
 - Deprecated a couple of APIs which were publicly exposing epoch time,
   in favour of Date objects to make the intent clearer.
 - A couple of cases had currentTimeMillis in dead code.
 - In some cases where currentTimeMillis was used to just generate a name,
   used nanoTime instead (really it should be some sequence/random number
   in such a case).
 - In some other cases where stamps were used for SQL queries, HTTP headers,
   comparing against data in external files, ZK etc., used SuppressForbidden.
 - Also currently allow the use of currentTimeMillis in commit data,
   this is then used in replication -- this is concerning since absolute
   times are being compared, but that can be dealt with separately.



Changed paths

Path Details
Directorylucene/dev/trunk/lucene/tools/forbiddenApis/solr.txt modified , text changed
Directorylucene/dev/trunk/solr/CHANGES.txt modified , text changed
Directorylucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/AbstractDataImportHandlerTestCase.java modified , text changed
Directorylucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/AbstractSqlEntityProcessorTestCase.java modified , text changed
Directorylucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestFileListEntityProcessor.java modified , text changed
Directorylucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestSimplePropertiesWriter.java modified , text changed
Directorylucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestZKPropertiesWriter.java modified , text changed
Directorylucene/dev/trunk/solr/contrib/dataimporthandler-extras/src/java/org/apache/solr/handler/dataimport/MailEntityProcessor.java modified , text changed
Directorylucene/dev/trunk/solr/contrib/map-reduce/src/java/org/apache/solr/hadoop/TreeMergeOutputFormat.java modified , text changed
Directorylucene/dev/trunk/solr/contrib/map-reduce/src/test/org/apache/solr/hadoop/MorphlineGoLiveMiniMRTest.java modified , text changed
Directorylucene/dev/trunk/solr/contrib/map-reduce/src/test/org/apache/solr/hadoop/hack/MiniMRCluster.java modified , text changed
Directorylucene/dev/trunk/solr/contrib/map-reduce/src/test/org/apache/solr/hadoop/hack/MiniYARNCluster.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/cloud/LeaderInitiatedRecoveryThread.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/cloud/OverseerCollectionMessageHandler.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrCore.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/CdcrReplicatorState.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/IndexFetcher.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/SolrConfigHandler.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/component/DebugComponent.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/request/SolrQueryRequestBase.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/schema/ManagedIndexSchema.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/schema/OpenExchangeRatesOrgProvider.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/search/JoinQParserPlugin.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/search/join/ScoreJoinQParserPlugin.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/servlet/cache/HttpCacheHeaderUtil.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/store/blockcache/BlockCacheLocation.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/update/UpdateLog.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/update/VersionInfo.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/util/SimplePostTool.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/util/SolrLogLayout.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/util/TimeOut.java added
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/util/stats/Clock.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/java/org/apache/solr/util/xslt/TransformerProvider.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/DistributedIntervalFacetingTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/SolrInfoMBeanTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZkTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/CollectionsAPIDistributedZkTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/CollectionsAPISolrJTests.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/ConcurrentDeleteAndCreateCollectionTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/DeleteInactiveReplicaTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/DeleteLastCustomShardedReplicaTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/DeleteReplicaTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/DistribDocExpirationUpdateProcessorTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/HttpPartitionTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/LeaderInitiatedRecoveryOnCommitTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/MigrateRouteKeyTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/OverseerCollectionProcessorTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/OverseerRolesTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/SolrXmlInZkTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/TestRebalanceLeaders.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/UnloadDistributedZkTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/ZkCLITest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/hdfs/StressHdfsTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/core/OpenCloseCoreStressTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/core/TestCoreContainer.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/handler/TestBlobHandler.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/handler/admin/CoreAdminHandlerTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/request/TestWriterPerf.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/schema/AbstractCurrencyFieldTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/schema/OpenExchangeRatesOrgProviderTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/search/DocSetPerf.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/search/TestFastLRUCache.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/search/TestSearchPerf.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/search/TestSolrJ.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/search/function/TestFunctionQuery.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/servlet/CacheHeaderTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/servlet/NoCacheHeaderTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/update/AutoCommitTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/update/DirectUpdateHandlerTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/update/SoftAutoCommitTest.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/update/TestIndexingPerformance.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/util/BitSetPerf.java modified , text changed
Directorylucene/dev/trunk/solr/core/src/test/org/apache/solr/util/TestUtils.java modified , text changed
Directorylucene/dev/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java modified , text changed
Directorylucene/dev/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttpSolrClient.java modified , text changed
Directorylucene/dev/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/CloudSolrStream.java modified , text changed
Directorylucene/dev/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/ParallelStream.java modified , text changed
Directorylucene/dev/trunk/solr/solrj/src/java/org/apache/solr/common/cloud/RoutingRule.java modified , text changed
Directorylucene/dev/trunk/solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleTestsBase.java modified , text changed
Directorylucene/dev/trunk/solr/solrj/src/test/org/apache/solr/client/solrj/TestLBHttpSolrClient.java modified , text changed
Directorylucene/dev/trunk/solr/solrj/src/test/org/apache/solr/common/util/TestJavaBinCodec.java modified , text changed
Directorylucene/dev/trunk/solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java modified , text changed
Directorylucene/dev/trunk/solr/test-framework/src/java/org/apache/solr/cloud/ChaosMonkey.java modified , text changed
Directorylucene/dev/trunk/solr/test-framework/src/java/org/apache/solr/cloud/ZkTestServer.java modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26